- Devel - libvirt List Archives

[Libvir] [PATCH] Enable USB device setting information handling on virsh.
by Masayuki Sunou 29 Mar '07

29 Mar '07

Hi When domHVM started by virsh create, the information of USB setting is not saved by vish dumpxml. The reason is that USB setting is defined by Xen itself, not virsh. This patch enables USB device setting information handling on virsh create/virsh dumpxml. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou Index: libvirt/src/xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.99 diff -u -p -r1.99 xend_internal.c --- libvirt/src/xend_internal.c 6 Mar 2007 21:55:44 -0000 1.99 +++ libvirt/src/xend_internal.c 7 Mar 2007 08:28:55 -0000 @@ -1666,6 +1666,13 @@ xend_parse_sexp_desc(virConnectPtr conn, free(tty); } + tmp = sexpr_node(root, "domain/image/hvm/usbdevice"); + if ((tmp != NULL) && (tmp[0] != 0)) { + virBufferVSprintf(&buf, " <usb usbdevice='%s'/>\n", tmp); + } else if (sexpr_int(root, "domain/image/hvm/usb")) { + virBufferAdd(&buf, " <usb/>\n", 11 ); + } + virBufferAdd(&buf, " </devices>\n", 13); virBufferAdd(&buf, "</domain>\n", 10); Index: libvirt/src/xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.62 diff -u -p -r1.62 xml.c --- libvirt/src/xml.c 6 Mar 2007 20:00:17 -0000 1.62 +++ libvirt/src/xml.c 7 Mar 2007 08:28:55 -0000 @@ -524,6 +524,20 @@ virDomainParseXMLOSDescHVM(virConnectPtr } xmlXPathFreeObject(obj); + obj = xmlXPathEval(BAD_CAST "/domain/devices/usb", ctxt); + if ((obj != NULL) && (obj->type == XPATH_NODESET) && + (obj->nodesetval != NULL) && (obj->nodesetval->nodeNr == 1)) { + virBufferAdd(buf, "(usb 1)", 7); + xmlXPathFreeObject(obj); + obj = xmlXPathEval(BAD_CAST "string(/domain/devices/usb/@usbdevice)", ctxt); + if ((obj != NULL) && (obj->type == XPATH_STRING) && + (obj->stringval != NULL) && (obj->stringval[0] != 0)) { + virBufferVSprintf(buf, "(usbdevice '%s')", obj->stringval); + } + } + if (obj) + xmlXPathFreeObject(obj); + virBufferAdd(buf, "))", 2); if (boot_dev)

4 10

[Libvir] [PATCH] Python bindings now generate exceptions for libvirt errors
by Richard W.M. Jones 29 Mar '07

29 Mar '07

Following on from this thread: https://www.redhat.com/archives/libvir-list/2007-March/thread.html#00341 The first attachment is a patch which changes the generated Python bindings so that they always raise an exception when an underlying error occurs in the C libvirt library. The second attachment is for information only (not to be applied) - it shows the differences in the generated file libvirtclass.py. I have checked each of these changes by hand against both the libvirt.c interface description and the C implementation of the Python bindings (libvir.c and libvirt-py.c), and each change seems correct. I have _not_ tested this against virt-manager. It is quite possible that virt-manager will cease to work if it wasn't checking the return values from affected functions carefully. I'll check this later today and supply a patch (to virt-manager) if necessary. I have some additional questions about the Python bindings, but I'll put those in a separate thread. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

4 15

[Libvir] A couple of questions about the Python bindings
by Richard W.M. Jones 28 Mar '07

28 Mar '07

virDomainGetUUIDString, virDomainPinVcpu, virNetworkGetUUIDString: These functions don't seem to check whether the parameters are correct. For example, virDomainGetUUIDString doesn't check if the buffer parameter passed from Python is large enough to take the UUID string. virDomainPinVcpu is just plain strange (but I guess that strangeness eminates from the Xen implementation), but it seems possible for the Python code to be wrong about the length of the Vcpu map (string). Shouldn't the length be taken from the string itself? virDomainUndefine, virNetworkUndefine: It's unclear from the libvirt documentation, but it sounds as if these functions invalidate (free) the virDomainPtr / virNetworkPtr object passed to them. (In fact, the Xen implementation of virDomainPtr at least _doesn't_ free it - is that a bug?) If this is the case, then the Python bindings ought to set self._o = None. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)

3 2

[Libvir] [PATCH] Fix value of XEN_V2_OP_SETMAXMEM
by Masayuki Sunou 28 Mar '07

28 Mar '07

Hi Because the value of XEN_V2_OP_SETMAXMEM in xen_internal.c is wrong, virsh setmaxmem outputs error message. --> Both XEN_V2_OP_SETMAXMEM and XEN_V2_OP_GETVCPUINFO are set to 14, but XEN_V2_OP_SETMAXMEM should be set to 11. -------------------------------------------------------------------------------- # virsh setmaxmem 0 921600 libvir: Xen error : failed Xen syscall ioctl 8518692 -------------------------------------------------------------------------------- This patch sets the right value to XEN_V2_OP_SETMAXMEM. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: libvirt/src/xen_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xen_internal.c,v retrieving revision 1.67 diff -u -p -r1.67 xen_internal.c --- libvirt/src/xen_internal.c 23 Mar 2007 09:18:24 -0000 1.67 +++ libvirt/src/xen_internal.c 26 Mar 2007 00:09:35 -0000 @@ -280,7 +280,7 @@ typedef struct xen_v0_domainop xen_v0_do */ #define XEN_V0_OP_SETMAXMEM 28 #define XEN_V1_OP_SETMAXMEM 28 -#define XEN_V2_OP_SETMAXMEM 14 +#define XEN_V2_OP_SETMAXMEM 11 struct xen_v0_setmaxmem { domid_t domain; --------------------------------------------------------------------------------

2 3

[Libvir] [PATCH] Fix warn_unused_result when compiling with latest glibc
by Richard W.M. Jones 27 Mar '07

27 Mar '07

I'm not sure if this is the right way to solve this, but it is a way. Rich.

3 5

[Libvir] libvirt not compatible with Xen-unstable hypercall API ?
by Jerone Young 27 Mar '07

27 Mar '07

While trying to verify any potential problem between with libvirt & Xen PPC port. I've found that libvirt currently in CVS attempts to determine what hypercall version to follow, by looking at the hypervisior version. It determines that this is some arbitrary versioning "v2" of the hypercall api. This starts on line 1250 of xen_internal.c. This does not appear to be compatible with current Xen-Unstable from testing and trying to hack it up. Has any work been done toward making libvirt compatible with Xen-unstable that has not been included? Or is it waiting till the offical 3.0.5 release? We are attempting to ensure that Xen PPC works with libvirt. Though we have to use the latest hypercall api. Thanks, Jerone

4 5

[Libvir] [PATCH] pae/nonpae capabilities for paravirt xen guests
by David Lutterkort 27 Mar '07

27 Mar '07

I noticed that the guest capabilities on a xen dom0 always contain both the pae and nonpae feature - AFAIK, you can't mix pae/nonpae guests and hosts, and only one of the features should be there. The attached patch contains the obvious fix. David

4 5

[Libvir] don't clobber user-specified CFLAGS
by Jim Meyering 26 Mar '07

26 Mar '07

Building libvirt with CFLAGS=-g doesn't work as expected: gcc runs without -g. That was due to the following assignment that gives CFLAGS the value of an undefined variable. 2007-03-23 Jim Meyering <jim(a)meyering.net> * acinclude.m4: Remove bogus CFLAGS=$undefined_var assignment that would clobber any CFLAGS setting from e.g., ./autogen.sh CFLAGS=-g. Reported by David Lutterkort. Index: acinclude.m4 =================================================================== RCS file: /data/cvs/libvirt/acinclude.m4,v retrieving revision 1.3 diff -u -p -r1.3 acinclude.m4 --- acinclude.m4 21 Mar 2007 15:22:31 -0000 1.3 +++ acinclude.m4 23 Mar 2007 18:52:55 -0000 @@ -59,8 +59,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ unset option unset try_compiler_flags - CFLAGS="$realsave_CFLAGS" - AC_ARG_ENABLE(iso-c, AC_HELP_STRING([--enable-iso-c], [Try to warn if code is not ISO C ]),,

2 1

[Libvir] [PATCH] Add the message when a little memory is set with setmaxmem.
by Masayuki Sunou 26 Mar '07

26 Mar '07

Hi The message which a cause of an error is hard to detect is displayed when "virsh setmaxmem" sets the maximum memory of an active domain less than Used Memory. -------------------------------------------------------------------------------- # virsh setmaxmem 0 4096 libvir: Xen error : failed Xen syscall ioctl 8518692 libvir: Xen Daemon error : POST operation failed: (xend.err "(22, 'Invalid argument')") libvir: error : library call virDomainSetMaxMemory failed, possibly not supported -------------------------------------------------------------------------------- This patch displays the message which is easier to detect the cause of an error to a user. -------------------------------------------------------------------------------- # virsh setmaxmem 0 4096 error: 4096 is less than current used memory. -------------------------------------------------------------------------------- Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: libvirt/src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.67 diff -u -p -r1.67 virsh.c --- libvirt/src/virsh.c 20 Mar 2007 15:31:46 -0000 1.67 +++ libvirt/src/virsh.c 22 Mar 2007 02:27:16 -0000 @@ -1493,6 +1493,7 @@ static int cmdSetmaxmem(vshControl * ctl, vshCmd * cmd) { virDomainPtr dom; + virDomainInfo info; int bytes; int ret = TRUE; @@ -1509,6 +1510,18 @@ cmdSetmaxmem(vshControl * ctl, vshCmd * return FALSE; } + if (virDomainGetID(dom) != ((unsigned int)-1)) { + if (virDomainGetInfo(dom, &info) != 0) { + virDomainFree(dom); + return FALSE; + } + if (bytes < info.memory) { + vshError(ctl, FALSE, _("%d is less than current used memory."), bytes); + virDomainFree(dom); + return FALSE; + } + } + if (virDomainSetMaxMemory(dom, bytes) != 0) { ret = FALSE; } --------------------------------------------------------------------------------

2 3

[Libvir] sprintf cleanup patch
by Daniel Veillard 24 Mar '07

24 Mar '07

Sprintf is potentially dangerous, so I replaced all instances with snprintf (even in cases where the usage was garanteed to be safe to have a coherent approach). Pending patch appended, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 1