- Devel - libvirt List Archives

[Libvir] [PATCH] Fix memory leak on virDomainParseXMLDiskDesc()
by Masayuki Sunou 11 Jul '07

11 Jul '07

Hi I found some memory leaks in xml.c --> Missing release of drvType and drvName in virDomainParseXMLDiskDesc(). This patch fixes it. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: src/xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.80 diff -u -p -r1.80 xml.c --- src/xml.c 4 Jul 2007 09:16:23 -0000 1.80 +++ src/xml.c 11 Jul 2007 07:51:17 -0000 @@ -719,6 +719,7 @@ virDomainParseXMLDiskDesc(virConnectPtr int typ = 0; int cdrom = 0; int isNoSrcCdrom = 0; + int ret = 0; type = xmlGetProp(node, BAD_CAST "type"); if (type != NULL) { @@ -768,21 +769,14 @@ virDomainParseXMLDiskDesc(virConnectPtr } if (!isNoSrcCdrom) { virXMLError(conn, VIR_ERR_NO_SOURCE, (const char *) target, 0); - - if (target != NULL) - xmlFree(target); - if (device != NULL) - xmlFree(device); - return (-1); + ret = -1; + goto cleanup; } } if (target == NULL) { virXMLError(conn, VIR_ERR_NO_TARGET, (const char *) source, 0); - if (source != NULL) - xmlFree(source); - if (device != NULL) - xmlFree(device); - return (-1); + ret = -1; + goto cleanup; } /* Xend (all versions) put the floppy device config @@ -861,12 +855,17 @@ virDomainParseXMLDiskDesc(virConnectPtr virBufferAdd(buf, ")", 1); cleanup: - xmlFree(drvType); - xmlFree(drvName); - xmlFree(device); - xmlFree(target); - xmlFree(source); - return (0); + if(drvType) + xmlFree(drvType); + if(drvName) + xmlFree(drvName); + if(device) + xmlFree(device); + if(target) + xmlFree(target); + if(source) + xmlFree(source); + return (ret); } /**

3 2

[Libvir] Howto: install libvirt on Debian Etch (the ugly way)
by Roman Ammann 11 Jul '07

11 Jul '07

Hello list I read on the list that other people tried to install libvirt on Debian Etch. I finally succeeded so I'll post a little Howto. Maybe someone with a better understanding of automake and C stuff knows a nicer way but the ugly folder with the links to the different header files. The start point is a Debian Etch with a running Xen (in my case it's the xen-hypervisor-3.0.3-1-i386-pae package). If you're not using the PAE version of the xen-hypervisor change the "apt-get source" line accordingly. First you will need to install a bunch of development packages apt-get install build-essential libxml2-dev libncurses5-dev apt-get isntall libreadline5-dev python-dev Go to your home directory and install the Xen hypervisor sources cd apt-get source xen-hypervisor-3.0.3-1-i386-pae Create a folder with a bunch of symbolic links. We will use this folder libvirt to find the header files. mkdir libvirt-include cd libvirt-include/ ln -s /root/xen-3.0-3.0.3-0/xen/include/public/xen.h ln -s /root/xen-3.0-3.0.3-0/tools/xenstore/xs.h ln -s /root/xen-3.0-3.0.3-0/tools/xenstore/xs_lib.h ln -s /root/xen-3.0-3.0.3-0/xen/include/public xen ln -s /root/xen-3.0-3.0.3-0/linux-2.6-xen-sparse/include/xen/public/ xen/linux Configure the dynamic linker that it will be able to find the libxenstore library echo '/usr/lib/xen-3.0.3-1/lib' > /etc/ld.so.conf.d/i486-linux-gnu.conf ldconfig Go to your home directory, download an extract the libvirt source package cd wget http://libvirt.org/sources/libvirt-0.2.3.tar.gz tar xvfz libvirt-0.2.3.tar.gz cd libvirt-0.2.3 Configure, build and install the libvirt CFLAGS="-fno-stack-protector -I/root/libvirt-include -L/usr/lib/xen-3.0.3-1/lib" ./configure --with-xen --without-qemu make make install Enable the Unix socket server for xend. Edit /etc/xen/xend-config.sxp and change the line #(xend-unix-server no) to (xend-unix-server yes) Restart your Xen-Daemon /etc/init.d/xend restart If everything work you should see your running virtual machines when you enter virsh list Regards Roman

4 3

[Libvir] Updating an existing libvirt installation
by Omer Khalid 11 Jul '07

11 Jul '07

Hi, I am wondering if its possible to upgrade an existing libvirt installation to a newer version. Actually one of my clients is still have libvirt-0.1.8while my software works ver 0.1.9 upwards. Many thanks for your help, Cheers Omer -- ---------------------------------------------------------- CERN – European Organization for Nuclear Research, IT Department, CH-1211 Geneva 23, Switzerland Phone: +41 (0) 22 767 2224 Fax: +41 (0) 22 766 8683 E-mail : Omer.Khalid(a)cern.ch Homepage: http://cern.ch/Omer.Khalid

4 4

[Libvir] Release of libvirt-0.3.0
by Daniel Veillard 09 Jul '07

09 Jul '07

Considering the amount of changes available in CVS, a release was in order plus increasing the minor release number was also making sense. The package is available at ftp://libvirt.org/libvirt/ The main change is the secure remote support at the API level thanks to Richard Jones, look at the specific page to get informations on what is available and how to set up the certificates needed for authentication: http://libvirt.org/remote.html it's worth also looking at the URI documentation to see how to build the connection URI strings http://libvirt.org/uri.html Last thing, the background daemon has been renamed between versions 0.2.3 and the current version from libvirt_qemud to libvirtd since it now also serve for the remote support, so when upgrading the package it's a good idea to stop first the libvirt service, do the upgrade and then restart the service otherwise you may end up with a old version of the daemon running. This release includes a lot of changes: + Secure Remote support (Richard Jones). See the remote page of the documentation + Documentation: - remote support (Richard Jones) - description of the URI connection strings (Richard Jones) - update of virsh man page - matrix of libvirt API/hypervisor support with version informations (Richard Jones) + Bug fixes: - examples Makefile.am generation (Richard Jones) - SetMem fix (Mark Johnson) - URI handling and ordering of drivers (Daniel Berrange) - fix virsh help without hypervisor (Richard Jones) - id marshalling fix (Daniel Berrange) - fix virConnectGetMaxVcpus on remote (Richard Jones) - avoid a realloc leak (Jim Meyering) - scheduler parameters handling for Xen (Richard Jones) - various early remote bug fixes (Richard Jones) - remove virsh leaks of domains references (Masayuki Sunou) - configCache refill bug (Richard Jones) - fix XML serialization bugs + Improvements: - QEmu switch to XDR-based protocol (Dan Berrange) - device attach/detach commands (Masayuki Sunou) - OCaml bindings (Richard Jones) - new entry points virDomainGetConnect and virNetworkGetConnect useful for bindings (Richard Jones) - reunitifaction of remote and qemu daemon under a single libvirtd with a config file (Daniel Berrange) + Cleanups: - parsing of connection URIs (Richard Jones) - messages from virsh (Saori Fukuta) - Coverage files (Daniel Berrange) - Solaris fixes (Mark Johnson) - avoid [r]index calls (Richard Jones) - release information in Xen backend - virsh cpupin command cleanups (Masayuki Sunou) - xen:/// suppport as standard Xen URI (Richard Jones and Daniel Berrange) - improve driver selection/decline mechanism (Richard Jones) - error reporting on XML dump (Richard Jones) - Remove unused virDomainKernel structure (Richard Jones) - daemon event loop event handling (Daniel Berrange) - various unifications cleanup in the daemon merging (Daniel Berrange) - internal file and timer monitoring API (Daniel Berrange) - remove libsysfs dependancy - call brctl program directly (Daniel Berrange) - virBuffer functions cleanups (Richard Jones) - make init script LSB compliant - error handling on lookup functions (Richard Jones) - remove internal virGetDomainByID (Richard Jones) - revamp of xen subdrivers interfaces (Richard Jones) + Localization updates Thanks to everybody who helped for this release, with code, bug reports or suggestions ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] XML escaping patch
by Daniel Veillard 07 Jul '07

07 Jul '07

This is related to bug #206653 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206653 basically we are very optimistic when generating the XML files, and sometimes this can break. The most common case is if some string inherited from the user input or some other config file embeds one of > < or & , another one would be if the strings are containing character outside of ACSII range and not encoded in UTF-8. We can at least cope with the easy case of escaping the 3 characters. This patch adds a simple buffer printing routing working with a simple string argument, and use it for the 2 cases where I think it's most likely to be needed i.e. cmdline and bootloader_args. There is a number of places where paths are used and the user might use weird character names, but since those cases can't be handled properly (you can't change that path or try to convert encoding on the fly since we can't guess reliably which one is used) I didn't tried to change those. This makes for a relatively simple patch which should IMHO cover most case where we may break while we really should not. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

3 7

[Libvir] Some doubts for OpenVZ
by Shuveb Hussain 06 Jul '07

06 Jul '07

Hi, I have some basic doubts. 1. The OpenVZ system has one config file per VM which contains all the VM's parameters. So, during libvirt start-up, these files can be read, or openvz utils can be popened() to get information regarding these VMs. Is there a necessity to have per-vm config files in libvirt for the OpenVZ VMs? I understand UUIDs are used to identify each of the running VMs. Where will these values persist? Can I do away with UUIDs for OpenVZ and avoid the libvirt specific config file? 2. In OpenVZ, there is just a VPS ID/Name. There is no temporary reference like 'id'. For example QEMU is using the process PID. There is no such notion for OpenVZ. In that case, can I make 'name' and 'id' same for OpenVZ? Thanks, -- Shuveb Hussain Unix is very user friendly. It is just a little choosy about who its friends are http://www.binarykarma.com

3 5

[Libvir] virsh vcpupin does not work with xend
by Saori Fukuta 06 Jul '07

06 Jul '07

Hi, The virsh vcpupin command does not work when it uses Xend(xend_internal.c). HV(xen_internal.c) works fine. I'm testing on Xen3.1.0(hypervisor_version=2, dom_interface_version=5, xendConfigVersion=4), and using current libvirt(ChangeLog revision 1.546). To solve this problem, I got the xend debug information and compared that. * in the case of executing "virsh vcpupin 63 7 1" * [2007-05-29 09:33:20 4258] DEBUG (XendDomain:1297) dom(63) cpu 7 cpumap [1](<type'str'>) * in the case of executing "xm vcpu-pin 63 7 1" * [2007-05-29 09:33:32 4258] DEBUG (XendDomain:1297) dom(63) cpu 7 cpumap [1](<type'list'>) There is one different thing. The type of cpumap is str when executing virsh command, but the type of cpumap is list when executing xm command. Do you have any idea ? Thanks, Saori Fukuta

2 4

[Libvir] LSBization of libvirt init script
by Daniel Veillard 06 Jul '07

06 Jul '07

Small patch applied to qemud/libvirtd.init.in: - adds an LSB compliant header - add a couple of LSB defined functions - fixes the name in the chkconfig comments Hopefully it's correct :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 2

[Libvir] [Q]Will virConnectNumOfNetworks and virConnectNumOfDefinedNetworks be supported by Xen ?
by S.Sakamoto 06 Jul '07

06 Jul '07

Hi, When I use virt-manager that is connected by xen, the following error is given at every monitoring. libvir: Error : this function is not supported by the hypervisor: virConnectNumOfNetworks libvir: Error : this function is not supported by the hypervisor: virConnectNumOfDefinedNetworks Therefore I have a question. Will virConnectNumOfNetworks and virConnectNumOfDefinedNetworks be supported by Xen ? When is it if supported ? Thanks, Shigeki Sakamoto.

4 8

Re: [Libvir] [RFC]OpenVZ XML def
by Richard W.M. Jones 05 Jul '07

05 Jul '07

Shuveb Hussain wrote: [...] OK, but still let us know if there are particular things which are a problem to parse. Also if you can just follow-up sometime with example output from OpenVZ commands. I'd like to see that, since I tried to get OpenVZ working on my machine, but it broke down (unrelated to OpenVZ :-) Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0