- Devel - libvirt List Archives

[Libvir] PATCH: Check for bogus default architecture
by Daniel P. Berrange 31 Jul '07

31 Jul '07

There was a missing check in the QEMU driver for a bogus architecture in the XML which could cause a crash. This wasn't a problem except for the fact that another bug in my recent virt-install 0.200.0 release passed a bogus architecture on 32-bit platforms :-( Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] PATCH: Overhaul the test driver
by Daniel P. Berrange 31 Jul '07

31 Jul '07

The test driver has suffered from quite alot of bitrot. Its got all sorts of checks in the driver entry points already done by libvirt.c, its got private data, redundantly pointing to private data, it doesn't implement any of the networking APIs, is missing alot of the newer domain APIs. So I've given it a thorough overhaul to remove alot of redundant code, clean up more, and add entry points for all the APIs except for VCPU pinning ones. The addition of the networking APIs means we no longer get errors thrown when trying to run tests without the libvirt daemon running, and means apps can actually do tests for their networking capabilities. docs/testnetdef.xml | 12 docs/testnetpriv.xml | 11 docs/testnode.xml | 2 src/driver.h | 1 src/libvirt.c | 17 src/qemu_driver.c | 1 src/remote_internal.c | 1 src/test.c | 1892 +++++++++++++++++++++++++++++++------------------- tests/virshtest.c | 465 +++--------- 9 files changed, 1382 insertions(+), 1020 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] PATCH Fix a couple of mem leaks
by Daniel P. Berrange 31 Jul '07

31 Jul '07

I ran 'make valgrind' for the first time in too long and found a hanful of memory leaks in code exercised by the test suite. The attached patch fixes them all. I'm sure there are more lurking though - the test suite is mainly focused on exercising & validating correctness of parsing routines - its not really tried doing any validation of failure scenaarios. So I fear there's probably a number of error code paths where we don't cleanup properly, and/or don't reject invalid data. Its an area which should be addressed by someone with some copious free time ;-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] PATCH 0/2: Capabilities and features
by David Lutterkort 30 Jul '07

30 Jul '07

Hi, these two patches extend the features libvirt reports in the capabilities XML; in particular, features are now reported for the QEMU driver, and features for both Xen and QEMU include information on ACPI/APIC support. Tools that rely on feature reporting, in general, need to know whether a certain feature is on or off by default, and whether that can be toggled, because users will be asking for one of three things for their VM: * Feature X (e.g., ACPI) must be on/present in the VM * Feature X must not be on/present in the VM * It doesn't matter whether feature X is there or not For example, in QEMU, ACPI is on by default, but can be turned off. The APIC on the other hand, is always there and can't be turned off. That is now reported as <features> <acpi default="on" toggle="yes"/> <apic default="on" toggle="no"/> </features> It's unfortunate that the format for PAE (<pae/> vs. <nonpae/>) reporting doesn't fit into this scheme. I didn't want to start with having tags <X/> and <nonX/> for each feature; that means that parsers need to special case PAE. It's probably too late, but it would be nice if PAE was reported in a similar format, with <pae> correponding to <pae default="on" toggle="no"/>, <nonpae/> corresponding to <pae default="yes" toggle="no"/>, and having both together corresponding to <pae default="yes" toggle="yes"/>, but that's a separate discussion from these patches. David

4 12

[Libvir] [PATCH] virsh Range check in Credit Scheduler
by Atsushi SAKAI 30 Jul '07

30 Jul '07

Hi, Add Range check in Credit Scheduler. Signed-off-by: Atsushi SAKAI <sakaia(a)jp.fujitsu.com> Thanks Atsushi SAKAI

6 20

[Libvir] [PATCH] add a ttyconsole command
by Daniel Veillard 26 Jul '07

26 Jul '07

It was pointed out that we have a vncdisplay command but none for extracting the TTY console device: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239687 the trivial associated patch adds it as well as the doc in the man page Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

3 4

[Libvir] PATCH: Separate QEMU impl of nodeinfo API
by Daniel P. Berrange 26 Jul '07

26 Jul '07

While fixing the QEMU nodeinfo API to correctly deal with case where CPU sockets have sparse numbering (eg sockets 0 & 3 are populated), I realized that OpenVZ doesn't have a nodeinfo API, and its requirements are basically identical to the QEMU driver's. So this patch moves the impl of the nodeinfo API into a nodeinfo.c file, and makes both the QEMU and OpenVZ driver call out to this shared impl. I also put #ifdef __linux__ around the impl since code reading /proc/cpuinfo is never going to work on any non-Linux platform. For non linux I just return -1 which'll get treated as not-implemented. If QEMU driver is ported to work on Solaris, the nodeinfo.c file can be easily extended for their custom impl. Finally I'm adding a testcase with a bunch of example /proc/cpuinfo files to validate correctness Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] [PATCH] Python bindings: Use virDomain/NetworkGetConnect instead of storing connection in domain/network object
by Richard W.M. Jones 25 Jul '07

25 Jul '07

Previously[1] I patched libvirt to add the virDomainGetConnect and virNetworkGetConnect functions. The rationale for these is explained here[2]. The attached patch makes the Python bindings use these functions instead of storing the connection object explicitly. Rich. [1]https://www.redhat.com/archives/libvir-list/2007-June/msg00365.html [2]https://www.redhat.com/archives/libvir-list/2007-June/msg00352.html

3 8

[Libvir] Release of libvirt-0.3.1
by Daniel Veillard 25 Jul '07

25 Jul '07

Quite a few things were fixed since 0.3.0, and it was looking like a new release at this point would be a good idea. Availbale at ftp://libvirt.org/libvirt/ * Documentation: - index to remote page - script to test certificates - IPv6 remote support docs (Daniel Berrange) - document VIRSH_DEFAULT_CONNECT_URI in virsh man page (David Lutterkort) - Relax-NG early grammar for the network XML (David Lutterkort) * Bug fixes: - leaks in disk XML parsing (Masayuki Sunou) - hypervisor alignment call problems on PPC64 (Christian Ehrhardt) - dead client registration in daemon event loop (Daniel Berrange) - double free in error handling (Daniel Berrange) - close on exec for log file descriptors in the daemon (Daniel Berrange) - avoid caching problem in remote daemon (Daniel Berrange) - avoid crash after QEmu domain failure (Daniel Berrange) * Improvements: - checks of x509 certificates and keys (Daniel Berrange) - error reports in the daemon (Daniel Berrange) - checking of Ethernet MAC addresses in XML configs (Masayuki Sunou) - support for a new clock switch between UTC and localtime (Daniel Berrange) - early version of OpenVZ support (Shuveb Hussain) - support for input devices on PS/2 and USB buses (Daniel Berrange) - more tests especially the QEmu support (Daniel Berrange) - range check in credit scheduler (with Saori Fukuta and Atsushi Sakai) - add support for listen VNC parameter un QEmu and fix command line arg (Daniel Berrange) * Cleanups: - debug tracing (Richard Jones) - removal of --with-qemud-pid-file (Richard Jones) - remove unused virDeviceMode - new util module for code shared between drivers (Shuveb Hussain) - xen header location detection (Richard Jones) thanks to everybody who helped for this release, with bug reports or patches ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] PATCH: Make QEMU driver honour 'listen' flag for VNC
by Daniel P. Berrange 25 Jul '07

25 Jul '07

In QEMU 0.9.0 or later it is possible to tell QEMU to only listen on a particular IP address. THis patch adapts the code so that it honours the 'listen' attribute on the <graphics> tag if using QEMU >= 0.9.0. It also re-enables the tests for this capability that I temporarily disabled. src/qemu_conf.c | 37 +++++++++++++----- src/qemu_conf.h | 1 tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.args | 2 tests/qemuxml2argvtest.c | 4 - tests/qemuxml2xmltest.c | 2 5 files changed, 32 insertions(+), 14 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 5