- Devel - libvirt List Archives

[Libvir] [PATCH]OpenVZ Enhancements - Cleaned up
by Shuveb Hussain 04 Sep '07

04 Sep '07

Hi, Attached are the OpenVZ driver enhancements. Cleanups have been done according to Daniel .V's suggestions. Please see my previous mail for summary. Cheers, Shuveb Hussain http://www.binarykarma.com

2 2

[Libvir] libvirt on Windows
by Ronald Long 31 Aug '07

31 Aug '07

I am trying to talk to a 4.0.1 Xen Hypervisor (not Xen underneath a Linux Distro) (via Python) from a Windows box. (Am able to successfully connect and communicate using the Xen API Python bindings). Looks like at the very least I need to build libvirtmon.la from the c sources. Am I just dealing with "beginneritis", or trying to do something (run from Windows) that hasn't been done before? thanks ronald

2 1

[Libvir] Ruby bindings for libvirt
by Meng Kuan 31 Aug '07

31 Aug '07

Hi, I am exploring the possibility of creating ruby bindings for libvirt. The only attempt I found after some searching is this: http://www.cs.ucsb.edu/~ckrintz/racelab/jisha/ Following the SWIG method as described in the above URL, I have gotten to the following point: [root@dell1 libvirt_ruby]# irb irb(main):001:0> require 'libvirt_ruby' => true irb(main):002:0> conn = Libvirt_ruby.virConnectOpenReadOnly("") => #<SWIG::TYPE_p__virConnect:0x2aaaaabc46c8> irb(main):003:0> dom = Libvirt_ruby.virDomainLookupByID(conn, 0) => #<SWIG::TYPE_p__virDomain:0x2aaaaabb5df8> irb(main):004:0> ret = Libvirt_ruby.virDomainGetInfo(dom, info) NameError: undefined local variable or method `info' for main:Object from (irb):4 irb(main):005:0> I am not sure how to create and pass in a ptr to a virDomainInfo struct object into the virDomainGetInfo call within ruby. Note that I was trying to following the info1.c example on the libvirt website: http://libvirt.org/examples/info1.c As you can tell, this is the first time I am trying to create any sort of language bindings for a C library. Some questions: 1. Is there a better way of creating ruby bindings for libvirt besides SWIG? If so, any pointers on what should be done? 2. Alternatively I can try to make my ruby code use libvirt-python bindings as a python library. Has anyone done so? Any problems with this approach? cheers, mengkuan

3 4

[Libvir] --without-*
by Mark Johnson 31 Aug '07

31 Aug '07

Hi all, Merging up to 0.3.2 on Solaris finally.. I had a couple of things on my list of hacked patches, and not being a configure expert I figured I would ask here... How hard it is to change the config logic to account for the various --without's. e.g. --without-qemu, o ./Makefile.in - SUBDIRS shouldn't include qemud o ./src/Makefile.in o am__objects_1 shouldn't include: o libvirt_la-bridge.lo o libvirt_la-iptables.lo o libvirt_la-qemu_driver.lo o libvirt_la-qemu_conf.lo o client sources, build rules, etc for the above. --without-test (Incuding srcs, rules, etc) o libvirt_la-test.lo, etc... --without-xen (Incuding srcs, rules, etc) o libvirt_la-xen_internal.lo o libvirt_la-xs_internal.lo o libvirt_la-xend_internal.lo --without-remote (Incuding srcs, rules, etc) o libvirt_la-remote_internal.lo o am_libvirt_la_OBJECTS shouldn't include am__objects_2 One other thing I was curious about... I noticed the remote code uses remote_protocol* out of the ./qemud dir.. I was just curious if I should expect that to move somewhere else soon, or if you were going to leave it there? Thanks, Mark.

2 2

[Libvir] [PATCH] Fix endless loop of VirBufferVSprintf()
by Masayuki Sunou 30 Aug '07

30 Aug '07

Hi VirBufferVSprintf() loops endless when it receives over 2000 bytes, because the return value of vsnprintf() is more than "size - 1". It is because the maximum of "size" is 1999 bytes. --> the maximum of "buf->size - buf->use" = 2000 (1000(argument of virBufferGrow()) + 1000(set in virBufferGrow())) So, virBufferEscapeString() has the same problem. This patch sets to virBufferGrow() the size of the data which VirBufferVSprintf()(virBufferEscapeString()) received when it is over 1000 bytes. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: src/buf.c =================================================================== RCS file: /data/cvs/libvirt/src/buf.c,v retrieving revision 1.3 diff -u -p -r1.3 buf.c --- src/buf.c 9 Jul 2007 11:24:52 -0000 1.3 +++ src/buf.c 24 Aug 2007 05:56:37 -0000 @@ -159,7 +159,7 @@ virBufferContentAndFree (virBufferPtr bu int virBufferVSprintf(virBufferPtr buf, const char *format, ...) { - int size, count; + int size, count, grow_size; va_list locarg, argptr; if ((format == NULL) || (buf == NULL)) { @@ -172,7 +172,8 @@ virBufferVSprintf(virBufferPtr buf, cons locarg)) < 0) || (count >= size - 1)) { buf->content[buf->use] = 0; va_end(locarg); - if (virBufferGrow(buf, 1000) < 0) { + grow_size = (count > 1000) ? count : 1000; + if (virBufferGrow(buf, grow_size) < 0) { return (-1); } size = buf->size - buf->use - 1; @@ -198,7 +199,7 @@ virBufferVSprintf(virBufferPtr buf, cons int virBufferEscapeString(virBufferPtr buf, const char *format, const char *str) { - int size, count, len; + int size, count, len, grow_size; char *escaped, *out; const char *cur; @@ -248,7 +249,8 @@ virBufferEscapeString(virBufferPtr buf, while (((count = snprintf(&buf->content[buf->use], size, format, (char *)escaped)) < 0) || (count >= size - 1)) { buf->content[buf->use] = 0; - if (virBufferGrow(buf, 1000) < 0) { + grow_size = (count > 1000) ? count : 1000; + if (virBufferGrow(buf, grow_size) < 0) { free(escaped); return (-1); } ----------------------------------------------------------------------

2 2

[Libvir] ANNOUNCE: virt-top 0.3.2.5 released
by Richard W.M. Jones 30 Aug '07

30 Aug '07

I'm pleased to announce a new release of virt-top, which is a utility like 'top' that works for virtual machines. Many keys and command line options are the same as for ordinary top. Thanks to all the people who have been playing with it and sending me feedback. This version adds block device and network statistics (if supported by the hypervisor and libvirt). This version also fixes a bug where it would fail silently if unable to contact the hypervisor. Main page: http://et.redhat.com/~rjones/virt-top/ Source and binaries for several architectures available from: http://et.redhat.com/~rjones/virt-top/download.html If you have Fedora 7, this will probably work: yum --enablerepo=development install virt-top Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] [PATCH] TX/RX network stats are swapped
by Richard W.M. Jones 29 Aug '07

29 Aug '07

I noticed that the stats reported by virDomainInterfaceStats appeared to be swapped around. If the domain was downloading a lot of information, then tx_bytes would increase quickly (I'd expect rx_bytes to increase more if the domain was downloading). The problem is that xen_internal.c measures the TX/RX from the point of view of dom0. So that if dom0 is TRANSMITTING a lot of data up to the domain, then that domain is really RECEIVING it. Yes, I feel like an idiot ... Fix attached. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 1

[Libvir] [PATCH] Block device and network stats (version 2)
by Richard W.M. Jones 29 Aug '07

29 Aug '07

This patch adds block device and network stats. The main changes over the previous version are: * Remote support. * Change Xen network interface names to have the form "vif<domid>.<n>"[1]. Discussions about the previous version may be found starting here: https://www.redhat.com/archives/libvir-list/2007-August/thread.html#00064 I have left use of stdint.h / int64_t, since it wasn't clear to me what conclusion people had arrived at. I left the explicit structure size parameter to allow for future extensibility. Also attached is the output of: virsh -c xen+tls://amd/ domifstat fc6_1 vif2.0 Rich. [1] There is currently no way to get the interface name except to just know it -- that is the subject of a separate patch. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903 libvirt: virConnectOpen (name=xen+tls://amd/) libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: virInitialize () libvirt: do_open: proceeding with name=xen+tls://amd/ libvirt: do_open: trying driver 0 (Test) ... libvirt: do_open: driver 0 Test returned DECLINED libvirt: do_open: trying driver 1 (QEMU) ... libvirt: do_open: driver 1 QEMU returned DECLINED libvirt: do_open: trying driver 2 (Xen) ... libvirt: do_open: driver 2 Xen returned DECLINED libvirt: do_open: trying driver 3 (remote) ... libvirt: do_open: driver 3 remote returned SUCCESS libvirt: do_open: network driver 0 Test returned DECLINED libvirt: do_open: network driver 1 QEMU returned DECLINED libvirt: do_open: network driver 2 remote returned SUCCESS libvirt: virDomainLookupByName (conn=0x130ee020, name=fc6_1) libvirt: virDomainInterfaceStats (domain=0x13129bd0, path=vif2.0, stats=0x7fff688e6e20, size=64) libvirt: virDomainFree (domain=0x13129bd0) libvirt: virConnectClose (conn=0x130ee020) vif2.0 rx_bytes 18591 vif2.0 rx_packets 113 vif2.0 rx_errs 0 vif2.0 rx_drop 0 vif2.0 tx_bytes 125319 vif2.0 tx_packets 962 vif2.0 tx_errs 0 vif2.0 tx_drop 0

5 17

[Libvir] [PATCH] Fix return value of virsh vncdisplay
by Masayuki Sunou 29 Aug '07

29 Aug '07

Hi Virsh vncdisplay always returns 1, because return value is not set in the case of normal end. ------------------------------------ # virsh vncdisplay test :0 # echo $? 1 ------------------------------------ This patch fixes it. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: libvirt/src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.100 diff -u -p -r1.100 virsh.c --- libvirt/src/virsh.c 21 Aug 2007 11:53:52 -0000 1.100 +++ libvirt/src/virsh.c 28 Aug 2007 06:33:03 -0000 @@ -2919,6 +2919,7 @@ cmdVNCDisplay(vshControl * ctl, vshCmd * } xmlXPathFreeObject(obj); obj = NULL; + ret = TRUE; cleanup: if (obj) ----------------------------------------------------------------------

2 1

[Libvir] [PATCH] Delete a harmful variable in xend_parse_sexp_desc()
by Masayuki Sunou 27 Aug '07

27 Aug '07

Hi Xend_parse_sexp_desc() of xend_internal.c declares a variable named "ret" to buffer SXP. However, it actually uses "buf.content" not "ret" and allocates memory to "buf" when size of "ret" became insufficient. --> virBufferAdd(&buf, ...);, virBufferVSprintf(&buf, ...) So freeing "ret" fails, because "ret" refers to an address unlike "buf.contents" As a result, a segmentation fault occurs. This patch fixes so that xend_parse_sexp_desc() uses "buf.contents" not "ret". Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. -------------------------------------------------------------------------------- Index: src/xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.135 diff -u -p -r1.135 xend_internal.c --- src/xend_internal.c 21 Aug 2007 09:31:12 -0000 1.135 +++ src/xend_internal.c 27 Aug 2007 07:47:03 -0000 @@ -1346,7 +1346,6 @@ xend_parse_sexp_desc_os(virConnectPtr xe static char * xend_parse_sexp_desc(virConnectPtr conn, struct sexpr *root, int xendConfigVersion) { - char *ret; struct sexpr *cur, *node; const char *tmp; char *tty; @@ -1362,10 +1361,9 @@ xend_parse_sexp_desc(virConnectPtr conn, /* ERROR */ return (NULL); } - ret = malloc(4000); - if (ret == NULL) + buf.content = malloc(4000); + if (buf.content == NULL) return (NULL); - buf.content = ret; buf.size = 4000; buf.use = 0; @@ -1762,11 +1760,11 @@ xend_parse_sexp_desc(virConnectPtr conn, virBufferAdd(&buf, "</domain>\n", 10); buf.content[buf.use] = 0; - return (ret); + return (buf.content); error: - if (ret != NULL) - free(ret); + if (buf.content != NULL) + free(buf.content); return (NULL); } --------------------------------------------------------------------------------

2 1