- Devel - libvirt List Archives

[libvirt] [PATCH] avoid format string warnings
by Jim Meyering 11 Dec '08

11 Dec '08

* src/openvz_conf.c (openvzGetNodeCPUs): Add "%s" arg before _(...). * src/uml_driver.c (umlDomainBlockPeek): Likewise. --- src/openvz_conf.c | 2 +- src/uml_driver.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/openvz_conf.c b/src/openvz_conf.c index fc4ef20..1361c53 100644 --- a/src/openvz_conf.c +++ b/src/openvz_conf.c @@ -466,7 +466,7 @@ openvzGetNodeCPUs(void) if (virNodeInfoPopulate(NULL, &nodeinfo) < 0) { openvzError(NULL, VIR_ERR_INTERNAL_ERROR, - _("Cound not read nodeinfo")); + "%s", _("Cound not read nodeinfo")); return 0; } diff --git a/src/uml_driver.c b/src/uml_driver.c index 9c0d9c4..408096e 100644 --- a/src/uml_driver.c +++ b/src/uml_driver.c @@ -1764,13 +1764,13 @@ umlDomainBlockPeek (virDomainPtr dom, if (!vm) { umlReportError (dom->conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, - _("no domain with matching uuid")); + "%s", _("no domain with matching uuid")); goto cleanup; } if (!path || path[0] == '\0') { umlReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, - _("NULL or empty path")); + "%s", _("NULL or empty path")); goto cleanup; } @@ -1807,7 +1807,7 @@ umlDomainBlockPeek (virDomainPtr dom, ret = 0; } else { umlReportError (dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, - _("invalid path")); + "%s", _("invalid path")); } cleanup: -- 1.6.0.4.1044.g77718

2 2

[libvirt] PATCH 0/5: connection cloning support (WIP)
by Daniel P. Berrange 10 Dec '08

10 Dec '08

This series is a work-in-progress set of patches implementing connection cloning. The idea is that if you want to use a connection form multiple threads, you could do virConnectPtr copy = virConnectClone(conn) and use 'copy' from the other thread. This avoids the problem of having to make all the virError handling stuff thread-local whic is the blocker for allowing real mutlti-thread access to a single virConnectPtr object. I believe this cloning support should be sufficient for the Java bindings need to use a thread for its event loop. The idea being that if you wanted to use an event loop in a background thread, you'd create a cloned object for use event loop triggered callbacks like domain events notifications. I'd still like to do some experiments later making the single virConnectPtr fully thread safe, but that'll take a little more time. I'm hoping this cloning will address the Java needs right now... Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 7

[libvirt] F10 rpm problems
by Ben Guthro 10 Dec '08

10 Dec '08

So...I decided to make the leap, and upgraded to F10 (from F9) After my upgrade, I decided to build the libvirt rpm from source, and install it. So far, so good...everything built, and installs nicely. However, when I run virsh, I get the following error: virsh: error while loading shared libraries: libgnutls.so.13: cannot open shared object file: No such file or directory Fedora 10 has /usr/lib/libgnutls.so.26, so I'm not real sure why it is looking for the old F9 versions. I have tried a make clean, make distclean, even re-cloning the repo...without effect. Does anyone have any thoughts as to why it is choosing this version of gnutls?

5 6

[libvirt] [PATCH] fix just-broken "virsh start" and "virsh pool-start" commands
by Jim Meyering 10 Dec '08

10 Dec '08

* src/virsh.c (cmdPoolStart, cmdStart): Change hard-coded vshCommandOptDomainBy string argument to match just-changed option name. Cole Robinson reported that "virsh start" was broken and provided that part of the fix. Bug introduced by yesterday's "virsh.c: tweak options to produce more accurate help". * tests/start: New file. Test for the above fix. * tests/Makefile.am (test_scripts): Add start. --- Without this change, "virsh start" and "virsh pool-start" would always fail. I'm fixing this in two steps: first is this patch: make the tiny string-changing fixes (along with the new test). Second will be a more invasive change to make it so the duplicate strings are removed altogether, so they'll never get out of sync again. src/virsh.c | 4 ++-- tests/Makefile.am | 1 + tests/start | 42 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+), 2 deletions(-) create mode 100755 tests/start diff --git a/src/virsh.c b/src/virsh.c index bb81f25..1a5b42f 100644 --- a/src/virsh.c +++ b/src/virsh.c @@ -1021,7 +1021,7 @@ cmdStart(vshControl *ctl, const vshCmd *cmd) if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) return FALSE; - if (!(dom = vshCommandOptDomainBy(ctl, cmd, "name", NULL, VSH_BYNAME))) + if (!(dom = vshCommandOptDomainBy(ctl, cmd, "domain", NULL, VSH_BYNAME))) return FALSE; if (virDomainGetID(dom) != (unsigned int)-1) { @@ -3693,7 +3693,7 @@ cmdPoolStart(vshControl *ctl, const vshCmd *cmd) if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) return FALSE; - if (!(pool = vshCommandOptPoolBy(ctl, cmd, "name", NULL, VSH_BYNAME))) + if (!(pool = vshCommandOptPoolBy(ctl, cmd, "pool", NULL, VSH_BYNAME))) return FALSE; if (virStoragePoolCreate(pool, 0) == 0) { diff --git a/tests/Makefile.am b/tests/Makefile.am index fd319e1..9e794c5 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -64,6 +64,7 @@ test_scripts += \ int-overflow \ read-bufsiz \ read-non-seekable \ + start \ undefine \ vcpupin virsh-all diff --git a/tests/start b/tests/start new file mode 100755 index 0000000..a436f9b --- /dev/null +++ b/tests/start @@ -0,0 +1,42 @@ +#!/bin/sh +# ensure that virsh start works properly + +# Copyright (C) 2008 Free Software Foundation, Inc. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +if test "$VERBOSE" = yes; then + set -x + virsh --version +fi + +test -z "$srcdir" && srcdir=$(pwd) +test -z "$abs_top_srcdir" && abs_top_srcdir=$(pwd)/.. +. "$srcdir/test-lib.sh" + +fail=0 + +test_url=test:///default + +# expect this to fail +virsh -c $test_url start test > out 2> err && fail=1 + +# stdout gets a newline +echo > exp || fail=1 +compare out exp || fail=1 + +echo 'error: Domain is already active' > exp || fail=1 +compare err exp || fail=1 + +(exit $fail); exit $fail -- 1.6.0.4.1044.g77718

2 2

[libvirt] [Python] libvirt.libvirtError output
by Ivan Vovk 10 Dec '08

10 Dec '08

Hello, i have the following piece of pyhton test code: try: dom = conn.createXML(xmldata, 0) except libvirt.libvirtError, le: sys.stderr.write(le.message) as a result in case of exception i get 2 outputs in stderr: libvir: OpenVZ error : operation failed: Already an OPENVZ VM defined with the id '3005' operation failed: Already an OPENVZ VM defined with the id '3005' Actually, i just need only second string, which is generated by sys.stderr.write(le.message). Can an exception be raised without "uncontrolled" direction to stderr (fisrt string)? ________________________________ This message (including attachments) is private and confidential. If you have received this message in error, please notify us and remove it from your system.

2 1

[libvirt] Open monitor logs O_APPEND
by Guido Günther 10 Dec '08

10 Dec '08

Hi, attached patch is from Debian Bug #507553: The logfile is opened with O_APPEND (to make logrotate work with copytruncate) and without O_TRUNC (to not lose log information e.g. with stop and start of a VM). Using collectd or munin to monitor VMs creates quiet a bit of qemu monitor output so the ability to use logrotate makes a lot of sense to me. O.k. to apply? -- Guido diff -ur libvirt-0.4.4.orig/src/qemu_driver.c libvirt-0.4.4/src/qemu_driver.c --- libvirt-0.4.4.orig/src/qemu_driver.c 2008-06-12 16:52:53.000000000 +0200 +++ libvirt-0.4.4/src/qemu_driver.c 2008-12-02 12:48:32.271881000 +0100 @@ -844,7 +844,7 @@ return -1; } - if ((vm->logfile = open(logfile, O_CREAT | O_TRUNC | O_WRONLY, + if ((vm->logfile = open(logfile, O_CREAT | O_APPEND | O_WRONLY, S_IRUSR | S_IWUSR)) < 0) { qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, _("failed to create logfile %s: %s"),

3 4

[libvirt] how to get started with libvirt & central access control
by Juan Miscaro 09 Dec '08

09 Dec '08

Quite new to libvirt (and kvm). I played with a few vm's with libvirt/kvm and vnc/virsh/virt-manager. I would now like to implement access control for my vm's (of any format: xen, kvm, etc) to a remote backend (mysql/ldap/other). Where does one begin? I would later want to do the same but in the context of a cluster of hosts (each running multiple vm's). Thanks in advance for any advice. /juan

3 2

[libvirt] libvirt 0.5.1 tag missing in git repo: just applied manually
by Jim Meyering 08 Dec '08

08 Dec '08

FYI, Itamar Heim noticed that the LIBVIRT_0_5_1 tag, while in CVS, was not in the git repository (thanks, Itamar). I have a vague recollection that git cvsimport creates certain tags lazily (like only once there is something on a branch) but I have manually applied and pushed this particular tag, nonetheless.

1 0

[libvirt] [PATCH 0/4] generate SYNTAX section of "virsh help CMD" output
by Jim Meyering 08 Dec '08

08 Dec '08

This started when I noticed that a lot of virsh help output was out of date. Dan Berrange suggested to generate the SYNTAX line automatically based on existing option descriptions, since they tell us what arguments/types each command accepts and can (usually) tell us when options or arguments are optional. Doing this exposed several inaccurate SYNTAX lines, as well as some inaccurate option descriptions. But since the option description structs are currently used only to generate the text of ./virsh help's OPTIONS section, it's not terribly important. Other than changes to help output, this change induces some minor user-visible changes: It is currently undocumented that virsh accepts "-h C1 C2 C3..." and treats it like "virsh help C1", ignoring C2 C3... This change disables that feature (to clean up a few interfaces and to make automatic help SYNTAX generation simpler) and makes virsh diagnose any unused arguments with --help (-h), so now, this command fails rather than trying to interpret "A" as a command: $ virsh -h -c test:///default A virsh: error: extra argument 'A'. See --help. To view the other changes induced by this patch, I've run the following commands: v='virsh -c test:///default' cmd=$(eval $v help|sed -n 's/^ $[^ ][^ ]*$ .*/\1/p') for i in $(echo $cmd); do diff -ubBw -L $i.orig -L $i.new <(eval $v help $i) <(eval ./$v help $i) done They use diff to compare e.g., the output of my just-built ./virsh and the installed-in-PATH "virsh" program. Note that there is currently no way via options to indicate that one of two or more options must be selected, so the automatically generated syntax string list both as independent options. Here are the induced help changes: [code diffs coming in separate messages] --- attach-disk.orig +++ attach-disk.new @@ -2,7 +2,7 @@ attach-disk - attach disk device SYNOPSIS - attach-disk <domain> <source> <target> [--driver <driver>] [--subdriver <subdriver>] [--type <type>] [--mode <mode>] + attach-disk <domain> <source> <target> [--driver <string>] [--subdriver <string>] [--type <string>] [--mode <string>] DESCRIPTION Attach new disk device. @@ -11,9 +11,9 @@ <domain> domain name, id or uuid <source> source of disk device <target> target of disk device - <driver> driver of disk device - <subdriver> subdriver of disk device - <type> target device type - <mode> mode of device reading and writing + --driver <string> driver of disk device + --subdriver <string> subdriver of disk device + --type <string> target device type + --mode <string> mode of device reading and writing --- attach-interface.orig +++ attach-interface.new @@ -2,7 +2,7 @@ attach-interface - attach network interface SYNOPSIS - attach-interface <domain> <type> <source> [--target <target>] [--mac <mac>] [--script <script>] + attach-interface <domain> <type> <source> [<target>] [<mac>] [<script>] DESCRIPTION Attach new network interface. --- autostart.orig +++ autostart.new @@ -2,7 +2,7 @@ autostart - autostart a domain SYNOPSIS - autostart [--disable] <domain> + autostart <domain> [--disable] DESCRIPTION Configure a domain to be automatically started at boot. --- connect.orig +++ connect.new @@ -2,7 +2,7 @@ connect - (re)connect to hypervisor SYNOPSIS - connect [name] [--readonly] + connect [<name>] [--readonly] DESCRIPTION Connect to local hypervisor. This is built-in command after shell start up. --- create.orig +++ create.new @@ -2,7 +2,7 @@ create - create a domain from an XML file SYNOPSIS - create a domain from an XML <file> + create <file> DESCRIPTION Create a domain. --- start.orig +++ start.new @@ -8,6 +8,6 @@ Start a domain. OPTIONS - <name> name of the inactive domain + <domain> name of the inactive domain --- detach-interface.orig +++ detach-interface.new @@ -2,7 +2,7 @@ detach-interface - detach network interface SYNOPSIS - detach-interface <domain> <type> [--mac <mac>] + detach-interface <domain> <type> [--mac <string>] DESCRIPTION Detach network interface. @@ -10,6 +10,6 @@ OPTIONS <domain> domain name, id or uuid <type> network interface type - <mac> MAC address + --mac <string> MAC address --- define.orig +++ define.new @@ -2,7 +2,7 @@ define - define (but don't start) a domain from an XML file SYNOPSIS - define a domain from an XML <file> + define <file> DESCRIPTION Define a domain. --- domblkstat.orig +++ domblkstat.new @@ -2,7 +2,7 @@ domblkstat - get device block stats for a domain SYNOPSIS - domblkstat <domain> <dev> + domblkstat <domain> <device> DESCRIPTION Get device block stats for a running domain. --- domifstat.orig +++ domifstat.new @@ -2,7 +2,7 @@ domifstat - get network interface stats for a domain SYNOPSIS - domifstat <domain> <dev> + domifstat <domain> <interface> DESCRIPTION Get network interface stats for a running domain. --- find-storage-pool-sources.orig +++ find-storage-pool-sources.new @@ -2,7 +2,7 @@ find-storage-pool-sources - discover potential storage pool sources SYNOPSIS - find-storage-pool-sources <type> [srcSpec] + find-storage-pool-sources <type> [<srcSpec>] DESCRIPTION Returns XML <sources> document. --- find-storage-pool-sources-as.orig +++ find-storage-pool-sources-as.new @@ -2,7 +2,7 @@ find-storage-pool-sources-as - find potential storage pool sources SYNOPSIS - find-storage-pool-sources-as <type> [options] + find-storage-pool-sources-as <type> [<host>] [<port>] DESCRIPTION Returns XML <sources> document. --- list.orig +++ list.new @@ -2,7 +2,7 @@ list - list domains SYNOPSIS - list [--inactive | --all] + list [--inactive] [--all] DESCRIPTION Returns list of domains. --- migrate.orig +++ migrate.new @@ -2,7 +2,7 @@ migrate - migrate domain to another host SYNOPSIS - migrate [--live] <domain> <desturi> [<migrateuri>] + migrate [--live] <domain> <desturi> [<migrateuri>] [<dname>] DESCRIPTION Migrate domain to another host. Add --live for live migration. --- net-autostart.orig +++ net-autostart.new @@ -2,7 +2,7 @@ net-autostart - autostart a network SYNOPSIS - net-autostart [--disable] <network> + net-autostart <network> [--disable] DESCRIPTION Configure a network to be automatically started at boot. --- net-list.orig +++ net-list.new @@ -2,7 +2,7 @@ net-list - list networks SYNOPSIS - net-list [ --inactive | --all ] + net-list [--inactive] [--all] DESCRIPTION Returns list of networks. --- net-start.orig +++ net-start.new @@ -2,7 +2,7 @@ net-start - start a (previously defined) inactive network SYNOPSIS - net-start <network> + net-start <name> DESCRIPTION Start a network. --- nodedev-list.orig +++ nodedev-list.new @@ -2,7 +2,7 @@ nodedev-list - enumerate devices on this host SYNOPSIS - nodedev-list [--cap <capability>] + nodedev-list [--cap <string>] OPTIONS --cap <string> capability name --- pool-autostart.orig +++ pool-autostart.new @@ -2,7 +2,7 @@ pool-autostart - autostart a pool SYNOPSIS - pool-autostart [--disable] <pool> + pool-autostart <pool> [--disable] DESCRIPTION Configure a pool to be automatically started at boot. --- pool-create-as.orig +++ pool-create-as.new @@ -2,7 +2,7 @@ pool-create-as - create a pool from a set of args SYNOPSIS - pool-create-as <name> <type> + pool-create-as <name> <type> [<source-host>] [<source-path>] [<source-dev>] [<target>] DESCRIPTION Create a pool. --- pool-define-as.orig +++ pool-define-as.new @@ -2,7 +2,7 @@ pool-define-as - define a pool from a set of args SYNOPSIS - pool-define-as <name> <type> + pool-define-as <name> <type> [<source-host>] [<source-path>] [<source-dev>] [<source-name>] [<target>] DESCRIPTION Define a pool. --- pool-edit.orig +++ pool-edit.new @@ -2,7 +2,7 @@ pool-edit - edit XML configuration for a storage pool SYNOPSIS - pool-edit <domain> + pool-edit <pool> DESCRIPTION Edit the XML configuration for a storage pool. --- pool-list.orig +++ pool-list.new @@ -2,7 +2,7 @@ pool-list - list pools SYNOPSIS - pool-list [ --inactive | --all ] + pool-list [--inactive] [--all] DESCRIPTION Returns list of pools. --- pool-start.orig +++ pool-start.new @@ -8,6 +8,6 @@ Start a pool. OPTIONS - <name> name of the inactive pool + <pool> name of the inactive pool --- restore.orig +++ restore.new @@ -2,7 +2,7 @@ restore - restore a domain from a saved state in a file SYNOPSIS - restore a domain from <file> + restore <file> DESCRIPTION Restore a domain. --- schedinfo.orig +++ schedinfo.new @@ -2,7 +2,7 @@ schedinfo - show/set scheduler parameters SYNOPSIS - schedinfo <domain> + schedinfo <domain> [--set <string>] [--weight <number>] [--cap <number>] DESCRIPTION Show/Set scheduler parameters. --- vol-create.orig +++ vol-create.new @@ -2,7 +2,7 @@ vol-create - create a vol from an XML file SYNOPSIS - vol-create <file> + vol-create <pool> <file> DESCRIPTION Create a vol. --- vol-create-as.orig +++ vol-create-as.new @@ -2,7 +2,7 @@ vol-create-as - create a volume from a set of args SYNOPSIS - vol-create-as <pool> <name> <capacity> + vol-create-as <pool> <name> <capacity> [--allocation <string>] [--format <string>] DESCRIPTION Create a vol. @@ -11,7 +11,7 @@ <pool> pool name <name> name of the volume <capacity> size of the vol with optional k,M,G,T suffix - <allocation> initial allocation size with optional k,M,G,T suffix - <format> file format type raw,bochs,qcow,qcow2,vmdk + --allocation <string> initial allocation size with optional k,M,G,T suffix + --format <string> file format type raw,bochs,qcow,qcow2,vmdk --- vol-delete.orig +++ vol-delete.new @@ -2,7 +2,7 @@ vol-delete - delete a vol SYNOPSIS - vol-delete <vol> + vol-delete [--pool <string>] <vol> DESCRIPTION Delete a given vol. --- vol-dumpxml.orig +++ vol-dumpxml.new @@ -2,7 +2,7 @@ vol-dumpxml - vol information in XML SYNOPSIS - vol-dumpxml <vol> + vol-dumpxml [--pool <string>] <vol> DESCRIPTION Output the vol information as an XML dump to stdout. --- vol-info.orig +++ vol-info.new @@ -2,7 +2,7 @@ vol-info - storage vol information SYNOPSIS - vol-info <vol> + vol-info [--pool <string>] <vol> DESCRIPTION Returns basic information about the storage vol. --- vol-path.orig +++ vol-path.new @@ -2,7 +2,7 @@ vol-path - convert a vol UUID to vol path SYNOPSIS - vol-path <pool> <vol> + vol-path [--pool <string>] <vol> OPTIONS --pool <string> pool name or uuid

3 4

[libvirt] Bridged network (shared physical device) and libvirt
by Henrik Persson E 08 Dec '08

08 Dec '08

Hi, Are there any plans to include possibility to configure bridged networks in libvirt? I see the need to be able to actually be able create vlans on physical devices and the bridge the vlan, which I guess is a very normal case for isolating network traffic between different guests. I would be great if it would be possible to both create vlans on physical devices and then also create bridged network connected to any available network (physical/bonded/vlan) /Henrik

4 3