- Devel - libvirt List Archives

[libvirt] [PATCH] don't dereference uninitialized pointer
by Jim Meyering 02 Mar '09

02 Mar '09

>From a907d2da7e7f9d1f58009ff6a95454ac0eb2cbf1 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 2 Mar 2009 10:10:02 +0100 Subject: [PATCH] don't dereference uninitialized pointer * src/storage_conf.c (virStoragePoolDefParsePerms): Initialize "ptr" to NULL. --- ChangeLog | 6 ++++++ src/storage_conf.c | 2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 12715f5..ede7e0d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2009-03-02 Jim Meyering <meyering(a)redhat.com> + + don't dereference uninitialized pointer + * src/storage_conf.c (virStoragePoolDefParsePerms): Initialize + "ptr" to NULL. + Fri Feb 27 17:15:00 CET 2009 Chris Lalancette <clalance(a)redhat.com> * src/qemu_driver.c: If there is a failure during offline migrate, diff --git a/src/storage_conf.c b/src/storage_conf.c index 70107a2..4a53ff4 100644 --- a/src/storage_conf.c +++ b/src/storage_conf.c @@ -381,7 +381,7 @@ virStoragePoolDefParsePerms(virConnectPtr conn, if (!mode) { perms->mode = 0700; } else { - char *end; + char *end = NULL; perms->mode = strtol(mode, &end, 8); if (*end || perms->mode < 0 || perms->mode > 0777) { virStorageReportError(conn, VIR_ERR_XML_ERROR, -- 1.6.2.rc1.285.gc5f54

2 2

[libvirt] Update on host interface configuration
by David Lutterkort 01 Mar '09

01 Mar '09

Hi, I thought I'd write an update of what I've been doing with the host interface configuration previously discussed[1] After talking with Dan Williams, who is working in NetworkManager, it is clear that the network interface functionality for libvirt is also useful for NM and would help them with handling system-wide interface configuration. To accomodate that, I will implement network interface configuration in a separate library (inspiringly called 'netcf', until somebody thinks of something catchier) and add public API to libvirt that will use netcf to do the actual work. One thorny issue is how libvirt's public API and netcf's public API relate to each other, especially since both libvirt and netcf use XML descriptions to describe network interfaces (netcf does that for exactly the same reasons that libvirt does it, since it will have to deal with similar stability issues) For the time being, I am assuming that the two XML descriptions are identical, with no guarantee that that will always be the case. If and when we run into a case where libvirt's and netcf's needs diverge, we'll break that identity. On the implementation side, that means that, for now, netcf will do all the validation and pass errors back to libvirt. In more concrete terms, I put up a git repo[2] for netcf. There's hardly any code in there, the things I'd particularly appreciate review/feedback on are * the RelaxNG specification of the interface XML (in xml/interface.rng) together with examples of such interface specifications (in tests/interface/) * the (very rough) sketch of the netcf public API, which should map almost 1-1 to the public libvirt API in src/netcf.h I know that the XML schema doesn't cover everything we've discussed in [1], but I think it's a small enough subset to tackle relatively quickly and large enough to be useful. So, one of the main things to think about when looking at the schema is places where the schema would make it hard to make desirable enhancements in the near future (like Marius' point about default routes/gateways) One important point about the model of network config in the schema is that it is centered around what NM calls a 'connection' (though it's called 'interface' in the schema): a grouping of the components that make up the interface the user really cares about (a bridge or a bond) together with the components subordinate to it (e.g. ethernet interfaces enslaved to the bridge or bond) It's those groups that netcf deals with, i.e. if eth0 is enslaved to br0, netcf won't list eth0 as an interface, but only br0, with eth0 as a subinterface. For the implementation, netcf will have a separate backend for each network configuration regime (initscripts for Fedora/RHEL, /etc/network/interfaces for Debian, ...) - once the initscripts backend is done, I'd be very grateful for contributions for the other backends. To sketch out the initscripts implementation, I wrote two XSL stylesheets, xml/initscripts-get.xml that goes from interface XML -> initscripts files (via Augeas) and xml/initscripts-put.xml to go the other way for querying; I'll use those for the core of the initscripts backend. Whether other backands can be done in a similar manner is TBD. David [1] https://www.redhat.com/archives/libvir-list/2009-January/msg00350.html [2] http://git.et.redhat.com/?p=netcf.git;a=tree

5 10

[libvirt] virsh and api
by Zvi Dubitzky 01 Mar '09

01 Mar '09

Hi How about adding the following info to the virsh / dominfo command ( and to the programmable libvirt API:): - IP address of the domain in case the host was configured as a bridge - cpu utilization (at least for Linux) Is that possible ? thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

1 0

[libvirt] Problem installing KVM Guest from command line
by aliahsan naqvi 28 Feb '09

28 Feb '09

Hi All >From past many days i am trying to install KVM Guest Machine from command line via virt-install.Below is many command i have testing this on Fedora 9 and fedora 10 but not able to do it. virt-install -n testing -r 256 -w bridge:virbr0 --location /mnt/Fedora-10-i386-DVD.iso --accelerate --os-type=linux --hvm --nographics -f /var/imgVM1 --force -x "console=ttyS0" I am installing from HTTP server.After give Network information.Following error comes.i have also tried with NFS and ftp but same result.It seem guest machine not able to get ip address.Because when i ping the ip address of the guest which is provided in Networking setting during guest installation.It was not pingable.And this http server is working fine.i can browse all the install directory with no problem and i have install other machine with the http install directory. I am getting following error after TCP/IP Manual/ DHCP Configuration Network Settings +-----------+ Error +------------+ | | | Unable to retrieve | | http://192.168.1.8/fedora | | /linux/releases/10/Fedora/i38 | | 6/os//images/install.img. | | | | +----+ | | | OK | | | +----+ | | | | | +--------------------------------+ Please Advise.Please let me if i am doing some thing wrong or this a bug. _________________________________________________________________ Windows Live™: Life without walls. http://windowslive.com/explore?ocid=TXT_TAGLM_WL_allup_1a_explore_032009

1 0

RE: [libvirt] Help with bridged networking
by Jesus Urroa 27 Feb '09

27 Feb '09

Hi, Thanks all for your help, I installed libvirt 0.6.0-4 and kvm 84-1 from fedora's rawhide and that solved the problem. However know I have a new problem I tried the other virtual machines and some of them just don't start, they seem to stop when the bios jumps to the disk and grub, any ideas? The only thing I can think of is to upgrade the host kernel but if I'm not wrong I have to upgrade to Fedora 9 or 10, and I would like to try something else before because I want to have everything running before leaving xen completely > Subject: RE: [libvirt] Help with bridged networking > From: lutter(a)redhat.com > To: observer1(a)hotmail.es > Date: Fri, 27 Feb 2009 08:48:13 -0800 > > On Fri, 2009-02-27 at 00:55 +0000, Jesus Urroa wrote: > > My mistake I see the lines for the ip config commented out in the file > > and I place them again > > Anyway I remove the card from the bridge to simplify the problem a > > little, this the output of brctl show for the bridge using only xen > > (no libvirt at all) and using kvm with libvirt and running only 2 vms: > > > > worknet 8000.feffffffffff no vif1.0 > > vif4.0 > > vif5.0 > > vif6.1 > > vif7.1 > > vif8.0 > > > > worknet 8000.00ff52959073 no vnet0 > > > > vnet3 > > With the non-Xen setup, your bridge should have the same IP address as > the enslaved NIC. > > What exactly is not working ? Can VM's on the same bridge ping each > other ? > > Did you add teh following iptables rule (to forward packages from the > bridge to the outside): > > # echo "-I FORWARD -m physdev --physdev-is-bridged -j ACCEPT" > /etc/sysconfig/iptables-forward-bridged > # lokkit --custom-rules=ipv4:filter:/etc/sysconfig/iptables-forward-bridged > # service libvirtd reload > > Otherwise, your VM;s can't talk to the outside. > > David > > _________________________________________________________________ Anímate y disfruta con los mejores juegos de Messenger, ¡descúbrelos! http://www.vivelive.com/juegos/

1 0

[libvirt] internal error Timed out while reading console log output
by jmandawg 27 Feb '09

27 Feb '09

Hi, I just compiled installed Libvirt from the latest git repo, and for some reason when I try to start a VM from virsh I get the following error: virsh # start XPTest error: Failed to start domain XPTest error: internal error unable to start guest: and the corresponding output from libvirtd running in verbose mode: 08:19:53.163: info : Received unexpected signal 17 08:20:00.083: info : Received unexpected signal 17 08:20:00.095: info : Received unexpected signal 17 08:20:03.200: error : internal error Timed out while reading console log output libvir: QEMU error : internal error Timed out while reading console log output 08:20:03.200: error : internal error unable to start guest: libvir: QEMU error : internal error unable to start guest: Here is the command virsh is trying to run from the Libvirt log file: LC_ALL=C PATH=/usr/bin:/bin:/root/bin:/usr/X11R6/bin:/usr/local/kvm/bin:/usr/local/sb in:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games HOME=/root USER=root LOGNAME=root /usr/bin/kvm -S -M pc -m 512 -smp 1 -name XPTest -uuid 732fcba8-b71f-face-e067-cf8431fc94aa -monitor pty -pidfile /var/run/libvirt/qemu//XPTest.pid -localtime -no-acpi -boot c -drive file=/var/kvm-images/XPTest/XP_Test.img,if=ide,index=0,boot=on -net nic,macaddr=00:0c:29:f6:c4:f8,vlan=0,model=e1000 -net tap,fd=20,script=,vlan=0,ifname=vnet3 -serial none -parallel none -usb -usbdevice tablet -vnc 0.0.0.0:9 If I start the VM from the commandline manually using this command and then shutdown, I can successfully start it from Virsh qemu-system-x86_64 -no-acpi -m 512 -hda XP_Test.img \ -net nic,macaddr=00:0C:29:F6:C4:F8 \ -net tap \ -usb -usbdevice tablet \ -monitor unix:monitor,server,nowait \ -soundhw all \ -pidfile pid & virsh # version Compiled against library: libvir 0.6.0 Using library: libvir 0.6.0 Using API: QEMU 0.6.0 Running hypervisor: QEMU 0.9.1 Any help would be appreciated. Thanks, John

1 1

[libvirt] [PATCH]: Fix non-live migration failure
by Chris Lalancette 27 Feb '09

27 Feb '09

There is a logic error in the Qemu driver when doing a non-live migrate. During a non-live migrate, on the source host during the Perform step, we pause the domain; however, if there was ever a failure, we were forgetting to unpause the domain, meaning that the domain was paused forever. Add a flag to tell us when we should unpause the domain after a failure. Also, as pointed out by DV, we were unnecessarily using a snprintf to a buffer to execute qemu monitor commands, when we could get away with just sending a static string. Fix that as well. Signed-off-by: Chris Lalancette <clalance(a)redhat.com>

2 2

[libvirt] libvirt tls vnc
by Michael Kress 27 Feb '09

27 Feb '09

Hi, is there a comprehensive howto/tutorial you can recommend me on how to set up libvirt with vnc over tls properly? What I'm trying to do is to use vnc for production use outside my local network and therefore I'd like to secure the vnc sessions. I already made some attempts with ssvnc and Ultr@VNC (both windows clients) but these attemps all failed. I can't get the vnc server (launched by virt-install / kvm) to be displayed via tls. It all runs perfectly without tls. Thanx for any hints! Michael

4 16

[libvirt] using virsh remotely
by Andreas Rittershofer 27 Feb '09

27 Feb '09

I can use virsh as a command line tool, for exampe virsh list gives me the list of the running machines and I am back to the prompt. When I make virsh -c qemu+ssh://maschine-2/system list I get the list of the running machine on the remote machine-2 - but that's it, I am not back to the prompt automatically. I want virsh to behave used remotely as used locally - execute the command and go back to the prompt. How this can be done? mfg ar -- Hier könnte keine Signatur stehen.

2 2

[libvirt] adding bandwidth control support
by Max Zhen 27 Feb '09

27 Feb '09

My last post failed, resend... Max Zhen at 2008-12-24 18:39 wrote: > Hi, > > I'm working on adding bandwidth control support in > virt-install/virsh/libvirt on Xen. > This support can allow setting bandwidth control in dom0 (I'm working on > Solaris dom0 now) for virtual nic devices used in a domU. > I've attached my design in this email. > Basically, this design is about how to represent bandwidth limit > information in command line for virsh/virt-install and how to represent > it in current XML configuration file for a domU. > > Your comments will be highly appreciated :). > > Thanks, > Max > > There are a few things to do to achieve this goal: 1. extend current command line syntax of 'virsh attach-interface' 2. extend current command line syntax of 'virt-install' 3. define bandwidth representation in XML format For 1. I will change the current command line syntax to: virsh attach-interface <domain> <type> <source> [--target <target>] [--mac <mac>] [--script <script>] [--rate <rate-string>] So that we are able to specify bandwidth as "--rate 100M" in command line, like: #virsh attach-interface domu bridge bge0 --rate 100M In this case, bandwidth is specified as an integer with one of the scale suffixes K, M, or G for Kbps, Mbps, or Gbps. For 2. I will add one more option "--rate=rate-string" to current option set of virt-install command. Users can repeatedly add more than one 'rate' options to set bandwidth for multiple nic devices respectively, if needed. For example, with below command line, we start installing a domain with two nic devices whose bandwidth are set to 100Mb/s and 200Mb/s respectively: #virt-install -n snv105 -r 2048 -p --file=/root/snv105 --location=/solarisdvd.iso -b bge0 --rate=100M -b bge1 --rate=200M In this case, bandwidth is specified as an integer with one of the scale suffixes K, M, or G for Kbps, Mbps, or Gbps. For 3. All user specified bandwidth will be represented as part of interface element currently defined in XML configuration file. The new format looks like: <interface type='bridge'> <source bridge='e1000g1'/> <flowcontrol> <rate unit='megabit' period='second' value='100'/> </flowcontrol> </interface> So, I create a new element, "flowcontrol", inside "interface" element. Inside "flowcontrol", I provide bandwidth by setting "rate" element with three attributes, "unit", "period" and "value" to express the bandwidth limit. The supported unit can be 'gigabit', 'megabit' and 'kilobit'. The supported period can be 'second', 'millisecond' and 'microsecond'. And value is an integer to express the amount of data in unit allowed to be transfered in period of time. More elements can be added inside "flowcontrol" element, if we want to add more flow control policies in the future.

2 5