- Devel - libvirt List Archives

[libvirt] Java api for libvirt migration
by Zvi Dubitzky 07 May '09

07 May '09

I am trying to do a migrate of VM with libvirt 0.6.1 and kvm-84 . I am successful in doing it many times via the C interface . I can do most of the basic libvirt activity via the libvirt JAVA library (libvirt-java-0.2.1). When it comes to a migrate the JVM fails wit a log file attached below . Can someone help. My memory consumption in my JAVA test code is small. The migrate parameters I am sending with the Java are identical to those I use in the C case and is: destDomain = localDomain.migrate (dcon, // destination host Connect object VIR_MIGRATE_LIVE, null, //const char *dname destination domain name target_uri, //"tcp:9.148.28.13:4444" 0 // unsigned long bandwidth) - do not specify ); thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

1 0

[libvirt] [PATCH] return a sensible error on bogus paths
by Guido Günther 07 May '09

07 May '09

Hi, attached patch makes it easier to detect bogus paths when creating/removing pidfiles. O.k. to apply? Cheers, -- Guido

2 2

[libvirt] [PATCH]: don't crash when calling libvirt_lxc without arguments
by Guido Günther 07 May '09

07 May '09

In this case we reference def with is NULL. O.k. to apply? Cheers, -- Guido

2 2

[libvirt] PATCH: Add LSB init headers
by Frederik Himpe 07 May '09

07 May '09

The following patch is needed to make sure libvirt is not started too early in the boot sequence on Mandriva. --- libvirt-0.6.1/qemud/libvirtd.init.in.orig 2009-03-05 19:34:05.000000000 +0100 +++ libvirt-0.6.1/qemud/libvirtd.init.in 2009-03-05 19:34:54.000000000 +0100 @@ -5,7 +5,11 @@ # ### BEGIN INIT INFO # Provides: libvirtd +# Required-Start: $network messagebus +# Should-Start: $named # Should-Start: xend +# Required-Stop: $network messagebus +# Should-Stop: $named # Default-Start: 3 4 5 # Short-Description: daemon for libvirt virtualization API # Description: This is a daemon for managing guest instances

4 5

[libvirt] [PATCH 2/2] support for multiple graphics devices
by Pritesh Kothari 07 May '09

07 May '09

Hi All, I have added support for multiple graphics devices, the patches are as below. I have checked them against current cvs head and works fine PATCH 1/2: contains changes in libvirt for multiple graphics devices PATCH 2/2: contains corresponding changes in qemu driver. Regards, Pritesh

3 5

[libvirt] Authentication with virConnectAuthPtr
by Eduardo Otubo 07 May '09

07 May '09

Hello all, I'll start using virConnectAuthPtr to handle the authentication proccess at the phyp driver I'm wrinting <https://www.redhat.com/archives/libvir-list/2009-April/msg00493.html> and I have some doubts in my mind: 1) What are the types of authentication that 'int *credtype' can hold? And who fills it with the information I'll need? 2) Once known the credential type, I need to use the function pointer 'virConnectAuthCallbackPtr cb' to get the information whatever it is, right? I mean, it can be a password, a pubkey or anything else, right? Is there a callback able to handle password or pubkeys? 3) And finally I'll be able to use the 'void *cbdata' to manage the authentication in my way. In my case, using libssh. In fact, in the end of the process, I'll just need a password or a key to get things working. There is no driver authenticatin agaist ssh channel, that's why I got so confused with this topic. I don't know if my thoughts are pretty clear here. But I would like to confirm the information 2 and 3, and check how 1 works. Could anyone help me? Thanks in advance, []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 otubo(a)linux.vnet.ibm.com

2 2

[libvirt] discrepancies in issuing virsh capabilities with different user-accounts
by Gerrit Slomma 06 May '09

06 May '09

Hello When doing a virsh capabilities with root i get a different output than when issuing the command with my own unprivileged account roadrunner. Furthermore the first issuing of the command as roadrunner throws a error-message. Restarting of the libvirt-daemon gives the correct output. Sample: Last login: Wed May 6 21:00:56 2009 from 192.168.1.120 [root@rr018 ~]# virsh capabilities|grep kvm [root@rr018 ~]# su - roadrunner [roadrunner@rr018 ~]$ virsh capabilities|grep kvm libvir: Remote Fehler : unable to connect to '@/home/roadrunner/.libvirt/libvirt-sock': Verbindungsaufbau abgelehnt Fehler: Verbindung zum Hypervisor scheiterte Failed to bind socket to '@/home/roadrunner/.libvirt/libvirt-sock': Address already in use Failed to bind socket to '@/home/roadrunner/.libvirt/libvirt-sock': Address already in use Failed to bind socket to '@/home/roadrunner/.libvirt/libvirt-sock': Address already in use Failed to bind socket to '@/home/roadrunner/.libvirt/libvirt-sock': Address already in use ^C [roadrunner@rr018 ~]$ virsh capabilities|grep kvm <domain type='kvm'> <emulator>/usr/bin/kvm</emulator> <domain type='kvm'> [roadrunner@rr018 ~]$ exit logout [root@rr018 ~]# virsh capabilities|grep kvm [root@rr018 ~]# /etc/init.d/libvirtd restart libvirtd-Daemon beenden: [ OK ] libvirtd-Daemon starten: [ OK ] [root@rr018 ~]# virsh capabilities|grep kvm <domain type='kvm'> <emulator>/usr/bin/kvm</emulator> <domain type='kvm'> [root@rr018 ~]#

1 1

Re: [libvirt] KVM processes -- should we be able to attach them to the libvirtd process?
by Daniel P. Berrange 06 May '09

06 May '09

On Wed, May 06, 2009 at 08:56:18PM +0200, Gerrit Slomma wrote: > Daniel P. Berrange schrieb: > >On Tue, May 05, 2009 at 11:38:13PM -0500, Matthew Farrellee wrote: > > > >>It doesn't appear to be the case that the libvirtd daemon can trivially > >>restart and continue with no interruptions. Right now it loses track of > >>VMs. > >> > > > >That a is a bug then, if you can reproduce it, please file a BZ ticket > >so we can track it down & fix it. > > > > > >>In a scenario where VMs are not deployed and locked to specific physical > >>nodes, it can be highly valuable to have ways to ensure a VM is no > >>longer running when a layer of its management stops functioning. > >> > > > >IMHO this is a problem to be solved by clustering software. If the > >clustering software detects a failure with the management service, > >then it should power fence the entire node. Relying on management > >service failure to kill the VMs will never be reliable enough. > > > I think he is pointing towards a VM that runs on a host where it isn't > defined at via a corresponding *.xml. > If you restart a libvirt i looses connection to this or these specific > VM(s). That is a bug that needs fixing. Even if there is no persistent config, we should not loose track of the running VM, because we always write out the 'live' XML config to /var/run/libvirt explicitly so that it is available at restart. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

[libvirt] PATCH: Raise log level for dlopen() problems
by Daniel P. Berrange 06 May '09

06 May '09

Some of the problems when dlopen'ing a module really should be reported to the user/admin more readily. So this raises the logging level for the important failure messages, so they're visible by default Daniel diff -r 15c4668d403b src/driver.c --- a/src/driver.c Wed Apr 29 15:29:17 2009 +0100 +++ b/src/driver.c Thu Apr 30 14:49:27 2009 +0100 @@ -54,13 +54,13 @@ virDriverLoadModule(const char *name) return NULL; if (access(modfile, R_OK) < 0) { - DEBUG("Moodule %s not accessible", modfile); + VIR_WARN("Module %s not accessible", modfile); goto cleanup; } handle = dlopen(modfile, RTLD_NOW | RTLD_LOCAL); if (!handle) { - DEBUG("failed to load module %s %s", modfile, dlerror()); + VIR_ERROR("failed to load module %s %s", modfile, dlerror()); goto cleanup; } @@ -70,12 +70,12 @@ virDriverLoadModule(const char *name) regsym = dlsym(handle, regfunc); if (!regsym) { - DEBUG("Missing module registration symbol %s", regfunc); + VIR_ERROR("Missing module registration symbol %s", regfunc); goto cleanup; } if ((*regsym)() < 0) { - DEBUG("Failed module registration %s", regfunc); + VIR_ERROR("Failed module registration %s", regfunc); goto cleanup; } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] PATCH: More robust name & UUID uniqueness checking for QEMU
by Daniel P. Berrange 06 May '09

06 May '09

When defining a VM config, we need to apply the following logi - If existing VM has same UUID - If name also matches => allow - Else => raise error - Else - If name matches => raise error - Else => allow When creating a live VM, or restoring a VM we need to apply similar, but slightly different logic - If existing VM has same UUID - If name also matches - If existing VM is running => raise error - Else => allow - Else => raise error - Else - If name matches => raise error - Else => allow This patch applies those checks for the QEMU driver Daniel diff -r 4e6a98395da5 src/qemu_driver.c --- a/src/qemu_driver.c Thu Apr 30 14:50:14 2009 +0100 +++ b/src/qemu_driver.c Thu Apr 30 15:03:03 2009 +0100 @@ -2145,22 +2145,37 @@ static virDomainPtr qemudDomainCreate(vi if (virSecurityDriverVerify(conn, def) < 0) goto cleanup; - vm = virDomainFindByName(&driver->domains, def->name); - if (vm) { - qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, - _("domain '%s' is already defined"), - def->name); - goto cleanup; - } + /* See if a VM with matching UUID already exists */ vm = virDomainFindByUUID(&driver->domains, def->uuid); if (vm) { - char uuidstr[VIR_UUID_STRING_BUFLEN]; - - virUUIDFormat(def->uuid, uuidstr); - qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, - _("domain with uuid '%s' is already defined"), - uuidstr); - goto cleanup; + /* UUID matches, but if names don't match, refuse it */ + if (STRNEQ(vm->def->name, def->name)) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + vm->def->name, uuidstr); + goto cleanup; + } + + /* UUID & name match, but if VM is already active, refuse it */ + if (virDomainIsActive(vm)) { + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + _("domain is already active as '%s'"), vm->def->name); + goto cleanup; + } + virDomainObjUnlock(vm); + } else { + /* UUID does not match, but if a name matches, refuse it */ + vm = virDomainFindByName(&driver->domains, def->name); + if (vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + def->name, uuidstr); + goto cleanup; + } } if (!(vm = virDomainAssignDef(conn, @@ -2348,6 +2363,11 @@ static int qemudDomainDestroy(virDomainP _("no domain with matching uuid '%s'"), uuidstr); goto cleanup; } + if (!virDomainIsActive(vm)) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "%s", _("domain is not running")); + goto cleanup; + } qemudShutdownVMDaemon(dom->conn, driver, vm); event = virDomainEventNewFromObj(vm, @@ -3258,17 +3278,36 @@ static int qemudDomainRestore(virConnect goto cleanup; } - /* Ensure the name and UUID don't already exist in an active VM */ + /* See if a VM with matching UUID already exists */ vm = virDomainFindByUUID(&driver->domains, def->uuid); - if (!vm) - vm = virDomainFindByName(&driver->domains, def->name); if (vm) { + /* UUID matches, but if names don't match, refuse it */ + if (STRNEQ(vm->def->name, def->name)) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + vm->def->name, uuidstr); + goto cleanup; + } + + /* UUID & name match, but if VM is already active, refuse it */ if (virDomainIsActive(vm)) { qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_INVALID, _("domain is already active as '%s'"), vm->def->name); goto cleanup; - } else { - virDomainObjUnlock(vm); + } + virDomainObjUnlock(vm); + } else { + /* UUID does not match, but if a name matches, refuse it */ + vm = virDomainFindByName(&driver->domains, def->name); + if (vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + def->name, uuidstr); + goto cleanup; } } @@ -3603,18 +3642,41 @@ static virDomainPtr qemudDomainDefine(vi if (virSecurityDriverVerify(conn, def) < 0) goto cleanup; - vm = virDomainFindByName(&driver->domains, def->name); + /* See if a VM with matching UUID already exists */ + vm = virDomainFindByUUID(&driver->domains, def->uuid); if (vm) { + /* UUID matches, but if names don't match, refuse it */ + if (STRNEQ(vm->def->name, def->name)) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + vm->def->name, uuidstr); + goto cleanup; + } + + /* UUID & name match */ virDomainObjUnlock(vm); newVM = 0; + } else { + /* UUID does not match, but if a name matches, refuse it */ + vm = virDomainFindByName(&driver->domains, def->name); + if (vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + def->name, uuidstr); + goto cleanup; + } } if (!(vm = virDomainAssignDef(conn, &driver->domains, def))) { - virDomainDefFree(def); - goto cleanup; - } + goto cleanup; + } + def = NULL; vm->persistent = 1; if (virDomainSaveConfig(conn, @@ -3636,6 +3698,7 @@ static virDomainPtr qemudDomainDefine(vi if (dom) dom->id = vm->def->id; cleanup: + virDomainDefFree(def); if (vm) virDomainObjUnlock(vm); if (event) -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1