- Devel - libvirt List Archives

[PATCH] qemu: fd: Fix monitor usage of qemuFDPassDirectGetPath
by Peter Krempa 03 Jun '22

03 Jun '22

We need to use the 'name' variable and just overwrite it with the FD number when FDs are passed on the monitor. Otherwise we will read NULL path if the FD is accessed before being passed on the monitor. The idea of this helper is to simplify the monitor code so it would be counterproductive to have other behaviour. Fixes the following symptom: $ virsh attach-interface cd network default --model virtio error: Failed to attach interface error: internal error: unable to execute QEMU command 'netdev_add': File descriptor named '(null)' has not been found Fixes: bca9047906fd73fd30f275dd45b64998fbbcf6de Resolves: https://gitlab.com/libvirt/libvirt/-/issues/318 Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2092856 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_fd.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c index 6311161657..51a8133fde 100644 --- a/src/qemu/qemu_fd.c +++ b/src/qemu/qemu_fd.c @@ -235,7 +235,6 @@ qemuFDPassGetPath(qemuFDPass *fdpass) struct _qemuFDPassDirect { int fd; - char *path; char *name; bool passed; /* passed to qemu via monitor */ @@ -251,7 +250,6 @@ qemuFDPassDirectFree(qemuFDPassDirect *fdpass) VIR_FORCE_CLOSE(fdpass->fd); g_free(fdpass->name); - g_free(fdpass->path); g_free(fdpass); } @@ -295,7 +293,8 @@ qemuFDPassDirectTransferCommand(qemuFDPassDirect *fdpass, return; virCommandPassFD(cmd, fdpass->fd, VIR_COMMAND_PASS_FD_CLOSE_PARENT); - fdpass->path = g_strdup_printf("%d", fdpass->fd); + g_free(fdpass->name); + fdpass->name = g_strdup_printf("%d", fdpass->fd); fdpass->fd = -1; } @@ -318,7 +317,6 @@ qemuFDPassDirectTransferMonitor(qemuFDPassDirect *fdpass, if (qemuMonitorSendFileHandle(mon, fdpass->name, fdpass->fd) < 0) return -1; - fdpass->path = g_strdup(fdpass->name); VIR_FORCE_CLOSE(fdpass->fd); fdpass->passed = true; @@ -358,5 +356,5 @@ qemuFDPassDirectGetPath(qemuFDPassDirect *fdpass) if (!fdpass) return NULL; - return fdpass->path; + return fdpass->name; } -- 2.35.3

2 1

[libvirt PATCH] ci: gitlab: Expire artifacts after 1 day
by Erik Skultety 02 Jun '22

02 Jun '22

With GitLab cutting down on shared resource usage it's very likely that following our measure to decrease the number of CI minutes we'll also need to decrease our usage of storage. Start by decreasing artifact expiration time to 1 day for jobs that are currently exceeding it (by a lot -> 30 days). At the same time, define expiration on the integration jobs' artifacts where there currently isn't one defined. Although 1 day doesn't seem to be enough of a time period, given the cadency of libvirt pipeline executions it should suffice giving everyone/jobs enough time to download artifacts if needed. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- .gitlab-ci.yml | 4 ++-- ci/integration-template.yml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6a8b89729f..1b39047862 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -74,7 +74,7 @@ website: expose_as: 'Website' name: 'website' when: on_success - expire_in: 30 days + expire_in: 1 day paths: - website @@ -115,7 +115,7 @@ potfile: expose_as: 'Potfile' name: 'potfile' when: on_success - expire_in: 30 days + expire_in: 1 day paths: - libvirt.pot diff --git a/ci/integration-template.yml b/ci/integration-template.yml index e2ccebd1f6..bd634a971b 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -80,6 +80,7 @@ SCRATCH_DIR: "/tmp/scratch" artifacts: name: logs + expire_in: 1 day paths: - logs when: on_failure -- 2.36.1

2 3

[PATCH] qemu: Restore label to temp file in qemuDomainScreenshot()
by Michal Privoznik 02 Jun '22

02 Jun '22

Obtaining a screenshot via virDomainScreenshot() works like this: 1) we create a temp file, label it, then 2) tell QEMU to store the screenshot into it, and 3) finally, open the file for transfer via virStream Since the file is just temporary and even explicitly unlinked at the end, no seclabel restoration is done. This makes perfect sense for security models which attach a label to file itself (DAC, SELinux) because the label is gone with the file. However, for models where a list of files and allowed actions is kept on a side (AppArmor) this approach means we just append files into the profile and never remove them. In turn, the file grows and policy update takes longer with each entry. Restore the seclabel for AppArmor's sake. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index fb63e6550f..0c6645ed89 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3423,8 +3423,13 @@ qemuDomainScreenshot(virDomainPtr dom, endjob: VIR_FORCE_CLOSE(tmp_fd); - if (unlink_tmp) + if (unlink_tmp) { + /* This may look pointless, since we're removing the file anyways, but + * it's crucial for AppArmor. Otherwise these temp files would + * accumulate in the domain's profile. */ + qemuSecurityDomainRestorePathLabel(driver, vm, tmp); unlink(tmp); + } qemuDomainObjEndJob(vm); -- 2.35.1

2 1

[PATCH REBASE 00/17] Use virXMLPropEnum() more (part I)
by Michal Privoznik 01 Jun '22

01 Jun '22

This is rebased version of: https://listman.redhat.com/archives/libvir-list/2022-April/229941.html Michal Prívozník (17): Drop needless typecast to virStorageType enum virStorageSourceGetActualType: Change type of retval virDomainBackupDefParse: Switch to virXMLPropEnumDefault() virDomainDeviceAddressParseXML: Switch to virXMLPropEnumDefault() virDomainStorageNetworkParseHost: Switch to virXMLPropEnumDefault() virDomainHostdevSubsysSCSIDefParseXML: Switch to virXMLPropEnumDefault() virDomainHostdevSubsysSCSIVHostDefParseXML: Switch to virXMLPropEnumDefault() virDomainDiskSourceNVMeParse: Switch to virXMLPropEnumDefault() virDomainDiskDefMirrorParse: Switch to virXMLPropEnumDefault() virDomainDiskSourcePoolDefParse: Switch to virXMLPropEnumDefault() virDomainDiskDefParseSourceXML: Switch to virXMLPropEnumDefault() virDomainChrDefParseXML: Switch to virXMLPropEnumDefault() virDomainTPMDefParseXML: Switch to virXMLPropEnumDefault() virDomainPanicDefParseXML: Switch to virXMLPropEnumDefault() virDomainInputDefParseXML: Switch to virXMLPropEnumDefault() virDomainHubDefParseXML: Switch to virXMLPropEnumDefault() virDomainTimerDefParseXML: Switch to virXMLPropEnumDefault() src/ch/ch_monitor.c | 2 +- src/conf/backup_conf.c | 16 +- src/conf/backup_conf.h | 2 +- src/conf/device_conf.c | 12 +- src/conf/device_conf.h | 4 +- src/conf/domain_audit.c | 2 +- src/conf/domain_conf.c | 494 ++++++------------ src/conf/domain_conf.h | 54 +- src/conf/domain_validate.c | 6 +- src/conf/storage_source_conf.c | 2 +- src/conf/storage_source_conf.h | 8 +- src/conf/virchrdev.c | 29 + src/libxl/libxl_conf.c | 32 +- src/libxl/libxl_domain.c | 2 +- src/libxl/xen_common.c | 29 +- src/libxl/xen_xl.c | 7 +- src/libxl/xen_xm.c | 3 + src/locking/domain_lock.c | 2 +- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_controller.c | 2 +- src/qemu/qemu_backup.c | 2 +- src/qemu/qemu_block.c | 14 +- src/qemu/qemu_cgroup.c | 12 + src/qemu/qemu_command.c | 49 +- src/qemu/qemu_domain.c | 44 +- src/qemu/qemu_domain_address.c | 4 +- src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 4 +- src/qemu/qemu_migration.c | 6 +- src/qemu/qemu_monitor.c | 54 +- src/qemu/qemu_monitor_json.c | 4 +- src/qemu/qemu_process.c | 10 +- src/qemu/qemu_snapshot.c | 16 +- src/qemu/qemu_validate.c | 19 +- src/security/security_apparmor.c | 6 +- src/security/security_dac.c | 8 +- src/security/security_selinux.c | 28 +- .../storage_file_backend_gluster.c | 2 +- src/storage_file/storage_source.c | 4 +- .../storage_source_backingstore.c | 16 +- src/vmx/vmx.c | 26 + tests/qemuxml2argvtest.c | 2 +- tests/testutilsqemu.c | 2 +- 43 files changed, 557 insertions(+), 489 deletions(-) -- 2.35.1

3 39

[libvirt PATCH] docs: contact: recommend the TLS port for IRC
by Ján Tomko 01 Jun '22

01 Jun '22

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- docs/contact.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contact.rst b/docs/contact.rst index 19e1b66a52..f8f7e806b3 100644 --- a/docs/contact.rst +++ b/docs/contact.rst @@ -80,7 +80,7 @@ Some of the libvirt developers may be found on IRC on the `OFTC IRC <https://oftc.net>`__ network. Use the settings: - server: irc.oftc.net -- port: 6667 (the usual IRC port) +- port: 6697 (the usual IRC TLS port) - channel: #virt NB There is no guarantee that someone will be watching or able to reply -- 2.35.1

2 1

[libvirt PATCH] Fix typos
by Tim Wiederhake 01 Jun '22

01 Jun '22

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/qemu/qemu_fd.c | 2 +- src/util/virfile.c | 2 +- tests/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_fd.c b/src/qemu/qemu_fd.c index bc6a37663c..6311161657 100644 --- a/src/qemu/qemu_fd.c +++ b/src/qemu/qemu_fd.c @@ -262,7 +262,7 @@ qemuFDPassDirectFree(qemuFDPassDirect *fdpass) * @fd: The FD, cleared when passed. * * The qemuFDPassDirect helper returned by this helper is used to hold a FD - * passed to qemu either direcly via FD number when used on commandline or the + * passed to qemu either directly via FD number when used on commandline or the * 'getfd' QMP command. */ qemuFDPassDirect * diff --git a/src/util/virfile.c b/src/util/virfile.c index e4522b5f67..99da058db3 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -4595,7 +4595,7 @@ struct runIOParams { * * Execute the copy based on the passed parameters. * - * Returns: size transfered, or < 0 on error. + * Returns: size transferred, or < 0 on error. */ static off_t diff --git a/tests/meson.build b/tests/meson.build index 1871f5e611..bc9d8ccc4c 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -47,7 +47,7 @@ tests_env = [ # # (process:50880): GLib-WARNING **: 02:54:15.272: poll(2) failed due to: Bad file descriptor. # -# Our code is inherantly racy, calling g_source_destroy which +# Our code is inherently racy, calling g_source_destroy which # removes the FD from the event thread poll asynchronously # but we close the FD immediately after g_source_destroy returns. # -- 2.31.1

2 1

[PATCH 00/15] docs: Convert some pages to rST and clean up (part 6)
by Peter Krempa 01 Jun '22

01 Jun '22

After this series only 2 non-generated HTML files remain: - index.html.in - 404.html.in It is possible to convert these but the utility of doing so may not be great for now. Additionally this series cleans up some long-broken links and removes unneeded raw HTML passthrough to declare anchors. Pavel Hrdina (2): docs: storage: rename headers to remove duplicate names docs: Convert 'storage' page to rst Peter Krempa (13): docs: formatsecret: Correct link to storage volume XML definition Correct links to TLS certificate setup page docs: Convert 'remote' page to rst docs: remote: Remove 'Limitations' paragraph docs: Convert 'uri' page to rst docs: uri: Remove old 'NULL URI' section docs: uri: Consolidate paragraphs on Xen URIs docs: uri: Move the 'test' hypervisor under a 'local hypervisors heading docs: uri: Rewrite section about transport protocols and extra parameters docs: governance: Remove unused HTML anchors docs: contact: Remove HTML anchors and adjust documents using them docs: bugs: Remove raw HTML anchor 'quality' docs: formatdomain: Remove old unreferenced HTML anchors .gitlab/issue_templates/bug.md | 2 +- docs/bugs.rst | 5 - docs/contact.rst | 11 +- docs/contribute.rst | 10 +- docs/drvesx.rst | 5 +- docs/formatdomain.rst | 112 ----- docs/formatsecret.rst | 8 +- docs/governance.rst | 5 - docs/kbase/tlscerts.rst | 4 +- docs/meson.build | 6 +- docs/page.xsl | 2 +- docs/remote.html.in | 297 ------------ docs/remote.rst | 209 +++++++++ docs/securityprocess.rst | 4 +- docs/storage.html.in | 833 --------------------------------- docs/storage.rst | 790 +++++++++++++++++++++++++++++++ docs/uri.html.in | 507 -------------------- docs/uri.rst | 405 ++++++++++++++++ tools/virt-pki-validate.in | 10 +- 19 files changed, 1431 insertions(+), 1794 deletions(-) delete mode 100644 docs/remote.html.in create mode 100644 docs/remote.rst delete mode 100644 docs/storage.html.in create mode 100644 docs/storage.rst delete mode 100644 docs/uri.html.in create mode 100644 docs/uri.rst -- 2.35.1

3 20

Release of libvirt-8.4.0
by Jiri Denemark 01 Jun '22

01 Jun '22

The 8.4.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * qemu: D-Bus display Libvirt is now able to setup a D-Bus display export, either with a private bus or in p2p mode. This display is available in QEMU 7.0.0. * qemu: ppc64 Power10 processor support Support for the recently released IBM Power10 processor was added. * qemu: Introduce ``absolute`` clock offset The ``absolute`` clock offset type allows to set the guest clock to an arbitrary epoch timestamp at each start. This is useful if some VM needs to be kept set to an arbitrary time for e.g. testing or working around broken software. * qemu: add qemu-vdagent channel This paravirtualized qemu vdagent channel can enable copy and paste between a guest and a VNC client. It is available in QEMU 6.1.0. * api: Add new APIs ``virDomainSaveParams`` and ``virDomainRestoreParams`` * ``virDomainSaveParams``: An alternative domain saving API, extends ``virDomainSaveFlags`` by adding parameters. * ``virDomainRestoreParams``: An alternative domain restoring API, extends ``virDomainRestoreFlags`` by adding parameters. * Bug fixes * Improve heuristics for computing baseline CPU models Both ``virConnectBaselineHypervisorCPU`` and ``virConnectBaselineCPU`` were in some cases computing the result using a CPU model which was newer than some of the input models. For example, ``Cascadelake-Server`` was used as a baseline for ``Skylake-Server-IBRS`` and ``Cascadelake-Server``. The CPU model selection heuristics was improved to choose a more appropriate model. Enjoy. Jirka

1 0

[PATCH RESEND 0/3] network: Generate TFTP config regardless of DHCP
by Michal Privoznik 01 Jun '22

01 Jun '22

This is rebased version of: https://listman.redhat.com/archives/libvir-list/2021-December/226045.html Michal Prívozník (3): network: Initialize variables in networkDnsmasqConfContents() network: Separate DHCP config generator into a function network: Generate TFTP config regardless of DHCP src/network/bridge_driver.c | 259 ++++++++++-------- .../networkxml2confdata/netboot-network.conf | 4 +- tests/networkxml2confdata/netboot-tftp.conf | 13 + tests/networkxml2confdata/netboot-tftp.xml | 9 + tests/networkxml2conftest.c | 1 + tests/networkxml2xmlin/netboot-tftp.xml | 1 + tests/networkxml2xmlout/netboot-tftp.xml | 1 + tests/networkxml2xmltest.c | 1 + 8 files changed, 170 insertions(+), 119 deletions(-) create mode 100644 tests/networkxml2confdata/netboot-tftp.conf create mode 100644 tests/networkxml2confdata/netboot-tftp.xml create mode 120000 tests/networkxml2xmlin/netboot-tftp.xml create mode 120000 tests/networkxml2xmlout/netboot-tftp.xml -- 2.35.1

2 4

[PATCH 00/67] docs: Fix and clean up anchor links
by Peter Krempa 01 Jun '22

01 Jun '22

First 50 patches remove the use of raw HTML passthrough in formatdomain.rst, which is the only outstanding place which still does. Most of the work was done by a ad-hoc bash script, but manual tweaks were needed. Since this series also contains a test script which validates linking I'm not going to publish the conversion script. The rest of the series then cleans up pre-existing broken links and adds the aforementioned checker script. One more change is to prevent the use of external references in RST to refer to the same file. All usage was converted to local references and a syntax check was added. One slight drawback of the checker script is that it works on generated HTML files and thus the error message contains the output file name and not the source RST document. Output after the fixes can be browsed at: https://gitlab.com/pipo.sk/libvirt/-/jobs/2528184702/artifacts/browse/websi… Peter Krempa (67): docs: formatdomain: Remove 'elements' anchor docs: formatdomain: Remove 'elementsMetadata' anchor docs: formatdomain: Remove 'elementsOS' anchor docs: formatdomain: Remove 'elementsOSBIOS' anchor docs: formatdomain: Remove 'elementsOSContainer' anchor docs: formatdomain: Remove 'elementsSysinfo' anchor docs: formatdomain: Remove 'elementsCPUAllocation' anchor docs: formatdomain: Remove 'elementsIOThreadsAllocation' anchor docs: formatdomain: Remove 'elementsCPUTuning' anchor docs: formatdomain: Remove 'elementsMemoryAllocation' anchor docs: formatdomain: Remove 'elementsMemoryBacking' anchor docs: formatdomain: Remove 'elementsMemoryTuning' anchor docs: formatdomain: Remove 'elementsNUMATuning' anchor docs: formatdomain: Remove 'elementsBlockTuning' anchor docs: formatdomain: Remove 'elementsCPU' anchor docs: formatdomain: Remove 'hmat' anchor docs: formatdomain: Remove 'elementsEvents' anchor docs: formatdomain: Remove 'elementsFeatures' anchor docs: formatdomain: Remove 'elementsDevices' anchor docs: formatdomain: Remove 'elementsDisks' anchor docs: formatdomain: Remove 'elementsAddress' anchor docs: formatdomain: Remove 'elementsVirtio' anchor docs: formatdomain: Remove 'elementsVirtioTransitional' anchor docs: formatdomain: Remove 'elementsControllers' anchor docs: formatdomain: Remove 'elementsHostDev' anchor docs: formatdomain: Remove 'elementsNICS' anchor docs: formatdomain: Remove 'elementsNICSDirect' anchor docs: formatdomain: Remove 'elementsNICSTargetOverride' anchor docs: formatdomain: Remove 'elementQoS' anchor docs: formatdomain: Remove 'elementVlanTag' anchor docs: formatdomain: Remove 'elementPort' anchor docs: formatdomain: Remove 'mtu' anchor docs: formatdomain: Remove 'coalesce' anchor docs: formatdomain: Remove 'elementVhostuser' anchor docs: formatdomain: Remove 'elementsGraphics' anchor docs: formatdomain: Remove 'elementsVideo' anchor docs: formatdomain: Remove 'elementsConsole' anchor docs: formatdomain: Remove 'elementCharSerial' anchor docs: formatdomain: Remove 'elementCharSerialAndConsole' anchor docs: formatdomain: Remove 'elementsCharHostInterface' anchor docs: formatdomain: Remove 'elementsCharHost' anchor docs: formatdomain: Remove 'elementsAudio' anchor docs: formatdomain: Remove 'elementsTpm' anchor docs: formatdomain: Remove 'elementsMemory' anchor docs: formatdomain: Remove 'elementsIommu' anchor docs: formatdomain: Remove 'vsock' anchor docs: formatdomain: Remove 'seclabel' anchor docs: formatdomain: Remove 'keywrap' anchor docs: formatdomain: Remove 'launchSecurity' anchor docs: formatdomain: Remove the 'anchor' role docs: formatdomain: Use local reference directly docs: uri: Fix link to libvirtd configuration section syntax-check: Add check prohibiting remote reference to local file docs: page.xsl: Fix link to 'mailing-lists' section docs: domainstatecapture: Fix broken links docs: rpc: Fix broken headings docs: formatcaps: Fix anchors of links into formatdomain.rst scripts: hvsupport: Remove link into the 'html' directory docs: Fix link to 'tlscerts' article docs: Remove extra leading slash in 'api' and 'formatdomaincaps' pages docs: Fix links in kbase/internals docs: kbase/kvm-realtime: Fix few links docs: kbase/tlscerts: Fix links docs: remote: Fix anchor names in links to uri.html uri: Fix link to qemu KVM example config docs: formatstorageencryption: Use correct anchor into formatsecret page docs: Add HTML reference checker build-aux/syntax-check.mk | 7 + docs/api.rst | 2 +- docs/docs.rst | 2 +- docs/drvlxc.rst | 2 +- docs/formatbackup.rst | 6 +- docs/formatcaps.rst | 10 +- docs/formatcheckpoint.rst | 2 +- docs/formatdomain.rst | 360 ++++++++++++----------------- docs/formatdomaincaps.rst | 20 +- docs/formatnetwork.rst | 8 +- docs/formatnetworkport.rst | 4 +- docs/formatnode.rst | 2 +- docs/formatsecret.rst | 12 +- docs/formatsnapshot.rst | 8 +- docs/formatstorageencryption.rst | 2 +- docs/kbase/domainstatecapture.rst | 12 +- docs/kbase/internals/eventloop.rst | 2 +- docs/kbase/internals/migration.rst | 2 +- docs/kbase/internals/rpc.rst | 16 +- docs/kbase/kvm-realtime.rst | 10 +- docs/kbase/launch_security_sev.rst | 2 +- docs/kbase/locking-sanlock.rst | 2 +- docs/kbase/memorydevices.rst | 2 +- docs/kbase/s390_protected_virt.rst | 2 +- docs/kbase/tlscerts.rst | 8 +- docs/manpages/virsh.rst | 8 +- docs/meson.build | 11 + docs/page.xsl | 2 +- docs/remote.rst | 4 +- docs/storage.rst | 6 +- docs/uri.rst | 4 +- scripts/check-html-references.py | 153 ++++++++++++ scripts/hvsupport.py | 2 +- scripts/meson.build | 1 + 34 files changed, 402 insertions(+), 294 deletions(-) create mode 100755 scripts/check-html-references.py -- 2.35.3

2 81