- Devel - libvirt List Archives

[libvirt] Fix wrong nodeinfo->mhz when cpufreq is enabled
by Thomas Treutner 04 Feb '10

04 Feb '10

Hi, I've written a little patch to fix wrong nodeinfo->mhz when the Linux kernel module cpufreq and a typical governor like ondemand are loaded. nodeinfo->mhz is then too low as libvirt just reads /proc/cpuinfo, entry "cpu MHz". This patch reads /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq if existing and corrects nodeinfo->mhz if the value found is higher. Using cpu0 is a crude hack but as discussed on IRC, considering different governors/maximum frequencies per cpu/core would require changing the nodeinfo struct, which would break the API. Some more info: https://bugzilla.redhat.com/show_bug.cgi?id=559762 Please have a careful look at my patch, my last C is quite some time ago. I tried to stick to linuxNodeInfoCPUPopulate, but f.e., checking for "&& *p == '\0'" after virStrToLong_ui doesn't work and I'm wondering why scaling_max_freq may not be terminated with by NUL? I also hope the file handling is correct, but please have a look. There is still some todo: Some logging would be helpful, maybe one of you could point out which function best to use? This is my first patch, so hopefully it follows in the next mail ;-) kr, tom

2 2

[libvirt] [PATCH] virt-pki-validate contains unexpanded SYSCONFDIR variable
by Doug Goldstein 04 Feb '10

04 Feb '10

virt-pki-validate contains an unexpanded SYSCONFDIR variable which causes it not to function at all. --- tools/virt-pki-validate.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virt-pki-validate.in b/tools/virt-pki-validate.in index a428a96..3e8c642 100755 --- a/tools/virt-pki-validate.in +++ b/tools/virt-pki-validate.in @@ -25,7 +25,7 @@ echo Found $CERTOOL # # Check the directory structure # -PKI="$(SYSCONFDIR)/pki" +PKI="@SYSCONFDIR@/pki" if [ ! -d $PKI ] then echo the $PKI directory is missing, it is usually -- 1.6.6.1

3 2

[libvirt] [PATCH] esx: Remove unnecessary casts
by Matthias Bolte 04 Feb '10

04 Feb '10

--- src/esx/esx_driver.c | 74 +++++++++++++++++++++++++------------------------- 1 files changed, 37 insertions(+), 37 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index fc254c6..fc5a50e 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -558,7 +558,7 @@ esxOpen(virConnectPtr conn, virConnectAuthPtr auth, int flags ATTRIBUTE_UNUSED) static int esxClose(virConnectPtr conn) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_EnsureSession(priv->host); @@ -645,7 +645,7 @@ esxSupportsVMotion(esxPrivate *priv) static int esxSupportsFeature(virConnectPtr conn, int feature) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_Boolean supportsVMotion = esxVI_Boolean_Undefined; switch (feature) { @@ -678,7 +678,7 @@ esxGetType(virConnectPtr conn ATTRIBUTE_UNUSED) static int esxGetVersion(virConnectPtr conn, unsigned long *version) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; char *temp; unsigned int major, minor, release; @@ -716,7 +716,7 @@ esxGetVersion(virConnectPtr conn, unsigned long *version) static char * esxGetHostname(virConnectPtr conn) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *hostSystem = NULL; esxVI_DynamicProperty *dynamicProperty = NULL; @@ -805,7 +805,7 @@ static int esxNodeGetInfo(virConnectPtr conn, virNodeInfoPtr nodeinfo) { int result = 0; - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *hostSystem = NULL; esxVI_DynamicProperty *dynamicProperty = NULL; @@ -958,7 +958,7 @@ esxNodeGetInfo(virConnectPtr conn, virNodeInfoPtr nodeinfo) static char * esxGetCapabilities(virConnectPtr conn) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; char *xml = virCapabilitiesFormatXML(priv->caps); if (xml == NULL) { @@ -974,7 +974,7 @@ esxGetCapabilities(virConnectPtr conn) static int esxListDomains(virConnectPtr conn, int *ids, int maxids) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_ObjectContent *virtualMachineList = NULL; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; @@ -1046,7 +1046,7 @@ esxListDomains(virConnectPtr conn, int *ids, int maxids) static int esxNumberOfDomains(virConnectPtr conn) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; if (esxVI_EnsureSession(priv->host) < 0) { return -1; @@ -1062,7 +1062,7 @@ esxNumberOfDomains(virConnectPtr conn) static virDomainPtr esxDomainLookupByID(virConnectPtr conn, int id) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *virtualMachineList = NULL; esxVI_ObjectContent *virtualMachine = NULL; @@ -1145,7 +1145,7 @@ esxDomainLookupByID(virConnectPtr conn, int id) static virDomainPtr esxDomainLookupByUUID(virConnectPtr conn, const unsigned char *uuid) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *virtualMachine = NULL; esxVI_VirtualMachinePowerState powerState; @@ -1199,7 +1199,7 @@ esxDomainLookupByUUID(virConnectPtr conn, const unsigned char *uuid) static virDomainPtr esxDomainLookupByName(virConnectPtr conn, const char *name) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *virtualMachineList = NULL; esxVI_ObjectContent *virtualMachine = NULL; @@ -1283,7 +1283,7 @@ static int esxDomainSuspend(virDomainPtr domain) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; esxVI_VirtualMachinePowerState powerState; @@ -1338,7 +1338,7 @@ static int esxDomainResume(virDomainPtr domain) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; esxVI_VirtualMachinePowerState powerState; @@ -1393,7 +1393,7 @@ static int esxDomainShutdown(virDomainPtr domain) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; esxVI_VirtualMachinePowerState powerState; @@ -1438,7 +1438,7 @@ static int esxDomainReboot(virDomainPtr domain, unsigned int flags ATTRIBUTE_UNUSED) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; esxVI_VirtualMachinePowerState powerState; @@ -1483,7 +1483,7 @@ static int esxDomainDestroy(virDomainPtr domain) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_Context *ctx = NULL; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; @@ -1559,7 +1559,7 @@ esxDomainGetOSType(virDomainPtr domain ATTRIBUTE_UNUSED) static unsigned long esxDomainGetMaxMemory(virDomainPtr domain) { - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *virtualMachine = NULL; esxVI_DynamicProperty *dynamicProperty = NULL; @@ -1616,7 +1616,7 @@ static int esxDomainSetMaxMemory(virDomainPtr domain, unsigned long memory) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_VirtualMachineConfigSpec *spec = NULL; esxVI_ManagedObjectReference *task = NULL; @@ -1669,7 +1669,7 @@ static int esxDomainSetMemory(virDomainPtr domain, unsigned long memory) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_VirtualMachineConfigSpec *spec = NULL; esxVI_ManagedObjectReference *task = NULL; @@ -1723,7 +1723,7 @@ static int esxDomainGetInfo(virDomainPtr domain, virDomainInfoPtr info) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *virtualMachine = NULL; esxVI_DynamicProperty *dynamicProperty = NULL; @@ -1978,7 +1978,7 @@ static int esxDomainSetVcpus(virDomainPtr domain, unsigned int nvcpus) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; int maxVcpus; esxVI_ObjectContent *virtualMachine = NULL; esxVI_VirtualMachineConfigSpec *spec = NULL; @@ -2050,7 +2050,7 @@ esxDomainSetVcpus(virDomainPtr domain, unsigned int nvcpus) static int esxDomainGetMaxVcpus(virDomainPtr domain) { - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *hostSystem = NULL; esxVI_DynamicProperty *dynamicProperty = NULL; @@ -2109,7 +2109,7 @@ esxDomainGetMaxVcpus(virDomainPtr domain) static char * esxDomainDumpXML(virDomainPtr domain, int flags) { - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *virtualMachine = NULL; esxVI_DynamicProperty *dynamicProperty = NULL; @@ -2211,7 +2211,7 @@ esxDomainXMLFromNative(virConnectPtr conn, const char *nativeFormat, const char *nativeConfig, unsigned int flags ATTRIBUTE_UNUSED) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; virDomainDefPtr def = NULL; char *xml = NULL; @@ -2240,7 +2240,7 @@ esxDomainXMLToNative(virConnectPtr conn, const char *nativeFormat, const char *domainXml, unsigned int flags ATTRIBUTE_UNUSED) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; virDomainDefPtr def = NULL; char *vmx = NULL; @@ -2268,7 +2268,7 @@ esxDomainXMLToNative(virConnectPtr conn, const char *nativeFormat, static int esxListDefinedDomains(virConnectPtr conn, char **const names, int maxnames) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *virtualMachineList = NULL; esxVI_ObjectContent *virtualMachine = NULL; @@ -2358,7 +2358,7 @@ esxListDefinedDomains(virConnectPtr conn, char **const names, int maxnames) static int esxNumberOfDefinedDomains(virConnectPtr conn) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; if (esxVI_EnsureSession(priv->host) < 0) { return -1; @@ -2375,7 +2375,7 @@ static int esxDomainCreate(virDomainPtr domain) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; esxVI_VirtualMachinePowerState powerState; @@ -2430,7 +2430,7 @@ esxDomainCreate(virDomainPtr domain) static virDomainPtr esxDomainDefineXML(virConnectPtr conn, const char *xml ATTRIBUTE_UNUSED) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; virDomainDefPtr def = NULL; char *vmx = NULL; int i; @@ -2638,7 +2638,7 @@ static int esxDomainUndefine(virDomainPtr domain) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_Context *ctx = NULL; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; @@ -2740,7 +2740,7 @@ esxDomainGetSchedulerParameters(virDomainPtr domain, virSchedParameterPtr params, int *nparams) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *virtualMachine = NULL; esxVI_DynamicProperty *dynamicProperty = NULL; @@ -2869,7 +2869,7 @@ esxDomainSetSchedulerParameters(virDomainPtr domain, virSchedParameterPtr params, int nparams) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_VirtualMachineConfigSpec *spec = NULL; esxVI_SharesInfo *sharesInfo = NULL; @@ -3040,7 +3040,7 @@ esxDomainMigratePerform(virDomainPtr domain, unsigned long bandwidth ATTRIBUTE_UNUSED) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; xmlURIPtr xmlUri = NULL; char hostIpAddress[NI_MAXHOST] = ""; esxVI_ObjectContent *virtualMachine = NULL; @@ -3171,7 +3171,7 @@ static unsigned long long esxNodeGetFreeMemory(virConnectPtr conn) { unsigned long long result = 0; - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; esxVI_String *propertyNameList = NULL; esxVI_ObjectContent *hostSystem = NULL; esxVI_ManagedObjectReference *managedObjectReference = NULL; @@ -3249,7 +3249,7 @@ esxNodeGetFreeMemory(virConnectPtr conn) static int esxIsEncrypted(virConnectPtr conn) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; if (STRCASEEQ(priv->transport, "https")) { return 1; @@ -3263,7 +3263,7 @@ esxIsEncrypted(virConnectPtr conn) static int esxIsSecure(virConnectPtr conn) { - esxPrivate *priv = (esxPrivate *)conn->privateData; + esxPrivate *priv = conn->privateData; if (STRCASEEQ(priv->transport, "https")) { return 1; @@ -3278,7 +3278,7 @@ static int esxDomainIsActive(virDomainPtr domain) { int result = 0; - esxPrivate *priv = (esxPrivate *)domain->conn->privateData; + esxPrivate *priv = domain->conn->privateData; esxVI_ObjectContent *virtualMachine = NULL; esxVI_String *propertyNameList = NULL; esxVI_VirtualMachinePowerState powerState; -- 1.6.3.3

1 0

[libvirt] [PATCH] cgroup.c: avoid unconditional leaks
by Jim Meyering 04 Feb '10

04 Feb '10

Here's output from "git format-patch -U19 --stdout -1", so you see the context: >From 47ea9beecf93a796e606b4d906424c05e7f6c9bb Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 4 Feb 2010 11:14:03 +0100 Subject: [PATCH] cgroup.c: avoid unconditional leaks * src/util/cgroup.c (virCgroupCpuSetInherit) [HAVE_MNTENT_H]: Don't leak CPU-set inheritance value strings. --- src/util/cgroup.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/cgroup.c b/src/util/cgroup.c index c80cf50..e6f0270 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -416,38 +416,39 @@ static int virCgroupCpuSetInherit(virCgroupPtr parent, virCgroupPtr group) VIR_DEBUG("Setting up inheritance %s -> %s", parent->path, group->path); for (i = 0; i < ARRAY_CARDINALITY(inherit_values) ; i++) { char *value; rc = virCgroupGetValueStr(parent, VIR_CGROUP_CONTROLLER_CPUSET, inherit_values[i], &value); if (rc != 0) { VIR_ERROR("Failed to get %s %d", inherit_values[i], rc); break; } VIR_DEBUG("Inherit %s = %s", inherit_values[i], value); rc = virCgroupSetValueStr(group, VIR_CGROUP_CONTROLLER_CPUSET, inherit_values[i], value); + VIR_FREE(value); if (rc != 0) { VIR_ERROR("Failed to set %s %d", inherit_values[i], rc); break; } } return rc; } static int virCgroupMakeGroup(virCgroupPtr parent, virCgroupPtr group, int create) { int i; int rc = 0; VIR_DEBUG("Make group %s", group->path); for (i = 0 ; i < VIR_CGROUP_CONTROLLER_LAST ; i++) { char *path = NULL; -- 1.7.0.rc1.193.ge8618

4 5

[libvirt] [PATCH] virDomainChrDefParseXML: don't leak upon invalid input
by Jim Meyering 04 Feb '10

04 Feb '10

>From 6d0e0e571bba7792df9dacb898849708d5d3b425 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 4 Feb 2010 12:49:53 +0100 Subject: [PATCH] virDomainChrDefParseXML: don't leak upon invalid input * src/conf/domain_conf.c (virDomainChrDefParseXML): Don't leak a virDomainChrDef buffer upon "unknown target type for char device" error. --- src/conf/domain_conf.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 766993c..306776d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1947,6 +1947,7 @@ virDomainChrDefParseXML(virConnectPtr conn, virDomainReportError(conn, VIR_ERR_XML_ERROR, _("unknown target type for character device: %s"), nodeName); + VIR_FREE(def); return NULL; } def->targetType = VIR_DOMAIN_CHR_TARGET_TYPE_NULL; -- 1.7.0.rc1.199.g9253a

2 1

[libvirt] [PATCH] virExecWithHook: avoid leak on OOM error path
by Jim Meyering 04 Feb '10

04 Feb '10

>From ab102cf853e3b46bf10cf0faafa643a352ed8888 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 4 Feb 2010 12:25:34 +0100 Subject: [PATCH] virExecWithHook: avoid leak on OOM error path * src/util/util.c (virExecWithHook): Free argv_str string before returning upon failure to allocate space for environment. --- src/util/util.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 7e0cd50..a01fc45 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -625,18 +625,19 @@ virExecWithHook(virConnectPtr conn, char *envp_str; if ((argv_str = virArgvToString(argv)) == NULL) { virReportOOMError(conn); return -1; } if (envp) { if ((envp_str = virArgvToString(envp)) == NULL) { + VIR_FREE(argv_str); virReportOOMError(conn); return -1; } VIR_DEBUG("%s %s", envp_str, argv_str); VIR_FREE(envp_str); } else { VIR_DEBUG0(argv_str); } VIR_FREE(argv_str); -- 1.7.0.rc1.199.g9253a

2 1

[libvirt] [PATCH] cgroup.c: don't leak mem+FD upon OOM
by Jim Meyering 04 Feb '10

04 Feb '10

Here's the patch: (note, no need to test for mapping == NULL in the no_memory block) >From 91dbe896fff64783df1c68769a57a267441143ae Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Thu, 4 Feb 2010 11:22:20 +0100 Subject: [PATCH] cgroup.c: don't leak mem+FD upon OOM * src/util/cgroup.c (virCgroupDetectPlacement): Close the mapping FILE* also upon error. --- src/util/cgroup.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/cgroup.c b/src/util/cgroup.c index e6f0270..4446c7f 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -183,6 +183,7 @@ static int virCgroupDetectPlacement(virCgroupPtr group) return 0; no_memory: + fclose(mapping); return -ENOMEM; } -- 1.7.0.rc1.193.ge8618 Here's the (fixed) function: /* * Process /proc/self/cgroup figuring out what cgroup * sub-path the current process is assigned to. ie not * neccessarily in the root */ static int virCgroupDetectPlacement(virCgroupPtr group) { int i; FILE *mapping = NULL; char line[1024]; mapping = fopen("/proc/self/cgroup", "r"); if (mapping == NULL) { VIR_ERROR0("Unable to open /proc/self/cgroup"); return -ENOENT; } while (fgets(line, sizeof(line), mapping) != NULL) { char *controllers = strchr(line, ':'); char *path = controllers ? strchr(controllers+1, ':') : NULL; char *nl = path ? strchr(path, '\n') : NULL; if (!controllers || !path) continue; if (nl) *nl = '\0'; *path = '\0'; controllers++; path++; for (i = 0 ; i < VIR_CGROUP_CONTROLLER_LAST ; i++) { const char *typestr = virCgroupControllerTypeToString(i); int typelen = strlen(typestr); char *tmp = controllers; while (tmp) { char *next = strchr(tmp, ','); int len; if (next) { len = next-tmp; next++; } else { len = strlen(tmp); } if (typelen == len && STREQLEN(typestr, tmp, len) && !(group->controllers[i].placement = strdup(STREQ(path, "/") ? "" : path))) goto no_memory; tmp = next; } } } fclose(mapping); return 0; no_memory: fclose(mapping); return -ENOMEM; }

2 1

[libvirt] [PATCH 5/5] macvtap support for libvirt -- schema extensions
by Stefan Berger 04 Feb '10

04 Feb '10

This part extends the domain xml schema to support the new interface type 'direct'. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>

1 0

[libvirt] [PATCH 3/5] macvtap support for libvirt -- qemu support
by Stefan Berger 04 Feb '10

04 Feb '10

This part adds support for qemu making a macvtap tap device available via file descriptor passed to qemu command line. This also attempts to tear down the macvtap device when a VM terminates. This includes support for attachment and detachment to/from running VM. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>

1 0

[libvirt] [PATCH 1/5] macvtap support for libvirt -- build support
by Stefan Berger 04 Feb '10

04 Feb '10

This patch adds build support for libvirt checking for certain contents of /usr/include/linux/if_link.h to see whether macvtap support is compilable on that system. One can disable macvtap support in libvirt via --without-macvtap passed to configure. Signed-off-by: Stefan Berger <stefanb(a)us.ibm.com>

1 0