- Devel - libvirt List Archives

[PATCH 0/3] lib: Replace qsort() with g_qsort_with_data()
by Michal Privoznik 23 Nov '23

23 Nov '23

Technically, this is a v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/GBTH… but it implements a different approach, so I'm sending it anew. Michal Prívozník (3): build-aux: Refresh list of nonreentrant functions lib: Replace qsort() with g_qsort_with_data() syntax-check: Forbid use of qsort() build-aux/Makefile.nonreentrant | 18 +++++++------- build-aux/syntax-check.mk | 9 ++++++- src/conf/capabilities.c | 8 ++++--- src/conf/domain_conf.c | 6 +++-- src/cpu/cpu.c | 7 +++--- src/cpu/cpu_x86.c | 15 +++++++----- src/lxc/lxc_container.c | 3 ++- src/nwfilter/nwfilter_ebiptables_driver.c | 29 +++++++++++++++-------- src/qemu/qemu_monitor_json.c | 6 +++-- src/qemu/qemu_process.c | 7 +++--- src/security/security_manager.c | 9 ++++--- src/util/virfile.c | 8 ++++--- src/util/virhash.c | 9 ++++--- src/util/virresctrl.c | 9 ++++--- src/util/virstring.c | 12 ++++++---- src/util/virstring.h | 8 +++++-- src/util/virtypedparam.c | 9 ++++--- tests/commandhelper.c | 6 +++-- tests/virstringtest.c | 8 +++---- tools/nss/libvirt_nss.c | 3 ++- tools/virsh-checkpoint.c | 10 ++++---- tools/virsh-domain-monitor.c | 11 +++++---- tools/virsh-host.c | 7 ++++-- tools/virsh-interface.c | 11 +++++---- tools/virsh-network.c | 29 +++++++++++++++-------- tools/virsh-nodedev.c | 11 +++++---- tools/virsh-nwfilter.c | 22 ++++++++++------- tools/virsh-pool.c | 11 +++++---- tools/virsh-secret.c | 11 +++++---- tools/virsh-snapshot.c | 10 ++++---- tools/virsh-volume.c | 10 +++++--- 31 files changed, 213 insertions(+), 119 deletions(-) -- 2.41.0

3 5

[PATCH 0/5] conf: Check for dimm/nvimm address conflicts too
by Michal Privoznik 23 Nov '23

23 Nov '23

*** BLURB HERE *** Michal Prívozník (5): domain_validate: Move memdevice address conflict check into a separate function qemuxml2argvdata: Extend memory-hotplug-virtio-mem-overlap-address.xml virDomainMemoryDefCheckConflict: Check dimm & nvdimm models too virDomainMemoryDefCheckConflict: Validate dimm slot too qemu_domain: Drop qemuCheckMemoryDimmConflict() src/conf/domain_validate.c | 165 +++++++++++------- src/qemu/qemu_domain.c | 37 ---- ...rtio-mem-overlap-address.x86_64-latest.err | 2 +- ...ory-hotplug-virtio-mem-overlap-address.xml | 19 +- 4 files changed, 123 insertions(+), 100 deletions(-) -- 2.41.0

3 13

[PULL 05/14] target/nios2: Deprecate the Nios II architecture
by Alex Bennée 23 Nov '23

23 Nov '23

From: Philippe Mathieu-Daudé <philmd(a)linaro.org> See commit 9ba1caf510 ("MAINTAINERS: Mark the Nios II CPU as orphan"), last contribution from Chris was in 2012 [1] and Marek in 2018 [2]. [1] https://lore.kernel.org/qemu-devel/1352607539-10455-2-git-send-email-crwulf… [2] https://lore.kernel.org/qemu-devel/805fc7b5-03f0-56d4-abfd-ed010d4fa769@den… Signed-off-by: Philippe Mathieu-Daudé <philmd(a)linaro.org> Reviewed-by: Richard Henderson <richard.henderson(a)linaro.org> Acked-by: Marek Vasut <marex(a)denx.de> Reviewed-by: Thomas Huth <thuth(a)redhat.com> Message-Id: <20231117070250.32932-1-philmd(a)linaro.org> Signed-off-by: Alex Bennée <alex.bennee(a)linaro.org> Message-Id: <20231120150833.2552739-6-alex.bennee(a)linaro.org> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 6c84db90b5..2e15040246 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -236,6 +236,16 @@ it. Since all recent x86 hardware from the past >10 years is capable of the 64-bit x86 extensions, a corresponding 64-bit OS should be used instead. +System emulator CPUs +-------------------- + +Nios II CPU (since 8.2) +''''''''''''''''''''''' + +The Nios II architecture is orphan. The ``nios2`` guest CPU support is +deprecated and will be removed in a future version of QEMU. + + System emulator machines ------------------------ @@ -254,6 +264,11 @@ These old machine types are quite neglected nowadays and thus might have various pitfalls with regards to live migration. Use a newer machine type instead. +Nios II ``10m50-ghrd`` and ``nios2-generic-nommu`` machines (since 8.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +The Nios II architecture is orphan. + Backend options --------------- diff --git a/hw/nios2/10m50_devboard.c b/hw/nios2/10m50_devboard.c index 952a0dc33e..6cb32f777b 100644 --- a/hw/nios2/10m50_devboard.c +++ b/hw/nios2/10m50_devboard.c @@ -160,6 +160,7 @@ static void nios2_10m50_ghrd_class_init(ObjectClass *oc, void *data) mc->desc = "Altera 10M50 GHRD Nios II design"; mc->init = nios2_10m50_ghrd_init; mc->is_default = true; + mc->deprecation_reason = "Nios II architecture is deprecated"; object_class_property_add_bool(oc, "vic", get_vic, set_vic); object_class_property_set_description(oc, "vic", diff --git a/hw/nios2/generic_nommu.c b/hw/nios2/generic_nommu.c index 48edb3ae37..defa16953f 100644 --- a/hw/nios2/generic_nommu.c +++ b/hw/nios2/generic_nommu.c @@ -95,6 +95,7 @@ static void nios2_generic_nommu_machine_init(struct MachineClass *mc) { mc->desc = "Generic NOMMU Nios II design"; mc->init = nios2_generic_nommu_init; + mc->deprecation_reason = "Nios II architecture is deprecated"; } DEFINE_MACHINE("nios2-generic-nommu", nios2_generic_nommu_machine_init); -- 2.39.2

1 0

[libvirt PATCH v2 0/5] ci: Build RPMs on MinGW
by Andrea Bolognani 23 Nov '23

23 Nov '23

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1075354744 Ignore the macOS 14 failure, it's caused by a temporary issue on the Cirrus CI side. Changes since [v1]: * a few patches have either been pushed (1-4) or are no longer needed (10), so they have been dropped; * the last patch has been tweaked a bit and the changes contained in it are now documented with a code comment. [v1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/Y2W2… Andrea Bolognani (5): rpm: Shuffle BuildRequires around rpm: Split call to mingw_debug_package rpm: Introduce with_mingw32/with_mingw64 rpm: Introduce with_native ci: Build RPMs on MinGW .gitlab-ci.yml | 11 +- ci/jobs.sh | 23 ++- libvirt.spec.in | 460 +++++++++++++++++++++++++++--------------------- 3 files changed, 285 insertions(+), 209 deletions(-) -- 2.41.0

2 6

[PATCH 0/3] qemuDomainAttachDeviceDiskLiveInternal: Fix error handling and properly hotplug empty cdroms
by Peter Krempa 23 Nov '23

23 Nov '23

Patch 3 is best viewed with '-w' Peter Krempa (3): qemuDomainAttachDeviceDiskLiveInternal: Fix jumps on error qemuDomainAttachDeviceDiskLiveInternal: Add missing jump to 'cleanup' on error qemu: hotplug: Don't try to setup disk image when hotplugging empty cdrom drive src/qemu/qemu_hotplug.c | 100 +++++++++++++++++++++------------------- 1 file changed, 53 insertions(+), 47 deletions(-) -- 2.42.0

2 4

Kernel issue or libvirt issue? Where to report?
by Koos Pol 22 Nov '23

22 Nov '23

Hi, After upgrading the VM host (os + kernel) a VM client can no longer use a pass-through USB device. The syslog of the VM host is flooded with: nov 08 19:59:46 vmhost kernel: usb 1-3: usbfs: process 1729 (qemu-system-x86) did not claim interface 1 before use Because of the upgrade the vm host has gotten both a new kernel version and a new libvirt verion. The vm client has not been touched. Before I waste everyone's time on an incorrect bug report, would you say I file this with libvirt or with the openSUSE kernel (the o.s. of the vmhost)? Thanks! Koos

2 2

[PATCH] qemu: validate: Reword error message when CCW addresses are not supported for a machine
by Peter Krempa 22 Nov '23

22 Nov '23

Reword the error message to clearly state that the machine type doesn't support the address type. It doesn't matter which device it's for. Additionally the alias may be still NULL at the point when the error is being reported misleading users that they have something wrong with a specific device. Resolves:https://issues.redhat.com/browse/RHEL-16878 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_validate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 93df9e4c8e..2afd7e128a 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1512,8 +1512,8 @@ qemuValidateDomainDeviceDefAddress(const virDomainDeviceDef *dev, case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: if (!qemuDomainIsS390CCW(def)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("cannot use CCW address type for device '%1$s' using machine type '%2$s'"), - NULLSTR(info->alias), def->os.machine); + _("CCW addresses are not supported by machine type '%1$s'"), + def->os.machine); return -1; } -- 2.41.0

3 2

[PATCH 0/2] Adapt to glibc qsort() turned unstable
by Michal Privoznik 22 Nov '23

22 Nov '23

glibc reworked qsort() which now uses an unstable sorting algorithm. This is causing issues to our tests (see broken pipeline for rawhide). Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1081297468 Michal Prívozník (2): tests: Introduce virqsortmock nwfilterxml2firewalltest: Use virqsortmock for stable sorting tests/meson.build | 1 + tests/nwfilterxml2firewalltest.c | 4 ++- tests/virqsortmock.c | 58 ++++++++++++++++++++++++++++++++ 3 files changed, 62 insertions(+), 1 deletion(-) create mode 100644 tests/virqsortmock.c -- 2.41.0

3 4

[PATCH 0/3] Introduce pipewire audio backend
by Michal Privoznik 22 Nov '23

22 Nov '23

This is a resend of patches from earlier: https://listman.redhat.com/archives/libvir-list/2023-May/239860.html Apparently, users want this now. Michal Prívozník (3): conf: Introduce pipewire audio backend qemu: Generate cmd line for pipewire audio backend NEWS: Document pipewire audio backend NEWS.rst | 10 +++ docs/formatdomain.rst | 35 +++++++++- src/conf/domain_conf.c | 70 +++++++++++++++++++ src/conf/domain_conf.h | 12 ++++ src/conf/schemas/domaincommon.rng | 37 ++++++++++ src/qemu/qemu_command.c | 63 +++++++++++++++++ src/qemu/qemu_validate.c | 1 + .../audio-many-backends.x86_64-latest.args | 2 + .../qemuxml2argvdata/audio-many-backends.xml | 1 + .../audio-pipewire-best.x86_64-latest.args | 36 ++++++++++ .../qemuxml2argvdata/audio-pipewire-best.xml | 43 ++++++++++++ .../audio-pipewire-full.x86_64-latest.args | 36 ++++++++++ .../qemuxml2argvdata/audio-pipewire-full.xml | 43 ++++++++++++ .../audio-pipewire-minimal.x86_64-latest.args | 36 ++++++++++ .../audio-pipewire-minimal.xml | 36 ++++++++++ tests/qemuxml2argvtest.c | 14 ++++ .../audio-many-backends.x86_64-latest.xml | 1 + .../audio-pipewire-best.x86_64-latest.xml | 46 ++++++++++++ .../audio-pipewire-full.x86_64-latest.xml | 46 ++++++++++++ .../audio-pipewire-minimal.x86_64-latest.xml | 39 +++++++++++ tests/qemuxml2xmltest.c | 3 + 21 files changed, 608 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/audio-pipewire-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-best.xml create mode 100644 tests/qemuxml2argvdata/audio-pipewire-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-full.xml create mode 100644 tests/qemuxml2argvdata/audio-pipewire-minimal.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-pipewire-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-best.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-full.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/audio-pipewire-minimal.x86_64-latest.xml -- 2.41.0

3 8

Plans for 9.10.0 release (freeze on Monday 27 Nov)
by Jiri Denemark 21 Nov '23

21 Nov '23

We are getting close to 9.10.0 release of libvirt. To aim for the release on Friday 01 Dec I suggest entering the freeze on Monday 27 Nov and tagging RC2 on Wednesday 29 Nov. I hope this works for everyone. Jirka

1 0