- Devel - libvirt List Archives

Re: Re: Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt
by Andrea Bolognani 10 Jan '24

10 Jan '24

On Tue, Jan 09, 2024 at 01:25:16AM -0800, Andrea Bolognani wrote: > On Tue, Jan 09, 2024 at 09:51:59AM +0800, lixianglai wrote: > > Hi Andrea: > > > > I'm so sorry to bother you. > > > > I modified the code according to your suggestion and sent the second version > > of patch to the community, > > > > but I did not find it in the mailing list, I am not sure whether I have > > successfully sent it to the community, > > > > so I would like to confirm that you can receive the email of the second > > version of patch I sent? > > > > Under normal circumstances, can I see the patch I sent in the link below? > > > > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org > > Yeah, it's supposed to show up there as well as in the month view[1] > but I can't see it. I haven't received a copy in my inbox either. > > It looks like something went wrong. Normally my first guess would be > that the messages are held up in the moderation queue, but I've > confirmed with the list admin that was not the case here. > > I'd say maybe give it a bit more time just in case things are > temporarily stuck in between servers, then send the patches again. > Worst case scenario, we're going to get two copies, no big deal :) I think I might have spotted the problem. You probably sent the patches to the old mailing list address (libvir-list(a)redhat.com) instead of the new one (devel(a)lists.libvirt.org) You should have gotten a message back telling you about it (I just did, which is how I noticed) but I've found those notifications to be somewhat hit and miss in the past. Just send the patches to the new address and they should make it to the list. If you use git-publish, it should automatically pick the right address. -- Andrea Bolognani / Red Hat / Virtualization

2 1

[PATCH] qemu: Be less aggressive when dropping channel source paths
by Michal Privoznik 09 Jan '24

09 Jan '24

In v9.7.0-rc1~130 I've shortened the path that's generated for <channel/> source. With that, I had to adjust regex that matches all versions of paths we have ever generated so that we can drop them (see comment around qemuDomainChrDefDropDefaultPath()). But as it is usually the case with regexes - they are write only. And while I attempted to make one portion of the path optional ("/target/") I accidentally made regex accept more, which resulted in libvirt dropping the user provided path and generating our own instead. Fixes: d3759d3674ab9453e5fb5a27ab6c28b8ff8d5569 Resolves: https://issues.redhat.com/browse/RHEL-20807 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 2 +- ...hannel-unix-source-path.x86_64-latest.args | 8 ++++++++ .../channel-unix-source-path.xml | 16 +++++++++++++++ ...-unix-source-path-active.x86_64-latest.xml | 20 +++++++++++++++++++ ...nix-source-path-inactive.x86_64-latest.xml | 20 +++++++++++++++++++ 5 files changed, 65 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 003fe7c71b..3a00fb689e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5447,7 +5447,7 @@ qemuDomainChrMatchDefaultPath(const char *prefix, virBufferEscapeRegex(&buf, "^%s", prefix); if (infix) virBufferEscapeRegex(&buf, "%s", infix); - virBufferAddLit(&buf, "/(target/)?([^/]+\\.)|(domain-[^/]+/)|([0-9]+-[^/]+/)"); + virBufferAddLit(&buf, "/(target/)?(([^/]+\\.)|(domain-[^/]+/)|([0-9]+-[^/]+/))"); virBufferEscapeRegex(&buf, "%s$", target); regexp = virBufferContentAndReset(&buf); diff --git a/tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args b/tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args index 821a508a40..845236d286 100644 --- a/tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args +++ b/tests/qemuxml2argvdata/channel-unix-source-path.x86_64-latest.args @@ -40,6 +40,14 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":5,"chardev":"charchannel4","id":"channel4","name":"org.qemu.guest_agent.4"}' \ -chardev socket,id=charchannel5,fd=1729,server=on,wait=off \ -device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":6,"chardev":"charchannel5","id":"channel5","name":"org.qemu.guest_agent.5"}' \ +-chardev socket,id=charchannel6,fd=1729,server=on,wait=off \ +-device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":7,"chardev":"charchannel6","id":"channel6","name":"org.qemu.guest_agent.6"}' \ +-chardev socket,id=charchannel7,fd=1729,server=on,wait=off \ +-device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":8,"chardev":"charchannel7","id":"channel7","name":"org.qemu.guest_agent.7"}' \ +-chardev socket,id=charchannel8,fd=1729,server=on,wait=off \ +-device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":9,"chardev":"charchannel8","id":"channel8","name":"org.qemu.guest_agent.8"}' \ +-chardev socket,id=charchannel9,fd=1729,server=on,wait=off \ +-device '{"driver":"virtserialport","bus":"virtio-serial0.0","nr":10,"chardev":"charchannel9","id":"channel9","name":"org.qemu.guest_agent.9"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ -msg timestamp=on diff --git a/tests/qemuxml2argvdata/channel-unix-source-path.xml b/tests/qemuxml2argvdata/channel-unix-source-path.xml index df548d88e7..265971eb94 100644 --- a/tests/qemuxml2argvdata/channel-unix-source-path.xml +++ b/tests/qemuxml2argvdata/channel-unix-source-path.xml @@ -32,6 +32,22 @@ <source mode='bind' path='/var/run/libvirt/qemu/channel/1-QEMUGuest1/org.qemu.guest_agent.5'/> <target type='virtio' name='org.qemu.guest_agent.5'/> </channel> + <channel type="unix"> + <source mode="bind" path="/1-QEMUGuest1/org.qemu.guest_agent.6"/> + <target type="virtio" name="org.qemu.guest_agent.6" state="connected"/> + </channel> + <channel type="unix"> + <source mode="bind" path="/tmp/1-QEMUGuest1/org.qemu.guest_agent.7"/> + <target type="virtio" name="org.qemu.guest_agent.7" state="connected"/> + </channel> + <channel type="unix"> + <source mode="bind" path="/tmp/libvirt/qemu/channel/1-QEMUGuest1/org.qemu.guest_agent.8"/> + <target type="virtio" name="org.qemu.guest_agent.8" state="connected"/> + </channel> + <channel type="unix"> + <source mode="bind" path="/tmp/org.qemu.guest_agent.9"/> + <target type="virtio" name="org.qemu.guest_agent.9" state="connected"/> + </channel> <memballoon model='none'/> </devices> </domain> diff --git a/tests/qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml b/tests/qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml index 022ad7025a..12a981438c 100644 --- a/tests/qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml +++ b/tests/qemuxml2xmloutdata/channel-unix-source-path-active.x86_64-latest.xml @@ -54,6 +54,26 @@ <target type='virtio' name='org.qemu.guest_agent.5'/> <address type='virtio-serial' controller='0' bus='0' port='6'/> </channel> + <channel type='unix'> + <source mode='bind' path='/1-QEMUGuest1/org.qemu.guest_agent.6'/> + <target type='virtio' name='org.qemu.guest_agent.6'/> + <address type='virtio-serial' controller='0' bus='0' port='7'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/1-QEMUGuest1/org.qemu.guest_agent.7'/> + <target type='virtio' name='org.qemu.guest_agent.7'/> + <address type='virtio-serial' controller='0' bus='0' port='8'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/libvirt/qemu/channel/1-QEMUGuest1/org.qemu.guest_agent.8'/> + <target type='virtio' name='org.qemu.guest_agent.8'/> + <address type='virtio-serial' controller='0' bus='0' port='9'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/org.qemu.guest_agent.9'/> + <target type='virtio' name='org.qemu.guest_agent.9'/> + <address type='virtio-serial' controller='0' bus='0' port='10'/> + </channel> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <audio id='1' type='none'/> diff --git a/tests/qemuxml2xmloutdata/channel-unix-source-path-inactive.x86_64-latest.xml b/tests/qemuxml2xmloutdata/channel-unix-source-path-inactive.x86_64-latest.xml index 3b013e9f87..2315a572e4 100644 --- a/tests/qemuxml2xmloutdata/channel-unix-source-path-inactive.x86_64-latest.xml +++ b/tests/qemuxml2xmloutdata/channel-unix-source-path-inactive.x86_64-latest.xml @@ -49,6 +49,26 @@ <target type='virtio' name='org.qemu.guest_agent.5'/> <address type='virtio-serial' controller='0' bus='0' port='6'/> </channel> + <channel type='unix'> + <source mode='bind' path='/1-QEMUGuest1/org.qemu.guest_agent.6'/> + <target type='virtio' name='org.qemu.guest_agent.6'/> + <address type='virtio-serial' controller='0' bus='0' port='7'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/1-QEMUGuest1/org.qemu.guest_agent.7'/> + <target type='virtio' name='org.qemu.guest_agent.7'/> + <address type='virtio-serial' controller='0' bus='0' port='8'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/libvirt/qemu/channel/1-QEMUGuest1/org.qemu.guest_agent.8'/> + <target type='virtio' name='org.qemu.guest_agent.8'/> + <address type='virtio-serial' controller='0' bus='0' port='9'/> + </channel> + <channel type='unix'> + <source mode='bind' path='/tmp/org.qemu.guest_agent.9'/> + <target type='virtio' name='org.qemu.guest_agent.9'/> + <address type='virtio-serial' controller='0' bus='0' port='10'/> + </channel> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <audio id='1' type='none'/> -- 2.41.0

2 1

[PATCH 0/2] ci: Update to Fedora 39
by Michal Privoznik 09 Jan '24

09 Jan '24

Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1106643445 Michal Prívozník (2): ci: integration: Switch upstream integration tests to Fedora 39 ci: Update Alpine and Fedora and regenerate ci/buildenv/{alpine-317.sh => alpine-319.sh} | 0 ci/buildenv/{fedora-37.sh => fedora-39.sh} | 0 ...e-317.Dockerfile => alpine-319.Dockerfile} | 2 +- ...ora-37.Dockerfile => fedora-39.Dockerfile} | 2 +- ci/gitlab/builds.yml | 64 +++++++-------- ci/gitlab/containers.yml | 18 ++--- ci/integration.yml | 80 +++++++++---------- ci/manifest.yml | 18 ++--- 8 files changed, 92 insertions(+), 92 deletions(-) rename ci/buildenv/{alpine-317.sh => alpine-319.sh} (100%) rename ci/buildenv/{fedora-37.sh => fedora-39.sh} (100%) rename ci/containers/{alpine-317.Dockerfile => alpine-319.Dockerfile} (98%) rename ci/containers/{fedora-37.Dockerfile => fedora-39.Dockerfile} (98%) -- 2.41.0

6 15

[PATCH v2 0/2] Deprecate the shix machine and the TC58128 flash device
by Samuel Tardieu 09 Jan '24

09 Jan '24

The shix machine was a research project started around 2003 at Télécom Paris. Preliminary support in QEMU was added in 2005 back when the QEMU architecture was less structured than it is now. Unfortunately, the support for the shix machine and its peripherals, such as the TC58128 16MiB flash device, has never been maintained as the research project used the real machine. This project stopped around 2010 and to the best of my knowledge and after consulting with the original author Alexis Polti, I propose to deprecate it in QEMU as well as the TC58128 flash device which does not implement the QOM model and still contains debug fprintf statements. Samuel Tardieu (2): target/sh4: Deprecate the shix machine hw/block: Deprecate the TC58128 block device docs/about/deprecated.rst | 5 +++++ hw/block/tc58128.c | 1 + hw/sh4/shix.c | 1 + 3 files changed, 7 insertions(+) -- 2.42.0

2 4

[PATCH] qemu: tighten semantics of 'size' when resizing block devices
by Daniel P. Berrangé 09 Jan '24

09 Jan '24

When VIR_DOMAIN_BLOCK_RESIZE_CAPACITY is set, the 'size' parameter is currently ignored. Since applications must none the less pass a value for this parameter, it is preferrable to declare some explicit semantics for it. This declare that the parameter must be 0, or the exact size of the underlying block device. The latter gives the management application the ability to sanity check that the block device size matches what they think it should be. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/libvirt-domain.c | 5 +++-- src/qemu/qemu_driver.c | 9 ++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 94e5672ed8..83abad251e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6389,8 +6389,9 @@ virDomainBlockPeek(virDomainPtr dom, * to the next alignment boundary. * * If @flag contains VIR_DOMAIN_BLOCK_RESIZE_CAPACITY (since 10.0.0) the - * hypervisor will resize the guest block device to fully fill the source, - * ignoring @size. This is possible only for image formats with no metadata + * hypervisor will resize the guest block device to fully fill the source. + * @size must be either set to zero, or to the exact size of the block + * device source. This is possible only for image formats with no metadata * ('raw') and for source devices with limited capacity such as block devices. * * The @disk parameter is either an unambiguous source name of the diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 49bc4a624d..8e529f97b5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9325,7 +9325,14 @@ qemuDomainBlockResize(virDomainPtr dom, goto endjob; } - size = disk->src->physical; + if (size == 0) { + size = disk->src->physical; + } else if (size != disk->src->physical) { + virReportError(VIR_ERR_INVALID_ARG, + _("block resize to full capacity %llu but validate size is %llu"), + size, disk->src->physical); + goto endjob; + } } /* qcow2 and qed must be sized on 512 byte blocks/sectors, -- 2.43.0

2 2

[PATCH 0/2] tests: Add capabilities for QEMU 8.2.0 on aarch64
by Andrea Bolognani 09 Jan '24

09 Jan '24

Edited for brevity. Full version: $ git fetch https://gitlab.com/abologna/libvirt.git qemu-caps Andrea Bolognani (2): tests: Don't use features with vexpress machine tests: Add capabilities for QEMU 8.2.0 on aarch64 .../qemu_8.2.0-virt.aarch64.xml | 227 + tests/domaincapsdata/qemu_8.2.0.aarch64.xml | 227 + .../caps_8.2.0_aarch64.replies | 36411 ++++++++++++++++ .../caps_8.2.0_aarch64.xml | 549 + ...ch64-aavmf-virtio-mmio.aarch64-latest.args | 5 +- ...arch64-cpu-passthrough.aarch64-latest.args | 3 +- ...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 3 +- ...fault-cpu-tcg-virt-4.2.aarch64-latest.args | 3 +- .../aarch64-features-sve.aarch64-latest.args | 3 +- ...rch64-gic-default-both.aarch64-latest.args | 3 +- ...aarch64-gic-default-v2.aarch64-latest.args | 3 +- ...aarch64-gic-default-v3.aarch64-latest.args | 3 +- .../aarch64-gic-default.aarch64-latest.args | 3 +- .../aarch64-gic-host.aarch64-latest.args | 3 +- .../aarch64-gic-none-both.aarch64-latest.args | 3 +- .../aarch64-gic-none-tcg.aarch64-latest.args | 3 +- .../aarch64-gic-none-v2.aarch64-latest.args | 3 +- .../aarch64-gic-none-v3.aarch64-latest.args | 3 +- .../aarch64-gic-none.aarch64-latest.args | 3 +- .../aarch64-gic-v2.aarch64-latest.args | 3 +- .../aarch64-gic-v3.aarch64-latest.args | 3 +- .../aarch64-kvm-32-on-64.aarch64-latest.args | 4 +- .../aarch64-pci-serial.aarch64-latest.args | 3 +- .../aarch64-tpm.aarch64-latest.args | 3 +- ...arch64-traditional-pci.aarch64-latest.args | 3 +- ...aarch64-usb-controller.aarch64-latest.args | 3 +- .../aarch64-video-default.aarch64-latest.args | 3 +- ...4-video-virtio-gpu-pci.aarch64-latest.args | 5 +- ...rch64-virt-default-nic.aarch64-latest.args | 5 +- .../aarch64-virt-graphics.aarch64-latest.args | 4 +- .../aarch64-virt-headless.aarch64-latest.args | 4 +- ...rch64-virt-virtio-MMIO.aarch64.latest.args | 5 +- .../aarch64-virt-virtio.aarch64-latest.args | 5 +- ...h64-virtio-pci-default.aarch64-latest.args | 5 +- ...o-pci-manual-addresses.aarch64-latest.args | 7 +- .../arm-vexpressa9-basic.aarch64-latest.args | 2 +- .../qemuxml2argvdata/arm-vexpressa9-basic.xml | 5 - .../arm-vexpressa9-nodevs.xml | 5 - .../arm-vexpressa9-virtio.aarch64-latest.args | 2 +- .../arm-vexpressa9-virtio.xml | 5 - .../arm-virt-virtio.aarch64-latest.args | 4 +- .../balloon-mmio-deflate.aarch64-latest.args | 3 +- .../clock-timer-armvtimer.aarch64-latest.args | 3 +- ...ult-video-type-aarch64.aarch64-latest.args | 3 +- .../disk-arm-virtio-sd.aarch64-latest.args | 1 - ...mware-auto-efi-aarch64.aarch64-latest.args | 2 +- ...efi-abi-update-aarch64.aarch64-latest.args | 2 +- ...-loader-raw-abi-update.aarch64-latest.args | 2 +- ...-efi-format-loader-raw.aarch64-latest.args | 2 +- ...i-aarch64-legacy-paths.aarch64-latest.args | 2 +- ...anual-efi-acpi-aarch64.aarch64-latest.args | 2 +- ...ual-efi-noacpi-aarch64.aarch64-latest.args | 3 +- ...l-noefi-noacpi-aarch64.aarch64-latest.args | 3 +- .../iommu-smmuv3.aarch64-latest.args | 3 +- ...ch-virt-console-native.aarch64-latest.args | 3 +- ...ch-virt-console-virtio.aarch64-latest.args | 3 +- ...-serial+console-native.aarch64-latest.args | 3 +- ...ach-virt-serial-compat.aarch64-latest.args | 3 +- ...ach-virt-serial-native.aarch64-latest.args | 3 +- .../mach-virt-serial-pci.aarch64-latest.args | 3 +- .../mach-virt-serial-usb.aarch64-latest.args | 3 +- ...e-expander-bus-aarch64.aarch64-latest.args | 3 +- .../pvpanic-pci-aarch64.aarch64-latest.args | 2 +- ...pci-no-address-aarch64.aarch64-latest.args | 2 +- .../virtio-iommu-aarch64.aarch64-latest.args | 2 +- 65 files changed, 37483 insertions(+), 127 deletions(-) create mode 100644 tests/domaincapsdata/qemu_8.2.0-virt.aarch64.xml create mode 100644 tests/domaincapsdata/qemu_8.2.0.aarch64.xml create mode 100644 tests/qemucapabilitiesdata/caps_8.2.0_aarch64.replies create mode 100644 tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml -- 2.43.0

3 7

[PATCH 0/2] Deprecate the shix machine and the TC58128 flash device
by Samuel Tardieu 09 Jan '24

09 Jan '24

The shix machine was a research project started around 2003 at Télécom Paris. Preliminary support in QEMU was added in 2005 back when the QEMU architecture was less structured than it is now. Unfortunately, the support for the shix machine and its peripherals, such as the TC58128 16MiB flash device, has never been maintained as the research project used the real machine. This project stopped around 2010 and to the best of my knowledge and after consulting with the original author Alexis Polti, I propose to deprecate it in QEMU as well as the TC58128 flash device which does not implement the QOM model and still contains debug fprintf statements. Samuel Tardieu (2): target/sh4: Deprecate the shix machine hw/block: Deprecate the TC58128 block device docs/about/deprecated.rst | 5 +++++ hw/block/tc58128.c | 1 + hw/sh4/shix.c | 1 + 3 files changed, 7 insertions(+) -- 2.42.0

4 7

[libvirt PATCH 0/6] qemu: Enable postcopy-preempt migration capability
by Jiri Denemark 08 Jan '24

08 Jan '24

This is technically a v2 of my recent "Introduce VIR_MIGRATE_POSTCOPY_PREEMPT flag", but the two series share exactly two lines of code (those defining a new QEMU_MIGRATION_CAP_POSTCOPY_PREEMPT enum item) so I'm just sending it as a separate series. More details about this feature can be found in patch 5/6. Jiri Denemark (6): qemu: Document qemuMigrationParamsFlagMapItem fields qemu: Use C99 initializers for qemuMigrationParamsFlagMap qemu: Rename remoteCaps parameter in qemuMigrationParamsCheck qemu: Add support for optional migration capabilities qemu: Enable postcopy-preempt migration capability NEWS: Mention postcopy-preempt migration capability NEWS.rst | 8 ++ src/qemu/qemu_migration.c | 19 +++-- src/qemu/qemu_migration_params.c | 127 ++++++++++++++++++++++--------- src/qemu/qemu_migration_params.h | 4 +- 4 files changed, 115 insertions(+), 43 deletions(-) -- 2.43.0

2 12

[libvirt PATCH 0/3] Introduce VIR_MIGRATE_POSTCOPY_PREEMPT flag
by Jiri Denemark 08 Jan '24

08 Jan '24

See 1/3 for details. https://issues.redhat.com/browse/RHEL-7100 Jiri Denemark (3): Introduce VIR_MIGRATE_POSTCOPY_PREEMPT flag virsh migrate: Add --postcopy-preempt option qemu_migration: Implement VIR_MIGRATE_POSTCOPY_PREEMPT docs/manpages/virsh.rst | 9 ++++++--- include/libvirt/libvirt-domain.h | 8 ++++++++ src/qemu/qemu_migration.c | 21 ++++++++++++++++++--- src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 6 ++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 6 ++++++ 7 files changed, 46 insertions(+), 6 deletions(-) -- 2.43.0

3 7

[PATCH v3 00/13] Support for VFIO variant drivers, Part 2
by Laine Stump 05 Jan '24

05 Jan '24

This is "V3 of Part 2". "V2 of Part 2": is here: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EVHM… Part 1 (which simply made it possible to use virsh nodedev-detach to bind a device to a manually-specified variant driver, and at guest runtime allowed libvirt to ignore the fact that the driver found to the device was something other than exactly "vfio-pci") was here: https://listman.redhat.com/archives/libvir-list/2023-August/241338.html and pushed upstream as of commit v9.6.0-153-g24beaffec3 Part 2 adds two new pieces of functionality: 1) It is possible to manually specify a VFIO variant driver (or force the generic vfio-pci driver) for a device in the domain XML with, e.g.: <driver name='mlx5_vfio_pci'/> (for the former) or: <driver name='vfio-pci'/> (for the latter). 2) By default libvirt will now find the "best match" VFIO or VFIO variant driver by comparing the device's modalias file contents (in sysfs) with vfio drivers found in the running kernel's modules.alias file. This means that "virsh nodedev-detach" of a host device will bind it to its appropriate VFIO variant driver (if one is available), and also if a <hostdev> decice in a domain config has "managed='yes'", libvirt will bind it to a variant driver if possible (in order to force binding to the basic vfio-pci driver instead, you just need to add the <driver> element mentioned above). Differences from V2 to V3: * I attempted to simplify my explanation of the confusion with module name vs. driver name that I had in the commit log of patch 1. * I think I've addressed all of the minor issues pointed out by Peter in his reviews V2 (joining unnecessarily split lines, failing when a modalias file can't be found (rather than "kind of" ignoring it), and other minor fixes. * The main difference between V2 and V3 is that I've relented on the issue of re-using the existing <driver name='blah'/> attribute (due to potential backwrd compatibility problems we might encounter), and am instead adding a new attribute <driver model='blah'/>. This means that both the driver name and the new driver model attribute names don't make as much sense, but that's what fancy GUI frontends are for -hiding the borderline-confusing names! * One change suggested by Peter that I enthusiastically agree with, but haven't implemented in V3 is to cache the few relevant lines of modules.alias rather than rereading the entire file each time. I do agree with him, but have run out of steam (and time) to implement it now - I do promise a followup with this functionality "soon". Patches 2-9 and 11 were already ACKed by Peter in V2 (several of them conditionally based on some minor fixes that I have made). This leaves only patches 1, 10, 12, and 13 that require an ACK (V2 had 15 patches, but I removed two of them). Laine Stump (13): util: properly deal with VFIO module name vs. driver name schema: consolidate RNG for all hostdev <driver> elements conf: move/rename hostdev PCI driver type enum to device_conf.h conf: normalize hostdev <driver> parsing to simplify adding new attr conf: put hostdev PCI backend into a struct conf: use virDeviceHostdevPCIDriverInfo in network and networkport objects conf: split out hostdev <driver> parse/format to their own functions conf: use new common parser/formatter for hostdev driver in network XML conf: replace virHostdevIsVFIODevice with virHostdevIsPCIDevice xen: explicitly set hostdev driver.name at runtime, not in postparse tests: remove explicit <driver name='vfio'/> from hostdev test cases conf: support manually specifying VFIO variant driver in <hostdev> XML qemu: automatically bind to a vfio variant driver, if available docs/formatdomain.rst | 55 ++- docs/formatnetwork.rst | 22 +- docs/formatnetworkport.rst | 1 - docs/pci-addresses.rst | 1 - src/conf/device_conf.c | 59 +++ src/conf/device_conf.h | 27 ++ src/conf/domain_capabilities.c | 2 +- src/conf/domain_capabilities.h | 2 +- src/conf/domain_conf.c | 98 +---- src/conf/domain_conf.h | 18 +- src/conf/network_conf.c | 42 +- src/conf/network_conf.h | 17 +- src/conf/schemas/basictypes.rng | 20 + src/conf/schemas/domaincommon.rng | 173 ++++---- src/conf/schemas/network.rng | 10 +- src/conf/schemas/networkport.rng | 10 +- src/conf/virconftypes.h | 2 + src/conf/virnetworkportdef.c | 22 +- src/conf/virnetworkportdef.h | 4 +- src/hypervisor/virhostdev.c | 16 +- src/hypervisor/virhostdev.h | 2 - src/libvirt_private.syms | 8 +- src/libxl/libxl_capabilities.c | 3 +- src/libxl/libxl_domain.c | 73 +++- src/libxl/libxl_driver.c | 25 +- src/network/bridge_driver.c | 3 +- src/qemu/qemu_capabilities.c | 4 +- src/qemu/qemu_command.c | 16 +- src/qemu/qemu_domain.c | 28 +- src/qemu/qemu_hostdev.c | 2 +- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_validate.c | 6 +- src/security/security_apparmor.c | 2 +- src/security/security_dac.c | 4 +- src/security/security_selinux.c | 4 +- src/security/virt-aa-helper.c | 7 +- src/test/test_driver.c | 18 +- src/util/virpci.c | 410 ++++++++++++++++-- src/util/virpci.h | 2 + tests/domaincapstest.c | 4 +- tests/libxlxml2domconfigdata/moredevs-hvm.xml | 1 - tests/networkxml2xmlin/hostdev-pf-old.xml | 8 + tests/networkxml2xmlin/hostdev-pf.xml | 1 - tests/networkxml2xmlout/hostdev-pf-old.xml | 8 + tests/networkxml2xmlout/hostdev-pf.xml | 1 - tests/networkxml2xmltest.c | 6 + .../qemuhotplug-hostdev-pci.xml | 1 - .../qemumemlock-pc-hardlimit+hostdev.xml | 1 - ...emumemlock-pc-hardlimit+locked+hostdev.xml | 1 - .../qemumemlock-pc-hostdev-nvme.xml | 1 - .../qemumemlock-pc-hostdev.xml | 1 - .../qemumemlock-pc-locked+hostdev.xml | 1 - .../qemumemlock-pseries-hardlimit+hostdev.xml | 1 - ...mlock-pseries-hardlimit+locked+hostdev.xml | 1 - .../qemumemlock-pseries-hostdev.xml | 1 - .../qemumemlock-pseries-locked+hostdev.xml | 1 - tests/qemustatusxml2xmldata/modern-in.xml | 1 - .../hostdev-pci-address-unassigned.xml | 4 - .../hostdev-pci-multifunction.xml | 7 - .../hostdev-vfio-multidomain.xml | 1 - .../hostdev-vfio-zpci-autogenerate-fids.xml | 2 - .../hostdev-vfio-zpci-autogenerate-uids.xml | 2 - .../hostdev-vfio-zpci-autogenerate.xml | 1 - .../hostdev-vfio-zpci-boundaries.xml | 2 - .../hostdev-vfio-zpci-ccw-memballoon.xml | 1 - .../hostdev-vfio-zpci-duplicate.xml | 2 - ...ostdev-vfio-zpci-invalid-uid-valid-fid.xml | 1 - .../hostdev-vfio-zpci-multidomain-many.xml | 8 - .../hostdev-vfio-zpci-set-zero.xml | 1 - .../hostdev-vfio-zpci-uid-set-zero.xml | 1 - .../hostdev-vfio-zpci-wrong-arch.xml | 1 - tests/qemuxml2argvdata/hostdev-vfio-zpci.xml | 1 - .../hostdev-vfio.x86_64-latest.args | 5 +- tests/qemuxml2argvdata/hostdev-vfio.xml | 19 +- .../net-hostdev-vfio-multidomain.xml | 1 - tests/qemuxml2argvdata/net-hostdev-vfio.xml | 1 - tests/qemuxml2argvdata/pseries-hostdevs-1.xml | 3 - tests/qemuxml2argvdata/pseries-hostdevs-2.xml | 2 - tests/qemuxml2argvdata/pseries-hostdevs-3.xml | 2 - ...v-pci-address-unassigned.x86_64-latest.xml | 4 - ...ostdev-pci-multifunction.x86_64-latest.xml | 7 - ...dev-vfio-old-driver-name.x86_64-latest.xml | 46 ++ ...io-zpci-autogenerate-fids.s390x-latest.xml | 2 - ...io-zpci-autogenerate-uids.s390x-latest.xml | 2 - ...ev-vfio-zpci-autogenerate.s390x-latest.xml | 1 - ...tdev-vfio-zpci-boundaries.s390x-latest.xml | 2 - ...-vfio-zpci-ccw-memballoon.s390x-latest.xml | 1 - ...fio-zpci-multidomain-many.s390x-latest.xml | 8 - .../hostdev-vfio-zpci.s390x-latest.xml | 1 - .../hostdev-vfio.x86_64-latest.xml | 24 +- .../net-hostdev-vfio.x86_64-latest.xml | 1 - .../pseries-hostdevs-1.ppc64-latest.xml | 3 - .../pseries-hostdevs-2.ppc64-latest.xml | 2 - .../pseries-hostdevs-3.ppc64-latest.xml | 2 - tests/virhostdevtest.c | 2 +- .../plug-hostdev-pci-unmanaged.xml | 1 - .../plug-hostdev-pci.xml | 1 - tests/virpcimock.c | 9 + tests/xlconfigdata/test-fullvirt-pci.xml | 2 - tests/xmconfigdata/test-pci-dev-syntax.xml | 2 - tests/xmconfigdata/test-pci-devs.xml | 2 - tools/virsh-completer-nodedev.c | 4 +- 102 files changed, 927 insertions(+), 530 deletions(-) create mode 100644 tests/networkxml2xmlin/hostdev-pf-old.xml create mode 100644 tests/networkxml2xmlout/hostdev-pf-old.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-vfio-old-driver-name.x86_64-latest.xml -- 2.43.0

2 25