- Devel - libvirt List Archives

[libvirt] [PATCH] maint: update to latest gnulib
by Eric Blake 28 Dec '13

28 Dec '13

A couple of fixes for bootstrap issues reported on IRC: - on some older glibc systems, ./configure could deadlock due to a glibc malloc bug - on FreeBSD systems, a broken autom4te coupled with gettext 0.18.3 prevents bootstrap; we can't work around it, but can at least inform the user why they have a problem And as always, portability fixes in other modules, some of which are used by libvirt. * .gnulib: Update to latest, in part for bootstrap improvements. * bootstrap: Resync to gnulib. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Hmm, in reading this gnulib changelog, I'm not sure I want to push right away: the line about md5 being tweaked to use openssl makes me wonder if this update is dragging in a new library dependency; I'll have to do a bit more investigation. But here's the patch, if anyone else also wants to investigate. * .gnulib 831b84c...fdfe96f (18): > bootstrap: warn about BSD toolchain snafu > open-tests: port to glibc with _FORTIFY_SOURCE and -O1 > include_next: minimize code duplication > getcwd: fix compile error in configure check > regex: suppress core dumps from detection code > md5, sha1, sha256, sha512: support mandating use of openssl > test-xvasprintf: disable some -Wformat-security diagnostics > regex: avoid glibc deadlock during configure > md5, sha1, sha256, sha512: use openssl routines if available > base64: fix recent compilation regression on some compilers > autoupdate > autoupdate > ignore-value: revert previous code change > selinux-h: improve stub types and add more stub functions > ignore-value: prefer GCC version back through 2.0 > pty: Activate the signature wrapper of forkpty. > maint: fix gendocs.sh permissions > autoupdate .gnulib | 2 +- bootstrap | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.gnulib b/.gnulib index 831b84c..fdfe96f 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 831b84c59ef413c57a36b67344467d66a8a2ba70 +Subproject commit fdfe96fe43746d63364f823ab3032c8301d53d1f diff --git a/bootstrap b/bootstrap index e31d17d..5acbe5b 100755 --- a/bootstrap +++ b/bootstrap @@ -1,6 +1,6 @@ #! /bin/sh # Print a version string. -scriptversion=2013-08-15.22; # UTC +scriptversion=2013-12-05.23; # UTC # Bootstrap this package from checked-out sources. @@ -551,6 +551,14 @@ if ! printf "$buildreq" | check_versions; then fi fi +# Warn the user if autom4te appears to be broken; this causes known +# issues with at least gettext 0.18.3. +probe=$(echo 'm4_quote([hi])' | autom4te -l M4sugar -t 'm4_quote:$%' -) +if test "x$probe" != xhi; then + warn_ "WARNING: your autom4te wrapper eats stdin;" + warn_ "if bootstrap fails, consider upgrading your autotools" +fi + echo "$0: Bootstrapping from checked-out $package sources..." # See if we can use gnulib's git-merge-changelog merge driver. -- 1.8.3.1

2 2

[libvirt] [PATCHv2] maint: improve debug of libvirt-{qemu, lxc} apis
by Eric Blake 28 Dec '13

28 Dec '13

I noticed that the virDomainQemuMonitorCommand debug output wasn't telling me the name of the domain it was working on. While it was easy enough to determine which pointer matches the domain based on other log messages, it is nicer to be consistent. * src/util/viruuid.h (VIR_UUID_DEBUG): Moved here from... * src/libvirt.c (VIR_UUID_DEBUG): ...here. (VIR_ARG15, VIR_HAS_COMMA, VIR_DOMAIN_DEBUG_EXPAND) (VIR_DOMAIN_DEBUG_PASTE, VIR_DOMAIN_DEBUG_0, VIR_DOMAIN_DEBUG_1) (VIR_DOMAIN_DEBUG_2, VIR_DOMAIN_DEBUG): Move... * src/datatypes.h: ...here. * src/libvirt-qemu.c (virDomainQemuMonitorCommand) (virDomainQemuAgentCommand): Better debug messages. * src/libvirt-lxc.c (virDomainLxcOpenNamespace): Likewise. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- The simpler part of my changes; the work on cleaning up the remaining virLib*Error() calls in libvirt.c is turning into a bigger cleanup project. src/datatypes.h | 60 ++++++++++++++++++++++++++++++++++++++++++++- src/libvirt-lxc.c | 4 +-- src/libvirt-qemu.c | 11 +++++---- src/libvirt.c | 71 ------------------------------------------------------ src/util/viruuid.h | 20 ++++++++++++++- 5 files changed, 86 insertions(+), 80 deletions(-) diff --git a/src/datatypes.h b/src/datatypes.h index 6026bb0..7f325b0 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -1,7 +1,7 @@ /* * datatypes.h: management of structs for public data types * - * Copyright (C) 2006-2008, 2010-2011 Red Hat, Inc. + * Copyright (C) 2006-2008, 2010-2011, 2013 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -94,6 +94,64 @@ extern virClassPtr virStoragePoolClass; (VIR_IS_SNAPSHOT(obj) && VIR_IS_DOMAIN((obj)->domain)) +/* Helper macros to implement VIR_DOMAIN_DEBUG using just C99. This + * assumes you pass fewer than 15 arguments to VIR_DOMAIN_DEBUG, but + * can easily be expanded if needed. + * + * Note that gcc provides extensions of "define a(b...) b" or + * "define a(b,...) b,##__VA_ARGS__" as a means of eliding a comma + * when no var-args are present, but we don't want to require gcc. + */ +# define VIR_ARG15(_1, _2, _3, _4, _5, _6, _7, _8, _9, _10, \ + _11, _12, _13, _14, _15, ...) _15 +# define VIR_HAS_COMMA(...) VIR_ARG15(__VA_ARGS__, \ + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0) + +/* Form the name VIR_DOMAIN_DEBUG_[01], then call that macro, + * according to how many arguments are present. Two-phase due to + * macro expansion rules. */ +# define VIR_DOMAIN_DEBUG_EXPAND(a, b, ...) \ + VIR_DOMAIN_DEBUG_PASTE(a, b, __VA_ARGS__) +# define VIR_DOMAIN_DEBUG_PASTE(a, b, ...) \ + a##b(__VA_ARGS__) + +/* Internal use only, when VIR_DOMAIN_DEBUG has one argument. */ +# define VIR_DOMAIN_DEBUG_0(dom) \ + VIR_DOMAIN_DEBUG_2(dom, "%s", "") + +/* Internal use only, when VIR_DOMAIN_DEBUG has three or more arguments. */ +# define VIR_DOMAIN_DEBUG_1(dom, fmt, ...) \ + VIR_DOMAIN_DEBUG_2(dom, ", " fmt, __VA_ARGS__) + +/* Internal use only, with final format. */ +# define VIR_DOMAIN_DEBUG_2(dom, fmt, ...) \ + do { \ + char _uuidstr[VIR_UUID_STRING_BUFLEN]; \ + const char *_domname = NULL; \ + \ + if (!VIR_IS_DOMAIN(dom)) { \ + memset(_uuidstr, 0, sizeof(_uuidstr)); \ + } else { \ + virUUIDFormat((dom)->uuid, _uuidstr); \ + _domname = (dom)->name; \ + } \ + \ + VIR_DEBUG("dom=%p, (VM: name=%s, uuid=%s)" fmt, \ + dom, NULLSTR(_domname), _uuidstr, __VA_ARGS__); \ + } while (0) + +/** + * VIR_DOMAIN_DEBUG: + * @dom: domain + * @fmt: optional format for additional information + * @...: optional arguments corresponding to @fmt. + */ +# define VIR_DOMAIN_DEBUG(...) \ + VIR_DOMAIN_DEBUG_EXPAND(VIR_DOMAIN_DEBUG_, \ + VIR_HAS_COMMA(__VA_ARGS__), \ + __VA_ARGS__) + + typedef struct _virConnectCloseCallbackData virConnectCloseCallbackData; typedef virConnectCloseCallbackData *virConnectCloseCallbackDataPtr; diff --git a/src/libvirt-lxc.c b/src/libvirt-lxc.c index c8cdcea..5cbe8bf 100644 --- a/src/libvirt-lxc.c +++ b/src/libvirt-lxc.c @@ -28,6 +28,7 @@ #include "virfile.h" #include "virlog.h" #include "virprocess.h" +#include "viruuid.h" #include "datatypes.h" #ifdef WITH_SELINUX # include <selinux/selinux.h> @@ -69,8 +70,7 @@ virDomainLxcOpenNamespace(virDomainPtr domain, { virConnectPtr conn; - VIR_DEBUG("domain=%p, fdlist=%p flags=%x", - domain, fdlist, flags); + VIR_DOMAIN_DEBUG(domain, "fdlist=%p flags=%x", fdlist, flags); virResetLastError(); diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index 83fb3b3..2fa5522 100644 --- a/src/libvirt-qemu.c +++ b/src/libvirt-qemu.c @@ -2,7 +2,7 @@ * libvirt-qemu.c: Interfaces for the libvirt library to handle qemu-specific * APIs. * - * Copyright (C) 2010-2012 Red Hat, Inc. + * Copyright (C) 2010-2013 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -25,6 +25,7 @@ #include "virerror.h" #include "virlog.h" +#include "viruuid.h" #include "datatypes.h" #define VIR_FROM_THIS VIR_FROM_NONE @@ -75,8 +76,8 @@ virDomainQemuMonitorCommand(virDomainPtr domain, const char *cmd, { virConnectPtr conn; - VIR_DEBUG("domain=%p, cmd=%s, result=%p, flags=%x", - domain, cmd, result, flags); + VIR_DOMAIN_DEBUG(domain, "cmd=%s, result=%p, flags=%x", + cmd, result, flags); virResetLastError(); @@ -213,8 +214,8 @@ virDomainQemuAgentCommand(virDomainPtr domain, virConnectPtr conn; char *ret; - VIR_DEBUG("domain=%p, cmd=%s, timeout=%d, flags=%x", - domain, cmd, timeout, flags); + VIR_DOMAIN_DEBUG(domain, "cmd=%s, timeout=%d, flags=%x", + cmd, timeout, flags); if (!VIR_IS_CONNECTED_DOMAIN(domain)) { virLibDomainError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__); diff --git a/src/libvirt.c b/src/libvirt.c index 77f481e..37de991 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -327,77 +327,6 @@ static struct gcry_thread_cbs virTLSThreadImpl = { }; #endif /* WITH_GNUTLS_GCRYPT */ -/* Helper macros to implement VIR_DOMAIN_DEBUG using just C99. This - * assumes you pass fewer than 15 arguments to VIR_DOMAIN_DEBUG, but - * can easily be expanded if needed. - * - * Note that gcc provides extensions of "define a(b...) b" or - * "define a(b,...) b,##__VA_ARGS__" as a means of eliding a comma - * when no var-args are present, but we don't want to require gcc. - */ -#define VIR_ARG15(_1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _11, _12, _13, _14, _15, ...) _15 -#define VIR_HAS_COMMA(...) VIR_ARG15(__VA_ARGS__, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0) - -/* Form the name VIR_DOMAIN_DEBUG_[01], then call that macro, - * according to how many arguments are present. Two-phase due to - * macro expansion rules. */ -#define VIR_DOMAIN_DEBUG_EXPAND(a, b, ...) \ - VIR_DOMAIN_DEBUG_PASTE(a, b, __VA_ARGS__) -#define VIR_DOMAIN_DEBUG_PASTE(a, b, ...) \ - a##b(__VA_ARGS__) - -/* Internal use only, when VIR_DOMAIN_DEBUG has one argument. */ -#define VIR_DOMAIN_DEBUG_0(dom) \ - VIR_DOMAIN_DEBUG_2(dom, "%s", "") - -/* Internal use only, when VIR_DOMAIN_DEBUG has three or more arguments. */ -#define VIR_DOMAIN_DEBUG_1(dom, fmt, ...) \ - VIR_DOMAIN_DEBUG_2(dom, ", " fmt, __VA_ARGS__) - -/* Internal use only, with final format. */ -#define VIR_DOMAIN_DEBUG_2(dom, fmt, ...) \ - do { \ - char _uuidstr[VIR_UUID_STRING_BUFLEN]; \ - const char *_domname = NULL; \ - \ - if (!VIR_IS_DOMAIN(dom)) { \ - memset(_uuidstr, 0, sizeof(_uuidstr)); \ - } else { \ - virUUIDFormat((dom)->uuid, _uuidstr); \ - _domname = (dom)->name; \ - } \ - \ - VIR_DEBUG("dom=%p, (VM: name=%s, uuid=%s)" fmt, \ - dom, NULLSTR(_domname), _uuidstr, __VA_ARGS__); \ - } while (0) - -/** - * VIR_DOMAIN_DEBUG: - * @dom: domain - * @fmt: optional format for additional information - * @...: optional arguments corresponding to @fmt. - */ -#define VIR_DOMAIN_DEBUG(...) \ - VIR_DOMAIN_DEBUG_EXPAND(VIR_DOMAIN_DEBUG_, \ - VIR_HAS_COMMA(__VA_ARGS__), \ - __VA_ARGS__) - -/** - * VIR_UUID_DEBUG: - * @conn: connection - * @uuid: possibly null UUID array - */ -#define VIR_UUID_DEBUG(conn, uuid) \ - do { \ - if (uuid) { \ - char _uuidstr[VIR_UUID_STRING_BUFLEN]; \ - virUUIDFormat(uuid, _uuidstr); \ - VIR_DEBUG("conn=%p, uuid=%s", conn, _uuidstr); \ - } else { \ - VIR_DEBUG("conn=%p, uuid=(null)", conn); \ - } \ - } while (0) - static bool virGlobalError = false; static virOnceControl virGlobalOnce = VIR_ONCE_CONTROL_INITIALIZER; diff --git a/src/util/viruuid.h b/src/util/viruuid.h index bebd338..b3b1d49 100644 --- a/src/util/viruuid.h +++ b/src/util/viruuid.h @@ -1,7 +1,7 @@ /* * viruuid.h: helper APIs for dealing with UUIDs * - * Copyright (C) 2007, 2011, 2012 Red Hat, Inc. + * Copyright (C) 2007, 2011-2013 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -26,6 +26,24 @@ # include "internal.h" + +/** + * VIR_UUID_DEBUG: + * @conn: connection + * @uuid: possibly null UUID array + */ +# define VIR_UUID_DEBUG(conn, uuid) \ + do { \ + if (uuid) { \ + char _uuidstr[VIR_UUID_STRING_BUFLEN]; \ + virUUIDFormat(uuid, _uuidstr); \ + VIR_DEBUG("conn=%p, uuid=%s", conn, _uuidstr); \ + } else { \ + VIR_DEBUG("conn=%p, uuid=(null)", conn); \ + } \ + } while (0) + + int virSetHostUUIDStr(const char *host_uuid); int virGetHostUUID(unsigned char *host_uuid) ATTRIBUTE_NONNULL(1); -- 1.8.4.2

1 1

[libvirt] [PATCH] maint: fix typo in error message
by Eric Blake 27 Dec '13

27 Dec '13

* src/util/virerror.h (virReportInvalidZeroArg): Fix double space. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the trivial rule. src/util/virerror.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virerror.h b/src/util/virerror.h index 05e9950..87272e9 100644 --- a/src/util/virerror.h +++ b/src/util/virerror.h @@ -1,7 +1,7 @@ /* * virerror.c: error handling and reporting code for libvirt * - * Copyright (C) 2006-2009, 2011 Red Hat, Inc. + * Copyright (C) 2006-2013 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -121,7 +121,7 @@ void virReportSystemErrorFull(int domcode, #argname, \ NULL, \ 0, 0, \ - _("%s in %s must be zero"), \ + _("%s in %s must be zero"), \ #argname, __FUNCTION__) # define virReportInvalidNonNegativeArg(argname) \ virRaiseErrorFull(__FILE__, __FUNCTION__, __LINE__, \ -- 1.8.4.2

1 0

[libvirt] fail to live migration is related to virtio-console
by yue 27 Dec '13

27 Dec '13

hi,all this error occured when live migration windows os, log of that vm is: features 0x1e unsupported allowed features 0x71000002 qemu warning error while loading state for instance 0x0 of device '0000:00:04.4/virtio-console' do you have some idea about that? thanks

2 1

[libvirt] [PATCH] initial version of the bhyve driver
by Roman Bogorodskiy 27 Dec '13

27 Dec '13

Hi, This is an initial version of the bhyve driver. bhyve is a hypervisor for FreeBSD: http://bhyve.org/. I've tried to make this initial version as small as possible but functional, e.g. so it could be tested without lots of manual actions outside of libvirt. Hopefully it's not large enough for review, because I have no idea how to make it smaller yet functional. About the driver itself. It supports the following operations on domains (not counting service ones): * define * start * destroy Domain configuration is limited, user can define RAM, vcpus, can specify only one block device and attach the domain to only one network of 'bridge' type (default network works fine). Having that, you can start a bhyve VM and it will get a network connectivity. Network supported added at the early state, because the only way to get inside VM but network is via stdout/stdin, which is not convenient at all. That was fixed in -CURRENT and one could use tty device, but I haven't upgrade my development box to that version yet. Testing information: I use an domain xml like that: https://gist.github.com/novel/8151244 On both host and guest I use FreeBSD amd64 10-BETA3. Guest image doesn't have much configuration except: ifconfig_vtnet0="DHCP" in /etc/rc.conf And allowing root loging for sshd. Also, if one wants to manually test the image outside of libvirt, this line is needed in /etc/ttys to be able to login from console: ttyu2 "/usr/libexec/getty std.9600" vt100 on secure Roman Bogorodskiy (1): bhyve: add a basic driver configure.ac | 37 ++++ daemon/libvirtd.c | 9 + include/libvirt/virterror.h | 1 + src/Makefile.am | 35 +++ src/bhyve/bhyve_driver.c | 529 ++++++++++++++++++++++++++++++++++++++++++++ src/bhyve/bhyve_driver.h | 28 +++ src/bhyve/bhyve_process.c | 386 ++++++++++++++++++++++++++++++++ src/bhyve/bhyve_process.h | 36 +++ src/bhyve/bhyve_utils.h | 48 ++++ src/conf/domain_conf.c | 3 +- src/conf/domain_conf.h | 1 + src/driver.h | 1 + src/libvirt.c | 3 + src/util/virerror.c | 1 + 14 files changed, 1117 insertions(+), 1 deletion(-) create mode 100644 src/bhyve/bhyve_driver.c create mode 100644 src/bhyve/bhyve_driver.h create mode 100644 src/bhyve/bhyve_process.c create mode 100644 src/bhyve/bhyve_process.h create mode 100644 src/bhyve/bhyve_utils.h -- 1.8.4.3

1 1

[libvirt] fail to live migration
by yue 27 Dec '13

27 Dec '13

hi,all i have no idea why? does this error have anything to do with virtio-channel via which outside process can communicate with guest's process. ------------------my app log-------- File "/usr/lib64/python2.6/site-packages/mcvda/libvirtconnection.py", line 87, in wrapper ret = f(*args, **kwargs) File "/usr/lib64/python2.6/site-packages/libvirt.py", line 1178, in migrateToURI2 if ret == -1: raise libvirtError ('virDomainMigrateToURI2() failed', dom=self) libvirtError: Failed to inquire lock: No such process --log libvirtd.log 2013-12-26 09:09:15.514+0000: 18953: error : qemuMonitorIORead:513 : Unable to read from monitor: Connection reset by peer 2013-12-26 09:09:15.514+0000: 18953: debug : qemuMonitorIO:646 : Error on monitor Unable to read from monitor: Connection reset by peer 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940d0530 2013-12-26 09:09:15.514+0000: 18953: debug : qemuMonitorIO:680 : Triggering error callback 2013-12-26 09:09:15.514+0000: 18953: debug : qemuProcessHandleMonitorError:357 : Received error on 0x7fd6940cd410 'QY-n1' 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectRef:168 : OBJECT_REF: obj=0x7fd6940d0640 2013-12-26 09:09:15.514+0000: 18953: error : qemuAgentIO:642 : internal error End of file from monitor 2013-12-26 09:09:15.514+0000: 18953: debug : qemuAgentIO:675 : Error on monitor internal error End of file from monitor 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940d0640 2013-12-26 09:09:15.514+0000: 18953: debug : qemuAgentIO:698 : Triggering EOF callback 2013-12-26 09:09:15.514+0000: 18953: debug : qemuProcessHandleAgentEOF:125 : Received EOF from agent on 0x7fd6940cd410 'QY-n1' 2013-12-26 09:09:15.514+0000: 18953: debug : qemuAgentClose:814 : mon=0x7fd6940d0640 2013-12-26 09:09:15.514+0000: 18953: debug : virFileClose:72 : Closed fd 29 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940d0640 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940d0640 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectUnref:137 : OBJECT_DISPOSE: obj=0x7fd6940d0640 2013-12-26 09:09:15.514+0000: 18953: debug : qemuAgentDispose:169 : mon=0x7fd6940d0640 2013-12-26 09:09:15.514+0000: 18953: debug : qemuProcessHandleAgentDestroy:186 : Received destroy agent=0x7fd6940d0640 vm=0x7fd6940cd410 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940cd410 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectRef:168 : OBJECT_REF: obj=0x7fd6940d0530 2013-12-26 09:09:15.514+0000: 18953: debug : qemuMonitorIO:646 : Error on monitor Unable to read from monitor: Connection reset by peer 2013-12-26 09:09:15.514+0000: 18953: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940d0530 2013-12-26 09:09:15.514+0000: 18953: debug : qemuMonitorIO:669 : Triggering EOF callback 2013-12-26 09:09:15.514+0000: 18953: debug : qemuProcessHandleMonitorEOF:298 : Received EOF on 0x7fd6940cd410 'QY-n1' 2013-12-26 09:09:15.514+0000: 18953: debug : qemuProcessHandleMonitorEOF:317 : Monitor connection to 'QY-n1' closed without SHUTDOWN event; assuming the domain crashed 2013-12-26 09:09:15.514+0000: 18953: debug : qemuProcessStop:4192 : Shutting down VM 'QY-n1' pid=20542 flags=0 2013-12-26 09:09:15.515+0000: 18953: debug : virFileClose:72 : Closed fd 28 2013-12-26 09:09:15.515+0000: 18953: debug : qemuMonitorClose:837 : QEMU_MONITOR_CLOSE: mon=0x7fd6940d0530 refs=3 2013-12-26 09:09:15.515+0000: 18953: debug : virFileClose:72 : Closed fd 30 2013-12-26 09:09:15.515+0000: 18953: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940d0530 2013-12-26 09:09:15.515+0000: 18953: debug : qemuProcessKill:4090 : vm=QY-n1 pid=20542 flags=5 2013-12-26 09:09:15.515+0000: 18957: debug : qemuMonitorSend:915 : Send command resulted in error Unable to read from monitor: Connection reset by peer 2013-12-26 09:09:15.715+0000: 18953: debug : virObjectRef:168 : OBJECT_REF: obj=0x7fd6940cd410 2013-12-26 09:09:15.715+0000: 18957: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940cd410 2013-12-26 09:09:15.715+0000: 18957: debug : virDomainLockProcessPause:194 : plugin=0x7fd698003020 dom=0x7fd6940cd410 state=0x7fd6940d93d8 2013-12-26 09:09:15.715+0000: 18957: debug : virDomainLockManagerNew:128 : plugin=0x7fd698003020 dom=0x7fd6940cd410 withResources=1 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerPluginGetDriver:283 : plugin=0x7fd698003020 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerNew:307 : driver=0x7fd69d17e900 type=0 nparams=5 params=0x7fd6a2f33720 flags=0 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerLogParams:107 : key=uuid type=uuid value=2619ef7c-d047-4468-b047-3099695f95b7 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerLogParams:100 : key=name type=string value=QY-n1 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerLogParams:88 : key=id type=uint value=4294967295 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerLogParams:88 : key=pid type=uint value=20542 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerLogParams:103 : key=uri type=cstring value=(null) 2013-12-26 09:09:15.715+0000: 18957: debug : virDomainLockManagerNew:140 : Adding leases 2013-12-26 09:09:15.715+0000: 18957: debug : virDomainLockManagerNew:145 : Adding disks 2013-12-26 09:09:15.715+0000: 18957: debug : virDomainLockManagerAddDisk:86 : Add disk /rhev/data-center/e0495ee4-cc01-41ca-9530-a58e184f6e29/c3a83221-1393-4bec-bc3a-214d82e7433c/images/cae86c44-d7fd-45d4-9c2c-ffba89ae31ad/1d04094d-9d76-407e-8924-63d2015f17ed 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerAddResource:336 : lock=0x7fd6880018f0 type=0 name=/rhev/data-center/e0495ee4-cc01-41ca-9530-a58e184f6e29/c3a83221-1393-4bec-bc3a-214d82e7433c/images/cae86c44-d7fd-45d4-9c2c-ffba89ae31ad/1d04094d-9d76-407e-8924-63d2015f17ed nparams=0 params=(nil) flags=0 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerRelease:369 : lock=0x7fd6880018f0 state=0x7fd6940d93d8 flags=0 2013-12-26 09:09:15.715+0000: 18957: error : virLockManagerSanlockRelease:1047 : Failed to inquire lock: No such process 2013-12-26 09:09:15.715+0000: 18957: debug : virLockManagerFree:391 : lock=0x7fd6880018f0 2013-12-26 09:09:15.715+0000: 18957: warning : qemuProcessStartCPUs:2846 : Unable to release lease on QY-n1 2013-12-26 09:09:15.715+0000: 18957: debug : qemuProcessStartCPUs:2847 : Preserving lock state '(null)' 2013-12-26 09:09:15.715+0000: 18957: debug : qemuProcessStop:4192 : Shutting down VM 'QY-n1' pid=20542 flags=1 2013-12-26 09:09:15.715+0000: 18957: debug : qemuProcessStop:4195 : VM 'QY-n1' not active 2013-12-26 09:09:15.715+0000: 18957: debug : qemuDomainObjEndAsyncJob:955 : Stopping async job: migration in 2013-12-26 09:09:15.715+0000: 18957: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940cd410 2013-12-26 09:09:15.715+0000: 18957: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940cd410 2013-12-26 09:09:15.715+0000: 18957: debug : virNetServerProgramSendError:150 : prog=536903814 ver=1 proc=217 type=1 serial=6 msg=0x2263720 rerr=0x7fd6a2f33b80 2013-12-26 09:09:15.715+0000: 18953: debug : virObjectUnref:135 : OBJECT_UNREF: obj=0x7fd6940cd410 2013-12-26 09:09:15.715+0000: 18953: debug : qemuDomainCleanupRun:1995 : driver=0x7fd69801fe50, vm=QY-n1 2013-12-26 09:09:15.715+0000: 18953: debug : qemuProcessAutoDestroyRemove:4670 : vm=QY-n1

1 0

[libvirt] python setMetadata issue
by Umar Draz 25 Dec '13

25 Dec '13

Hi I am trying to set Metada of running virtual machine, but its giving me an error. Here is my code import libvirt conn = libvirt.open('qemu+tcp://10.0.128.12/system') dom = conn.lookupByName('virtspace') type = 'VIR_DOMAIN_METADATA_DESCRIPTION' key = '' uri = '' dom.setMetadata(conn, type, 'myDescription', key, uri) and here is the error. Traceback (most recent call last): File "setMeta.py", line 11, in <module> dom.setMetadata(conn, type, 'meta_test', key, uri) File "/usr/lib64/python2.6/site-packages/libvirt.py", line 1460, in setMetadata ret = libvirtmod.virDomainSetMetadata(self._o, type, metadata, key, uri, flags) AttributeError: virConnect instance has no attribute '__trunc__'

2 1

[libvirt] [PATCH] domain: don't try to interpret <driver> as virtio config for hostdev interfaces
by Laine Stump 24 Dec '13

24 Dec '13

This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1046337 The <driver> type attribute of an interface is interpreted in two different ways depending on the <interface> type - if the interface is type='hostdev', then the driver name describes which backend to use for the hostdev device assignment (vfio or kvm), but if the interface is any emulated type *and* the model type is "virtio", then the driver name can be "vhost" or "qemu", telling which backend qemu should use to communicate with the emulated device. The problem comes when someone has defined a an interface like this (which is accepted by the parser as long as no <driver name='xxx'/> is specified): <interface type='hostdev'> ... <model type='virtio'/> ... </interface> As libvirt storing this definition in the domain's status, the driver name is automatically filled in with the backend that was automatically decided by libvirt, so it stores this in the status: <interface type='hostdev'> ... <driver name='vfio'/> ... <model type='virtio'/> ... </interface> This isn't noticed until the next time libvirtd is restarted - as it is reading the status of all domains, it encounters the above interface definition, logs an error: internal error: Unknown interface <driver name='vfio'> has been specified and fails to reload the domain status, so the domain is marked as inactive. The solution is to stop the parser from interpreting <driver> attributes as if the device was an emulated virtio device, when it is actually a hostdev. (Although the bug has existed since vfio support was added, it has just recently become more apparent because libvirt previously didn't automatically set the driver name for hostdev interfaces in the domain status to vfio/kvm as it does since commit f094aa, first appearing in v1.1.4.) --- src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 80bc85f..e65f3e3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6752,7 +6752,8 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, model = NULL; } - if (def->model && STREQ(def->model, "virtio")) { + if (def->type != VIR_DOMAIN_NET_TYPE_HOSTDEV && + STREQ_NULLABLE(def->model, "virtio")) { if (backend != NULL) { int name; if ((name = virDomainNetBackendTypeFromString(backend)) < 0 || -- 1.8.3.1

2 1

[libvirt] [PATCH v2 0/3] libxl: improve vcpu pinning
by Dario Faggioli 24 Dec '13

24 Dec '13

Hi, Take two, with the comments from Jim on v1 fixed. Basically, that means I've added a few comments and removed some non necessary safety checking. Series available here: git://xenbits.xen.org/people/dariof/libvirt.git libxl/VcpuPinX-v2 Regards, Dario --- Dario Faggioli (3): libxl: implement virDomainGetVcpuPinInfo libxl: implement virDomainPinVcpuFlags libxl: correctly handle affinity reset in virDomainPinVcpu[Flags] src/libxl/libxl_driver.c | 166 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 145 insertions(+), 21 deletions(-) -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

2 4

[libvirt] [PATCH] virt-login-shell: clean up usage
by Eric Blake 24 Dec '13

24 Dec '13

I noticed a couple odd things in 'virt-login-shell --help' output. * tools/virt-login-shell.c (usage): At most one option accepted, drop trailing colon. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the trivial rule. tools/virt-login-shell.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virt-login-shell.c b/tools/virt-login-shell.c index 758d1af..8b35e34 100644 --- a/tools/virt-login-shell.c +++ b/tools/virt-login-shell.c @@ -161,10 +161,10 @@ usage(void) fprintf(stdout, _("\n" "Usage:\n" - " %s [options]\n\n" + " %s [option]\n\n" "Options:\n" - " -h | --help Display program help:\n" - " -V | --version Display program version:\n" + " -h | --help Display program help\n" + " -V | --version Display program version\n" "\n" "libvirt login shell\n"), progname); -- 1.8.4.2

1 0