- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Make virFileFindHugeTLBFS fault tolerant
by Michal Privoznik 07 Aug '14

07 Aug '14

Since commit be0782e1 we are parsing /proc/meminfo to find out the default huge page size. However, if the host we are running at does not support any huge pages (e.g. CONFIG_HUGETLB_PAGE is turned off), we will not successfully parse the meminfo file and hence the whole qemu driver init process fails. Moreover, the default huge page size is needed if and only if there's at least one hugetlbfs mount point. So the fix consists of moving the virFileGetDefaultHugepageSize function call after the first hugetlbfs mount point is found. With this fix, we fail to start with one or more hugetlbfs mounts and malformed meminfo file, but that's expected (how can one mount hugetlbfs without kernel supporting huge pages?). Workaround in that case is to umount all the hugetlbfs mounts. Reported-by: Jim Fehlig <jfehlig(a)suse.com> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virfile.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 9863fd0..f9efc65 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -2990,10 +2990,7 @@ virFileFindHugeTLBFS(virHugeTLBFSPtr *ret_fs, char mntbuf[1024]; virHugeTLBFSPtr fs = NULL; size_t nfs = 0; - unsigned long long default_hugepagesz; - - if (virFileGetDefaultHugepageSize(&default_hugepagesz) < 0) - goto cleanup; + unsigned long long default_hugepagesz = 0; if (!(f = setmntent(PROC_MOUNTS, "r"))) { virReportSystemError(errno, @@ -3019,6 +3016,10 @@ virFileFindHugeTLBFS(virHugeTLBFSPtr *ret_fs, if (virFileGetHugepageSize(tmp->mnt_dir, &tmp->size) < 0) goto cleanup; + if (!default_hugepagesz && + virFileGetDefaultHugepageSize(&default_hugepagesz) < 0) + goto cleanup; + tmp->deflt = tmp->size == default_hugepagesz; } -- 1.8.5.5

3 2

[libvirt] handle different version of QEMU
by Matthias Gatto 06 Aug '14

06 Aug '14

Hello, I'm implementing the "new" QEMU option of block_set_io_throttle(@bps_max, @bps_rd_max...), but i have a problem: The old version of QEMU(before 1.7) does not handle it, so I'd like to know what function should i use to know the version of QEMU, and what's the proper way to handle this problem ?

2 2

[libvirt] [python PATCH] Bump version to 1.2.8 for new dev cycle
by Eric Blake 06 Aug '14

06 Aug '14

Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the trivial rule. setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 334d7b2..f5c6542 100755 --- a/setup.py +++ b/setup.py @@ -309,7 +309,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '1.2.7', + version = '1.2.8', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 1.9.3

4 4

[libvirt] [PATCH v2 0/8] Add iSCSI hostdev pass-through device
by John Ferlan 06 Aug '14

06 Aug '14

Followup/rebase to partially ACK'd pile of changes - figure it's just as easy for me to keep things together and it's better to see things in totality... See: http://www.redhat.com/archives/libvir-list/2014-July/msg00592.html * Patches 1-5 were adjusted to use the first_/second_ naming scheme rather than a/b. * Typo for 'vedor' in patch 1 adjusted. * Changed name of iSCSIFree to iSCSIClear. John Ferlan (8): hostdev: Introduce virDomainHostdevSubsysUSB hostdev: Introduce virDomainHostdevSubsysPCI hostdev: Introduce virDomainHostdevSubsysSCSI hostdev: Introduce virDomainHostdevSubsysSCSIHost Add virConnectPtr for qemuBuildSCSIHostdevDrvStr hostdev: Introduce virDomainHostdevSubsysSCSIiSCSI domain_conf: Common routine to handle network storage host xml def hostdev: Add iSCSI hostdev XML docs/formatdomain.html.in | 142 +++++-- docs/schemas/domaincommon.rng | 46 +- src/conf/domain_audit.c | 38 +- src/conf/domain_conf.c | 471 ++++++++++++++------- src/conf/domain_conf.h | 80 +++- src/libxl/libxl_conf.c | 9 +- src/libxl/libxl_domain.c | 6 +- src/libxl/libxl_driver.c | 34 +- src/lxc/lxc_cgroup.c | 4 +- src/lxc/lxc_controller.c | 10 +- src/lxc/lxc_driver.c | 16 +- src/qemu/qemu_cgroup.c | 69 +-- src/qemu/qemu_command.c | 158 ++++--- src/qemu/qemu_command.h | 5 +- src/qemu/qemu_conf.c | 20 +- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_hotplug.c | 93 ++-- src/qemu/qemu_hotplug.h | 9 +- src/security/security_apparmor.c | 33 +- src/security/security_dac.c | 66 +-- src/security/security_selinux.c | 64 +-- src/security/virt-aa-helper.c | 5 +- src/util/virhostdev.c | 295 +++++++------ .../qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.args | 14 + .../qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.xml | 46 ++ .../qemuxml2argv-hostdev-scsi-lsi-iscsi.args | 14 + .../qemuxml2argv-hostdev-scsi-lsi-iscsi.xml | 40 ++ ...emuxml2argv-hostdev-scsi-virtio-iscsi-auth.args | 16 + ...qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.xml | 46 ++ .../qemuxml2argv-hostdev-scsi-virtio-iscsi.args | 16 + .../qemuxml2argv-hostdev-scsi-virtio-iscsi.xml | 40 ++ tests/qemuxml2argvtest.c | 16 + tests/qemuxml2xmltest.c | 5 + 33 files changed, 1322 insertions(+), 610 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi.xml -- 1.9.3

2 24

[libvirt] [PATCH 0/2] Fix PCI address validation
by Pavel Hrdina 06 Aug '14

06 Aug '14

Pavel Hrdina (2): domain_conf: refactor virDomainDeviceAddressIsValid to boolean device_conf: PCI address pci_0000_00_00_0 is also valid src/conf/device_conf.c | 7 ++++--- src/conf/device_conf.h | 2 +- src/conf/domain_conf.c | 16 ++++++++-------- src/conf/domain_conf.h | 4 ++-- 4 files changed, 15 insertions(+), 14 deletions(-) -- 1.8.5.5

2 4

[libvirt] [PATCH] blockjob: correctly report active commit for job info
by Eric Blake 06 Aug '14

06 Aug '14

Commit 232a31b munged job info to report 'active commit' instead of 'commit' when generating events, but forgot to also munge the polling variant of the command. * src/qemu/qemu_driver.c (qemuDomainBlockJobImpl): Adjust type as needed. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a3de784..57cc913 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15103,6 +15103,9 @@ qemuDomainBlockJobImpl(virDomainObjPtr vm, ret = qemuMonitorBlockJob(priv->mon, device, basePath, backingPath, bandwidth, info, mode, async); qemuDomainObjExitMonitor(driver, vm); + if (info && info->type == VIR_DOMAIN_BLOCK_JOB_TYPE_COMMIT && + disk->mirrorJob == VIR_DOMAIN_BLOCK_JOB_TYPE_ACTIVE_COMMIT) + info->type = disk->mirrorJob; if (ret < 0) { if (mode == BLOCK_JOB_ABORT && disk->mirror) disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_NONE; -- 1.9.3

2 2

[libvirt] [PATCH] qemu: reword caps-related error
by Martin Kletzander 06 Aug '14

06 Aug '14

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 8eba8e8..a4a96af 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3456,7 +3456,9 @@ static int qemuDumpToFd(virQEMUDriverPtr driver, virDomainObjPtr vm, if (ret <= 0) { virReportError(VIR_ERR_INVALID_ARG, - _("unsupported dumpformat '%s'"), dumpformat); + _("unsupported dumpformat '%s' " + "for this QEMU binary"), + dumpformat); ret = -1; goto cleanup; } -- 2.0.4

2 1

[libvirt] [PATCH] lxc: Report container init process failures.
by Jarek Dziedzic 05 Aug '14

05 Aug '14

This change improves the reporting of container stop reason. Before this change if the init process of lxc container has crashed or returned non zero status, the domain state listeners would be notified that a domain has stopped due to normal shutdown. This maps to VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN and is exactly the same as the stop reason reported when the init process ends without errors. After this patch, when the container init process exits with a non zero status (or crashes) the reported stop reason will be VIR_DOMAIN_EVENT_STOPPED_CRASHED. --- src/lxc/lxc_controller.c | 16 ++++++++++++++-- src/lxc/lxc_monitor_protocol.x | 3 ++- src/lxc/lxc_process.c | 3 +++ src/lxc_monitor_protocol-structs | 1 + 4 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 2d220eb..e8ff1c4 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -821,7 +821,7 @@ static int lxcControllerClearCapabilities(void) static bool wantReboot = false; static virMutex lock = VIR_MUTEX_INITIALIZER; - +static int initProcessExitCode = 0; static void virLXCControllerSignalChildIO(virNetServerPtr server, siginfo_t *info ATTRIBUTE_UNUSED, @@ -834,6 +834,11 @@ static void virLXCControllerSignalChildIO(virNetServerPtr server, ret = waitpid(-1, &status, WNOHANG); VIR_DEBUG("Got sig child %d vs %lld", ret, (unsigned long long)ctrl->initpid); if (ret == ctrl->initpid) { + VIR_DEBUG("Init process waitpid status 0x%x", status); + if (WIFEXITED(status)) { + initProcessExitCode = WEXITSTATUS(status); + VIR_INFO("Init process exited. Exit code = %d", initProcessExitCode); + } virNetServerQuit(server); virMutexLock(&lock); if (WIFSIGNALED(status) && @@ -841,6 +846,10 @@ static void virLXCControllerSignalChildIO(virNetServerPtr server, VIR_DEBUG("Status indicates reboot"); wantReboot = true; } + else if (WIFSIGNALED(status)) { + initProcessExitCode = 0x80 + WTERMSIG(status); + VIR_INFO("Init process received a signal %d. Exit code = %d", WTERMSIG(status), initProcessExitCode); + } virMutexUnlock(&lock); } } @@ -2080,7 +2089,10 @@ virLXCControllerEventSendExit(virLXCControllerPtr ctrl, memset(&msg, 0, sizeof(msg)); switch (exitstatus) { case 0: - msg.status = VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN; + if (initProcessExitCode == 0) + msg.status = VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN; + else + msg.status = VIR_LXC_MONITOR_EXIT_STATUS_INIT_PROCESS_ERROR; break; case 1: msg.status = VIR_LXC_MONITOR_EXIT_STATUS_REBOOT; diff --git a/src/lxc/lxc_monitor_protocol.x b/src/lxc/lxc_monitor_protocol.x index 0926e26..beb2272 100644 --- a/src/lxc/lxc_monitor_protocol.x +++ b/src/lxc/lxc_monitor_protocol.x @@ -7,7 +7,8 @@ enum virLXCMonitorExitStatus { VIR_LXC_MONITOR_EXIT_STATUS_ERROR, VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN, - VIR_LXC_MONITOR_EXIT_STATUS_REBOOT + VIR_LXC_MONITOR_EXIT_STATUS_REBOOT, + VIR_LXC_MONITOR_EXIT_STATUS_INIT_PROCESS_ERROR }; struct virLXCMonitorExitEventMsg { diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 3353dc1..fb65919 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -553,6 +553,9 @@ static void virLXCProcessMonitorExitNotify(virLXCMonitorPtr mon ATTRIBUTE_UNUSED case VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN: priv->stopReason = VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN; break; + case VIR_LXC_MONITOR_EXIT_STATUS_INIT_PROCESS_ERROR: + priv->stopReason = VIR_DOMAIN_EVENT_STOPPED_CRASHED; + break; case VIR_LXC_MONITOR_EXIT_STATUS_ERROR: priv->stopReason = VIR_DOMAIN_EVENT_STOPPED_FAILED; break; diff --git a/src/lxc_monitor_protocol-structs b/src/lxc_monitor_protocol-structs index da72ec0..b3877d3 100644 --- a/src/lxc_monitor_protocol-structs +++ b/src/lxc_monitor_protocol-structs @@ -3,6 +3,7 @@ enum virLXCMonitorExitStatus { VIR_LXC_MONITOR_EXIT_STATUS_ERROR = 0, VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN = 1, VIR_LXC_MONITOR_EXIT_STATUS_REBOOT = 2, + VIR_LXC_MONITOR_EXIT_STATUS_INIT_PROCESS_ERROR = 3, }; struct virLXCMonitorExitEventMsg { enum virLXCMonitorExitStatus status; -- 1.9.3

1 0

[libvirt] help
by Himanshu Sharma 05 Aug '14

05 Aug '14

Dear Team, Greetings!! I'm testing libvirt with VMware ESXi. I'm able to connect to VMware ESXi with libvirt driver but not able to connect it through "Virtual Machine manager" GUI also not able to run virt-clone command inturn to clone ESXi VM. Can you please guide me how to do so? -----Original Message----- From: libvir-list-bounces(a)redhat.com [mailto:libvir-list-bounces@redhat.com] On Behalf Of libvir-list-request(a)redhat.com Sent: 05 August 2014 14:49 To: Himanshu Sharma Subject: Welcome to the "libvir-list" mailing list Welcome to the libvir-list(a)redhat.com mailing list! To post to this list, send your email to: libvir-list(a)redhat.com General information about the mailing list is at: https://www.redhat.com/mailman/listinfo/libvir-list If you ever want to unsubscribe or change your options (eg, switch to or from digest mode, change your password, etc.), visit your subscription page at: https://www.redhat.com/mailman/options/libvir-list/himanshu.sharma%40nectec… You can also make such adjustments via email by sending a message to: libvir-list-request(a)redhat.com with the word `help' in the subject or body (don't include the quotes), and you will get back a message with instructions. You must know your password to change your options (including changing the password, itself) or to unsubscribe. It is: Normally, Mailman will remind you of your redhat.com mailing list passwords once every month, although you can disable this if you prefer. This reminder will also include instructions on how to unsubscribe or change your account options. There is also a button on your options page that will email your current password to you. DISCLAIMER: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. It shall not attach any liability on the originator or NEC or its affiliates. Any views or opinions presented in this email are solely those of the author and may not necessarily reflect the opinions of NEC or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. . -----------------------------------------------------------------------------------------------------------------------

2 1

[libvirt] [PATCH] lxc: Report container init process failures.
by Jarek Dziedzic 05 Aug '14

05 Aug '14

This change improves the reporting of container stop reason. Before this change if the init process of lxc container has crashed or returned non zero status, the domain state listeners would be notified that a domain has stopped due to normal shutdown. This maps to VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN and is exactly the same as the stop reason reported when the init process ends without errors. After this patch, when the container init process exits with a non zero status (or crashes) the reported stop reason will be VIR_DOMAIN_EVENT_STOPPED_CRASHED. --- src/lxc/lxc_controller.c | 16 ++++++++++++++-- src/lxc/lxc_monitor_protocol.x | 3 ++- src/lxc/lxc_process.c | 3 +++ src/lxc_monitor_protocol-structs | 1 + 4 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 2d220eb..e8ff1c4 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -821,7 +821,7 @@ static int lxcControllerClearCapabilities(void) static bool wantReboot = false; static virMutex lock = VIR_MUTEX_INITIALIZER; - +static int initProcessExitCode = 0; static void virLXCControllerSignalChildIO(virNetServerPtr server, siginfo_t *info ATTRIBUTE_UNUSED, @@ -834,6 +834,11 @@ static void virLXCControllerSignalChildIO(virNetServerPtr server, ret = waitpid(-1, &status, WNOHANG); VIR_DEBUG("Got sig child %d vs %lld", ret, (unsigned long long)ctrl->initpid); if (ret == ctrl->initpid) { + VIR_DEBUG("Init process waitpid status 0x%x", status); + if (WIFEXITED(status)) { + initProcessExitCode = WEXITSTATUS(status); + VIR_INFO("Init process exited. Exit code = %d", initProcessExitCode); + } virNetServerQuit(server); virMutexLock(&lock); if (WIFSIGNALED(status) && @@ -841,6 +846,10 @@ static void virLXCControllerSignalChildIO(virNetServerPtr server, VIR_DEBUG("Status indicates reboot"); wantReboot = true; } + else if (WIFSIGNALED(status)) { + initProcessExitCode = 0x80 + WTERMSIG(status); + VIR_INFO("Init process received a signal %d. Exit code = %d", WTERMSIG(status), initProcessExitCode); + } virMutexUnlock(&lock); } } @@ -2080,7 +2089,10 @@ virLXCControllerEventSendExit(virLXCControllerPtr ctrl, memset(&msg, 0, sizeof(msg)); switch (exitstatus) { case 0: - msg.status = VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN; + if (initProcessExitCode == 0) + msg.status = VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN; + else + msg.status = VIR_LXC_MONITOR_EXIT_STATUS_INIT_PROCESS_ERROR; break; case 1: msg.status = VIR_LXC_MONITOR_EXIT_STATUS_REBOOT; diff --git a/src/lxc/lxc_monitor_protocol.x b/src/lxc/lxc_monitor_protocol.x index 0926e26..beb2272 100644 --- a/src/lxc/lxc_monitor_protocol.x +++ b/src/lxc/lxc_monitor_protocol.x @@ -7,7 +7,8 @@ enum virLXCMonitorExitStatus { VIR_LXC_MONITOR_EXIT_STATUS_ERROR, VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN, - VIR_LXC_MONITOR_EXIT_STATUS_REBOOT + VIR_LXC_MONITOR_EXIT_STATUS_REBOOT, + VIR_LXC_MONITOR_EXIT_STATUS_INIT_PROCESS_ERROR }; struct virLXCMonitorExitEventMsg { diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 3353dc1..fb65919 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -553,6 +553,9 @@ static void virLXCProcessMonitorExitNotify(virLXCMonitorPtr mon ATTRIBUTE_UNUSED case VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN: priv->stopReason = VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN; break; + case VIR_LXC_MONITOR_EXIT_STATUS_INIT_PROCESS_ERROR: + priv->stopReason = VIR_DOMAIN_EVENT_STOPPED_CRASHED; + break; case VIR_LXC_MONITOR_EXIT_STATUS_ERROR: priv->stopReason = VIR_DOMAIN_EVENT_STOPPED_FAILED; break; diff --git a/src/lxc_monitor_protocol-structs b/src/lxc_monitor_protocol-structs index da72ec0..b3877d3 100644 --- a/src/lxc_monitor_protocol-structs +++ b/src/lxc_monitor_protocol-structs @@ -3,6 +3,7 @@ enum virLXCMonitorExitStatus { VIR_LXC_MONITOR_EXIT_STATUS_ERROR = 0, VIR_LXC_MONITOR_EXIT_STATUS_SHUTDOWN = 1, VIR_LXC_MONITOR_EXIT_STATUS_REBOOT = 2, + VIR_LXC_MONITOR_EXIT_STATUS_INIT_PROCESS_ERROR = 3, }; struct virLXCMonitorExitEventMsg { enum virLXCMonitorExitStatus status; -- 1.9.3

1 0