- Devel - libvirt List Archives

Re: [libvirt] [GIT PULL] namespace updates for v3.17-rc1
by Adrian Davey 16 Oct '14

16 Oct '14

On 21.08.2014 08:54:57, writes Eric W. Biederman: > Richard Weinberger <richard nod at> writes: > >> Am 21.08.2014 08:29, schrieb Richard Weinberger: >>> Am 21.08.2014 06:53, schrieb Eric W. Biederman: >>>> The bugs fixed are security issues, so if we have to break a small >>>> number of userspace applications we will. Anything that we can >>>> reasonably do to avoid regressions will be done. >>>> >>>> Could you please look at my user-namespace.git#for-next branch I >>>> have a >>>> fix for at least one regresion causing issue in there. I think it >>>> may >>>> fix your issues but I am not fully certain more comments below. >>> >>> I'll run this on my LXC testbed today. >> >> Looks good. With these patches applied libvirt works again. :) > > Darn I read my email in the wrong order. I am glad to hear that my > changes were enough to fix libvirt-lxc. > > I will aim at pushing this to Linus after the conference is over and I > can trust myself to think clearly. > > Eric Apologies for the poor etiquette on posting (normal email client is broken so using a web version). I am trying to track down if my issues with libvirt_lxc are down to me missing the changes in libvirt or the kernel (libvirt 1.2.9, Linux 3.16.3) that are mentioned from this thread. I am looking for either the git changes in both libvirt and linux (currently failing to find either) or if indeed these changes made it upstream? Is anyone able to point me in the right direction please? This is for the issue I have with proc remounting while using <idmap> which I believe is the problem talked about in this thread, but I could well be barking up the wrong tree. virsh # start testvm error: Failed to start domain testvm error: internal error: guest failed to start: Failed to re-mount /proc/sys on /proc/sys flags=1021: Operation not permitted Many thanks, Adrian

1 0

[libvirt] [libvirt-python PATCH] Improve error output when use getTime with a nonzero flags.
by Luyao Huang 16 Oct '14

16 Oct '14

When give a nonzero flags to getTime, c_retval will get -1 and goto cleanup. But py_retval still is NULL,so pass c_retval value to py_retval. This will make the output message more correct. error before use this patch: SystemError: error return without exception set after use the patch: libvirtError: unsupported flags (0x1) in function qemuDomainGetTime Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- libvirt-override.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-override.c b/libvirt-override.c index 9ba87eb..eed8d50 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -7758,6 +7758,7 @@ libvirt_virDomainGetTime(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) { LIBVIRT_END_ALLOW_THREADS; if (c_retval < 0) + py_retval = libvirt_intWrap(c_retval); goto cleanup; if (!(pyobj_seconds = libvirt_longlongWrap(seconds)) || -- 1.8.3.1

1 0

[libvirt] [libvirt-python PATCH 1/1] Change the comment in getPyNodeCPUCount method reflecting correct called methods
by Pradipta Kr. Banerjee 16 Oct '14

16 Oct '14

Comment mentions virGetNodeCPUMap whereas the actual method is virNodeGetCPUMap. Similarly comment mentions virGetNodeInfo whereas the actual method is virNodeGetInfo Signed-off-by: Pradipta Kr. Banerjee <bpradip(a)in.ibm.com> --- libvirt-override.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-override.c b/libvirt-override.c index 8b3c503..9ba87eb 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -437,10 +437,10 @@ cleanup: /* * Utility function to retrieve the number of node CPUs present. - * It first tries virGetNodeCPUMap, which will return the + * It first tries virNodeGetCPUMap, which will return the * number reliably, if available. * As a fallback and for compatibility with backlevel libvirt - * versions virGetNodeInfo will be called to calculate the + * versions virNodeGetInfo will be called to calculate the * CPU number, which has the potential to return a too small * number if some host CPUs are offline. */ -- 1.9.3

2 1

[libvirt] [PATCH] tools: compatible with old wireshark
by Jincheng Miao 16 Oct '14

16 Oct '14

Old version wireshark doesn't have ws_symbol_export.h, which is added from wireshark-v1.10.0. But some distros, like RHEL6u5, only have wireshark-v1.8, so libvirt should be compatible with these wiresharks. Signed-off-by: Jincheng Miao <jmiao(a)redhat.com> --- configure.ac | 2 +- tools/wireshark/util/make-dissector-reg | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f7b02ff..c62f934 100644 --- a/configure.ac +++ b/configure.ac @@ -2667,7 +2667,7 @@ if test "$with_wireshark_dissector" != "no"; then LIBVIRT_WS_HANDLE_ERROR([wireshark/config.h is required for wireshark-dissector support]) ]) AC_CHECK_HEADERS([wireshark/epan/packet.h wireshark/epan/dissectors/packet-tcp.h],, [ - LIBVIRT_WS_HANDLE_ERROR([wireshark/epan/{packet,packet-tcp}.h are required for wireshark-dissector support]) + LIBVIRT_WS_HANDLE_ERROR([wireshark/epan/{packet,/dissectors/packet-tcp}.h are required for wireshark-dissector support]) ], [ #include <wireshark/config.h> ]) diff --git a/tools/wireshark/util/make-dissector-reg b/tools/wireshark/util/make-dissector-reg index 6fa25c1..2524f09 100755 --- a/tools/wireshark/util/make-dissector-reg +++ b/tools/wireshark/util/make-dissector-reg @@ -53,7 +53,21 @@ then /* plugins are DLLs */ #define WS_BUILD_DLL -#include "ws_symbol_export.h" + +/* File ws_symbol_export.h is introduced from commit id + * 45c2884 (1.10.0). For compatability with old wireshark, + * which is provided by some distros, like RHEL6u5, + * here define WS_DLL_PUBLIC_NOEXTERN manually. + */ +#if WIRESHARK_VERSION < 1010000 +# if __GNUC__ >= 4 +# define WS_DLL_PUBLIC_NOEXTERN __attribute__ ((visibility("default"))) +# else +# define WS_DLL_PUBLIC_NOEXTERN __attribute__ ((dllexport)) +# endif +#else +# include "ws_symbol_export.h" +#endif /* In 1.12 wireshark WS_DLL_PUBLIC_NOEXTERN was substitued with * WS_DLL_PUBLIC_DEF. See wireshark's commit -- 1.9.3

1 0

[libvirt] [PATCH 0/5] qemu: Fix rest of hot/cold-add/remove device functions to use typecasted switch
by Peter Krempa 15 Oct '14

15 Oct '14

Tweak the rest of the stuff to get notified at compile time when adding a new device type to implement it's backend functions. Peter Krempa (5): qemu: Convert qemuDomainDetachDeviceLive to typecasted enum qemu: Convert qemuDomainUpdateDeviceLive to typecasted enum qemu: Convert qemuDomainAttachDeviceConfig to typecasted enum qemu: Convert qemuDomainDetachDeviceConfig to typecasted enum qemu: Convert qemuDomainUpdateDeviceConfig to typecasted enum src/qemu/qemu_driver.c | 96 ++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 85 insertions(+), 11 deletions(-) -- 2.1.0

2 7

[libvirt] [PATCH] conf: fix an memory leak in virSocketAddrIsNumericLocalhost()
by Chen Fan 15 Oct '14

15 Oct '14

Signed-off-by: Chen Fan <chen.fan.fnst(a)cn.fujitsu.com> --- src/util/virsocketaddr.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 8c9f05f..5f54e68 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -894,19 +894,24 @@ virSocketAddrIsNumericLocalhost(const char *addr) struct in_addr tmp = { .s_addr = htonl(INADDR_LOOPBACK) }; struct sockaddr_in *inet4; struct sockaddr_in6 *inet6; + bool ret = false; if (virSocketAddrParseInternal(&res, addr, AF_UNSPEC, false) < 0) - return false; + return ret; switch (res->ai_addr->sa_family) { case AF_INET: inet4 = (struct sockaddr_in*) res->ai_addr; - return memcmp(&inet4->sin_addr.s_addr, &tmp.s_addr, - sizeof(inet4->sin_addr.s_addr)) == 0; + ret = memcmp(&inet4->sin_addr.s_addr, &tmp.s_addr, + sizeof(inet4->sin_addr.s_addr)) == 0; + break; case AF_INET6: inet6 = (struct sockaddr_in6*) res->ai_addr; - return IN6_IS_ADDR_LOOPBACK(&(inet6->sin6_addr)); + ret = IN6_IS_ADDR_LOOPBACK(&(inet6->sin6_addr)); + break; } - return false; + + freeaddrinfo(res); + return ret; } -- 1.9.3

2 1

[libvirt] [PATCH v3 0/3] Check migration configuration
by Chen Fan 15 Oct '14

15 Oct '14

add some check in migration configuration. Chen Fan (3): migration: add migration_host support for Ipv6 address without brackets conf: add check if migration_host is a localhost address conf: Check migration_address whether is localhost src/libvirt_private.syms | 3 +- src/qemu/qemu.conf | 2 +- src/qemu/qemu_conf.c | 58 ++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_migration.c | 49 ++++++++++++++++---------------- src/qemu/test_libvirtd_qemu.aug.in | 2 +- src/util/virsocketaddr.c | 43 +++++++++++++++++++++------- src/util/virsocketaddr.h | 4 ++- tests/sockettest.c | 2 +- 9 files changed, 125 insertions(+), 40 deletions(-) -- 1.9.3

4 11

[libvirt] [PATCH 0/9] ABI/JSON/other fixes
by Peter Krempa 15 Oct '14

15 Oct '14

I've split out these patches from my work on supporting memory hotplug in qemu so that the resulting series is not extremely huge. Peter Krempa (9): conf: Improve adding of new address types conf: shmem: Add ABI stability check conf: Add compile time check that devices were checked for ABI stability qemu: hotplug: Use typecasted switch statement when plugging new devices util: json: Split out code to create json value objects util: json: Improve handling and docs for adding JSON objects qemu: monitor: Add functions for object hot-add/remove Implement empty post parse callbacks for all drivers conf: Move definition of virDomainParseMemory src/bhyve/bhyve_domain.c | 10 ++ src/conf/domain_conf.c | 179 +++++++++++++++++++++++-------- src/conf/domain_conf.h | 2 +- src/libvirt_private.syms | 2 + src/parallels/parallels_driver.c | 21 ++++ src/phyp/phyp_driver.c | 29 ++++- src/qemu/qemu_driver.c | 17 ++- src/qemu/qemu_monitor.c | 48 +++++++++ src/qemu/qemu_monitor.h | 8 ++ src/qemu/qemu_monitor_json.c | 217 ++++++++++--------------------------- src/qemu/qemu_monitor_json.h | 8 ++ src/uml/uml_driver.c | 10 ++ src/util/virjson.c | 224 +++++++++++++++++++++++++++++++++++++++ src/util/virjson.h | 5 + src/vbox/vbox_common.c | 19 ++++ src/vmware/vmware_driver.c | 24 ++++- src/vmx/vmx.c | 18 ++++ src/xenapi/xenapi_driver.c | 10 ++ 18 files changed, 645 insertions(+), 206 deletions(-) -- 2.1.0

2 21

[libvirt] [PATCH] libvirt: Document UNDEFINE_NVRAM in UndefineFlags doc
by Cole Robinson 15 Oct '14

15 Oct '14

--- src/libvirt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index caacc2e..dfca4f6 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -8760,6 +8760,10 @@ virDomainUndefine(virDomainPtr domain) * whether this flag is present. On hypervisors where snapshots do * not use libvirt metadata, this flag has no effect. * + * If the domain has any nvram specified, then including + * VIR_DOMAIN_UNDEFINE_NVRAM will also remove that file, and omitting the flag + * will cause the undefine process to fail. + * * Returns 0 in case of success, -1 in case of error */ int -- 2.1.0

2 2

[libvirt] [PATCH] Cleanup maintainers list
by Jiri Denemark 15 Oct '14

15 Oct '14

These Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- AUTHORS.in | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/AUTHORS.in b/AUTHORS.in index 0e0e613..3c783f7 100644 --- a/AUTHORS.in +++ b/AUTHORS.in @@ -8,32 +8,25 @@ Daniel Veillard <veillard(a)redhat.com> or <daniel(a)veillard.com> The primary maintainers and people with commit access rights: Alex Jia <ajia(a)redhat.com> -Anthony Liguori <aliguori(a)us.ibm.com> Cédric Bosdonnat <cbosdonnat(a)suse.com> -Chris Lalancette <clalance(a)redhat.com> Christophe Fergeau <cfergeau(a)redhat.com> Claudio Bley <cbley(a)av-test.de> Cole Robinson <crobinso(a)redhat.com> Daniel Berrange <berrange(a)redhat.com> Daniel Veillard <veillard(a)redhat.com> -Dave Allan <dallan(a)redhat.com> Doug Goldstein <cardoe(a)gentoo.org> Eric Blake <eblake(a)redhat.com> Gao Feng <gaofeng(a)cn.fujitsu.com> -Guannan Ren <gren(a)redhat.com> Guido Günther <agx(a)sigxcpu.org> Ján Tomko <jtomko(a)redhat.com> Jim Fehlig <jfehlig(a)suse.com> -Jim Meyering <meyering(a)redhat.com> Jiří Denemark <jdenemar(a)redhat.com> John Ferlan <jferlan(a)redhat.com> -John Levon <john.levon(a)sun.com> Laine Stump <laine(a)redhat.com> Mark McLoughlin <markmc(a)redhat.com> Martin Kletzander <mkletzan(a)redhat.com> Matthias Bolte <matthias.bolte(a)googlemail.com> Michal Prívozník <mprivozn(a)redhat.com> -Osier Yang <jyang(a)redhat.com> Pavel Hrdina <phrdina(a)redhat.com> Peter Krempa <pkrempa(a)redhat.com> Richard W.M. Jones <rjones(a)redhat.com> @@ -43,11 +36,18 @@ Wen Congyang <wency(a)cn.fujitsu.com> Previous maintainers: +Anthony Liguori <aliguori(a)us.ibm.com> Atsushi SAKAI <sakaia(a)jp.fujitsu.com> +Chris Lalancette <clalance(a)redhat.com> Dan Smith <danms(a)us.ibm.com> +Dave Allan <dallan(a)redhat.com> Dave Leskovec <dlesko(a)linux.vnet.ibm.com> +Guannan Ren <gren(a)redhat.com> +Jim Meyering <meyering(a)redhat.com> +John Levon <john.levon(a)sun.com> Justin Clift <jclift(a)redhat.com> Karel Zak <kzak(a)redhat.com> +Osier Yang <jyang(a)redhat.com> Patches have also been contributed by: -- 2.1.2

3 3