- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: use a wrong name for guest panic status
by Luyao Huang 06 Jan '15

06 Jan '15

https://bugzilla.redhat.com/show_bug.cgi?id=1178652 We will get a warning when we have a guest in paused status(casue by kernel panic) and restart libvirtd, warning message like this: Qemu reported unknown VM status: 'guest-panicked' and this seems because we set a wrong status name in qemu_monitor.c, and from qemu qapi-schema.json file we know this status should named 'guest-panicked'. Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 100bbd0..57a13ab 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -127,7 +127,7 @@ VIR_ENUM_IMPL(qemuMonitorVMStatus, QEMU_MONITOR_VM_STATUS_LAST, "debug", "inmigrate", "internal-error", "io-error", "paused", "postmigrate", "prelaunch", "finish-migrate", "restore-vm", - "running", "save-vm", "shutdown", "watchdog", "guest-panic") + "running", "save-vm", "shutdown", "watchdog", "guest-panicked") typedef enum { QEMU_MONITOR_BLOCK_IO_STATUS_OK, -- 1.8.3.1

2 1

[libvirt] [PATCH] Makefile: Fix parallel build after Xen-xl parser introduction
by Michal Privoznik 06 Jan '15

06 Jan '15

Well, the parallel build doesn't work as there are not dependencies set correctly. When running 'make -j' I see this error: make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src' GEN util/virkeymaps.h GEN locking/lock_protocol.h make[2]: *** No rule to make target 'xenconfig/xen_xl_disk.h', needed by 'all'. Stop. make[2]: *** Waiting for unfinished jobs.... GEN lxc/lxc_controller_dispatch.h The fix is to correctly set dependencies by letting make know that .c and .h are to be generated from .l. Moreover, the section is moved closer to the other section which uses it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I'm not fully satisfied with this patch yet. I mean, for some reason it creates 'src/.h' file, but hey - it makes parallel build work again. Any brighter idea appreciated. src/Makefile.am | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index c6d736e..7619cf0 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1000,23 +1000,6 @@ CPU_SOURCES = \ VMX_SOURCES = \ vmx/vmx.c vmx/vmx.h -AM_LFLAGS = -Pxl_disk_ --header-file=../$*.h -LEX_OUTPUT_ROOT = lex.xl_disk_ -BUILT_SOURCES += xenconfig/xen_xl_disk.c xenconfig/xen_xl_disk.h -# Generated header file is not implicitly added to dist -EXTRA_DIST += xenconfig/xen_xl_disk.h -CLEANFILES += xenconfig/xen_xl_disk.h xenconfig/xen_xl_disk.c - -XENXLDISKPARSER_SOURCES = xenconfig/xen_xl_disk.l - -XENCONFIG_SOURCES = \ - xenconfig/xenxs_private.h \ - xenconfig/xen_common.c xenconfig/xen_common.h \ - xenconfig/xen_sxpr.c xenconfig/xen_sxpr.h \ - xenconfig/xen_xm.c xenconfig/xen_xm.h \ - xenconfig/xen_xl.c xenconfig/xen_xl.h \ - xenconfig/xen_xl_disk.h - pkgdata_DATA = cpu/cpu_map.xml EXTRA_DIST += $(pkgdata_DATA) @@ -1078,6 +1061,25 @@ libvirt_xenxldiskparser_la_CFLAGS = \ libvirt_xenxldiskparser_la_SOURCES = \ $(XENXLDISKPARSER_SOURCES) +AM_LFLAGS = -Pxl_disk_ --header-file=../$*.h +XENXLDISKPARSER_GENERATED = xenconfig/xen_xl_disk.c xenconfig/xen_xl_disk.h +BUILT_SOURCES += $(XENXLDISKPARSER_GENERATED) +EXTRA_DIST += $(XENXLDISKPARSER_GENERATED) +MAINTAINERCLEANFILES += $(XENXLDISKPARSER_GENERATED) + +XENXLDISKPARSER_SOURCES = xenconfig/xen_xl_disk.l + +$(XENXLDISKPARSER_GENERATED): $(XENXLDISKPARSER_SOURCES) + $(SHELL) $(YLWRAP) $< lex.xl_disk_.c $@ -- $(LEXCOMPILE) + +XENCONFIG_SOURCES = \ + xenconfig/xenxs_private.h \ + xenconfig/xen_common.c xenconfig/xen_common.h \ + xenconfig/xen_sxpr.c xenconfig/xen_sxpr.h \ + xenconfig/xen_xm.c xenconfig/xen_xm.h \ + xenconfig/xen_xl.c xenconfig/xen_xl.h \ + xenconfig/xen_xl_disk_i.h + noinst_LTLIBRARIES += libvirt_xenconfig.la libvirt_la_BUILT_LIBADD += libvirt_xenconfig.la libvirt_xenconfig_la_CFLAGS = \ -- 2.0.5

4 3

[libvirt] [PATCH] maint: update to latest gnulib
by Eric Blake 06 Jan '15

06 Jan '15

Another update is required to pick up today's gnulib fix for mingw builds (now that gnulib turns on mingw's replacement printf that understands %lld, it must also tell the compiler to respect the improved definition of PRIdMAX and friends). * .gnulib: Update to latest. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule. * .gnulib 498a1b6...c27f1a3 (3): > doc: update INSTALL from autoconf > stdio: fix use of PRIdMAX on modern mingw > Fix check for pthreads.h pollution on Mingw64 .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 498a1b6..c27f1a3 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 498a1b6bc7d70f944ca0f939e1bc470889fdce76 +Subproject commit c27f1a356f2f321daa7f971ef276a1dbfa873bf8 -- 2.1.0

1 0

[libvirt] [PATCH 0/2] Misc fixes
by Cédric Bosdonnat 05 Jan '15

05 Jan '15

Hi there, Here are 2 patches fixing tiny annoying problems. One of them, makes apparmor profiles handle /usr/lib64 folder and the other one fixes an uncleaned piece of domain config. Cédric Bosdonnat (2): Teach AppArmor, that /usr/lib64 may exist. Fix error when starting a container after an error examples/apparmor/libvirt-qemu | 2 +- examples/apparmor/usr.lib.libvirt.virt-aa-helper | 4 ++-- examples/apparmor/usr.sbin.libvirtd | 4 ++-- src/lxc/lxc_process.c | 1 + 4 files changed, 6 insertions(+), 5 deletions(-) -- 2.1.2

5 7

[libvirt] Query: Implementation of virNetworkGetDHCPLeases
by Nehal J Wani 05 Jan '15

05 Jan '15

In the method networkGetDHCPLeases inside ./src/network/bridge_driver.c , we have: if (need_results && mac && !leases_ret) { virReportError(VIR_ERR_INTERNAL_ERROR, _("no lease with matching MAC address: %s"), mac); goto error; } Is this really required? In my opinion, since we are already filling rv with nleases (which will be 0, in case no lease corresponding to given mac is found), user will know that there is no result for his query. Why to report error? This results in: virsh # net-dhcp-leases --mac 00:50:56:c0:00:01 default error: Failed to get leases info for default error: internal error: no lease with matching MAC address: 00:50:56:c0:00:01 -- Nehal J Wani

2 1

[libvirt] [PATCH] maint: fix date in local gnulib patch
by Daniel P. Berrange 05 Jan '15

05 Jan '15

The local gnulib ssize_t.m4.diff patch no longer applied due to changed context from the date change. --- gnulib/local/m4/ssize_t.m4.diff | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as another build breaker fix diff --git a/gnulib/local/m4/ssize_t.m4.diff b/gnulib/local/m4/ssize_t.m4.diff index 08c2b9c..12cff12 100644 --- a/gnulib/local/m4/ssize_t.m4.diff +++ b/gnulib/local/m4/ssize_t.m4.diff @@ -5,7 +5,7 @@ index 209d64c..5ea72a1 100644 @@ -1,4 +1,4 @@ -# ssize_t.m4 serial 5 (gettext-0.18.2) +# ssize_t.m4 serial 6 (gettext-0.18.2) - dnl Copyright (C) 2001-2003, 2006, 2010-2014 Free Software Foundation, Inc. + dnl Copyright (C) 2001-2003, 2006, 2010-2015 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -17,7 +17,21 @@ AC_DEFUN([gt_TYPE_SSIZE_T], -- 2.1.0

1 0

[libvirt] [PATCH] maint: update to latest gnulib
by Daniel P. Berrange 05 Jan '15

05 Jan '15

Sync to latest gnulib to get files updated with 2015 copyright date to fix syntax-check * .gnulib: update to latest * bootstrap: Regenerate from upstream Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- .gnulib | 2 +- bootstrap | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Pushed as build-breaker fix for 'make syntax-check' year check diff --git a/.gnulib b/.gnulib index 3914f31..498a1b6 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 3914f3153576e9a5ba4002bde27de05211b5a79c +Subproject commit 498a1b6bc7d70f944ca0f939e1bc470889fdce76 diff --git a/bootstrap b/bootstrap index e0c4ec2..2fdf267 100755 --- a/bootstrap +++ b/bootstrap @@ -4,7 +4,7 @@ scriptversion=2014-12-08.12; # UTC # Bootstrap this package from checked-out sources. -# Copyright (C) 2003-2014 Free Software Foundation, Inc. +# Copyright (C) 2003-2015 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by -- 2.1.0

2 1

[libvirt] libvirt memory usage statistics
by Narayanan, Krishnaprasad 05 Jan '15

05 Jan '15

Hello all, I am using libvirt version 1.1.1 on one of the nodes which has several VMs. When I used virsh dommemstat <domain UUID>, I am getting the following flags: actual, swap_in and rss. I am not able to get the unused memory that is associated with the virtual machine. Can I kindly know is there a documentation that describe the memory flags? Further, can I get help from the forum to obtain information about the unused memory associated with the virtual machine? Regards, Krishnaprasad

2 1

[libvirt] [PATCH 0/3] Fix migration to older libvirt
by Pavel Hrdina 05 Jan '15

05 Jan '15

Recently I've implemented new feature that we can set "vgamem_mb" for QXL device and also I've fixed libvirt to honor the 'vram' attribute and pass that value to QEMU process. But with this change the migration to older libvirt stopped working because QEMU silently updates the video memory size if the value is too low or there are some dependencies (for example QXL device has to have 'ram' size twice as 'vgamem'). To fix the migration we need to load the updated values from QEMU and store them into the status XML. Pavel Hrdina (3): qemu_monitor: introduce new function to get QOM path qemu_monitor: move qemuMonitorJSONObjectProperty from qemu_monitor_json qemu_process: detect updated video ram size values from QEMU src/qemu/qemu_monitor.c | 207 ++++++++++++++++++++++++++++--------------- src/qemu/qemu_monitor.h | 38 ++++++++ src/qemu/qemu_monitor_json.c | 12 +-- src/qemu/qemu_monitor_json.h | 34 +------ src/qemu/qemu_process.c | 108 ++++++++++++++++++++++ tests/qemumonitorjsontest.c | 10 +-- 6 files changed, 295 insertions(+), 114 deletions(-) -- 2.0.4

3 8

[libvirt] [PATCH] src/Makefile.am: fix build breaker for xenconfig
by Pavel Hrdina 05 Jan '15

05 Jan '15

Commit 2c78051a introduced build breaker with type in Makefile.am by specifying wrong header file. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed as build breaker. src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 8ccc273..c6d736e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1015,7 +1015,7 @@ XENCONFIG_SOURCES = \ xenconfig/xen_sxpr.c xenconfig/xen_sxpr.h \ xenconfig/xen_xm.c xenconfig/xen_xm.h \ xenconfig/xen_xl.c xenconfig/xen_xl.h \ - xenconfig/xen_xl_disk_i.h + xenconfig/xen_xl_disk.h pkgdata_DATA = cpu/cpu_map.xml -- 2.0.5

1 0