- Devel - libvirt List Archives

[libvirt] [PATCH] Fix qemu job handling in SetSchedulerParameters
by Ján Tomko 10 Feb '15

10 Feb '15

Commit c5ee5cf added a job to SetSchedulerParameters, but forgot to change one label in the SCHED_RANGE_CHECK macro. --- Not yet released. src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1614340..e3ca437 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9740,7 +9740,7 @@ qemuSetEmulatorBandwidthLive(virDomainObjPtr vm, virCgroupPtr cgroup, _("value of '%s' is out of range [%lld, %lld]"), \ NAME, MIN, MAX); \ rc = -1; \ - goto cleanup; \ + goto endjob; \ } static int -- 2.0.5

2 1

[libvirt] [PATCH 00/12] Implement random number generator hot/cold (un)plug
by Peter Krempa 10 Feb '15

10 Feb '15

Extension of Luyao's series with changes that were possible due to the prepare series for memory hotplug. Luyao Huang (7): qemu: Add helper to assign RNG device aliases qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug qemu: command: Make RNG backend device IDs unique audit: export virDomainAuditRNG conf: Add helpers to insert/remove/find RNG devices in domain def qemu: Implement random number generator hotplug qemu: Implement random number generator hotunplug Peter Krempa (5): conf: Introduce helper to find duplicate device address qemu: command: Shuffle around formatting of alias for RNG device backend qemu: command: Break some very long lines in qemuBuildRNGDevStr() qemu: command: Refactor creation of RNG device commandline qemu: Implement random number generator cold (un)plug src/conf/domain_audit.c | 2 +- src/conf/domain_audit.h | 7 + src/conf/domain_conf.c | 164 +++++++++++++++++ src/conf/domain_conf.h | 8 + src/libvirt_private.syms | 6 + src/qemu/qemu_command.c | 153 +++++++++++---- src/qemu/qemu_command.h | 9 + src/qemu/qemu_driver.c | 41 ++++- src/qemu/qemu_hotplug.c | 205 ++++++++++++++++++++- src/qemu/qemu_hotplug.h | 7 +- .../qemuxml2argv-aarch64-virt-virtio.args | 4 +- .../qemuxml2argv-arm-vexpressa9-virtio.args | 4 +- .../qemuxml2argv-arm-virt-virtio.args | 4 +- .../qemuxml2argv-s390-piix-controllers.args | 3 +- .../qemuxml2argv-s390-usb-none.args | 3 +- .../qemuxml2argv-virtio-rng-ccw.args | 4 +- .../qemuxml2argv-virtio-rng-default.args | 4 +- .../qemuxml2argv-virtio-rng-egd.args | 4 +- .../qemuxml2argv-virtio-rng-multiple.args | 8 +- .../qemuxml2argv-virtio-rng-random.args | 4 +- 20 files changed, 578 insertions(+), 66 deletions(-) -- 2.2.2

3 21

[libvirt] [PATCH] conf: disallow invalid values for video attributes
by Martin Kletzander 10 Feb '15

10 Feb '15

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1190956 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/conf/domain_conf.c | 8 ++++---- ...v-seclabel-dynamic-none.xml => qemuxml2argv-video-invalid.xml} | 4 +++- tests/qemuxml2argvtest.c | 1 + 3 files changed, 8 insertions(+), 5 deletions(-) copy tests/qemuxml2argvdata/{qemuxml2argv-seclabel-dynamic-none.xml => qemuxml2argv-video-invalid.xml} (90%) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d5b15db..77319dc 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10580,7 +10580,7 @@ virDomainVideoDefParseXML(xmlNodePtr node, _("ram attribute only supported for type of qxl")); goto error; } - if (virStrToLong_ui(ram, NULL, 10, &def->ram) < 0) { + if (virStrToLong_uip(ram, NULL, 10, &def->ram) < 0) { virReportError(VIR_ERR_XML_ERROR, _("cannot parse video ram '%s'"), ram); goto error; @@ -10590,7 +10590,7 @@ virDomainVideoDefParseXML(xmlNodePtr node, } if (vram) { - if (virStrToLong_ui(vram, NULL, 10, &def->vram) < 0) { + if (virStrToLong_uip(vram, NULL, 10, &def->vram) < 0) { virReportError(VIR_ERR_XML_ERROR, _("cannot parse video vram '%s'"), vram); goto error; @@ -10605,7 +10605,7 @@ virDomainVideoDefParseXML(xmlNodePtr node, _("vgamem attribute only supported for type of qxl")); goto error; } - if (virStrToLong_ui(vgamem, NULL, 10, &def->vgamem) < 0) { + if (virStrToLong_uip(vgamem, NULL, 10, &def->vgamem) < 0) { virReportError(VIR_ERR_XML_ERROR, _("cannot parse video vgamem '%s'"), vgamem); goto error; @@ -10613,7 +10613,7 @@ virDomainVideoDefParseXML(xmlNodePtr node, } if (heads) { - if (virStrToLong_ui(heads, NULL, 10, &def->heads) < 0) { + if (virStrToLong_uip(heads, NULL, 10, &def->heads) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("cannot parse video heads '%s'"), heads); goto error; diff --git a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-none.xml b/tests/qemuxml2argvdata/qemuxml2argv-video-invalid.xml similarity index 90% copy from tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-none.xml copy to tests/qemuxml2argvdata/qemuxml2argv-video-invalid.xml index cec59f8..e3848e1 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-none.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-video-invalid.xml @@ -22,7 +22,9 @@ <controller type='usb' index='0'/> <controller type='ide' index='0'/> <controller type='pci' index='0' model='pci-root'/> + <video> + <model type='qxl' ram='-1' vram='-1' vgamem='-1' heads='-1'/> + </video> <memballoon model='virtio'/> </devices> - <seclabel type='none' model='none'/> </domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 77ee630..f864c2a 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1362,6 +1362,7 @@ mymain(void) QEMU_CAPS_DEVICE_QXL_VGA, QEMU_CAPS_DEVICE_QXL, QEMU_CAPS_DEVICE_VIDEO_PRIMARY, QEMU_CAPS_QXL_VGA_VGAMEM, QEMU_CAPS_QXL_VGAMEM); + DO_TEST_PARSE_ERROR("video-invalid", NONE); DO_TEST("virtio-rng-default", QEMU_CAPS_DEVICE, QEMU_CAPS_DEVICE_VIRTIO_RNG, QEMU_CAPS_OBJECT_RNG_RANDOM); -- 2.3.0

2 1

[libvirt] [PATCH 0/3] attach-interface: Learn net type='direct'
by Michal Privoznik 09 Feb '15

09 Feb '15

I've just wanted to hotplug a macvtap device into a running guest. I was too lazy to write an XML, and I've found out that virsh attach-interface doesn't know how to plug macvtaps. Michal Privoznik (3): virsh attach-interface: Use enum instead of arbitrary integers virsh: Use VIR_ENUM* macros for vshCmdAttachInterface virsh attach-interface: Allow macvtap hotplug tools/virsh-domain.c | 38 ++++++++++++++++++++++++++++---------- tools/virsh.pod | 14 ++++++++------ 2 files changed, 36 insertions(+), 16 deletions(-) -- 2.0.5

5 11

[libvirt] [PATCH 0/4] parallels: Better bridged network interfaces support and some fixes
by Maxim Nestratov 09 Feb '15

09 Feb '15

Maxim Nestratov (3): parallels: Fix connecting to parallels driver parallels: better bridge network interface support parallels: don't forget to unlock domain if unregister fails Mikhail Feoktistov (1): parallels: set cpu mode when applying xml configuration

2 9

[libvirt] [RFC PATCH 00/12] Add support for memory hotplug
by Peter Krempa 09 Feb '15

09 Feb '15

!! this series applies on top of the cleanup series posted earlier !! Hi, this is my try to implement memory hotplug in libvirt (for the qemu) driver. This series is almost code-complete but is lacking tests and docs as I wanted to agree on design first before attempting to write the documentation. Additionally this series is also lacking code that would fix memballoon handling but I'm waiting on a clousure how it's supposed to work from qemu's side as it appears to be broken there too. The basic XML used to add a memory device: <memory model='acpi-dimm'> <target> <size unit='KiB'>524287</size> <node>0</node> </target> </memory> The <target> subelement is mandatory, whereas the <source> subelement (that contains source numa nodes, source page size ) is optional and is inferred from the NUMA tuning for given target numa node. Please note that at least one guest numa node has to be configured for the guest for this to work (limitation of qemu). What's missing in this series: - tests - docs - commit message touch-up - code to audit the memory size changes - code to make memory balloning working with correct size Peter Krempa (12): qemu: caps: Add capability bit for the "pc-dimm" device conf: Add support for parsing and formatting max memory and slot count qemu: Implement setup of memory hotplug parameters conf: Add device address type for dimm devices conf: Add interface to parse and format memory device information qemu: memdev: Add infrastructure to load memory device information qemu: migration: Forbid migration with memory modules lacking info qemu: add support for memory devices conf: Introduce helper to find duplicate device address qemu: conf: Add support for memory device cold(un)plug qemu: Implement memory device hotplug qemu: Implement memory device hotunplug docs/formatdomain.html.in | 19 + docs/schemas/domaincommon.rng | 76 +++ src/bhyve/bhyve_domain.c | 9 +- src/conf/domain_conf.c | 655 ++++++++++++++++++++- src/conf/domain_conf.h | 63 ++ src/libvirt_private.syms | 7 + src/libxl/libxl_domain.c | 8 + src/lxc/lxc_domain.c | 8 + src/openvz/openvz_driver.c | 14 +- src/parallels/parallels_driver.c | 6 +- src/phyp/phyp_driver.c | 6 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 157 ++++- src/qemu/qemu_command.h | 15 + src/qemu/qemu_domain.c | 58 ++ src/qemu/qemu_domain.h | 6 + src/qemu/qemu_driver.c | 29 + src/qemu/qemu_hotplug.c | 178 ++++++ src/qemu/qemu_hotplug.h | 6 + src/qemu/qemu_migration.c | 14 + src/qemu/qemu_monitor.c | 45 ++ src/qemu/qemu_monitor.h | 14 + src/qemu/qemu_monitor_json.c | 116 ++++ src/qemu/qemu_monitor_json.h | 5 + src/qemu/qemu_process.c | 4 + src/uml/uml_driver.c | 9 +- src/vbox/vbox_common.c | 6 +- src/vmware/vmware_driver.c | 6 +- src/vmx/vmx.c | 6 +- src/xen/xen_driver.c | 7 + src/xenapi/xenapi_driver.c | 9 +- tests/domainschemadata/maxMemory.xml | 19 + tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + .../qemuxml2argv-memory-hotplug-dimm.xml | 47 ++ .../qemuxml2argv-memory-hotplug-nonuma.xml | 22 + .../qemuxml2argv-memory-hotplug.args | 6 + .../qemuxml2argv-memory-hotplug.xml | 34 ++ tests/qemuxml2argvtest.c | 4 + tests/qemuxml2xmltest.c | 4 + 40 files changed, 1682 insertions(+), 19 deletions(-) create mode 100644 tests/domainschemadata/maxMemory.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nonuma.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.xml -- 2.2.2

5 33

[libvirt] [PATCH 0/2] S390: ccw support for virsh attach-disk address parameter
by Stefan Zimmermann 09 Feb '15

09 Feb '15

This patch add the ccw support for the optional address parameter of virsh attach-disk. Stefan Zimmermann (2): S390: ccw support for virsh attach-disk address parameter S390: Documentation for ccw address type docs/formatdomain.html.in | 5 ++--- tools/virsh-domain.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- tools/virsh.pod | 3 ++- 3 files changed, 49 insertions(+), 5 deletions(-) -- 2.1.4

2 4

[libvirt] [PATCH 0/6] security: Add check for invalid security models and duplicates
by Erik Skultety 09 Feb '15

09 Feb '15

Add a check for invalid security models in per-device configuration as well as a check for seclabel duplicates in per-device configuration Erik Skultety (6): security: Add check for valid security model conf: fix a minor typo conf: forbid seclabel duplicates for domain devices schema: allow multiple seclabel for devices in domaincommon.rng test: add test to check for device seclabel duplicates po: add security_stack.c into POTFILES.in docs/schemas/domaincommon.rng | 16 ++++---- po/POTFILES.in | 1 + src/conf/domain_conf.c | 11 ++++- src/security/security_manager.c | 5 +++ src/security/security_manager.h | 1 + src/security/security_stack.c | 48 +++++++++++++++++++++- .../qemuxml2argv-seclabel-device-multiple.xml | 35 ++++++++++++++++ 7 files changed, 106 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-seclabel-device-multiple.xml -- 1.9.3

3 12

[libvirt] [PATCH] Follow up fix of commit a58e1cb4
by Cédric Bosdonnat 09 Feb '15

09 Feb '15

commit a58e1cb4 didn't fix the bug if the security_default_confined is not set to 1. We now clean up even if there is no seclabel defined or the default one. --- src/lxc/lxc_process.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index b385423..19ea7f3 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -1022,6 +1022,7 @@ int virLXCProcessStart(virConnectPtr conn, virCgroupPtr selfcgroup; int status; char *pidfile = NULL; + bool clearSeclabel = false; if (virCgroupNewSelf(&selfcgroup) < 0) return -1; @@ -1126,6 +1127,10 @@ int virLXCProcessStart(virConnectPtr conn, /* If you are using a SecurityDriver with dynamic labelling, then generate a security label for isolation */ VIR_DEBUG("Generating domain security label (if required)"); + + clearSeclabel = vm->def->nseclabels == 0 || + vm->def->seclabels[0]->type == VIR_DOMAIN_SECLABEL_DEFAULT; + if (vm->def->nseclabels && vm->def->seclabels[0]->type == VIR_DOMAIN_SECLABEL_DEFAULT) vm->def->seclabels[0]->type = VIR_DOMAIN_SECLABEL_NONE; @@ -1387,7 +1392,8 @@ int virLXCProcessStart(virConnectPtr conn, virSecurityManagerReleaseLabel(driver->securityManager, vm->def); /* Clear out dynamically assigned labels */ if (vm->def->nseclabels && - vm->def->seclabels[0]->type == VIR_DOMAIN_SECLABEL_DYNAMIC) { + (vm->def->seclabels[0]->type == VIR_DOMAIN_SECLABEL_DYNAMIC || + clearSeclabel)) { VIR_FREE(vm->def->seclabels[0]->model); VIR_FREE(vm->def->seclabels[0]->label); VIR_FREE(vm->def->seclabels[0]->imagelabel); -- 2.1.4

3 2

[libvirt] ANNOUNCE: libvirt 1.2.9.2 maintenance release
by Cole Robinson 08 Feb '15

08 Feb '15

libvirt 1.2.9.2 is now available. This is a maintenance release of libvirt 1.2.9 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.2.9.2.tar.gz Changes in this version: * util: storage: Fix parsing of nbd:// URI without path * qemu: fix domain startup failing with 'strict' mode in numatune * storage: Need to clear pool prior to refreshPool during Autostart * xend: Don't crash in virDomainXMLDevID * CVE-2015-0236: qemu: Check ACLs when dumping security info from snapshots * CVE-2015-0236: qemu: Check ACLs when dumping security info from save image * conf: goto error when value of max_sectors is too large * Fix hotplugging of block device-backed usb disks * conf: fix crash when hotplug a channel chr device with no target * qemu: migration: Unlock vm on failed ACL check in protocol v2 APIs * storage: fix crash caused by no check return before set close * qemu: bulk stats: Fix logic in monitor handling * CVE-2014-8131: Fix possible deadlock and segfault in qemuConnectGetAllDomainStats() * qemu: Drop OVMF whitelist * qemu: Support OVMF on armv7l aarch64 guests For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0