- Devel - libvirt List Archives

[libvirt] [PATCH] Make ZFS storage pool XML tests optional
by Gary R Hook 16 Jan '15

16 Jan '15

From: Gary R Hook <grhookatwork(a)gmail.com> Do not run ZFS tests when ZFS is unsupported in the environment. The recent patch b4af40226d09adeaf9e33a1d6594c4e8ce7f771d adds tests to storagepoolxml2xmltest for the optional ZFS feature. When ZFS is not included in the configuration these tests should not / cannot be run. Modify Makefile.am and the test source file to check for use of the feature and compile in the tests accordingly. Signed-off-by: Gary R Hook <gary.hook(a)nimboxx.com> --- tests/Makefile.am | 4 ++++ tests/storagepoolxml2xmltest.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index e9418ea..8f8df27 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -780,6 +780,10 @@ storagepoolxml2xmltest_SOURCES = \ storagepoolxml2xmltest.c \ testutils.c testutils.h storagepoolxml2xmltest_LDADD = $(LDADDS) +storagepoolxml2xmltest_CFLAGS = $(AM_CFLAGS) +if WITH_STORAGE_ZFS +storagepoolxml2xmltest_CFLAGS += -DWITH_STORAGE_ZFS +endif nodedevxml2xmltest_SOURCES = \ nodedevxml2xmltest.c \ diff --git a/tests/storagepoolxml2xmltest.c b/tests/storagepoolxml2xmltest.c index 52e2193..270f75d 100644 --- a/tests/storagepoolxml2xmltest.c +++ b/tests/storagepoolxml2xmltest.c @@ -106,8 +106,10 @@ mymain(void) DO_TEST("pool-gluster"); DO_TEST("pool-gluster-sub"); DO_TEST("pool-scsi-type-scsi-host-stable"); +#ifdef WITH_STORAGE_ZFS DO_TEST("pool-zfs"); DO_TEST("pool-zfs-sourcedev"); +#endif return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 1.9.1

2 4

[libvirt] [PATCHv2] Coverity fix: properly check for 0 ipv6 address.
by Cédric Bosdonnat 16 Jan '15

16 Jan '15

--- src/util/virsocketaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 91bcadf..67ed330 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -850,7 +850,7 @@ virSocketAddrGetIpPrefix(const virSocketAddr *address, } return -1; } else if (VIR_SOCKET_ADDR_IS_FAMILY(address, AF_INET6)) { - if (address->data.inet6.sin6_addr.s6_addr == 0) + if (virSocketAddrIsWildcard(address)) return 0; return 64; } -- 2.1.2

3 2

[libvirt] [PATCH v3 0/3] Add schema validation for domain XML
by Daniel P. Berrange 16 Jan '15

16 Jan '15

A followup to https://www.redhat.com/archives/libvir-list/2015-January/msg00203.html In this posting, the 3 remaining patches only are posted: - Catch errors parsing RNG schema - Use virFileFindResource for findning RNG - Don't enable validation by default in virsh define/create - Other misc typos Daniel P. Berrange (3): Add virXMLValidateAgainstSchema helper method Add support for schema validation when passing in XML virsh: add support for domain XML validation include/libvirt/libvirt-domain.h | 5 +++ include/libvirt/virterror.h | 1 + src/bhyve/bhyve_driver.c | 16 ++++++-- src/conf/domain_conf.c | 11 +++++ src/conf/domain_conf.h | 1 + src/esx/esx_driver.c | 8 +++- src/internal.h | 4 ++ src/libvirt-domain.c | 2 +- src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 17 ++++++-- src/lxc/lxc_driver.c | 18 +++++++-- src/openvz/openvz_driver.c | 16 ++++++-- src/parallels/parallels_driver.c | 8 +++- src/phyp/phyp_driver.c | 8 +++- src/qemu/qemu_driver.c | 16 ++++++-- src/test/test_driver.c | 16 ++++++-- src/uml/uml_driver.c | 17 ++++++-- src/util/virerror.c | 6 +++ src/util/virxml.c | 79 ++++++++++++++++++++++++++++++++++++ src/util/virxml.h | 5 +++ src/vbox/vbox_common.c | 8 +++- src/vmware/vmware_driver.c | 16 ++++++-- src/xen/xen_driver.c | 16 ++++++-- src/xenapi/xenapi_driver.c | 17 ++++++-- tools/virsh-domain.c | 87 +++++++++++++++++++++++++++++++++++----- 25 files changed, 341 insertions(+), 58 deletions(-) -- 2.1.0

3 11

[libvirt] [PATCHv2 0/7] Sharing code for domain and network routes
by Cédric Bosdonnat 16 Jan '15

16 Jan '15

Hi guys, Here are a few patches to have common route definitions for domains and networks. What has changed since v1: * Split into several patches for backportability as suggested by Laine * Moved the virNetworkRouteDef struct definition in the c file to make sure all routes are created with the virNetworkRouteDefCreate (or Parse) function. This way we can get rid of the redundant checks in the format function. * Moved the prefix computing code into a new virNetworkRouteDefGetPrefix function. * Applied and tweaked John's patches. * Fix the virSocketAddrGetIpPrefix 0.0.0.0 special case as suggested by Laine. Cédric Bosdonnat (5): Fix ipv6 regex in RNG schemas to match '::' Move network route definition to networkcommon.rng Move code related to network routes to networkcommon_conf.[ch] Use the network route definitions for domains virSocketAddrGetIpPrefix 0.0.0.0 special case John Ferlan (2): domain_conf: Resolve Coverity RESOURCE_LEAK domain_conf: Check errors from virSocketAddrFormat docs/formatdomain.html.in | 9 +- docs/schemas/basictypes.rng | 2 +- docs/schemas/domaincommon.rng | 29 +- docs/schemas/network.rng | 20 +- docs/schemas/networkcommon.rng | 22 ++ po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/conf/domain_conf.c | 136 ++----- src/conf/domain_conf.h | 14 +- src/conf/network_conf.c | 297 +--------------- src/conf/network_conf.h | 22 +- src/conf/networkcommon_conf.c | 414 ++++++++++++++++++++++ src/conf/networkcommon_conf.h | 72 ++++ src/libvirt_private.syms | 11 + src/lxc/lxc_container.c | 22 +- src/lxc/lxc_native.c | 20 +- src/network/bridge_driver.c | 44 +-- src/util/virsocketaddr.c | 6 + tests/lxcconf2xmldata/lxcconf2xml-physnetwork.xml | 4 +- tests/lxcconf2xmldata/lxcconf2xml-simple.xml | 4 +- tests/lxcxml2xmldata/lxc-hostdev.xml | 4 +- tests/lxcxml2xmldata/lxc-idmap.xml | 4 +- 22 files changed, 633 insertions(+), 527 deletions(-) create mode 100644 src/conf/networkcommon_conf.c create mode 100644 src/conf/networkcommon_conf.h -- 2.1.2

5 25

[libvirt] [PATCHv3 0/3] Fix vmdef usage after ExitMonitor
by Ján Tomko 16 Jan '15

16 Jan '15

The patches 1-2, 6-8 from v2 have been pushed already Device removal and device detach are now squashed together. Both attach and detach skip audit when the domain crashed. (Left to be cleaned up by a separate series) Patches checking the return value in all other non-fatal cases were squashed together with the patch adding ATTRIBUTE_RETURN_CHECK. Rebased to master, added qemuProcessUpdateVideoRamSize, and fixed numerous wrong return values and a few missing EndJobs. Ján Tomko (3): Fix vmdef usage after domain crash in monitor on device detach Fix vmdef usage after domain crash in monitor on device attach Always check return value of qemuDomainObjExitMonitor src/qemu/qemu_domain.c | 11 +-- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 166 ++++++++++++++++++++++--------------- src/qemu/qemu_hotplug.c | 202 ++++++++++++++++++++++++++++++---------------- src/qemu/qemu_hotplug.h | 6 +- src/qemu/qemu_migration.c | 139 ++++++++++++++++--------------- src/qemu/qemu_process.c | 115 +++++++++++++------------- 7 files changed, 373 insertions(+), 269 deletions(-) -- 2.0.4

2 5

[libvirt] [PATCH] ipv6 check for :: address
by Cédric Bosdonnat 16 Jan '15

16 Jan '15

Hi John, Here is a possible fix for the coverity issue you mentioned. Since ipv6 addresses are too big to be converted to a single integer, I just looped over the array... not sure that is the most elegant way to do it. Cédric Bosdonnat (1): Coverity fix: properly check for 0 ipv6 address. src/util/virsocketaddr.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.1.2

2 2

[libvirt] [PATCH v2 0/5] parallels: manage container's filesystems
by Dmitry Guryanov 16 Jan '15

16 Jan '15

This patch series adds ability to manage container's filesystems: you can add or remove fs from existing container or create new one, based on existing disk image. Dmitry Guryanov (5): add ploop fs driver type parallels: dump info about container filesystems parallels: commit with PVCF_DETACH_HDD_BUNDLE flag parallels: allow to add filesystems to container parallels: create container from existing image docs/formatdomain.html.in | 3 +- docs/schemas/domaincommon.rng | 1 + docs/schemas/storagecommon.rng | 1 + src/conf/domain_conf.c | 3 +- src/conf/domain_conf.h | 1 + src/parallels/parallels_sdk.c | 209 +++++++++++++++++++-- src/qemu/qemu_command.c | 1 + .../domain-parallels-ct-simple.xml | 5 + 8 files changed, 206 insertions(+), 18 deletions(-) -- 2.1.0

2 9

[libvirt] [PATCH 0/3] Fix adding PCI bridge controller to extend default PCI bus
by Erik Skultety 16 Jan '15

16 Jan '15

Erik Skultety (3): qemu: Tweak auto adding PCI bridge controller when extending default PCI bus qemu: qemuDomainAssignPCIAddresses fix dead code qemu: Add XML test for too many PCI devices on default PCI bus src/qemu/qemu_command.c | 26 ++- tests/qemuxml2argvdata/qemuxml2argv-pci-many.args | 63 +++++++ tests/qemuxml2argvdata/qemuxml2argv-pci-many.xml | 214 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 2 + 4 files changed, 301 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-many.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-many.xml -- 1.9.3

3 7

[libvirt] [PATCH] network: Resolve Coverity FORWARD_NULL
by John Ferlan 16 Jan '15

16 Jan '15

Commit id 'ca481a6f' added virNetworkRouteDefFree which may be called in an error path from lxcAddNetworkRouteDefinition with 'route = NULL'. So just add the (!def) at the top to resolve. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/conf/networkcommon_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/networkcommon_conf.c b/src/conf/networkcommon_conf.c index 3f0896d..7b7a851 100644 --- a/src/conf/networkcommon_conf.c +++ b/src/conf/networkcommon_conf.c @@ -52,6 +52,8 @@ struct _virNetworkRouteDef { void virNetworkRouteDefFree(virNetworkRouteDefPtr def) { + if (!def) + return; VIR_FREE(def->family); VIR_FREE(def); } -- 2.1.0

2 1

[libvirt] [PATCH 0/2] qemu: Add support for PMU feature
by Martin Kletzander 16 Jan '15

16 Jan '15

This is based on top of: https://www.redhat.com/archives/libvir-list/2015-January/msg00307.html Martin Kletzander (2): docs, schema, conf: Add support for PMU feature qemu: Add support for enabling/disabling PMU docs/formatdomain.html.in | 6 ++++++ docs/schemas/domaincommon.rng | 11 ++++++++++ src/conf/domain_conf.c | 8 +++++-- src/conf/domain_conf.h | 3 ++- src/qemu/qemu_command.c | 12 ++++++++++- .../qemuxml2argv-pmu-feature-off.args | 5 +++++ .../qemuxml2argv-pmu-feature-off.xml | 25 ++++++++++++++++++++++ .../qemuxml2argvdata/qemuxml2argv-pmu-feature.args | 5 +++++ .../qemuxml2argvdata/qemuxml2argv-pmu-feature.xml | 25 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 3 +++ .../qemuxml2xmlout-pmu-feature.xml | 25 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 3 +++ 12 files changed, 127 insertions(+), 4 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pmu-feature-off.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pmu-feature-off.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pmu-feature.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pmu-feature.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pmu-feature.xml -- 2.2.1

2 3