- Devel - libvirt List Archives

[libvirt] cloud-init integration
by Tobias Florek 19 Jun '15

19 Jun '15

Hi, if that has been discussed before, please point me to it. I have not been able to find anything about it. It would be great to easily generate and cd-attach cloud-init isos when starting a vm. The config files could be taken from the file system (e.g. %sysconfdir/cloud-init/host-name) and put into an iso. when the host stops the generated iso should be removed. What do you think? If that's a worthwhile cause, I would be glad to start to implement it, if pointers are given. My C i a little rusty unfortunately. Thank you for your consideration, Tobias Florek

3 2

[libvirt] Socket files in virt-aa-helper
by Michał Dubiel 19 Jun '15

19 Jun '15

Hi guys, I have got a question. I need to add apparmor support for vhost-user socket files used to communicate with the vhost-user server app. Those ones defined with something like: <interface type='vhostuser'> <mac address='02:ed:f3:5d:de:f3'/> <source type='unix' path='/var/run/vrouter/uvh_vif_tapa8396c51-2a' mode='client'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> I added something like this into get_files() function in virt-aa-helper.c: for (i = 0; i < ctl->def->nnets; i++) { if (ctl->def->nets[i] && ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER && ctl->def->nets[i]->data.vhostuser) { virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser; if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw", vhu->type) != 0) goto cleanup; } } However, there is a restriction for the socket file types in valid_path() function: switch (sb.st_mode & S_IFMT) { case S_IFSOCK: return 1; break; default: break; } That prevents this from working. May I ask why the socket file types are restricted? Vhost-user uses sockets so if I want to use apparmor virt-aa-helper has to be able to add the line for the socket file into /etc/apparmor.d/libvirt/libvirt-UUID.files. Regards, Michal

3 5

[libvirt] [PATCH 0/4] A cople of memleak fixes
by Michal Privoznik 19 Jun '15

19 Jun '15

One thing that I still haven't figured out is, when the daemon is waiting in the even loop, in poll() and SIGINT comes, it jumps out and cleanup phase begins. However, the event loop may still be the one and only holding a reference to some objects, so we kind of want it to at least remove stale handlers. Well, they will be deleted after the cleanup work in the daemon is done. Yeah, messy and probably not worth breaking up the code into smaller pieces just to cleanup deleted handles. Michal Privoznik (4): daemonSetupNetworking: Don't leak services virNetSocketRemoveIOCallback: Be explicit about unref virNetSocket: Fix @watch corner case virNetServerServiceClose: Don't leak sockets daemon/libvirtd.c | 47 ++++++++++++++++++++++--------------------- src/rpc/virnetserverservice.c | 5 ++++- src/rpc/virnetsocket.c | 11 ++++++---- 3 files changed, 35 insertions(+), 28 deletions(-) -- 2.3.6

2 6

[libvirt] [v1.2.9-maint] Teach virt-aa-helper to use TEMPLATE.qemu if the domain is kvm or kqemu
by Guido Günther 19 Jun '15

19 Jun '15

(cherry picked from commit 16d2bc8b98563f801f111795250515fcbd39ab46) --- Succesfully tested on Debian at: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786652 src/security/virt-aa-helper.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 9afc8db..1f299a0 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -341,15 +341,25 @@ create_profile(const char *profile, const char *profile_name, int tlen, plen; int fd; int rc = -1; + const char *driver_name = NULL; if (virFileExists(profile)) { vah_error(NULL, 0, _("profile exists")); goto end; } + switch (virtType) { + case VIR_DOMAIN_VIRT_QEMU: + case VIR_DOMAIN_VIRT_KQEMU: + case VIR_DOMAIN_VIRT_KVM: + driver_name = "qemu"; + break; + default: + driver_name = virDomainVirtTypeToString(virtType); + } if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt", - virDomainVirtTypeToString(virtType)) < 0) { + driver_name) < 0) { vah_error(NULL, 0, _("template name exceeds maximum length")); goto end; } -- 2.1.4

2 2

[libvirt] [PATCH v3 0/9] Selective block device migration implementation
by Michal Privoznik 18 Jun '15

18 Jun '15

I've taken Pavel's patches, reworked them a bit, added something and sending v3. The original patches can be found here: https://www.redhat.com/archives/libvir-list/2015-May/msg00697.html Michal Privoznik (3): virDomainDiskGetSource: Mark passed disk as 'const' qemuMigrationBeginPhase: Fix function header indentation qemuMigrationDriveMirror: Pass disk format to qemu Pavel Boldin (6): util: multi-value virTypedParameter util: multi-value parameters in virTypedParamsAdd* util: virTypedParams{Filter,PickStrings} util: add virTypedParamsAddStringList qemu: migration: selective block device migration virsh: selective block device migration include/libvirt/libvirt-domain.h | 9 ++ include/libvirt/libvirt-host.h | 17 +++ src/conf/domain_conf.c | 2 +- src/conf/domain_conf.h | 2 +- src/libvirt_public.syms | 3 + src/qemu/qemu_driver.c | 72 +++++++--- src/qemu/qemu_migration.c | 267 +++++++++++++++++++++++++---------- src/qemu/qemu_migration.h | 24 ++-- src/util/virtypedparam.c | 269 ++++++++++++++++++++++++++++------- src/util/virtypedparam.h | 10 ++ tests/Makefile.am | 6 + tests/virtypedparamtest.c | 294 +++++++++++++++++++++++++++++++++++++++ tools/virsh-domain.c | 23 +++ tools/virsh.pod | 21 +-- 14 files changed, 854 insertions(+), 165 deletions(-) create mode 100644 tests/virtypedparamtest.c -- 2.3.6

7 45

[libvirt] [PATCH 0/2] Two trivial fixes
by Peter Krempa 18 Jun '15

18 Jun '15

Both are now pushed. Peter Krempa (2): qemu: Jump to correct label in qemuDomainPinIOThread qemu: Fix double space in error message in qemuDomainGetVcpusFlags src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.4.1

1 2

[libvirt] [PATCH 00/13] vCPU pinning and related refactors - Part 1.5
by Peter Krempa 18 Jun '15

18 Jun '15

Few more fixes to the Part 1 and related stuff. This is a continuation and fix to stuff done in Part 1. Peter Krempa (13): conf: Fix virDomainObjGetDefs when getting persistent config on a live vm conf: Introduce helper to help getting correct def for getter functions qemu: Simplify qemuDomainGetInterfaceParameters by using virDomainObjGetOneDef qemu: Simplify qemuDomainGetNumaParameters by using virDomainObjGetOneDef qemu: Simplify qemuDomainGetVcpuPinInfo by using virDomainObjGetOneDef qemu: Simplify qemuDomainGetEmulatorPinInfo by using virDomainObjGetOneDef qemu: Simplify qemuDomainGetVcpusFlags by using virDomainObjGetOneDef qemu: Simplify qemuDomainSetInterfaceParameters by using virDomainObjGetDefs qemu: Refactor qemuDomainSetNumaParameters qemu: Refactor qemuDomainGetMemoryParameters qemu: Reuse virDomainObjGetDefs in qemuDomainGetMemoryParameters qemu: 'privileged' flag is not really configuration conf: Move vcpu info parsing code into a separate function src/conf/domain_conf.c | 174 ++++++++++++++++--------- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_cgroup.c | 13 +- src/qemu/qemu_command.c | 9 +- src/qemu/qemu_conf.c | 7 +- src/qemu/qemu_conf.h | 5 +- src/qemu/qemu_domain.c | 4 +- src/qemu/qemu_driver.c | 332 ++++++++++++++--------------------------------- tests/qemuxml2argvtest.c | 4 +- 10 files changed, 241 insertions(+), 309 deletions(-) -- 2.4.1

2 20

Re: [libvirt] [Qemu-block] [Qemu-devel] [PATCH v7 00/11] Support streaming to an intermediate layer
by Eric Blake 18 Jun '15

18 Jun '15

[adding libvirt, to make sure I capture a design idea] On 06/18/2015 06:36 AM, Eric Blake wrote: > On 06/18/2015 06:07 AM, Alberto Garcia wrote: >> On Thu 18 Jun 2015 01:47:20 PM CEST, Kevin Wolf wrote: >> >>>>> I believe our conclusion from an earlier version of the series was >>>>> that we need QAPI introspection so that libvirt can detect the >>>>> presence of the feature. > > Detecting the presence of a feature allows libvirt the luxury of giving > its own error message, rather than relying on the qemu message. But > that's not to say libvirt HAS to use its own error message, and > therefore being unable to detect the feature may not be the end of the > world. > >> That said, I would prefer a way to detect the feature that does not >> involve testing commands for their error codes, but is there any? What >> does libvirt generally do in order to detect new features that don't >> depend on API changes? > > But libvirt has not yet set up node name management (I'm about to revive > Jeff's patch for auto-node-naming simultaneously with a libvirt patch > series that proves that it helps libvirt), and libvirt will need a new > API to allow users a way to request streams to an intermediate image. > So anything libvirt does to interact with the new stream-to-intermediate > will have to be new code, and I can worry about whether the qemu error > message is good enough, or whether I have to contrive some probing test > to see if it even works; but my initial thought is that merely probing > to see if auto-node-naming is in place is a good approximation filter > (if libvirt isn't managing its own node names, then the only way to use > stream-to-intermediate is via a node name automatically supplied by > qemu, especially nice if both features land in 2.4). Actually, in thinking more about it, libvirt won't need a new API; the existing virDomainBlockPull() and virDomainBlockRebase() are sufficient, if I allow libvirt to treat "vda[1]" as a destination (which is the first backing image of disk vda; pretty much similar to how qemu is adding node names rather than device names as a way to make the existing block-stream now stream to intermediate). And that is consistent with the way we have been retrofitting other existing libvirt API to refer to specific backing images. On libvirt's front, I may want to add a new flag (where the flag must be present to make it clear that stream-to-intermediate is desired, so that upper level applications can use the absence of the libvirt flag as their feature probe), but that has no bearing on what qemu has to do to turn on the feature. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

1 0

[libvirt] [PATCH] qemu: implement address for isa-serial
by James Cowgill 18 Jun '15

18 Jun '15

I needed to specify the iobase address for certain exotic mips configurations. Signed-off-by: James Cowgill <james410(a)cowgill.org.uk> --- src/qemu/qemu_command.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 61faa57..e1d53c2 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2693,6 +2693,10 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, info->addr.ccw.cssid, info->addr.ccw.ssid, info->addr.ccw.devno); + } else if (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_ISA) { + virBufferAsprintf(buf, ",iobase=0x%x,irq=0x%x", + info->addr.isa.iobase, + info->addr.isa.irq); } ret = 0; @@ -10950,11 +10954,15 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, break; case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_ISA: - if (serial->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { + if (serial->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && + serial->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_ISA) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("no addresses are supported for isa-serial")); + _("isa-serial requires address of isa type")); goto error; } + + if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0) + goto error; break; case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PCI: -- 2.1.4

2 3

[libvirt] [PATCH 0/2] Yet again a admin API fixup series.
by Peter Krempa 18 Jun '15

18 Jun '15

Fluffy bunny ears of shame will be administered to Martin. Peter Krempa (2): rpc: Actually increase reference count on @srv in virNetDaemonAddServer daemon: Add the admin service to the admin server only if it was allocated daemon/libvirtd.c | 6 +++--- src/rpc/virnetdaemon.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.4.1

2 4