- Devel - libvirt List Archives

[libvirt] [PATCH] migration: remove direct migration dependency on version1 of driver
by Nikolay Shirokovskiy 31 Aug '15

31 Aug '15

From: Nikolay Shirokovskiy <Nikolay Shirokovskiy nshirokovskiy(a)virtuozzo.com> Direct migration should work if *perform3 is present but *perform is not. This is situation when driver migration is implemented after new version of driver function is introduced. We should not be forced to support old version too as its parameter space is subspace of newer one. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/libvirt-domain.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6ab50ba..c89775b 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3427,7 +3427,8 @@ virDomainMigrateDirect(virDomainPtr domain, NULLSTR(xmlin), flags, NULLSTR(dname), NULLSTR(dconnuri), NULLSTR(miguri), bandwidth); - if (!domain->conn->driver->domainMigratePerform) { + if (!domain->conn->driver->domainMigratePerform && + !domain->conn->driver->domainMigratePerform3) { virReportUnsupportedError(); return -1; } -- 1.7.1

3 6

[libvirt] Entering freeze for libvirt-1.2.19
by Daniel Veillard 31 Aug '15

31 Aug '15

So I have tagged rc1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ The release works just fine in my limited testing, but others should try it out to check portability and more advanced functionalities. I will likely push rc2 at the end of the week-end and the final release on Tuesday or Wednesday, assuming no big issue is raised in the meantime. thanks for giving it a try. I also note that we have some CI test failing, not for core libvirt but perl bindings, virt-manager, ... it would be good to investigate before we push the release: https://ci.centos.org/view/libvirt-project/ thanks ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

4 5

[libvirt] [libvirt-test-api][PATCH] Add new test case for allocPages API
by Luyao Huang 31 Aug '15

31 Aug '15

Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- cases/test_connection.conf | 4 ++ repos/virconn/connection_allocPages.py | 88 ++++++++++++++++++++++++++++++++++ 2 files changed, 92 insertions(+) create mode 100644 repos/virconn/connection_allocPages.py diff --git a/cases/test_connection.conf b/cases/test_connection.conf index 336b1ad..600ec32 100644 --- a/cases/test_connection.conf +++ b/cases/test_connection.conf @@ -77,3 +77,7 @@ virconn:connection_getMemoryParameters virconn:connection_getMemoryStats conn qemu:///system + +virconn:connection_allocPages + conn + qemu:///system diff --git a/repos/virconn/connection_allocPages.py b/repos/virconn/connection_allocPages.py new file mode 100644 index 0000000..9ddd474 --- /dev/null +++ b/repos/virconn/connection_allocPages.py @@ -0,0 +1,88 @@ +#!/usr/bin/env python + +import libvirt +from libvirt import libvirtError +import lxml +import lxml.etree + +required_params = () +optional_params = {'conn': ''} + +HOST_HUGEPAGE = '/sys/devices/system/node/node%d/hugepages/hugepages-%dkB/nr_hugepages' + +def get_host_pagesize(conn): + ret = [] + tree = lxml.etree.fromstring(conn.getCapabilities()) + + set = tree.xpath("/capabilities/host/cpu/pages") + for n in set: + ret.append(int(n.attrib['size'])) + + return ret + +def get_host_pagecount(pagesize): + try: + return int(open(HOST_HUGEPAGE % (0, pagesize)).read()) + except IOError: + return -1 + +def connection_allocPages(params): + """ + test API for allocPages in class virConnect + """ + logger = params['logger'] + fail=0 + + try: + conn=libvirt.open(params['conn']) + logger.info("get connection to libvirtd") + list1 = get_host_pagesize(conn) + + except libvirtError, e: + logger.error("API error message: %s" % e.message) + return 1 + + for i in list1: + logger.info("test hugepage size %d" % i) + + if get_host_pagecount(i) == -1: + logger.info("Skip system page size %d" % i) + continue + + """ test flag VIR_NODE_ALLOC_PAGES_SET """ + try: + cur_count = get_host_pagecount(i) + conn.allocPages({i : cur_count + 1}, 0, 1, libvirt.VIR_NODE_ALLOC_PAGES_SET) + if get_host_pagecount(i) != cur_count + 1: + logger.info("libvirt set a wrong page count to %dKiB hugepage" % i) + fail = 1 + except libvirtError, e: + if "Allocated only" in e.message: + tmp_count = int(e.message.replace(" ", "")[-1:]) + + if tmp_count != get_host_pagecount(i): + logger.info("libvirt output %dKiB hugepage count is not right" % i) + fail = 1 + else: + logger.error("API error message: %s" % e.message) + return 1 + + """ test flag VIR_NODE_ALLOC_PAGES_ADD """ + try: + cur_count = get_host_pagecount(i) + conn.allocPages({i : 1}, 0, 1, libvirt.VIR_NODE_ALLOC_PAGES_ADD) + if get_host_pagecount(i) != cur_count + 1: + logger.info("libvirt set a wrong page count to %dKiB hugepage" % i) + fail = 1 + except libvirtError, e: + if "Allocated only" in e.message: + tmp_count = int(e.message.replace(" ", "")[-1:]) + + if tmp_count != get_host_pagecount(i): + logger.info("libvirt output %dKiB hugepage count is not right" % i) + fail = 1 + else: + logger.error("API error message: %s" % e.message) + return 1 + + return fail -- 1.8.3.1

2 1

[libvirt] [libvirt-test-api][PATCH 1/3] Introduce new test case for add/del IOthread
by Luyao Huang 31 Aug '15

31 Aug '15

Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- cases/linux_domain.conf | 6 +++ repos/domain/add_del_iothread.py | 82 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 88 insertions(+) create mode 100644 repos/domain/add_del_iothread.py diff --git a/cases/linux_domain.conf b/cases/linux_domain.conf index fd32aad..8a7efe9 100644 --- a/cases/linux_domain.conf +++ b/cases/linux_domain.conf @@ -281,6 +281,12 @@ domain:set_memory_period conn qemu:///system +domain:add_del_iothread + guestname + $defaultname + conn + qemu:///system + domain:destroy guestname $defaultname diff --git a/repos/domain/add_del_iothread.py b/repos/domain/add_del_iothread.py new file mode 100644 index 0000000..2d874f9 --- /dev/null +++ b/repos/domain/add_del_iothread.py @@ -0,0 +1,82 @@ +#!/usr/bin/env python + +import libvirt +from libvirt import libvirtError +import lxml +import lxml.etree + +required_params = ('guestname',) +optional_params = {'conn': 'qemu:///system'} + +def find_iothreadid_fromxml(vm, running, iothreadid): + if (running == 1): + tree = lxml.etree.fromstring(vm.XMLDesc(0)) + else: + tree = lxml.etree.fromstring(vm.XMLDesc(libvirt.VIR_DOMAIN_XML_INACTIVE)) + + set = tree.xpath("//iothreadids/iothread") + for n in set: + ids = n.attrib['id'] + if int(ids) == iothreadid: + return True + + return False + +def add_del_iothread(params): + """ + test API for addIOThread and delIOThread in class virDomain + """ + + logger = params['logger'] + fail=0 + + try: + conn = libvirt.open(params['conn']) + + logger.info("get connection to libvirtd") + guest = params['guestname'] + vm = conn.lookupByName(guest) + logger.info("test guest name: %s" % guest) + + """ test effect guest running XML """ + if vm.isActive() == 1: + logger.info("guest is running test with running guest") + + for i in range(300, 1000): + if not find_iothreadid_fromxml(vm, 1, i): + logger.info("add iothread %d to running guest" % i) + vm.addIOThread(i, libvirt.VIR_DOMAIN_AFFECT_LIVE) + if find_iothreadid_fromxml(vm, 1, i): + vm.delIOThread(i, libvirt.VIR_DOMAIN_AFFECT_LIVE) + if find_iothreadid_fromxml(vm, 1, i): + logger.info("FAIL: still can find iothread id in XML") + fail=1 + + break + else: + logger.info("FAIL: cannot find iothread id in XML") + fail=1 + break + + """ test effect guest config""" + logger.info("test with guest inactive XML") + for i in range(300, 1000): + if not find_iothreadid_fromxml(vm, 0, i): + logger.info("add iothread %d to guest config" % i) + vm.addIOThread(i, libvirt.VIR_DOMAIN_AFFECT_CONFIG) + if find_iothreadid_fromxml(vm, 0, i): + vm.delIOThread(i, libvirt.VIR_DOMAIN_AFFECT_CONFIG) + if find_iothreadid_fromxml(vm, 0, i): + logger.info("FAIL: still can find iothread id in XML") + fail=1 + + break + else: + logger.info("FAIL: cannot find iothread id in XML") + fail=1 + break + + except libvirtError, e: + logger.error("API error message: %s" % e.message) + fail=1 + return fail -- 1.8.3.1

2 3

[libvirt] [PATCH] apparmor: Adjust path to domain monitor socket
by Guido Günther 30 Aug '15

30 Aug '15

f1f68ca33 moved the monitor socket to a per domain directory. Adjust the path accordingly. --- It'd be nice to have this in 1.2.19 since it unbreaks starting qemu based domains. src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index b4a8f27..5de56e5 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1361,7 +1361,7 @@ main(int argc, char **argv) ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) { virBufferAsprintf(&buf, " \"%s/log/libvirt/**/%s.log\" w,\n", LOCALSTATEDIR, ctl->def->name); - virBufferAsprintf(&buf, " \"%s/lib/libvirt/**/%s.monitor\" rw,\n", + virBufferAsprintf(&buf, " \"%s/lib/libvirt/qemu/domain-%s/monitor.sock\" rw,\n", LOCALSTATEDIR, ctl->def->name); virBufferAsprintf(&buf, " \"%s/run/libvirt/**/%s.pid\" rwk,\n", LOCALSTATEDIR, ctl->def->name); -- 2.1.4

2 2

[libvirt] Please give me a wiki account
by Ian Kelling 29 Aug '15

29 Aug '15

I saw a page I'd like to improve a bit. wiki username IanKelling. - Ian Kelling

2 2

[libvirt] libvirt 1.2.19-rc1 can't configure
by Vasiliy Tolstov 29 Aug '15

29 Aug '15

I'm try to configure libvirt 1.2.19-rc1 but get strange error. configure ended with: checking whether <pthread.h> pollutes the namespace... no checking for pthread_t... yes checking for pthread_spinlock_t... yes checking for library containing pthread_create and pthread_join... -pthread checking for pthread_sigmask in -pthread... yes checking whether pthread_sigmask is only a macro... no complete log: https://gist.github.com/raw/f8dc44de0ed7b0675755 -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

2 3

[libvirt] [PATCH] Revert "LXC: show used memory as 0 when domain is not active"
by Jim Fehlig 28 Aug '15

28 Aug '15

This reverts commit 1ce7c1d20cfd5afb26d2dbc88201085d52415d0e, which introduced a significant semantic change to the virDomainGetInfo() API. Additionally, the change was only made to 2 of the 15 virt drivers. Conflicts: src/qemu/qemu_driver.c Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/lxc/lxc_driver.c | 2 +- src/qemu/qemu_driver.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index d8d5119..5b0a757 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -597,7 +597,7 @@ static int lxcDomainGetInfo(virDomainPtr dom, if (!virDomainObjIsActive(vm)) { info->cpuTime = 0; - info->memory = 0; + info->memory = vm->def->mem.cur_balloon; } else { if (virCgroupGetCpuacctUsage(priv->cgroup, &(info->cpuTime)) < 0) { virReportError(VIR_ERR_OPERATION_FAILED, diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6998e12..48cc534 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2641,13 +2641,13 @@ qemuDomainGetInfo(virDomainPtr dom, goto cleanup; } - if (virDomainObjIsActive(vm)) { - if (VIR_ASSIGN_IS_OVERFLOW(info->memory, vm->def->mem.cur_balloon)) { - virReportError(VIR_ERR_OVERFLOW, "%s", - _("Current memory size too large")); - goto cleanup; - } + if (VIR_ASSIGN_IS_OVERFLOW(info->memory, vm->def->mem.cur_balloon)) { + virReportError(VIR_ERR_OVERFLOW, "%s", + _("Current memory size too large")); + goto cleanup; + } + if (virDomainObjIsActive(vm)) { if (qemuGetProcessInfo(&(info->cpuTime), NULL, NULL, vm->pid, 0) < 0) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("cannot read cputime for domain")); -- 2.1.4

4 7

[libvirt] [PATCH] network type ethernet not needs to be reconnected
by Vasiliy Tolstov 28 Aug '15

28 Aug '15

libvirt docs says that network type ethernet not fully managed by libvirt, so don't check for ip. This fixes issue when no ip assigned to interface in libvirt domain xml and somebody want to change link state of interface. Signed-off-by: Vasiliy Tolstov <v.tolstov(a)selfip.ru> --- src/qemu/qemu_hotplug.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index aabdb78..db4fdda 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2394,10 +2394,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, case VIR_DOMAIN_NET_TYPE_ETHERNET: if (STRNEQ_NULLABLE(olddev->data.ethernet.dev, - newdev->data.ethernet.dev) || - olddev->nips == 0 || newdev->nips == 0 || - !virSocketAddrEqual(&olddev->ips[0]->address, - &newdev->ips[0]->address)) { + newdev->data.ethernet.dev)) { needReconnect = true; } break; -- 2.5.0

2 6

[libvirt] Should external snapshots be possible with type volume image files?
by Stefan Bader 28 Aug '15

28 Aug '15

At least up to libvirt version 1.2.16 an external snapshot fails when the image file (supported type like QCOW2) is not specified as type='file' by as type='volume' to a pool that consists of image files (type directory). The reason there is that the source element of the disk definition does not contain the full path but only references to pool and volume name. Which would require an additional indirection in order to find that it actually is a file and what the path is. And that would make things more complicated. So my question is whether this should work and needs fixing in code or was never meant to be used that way. If the latter, then maybe needs a clarification in the documentation. At least the wiki did read for me as only requiring to be a image file of a supported type. And we got at least one bug report about it. Thanks, Stefan

1 0