- Devel - libvirt List Archives

[libvirt] [PATCH v2 0/4] Fix a couple of iothread bugs
by John Ferlan 16 Oct '15

16 Oct '15

v1: http://www.redhat.com/archives/libvir-list/2015-October/msg00417.html Differences since v1 - many. - Reworked patches 1 & 2 to become patches 1 - 3 in the new series - Patch 1 is new, but the thinking behind patch 3 caused me to generate this patch which essentially changes comparisons with "->iothreads" to use "->niothreadids" instead except for one place where we're building the "iothreadids[]" array based on the difference between iothreads and niothreadids. - Patch 2 is essentially what former patch 1 became, adding a single check for niothreads == 0 rather than checking the capabilities bit. - The former patch 2 was dropped. In it's place is the new Patch 3 which moves the check for the capabilities bit to when the IOThread objects are added to the domain at startup time. Making that change had a couple of side effects and the whole sordid history of how we got into this situation was left in the commit message. Due to moving the check one test started failing, so that was fixed and while I was at it - I added a test which would define iothreads, some iothreadids, and some iothreadpin to show that without the capability the failure will be at start time. - The former patch 3 was already pushed since it was ACK'd - The former patch 4 logic was adjusted (more or less) to what was requested during the review with a couple of tweaks based on the realities I found during testing. NB: I spent some cycles considering how to handle the case where a domain with iothreads/niothreadids > 0 was already running when libvirtd was restarted and how to handle that. In the end I decided upon trying to do the somewhat nice thing and remove all traces and if some domain had iothreadid's defined, then leave a VIR_INFO message indicating the removal. Without this change, then qemuDomainPinIOThread for the live code will need some kind of adjustment in order to handle the case where the capability doesn't exist (some sort of thread_id == 0 check right after the IOThreadIDFind succeeds). John Ferlan (4): qemu: Use 'niothreadids' instead of 'iothreads' qemu: Check for niothreads == 0 in qemuSetupCgroupForIOThreads qemu: Fix qemu startup check for QEMU_CAPS_OBJECT_IOTHREAD conf: Optimize the iothreadid initialization src/conf/domain_audit.c | 4 +- src/conf/domain_conf.c | 43 +++++++++++++++++----- src/qemu/qemu_cgroup.c | 3 ++ src/qemu/qemu_command.c | 19 ++++------ src/qemu/qemu_driver.c | 16 ++++---- src/qemu/qemu_process.c | 32 ++++++++++++++-- .../qemuxml2argv-cputune-numatune.args | 1 + .../qemuxml2argv-iothreads-nocap.xml | 37 +++++++++++++++++++ tests/qemuxml2argvtest.c | 2 + 9 files changed, 122 insertions(+), 35 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-nocap.xml -- 2.1.0

2 9

[libvirt] [PATCH] virsh: Use 'format' argument only when specified
by Peter Krempa 16 Oct '15

16 Oct '15

The condition checking whether --format was specified was incorrect. virsh crashed if the following format was used: virsh dump VM dump --format '' --memory-only Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1272301 --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 456e273..4191548 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5280,7 +5280,7 @@ doDump(void *opaque) goto out; } - if (vshCommandOptString(ctl, cmd, "format", &format)) { + if (vshCommandOptString(ctl, cmd, "format", &format) > 0) { if (STREQ(format, "kdump-zlib")) { dumpformat = VIR_DOMAIN_CORE_DUMP_FORMAT_KDUMP_ZLIB; } else if (STREQ(format, "kdump-lzo")) { -- 2.4.5

2 2

[libvirt] [PATCH] docs: event impl. registration before hypervisor connection
by Dominik Perpeet 15 Oct '15

15 Oct '15

Event implementations need to be registered before a connection to the Hypervisor is opened, otherwise event handling can be impaired (e.g. delayed messages). This fact is referenced in an e-mail [1], but should also be noted in the documentation of the registration functions. [1] https://www.redhat.com/archives/libvirt-users/2014-April/msg00011.html --- src/util/virevent.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/util/virevent.c b/src/util/virevent.c index 54b6396..e0fd35e 100644 --- a/src/util/virevent.c +++ b/src/util/virevent.c @@ -204,6 +204,9 @@ virEventRemoveTimeout(int timer) * to integrate with the libglib2 event loop, or libevent * or the QT event loop. * + * For proper event handling, it is important that the event implementation + * is registered before a connection to the Hypervisor is opened. + * * Use of the virEventAddHandle() and similar APIs require that the * corresponding handler is registered. Use of the * virConnectDomainEventRegisterAny() and similar APIs requires that @@ -247,6 +250,9 @@ void virEventRegisterImpl(virEventAddHandleFunc addHandle, * not have a need to integrate with an external event * loop impl. * + * For proper event handling, it is important that the event implementation + * is registered before a connection to the Hypervisor is opened. + * * Once registered, the application has to invoke virEventRunDefaultImpl() in * a loop to process events. Failure to do so may result in connections being * closed unexpectedly as a result of keepalive timeout. The default -- 1.8.3.1

3 2

[libvirt] Fwd: [PATCH 2/3] NEWS: Split releases by year (2012-2015)
by Eric Blake 15 Oct '15

15 Oct '15

[moderated for smaller size] -------- Forwarded Message -------- From: Andrea Bolognani <abologna(a)redhat.com> To: libvir-list(a)redhat.com Subject: [PATCH 2/3] NEWS: Split releases by year (2012-2015) Date: Thu, 15 Oct 2015 16:12:09 +0200 Message-Id: <1444918330-15696-3-git-send-email-abologna(a)redhat.com> --- docs/news-2012.html.in | 3012 ++++++++++++++ docs/news-2013.html.in | 3675 +++++++++++++++++ docs/news-2014.html.in | 3418 ++++++++++++++++ docs/news.html.in | 10052 +---------------------------------------------- 4 files changed, 10110 insertions(+), 10047 deletions(-) create mode 100644 docs/news-2012.html.in create mode 100644 docs/news-2013.html.in create mode 100644 docs/news-2014.html.in diff --git a/docs/news-2012.html.in b/docs/news-2012.html.in new file mode 100644 index 0000000..a198d3c --- /dev/null +++ b/docs/news-2012.html.in @@ -0,0 +1,3012 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2012)</h1> + <p>Here is the list of official releases made during the year 2012. + A similar list for <a href="news-2011.html">2011</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>1.0.1: Dec 17 2012</h3> + <ul> + <li>Features:<br/> + Introduce virtlockd daemon (Daniel P. Berrange),<br/> [...] diff --git a/docs/news-2013.html.in b/docs/news-2013.html.in new file mode 100644 index 0000000..62b75a5 --- /dev/null +++ b/docs/news-2013.html.in @@ -0,0 +1,3675 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2013)</h1> + <p>Here is the list of official releases made during the year 2013. + A similar list for <a href="news-2012.html">2012</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>1.2.0: Dec 02 2013</h3> + <ul> + <li>Features:<br/> + Add support for gluster pool (Eric Blake),<br/> [...] diff --git a/docs/news-2014.html.in b/docs/news-2014.html.in new file mode 100644 index 0000000..5480d5d --- /dev/null +++ b/docs/news-2014.html.in @@ -0,0 +1,3418 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2014)</h1> + <p>Here is the list of official releases made during the year 2014. + A similar list for <a href="news-2013.html">2013</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log">GIT log</a> + to gauge progress. + </p> + + <h3>1.2.11: Dec 13 2014</h3> + <ul> + <li>Features:<br/> + Implement public API for virDomainGetFSInfo (Tomoki Sekiyama),<br/> [...] diff --git a/docs/news.html.in b/docs/news.html.in index 90e6ac7..3e133c2 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -5,8 +5,11 @@ <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> </head> <body> - <h1>Releases</h1> - <p>Here is the list of official releases, it is also possible to just use + <h1>Releases (2015)</h1> + <p>Here is the list of official releases made during the year 2015. + A similar list for <a href="news-2014.html">2014</a> is also available. + </p> + <p>It is also possible to just use the <a href="downloads.html">GIT version or snapshot</a>, contact the mailing list and check the <a href="http://libvirt.org/git/?p=libvirt.git;a=log">GIT log</a> @@ -2441,10050 +2444,5 @@ </li> </ul> - <h3>1.2.11: Dec 13 2014</h3> - <ul> - <li>Features:<br/> - Implement public API for virDomainGetFSInfo (Tomoki Sekiyama),<br/> [...] - - <h3>0.9.9: Jan 07 2012</h3> - <ul> - <li>Features:<br/> [...] - <li>Cleanups:<br/> - network_conf: Fix whitespace to pass syntax-check (Peter Krempa)<br/> - </li> - </ul> - </body> </html> -- 2.4.3

1 0

[libvirt] Fwd: [PATCH 1/3] NEWS: Split releases by year (2005-2011)
by Eric Blake 15 Oct '15

15 Oct '15

[moderated for smaller size] -------- Forwarded Message -------- From: Andrea Bolognani <abologna(a)redhat.com> To: libvir-list(a)redhat.com Subject: [PATCH 1/3] NEWS: Split releases by year (2005-2011) Date: Thu, 15 Oct 2015 16:12:08 +0200 Message-Id: <1444918330-15696-2-git-send-email-abologna(a)redhat.com> --- docs/news-2005.html.in | 28 + docs/news-2006.html.in | 354 ++ docs/news-2007.html.in | 534 +++ docs/news-2008.html.in | 580 ++++ docs/news-2009.html.in | 1603 +++++++++ docs/news-2010.html.in | 2218 +++++++++++++ docs/news-2011.html.in | 3314 +++++++++++++++++++ docs/news.html.in | 8492 ------------------------------------------------ 8 files changed, 8631 insertions(+), 8492 deletions(-) create mode 100644 docs/news-2005.html.in create mode 100644 docs/news-2006.html.in create mode 100644 docs/news-2007.html.in create mode 100644 docs/news-2008.html.in create mode 100644 docs/news-2009.html.in create mode 100644 docs/news-2010.html.in create mode 100644 docs/news-2011.html.in diff --git a/docs/news-2005.html.in b/docs/news-2005.html.in new file mode 100644 index 0000000..97a43c6 --- /dev/null +++ b/docs/news-2005.html.in @@ -0,0 +1,28 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2005)</h1> + <p>Here is the list of official releases made during the year 2005. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>0.0.1: Dec 19 2005</h3> + <ul> + <li>Features:<br/> + First release,<br/> + Basic management of existing Xen domains,<br/> + Minimal autogenerated Python bindings<br/> + </li> + </ul> + + </body> +</html> diff --git a/docs/news-2006.html.in b/docs/news-2006.html.in new file mode 100644 index 0000000..df29a06 --- /dev/null +++ b/docs/news-2006.html.in @@ -0,0 +1,354 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2006)</h1> + <p>Here is the list of official releases made during the year 2006. + A similar list for <a href="news-2005.html">2005</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>0.1.10: Dec 20 2006</h3> + <ul> + <li>Bug Fixes:<br/> + VCPU info breakages on xen 3.0.3,<br/> [...] diff --git a/docs/news-2007.html.in b/docs/news-2007.html.in new file mode 100644 index 0000000..8b08963 --- /dev/null +++ b/docs/news-2007.html.in @@ -0,0 +1,534 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2007)</h1> + <p>Here is the list of official releases made during the year 2007. + A similar list for <a href="news-2006.html">2006</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>0.4.0: Dec 18 2007</h3> + <ul> + <li>Features:<br/> + Compilation on Windows cygwin/mingw (Richard Jones),<br/> [...] diff --git a/docs/news-2008.html.in b/docs/news-2008.html.in new file mode 100644 index 0000000..16ee9b1 --- /dev/null +++ b/docs/news-2008.html.in @@ -0,0 +1,580 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2008)</h1> + <p>Here is the list of official releases made during the year 2008. + A similar list for <a href="news-2007.html">2007</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>0.5.1: Dec 04 2008</h3> + <ul> + <li>Portability:<br/> [...] + fix parsing for CDRom device with no source (Daniel Berrange),<br/> + use xenstore to list domains to avoid some bugs (Guido GÃ¼nther),<br/> [...] diff --git a/docs/news-2009.html.in b/docs/news-2009.html.in new file mode 100644 index 0000000..c0b48ae --- /dev/null +++ b/docs/news-2009.html.in @@ -0,0 +1,1603 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2009)</h1> + <p>Here is the list of official releases made during the year 2009. + A similar list for <a href="news-2008.html">2008</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>0.7.5: Dec 23 2009</h3> + <ul> + <li>Features:<br/> [...] diff --git a/docs/news-2010.html.in b/docs/news-2010.html.in new file mode 100644 index 0000000..0fd8860 --- /dev/null +++ b/docs/news-2010.html.in @@ -0,0 +1,2218 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2010)</h1> + <p>Here is the list of official releases made during the year 2010. + A similar list for <a href="news-2009.html">2009</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>0.8.6: Nov 30 2010</h3> + <ul> + <li>Features:<br/> [...] diff --git a/docs/news-2011.html.in b/docs/news-2011.html.in new file mode 100644 index 0000000..5dacb5c --- /dev/null +++ b/docs/news-2011.html.in @@ -0,0 +1,3314 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> + </head> + <body> + <h1>Releases (2011)</h1> + <p>Here is the list of official releases made during the year 2011. + A similar list for <a href="news-2010.html">2010</a> is also available. + </p> + <p>It is also possible to just use + the <a href="downloads.html" shape="rect">GIT version or snapshot</a>, + contact the mailing list and check + the <a href="http://libvirt.org/git/?p=libvirt.git;a=log" shape="rect">GIT log</a> + to gauge progress. + </p> + + <h3>0.9.8: Dec 08 2011</h3> + <ul> + <li>Features:<br/> [...] diff --git a/docs/news.html.in b/docs/news.html.in index 0e89fae..90e6ac7 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -12486,8497 +12486,5 @@ </li> </ul> - <h3>0.9.8: Dec 08 2011</h3> - <ul> - <li>Features:<br/> [...] - - <h3>0.0.1: Dec 19 2005</h3> - <ul> - <li>Features:<br/> - First release,<br/> - Basic management of existing Xen domains,<br/> - Minimal autogenerated Python bindings<br/> - </li> - </ul> - </body> </html> -- 2.4.3

1 0

[libvirt] [PATCH v5 0/5] vz: add migration support
by Nikolay Shirokovskiy 15 Oct '15

15 Oct '15

NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate 200 vz+ssh://shiny0/system --p2p --live --compressed --persistent --undefinesource Difference from v4: 1. move preparation of the migration uri from src to dst as dst intended to do it. 2. change hypervisor migration scheme from 'tcp' to 'vzmigr' 3. declare this scheme in host caps src/vz/vz_driver.c | 356 ++++++++++++++++++++++++++++++++++++++++++++++++++++ src/vz/vz_sdk.c | 86 +++++++++++-- src/vz/vz_sdk.h | 6 + src/vz/vz_utils.h | 4 +- 4 files changed, 437 insertions(+), 15 deletions(-)

4 12

[libvirt] crash in virDomainNumaGetMemorySize
by Olaf Hering 15 Oct '15

15 Oct '15

With current master (56945e1), while toying around with a WS2008R2 Hyper-V host: root@probook:~ # gdb --quiet -ex 'r -c hv dumpxml all-sles12-dev' -ex bt -ex detach -ex quit virsh Reading symbols from virsh...Reading symbols from /usr/lib/debug/usr/bin/virsh.debug...done. done. Starting program: /usr/bin/virsh -c hv dumpxml all-sles12-dev [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Enter Administrator's password for optiplex.fritz.box: [New Thread 0x7fffee601700 (LWP 26921)] Program received signal SIGSEGV, Segmentation fault. virDomainNumaGetMemorySize (numa=0x0) at conf/numa_conf.c:971 971 for (i = 0; i < numa->nmem_nodes; i++) #0 virDomainNumaGetMemorySize (numa=0x0) at conf/numa_conf.c:971 #1 0x00007ffff793bce0 in virDomainDefGetMemoryActual (def=def@entry=0x55555582ead0) at conf/domain_conf.c:7857 #2 0x00007ffff7948978 in virDomainDefFormatInternal (def=0x55555582ead0, flags=0, buf=buf@entry=0x7fffffffdde0) at conf/domain_conf.c:21677 #3 0x00007ffff794b8bc in virDomainDefFormat (def=<optimized out>, flags=<optimized out>) at conf/domain_conf.c:22507 #4 0x00007ffff7a94c33 in hypervDomainGetXMLDesc (domain=<optimized out>, flags=0) at hyperv/hyperv_driver.c:882 #5 0x00007ffff79b5351 in virDomainGetXMLDesc (domain=domain@entry=0x5555558237a0, flags=0) at libvirt-domain.c:2591 #6 0x000055555558b978 in cmdDumpXML (ctl=0x7fffffffe1c0, cmd=<optimized out>) at virsh-domain.c:9634 #7 0x000055555557d04f in vshCommandRun (ctl=0x7fffffffe1c0, cmd=0x555555822580) at vsh.c:1212 #8 0x0000555555579a4d in main (argc=5, argv=0x7fffffffe3c8) at virsh.c:921 Detaching from program: /usr/bin/virsh, process 26917 root@probook:~ # rpm -qf `which virsh` libvirt-client-20150917T085913.56945e1-3.xen_unstable.1.x86_64 Olaf

2 3

[libvirt] genprotocol.pl generates unstable output
by Olaf Hering 15 Oct '15

15 Oct '15

If the same source gets built twice the resulting files may differ. One example is this: ... [ 305s] /usr/bin/perl -w ./rpc/genprotocol.pl /usr/bin/rpcgen -c \ [ 305s] remote/remote_protocol.x ./remote/remote_protocol.c ... [ 577s] /usr/src/debug/libvirt-20150929T082652.68572de/src/remote/remote_protocol.c differs (C source, ASCII text) [ 577s] --- old//usr/src/debug/libvirt-20150929T082652.68572de/src/remote/remote_protocol.c 2015-09-30 11:34:31.000000000 +0000 [ 577s] +++ new//usr/src/debug/libvirt-20150929T082652.68572de/src/remote/remote_protocol.c 2015-09-30 14:57:39.000000000 +0000 [ 577s] @@ -2084,8 +2084,8 @@ [ 577s] bool_t [ 577s] xdr_remote_domain_get_vcpus_ret (XDR *xdrs, remote_domain_get_vcpus_ret *objp) [ 577s] { [ 577s] - char **objp_cpp1 = (char **) (void *) &objp->cpumaps.cpumaps_val; [ 577s] char **objp_cpp0 = (char **) (void *) &objp->info.info_val; [ 577s] + char **objp_cpp1 = (char **) (void *) &objp->cpumaps.cpumaps_val; [ 577s] [ 577s] if (!xdr_array (xdrs, objp_cpp0, (u_int *) &objp->info.info_len, REMOTE_VCPUINFO_MAX, [ 577s] sizeof (remote_vcpu_info), (xdrproc_t) xdr_remote_vcpu_info)) ... The input is like: bool_t xdr_remote_domain_get_vcpus_ret (XDR *xdrs, remote_domain_get_vcpus_ret *objp) { register int32_t *buf; if (!xdr_array (xdrs, (char **)&objp->info.info_val, (u_int *) &objp->info.info_len, REMOTE_VCPUINFO_MAX, sizeof (remote_vcpu_info), (xdrproc_t) xdr_remote_vcpu_info)) return FALSE; if (!xdr_bytes (xdrs, (char **)&objp->cpumaps.cpumaps_val, (u_int *) &objp->cpumaps.cpumaps_len, REMOTE_CPUMAPS_MAX)) return FALSE; return TRUE; } Looks like the perl script transforms the pointers, but it does not sort them to enforce an order. I think its the map() which does it, but dont know enough perl to be sure. How can this be fixed? Olaf

3 5

[libvirt] [PATCH 1/3] libvirt-domain: Introduce macro to save duplicated codes
by Wei Jiangang 15 Oct '15

15 Oct '15

Signed-off-by: Wei Jiangang <weijg.fnst(a)cn.fujitsu.com> --- src/libvirt-domain.c | 55 ++++++++++++++-------------------------------------- 1 file changed, 15 insertions(+), 40 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6e1aacd..ed07c9e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -33,6 +33,13 @@ VIR_LOG_INIT("libvirt.domain"); #define VIR_FROM_THIS VIR_FROM_DOMAIN +#define VIR_ABSOLUTIZE_PATH(PATH, ABSPATH) \ + if (virFileAbsPath(PATH, ABSPATH) < 0) { \ + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", \ + _("could not build absolute input file path")); \ + goto error; \ + } + /** * virConnectListDomains: @@ -830,11 +837,7 @@ virDomainSave(virDomainPtr domain, const char *to) char *absolute_to; /* We must absolutize the file path as the save is done out of process */ - if (virFileAbsPath(to, &absolute_to) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("could not build absolute output file path")); - goto error; - } + VIR_ABSOLUTIZE_PATH(to, &absolute_to); ret = conn->driver->domainSave(domain, absolute_to); @@ -918,11 +921,7 @@ virDomainSaveFlags(virDomainPtr domain, const char *to, char *absolute_to; /* We must absolutize the file path as the save is done out of process */ - if (virFileAbsPath(to, &absolute_to) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("could not build absolute output file path")); - goto error; - } + VIR_ABSOLUTIZE_PATH(to, &absolute_to); ret = conn->driver->domainSaveFlags(domain, absolute_to, dxml, flags); @@ -968,11 +967,7 @@ virDomainRestore(virConnectPtr conn, const char *from) char *absolute_from; /* We must absolutize the file path as the restore is done out of process */ - if (virFileAbsPath(from, &absolute_from) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("could not build absolute input file path")); - goto error; - } + VIR_ABSOLUTIZE_PATH(from, &absolute_from); ret = conn->driver->domainRestore(conn, absolute_from); @@ -1042,11 +1037,7 @@ virDomainRestoreFlags(virConnectPtr conn, const char *from, const char *dxml, char *absolute_from; /* We must absolutize the file path as the restore is done out of process */ - if (virFileAbsPath(from, &absolute_from) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("could not build absolute input file path")); - goto error; - } + VIR_ABSOLUTIZE_PATH(from, &absolute_from); ret = conn->driver->domainRestoreFlags(conn, absolute_from, dxml, flags); @@ -1107,11 +1098,7 @@ virDomainSaveImageGetXMLDesc(virConnectPtr conn, const char *file, char *absolute_file; /* We must absolutize the file path as the read is done out of process */ - if (virFileAbsPath(file, &absolute_file) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("could not build absolute input file path")); - goto error; - } + VIR_ABSOLUTIZE_PATH(file, &absolute_file); ret = conn->driver->domainSaveImageGetXMLDesc(conn, absolute_file, flags); @@ -1180,11 +1167,7 @@ virDomainSaveImageDefineXML(virConnectPtr conn, const char *file, char *absolute_file; /* We must absolutize the file path as the read is done out of process */ - if (virFileAbsPath(file, &absolute_file) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("could not build absolute input file path")); - goto error; - } + VIR_ABSOLUTIZE_PATH(file, &absolute_file); ret = conn->driver->domainSaveImageDefineXML(conn, absolute_file, dxml, flags); @@ -1255,11 +1238,7 @@ virDomainCoreDump(virDomainPtr domain, const char *to, unsigned int flags) char *absolute_to; /* We must absolutize the file path as the save is done out of process */ - if (virFileAbsPath(to, &absolute_to) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("could not build absolute core file path")); - goto error; - } + VIR_ABSOLUTIZE_PATH(to, &absolute_to); ret = conn->driver->domainCoreDump(domain, absolute_to, flags); @@ -1339,11 +1318,7 @@ virDomainCoreDumpWithFormat(virDomainPtr domain, const char *to, char *absolute_to; /* We must absolutize the file path as the save is done out of process */ - if (virFileAbsPath(to, &absolute_to) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("could not build absolute core file path")); - goto error; - } + VIR_ABSOLUTIZE_PATH(to, &absolute_to); ret = conn->driver->domainCoreDumpWithFormat(domain, absolute_to, dumpformat, flags); -- 1.9.3

4 7

[libvirt] [PATCH] testscripts: make redirects happen in correct order
by Wei Jiangang 15 Oct '15

15 Oct '15

It should redirect stdout to /dev/null firstly, then redirect stderr to whatever stdout currently points at. Signed-off-by: Wei Jiangang <weijg.fnst(a)cn.fujitsu.com> --- tests/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test-lib.sh b/tests/test-lib.sh index e612f8f..d36a901 100644 --- a/tests/test-lib.sh +++ b/tests/test-lib.sh @@ -248,9 +248,9 @@ trap '(exit $?); exit $?' 1 2 13 15 cd "$t_" || error_ "failed to cd to $t_" -if ( diff --version < /dev/null 2>&1 | grep GNU ) 2>&1 > /dev/null; then +if ( diff --version < /dev/null 2>&1 | grep GNU ) >/dev/null 2>&1; then compare() { diff -u "$@"; } -elif ( cmp --version < /dev/null 2>&1 | grep GNU ) 2>&1 > /dev/null; then +elif ( cmp --version < /dev/null 2>&1 | grep GNU ) >/dev/null 2>&1; then compare() { cmp -s "$@"; } else compare() { cmp "$@"; } -- 1.9.3

3 2