- Devel - libvirt List Archives

[libvirt] [PATCH] conf: rework code around 'append' attribute to make coverity happy
by Dmitry Mishin 29 Dec '15

29 Dec '15

Signed-off-by: Dmitry Mishin <dim(a)virtuozzo.com> --- src/conf/domain_conf.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f210c0b..8895e10 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1723,10 +1723,11 @@ virDomainChrSourceDefCopy(virDomainChrSourceDefPtr dest, switch (src->type) { case VIR_DOMAIN_CHR_TYPE_FILE: - dest->data.file.append = src->data.file.append; case VIR_DOMAIN_CHR_TYPE_PTY: case VIR_DOMAIN_CHR_TYPE_DEV: case VIR_DOMAIN_CHR_TYPE_PIPE: + if (src->type == VIR_DOMAIN_CHR_TYPE_FILE) + dest->data.file.append = src->data.file.append; if (VIR_STRDUP(dest->data.file.path, src->data.file.path) < 0) return -1; break; @@ -9386,12 +9387,12 @@ virDomainChrSourceDefParseXML(virDomainChrSourceDefPtr def, switch ((virDomainChrType) def->type) { case VIR_DOMAIN_CHR_TYPE_FILE: - if (!append) - append = virXMLPropString(cur, "append"); case VIR_DOMAIN_CHR_TYPE_PTY: case VIR_DOMAIN_CHR_TYPE_DEV: case VIR_DOMAIN_CHR_TYPE_PIPE: case VIR_DOMAIN_CHR_TYPE_UNIX: + if (!append && def->type == VIR_DOMAIN_CHR_TYPE_FILE) + append = virXMLPropString(cur, "append"); /* PTY path is only parsed from live xml. */ if (!path && (def->type != VIR_DOMAIN_CHR_TYPE_PTY || @@ -9476,15 +9477,15 @@ virDomainChrSourceDefParseXML(virDomainChrSourceDefPtr def, break; case VIR_DOMAIN_CHR_TYPE_FILE: + case VIR_DOMAIN_CHR_TYPE_PTY: + case VIR_DOMAIN_CHR_TYPE_DEV: + case VIR_DOMAIN_CHR_TYPE_PIPE: if (append && (def->data.file.append = virTristateSwitchTypeFromString(append)) <= 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Invalid append attribute value '%s'"), append); goto error; } - case VIR_DOMAIN_CHR_TYPE_PTY: - case VIR_DOMAIN_CHR_TYPE_DEV: - case VIR_DOMAIN_CHR_TYPE_PIPE: if (!path && def->type != VIR_DOMAIN_CHR_TYPE_PTY) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", -- 1.8.3.1

2 2

[libvirt] [PATCHv2 0/3] 'Append' attribute for serial ports output to file
by Dmitry Mishin 26 Dec '15

26 Dec '15

By default, QEMU truncates serial file on open. Sometimes, it could be weird - for example, when we are trying to investigate some event, which occured several restarts ago. This patch set adds an ability to preserve previous content. Dmitry Mishin (3): tests: add qemu 2.6 caps test conf: Add new 'append' attribute for chardevs with file source qemu: Process new 'append' attribute for char dev with output to a file docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 28 +- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 10 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 173 + tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 4043 ++++++++++++++++++++ tests/qemucapabilitiestest.c | 1 + .../qemuxml2argv-serial-file-chardev.args | 2 +- .../qemuxml2argv-serial-file-chardev.xml | 2 +- tests/qemuxml2argvtest.c | 3 +- 12 files changed, 4264 insertions(+), 7 deletions(-) create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.replies -- 1.8.3.1

3 8

[libvirt] Proposal for snapshotting functions of volumes
by Wido den Hollander 25 Dec '15

25 Dec '15

Hi, Currently libvirt is lacking support for snapshotting volumes through the storage pool mechanism. I want to add this to libvirt, but since the internals and the API design ideas of libvirt are not fully known to me I wanted to put this up for a basic review first. This patch can also be viewed on Github: https://github.com/wido/libvirt/commit/4483ab247f607250c5b3314d0a19509ef251… My main questions are: * Is this something we would like to see in libvirt? * If so, am I on the right track? * If so, what API calls should be different? The steps I want to take: 1. Add the new API calls 2. Add support to the RBD backend 3. Add support to virsh 4. Add support to the Java bindings The Apache CloudStack project uses libvirt intensively and I want to add as much support to libvirt as we need so that we don't do stuff inside CloudStack where libvirt might be a lot better place to do it. Any comments are very much appreciated before I start spending hours of my time on this :) Wido

1 1

[libvirt] centos6.5 virsh list hang and libvirtd can not restart
by 王李明 25 Dec '15

25 Dec '15

hi all： my environment is centos6.5 libvirt version is 1.2.14-1 qemu version is 1.7.0-1 I use openstack create a windows guest about two days later I run virsh list but the the process is hang virsh list can not return any thing it hang then I run /etc/init.d/libvirtd restart it show libivrtd stop faild and start failed I run /etc/init.d/libvirtd status it show libvired dead but subsys locked who can help me ? thans

2 2

[libvirt] [PATCH] vz: BUG: fix connecting hang in case of init failure
by Maxim Nestratov 24 Dec '15

24 Dec '15

In case of prlsdkLoadDomains fails, vzOpenDefault should clear connection privateData pointer every time its memory is actually freed. Also it is not necessary to call vzConnectClose if a call to vzOpenDefault fails, because they both make cleanup of connection privateData. Signed-off-by: Maxim Nestratov <mnestratov(a)virtuozzo.com> --- src/vz/vz_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 2ef47e4..dfcffb4 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -266,6 +266,7 @@ vzOpenDefault(virConnectPtr conn) prlsdkDisconnect(privconn); prlsdkDeinit(); err_free: + conn->privateData = NULL; VIR_FREE(privconn); return VIR_DRV_OPEN_ERROR; } @@ -307,10 +308,8 @@ vzConnectOpen(virConnectPtr conn, return VIR_DRV_OPEN_ERROR; } - if ((ret = vzOpenDefault(conn)) != VIR_DRV_OPEN_SUCCESS) { - vzConnectClose(conn); + if ((ret = vzOpenDefault(conn)) != VIR_DRV_OPEN_SUCCESS) return ret; - } return VIR_DRV_OPEN_SUCCESS; } -- 2.4.3

2 1

[libvirt] [PATCH 0/3] vz: domain undefine fixes
by Maxim Nestratov 24 Dec '15

24 Dec '15

Maxim Nestratov (3): vz: delete domains when undefine is called vz: move prlsdkCleanupBridgedNet after domain deletion vz: support additional flags in domain undefine src/vz/vz_driver.c | 5 +- src/vz/vz_sdk.c | 138 +++++++++++++++++++++++++++++++++++++++++++++++++++-- src/vz/vz_sdk.h | 2 +- 3 files changed, 138 insertions(+), 7 deletions(-) -- 2.4.3

2 6

[libvirt] ANNOUNCE: libvirt 1.2.18.2 maintenance release
by Cole Robinson 24 Dec '15

24 Dec '15

libvirt 1.2.18.2 is now available. This is a maintenance release of libvirt 1.2.18 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.2.18.2.tar.gz Changes in this version: * Fix a trailing space in spec file * virsh: report errors for empty strings * bridge: check for invalid MAC in networkGetDHCPLeases * Enhance documentation of virDomainDetachDevice * apparmor: add missing qemu binaries * qemu: Use live autoNodeset when numatune placement is auto * Close the source fd if the destination qemu exits during tunnelled migration * storage: Fix incorrect format for <disk> <auth> XML * virt-host-validate: distinguish exists vs accessible for devices * spec: Delete .git after applying patches * apparmor: differentiate between error and unconfined profiles * storage: Adjust calculation of alloc/capacity for disk * qemu: Add conditions for qemu-kvm use on ppc64 * rpc: libssh2: Fix regression in ssh host key verification * rpc: libssh2: Add more debugging info * Update pool allocation with new values on volume creation * Use daemon log facility for journald * virDomainCreateXML: Make domain definition transient * virDomainCreateXML: Don't remove persistent domains on error * qemu: Refresh memory size only on fresh starts * domain: Fix migratable XML with graphics/@listen * tpm: adapt sysfs cancel path for new TPM driver * libvirt-guests: Disable shutdown timeout * systemd: Escape only needed characters for machined * systemd: Escape machine name for machined * CVE-2015-5313: storage: don't allow '/' in filesystem volume names * docs: event impl. registration before hypervisor connection * spec: Fix some warnings with latest rpmbuild * qemu: Fix dynamic_ownership qemu.conf setting For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 1.2.13.2 maintenance release
by Cole Robinson 24 Dec '15

24 Dec '15

libvirt 1.2.13.2 is now available. This is a maintenance release of libvirt 1.2.13 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.2.13.2.tar.gz Changes in this version: * spec: Delete .git after applying patches * qemu: block-commit: Mark disk in block jobs only on successful command * qemu: Disallow concurrent block jobs on a single disk * qemu: event: Don't fiddle with disk backing trees without a job * qemu: process: Export qemuProcessFindDomainDiskByAlias * spec: Fix polkit dep on F23 * domain: Fix migratable XML with graphics/@listen * qemu: hotplug: Properly clean up drive backend if frontend hotplug fails * tpm: adapt sysfs cancel path for new TPM driver * libvirt-guests: Disable shutdown timeout * systemd: Escape only needed characters for machined * systemd: Escape machine name for machined * cgroup: Drop resource partition from virSystemdMakeScopeName * CVE-2015-5313: storage: don't allow '/' in filesystem volume names * remoteClientCloseFunc: Don't mangle connection object refcount * Revert "LXC: show used memory as 0 when domain is not active" * lxc: Don't pass a local variable address randomly * lxc: set nosuid+nodev+noexec flags on /proc/sys mount * virnetdev: fix moving of 802.11 phys * interface: don't error out if a bond has no interfaces * lxc: don't up the veth interfaces unless explicitly asked to * tests: Add virnetdevtestdata to EXTRA_DIST * lxc: move wireless PHYs to a network namespace * Cleanup "/sys/class/net" usage * Introduce virnetdevtest * build: provide virNetDevSysfsFile on non-Linux For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCH 0/3] 'Append' mode for serial ports output to file
by Dmitry Mishin 23 Dec '15

23 Dec '15

By default, QEMU truncates serial file on open. Sometimes, it could be weird - for example, when we are trying to investigate some event, which occured several restarts ago. This patch setadds an ability to preserve previous content. Dmitry Mishin (3): tests: add qemu 2.6 caps test conf: Add mode 'append' for chardevs with file source qemu: Process new mode='append' for char dev with output to a file src/conf/domain_conf.c | 18 +- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 10 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 173 + tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 4043 +++++++++++++++++++++++ tests/qemucapabilitiestest.c | 1 + 8 files changed, 4245 insertions(+), 4 deletions(-) create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.caps create mode 100644 tests/qemucapabilitiesdata/caps_2.6.0-1.replies -- 1.8.3.1

2 4

[libvirt] [PATCHv2 0/3] 'autodeflate' attribute for mememory balloon
by Dmitry Andreev 23 Dec '15

23 Dec '15

This patch-set adds support for the new feature 'deflate-on-oom' that has been added to the QEMU virtio memory balloon a month ago. This feature lets a guest OS deflate balloon on OOM. With 'deflate-on-oom' enabled virtio balloon will release it's memory if possible right before an OOM termination of processes. QEMU commit with the complete feature description: http://git.qemu.org/?p=qemu.git;a=commit;h=e3816255bf4b6377bb405331e2ee0dc1… v2: * attribute renamed to 'autodeflate' [1/3][3/3] * capability check added [2/3][2/3] * ability to change 'autodeflate' for running domain wasn't added because QEMU doesn't allow to on/off 'deflate-on-oom' in runtime * more tests added [3/3] *** BLURB HERE *** Dmitry Andreev (3): conf: introduce 'autodeflate' attribute for memballoon device qemu: add capability check for memballoon 'autodeflate' feature qemu: add support of optional 'autodeflate' attribute docs/formatdomain.html.in | 10 ++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 23 +++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 11 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 11 ++ tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 68 ++++++++- tests/qemucapabilitiesdata/caps_1.3.1-1.replies | 68 ++++++++- tests/qemucapabilitiesdata/caps_1.4.2-1.replies | 68 ++++++++- tests/qemucapabilitiesdata/caps_1.5.3-1.replies | 66 ++++++++- tests/qemucapabilitiesdata/caps_1.6.0-1.replies | 66 ++++++++- tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 66 ++++++++- tests/qemucapabilitiesdata/caps_2.1.1-1.replies | 78 +++++++++- tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.replies | 146 ++++++++++++++++++- tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.replies | 161 ++++++++++++++++++++- .../qemuxml2argv-balloon-ccw-deflate.args | 20 +++ .../qemuxml2argv-balloon-ccw-deflate.xml | 21 +++ .../qemuxml2argv-balloon-device-deflate-off.args | 23 +++ .../qemuxml2argv-balloon-device-deflate-off.xml | 25 ++++ .../qemuxml2argv-balloon-device-deflate.args | 23 +++ .../qemuxml2argv-balloon-device-deflate.xml | 25 ++++ .../qemuxml2argv-balloon-mmio-deflate.args | 25 ++++ .../qemuxml2argv-balloon-mmio-deflate.xml | 30 ++++ tests/qemuxml2argvtest.c | 9 ++ 27 files changed, 990 insertions(+), 63 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-balloon-ccw-deflate.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-balloon-ccw-deflate.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-balloon-device-deflate-off.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-balloon-device-deflate-off.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-balloon-device-deflate.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-balloon-device-deflate.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-balloon-mmio-deflate.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-balloon-mmio-deflate.xml -- 1.8.3.1

1 0