- Devel - libvirt List Archives

[libvirt] [PATCH v2] qemuTestDriverInit: fill driver with zeroes
by Michal Privoznik 18 Jan '16

18 Jan '16

In the commit aea47e48c473a we have fixed a single pointer within driver structure. Since all callers pass statically allocated driver on stack other pointers within driver may contain random values too. Before touching it lets overwrite it with zeroes and thus fix all dangling pointers. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v1: -Jirka's review worked in tests/testutilsqemu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index f2eacdd..ae69a18 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -555,11 +555,11 @@ int qemuTestCapsCacheInsert(virQEMUCapsCachePtr cache, const char *binary, int qemuTestDriverInit(virQEMUDriver *driver) { + memset(driver, 0, sizeof(*driver)); + if (virMutexInit(&driver->lock) < 0) return -1; - driver->securityManager = NULL; - driver->config = virQEMUDriverConfigNew(false); if (!driver->config) goto error; -- 2.4.10

3 2

[libvirt] [python PATCH v2] setup: Use cflags and ldflags properly
by Jiri Denemark 18 Jan '16

18 Jan '16

The setup.py script reads cflags and ldflags from pkg-config and uses them when compiling/linking C modules. Since both cflags and ldflags may include multiple compiler arguments we need to split them rather than concatenating them into a single argument. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: Version 2: - fix all modules I'm surprised it ever worked. setup.py | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/setup.py b/setup.py index 9bf583b..c44f84a 100755 --- a/setup.py +++ b/setup.py @@ -88,17 +88,15 @@ def get_module_lists(): c_modules = [] py_modules = [] - ldflags = get_pkgconfig_data(["--libs-only-L"], "libvirt", False) - cflags = get_pkgconfig_data(["--cflags"], "libvirt", False) + ldflags = get_pkgconfig_data(["--libs-only-L"], "libvirt", False).split() + cflags = get_pkgconfig_data(["--cflags"], "libvirt", False).split() module = Extension('libvirtmod', sources = ['libvirt-override.c', 'build/libvirt.c', 'typewrappers.c', 'libvirt-utils.c'], libraries = [ "virt" ], include_dirs = [ "." ]) - if cflags != "": - module.extra_compile_args.append(cflags) - if ldflags != "": - module.extra_link_args.append(ldflags) + module.extra_compile_args.extend(cflags) + module.extra_link_args.extend(ldflags) c_modules.append(module) py_modules.append("libvirt") @@ -107,10 +105,8 @@ def get_module_lists(): sources = ['libvirt-qemu-override.c', 'build/libvirt-qemu.c', 'typewrappers.c', 'libvirt-utils.c'], libraries = [ "virt-qemu" ], include_dirs = [ "." ]) - if cflags != "": - moduleqemu.extra_compile_args.append(cflags) - if ldflags != "": - moduleqemu.extra_link_args.append(ldflags) + moduleqemu.extra_compile_args.extend(cflags) + moduleqemu.extra_link_args.extend(ldflags) c_modules.append(moduleqemu) py_modules.append("libvirt_qemu") @@ -120,10 +116,8 @@ def get_module_lists(): sources = ['libvirt-lxc-override.c', 'build/libvirt-lxc.c', 'typewrappers.c', 'libvirt-utils.c'], libraries = [ "virt-lxc" ], include_dirs = [ "." ]) - if cflags != "": - modulelxc.extra_compile_args.append(cflags) - if ldflags != "": - modulelxc.extra_link_args.append(ldflags) + modulelxc.extra_compile_args.extend(cflags) + modulelxc.extra_link_args.extend(ldflags) c_modules.append(modulelxc) py_modules.append("libvirt_lxc") -- 2.7.0

2 1

[libvirt] [python PATCH] setup: Use cflags and ldflags properly
by Jiri Denemark 18 Jan '16

18 Jan '16

The setup.py script reads cflags and ldflags from pkg-config and uses them when compiling/linking C modules. Since both cflags and ldflags may include multiple compiler arguments we need to split them rather than concatenating them into a single argument. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 9bf583b..6994e75 100755 --- a/setup.py +++ b/setup.py @@ -96,9 +96,9 @@ def get_module_lists(): libraries = [ "virt" ], include_dirs = [ "." ]) if cflags != "": - module.extra_compile_args.append(cflags) + module.extra_compile_args.extend(cflags.split()) if ldflags != "": - module.extra_link_args.append(ldflags) + module.extra_link_args.extend(ldflags.split()) c_modules.append(module) py_modules.append("libvirt") -- 2.7.0

2 1

[libvirt] [python PATCH] Post-release version bump to 1.3.2
by Jiri Denemark 18 Jan '16

18 Jan '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index d2beece..9bf583b 100755 --- a/setup.py +++ b/setup.py @@ -311,7 +311,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '1.3.1', + version = '1.3.2', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.7.0

1 1

[libvirt] [PATCH 0/2] qemu: Properly detect if qemu is unable to do snapshot due to AHCI
by Peter Krempa 18 Jan '16

18 Jan '16

Peter Krempa (2): qemu: monitor: Refactor error handling for 'savevm' qemu: snapshot: Correctly report qemu error on 'savevm' src/qemu/qemu_monitor_text.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) -- 2.6.2

2 3

[libvirt] [PATCH] rbd: Set r variable so it can be returned should an error occur
by Wido den Hollander 18 Jan '16

18 Jan '16

This was reported in bug #1298024 where r would be filled with the return code of rbd_open(). Should rbd_snap_unprotect() fail for any reason the virReportSystemError call would return 'Success' since rbd_open() succeeded. https://bugzilla.redhat.com/show_bug.cgi?id=1298024 Signed-off-by: Wido den Hollander <wido(a)widodh.nl> --- src/storage/storage_backend_rbd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index e20a54d..8c7a80d 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -473,7 +473,8 @@ static int virStorageBackendRBDCleanupSnapshots(rados_ioctx_t ioctx, if (snap_count > 0) { for (i = 0; i < snap_count; i++) { - if (rbd_snap_is_protected(image, snaps[i].name, &protected)) { + r = rbd_snap_is_protected(image, snaps[i].name, &protected); + if (r < 0) { virReportSystemError(-r, _("failed to verify if snapshot '%s/%s@%s' is protected"), source->name, vol->name, snaps[i].name); @@ -485,7 +486,8 @@ static int virStorageBackendRBDCleanupSnapshots(rados_ioctx_t ioctx, "unprotected", source->name, vol->name, snaps[i].name); - if (rbd_snap_unprotect(image, snaps[i].name) < 0) { + r = rbd_snap_unprotect(image, snaps[i].name); + if (r < 0) { virReportSystemError(-r, _("failed to unprotect snapshot '%s/%s@%s'"), source->name, vol->name, snaps[i].name); -- 1.9.1

2 1

[libvirt] [PATCH 0/3] make containers memory settings API consistent
by Nikolay Shirokovskiy 18 Jan '16

18 Jan '16

Typical HVM hypervisor has 2 memory settings - maximum and current memory. (there could be more memory options of course but let's consider these two and their correlation). Current limit is implemented via ballooning and is not greater than maximum. Containers are different, we need only one parameter to control their memory consumption - current memory. Memory settings API, domain XML schema and domain internal representation arises obviously for HVMs where we have 2 different parameters. How one should adopt it for containers? This patch series makes these 2 parameters synonyms for containers. 1. API - make maximum memory API behaviour same to just memory. 2. internally keep cur_balloon and initial (or total) the same. 3. ignore cur_ballon in XML (we do it already, just keep internal representation consistent) Nikolay Shirokovskiy (3): lxc: make maximum and current settings same conf: keep cur_balloon and initial_memory the same docs: update memory setting descripitons docs/formatdomain.html.in | 6 ++--- src/conf/domain_conf.c | 8 +++++-- src/libvirt-domain.c | 6 ++++- src/lxc/lxc_driver.c | 58 ++++++++++++----------------------------------- tools/virsh.pod | 6 +++++ 5 files changed, 34 insertions(+), 50 deletions(-) -- 1.8.3.1

1 3

[libvirt] [PATCH 0/3] NEWS: Update for 2016
by Andrea Bolognani 18 Jan '16

18 Jan '16

Move all entries made in 2015 to a separate file and perform some minor cleanups while we're at it. Patch 1/3 is kinda big, so it might need to be explicitly allowed out of the moderation queue. Cheers. Andrea Bolognani (3): NEWS: Move 2015 entries to a separate file NEWS: Fix whitespace issues NEWS: Don't prefix version numbers with 'v' docs/{news.html.in => news-2015.html.in} | 325 +--- docs/news.html.in | 2852 +----------------------------- 2 files changed, 6 insertions(+), 3171 deletions(-) copy docs/{news.html.in => news-2015.html.in} (89%) -- 2.5.0

2 5

[libvirt] [PATCH] qemuTestDriverInit: fill driver with zeroes
by Michal Privoznik 18 Jan '16

18 Jan '16

In the commit aea47e48c473a we have fixed a single pointer within driver structure. Since all callers pass statically allocated driver on stack other pointers within driver may contain random values too. Before touching it lets overwrite it with zeroes and thus fix all dangling pointers. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/testutilsqemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index f2eacdd..6c52b96 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -558,7 +558,7 @@ int qemuTestDriverInit(virQEMUDriver *driver) if (virMutexInit(&driver->lock) < 0) return -1; - driver->securityManager = NULL; + memset(driver, 0, sizeof(*driver)); driver->config = virQEMUDriverConfigNew(false); if (!driver->config) -- 2.4.10

2 2

[libvirt] [PATCH V2 0/9] support multi-thread compress migration.
by ShaoHe Feng 18 Jan '16

18 Jan '16

These series patches support multi-thread compress during live migration. Eli Qiao (4): Add test cases for qemuMonitorJSONGetMigrationParameter remote: Add support for set and get multil thread migration parameters qemu_driver: Add support to set/get migration parameters. virsh: Add set and get multi-thread migration parameters commands ShaoHe Feng (5): qemu_migration: Add support for mutil-thread compressed migration enable qemu: Add monitor API for get/set migration parameters set multi-thread compress params for Migrate3 during live migration virsh: add multi-thread migration option for live migrate command Implement the public APIs for multi-thread compress parameters. .gnulib | 2 +- daemon/remote.c | 62 +++++++++++ include/libvirt/libvirt-domain.h | 31 ++++++ src/driver-hypervisor.h | 14 +++ src/libvirt-domain.c | 110 +++++++++++++++++++ src/libvirt_public.syms | 5 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 186 ++++++++++++++++++++++++++++++++ src/qemu/qemu_migration.c | 105 ++++++++++++++++++ src/qemu/qemu_migration.h | 32 ++++-- src/qemu/qemu_monitor.c | 40 ++++++- src/qemu/qemu_monitor.h | 11 ++ src/qemu/qemu_monitor_json.c | 93 ++++++++++++++++ src/qemu/qemu_monitor_json.h | 9 ++ src/qemu/qemu_monitor_text.c | 95 +++++++++++++++++ src/qemu/qemu_monitor_text.h | 10 ++ src/remote/remote_driver.c | 54 ++++++++++ src/remote/remote_protocol.x | 30 +++++- src/remote_protocol-structs | 26 +++++ tests/qemumonitorjsontest.c | 53 ++++++++++ tools/virsh-domain.c | 223 ++++++++++++++++++++++++++++++++++++++- tools/virsh.pod | 37 +++++-- 22 files changed, 1212 insertions(+), 19 deletions(-) -- 2.1.4

4 19