- Devel - libvirt List Archives

[libvirt] [PATCH] admin_server: fix memory leak
by Pavel Hrdina 25 Mar '16

25 Mar '16

If caller of adminConnectListServers() pass NULL instead of servers we need to free the list we've received from virNetDaemonGetServers(). Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- daemon/admin_server.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/daemon/admin_server.c b/daemon/admin_server.c index 1d16bc9..2f26488 100644 --- a/daemon/admin_server.c +++ b/daemon/admin_server.c @@ -52,6 +52,8 @@ adminConnectListServers(virNetDaemonPtr dmn, if (servers) { *servers = srvs; srvs = NULL; + } else { + virObjectListFreeCount(srvs, ret); } cleanup: return ret; -- 2.7.4

3 3

[libvirt] [PATCH v2] qemu: Replace some VIR_ERROR with vir*Error
by Jovanka Gulicoska 24 Mar '16

24 Mar '16

qemuStateInitialize uses a mix of VIR_ERROR and standard vir*Error calls. Prefer the standard vir*Error --- src/qemu/qemu_driver.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e5ed6b5..161a20f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -638,7 +638,6 @@ qemuStateInitialize(bool privileged, { char *driverConf = NULL; virConnectPtr conn = NULL; - char ebuf[1024]; virQEMUDriverConfigPtr cfg; uid_t run_uid = -1; gid_t run_gid = -1; @@ -649,7 +648,8 @@ qemuStateInitialize(bool privileged, return -1; if (virMutexInit(&qemu_driver->lock) < 0) { - VIR_ERROR(_("cannot initialize mutex")); + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("cannot initialize mutex")); VIR_FREE(qemu_driver); return -1; } @@ -682,44 +682,43 @@ qemuStateInitialize(bool privileged, VIR_FREE(driverConf); if (virFileMakePath(cfg->stateDir) < 0) { - VIR_ERROR(_("Failed to create state dir '%s': %s"), - cfg->stateDir, virStrerror(errno, ebuf, sizeof(ebuf))); + virReportSystemError(errno, _("Failed to create state dir %s"), + cfg->stateDir); goto error; } if (virFileMakePath(cfg->libDir) < 0) { - VIR_ERROR(_("Failed to create lib dir '%s': %s"), - cfg->libDir, virStrerror(errno, ebuf, sizeof(ebuf))); + virReportSystemError(errno, _("Failed to create lib dir %s"), + cfg->libDir); goto error; } if (virFileMakePath(cfg->cacheDir) < 0) { - VIR_ERROR(_("Failed to create cache dir '%s': %s"), - cfg->cacheDir, virStrerror(errno, ebuf, sizeof(ebuf))); + virReportSystemError(errno, _("Failed to create cache dir %s"), + cfg->cacheDir); goto error; } if (virFileMakePath(cfg->saveDir) < 0) { - VIR_ERROR(_("Failed to create save dir '%s': %s"), - cfg->saveDir, virStrerror(errno, ebuf, sizeof(ebuf))); + virReportSystemError(errno, _("Failed to create save dir %s"), + cfg->saveDir); goto error; } if (virFileMakePath(cfg->snapshotDir) < 0) { - VIR_ERROR(_("Failed to create save dir '%s': %s"), - cfg->snapshotDir, virStrerror(errno, ebuf, sizeof(ebuf))); + virReportSystemError(errno, _("Failed to create save dir %s"), + cfg->snapshotDir); goto error; } if (virFileMakePath(cfg->autoDumpPath) < 0) { - VIR_ERROR(_("Failed to create dump dir '%s': %s"), - cfg->autoDumpPath, virStrerror(errno, ebuf, sizeof(ebuf))); + virReportSystemError(errno, _("Failed to create dump dir %s"), + cfg->autoDumpPath); goto error; } if (virFileMakePath(cfg->channelTargetDir) < 0) { - VIR_ERROR(_("Failed to create channel target dir '%s': %s"), - cfg->channelTargetDir, - virStrerror(errno, ebuf, sizeof(ebuf))); + virReportSystemError(errno, _("Failed to create channel target dir %s"), + cfg->channelTargetDir); goto error; } if (virFileMakePath(cfg->nvramDir) < 0) { - VIR_ERROR(_("Failed to create nvram dir '%s': %s"), - cfg->nvramDir, virStrerror(errno, ebuf, sizeof(ebuf))); + virReportSystemError(errno, _("Failed to create nvram dir %s"), + cfg->nvramDir); goto error; } -- 2.5.0

2 1

[libvirt] [PATCH v2] qemu: Don't duplicate virGetLastErrorMessage
by Jovanka Gulicoska 24 Mar '16

24 Mar '16

These uses of virGetLastError message are just duplicating virGetLastErrorMessage. --- src/qemu/qemu_capabilities.c | 14 ++++---------- src/qemu/qemu_driver.c | 9 ++------- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index b223837..2823843 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3089,10 +3089,8 @@ virQEMUCapsInitCached(virQEMUCapsPtr qemuCaps, const char *cacheDir) if (virQEMUCapsLoadCache(qemuCaps, capsfile, &qemuctime, &selfctime, &selfvers) < 0) { - virErrorPtr err = virGetLastError(); VIR_WARN("Failed to load cached caps from '%s' for '%s': %s", - capsfile, qemuCaps->binary, err ? NULLSTR(err->message) : - _("unknown error")); + capsfile, qemuCaps->binary, virGetLastErrorMessage()); virResetLastError(); ret = 0; virQEMUCapsReset(qemuCaps); @@ -3320,9 +3318,8 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps, /* @mon is supposed to be locked by callee */ if (qemuMonitorSetCapabilities(mon) < 0) { - virErrorPtr err = virGetLastError(); VIR_DEBUG("Failed to set monitor capabilities %s", - err ? err->message : "<unknown problem>"); + virGetLastErrorMessage()); ret = 0; goto cleanup; } @@ -3330,9 +3327,8 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps, if (qemuMonitorGetVersion(mon, &major, &minor, &micro, &package) < 0) { - virErrorPtr err = virGetLastError(); VIR_DEBUG("Failed to query monitor version %s", - err ? err->message : "<unknown problem>"); + virGetLastErrorMessage()); ret = 0; goto cleanup; } @@ -3561,15 +3557,13 @@ virQEMUCapsLogProbeFailure(const char *binary) { .key = "LIBVIRT_QEMU_BINARY", .s = binary, .iv = 0 }, { .key = NULL }, }; - virErrorPtr err = virGetLastError(); virLogMessage(&virLogSelf, VIR_LOG_WARN, __FILE__, __LINE__, __func__, meta, _("Failed to probe capabilities for %s: %s"), - binary, err && err->message ? err->message : - _("unknown failure")); + binary, virGetLastErrorMessage()); } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 29c3bc8..6e0e19e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -277,7 +277,6 @@ qemuAutostartDomain(virDomainObjPtr vm, void *opaque) { struct qemuAutostartData *data = opaque; - virErrorPtr err; int flags = 0; virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(data->driver); int ret = -1; @@ -291,19 +290,15 @@ qemuAutostartDomain(virDomainObjPtr vm, if (vm->autostart && !virDomainObjIsActive(vm)) { if (qemuProcessBeginJob(data->driver, vm) < 0) { - err = virGetLastError(); VIR_ERROR(_("Failed to start job on VM '%s': %s"), - vm->def->name, - err ? err->message : _("unknown error")); + vm->def->name, virGetLastErrorMessage()); goto cleanup; } if (qemuDomainObjStart(data->conn, data->driver, vm, flags, QEMU_ASYNC_JOB_START) < 0) { - err = virGetLastError(); VIR_ERROR(_("Failed to autostart VM '%s': %s"), - vm->def->name, - err ? err->message : _("unknown error")); + vm->def->name, virGetLastErrorMessage()); } qemuProcessEndJob(data->driver, vm); -- 2.5.0

2 1

[libvirt] Usability Enhancement: Import/Export VMs GUI
by bancfc＠openmailbox.org 24 Mar '16

24 Mar '16

The single most important usability feature missed by our less technical users who migrate from VirtualBox is a one click import/export of VMs and their config settings. I was optimistic about the Gnome Boxes effort on Govf lib but unfortunately it was never realized and I would hesitate to recommend it because libvirt/virt-manager has the security advantages of sVirt. An ideal solution would work across all KVM frontends.

4 8

[libvirt] [PATCH 0/3] virlog: Refactor logging filters parser
by Erik Skultety 24 Mar '16

24 Mar '16

This series continues where series 0b231195 left and refactors logging filter parser. Series 0b231195 also introduced a small bug where if a specific testcase passes, but should fail, the original parser return value is returned instead of -1. That way, the virlogtest as a whole still appears as passed, even though it failed. Thus, this series also addresses this issue. Erik Skultety (3): tests: virlogtest: Fix testLogParseOutputs return value tests: Add new testcases to test parsing of log filters in virlogtest virlog: Refactor virLogParseFilters src/util/virlog.c | 95 +++++++++++++++++++++++++++++++++++++----------------- tests/virlogtest.c | 50 +++++++++++++++++++++++++--- 2 files changed, 111 insertions(+), 34 deletions(-) -- 2.4.3

2 6

[libvirt] [PATCH 0/2] Couple of small fixes
by Michal Privoznik 24 Mar '16

24 Mar '16

*** SOME BLURB HERE *** Michal Privoznik (2): nsstest: Drop useless @data check testutils: Adapt to highly unlikely case tests/nsstest.c | 3 --- tests/testutils.c | 13 ++++++++++--- 2 files changed, 10 insertions(+), 6 deletions(-) -- 2.7.3

2 3

[libvirt] current master failed to compile
by Vasiliy Tolstov 24 Mar '16

24 Mar '16

libvirt.c:323:15: error: 'gcry_thread_cbs' is deprecated [-Werror=deprecated-declarations] static struct gcry_thread_cbs virTLSThreadImpl = { ^ In file included from libvirt.c:58:0: /usr/x86_64-pc-linux-gnu/include/gcrypt.h:211:8: note: declared here struct gcry_thread_cbs ^ libvirt.c:331:5: error: excess elements in struct initializer [-Werror] virTLSMutexInit, ^ libvirt.c:331:5: note: (near initialization for 'virTLSThreadImpl') libvirt.c:332:5: error: excess elements in struct initializer [-Werror] virTLSMutexDestroy, ^ libvirt.c:332:5: note: (near initialization for 'virTLSThreadImpl') libvirt.c:333:5: error: excess elements in struct initializer [-Werror] virTLSMutexLock, ^ libvirt.c:333:5: note: (near initialization for 'virTLSThreadImpl') libvirt.c:334:5: error: excess elements in struct initializer [-Werror] virTLSMutexUnlock, ^ libvirt.c:334:5: note: (near initialization for 'virTLSThreadImpl') my configure line is: ./configure --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --prefix=/usr/x86_64-pc-linux-gnu --bindir=/usr/x86_64-pc-linux-gnu/bin --sbindir=/usr/x86_64-pc-linux-gnu/bin --libdir=/usr/x86_64-pc-linux-gnu/lib --datadir=/usr/share --datarootdir=/usr/share --docdir=/usr/share/doc/libvirt-scm --infodir=/usr/share/info --mandir=/usr/share/man --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --disable-silent-rules --enable-fast-install --enable-nls --localstatedir=/var --with-blkid --with-chrdev-lock-files=/run/lock --with-curl --with-dbus --with-firewalld --with-gnutls --with-html-dir=/usr/share/doc/libvirt-scm --with-html-subdir=./ --with-init-script=systemd --with-interface --with-libvirtd --with-macvtap --with-pciaccess --with-qemu-group=kvm --with-readline --with-remote --with-secrets --with-ssh2 --with-storage-dir --with-storage-fs --with-sysctl --with-test --with-udev --with-virtualport --without-apparmor --without-apparmor-mount --without-apparmor-profiles --without-audit --without-driver-modules --without-dtrace --without-esx --without-hal --without-hyperv --without-included-regex --without-libxl --without-netcf --without-openvz --without-openwsman --without-phyp --without-rhel5-api --without-sanlock --without-secdriver-apparmor --without-secdriver-selinux --without-selinux --without-selinux-mount --without-storage-gluster --without-storage-rbd --without-storage-zfs --without-vz --without-xen --without-xen-inotify --without-xenapi --enable-debug --without-avahi --with-attr --without-storage-iscsi --with-qemu --with-yajl --with-capng --without-storage-lvm --without-storage-mpath --with-lxc --with-fuse --without-network --without-numactl --without-numad --without-libpcap --without-pm-utils --without-polkit --without-storage-disk --without-sasl --without-storage-scsi --without-storage-sheepdog --without-uml --without-vbox --without-vmware --without-wireshark-dissector -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

4 6

[libvirt] [PATCH 0/3] Couple of coverity fixes
by Michal Privoznik 24 Mar '16

24 Mar '16

These all have been spotted by coverity. Michal Privoznik (3): event-test: Use goto cleanup instead of if else jungle event-test: Check for virConnectRegisterCloseCallback return value gendispatch: Avoid comparing signed and unsigned vars examples/object-events/event-test.c | 138 +++++++++++++++++++----------------- src/rpc/gendispatch.pl | 2 +- 2 files changed, 75 insertions(+), 65 deletions(-) -- 2.4.10

2 5

[libvirt] [PATCH v6 0/4] ARM: add query-gic-capabilities SMP command
by Peter Xu 24 Mar '16

24 Mar '16

v6 changes: - patch 1 (squashed into patch 2) - explain more about the following in commit message: why we need this command, and what does the entries mean [Markus] - explain what GIC is [Eric] - squash this patch into patch 2 [Eric] - patch 2 (new patch 1) - fix "does not implement" english error [Eric] - remove useless headers in target-arm/monitor.c [Markus] - remove this command from whitelist [Markus, Eric] - return dict rather than array, with single key points to the original array results [Markus, Eric] - patch 5 (new patch 4) - tiny change in implementation to suite the new interface. v5 changes: - patch 2: moved to target-arm/monitor.c (from target-arm/machine.c) [Peter] - patch 3: splitted into three patches: [all from Peter's comments] - patch 3 (new): leverage kvm_arm_create_scratch_host_vcpu(), tiny enhancement of old one to suite our need - patch 4: introduce kvm_support_device() in kvm-all.c - patch 5: do the implementation. v4 changes: - all: rename query-gic-capability to query-gic-capabilities [Andrea] - patch 3: rename helper function to kvm_support_device, make it inline and lighter. [Drew] v3 changes: - patch 2: remove func declaration, add qmp header [Drew] - patch 3: being able to detect KVM GIC capabilities even without kvm enabled [Andrea]: this is a little bit hacky, need some more review on this. v2 changes: - result layout change: use array and dict for the capability bits rather than a single array of strings [Andrea/Markus] - spelling out what GIC is in doc [Eric] This patch is to add ARM-specific command "query-gic-capability". The new command can report which kind of GIC device the host/QEMU support. The returned result is in the form of array. Sample command and output: {"execute": "query-gic-capability"} {"return": [{"emulated": false, "version": 3, "kernel": false}, {"emulated": true, "version": 2, "kernel": true}]} Testing: Smoke tests on both x86 (emulated) and another moonshot ARM server. Peter Xu (4): arm: qmp: add query-gic-capabilities interface arm: enhance kvm_arm_create_scratch_host_vcpu kvm: add kvm_support_device() helper function arm: implement query-gic-capabilities include/sysemu/kvm.h | 9 +++++ kvm-all.c | 15 +++++++++ monitor.c | 8 +++++ qapi-schema.json | 50 ++++++++++++++++++++++++++++ qmp-commands.hx | 28 ++++++++++++++++ target-arm/Makefile.objs | 2 +- target-arm/kvm.c | 10 +++++- target-arm/kvm_arm.h | 6 ++-- target-arm/monitor.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++++ 9 files changed, 210 insertions(+), 4 deletions(-) create mode 100644 target-arm/monitor.c -- 2.4.3

4 17

[libvirt] [PATCH] remote: Fix error message
by Cole Robinson 23 Mar '16

23 Mar '16

We were printing the wrong MAX value --- Pushed as trivial daemon/remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/remote.c b/daemon/remote.c index 2bf9e83..3bf94fa 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -5724,11 +5724,11 @@ remoteDispatchConnectGetAllDomainStats(virNetServerPtr server ATTRIBUTE_UNUSED, if (nrecords > REMOTE_CONNECT_GET_ALL_DOMAIN_STATS_MAX) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Number of domain stats records is %d, " "which exceeds max limit: %d"), - nrecords, REMOTE_DOMAIN_LIST_MAX); + nrecords, REMOTE_CONNECT_GET_ALL_DOMAIN_STATS_MAX); goto cleanup; } if (nrecords) { if (VIR_ALLOC_N(ret->retStats.retStats_val, nrecords) < 0) -- 2.5.0

1 0