- Devel - libvirt List Archives

[libvirt] [PATCH REBASE 0/4] vz: use disk bus and target name as disk id
by Nikolay Shirokovskiy 19 Apr '16

19 Apr '16

This series is a preparation to implement device update functionality. In case of disk updates disk bus and disk target name pair is considered disk id. We already have places in vz driver code where we use disk source as id. These places are either not critical (see boot patch) or correct (see detach patch) so we need not to fix them immediately to use more rubust id. But as this id will be introduced anyway for disk updates let's move to new id in existing code. This way we have single id for disks. Nikolay Shirokovskiy (4): vz: introduce vzsdk disk id function vz: fix detach disk to use new disk id vz: fix boot check to use new disk id vz: cleanup: remove trivial function src/vz/vz_sdk.c | 251 ++++++++++++++++++++++++++++---------------------------- 1 file changed, 126 insertions(+), 125 deletions(-) -- 1.8.3.1

2 9

[libvirt] [PATCH 00/10] Convert secret driver to use hashed object
by John Ferlan 19 Apr '16

19 Apr '16

This series replaces the usage of linked list in secret driver with a hashed object list as was suggested in the review in the last patch of the previous secret driver changes series: http://www.redhat.com/archives/libvir-list/2016-February/msg01274.html Patch 1 - starts the ball rolling Patch 2 - is yet another code optimization (as found in bridge_driver) Patches 3-8 - Add the new API's "slowly" (for review purposes) Patch 9 - replaces the usage of linked lists with the hashed object Patch 10 - moves the secretLoadAllConfigs to secret_conf The changes are loosely modeled after both virdomainobj and network_conf functionality. The real meat and potato(e)s is found in patches 5 and 9. Other functions should be relatively straightforward. I've done testing of various virsh secret-* commands (both valid and invalid options) as well as performing driver start, stop, and reload testing. Each patch was built using 'check' and 'syntax-check'. The end result is much more code in secret_conf and much less in secret_driver. John Ferlan (10): secret: Move virSecretObj to secret_conf.h Add secretObjFromSecret secret: Add hashed virSecretObj and virSecretObjList secret: Introduce virSecretObjListFindBy{UUID|Usage} support secret: Introduce virSecretObjListAdd* and virSecretObjListRemove secret: Introduce virSecretObjListNumOfSecrets secret: Introduce virSecretObjListExport secret: Introduce virSecretObjListGetUUIDs secret: Use the hashed virSecretObjList secret: Move and rename secretLoadAllConfigs src/conf/secret_conf.c | 819 ++++++++++++++++++++++++++++++++++++++++++++- src/conf/secret_conf.h | 76 ++++- src/libvirt_private.syms | 11 + src/secret/secret_driver.c | 647 +++-------------------------------- 4 files changed, 957 insertions(+), 596 deletions(-) -- 2.5.0

4 40

[libvirt] [PATCH 0/3] qemu: cleanup duplicate calls to DomainObjIsActive
by Cole Robinson 19 Apr '16

19 Apr '16

Some API entry points have duplicate calls to DomainObjIsActive. Remove the redundant ones, and document the valid ones that confused me :) Cole Robinson (3): qemu: Remove redundant DomainObjIsActive calls qemu: Clarify usage of DomainObjIsActive for PMSuspended qemu: Clarify usage of DomainObjIsActive for SetTime src/qemu/qemu_driver.c | 43 ++++++++++++++++--------------------------- 1 file changed, 16 insertions(+), 27 deletions(-) -- 2.7.3

2 7

[libvirt] [PATCH] Explicitly error on uri=qemu://system
by Cole Robinson 19 Apr '16

19 Apr '16

It's a fairly common error that a user tries to connect to a URI like qemu://system or qemu://session (missing a slash). This errors like: $ virsh --connect qemu://session error: failed to connect to the hypervisor error: Unable to resolve address 'session' service '16514': No address associated with hostname If you already know that the standard qemu URI has 3 slashes, that error will make it obvious enough. But new user's may not get it. There's even a RHEL support page explicitly mentioning it!: https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/ht… Catch this error early in libvirt.c virConnectOpen for qemu (and vbox which has similar rules https://bugzilla.redhat.com/show_bug.cgi?id=1038304 --- src/libvirt.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/src/libvirt.c b/src/libvirt.c index a21d00e..7607ae3 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -928,6 +928,33 @@ virConnectGetDefaultURI(virConfPtr conf, } +/* + * Check to see if an invalid URI like qemu://system (missing /) was passed, + * offer the suggested fix. + */ +static int +check_uri_missing_slash(const char *uristr, virURIPtr uri) +{ + /* These drivers _only_ accepts URIs with a 'path' element */ + if (STRNEQ(uri->scheme, "qemu") && + STRNEQ(uri->scheme, "vbox")) + return 0; + + if (uri->path != NULL) + return 0; + + if (STREQ(uri->server, "session") || + STREQ(uri->server, "system")) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("invalid URI %s (maybe you want %s:///%s)"), + uristr, uri->scheme, uri->server); + return -1; + } + + return 0; +} + + static virConnectPtr do_open(const char *name, virConnectAuthPtr auth, @@ -995,6 +1022,11 @@ do_open(const char *name, NULLSTR(ret->uri->user), ret->uri->port, NULLSTR(ret->uri->path)); + if (check_uri_missing_slash(alias ? alias : name, ret->uri) < 0) { + VIR_FREE(alias); + goto failed; + } + VIR_FREE(alias); } else { VIR_DEBUG("no name, allowing driver auto-select"); -- 2.7.3

3 4

[libvirt] [libvirt-php][PATCH 0/3] Couple of small fixes
by Michal Privoznik 19 Apr '16

19 Apr '16

While playing with our php bindings I've noticed couple of memory leaks mostly. And one bug in our examples. Michal Privoznik (3): examples: Check properly if connected Fix some leaks related to get_string_from_xpath Revisit some VIRT_RETURN_STRING examples/index.php | 4 +- src/libvirt-php.c | 121 ++++++++++++++++++++++++++++++----------------------- 2 files changed, 72 insertions(+), 53 deletions(-) -- 2.7.3

4 13

[libvirt] RFC: Drop unmaintained hv drivers? (phyp, xenapi, hyperv)
by Cole Robinson 19 Apr '16

19 Apr '16

Hi all, There's a few old hypervisor drivers in the tree that haven't been actively maintained for a long time. I'm curious if anyone knows of these drivers being actively used. If not I think we should consider dropping them src/phyp/ : for power VM hypervisor. Added in July 2009. The last commit that looks like it wasn't either internal API conversion, or caught by code analysis, is: commit 41461ff7f7d6ee6679aae2a8004e305c5830c9e8 Author: Eduardo Otubo <otubo(a)linux.vnet.ibm.com> Date: Tue Apr 19 12:34:08 2011 -0300 PHYP: Adding reboot domain function Adding reboot <domain> function for pHyp driver. Nearly 5 years ago. Eduardo is the primary driver author too (CCd at his email from github). Searching the upstream bug tracker for all bugs with 'phyp', the only one that's actually about the phyp driver is a report from 2 years ago that it crashes trying to open a connection: https://bugzilla.redhat.com/show_bug.cgi?id=1093094 src/xenapi/: Connecting to a xen api server. Added in March 2010. Largely appears to be a code drop, the original author/committer has never had another commit. The last xenapi specific commit seems to be: commit 484460ec4678a264c5e7355495c2f0da72cb42bd Author: Matthias Bolte <matthias.bolte(a)googlemail.com> Date: Thu Jul 21 15:16:11 2011 +0200 xenapi: Improve error reporting in xenapiOpen once again Nearly 5 years ago. The only upstream bug that was filed about xenapi is: https://bugzilla.redhat.com/show_bug.cgi?id=711372 Which was about a connection failure that was eventually fixed upstream, and dovetailed into the above referenced commit. Current xen guys, you know of anyone using this? src/hyperv/: Added in July 2011. This was largely a code drop as well; committed and patched a few times by Matthias but it was a university project by someone else. Last hyperv targeted patch was: commit 9e9ea3ead9825bd1dc2c17cea4abc8c4165591d0 Author: Matthias Bolte <matthias.bolte(a)googlemail.com> Date: Sun Sep 9 17:39:40 2012 +0200 hyperv: Fix and improve hypervListAllDomains The driver is fairly minimal as well: it can only list existing VMs and perform lifecycle operations. It can't create new VMs, and doesn't list VM device config AFAICT. Also, in general, I've never heard about anyone _actually_ using any of those drivers in the wild. There's reports here and there but it mostly sounds like people trying them out. Just an anecdote so take it with a grain of salt - Cole

4 7

[libvirt] [PATCH] network: Add support for dhcp-range lease time in the network XML configuration format and dnsmasq
by Alberto Ruiz 19 Apr '16

19 Apr '16

Hello, I've been asked to send this patch to the list for review which I originally posted at rhbz#913446 [0]. My main motivation is to be able to set a saner default for dhcp leases in Boxes for development machines where the instant volatility of the dhcp lease makes it impossible to reliably work with services after the machines have to be rebooted. One has to discover the ip again... setup ssh keys... This patch is a first attempt so feel free to let me know if I'm aiming at the right direction. Thanks! [0]https://bugzilla.redhat.com/show_bug.cgi?id=913446 -- Alberto Ruiz Associate Engineering Manager - Desktop Management Tools Red Hat

3 4

[libvirt] how does the qemu command line executed by libvirt?
by zhukaijie 19 Apr '16

19 Apr '16

As you know, libvirt takes advantage of xml and generate corresponding qemu command line. But how does this command line executed? Does it executed in bash shell? Or any other api is used to create the qemu process? Thank you.

2 1

[libvirt] [PATCH] qemu: command: drop redundant min_guarantee check
by Cole Robinson 19 Apr '16

19 Apr '16

We already reject a VM with min_guarantee early in the VM startup in qemuProcessStartValidate --- src/qemu/qemu_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 26c19ff..2fb967a 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -9143,7 +9143,6 @@ qemuBuildCommandLineValidate(virQEMUDriverPtr driver, if (virMemoryLimitIsSet(def->mem.hard_limit) || virMemoryLimitIsSet(def->mem.soft_limit) || - def->mem.min_guarantee || virMemoryLimitIsSet(def->mem.swap_hard_limit)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Memory tuning is not available in session mode")); -- 2.7.3

2 1

[libvirt] [libvirt-php PATCH 00/29] Add PHP7 support and unit tests V2
by Neal Gompa 19 Apr '16

19 Apr '16

This patch set is a revision of the first version, taking into account some of the feedback from Michal Privoznik. I've done some patch surgery to rebase the patch set on the current git HEAD, so it should cleanly apply as-is. Additionally, I've squashed a few commits (mainly some of Remi's patches that were squashable that should be squashed). This means that Vasiliy's patches are no longer unnecessarily part of this patch set. I've updated my patches for the instructions on the php extension build system method to correct a typo on how to run the tests (`make test` instead of `make tests`) and removed the "-dev" suffix that Remi attached to the version string in libvirt-php.h, as I expect that there will likely be a libvirt-php release after this patch set is merged. I would greatly appreciate a quick review and merge of this patch set. Chuck Roydhouse (1): add arginfo for libvirt_domain_block_commit and libvirt_domain_block_job_info Frederic Mora (1): Add more tests Neal Gompa (2): Commit short instructions to using the php extension build method Bump version to 0.5.2 Remi Collet (25): add config.m4 to allow standard PHP extension build system include config.h earlier add missing arginfo adapt RETURN_STRING work on zpp register + fetch resources + hash adapt add_assoc_string_ex clean ALLOC_INIT_ZVAL zend_hash_update add_next_index_string buildable with PHP 7 bump version 0.5.2-dev fix missed (hidden) zpp calls fix PHP 5 compat fix libvirt_version + add test port test-connect.phpt to real phpt Switch all add_assoc_string_ex to add_assoc_string to avoid nul char management Fix max_connections management add test-conn-limit.phpt (as real phpt) add test-connect-get-emulator.phpt fix parse_array + build warnings convert test-install.phpt to real phpt convert test-domain-create-and-coredump.phpt to real phpt convert test-domain-create-and-get-xpath.phpt to real phpt fix PHP 5 compat again (nested macro issue) INSTALL.PHPEXT | 14 + configure.ac | 2 +- src/config.m4 | 52 + src/libvirt-php.c | 1796 ++++++++++++++++------- src/libvirt-php.h | 48 +- src/tests/example-no-disk-and-media.xml | 41 + src/tests/qemu-no-disk-and-media.xml | 41 + src/tests/skipif.inc | 3 + src/tests/test-conn-limit.phpt | 49 + src/tests/test-connect-get-capabilities.phpt | 27 + src/tests/test-connect-get-emulator.phpt | 15 + src/tests/test-connect-get-info.phpt | 110 ++ src/tests/test-connect-get-machine-types.phpt | 30 + src/tests/test-connect.phpt | 15 + src/tests/test-domain-create-and-coredump.phpt | 49 + src/tests/test-domain-create-and-get-xpath.phpt | 56 + src/tests/test-domain-create-and-shutdown.phpt | 38 + src/tests/test-domain-define.phpt | 38 + src/tests/test-domain-disk.phpt | 71 + src/tests/test-domain-get.phpt | 91 ++ src/tests/test-domain-lookup-by-name.phpt | 35 + src/tests/test-domain-nic.phpt | 52 + src/tests/test-install.phpt | 136 ++ src/tests/test-libvirt-php.img | 0 src/tests/test-logfile.phpt | 43 + src/tests/test-version-get.phpt | 27 + 26 files changed, 2330 insertions(+), 549 deletions(-) create mode 100644 INSTALL.PHPEXT create mode 100644 src/config.m4 create mode 100644 src/tests/example-no-disk-and-media.xml create mode 100644 src/tests/qemu-no-disk-and-media.xml create mode 100644 src/tests/skipif.inc create mode 100644 src/tests/test-conn-limit.phpt create mode 100644 src/tests/test-connect-get-capabilities.phpt create mode 100644 src/tests/test-connect-get-emulator.phpt create mode 100644 src/tests/test-connect-get-info.phpt create mode 100644 src/tests/test-connect-get-machine-types.phpt create mode 100644 src/tests/test-connect.phpt create mode 100644 src/tests/test-domain-create-and-coredump.phpt create mode 100644 src/tests/test-domain-create-and-get-xpath.phpt create mode 100644 src/tests/test-domain-create-and-shutdown.phpt create mode 100644 src/tests/test-domain-define.phpt create mode 100644 src/tests/test-domain-disk.phpt create mode 100644 src/tests/test-domain-get.phpt create mode 100644 src/tests/test-domain-lookup-by-name.phpt create mode 100644 src/tests/test-domain-nic.phpt create mode 100644 src/tests/test-install.phpt create mode 100644 src/tests/test-libvirt-php.img create mode 100644 src/tests/test-logfile.phpt create mode 100644 src/tests/test-version-get.phpt -- 2.5.5

4 41