- Devel - libvirt List Archives

[libvirt] [PATCH] conf: limit chassisNr, and busNr to a minimum value of 1, not 0
by Laine Stump 21 Jun '16

21 Jun '16

In the case of chassisNr (used to set chassis_nr of a pci-bridge controller), 0 is reserved for / used by the pci[e]-root bus. In the base of busNr, a value of 0 would mean that the root bus had no places available to plug in new buses, including the pxb itself (the documentation I wrote for pxb even noted the limit of busNr as 1.254). NB: oddly, the "chassis" attribute, which is used for pcie-root-port and pcie-switch-downstream-port *can* be set to 0, since it's the combination of {chassis, slot} that needs to be unique, not chassis by itself (and slot 0 of pcie-root is reserved, while pcie-*-port can use *only* slot 0). This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1342962 --- docs/formatdomain.html.in | 2 +- src/conf/domain_conf.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index d181ffa..88db3bc 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3277,7 +3277,7 @@ control QEMU's "chassis_nr" option for the pci-bridge device (normally libvirt automatically sets this to the same value as the index attribute of the pci controller). If set, chassisNr - must be between 0 and 255. + must be between 1 and 255. </dd> <dt><code>chassis</code></dt> <dd> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 23ca236..9a6610b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8426,11 +8426,11 @@ virDomainControllerDefParseXML(xmlNodePtr node, chassisNr); goto error; } - if (def->opts.pciopts.chassisNr < 0 || + if (def->opts.pciopts.chassisNr < 1 || def->opts.pciopts.chassisNr > 255) { virReportError(VIR_ERR_XML_ERROR, _("PCI controller chassisNr '%s' out of range " - "- must be 0-255"), + "- must be 1-255"), chassisNr); goto error; } @@ -8477,11 +8477,11 @@ virDomainControllerDefParseXML(xmlNodePtr node, busNr); goto error; } - if (def->opts.pciopts.busNr < 0 || + if (def->opts.pciopts.busNr < 1 || def->opts.pciopts.busNr > 254) { virReportError(VIR_ERR_XML_ERROR, _("PCI controller busNr '%s' out of range " - "- must be 0-254"), + "- must be 1-254"), busNr); goto error; } -- 2.5.5

2 1

[libvirt] [PATCH 1/1] perf: add more perf events support
by Qiaowei Ren 21 Jun '16

21 Jun '16

With current perf framework, this patch adds support to more perf events, including cache missing, cache peference, cpu cycles, instrction, etc.. Signed-off-by: Qiaowei Ren <qiaowei.ren(a)intel.com> --- include/libvirt/libvirt-domain.h | 39 ++++++++++++++++++++++++ src/libvirt-domain.c | 8 +++++ src/qemu/qemu_driver.c | 23 +++++++------- src/util/virperf.c | 65 +++++++++++++++++++++++++++++++++++++++- src/util/virperf.h | 4 +++ 5 files changed, 126 insertions(+), 13 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index cba4fa5..99c4c48 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1928,6 +1928,45 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats); */ # define VIR_PERF_PARAM_MBML "mbml" +/** + * VIR_PERF_PARAM_CACHE_MISSES: + * + * Macro for typed parameter name that represents cache_misses perf + * event which can be used to measure the amount of cache missing by + * applications running on the platform. It corresponds to the + * "perf.cache_misses" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_CACHE_MISSES "cache_misses" + +/** + * VIR_PERF_PARAM_CACHE_REFERENCES: + * + * Macro for typed parameter name that represents cache_peferences + * perf event which can be used to measure the amount of cache hit + * by applications running on the platform. It corresponds to the + * "perf.cache_peferences" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_CACHE_REFERENCES "cache_peferences" + +/** + * VIR_PERF_PARAM_INSTRUCTIONS: + * + * Macro for typed parameter name that represents instructions perf + * event which can be used to measure the amount of instructions + * by applications running on the platform. It corresponds to the + * "perf.instructions" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_INSTRUCTIONS "instructions" + +/** + * VIR_PERF_PARAM_CPU_CYCLES: + * + * Macro for typed parameter name that represents cpu_cycles perf event + * which can be used to measure how many cycles one instruction needs. + * It corresponds to the "perf.cpu_cycles" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_CPU_CYCLES "cpu_cycles" + int virDomainGetPerfEvents(virDomainPtr dom, virTypedParameterPtr *params, int *nparams, diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 73ae369..ef71b31 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11452,6 +11452,14 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * "perf.mbml" - the amount of data (bytes/s) sent through the memory controller * on the socket as unsigned long long. It is produced by mbml * perf event. + * "perf.cache_misses" - the amount of cache missing as unsigned long long. + * It is produced by cache_misses perf event. + * "perf.cache_peferences" - the amount of cache hit as unsigned long long. + * It is produced by cache_peferences perf event. + * "perf.instructions" - the amount of instructions as unsigned long long. + * It is produced by instructions perf event. + * "perf.cpu_cycles" - the amount of cycles one instruction needs as unsigned + * long long. It is produced by cpu_cycles perf event. * * Note that entire stats groups or individual stat fields may be missing from * the output in case they are not supported by the given hypervisor, are not diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 10d3e3d..d465ec5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9756,6 +9756,10 @@ qemuDomainSetPerfEvents(virDomainPtr dom, VIR_PERF_PARAM_CMT, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_MBMT, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_MBML, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CACHE_MISSES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CACHE_REFERENCES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_INSTRUCTIONS, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CPU_CYCLES, VIR_TYPED_PARAM_BOOLEAN, NULL) < 0) return -1; @@ -19071,10 +19075,10 @@ qemuDomainGetStatsBlock(virQEMUDriverPtr driver, #undef QEMU_ADD_COUNT_PARAM static int -qemuDomainGetStatsPerfRdt(virPerfPtr perf, - virPerfEventType type, - virDomainStatsRecordPtr record, - int *maxparams) +qemuDomainGetStatsPerfOneEvent(virPerfPtr perf, + virPerfEventType type, + virDomainStatsRecordPtr record, + int *maxparams) { char param_name[VIR_TYPED_PARAM_FIELD_LENGTH]; uint64_t value = 0; @@ -19110,14 +19114,9 @@ qemuDomainGetStatsPerf(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, if (!virPerfEventIsEnabled(priv->perf, i)) continue; - switch (i) { - case VIR_PERF_EVENT_CMT: - case VIR_PERF_EVENT_MBMT: - case VIR_PERF_EVENT_MBML: - if (qemuDomainGetStatsPerfRdt(priv->perf, i, record, maxparams) < 0) - goto cleanup; - break; - } + if (qemuDomainGetStatsPerfOneEvent(priv->perf, i, + record, maxparams) < 0) + goto cleanup; } ret = 0; diff --git a/src/util/virperf.c b/src/util/virperf.c index 450b3ba..38f2158 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -38,7 +38,9 @@ VIR_LOG_INIT("util.perf"); #define VIR_FROM_THIS VIR_FROM_PERF VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST, - "cmt", "mbmt", "mbml"); + "cmt", "mbmt", "mbml", + "cache_misses", "cache_peferences", + "instructions", "cpu_cycles"); struct virPerfEvent { int type; @@ -186,6 +188,60 @@ virPerfRdtEnable(virPerfEventPtr event, return -1; } +static int +virPerfGeneralEnable(virPerfEventPtr event, + pid_t pid) +{ + struct perf_event_attr attr; + + memset(&attr, 0, sizeof(attr)); + attr.size = sizeof(attr); + attr.inherit = 1; + attr.disabled = 1; + attr.enable_on_exec = 0; + + switch (event->type) { + case VIR_PERF_EVENT_CACHE_MISSES: + attr.type = PERF_TYPE_HARDWARE; + attr.config = PERF_COUNT_HW_CACHE_MISSES; + break; + case VIR_PERF_EVENT_CACHE_REFERENCES: + attr.type = PERF_TYPE_HARDWARE; + attr.config = PERF_COUNT_HW_CACHE_REFERENCES; + break; + case VIR_PERF_EVENT_INSTRUCTIONS: + attr.type = PERF_TYPE_HARDWARE; + attr.config = PERF_COUNT_HW_INSTRUCTIONS; + break; + case VIR_PERF_EVENT_CPU_CYCLES: + attr.type = PERF_TYPE_HARDWARE; + attr.config = PERF_COUNT_HW_CPU_CYCLES; + break; + } + + event->fd = syscall(__NR_perf_event_open, &attr, pid, -1, -1, 0); + if (event->fd < 0) { + virReportSystemError(errno, + _("Unable to open perf event for %s"), + virPerfEventTypeToString(event->type)); + goto error; + } + + if (ioctl(event->fd, PERF_EVENT_IOC_ENABLE) < 0) { + virReportSystemError(errno, + _("Unable to enable perf event for %s"), + virPerfEventTypeToString(event->type)); + goto error; + } + + event->enabled = true; + return 0; + + error: + VIR_FORCE_CLOSE(event->fd); + return -1; +} + int virPerfEventEnable(virPerfPtr perf, virPerfEventType type, @@ -202,6 +258,13 @@ virPerfEventEnable(virPerfPtr perf, if (virPerfRdtEnable(event, pid) < 0) return -1; break; + case VIR_PERF_EVENT_CACHE_MISSES: + case VIR_PERF_EVENT_CACHE_REFERENCES: + case VIR_PERF_EVENT_INSTRUCTIONS: + case VIR_PERF_EVENT_CPU_CYCLES: + if (virPerfGeneralEnable(event, pid) < 0) + return -1; + break; case VIR_PERF_EVENT_LAST: virReportError(VIR_ERR_INTERNAL_ERROR, _("Unexpected perf event type=%d"), type); diff --git a/src/util/virperf.h b/src/util/virperf.h index 769e85a..2cab339 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -28,6 +28,10 @@ typedef enum { VIR_PERF_EVENT_CMT, VIR_PERF_EVENT_MBMT, VIR_PERF_EVENT_MBML, + VIR_PERF_EVENT_CACHE_MISSES, + VIR_PERF_EVENT_CACHE_REFERENCES, + VIR_PERF_EVENT_INSTRUCTIONS, + VIR_PERF_EVENT_CPU_CYCLES, VIR_PERF_EVENT_LAST } virPerfEventType; -- 1.9.1

3 7

[libvirt] [PATCH] storage: Fix several issues with transient pool cleanup
by Jovanka Gulicoska 20 Jun '16

20 Jun '16

There are several cases where we do not handle transient pool destroy and cleanup correctly. For example: https://bugzilla.redhat.com/show_bug.cgi?id=1227475 Move the pool cleanup logic to a new function storagePoolSetInactive and use it consistently. --- src/storage/storage_driver.c | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index e2d729f..74af35d 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -77,6 +77,21 @@ static void storageDriverUnlock(void) } static void +storagePoolSetInactive(virStoragePoolObjPtr pool) +{ + pool->active = false; + + if (pool->configFile == NULL) { + virStoragePoolObjRemove(&driver->pools, pool); + pool = NULL; + } else if (pool->newDef) { + virStoragePoolDefFree(pool->def); + pool->def = pool->newDef; + pool->newDef = NULL; + } +} + +static void storagePoolUpdateState(virStoragePoolObjPtr pool) { bool active; @@ -143,6 +158,7 @@ storagePoolUpdateAllState(void) virStoragePoolObjPtr pool = driver->pools.objs[i]; virStoragePoolObjLock(pool); + storagePoolSetInactive(pool); storagePoolUpdateState(pool); virStoragePoolObjUnlock(pool); } @@ -198,6 +214,7 @@ storageDriverAutostart(void) unlink(stateFile); if (backend->stopPool) backend->stopPool(conn, pool); + storagePoolSetInactive(pool); virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to autostart storage pool '%s': %s"), pool->def->name, virGetLastErrorMessage()); @@ -737,7 +754,7 @@ storagePoolCreateXML(virConnectPtr conn, unlink(stateFile); if (backend->stopPool) backend->stopPool(conn, pool); - virStoragePoolObjRemove(&driver->pools, pool); + storagePoolSetInactive(pool); pool = NULL; goto cleanup; } @@ -1068,16 +1085,7 @@ storagePoolDestroy(virStoragePoolPtr obj) VIR_STORAGE_POOL_EVENT_STOPPED, 0); - pool->active = false; - - if (pool->configFile == NULL) { - virStoragePoolObjRemove(&driver->pools, pool); - pool = NULL; - } else if (pool->newDef) { - virStoragePoolDefFree(pool->def); - pool->def = pool->newDef; - pool->newDef = NULL; - } + storagePoolSetInactive(pool); ret = 0; @@ -1197,13 +1205,7 @@ storagePoolRefresh(virStoragePoolPtr obj, pool->def->uuid, VIR_STORAGE_POOL_EVENT_STOPPED, 0); - pool->active = false; - - if (pool->configFile == NULL) { - virStoragePoolObjRemove(&driver->pools, pool); - pool = NULL; - } - goto cleanup; + storagePoolSetInactive(pool); } event = virStoragePoolEventLifecycleNew(pool->def->name, -- 2.5.5

2 1

[libvirt] [PATCH] virsh: introduce name-uuid for list command
by Chen Hanxiao 20 Jun '16

20 Jun '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> This patch will show both name and UUID of domain: Id Name State UUID --------------------------------------------------------------------------------------- 3 f23 running 918f1dd6-b19f-412b-ba17-d113bad89af8 Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- tools/virsh-domain-monitor.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 0a93949..32e4ea4 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -1793,6 +1793,10 @@ static const vshCmdOptDef opts_list[] = { .type = VSH_OT_BOOL, .help = N_("show domain title") }, + {.name = "name-uuid", + .type = VSH_OT_BOOL, + .help = N_("show domain name and uuid") + }, {.name = NULL} }; @@ -1807,6 +1811,7 @@ cmdList(vshControl *ctl, const vshCmd *cmd) bool optTable = vshCommandOptBool(cmd, "table"); bool optUUID = vshCommandOptBool(cmd, "uuid"); bool optName = vshCommandOptBool(cmd, "name"); + bool optNameUuid = vshCommandOptBool(cmd, "name-uuid"); size_t i; char *title; char uuid[VIR_UUID_STRING_BUFLEN]; @@ -1844,10 +1849,10 @@ cmdList(vshControl *ctl, const vshCmd *cmd) FILTER("state-shutoff", VIR_CONNECT_LIST_DOMAINS_SHUTOFF); FILTER("state-other", VIR_CONNECT_LIST_DOMAINS_OTHER); - if (optTable + optName + optUUID > 1) { + if (optTable + optName + optUUID + optNameUuid > 1) { vshError(ctl, "%s", - _("Only one argument from --table, --name and --uuid " - "may be specified.")); + _("Only one argument from --table, --name, --uuid " + "and --name-uuid may be specified.")); return false; } @@ -1864,6 +1869,12 @@ cmdList(vshControl *ctl, const vshCmd *cmd) _("Id"), _("Name"), _("State"), _("Title"), "-----------------------------------------" "-----------------------------------------"); + else if (optNameUuid) + vshPrintExtra(ctl, " %-5s %-30s %-10s %-36s\n%s\n", + _("Id"), _("Name"), _("State"), _("UUID"), + "-----------------------------------------" + "-----------------------------------------" + "----"); else vshPrintExtra(ctl, " %-5s %-30s %s\n%s\n", _("Id"), _("Name"), _("State"), @@ -1901,6 +1912,16 @@ cmdList(vshControl *ctl, const vshCmd *cmd) title); VIR_FREE(title); + } else if (optNameUuid) { + if (virDomainGetUUIDString(dom, uuid) < 0) { + vshError(ctl, "%s", _("Failed to get domain's UUID")); + goto cleanup; + } + vshPrint(ctl, " %-5s %-30s %-10s %-36s\n", id_buf, + virDomainGetName(dom), + state == -2 ? _("saved") + : virshDomainStateToString(state), + uuid); } else { vshPrint(ctl, " %-5s %-30s %s\n", id_buf, virDomainGetName(dom), -- 1.8.3.1

4 6

[libvirt] [PATCH v3 0/4] util: Make failure to get supplementary groups non-fatal
by Peter Krempa 20 Jun '16

20 Jun '16

Changes: - New patches fixing few problems in virt-login-shell found while modifying the original patch. - split out addition of @quiet - rest of review feedback Peter Krempa (4): tools: virt-login-shell: Fix group list bounds checking tools: virt-login-shell: Fix cut'n'paste mistake in error message util: Add option not to report errors in virGetUserEnt util: Make failure to get supplementary group list for a uid non-fatal src/util/virutil.c | 49 ++++++++++++++++++++++++++++-------------------- tools/virt-login-shell.c | 9 +++++---- 2 files changed, 34 insertions(+), 24 deletions(-) -- 2.8.3

3 8

[libvirt] [PATCH 0/6] Remove 'make check' heating
by Ján Tomko 20 Jun '16

20 Jun '16

https://xkcd.com/1172/ Ján Tomko (6): Remove virsh-all tests: mock gnutls_dh_params_generate2 Introduce virsh self-test Remove virsh-synopsis Drop virrandomtest Mark virsh-optparse as expensive .gitignore | 1 + tests/Makefile.am | 8 +--- tests/virnettlscontexttest.c | 2 +- tests/virnettlssessiontest.c | 2 +- tests/virrandommock.c | 51 +++++++++++++++++++++ tests/virrandomtest.c | 86 ------------------------------------ tests/virsh-optparse | 2 + tests/{virsh-all => virsh-self-test} | 31 ++++--------- tests/virsh-synopsis | 44 ------------------ tools/virsh.c | 50 +++++++++++++++++++++ 10 files changed, 115 insertions(+), 162 deletions(-) delete mode 100644 tests/virrandomtest.c rename tests/{virsh-all => virsh-self-test} (54%) delete mode 100755 tests/virsh-synopsis -- 2.7.3

2 12

[libvirt] [PATCH 0/2] Fix leak and labels in virDomainGraphicsListensParseXML
by Peter Krempa 20 Jun '16

20 Jun '16

Peter Krempa (2): conf: Fix memory leak in graphics XML parser conf: Fix label name in virDomainGraphicsListensParseXML src/conf/domain_conf.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.8.3

2 3

[libvirt] [PATCH v2 0/7] Redirdev attach & detach
by Michal Privoznik 20 Jun '16

20 Jun '16

v2 of: https://www.redhat.com/archives/libvir-list/2016-June/msg00615.html diff to v1: - Peter's review worked in - Pushed ACKed patches - Found one silly bug (patch 7/7) Michal Privoznik (7): domain_conf: Validate redirdev after parsing virDomainRedirdevDef: Introduce find & remove routines virDomainDeviceInfoIterateInternal: Iterate through redirdevs too qemuDomainAttachDeviceConfig: Allow redirdev coldplug qemuDomainDetachDeviceConfig: Allow cold unplug of redirdevs qemuDomainRemoveDevice: Enable live redirdev detach qemuDomainDetachDeviceFlags: Pass live device XML to live detach code src/conf/domain_conf.c | 105 ++++++++++++++++++++++++++++++++++++----------- src/conf/domain_conf.h | 4 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 35 ++++++++++++---- src/qemu/qemu_hotplug.c | 76 +++++++++++++++++++++++++++++++++- src/qemu/qemu_hotplug.h | 3 ++ 6 files changed, 193 insertions(+), 32 deletions(-) -- 2.8.4

3 16

[libvirt] gnulib and 32-bit libvirt build, rpl_canonicalize_file_name
by Ian Jackson 20 Jun '16

20 Jun '16

The Xen Project's automated test (CI) system has reported a build failure in libvirt; libvirt uses gnulib. osstest has bisected it to a specific gnulib commit. (Email from osstest is quoted below.) The error message is: ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function `rpl_canonicalize_file_name': /home/osstest/build.95966.build-i386-libvirt/libvirt/gnulib/lib/canonicalize-lgpl.c:400: multiple definition of `rpl_canonicalize_file_name' .libs/virpcimock_la-virpcimock.o:/home/osstest/build.95966.build-i386-libvirt/libvirt/tests/virpcimock.c:954: first defined here collect2: error: ld returned 1 exit status Do you already know about this ? Would you like us to submit a patch to gnulib ? Thanks, Ian. osstest service owner writes ("[qemu-upstream-4.3-testing bisection] complete build-i386-libvirt"): > branch xen-4.3-testing > xenbranch xen-4.3-testing > job build-i386-libvirt > testid libvirt-build > > Tree: libvirt git://xenbits.xen.org/libvirt.git > Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git > Tree: qemuu git://xenbits.xen.org/qemu-xen.git > Tree: xen git://xenbits.xen.org/xen.git > > *** Found and reproduced problem changeset *** > > Bug is in tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Bug introduced: 54615b95ff238e235e806855efc46a9abad09f2e > Bug not present: e78f894d0bdc770101bc040613f4ea94e45f38f7 > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/95966/ > > > commit 54615b95ff238e235e806855efc46a9abad09f2e > Author: Paul Eggert <eggert(a)cs.ucla.edu> > Date: Sat Feb 6 18:11:48 2016 -0800 > > misc: port better to gcc -fsanitize=address > > Without these patches, ./configure CFLAGS='-fsanitize=address' > would compute incorrect values. This patch fixes some (but not all) > test failures with recent glibc, with this configuration. > * m4/acl.m4 (gl_ACL_GET_FILE): > * m4/calloc.m4 (_AC_FUNC_CALLOC_IF): > * m4/canonicalize.m4 (gl_FUNC_REALPATH_WORKS): > * m4/d-ino.m4 (gl_CHECK_TYPE_STRUCT_DIRENT_D_INO): > * m4/duplocale.m4 (gl_FUNC_DUPLOCALE): > * m4/getcwd.m4 (gl_FUNC_GETCWD_NULL): > * m4/getdelim.m4 (gl_FUNC_GETDELIM): > * m4/getgroups.m4 (gl_FUNC_GETGROUPS): > * m4/getline.m4 (gl_FUNC_GETLINE): > * m4/malloc.m4 (_AC_FUNC_MALLOC_IF): > * m4/realloc.m4 (_AC_FUNC_REALLOC_IF): > * m4/regex.m4 (gl_REGEX): > * m4/strndup.m4 (gl_FUNC_STRNDUP): > * tests/test-calloc-gnu.c (main): > * tests/test-duplocale.c (main): > * tests/test-getgroups.c (main): > * tests/test-getline.c (main): > * tests/test-inttostr.c (main): > * tests/test-localename.c (test_locale_name) > (test_locale_name_thread, test_locale_name_environ) > (test_locale_name_default): > * tests/test-regex.c (main): > * tests/test-setlocale1.c (main): > * tests/test-stat.h (test_stat_func): > Free heap-allocated storage before exiting. > * m4/asm-underscore.m4 (gl_ASM_SYMBOL_PREFIX): > Don't match *_foo symbols inserted by AddressSanitizer. > * tests/test-regex.c, tests/test-stat.c: Include stdlib.h, for 'free'. > > > For bisection revision-tuple graph see: > http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-upstream-4.… > Revision IDs in each graph node refer, respectively, to the Trees above. > > ---------------------------------------- > Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-upstream-4.3-testing/build-i386-libvirt.libvirt-build --summary-out=tmp/95966.bisection-summary --basis-template=80927 --blessings=real,real-bisect qemu-upstream-4.3-testing build-i386-libvirt libvirt-build > Searching for failure / basis pass: > 95930 fail [host=fiano0] / 80927 [host=pinot1] 80730 [host=baroque0] 77983 [host=pinot0] 77930 [host=italia0] 77853 [host=italia1] 62112 [host=nocera1] 62045 [host=nocera1] 61805 [host=nocera1] 61729 [host=nocera0] 61620 [host=pinot1] 60903 [host=nocera1] 60700 [host=nocera0] 60676 [host=nocera0] 60159 [host=italia1] 58381 [host=pinot1] 57828 [host=nocera0] 56721 [host=nocera1] 56679 [host=nocera0] 56637 [host=nocera1] 56604 [host=nocera1] 56583 [host=italia1] 56556 [host=nocera0] 56506 [host=nocera1] 56427 [host=nocera1] 56373 [host=nocera0] 55875 [host=nocera1] 50282 [host=fiano1] 36518 [host=scape-moth] 31652 [host=lace-bug] template as basis? using template as basis. > Failure / basis pass flights: 95930 / 80927 > (tree with no url: seabios) > Tree: libvirt git://xenbits.xen.org/libvirt.git > Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git > Tree: qemuu git://xenbits.xen.org/qemu-xen.git > Tree: xen git://xenbits.xen.org/xen.git > Latest eac167e2610d3e59b32f7ec7ba78cbc8c420a425 246b3b28808ee5f4664be674dce573af9497fc7a b96625e17169a7958575c2fb41499bb9ea2c212e 12e8fccf5b5460be7aecddc71d27eceaba6e1f15 8fa31952e2d08ef63897c43b5e8b33475ebf5d93 > Basis pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 6cc32c63e80bc1a30c521b2f07f2b54909b59892 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7-… git://git.sv.gnu.org/gnulib.git#6cc32c63e80bc1a30c521b2f07f2b54909b59892-24… git://xenbits.xen.org/qemu-xen-traditional.git#b96625e17169a7958575c2fb4149… git://xenbits.xen.org/qemu-xen.git#10c1b763c26feb645627a1639e722515f3e1e876… git://xenbits.xen.org/xen.git#ac0cc84d7bdfc111d47236356e5d06b5681a1dd6-8fa3… > adhoc-revtuple-generator: tree discontiguous: libvirt > Loaded 12327 nodes in revision graph > Searching for test results: > 80730 [host=baroque0] > 80927 [host=pinot1] > 95874 fail irrelevant > 95911 fail irrelevant > 95852 fail irrelevant > 95895 fail irrelevant > 95954 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 7ac276b42cbeb648c6b11e5637b2b05be951fd6d b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95928 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 6cc32c63e80bc1a30c521b2f07f2b54909b59892 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95957 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 e78f894d0bdc770101bc040613f4ea94e45f38f7 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95934 fail irrelevant > 95959 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 54615b95ff238e235e806855efc46a9abad09f2e b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95938 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 6cc32c63e80bc1a30c521b2f07f2b54909b59892 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95941 fail irrelevant > 95960 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 e78f894d0bdc770101bc040613f4ea94e45f38f7 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95943 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 fa2329eeae5ae80d0630f493b029297406b47237 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 404e83e055cb419efccbcb0c5c89476307a9ae46 > 95930 fail eac167e2610d3e59b32f7ec7ba78cbc8c420a425 246b3b28808ee5f4664be674dce573af9497fc7a b96625e17169a7958575c2fb41499bb9ea2c212e 12e8fccf5b5460be7aecddc71d27eceaba6e1f15 8fa31952e2d08ef63897c43b5e8b33475ebf5d93 > 95946 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 2b34f389a8a9a6ebfd514560369d91c9f6de7751 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95962 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 54615b95ff238e235e806855efc46a9abad09f2e b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95949 fail eac167e2610d3e59b32f7ec7ba78cbc8c420a425 246b3b28808ee5f4664be674dce573af9497fc7a b96625e17169a7958575c2fb41499bb9ea2c212e 12e8fccf5b5460be7aecddc71d27eceaba6e1f15 8fa31952e2d08ef63897c43b5e8b33475ebf5d93 > 95965 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 e78f894d0bdc770101bc040613f4ea94e45f38f7 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95950 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 cd9ecca8812571fc443688d11148f2768ededfa4 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95953 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 cd6a45292cdb7b3c4b628f1cb0f199a02140ea7c b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95966 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 54615b95ff238e235e806855efc46a9abad09f2e b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > Searching for interesting versions > Result found: flight 95928 (pass), for basis pass > Result found: flight 95930 (fail), for basis failure > Repro found: flight 95938 (pass), for basis pass > Repro found: flight 95949 (fail), for basis failure > 0 revisions at 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 e78f894d0bdc770101bc040613f4ea94e45f38f7 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > No revisions left to test, checking graph state. > Result found: flight 95957 (pass), for last pass > Result found: flight 95959 (fail), for first failure > Repro found: flight 95960 (pass), for last pass > Repro found: flight 95962 (fail), for first failure > Repro found: flight 95965 (pass), for last pass > Repro found: flight 95966 (fail), for first failure > > *** Found and reproduced problem changeset *** > > Bug is in tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Bug introduced: 54615b95ff238e235e806855efc46a9abad09f2e > Bug not present: e78f894d0bdc770101bc040613f4ea94e45f38f7 > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/95966/ > > > commit 54615b95ff238e235e806855efc46a9abad09f2e > Author: Paul Eggert <eggert(a)cs.ucla.edu> > Date: Sat Feb 6 18:11:48 2016 -0800 > > misc: port better to gcc -fsanitize=address > > Without these patches, ./configure CFLAGS='-fsanitize=address' > would compute incorrect values. This patch fixes some (but not all) > test failures with recent glibc, with this configuration. > * m4/acl.m4 (gl_ACL_GET_FILE): > * m4/calloc.m4 (_AC_FUNC_CALLOC_IF): > * m4/canonicalize.m4 (gl_FUNC_REALPATH_WORKS): > * m4/d-ino.m4 (gl_CHECK_TYPE_STRUCT_DIRENT_D_INO): > * m4/duplocale.m4 (gl_FUNC_DUPLOCALE): > * m4/getcwd.m4 (gl_FUNC_GETCWD_NULL): > * m4/getdelim.m4 (gl_FUNC_GETDELIM): > * m4/getgroups.m4 (gl_FUNC_GETGROUPS): > * m4/getline.m4 (gl_FUNC_GETLINE): > * m4/malloc.m4 (_AC_FUNC_MALLOC_IF): > * m4/realloc.m4 (_AC_FUNC_REALLOC_IF): > * m4/regex.m4 (gl_REGEX): > * m4/strndup.m4 (gl_FUNC_STRNDUP): > * tests/test-calloc-gnu.c (main): > * tests/test-duplocale.c (main): > * tests/test-getgroups.c (main): > * tests/test-getline.c (main): > * tests/test-inttostr.c (main): > * tests/test-localename.c (test_locale_name) > (test_locale_name_thread, test_locale_name_environ) > (test_locale_name_default): > * tests/test-regex.c (main): > * tests/test-setlocale1.c (main): > * tests/test-stat.h (test_stat_func): > Free heap-allocated storage before exiting. > * m4/asm-underscore.m4 (gl_ASM_SYMBOL_PREFIX): > Don't match *_foo symbols inserted by AddressSanitizer. > * tests/test-regex.c, tests/test-stat.c: Include stdlib.h, for 'free'. > > pnmtopng: 226 colors found > Revision graph left in /home/logs/results/bisect/qemu-upstream-4.3-testing/build-i386-libvirt.libvirt-build.{dot,ps,png,html,svg}. > ---------------------------------------- > 95966: tolerable ALL FAIL > > flight 95966 qemu-upstream-4.3-testing real-bisect [real] > http://logs.test-lab.xenproject.org/osstest/logs/95966/ > > Failures :-/ but no regressions. > > Tests which did not succeed, > including tests which could not be run: > build-i386-libvirt 5 libvirt-build fail baseline untested > > > jobs: > build-i386-libvirt fail > > > ------------------------------------------------------------ > sg-report-flight on osstest.test-lab.xenproject.org > logs: /home/logs/logs > images: /home/logs/images > > Logs, config files, etc. are available at > http://logs.test-lab.xenproject.org/osstest/logs > > Explanation of these reports, and of osstest in general, is at > http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master > http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master > > Test harness code can be found at > http://xenbits.xen.org/gitweb?p=osstest.git;a=summary >

2 2

[libvirt] [PATCH] util: fix a typo
by Chen Hanxiao 20 Jun '16

20 Jun '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> s/succcess/success Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 9d460b9..f47bf39 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -406,7 +406,7 @@ int virFileLock(int fd, bool shared, off_t start, off_t len, bool waitForLock) * NB the lock will also be released if any open file descriptor * pointing to the same file as @fd is closed * - * Returns 0 on succcess, or -errno on error + * Returns 0 on success, or -errno on error */ int virFileUnlock(int fd, off_t start, off_t len) { -- 1.8.3.1

2 1