- Devel - libvirt List Archives

[libvirt] [PATCH v5 0/2] qemu: Support for QXL heads
by Martin Kletzander 31 May '16

31 May '16

v5: - Just a rebase, plus v4 had some hunk in that didn't belong there so this one's cleaner to look at - https://www.redhat.com/archives/libvir-list/2016-March/msg01436.html v4: - Added test case without "heads=" - Don't consolidate 'size_t i, j' declarations v3: - rebase on top of current master in order to cleanly apply - https://www.redhat.com/archives/libvir-list/2016-March/msg01198.html v2: - don't change heads when migrating - https://www.redhat.com/archives/libvir-list/2016-March/msg00811.html v1: - https://www.redhat.com/archives/libvir-list/2016-March/msg00410.html Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 Martin Kletzander (2): qemu: Check for qxl's max_outputs parameter qemu: Add support to QXL's max_outputs parameter src/qemu/qemu_capabilities.c | 5 ++ src/qemu/qemu_capabilities.h | 4 ++ src/qemu/qemu_command.c | 8 +++ src/qemu/qemu_migration.c | 64 ++++++++++++++++++++-- .../qemuxml2argv-video-qxl-heads.args | 28 ++++++++++ .../qemuxml2argv-video-qxl-heads.xml | 47 ++++++++++++++++ .../qemuxml2argv-video-qxl-noheads.args | 24 ++++++++ .../qemuxml2argv-video-qxl-noheads.xml | 39 +++++++++++++ tests/qemuxml2argvtest.c | 16 ++++++ .../qemuxml2xmlout-video-qxl-heads.xml | 47 ++++++++++++++++ .../qemuxml2xmlout-video-qxl-noheads.xml | 39 +++++++++++++ tests/qemuxml2xmltest.c | 3 + 12 files changed, 319 insertions(+), 5 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-noheads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-noheads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-heads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-noheads.xml -- 2.8.1

4 6

[libvirt] [PATCH v3 0/2] Add support for zero-write detection
by Martin Kletzander 31 May '16

31 May '16

v3: - I know Peter said he'll review it, but there are conflicts every once in a while, so rebased version will apply cleanly for a while - And it's actually not that big of a change to wait for some bigger things to be designed, I believe =) - https://www.redhat.com/archives/libvir-list/2016-April/msg01926.html v2: - use 'zeroes' instead of 'zeros' - https://www.redhat.com/archives/libvir-list/2016-February/msg01146.html v1: - https://www.redhat.com/archives/libvir-list/2015-December/msg00511.html Martin Kletzander (2): conf: Add support of zero-detection for disks qemu: Add support for zero-detection writes docs/formatdomain.html.in | 10 +++++ docs/schemas/domaincommon.rng | 12 ++++++ src/conf/domain_conf.c | 21 +++++++++- src/conf/domain_conf.h | 11 ++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 11 ++++++ tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + .../qemuxml2argv-disk-drive-detect-zeroes.args | 27 +++++++++++++ .../qemuxml2argv-disk-drive-detect-zeroes.xml | 45 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 3 ++ .../qemuxml2xmlout-disk-drive-detect-zeroes.xml | 1 + tests/qemuxml2xmltest.c | 1 + 17 files changed, 149 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-detect-zeroes.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-detect-zeroes.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-detect-zeroes.xml -- 2.8.1

2 4

[libvirt] [PATCH 0/6] Final round of build fixes
by Michal Privoznik 31 May '16

31 May '16

Hopefully. Michal Privoznik (6): virNetDevBridgeGet: Avoid NULL dereference virDomainFormatSchedDef: Handle case when func returns NULL esxStorageVolGetXMLDesc: Lookup SCSI lun properly qemuMonitorTextGetAllBlockStatsInfo: Fix line validation ppc64Compute: Avoid false positive domain_conf: Avoid false positive src/conf/domain_conf.c | 27 ++++++++++++++++++++++++--- src/cpu/cpu_ppc64.c | 12 +++++++++++- src/esx/esx_storage_backend_iscsi.c | 4 ++-- src/qemu/qemu_monitor_text.c | 2 +- src/util/virnetdevbridge.c | 6 +++++- 5 files changed, 43 insertions(+), 8 deletions(-) -- 2.8.3

2 24

[libvirt] [libvirt-perl][PATCH 0/2] Catch up with latest libvirt
by Michal Privoznik 31 May '16

31 May '16

Two public constants are to be introduced in libvirt. While touching that are of code, update documentation to a constant of the same origin. Michal Privoznik (2): Add PERF_PARAM_MBML and PERF_PARAM_MBMT constants Expand description for PERF_PARAM_CMT constant Changes | 1 + Virt.xs | 2 ++ lib/Sys/Virt/Domain.pm | 16 +++++++++++++++- 3 files changed, 18 insertions(+), 1 deletion(-) -- 2.8.3

2 4

[libvirt] [PATCH 0/3] docs/website: drop some old bits
by Cole Robinson 31 May '16

31 May '16

Patches to drop the (busted) website search, (busted) static todo list, and not-very-useful ChangeLog-old Cole Robinson (3): docs: website: remove search docs: website: drop the static todo list page docs: drop ChangeLog-old .gitignore | 2 - ChangeLog-old | 16699 ---------------------------------------------- Makefile.am | 1 - TODO | 22 +- docs/404.html.in | 9 +- docs/Makefile.am | 31 +- docs/devhelp/html.xsl | 4 - docs/index.py | 1266 ---- docs/libvirt.css | 24 - docs/page.xsl | 8 - docs/search.php.code.in | 225 - docs/search.php.in | 18 - docs/sitemap.html.in | 2 +- docs/todo.cfg-example | 26 - docs/todo.pl | 125 - 15 files changed, 13 insertions(+), 18449 deletions(-) delete mode 100644 ChangeLog-old delete mode 100755 docs/index.py delete mode 100644 docs/search.php.code.in delete mode 100644 docs/search.php.in delete mode 100644 docs/todo.cfg-example delete mode 100755 docs/todo.pl -- 2.7.4

2 6

[libvirt] [PATCH 0/2] Yet another round of build fixes
by Michal Privoznik 30 May '16

30 May '16

After these regular errors, I still cannot build cleanly: ../../src/conf/domain_conf.c: In function 'virDomainChrPreAlloc': ../../src/conf/domain_conf.c:14109:57: error: potential null pointer dereference [-Werror=null-dereference] return VIR_REALLOC_N(*arrPtr, *cntPtr + 1); ^ ../../src/conf/domain_conf.c: In function 'virDomainChrRemove': ../../src/conf/domain_conf.c:14133:21: error: potential null pointer dereference [-Werror=null-dereference] for (i = 0; i < *cntPtr; i++) { ^~~~~~~ cc1: all warnings being treated as errors These are obviously false positives. I know some developers here are not very fond of fixing those, so my question is - is it worth the effort or will my patches be NACKed straight away? Michal Privoznik (2): apibuild: Substitute only pure number tokens virSocketAddrIsPrivate: Work on 32bits platforms docs/apibuild.py | 2 +- src/util/virsocketaddr.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.8.3

2 4

[libvirt] [PATCH] conf: Skip MAC checks when using an auto-generated one during detach-device
by Kothapally Madhu Pavan 30 May '16

30 May '16

When we try to detach a network device without specifying the mac address, random mac address is generated. As the generated mac address will not be available in the running vm, detaching device will fail erroring out "error: operation failed: no device matching mac address xx:xx:xx:xx:xx:xx found". This patch allows to match DetachDeviec xml using PCI address when mac address is not specified. Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- src/conf/domain_conf.c | 116 +++++++++++++++++++++++++++++----------------- src/conf/domain_conf.h | 6 ++ src/libxl/libxl_driver.c | 4 +- src/lxc/lxc_driver.c | 6 +- src/qemu/qemu_driver.c | 40 ++++++++++++++-- src/qemu/qemu_hotplug.c | 16 ++++-- src/qemu/qemu_hotplug.h | 3 + 7 files changed, 132 insertions(+), 59 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 568c699..f07f178 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13613,14 +13613,20 @@ int virDomainNetInsert(virDomainDefPtr def, virDomainNetDefPtr net) return 0; } -/* virDomainNetFindIdx: search according to mac address and guest side - * PCI address (if specified) +/* virDomainNetFindIdx: + * search according to mac address and guest side PCI address (if specified). + * + * @def: pointer to domain definition + * @net: pointer to network definition that has to be looked up for + * @MACAddrNotSpecified: when detaching a device it takes "true" when mac address is + * not specified in device xml and a random mac is generated which + * cannot be found in the domain def. * * Return: index of match if unique match found * -1 otherwise and an error is logged */ int -virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) +virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net, bool MACAddrNotSpecified) { size_t i; int matchidx = -1; @@ -13628,50 +13634,76 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) bool PCIAddrSpecified = virDomainDeviceAddressIsValid(&net->info, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI); - for (i = 0; i < def->nnets; i++) { - if (virMacAddrCmp(&def->nets[i]->mac, &net->mac)) - continue; - - if ((matchidx >= 0) && !PCIAddrSpecified) { - /* there were multiple matches on mac address, and no - * qualifying guest-side PCI address was given, so we must - * fail (NB: a USB address isn't adequate, since it may - * specify only vendor and product ID, and there may be - * multiples of those. - */ - virReportError(VIR_ERR_OPERATION_FAILED, - _("multiple devices matching mac address %s found"), - virMacAddrFormat(&net->mac, mac)); - return -1; - } + /* MAC address is not specified in device xml. So, we need not check for it. + * Here we check for matching PCI address if specified. */ + if (MACAddrNotSpecified) { if (PCIAddrSpecified) { - if (virPCIDeviceAddressEqual(&def->nets[i]->info.addr.pci, - &net->info.addr.pci)) { - /* exit early if the pci address was specified and - * it matches, as this guarantees no duplicates. + for (i = 0; i < def->nnets; i++) { + if (virPCIDeviceAddressEqual(&def->nets[i]->info.addr.pci, + &net->info.addr.pci)) { + matchidx = i; + break; + } + } + if (matchidx < 0) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("no device found on " + "%.4x:%.2x:%.2x.%.1x"), + net->info.addr.pci.domain, + net->info.addr.pci.bus, + net->info.addr.pci.slot, + net->info.addr.pci.function); + } + } else { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("mac address and pci address not specified in device xml")); + } + } else { + for (i = 0; i < def->nnets; i++) { + if (virMacAddrCmp(&def->nets[i]->mac, &net->mac)) + continue; + + if ((matchidx >= 0) && !PCIAddrSpecified) { + /* there were multiple matches on mac address, and no + * qualifying guest-side PCI address was given, so we must + * fail (NB: a USB address isn't adequate, since it may + * specify only vendor and product ID, and there may be + * multiples of those. */ + virReportError(VIR_ERR_OPERATION_FAILED, + _("multiple devices matching mac address %s found"), + virMacAddrFormat(&net->mac, mac)); + return -1; + } + if (PCIAddrSpecified) { + if (virPCIDeviceAddressEqual(&def->nets[i]->info.addr.pci, + &net->info.addr.pci)) { + /* exit early if the pci address was specified and + * it matches, as this guarantees no duplicates. + */ + matchidx = i; + break; + } + } else { + /* no PCI address given, so there may be multiple matches */ matchidx = i; - break; } - } else { - /* no PCI address given, so there may be multiple matches */ - matchidx = i; } - } - if (matchidx < 0) { - if (PCIAddrSpecified) { - virReportError(VIR_ERR_OPERATION_FAILED, - _("no device matching mac address %s found on " - "%.4x:%.2x:%.2x.%.1x"), - virMacAddrFormat(&net->mac, mac), - net->info.addr.pci.domain, - net->info.addr.pci.bus, - net->info.addr.pci.slot, - net->info.addr.pci.function); - } else { - virReportError(VIR_ERR_OPERATION_FAILED, - _("no device matching mac address %s found"), - virMacAddrFormat(&net->mac, mac)); + if (matchidx < 0) { + if (PCIAddrSpecified) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("no device matching mac address %s found on " + "%.4x:%.2x:%.2x.%.1x"), + virMacAddrFormat(&net->mac, mac), + net->info.addr.pci.domain, + net->info.addr.pci.bus, + net->info.addr.pci.slot, + net->info.addr.pci.function); + } else { + virReportError(VIR_ERR_OPERATION_FAILED, + _("no device matching mac address %s found"), + virMacAddrFormat(&net->mac, mac)); + } } } return matchidx; diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index b1953b3..d3ebcdc 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2581,6 +2581,8 @@ typedef enum { VIR_DOMAIN_DEF_PARSE_SKIP_OSTYPE_CHECKS = 1 << 8, /* allow updates in post parse callback that would break ABI otherwise */ VIR_DOMAIN_DEF_PARSE_ABI_UPDATE = 1 << 9, + /* indicates mac address is generated when not provided in device xml */ + VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR = 1 << 10, } virDomainDefParseFlags; typedef enum { @@ -2710,7 +2712,9 @@ int virDomainDiskSourceParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virStorageSourcePtr src); -int virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net); +int virDomainNetFindIdx(virDomainDefPtr def, + virDomainNetDefPtr net, + bool MACAddrNotSpecified); virDomainNetDefPtr virDomainNetFind(virDomainDefPtr def, const char *device); bool virDomainHasNet(virDomainDefPtr def, virDomainNetDefPtr net); int virDomainNetInsert(virDomainDefPtr def, virDomainNetDefPtr net); diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 95dfc01..1c53c5f 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -3422,7 +3422,7 @@ libxlDomainDetachNetDevice(libxlDriverPrivatePtr driver, libxl_device_nic_init(&nic); - if ((detachidx = virDomainNetFindIdx(vm->def, net)) < 0) + if ((detachidx = virDomainNetFindIdx(vm->def, net, false)) < 0) goto cleanup; detach = vm->def->nets[detachidx]; @@ -3521,7 +3521,7 @@ libxlDomainDetachDeviceConfig(virDomainDefPtr vmdef, virDomainDeviceDefPtr dev) case VIR_DOMAIN_DEVICE_NET: net = dev->data.net; - if ((idx = virDomainNetFindIdx(vmdef, net)) < 0) + if ((idx = virDomainNetFindIdx(vmdef, net, false)) < 0) return -1; /* this is guaranteed to succeed */ diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 67f14fe..3d1396a 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -3929,7 +3929,7 @@ lxcDomainUpdateDeviceConfig(virDomainDefPtr vmdef, switch (dev->type) { case VIR_DOMAIN_DEVICE_NET: net = dev->data.net; - if ((idx = virDomainNetFindIdx(vmdef, net)) < 0) + if ((idx = virDomainNetFindIdx(vmdef, net, false)) < 0) goto cleanup; virDomainNetDefFree(vmdef->nets[idx]); @@ -3975,7 +3975,7 @@ lxcDomainDetachDeviceConfig(virDomainDefPtr vmdef, case VIR_DOMAIN_DEVICE_NET: net = dev->data.net; - if ((idx = virDomainNetFindIdx(vmdef, net)) < 0) + if ((idx = virDomainNetFindIdx(vmdef, net, false)) < 0) goto cleanup; /* this is guaranteed to succeed */ @@ -4759,7 +4759,7 @@ lxcDomainDetachDeviceNetLive(virDomainObjPtr vm, virDomainNetDefPtr detach = NULL; virNetDevVPortProfilePtr vport = NULL; - if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net)) < 0) + if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net, false)) < 0) goto cleanup; detach = vm->def->nets[detachidx]; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 10d3e3d..e6c811c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4105,6 +4105,31 @@ processDeviceDeletedEvent(virQEMUDriverPtr driver, virObjectUnref(cfg); } +static bool qemuIsMacAvailable(const char *xmlStr) +{ + xmlNodePtr cur; + xmlXPathContextPtr ctxt = NULL; + + if (!virXMLParseStringCtxt(xmlStr, _("(device_definition)"), &ctxt)) + goto endjob; + + cur = ctxt->node->children; + while (cur != NULL) { + if (cur->type == XML_ELEMENT_NODE) { + if (xmlStrEqual(cur->name, BAD_CAST "mac")) + goto cleanup; + } + cur = cur->next; + } + + endjob: + xmlXPathFreeContext(ctxt); + return false; + + cleanup: + xmlXPathFreeContext(ctxt); + return true; +} static void syncNicRxFilterMacAddr(char *ifname, virNetDevRxFilterPtr guestFilter, @@ -7587,7 +7612,8 @@ qemuDomainDetachDeviceControllerLive(virQEMUDriverPtr driver, static int qemuDomainDetachDeviceLive(virDomainObjPtr vm, virDomainDeviceDefPtr dev, - virDomainPtr dom) + virDomainPtr dom, + unsigned int parse_flags) { virQEMUDriverPtr driver = dom->conn->privateData; int ret = -1; @@ -7603,7 +7629,7 @@ qemuDomainDetachDeviceLive(virDomainObjPtr vm, ret = qemuDomainDetachLease(driver, vm, dev->data.lease); break; case VIR_DOMAIN_DEVICE_NET: - ret = qemuDomainDetachNetDevice(driver, vm, dev); + ret = qemuDomainDetachNetDevice(driver, vm, dev, parse_flags); break; case VIR_DOMAIN_DEVICE_HOSTDEV: ret = qemuDomainDetachHostDevice(driver, vm, dev); @@ -7932,6 +7958,7 @@ qemuDomainDetachDeviceConfig(virDomainDefPtr vmdef, virDomainChrDefPtr chr; virDomainFSDefPtr fs; int idx; + bool skipMac = parse_flags & VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR ? true : false; switch ((virDomainDeviceType) dev->type) { case VIR_DOMAIN_DEVICE_DISK: @@ -7946,7 +7973,7 @@ qemuDomainDetachDeviceConfig(virDomainDefPtr vmdef, case VIR_DOMAIN_DEVICE_NET: net = dev->data.net; - if ((idx = virDomainNetFindIdx(vmdef, net)) < 0) + if ((idx = virDomainNetFindIdx(vmdef, net, skipMac)) < 0) return -1; /* this is guaranteed to succeed */ @@ -8115,7 +8142,7 @@ qemuDomainUpdateDeviceConfig(virDomainDefPtr vmdef, case VIR_DOMAIN_DEVICE_NET: net = dev->data.net; - if ((pos = virDomainNetFindIdx(vmdef, net)) < 0) + if ((pos = virDomainNetFindIdx(vmdef, net, false)) < 0) return -1; virDomainNetDefFree(vmdef->nets[pos]); @@ -8452,6 +8479,9 @@ qemuDomainDetachDeviceFlags(virDomainPtr dom, !(flags & VIR_DOMAIN_AFFECT_LIVE)) parse_flags |= VIR_DOMAIN_DEF_PARSE_INACTIVE; + if (!qemuIsMacAvailable(xml)) + parse_flags |= VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR; + dev = dev_copy = virDomainDeviceDefParse(xml, vm->def, caps, driver->xmlopt, parse_flags); @@ -8495,7 +8525,7 @@ qemuDomainDetachDeviceFlags(virDomainPtr dom, VIR_DOMAIN_DEVICE_ACTION_DETACH) < 0) goto endjob; - if ((ret = qemuDomainDetachDeviceLive(vm, dev_copy, dom)) < 0) + if ((ret = qemuDomainDetachDeviceLive(vm, dev_copy, dom, parse_flags)) < 0) goto endjob; /* * update domain status forcibly because the domain status may be diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 6ce0a84..2bf82b4 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2163,7 +2163,7 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, int ret = -1; int changeidx = -1; - if ((changeidx = virDomainNetFindIdx(vm->def, newdev)) < 0) + if ((changeidx = virDomainNetFindIdx(vm->def, newdev, false)) < 0) goto cleanup; devslot = &vm->def->nets[changeidx]; @@ -3825,7 +3825,7 @@ int qemuDomainDetachHostDevice(virQEMUDriverPtr driver, * function so that mac address / virtualport are reset */ if (detach->parent.type == VIR_DOMAIN_DEVICE_NET) - return qemuDomainDetachNetDevice(driver, vm, &detach->parent); + return qemuDomainDetachNetDevice(driver, vm, &detach->parent, 0); else return qemuDomainDetachThisHostDevice(driver, vm, detach); } @@ -3833,14 +3833,20 @@ int qemuDomainDetachHostDevice(virQEMUDriverPtr driver, int qemuDomainDetachNetDevice(virQEMUDriverPtr driver, virDomainObjPtr vm, - virDomainDeviceDefPtr dev) + virDomainDeviceDefPtr dev, + unsigned int parse_flags) { int detachidx, ret = -1; virDomainNetDefPtr detach = NULL; qemuDomainObjPrivatePtr priv = vm->privateData; - if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net)) < 0) - goto cleanup; + if (parse_flags & VIR_DOMAIN_DEF_PARSE_SKIP_GENERATE_MACADDR) { + if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net, true)) < 0) + goto cleanup; + } else { + if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net, false)) < 0) + goto cleanup; + } detach = vm->def->nets[detachidx]; diff --git a/src/qemu/qemu_hotplug.h b/src/qemu/qemu_hotplug.h index 165d345..f144879 100644 --- a/src/qemu/qemu_hotplug.h +++ b/src/qemu/qemu_hotplug.h @@ -82,7 +82,8 @@ int qemuDomainDetachControllerDevice(virQEMUDriverPtr driver, virDomainDeviceDefPtr dev); int qemuDomainDetachNetDevice(virQEMUDriverPtr driver, virDomainObjPtr vm, - virDomainDeviceDefPtr dev); + virDomainDeviceDefPtr dev, + unsigned int parse_flags); int qemuDomainDetachHostDevice(virQEMUDriverPtr driver, virDomainObjPtr vm, virDomainDeviceDefPtr dev);

2 1

[libvirt] [PATCH 0/3] Couple of build fixes
by Michal Privoznik 30 May '16

30 May '16

I've noticed couple of build failures with a bleeding edge gcc. Here are fixes to some of them. Michal Privoznik (3): docs: Teach apibuild to deal with (1U << 31) too Turn 1<<31 into 1U<<31 build: use gnulib's unsetenv bootstrap.conf | 1 + docs/apibuild.py | 3 ++- include/libvirt/libvirt-domain.h | 2 +- src/util/virtypedparam.h | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) -- 2.8.3

2 7

[libvirt] Entering freeze fro libvirt-1.3.5
by Daniel Veillard 28 May '16

28 May '16

Due to travel etc... I forgot to push RC1 on Thursday and could not yesterday, but I just tagged rc1 in git and am pushing signed tarball and rpms to the usual place now: ftp://libvirt.org/libvirt/ I think I can try to push rc2 on Tuesday or Wednesday, and then I will try to push 1.3.5 on Friday (3rd then), sorry for the delay, please give it a try, thanks Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH rfc 0/1] storage: vzstorage storage pool
by Olga Krishtal 28 May '16

28 May '16

In-Reply-To: This is first draft, that supports vzstorage in storage pools.i Virtuozzo Storage is a fault-tolerant distributed storage system, optimized for virtualization workloads. Vzstorage pool supports the same volume formats as directory, nfs, etc. In terms of volume management - there is no difference between these pools. You can find more information here: https://openvz.org/Virtuozzo_Storage XML: <pool type='vz'> <name>vz7_pool</name> <uuid>b27a72b5-a92e-4e58-a172-a80ba73b30fe</uuid> <capacity unit='bytes'>0</capacity> <allocation unit='bytes'>0</allocation> <available unit='bytes'>0</available> <source> <host name='127.0.0.2'/> <device path='vz7-vzstorage'/> <dir path='/pool1'/> </source> <target> <path>/vz7-vzstorage</path> </target> </pool> To compile libvirt with vz pool support use key --with-storage-vz I need some help to resolve some problems: - how to detect that pool is alredy mounted. - when we show pool sources do we need to show folders that may reside on vzstorage - I am not quite sure that we need host name in xml. I will be glad to here your opinion.

2 3