- Devel - libvirt List Archives

Re: [libvirt] [PATCH 00/16] Hyper-V: Improve 2008, Introduce 2012
by Fernando Casas Schössow 09 Sep '16

09 Sep '16

Hi there, I was wondering if any of these patches actually made it into libvirt code. I'm really looking forward hyper-v support improvement and features like shutdown VM (not destroy/turn off but clean shutdown) implemented. Especially interested in 2012/2012 R2 since 2008 is getting old and 2016 is right around the corner. I'm already using libvirt 2.1.0 with some patches I found in https://github.com/vikhyath/libvirt-hyperv-r2-2012 but it would be great to have the code reviewed and merged into libvirt releases. Thanks. Fer > The following patches include work originally done by Yves Vinter back > in 2014. The last patch introduces support for Hyper-V 2012, while > still > supporting 2008. I am not sure that the method I used to include the > 2012 > support is the best approach, mainly due to code duplication, but I am > open to suggestions on how to do this better. > > Jason Miesionczek (16): > hyperv: additional server 2008 wmi classes > hyperv: add cim types support to code generator > hyperv: add get capabilities > hyperv: implement connectGetVersion > hyperv: implement vcpu functions > hyperv: implement nodeGetFreeMemory > hyperv: implement ability to send xml soap requests > hyperv: introduce basic network driver > hyperv: add domain shutdown function > hyperv: add get scheduler functions > hyperv: add set memory functions > hyperv: set vpcu functions > hyperv: domain undefine functions > hyperv: domain define and associated functions > hyperv: network list functions > hyperv: introduce 2012 support > > src/Makefile.am | 2 + > src/hyperv/hyperv_driver.c | 1989 ++++++++++++++++++++++++++++++++- > src/hyperv/hyperv_driver_2012.c | 299 +++++ > src/hyperv/hyperv_driver_2012.h | 55 + > src/hyperv/hyperv_network_driver.c | 280 +++++ > src/hyperv/hyperv_network_driver.h | 30 + > src/hyperv/hyperv_private.h | 8 + > src/hyperv/hyperv_wmi.c | 709 +++++++++++- > src/hyperv/hyperv_wmi.h | 78 ++ > src/hyperv/hyperv_wmi_generator.input | 518 ++++++++- > src/hyperv/hyperv_wmi_generator.py | 68 +- > src/hyperv/openwsman.h | 4 + > 12 files changed, 3989 insertions(+), 51 deletions(-) > create mode 100644 src/hyperv/hyperv_driver_2012.c > create mode 100644 src/hyperv/hyperv_driver_2012.h > create mode 100644 src/hyperv/hyperv_network_driver.c > create mode 100644 src/hyperv/hyperv_network_driver.h

3 7

[libvirt] [PATCH] security: Fixing wrong label in virt-aa-helper.c.
by Julio Faracco 09 Sep '16

09 Sep '16

There is an issue with a wrong label inside vah_add_path(). The compilation fails with the error: make[3]: Entering directory '/tmp/libvirt/src' CC security/virt_aa_helper-virt-aa-helper.o security/virt-aa-helper.c: In function 'vah_add_path': security/virt-aa-helper.c:769:9: error: label 'clean' used but not defined goto clean; This patch moves 'clean' label to 'cleanup' label. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 2aa6e28..fc01076 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -766,7 +766,7 @@ vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursi } if (VIR_STRDUP_QUIET(perms_new, perms) < 0) - goto clean; + goto cleanup; if (strchr(perms_new, 'w') != NULL) { readonly = false; -- 2.7.4

2 2

[libvirt] [PATCH 0/2] qemu: Remove stale transient def when migration fails
by Jiri Denemark 09 Sep '16

09 Sep '16

If a migration of a domain which is already defined on the destination host failed early (before we tried to start QEMU), we would forget to remove the incoming transient definition. Later on when someone starts the domain on the destination host, we will use the stale incoming definition and the persistent definition will just be ignored. https://bugzilla.redhat.com/show_bug.cgi?id=1368774 Jiri Denemark (2): Add helper for removing transient definition qemu: Remove stale transient def when migration fails src/conf/domain_conf.c | 19 +++++++++++++++++++ src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + src/libxl/libxl_domain.c | 8 +------- src/lxc/lxc_process.c | 7 +------ src/qemu/qemu_migration.c | 4 ++++ src/qemu/qemu_process.c | 7 +------ src/test/test_driver.c | 9 ++------- src/uml/uml_driver.c | 14 ++------------ 9 files changed, 32 insertions(+), 38 deletions(-) -- 2.10.0

2 4

[libvirt] Opening a read-only connection - with SASL auth.
by Yaniv Kaul 08 Sep '16

08 Sep '16

Looking at the collectd virt plugin, it opens a read only connection with libvirt[1]. We'd like to use it with SASL auth. (which oVirt configures libvirt to use by default, with a simple username/password) - is that possible? TIA, Y. [1] https://github.com/collectd/collectd/blob/d782a871aca61ac966ee8d928930719bd…

1 0

[libvirt] [PATCH] Allow address lease query with inactive domain
by Amador Pahim 08 Sep '16

08 Sep '16

The <drive>DomainInterfaceAddresses, when using the source type LEASE, does not need the domain to be running. It only checks the dhcp lease file and gets the address information from a valid lease, if any. This patch removes the virDomainObjIsActive(vm) check from the LEASE query type on both qemu and lxc drivers, keeping it only for query type AGENT on qemu driver (since lxc does not support AGENT type). Signed-off-by: Amador Pahim <amador(a)pahim.org> --- src/libxl/libxl_driver.c | 6 ------ src/qemu/qemu_driver.c | 12 ++++++------ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 480fef9..9f8c36a 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -6251,12 +6251,6 @@ libxlDomainInterfaceAddresses(virDomainPtr dom, if (virDomainInterfaceAddressesEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("domain is not running")); - goto cleanup; - } - switch (source) { case VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE: ret = libxlGetDHCPInterfaces(dom, vm, ifaces); diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 807e06d..a8dfa2f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19600,18 +19600,18 @@ qemuDomainInterfaceAddresses(virDomainPtr dom, if (virDomainInterfaceAddressesEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("domain is not running")); - goto cleanup; - } - switch (source) { case VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE: ret = qemuGetDHCPInterfaces(dom, vm, ifaces); break; case VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT: + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("domain is not running")); + goto cleanup; + } + if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; -- 2.7.4

3 4

[libvirt] [PATCH] virt-admin: Document srv-list command in virt-admin's man page
by Erik Skultety 08 Sep '16

08 Sep '16

srv-list command was missing in the man page. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- tools/virt-admin.pod | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tools/virt-admin.pod b/tools/virt-admin.pod index 2199038..c74707a 100644 --- a/tools/virt-admin.pod +++ b/tools/virt-admin.pod @@ -143,6 +143,20 @@ libvirtd:///system is used. =back +=head1 DAEMON COMMANDS + +Following commands allow to monitor daemon's state as well as directly change +its internal configuration. + +=over 4 + +=item B<srv-list> + +Lists all manageable servers on daemon the client is currently connected to +through administration interface. + +=back + =head1 SERVER COMMANDS Following commands manipulate daemon's server internal configuration. -- 2.5.5

2 2

[libvirt] [PATCH] virt-admin: Fix some English grammar in the manpage
by Erik Skultety 08 Sep '16

08 Sep '16

Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- tools/virt-admin.pod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Pushed as trivial. diff --git a/tools/virt-admin.pod b/tools/virt-admin.pod index 0195001..020eb51 100644 --- a/tools/virt-admin.pod +++ b/tools/virt-admin.pod @@ -159,7 +159,7 @@ currently connected to. =head1 SERVER COMMANDS -Following commands manipulate daemon's server internal configuration. +The following commands manipulate daemon's server internal configuration. The I<server> is specified by its name. =over 4 @@ -281,7 +281,7 @@ I<--max-clients>. =head1 CLIENT COMMANDS -Following commands provide management and monitoring of clients connected to +The following commands provide management and monitoring of clients connected to one of daemon's available servers. Clients are specified by their numeric ID which is obtained by listing all clients connected to a specified server (see command B<srv-clients-list>). -- 2.5.5

1 0

[libvirt] [libvirt-php][PATCH 0/8] Couple of php fixes
by Michal Privoznik 08 Sep '16

08 Sep '16

Pushed under php-autopush rule. Michal Privoznik (8): libvirt_domain_get_network_info: Don't overwrite retval libvirt_storagepool_get_autostart: Rework translate_counter_type: Rework libvirt_domain_block_commit: Reindent libvirt_domain_qemu_agent_command: Reindent libvirt_domain_disk_add: Reindent libvirt_domain_disk_remove: Reindent libvirt_list_storagepools: Reindent src/libvirt-php.c | 129 ++++++++++++++++++++++++++---------------------------- 1 file changed, 61 insertions(+), 68 deletions(-) -- 2.8.4

1 8

[libvirt] [libvirt-php][PATCH] Don't leak @mime in libvirt_domain_get_screenshot_api
by Michal Privoznik 08 Sep '16

08 Sep '16

When getting a screenshot of a domain via virDomainScreenshot() the MIME type of a image is returned as a string which needs to be freed by caller. However, we are not doing that anywhere. ==24748== 48 bytes in 2 blocks are definitely lost in loss record 123 of 171 ==24748== at 0x4C29F80: malloc (vg_replace_malloc.c:296) ==24748== by 0x90674AB: xdr_string (xdr.c:790) ==24748== by 0xCD3AF1D: xdr_remote_nonnull_string (in /usr/lib64/libvirt.so.0.2003.0) ==24748== by 0x9067B34: xdr_reference (xdr_ref.c:84) ==24748== by 0x9067C50: xdr_pointer (xdr_ref.c:135) ==24748== by 0xCD3B284: xdr_remote_string (in /usr/lib64/libvirt.so.0.2003.0) ==24748== by 0xCD3D288: xdr_remote_domain_screenshot_ret (in /usr/lib64/libvirt.so.0.2003.0) ==24748== by 0xCD5168E: virNetMessageDecodePayload (in /usr/lib64/libvirt.so.0.2003.0) ==24748== by 0xCD47E91: virNetClientProgramCall (in /usr/lib64/libvirt.so.0.2003.0) ==24748== by 0xCD1EBD3: callFull.isra.3 (in /usr/lib64/libvirt.so.0.2003.0) ==24748== by 0xCD29973: remoteDomainScreenshot (in /usr/lib64/libvirt.so.0.2003.0) ==24748== by 0xCCDC24C: virDomainScreenshot (in /usr/lib64/libvirt.so.0.2003.0) Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under php-autopush rule. src/libvirt-php.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 8edcb10..57ef1a0 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -4767,8 +4767,10 @@ PHP_FUNCTION(libvirt_domain_get_screenshot_api) } #ifndef EXTWIN - if (mkstemp(file) == 0) + if (mkstemp(file) == 0) { + free(mime); RETURN_FALSE; + } #endif if ((fd = open(file, O_WRONLY|O_CREAT|O_EXCL, 0666)) < 0) { @@ -4776,6 +4778,7 @@ PHP_FUNCTION(libvirt_domain_get_screenshot_api) (fd = open(file, O_WRONLY|O_TRUNC, 0666)) < 0) { virStreamFree(st); set_error_if_unset("Cannot get create file to save domain screenshot" TSRMLS_CC); + free(mime); RETURN_FALSE; } } @@ -4783,6 +4786,7 @@ PHP_FUNCTION(libvirt_domain_get_screenshot_api) if (virStreamRecvAll(st, streamSink, &fd) < 0) { virStreamFree(st); set_error_if_unset("Cannot receive screenshot data" TSRMLS_CC); + free(mime); RETURN_FALSE; } @@ -4791,6 +4795,7 @@ PHP_FUNCTION(libvirt_domain_get_screenshot_api) if (virStreamFinish(st) < 0) { virStreamFree(st); set_error_if_unset("Cannot close stream for domain" TSRMLS_CC); + free(mime); RETURN_FALSE; } @@ -4816,6 +4821,8 @@ PHP_FUNCTION(libvirt_domain_get_screenshot_api) VIRT_ADD_ASSOC_STRING(return_value, "file", file); VIRT_ADD_ASSOC_STRING(return_value, "mime", mime); } + + free(mime); } /* -- 2.8.4

1 0

[libvirt] [PATCH] Avoid segfault in virt-aa-helper when handling read-only mount filesystems
by rufo 08 Sep '16

08 Sep '16

This patch fixes a segfault in virt-aa-helper caused by attempting to modify a string literal in situ. It is triggered when a domain has a <filesystem> with type='mount' configured readonly, and libvirt is using the AppArmor security driver for sVirt confinement. --- src/security/virt-aa-helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 49e12b9..c22aa66 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -740,6 +740,7 @@ vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursi bool readonly = true; bool explicit_deny_rule = true; char *sub = NULL; + char *perms_new = strdup(perms); if (path == NULL) return rc; @@ -764,12 +765,12 @@ vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursi return rc; } - if (strchr(perms, 'w') != NULL) { + if (strchr(perms_new, 'w') != NULL) { readonly = false; explicit_deny_rule = false; } - if ((sub = strchr(perms, 'R')) != NULL) { + if ((sub = strchr(perms_new, 'R')) != NULL) { /* Don't write the invalid R permission, replace it with 'r' */ sub[0] = 'r'; explicit_deny_rule = false; @@ -787,7 +788,7 @@ vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursi if (tmp[strlen(tmp) - 1] == '/') tmp[strlen(tmp) - 1] = '\0'; - virBufferAsprintf(buf, " \"%s%s\" %s,\n", tmp, recursive ? "/**" : "", perms); + virBufferAsprintf(buf, " \"%s%s\" %s,\n", tmp, recursive ? "/**" : "", perms_new); if (explicit_deny_rule) { virBufferAddLit(buf, " # don't audit writes to readonly files\n"); virBufferAsprintf(buf, " deny \"%s%s\" w,\n", tmp, recursive ? "/**" : ""); -- 2.9.3

4 5