- Devel - libvirt List Archives

[libvirt] [PATCH 00/15] qemu: Add QMP schema introspection and use it to add gluster debug setting
by Peter Krempa 21 Oct '16

21 Oct '16

Add support for QMP schema introspection along with test data adding and fixup and use it to detect support for gluster debug setting in qemu. Thanks to Andrea and Pavel for gathering test data for me so I don't have to compile multiple qemu versions or deal with minority architectures. (I honoured them by granting them autorship on the patches) This series also includes the gluster posting from Prasanna which I've properly split, reordered and fixed. Andrea Bolognani (5): tests: qemucaps: Update ppc64 replies for qemu 2.6.0 release tests: qemucaps: Update aarch64 gicv2 replies for qemu 2.6.0 release tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on ppc64le tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on aarch64 gicv2 tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on aarch64 gicv3 Pavel Hrdina (3): tests: qemucaps: Add QMP introspection data for qemu 2.5.0 on x86 tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on x86 tests: qemucaps: Add QMP introspection data for qemu 2.7.0 on x86 Peter Krempa (4): util: json: add helper to iterate and steal members of json array qemu: monitor: Add code to retrieve and store QMP schema data tests: qemucaps: Temporarily remove 'query-qmp-schema' from test data qemu: capabilities: Add support for QMP schema introspection Prasanna Kumar Kalever (3): qemu: capabilities: Detect support for gluster debug setting qemu: conf: add option for tuning debug logging level qemu: command: Add debug option for gluster volumes src/libvirt_private.syms | 1 + src/qemu/libvirtd_qemu.aug | 3 + src/qemu/qemu.conf | 20 + src/qemu/qemu_capabilities.c | 183 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 19 +- src/qemu/qemu_command.h | 1 + src/qemu/qemu_conf.c | 3 + src/qemu/qemu_conf.h | 1 + src/qemu/qemu_hotplug.c | 6 +- src/qemu/qemu_monitor.c | 11 + src/qemu/qemu_monitor.h | 2 + src/qemu/qemu_monitor_json.c | 67 + src/qemu/qemu_monitor_json.h | 3 + src/util/virjson.c | 36 + src/util/virjson.h | 6 + .../qemuargv2xml-disk-drive-network-gluster.args | 7 +- .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 7545 ++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.replies | 8036 ++++++++++++++++++- .../caps_2.6.0-gicv2.aarch64.xml | 3 +- .../caps_2.6.0-gicv3.aarch64.replies | 8007 ++++++++++++++++++- .../caps_2.6.0-gicv3.aarch64.xml | 1 + .../caps_2.6.0.ppc64le.replies | 8026 ++++++++++++++++++- tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 5 +- .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 8005 +++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 8356 ++++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 + .../qemuxml2argv-disk-drive-network-gluster.args | 12 +- tests/qemuxml2argvtest.c | 3 +- 31 files changed, 48326 insertions(+), 48 deletions(-) 1000:1 ratio ;) -- 2.10.0

2 31

[libvirt] [PATCH] xenFormatXLDisk: Fix commas for arguments
by Michal Privoznik 21 Oct '16

21 Oct '16

instead of: virBufferAdd(buf, "arg1,"); virBufferAdd(buf, "arg2"); lets have: virBufferAdd(buf, "arg1"); virBufferAdd(buf, ",arg2"); Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/xenconfig/xen_xl.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index 742f1ef..337f9dd 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -1022,33 +1022,33 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) virBufferAddLit(&buf, "format="); switch (format) { case VIR_STORAGE_FILE_RAW: - virBufferAddLit(&buf, "raw,"); + virBufferAddLit(&buf, "raw"); break; case VIR_STORAGE_FILE_VHD: - virBufferAddLit(&buf, "xvhd,"); + virBufferAddLit(&buf, "xvhd"); break; case VIR_STORAGE_FILE_QCOW: - virBufferAddLit(&buf, "qcow,"); + virBufferAddLit(&buf, "qcow"); break; case VIR_STORAGE_FILE_QCOW2: - virBufferAddLit(&buf, "qcow2,"); + virBufferAddLit(&buf, "qcow2"); break; /* set default */ default: - virBufferAddLit(&buf, "raw,"); + virBufferAddLit(&buf, "raw"); } /* device */ - virBufferAsprintf(&buf, "vdev=%s,", disk->dst); + virBufferAsprintf(&buf, ",vdev=%s", disk->dst); /* access */ - virBufferAddLit(&buf, "access="); + virBufferAddLit(&buf, ",access="); if (disk->src->readonly) - virBufferAddLit(&buf, "ro,"); + virBufferAddLit(&buf, "ro"); else if (disk->src->shared) - virBufferAddLit(&buf, "!,"); + virBufferAddLit(&buf, "!"); else - virBufferAddLit(&buf, "rw,"); + virBufferAddLit(&buf, "rw"); if (disk->transient) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("transient disks not supported yet")); @@ -1057,18 +1057,18 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) /* backendtype */ if (driver) { - virBufferAddLit(&buf, "backendtype="); + virBufferAddLit(&buf, ",backendtype="); if (STREQ(driver, "qemu") || STREQ(driver, "file")) - virBufferAddLit(&buf, "qdisk,"); + virBufferAddLit(&buf, "qdisk"); else if (STREQ(driver, "tap")) - virBufferAddLit(&buf, "tap,"); + virBufferAddLit(&buf, "tap"); else if (STREQ(driver, "phy")) - virBufferAddLit(&buf, "phy,"); + virBufferAddLit(&buf, "phy"); } /* devtype */ if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) - virBufferAddLit(&buf, "devtype=cdrom,"); + virBufferAddLit(&buf, ",devtype=cdrom"); /* * target @@ -1082,7 +1082,7 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) goto cleanup; if (target) - virBufferAsprintf(&buf, "target=%s", target); + virBufferAsprintf(&buf, ",target=%s", target); if (virBufferCheckError(&buf) < 0) goto cleanup; -- 2.8.4

2 3

[libvirt] [PATCH 0/2] vz: add serial number to disk devices
by Nikolay Shirokovskiy 21 Oct '16

21 Oct '16

Only the first patch is really on the subject. The second one is bugfix that is included mainly because it touches the same place (and nice to have to test first patch too...) Nikolay Shirokovskiy (2): vz: add serial number to disk devices vz: set something in disk driver name src/vz/vz_sdk.c | 16 ++++++++++++++++ src/vz/vz_utils.c | 6 +++--- 2 files changed, 19 insertions(+), 3 deletions(-) -- 1.8.3.1

2 5

[libvirt] [PATCH v2 0/3] qemu: util: vz: support setting disk serial number
by Maxim Nestratov 21 Oct '16

21 Oct '16

Actually this is a combination of the two previous series https://www.redhat.com/archives/libvir-list/2016-October/msg00890.html and https://www.redhat.com/archives/libvir-list/2016-September/msg01024.html Maxim Nestratov (1): util: qemu: make qemuSafeSerialParamValue function usable by other drivers Nikolay Shirokovskiy (2): vz: set something in disk driver name vz: add serial number to disk devices src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 19 +------------------ src/util/virutil.c | 16 ++++++++++++++++ src/util/virutil.h | 2 ++ src/vz/vz_sdk.c | 24 ++++++++++++++++++++++++ src/vz/vz_utils.c | 6 +++--- 6 files changed, 47 insertions(+), 21 deletions(-) -- 2.4.11

1 4

[libvirt] [PATCH] bhyve: Need to add parameter to virDomainChrDefNew
by John Ferlan 21 Oct '16

21 Oct '16

Commit id '5f2a13278' missed this one. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as build breaker https://ci.centos.org/view/libvirt-project/job/libvirt-master-build/150/sys… src/bhyve/bhyve_parse_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c index fd9384d..1a7de3d 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -287,7 +287,7 @@ bhyveParseBhyveLPCArg(virDomainDefPtr def, /* Only support com%d */ if (STRPREFIX(type, "com") && type[4] == 0) { - if (!(chr = virDomainChrDefNew())) + if (!(chr = virDomainChrDefNew(NULL))) goto error; chr->source.type = VIR_DOMAIN_CHR_TYPE_NMDM; -- 2.7.4

1 0

[libvirt] [PATCH 0/4] qemuBuildHostNetStr cleanups
by Ján Tomko 21 Oct '16

21 Oct '16

This is not a blurb. Ján Tomko (4): qemuBuildHostNetStr: use type_sep earlier qemuBuildHostNetStr: do not start options with a comma qemuBuildHostNetStr: move stray VIR_DOMAIN_NET_TYPE_INTERNAL qemuBuildHostNetStr: remove dead code src/qemu/qemu_command.c | 49 +++++++++++++++++++++---------------------------- 1 file changed, 21 insertions(+), 28 deletions(-) -- 2.7.3

2 8

[libvirt] [PATCH v10 0/4] Add native TLS encrypted chardev TCP support
by John Ferlan 21 Oct '16

21 Oct '16

v9: http://www.redhat.com/archives/libvir-list/2016-October/msg00726.html "Theorically speaking" patch #2 is "separate" from patches 1, 3, & 4. That is patch 3 and 4 are adding the secret uuid processing handling which is different than the enable/disable property logic for patch 2. I've left them all together though since just to be consistent with previous series. Differences in v10 ... Pushed the previous series 2/5 and 3/5 since they were ACK'd ... Create a new patch 1 to have helper qemuDomainSupportTLSChardevTCP It's mostly unnecessary without patch 2 though, but it made adding or "separating" patch 2 from patches 3 & 4 a whole lot easier... ... Modified former patch 1 (now patch 2) to accommodate for a paradigm where tls='yes' and chardev_tls=0 might be possible. The new helper is used to whether to add the TLS information or not. ... Modified former patch 4 (now patch 3) to accommodate for the changes Pavel has made to the code and to generate the secalias using the "charAlias" ... Modified former patch 4 (now patch 4) to use the "charAlias" as well and merge in Pavel's changes NOTE: Even though 'yes' is a now possibility, it is an option that's assuming chardev_tls=0 so I don't feel the issues raised during review of v8 regarding needing to consider a currently running 2.3.0 domain that still needs to work when 2.4.0 is applied. I believe it will be with the way the optional property is being used, thus with respect to the points in: http://www.redhat.com/archives/libvir-list/2016-October/msg00732.html The proposed qemuProcessPrepareDomain change is invalid since haveTLS is a tristate and chardevTLS is a bistate. This is what I meant about being a bit dangerous (e.g. BOOL_NO=2, BOOL_YES=1, and BOOL_ABSENT=0); however, "chardevTLS=1" is enabled (yes) and "chardevTLS=0" is disabled (absent). While it looks good when typing, when you get down to the details sometimes you find those 'gotchas'. Even if the shorthand logic were fixed, it's not going to be good to assume that setting the domain property or disabling the domain property is the desired action. The qemuProcessAttach is for qemu-attach and not the path that libvirt uses to reconnect to running domains (which is qemuProcessReconnect). There's so much broken from the qemu-attach right now - I doubt it really works at all. With respect to the reconnect processing (since that's really what you were thinking about)... There is no "options" provided/found in that code. New code could possibly "read" the '/proc/$pid/cmdline' file and look for 'tls-creds', but the only purpose of that would be to manage 'assumptions' with how the "tls='{yes|no}'" property is used. Altering virDomainChrSourceDefParseXML and virDomainChrSourceDefFormat to manage some new boolean 'tlsFromConfig' that I'm not sure could be set properly is something I think is outside these patches. John Ferlan (4): qemu: Introduce qemuDomainSupportTLSChardevTCP domain: Add optional 'tls' attribute for TCP chardev qemu: Add a secret object to/for a chardev tcp with secret qemu: Add secret object hotplug for TCP chardev TLS docs/formatdomain.html.in | 28 +++++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 22 +++- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 33 ++++- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 133 ++++++++++++++++++++- src/qemu/qemu_domain.h | 18 ++- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 58 ++++++++- src/qemu/qemu_hotplug.h | 3 +- src/qemu/qemu_process.c | 4 +- tests/qemuhotplugtest.c | 2 +- ...uxml2argv-serial-tcp-tlsx509-chardev-notls.args | 30 +++++ ...muxml2argv-serial-tcp-tlsx509-chardev-notls.xml | 50 ++++++++ ...xml2argv-serial-tcp-tlsx509-secret-chardev.args | 38 ++++++ ...uxml2argv-serial-tcp-tlsx509-secret-chardev.xml | 50 ++++++++ tests/qemuxml2argvtest.c | 20 ++++ ...xml2xmlout-serial-tcp-tlsx509-chardev-notls.xml | 1 + tests/qemuxml2xmltest.c | 1 + 20 files changed, 483 insertions(+), 17 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev-notls.xml -- 2.7.4

2 15

[libvirt] [PATCH] vz: set localhost as vnc address
by Mikhail Feoktistov 21 Oct '16

21 Oct '16

We should set localhost as vnc address in case of empty string. Because Virtuozzo sets 0.0.0.0 as default vnc address. --- src/vz/vz_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index f2a5c96..7235172 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2967,7 +2967,7 @@ static int prlsdkApplyGraphicsParams(PRL_HANDLE sdkdom, glisten = virDomainGraphicsGetListen(gr, 0); pret = PrlVmCfg_SetVNCHostName(sdkdom, glisten && glisten->address ? - glisten->address : ""); + glisten->address : "127.0.0.1"); prlsdkCheckRetGoto(pret, cleanup); ret = 0; -- 1.8.3.1

3 2

[libvirt] [PATCH v4 0/3] Forbid new-line char in name of networks
by Sławek Kapłoński 20 Oct '16

20 Oct '16

v3: http://www.redhat.com/archives/libvir-list/2016-October/msg00627.html Differences in v4: * function to check string moved from src/util/virstring to src/util/virxml Sławek Kapłoński (3): util: Add function to check if string contains some illegal chars Use new util function to check network name Forbid new-line char in name of new networks src/conf/network_conf.c | 5 +---- src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 3 +++ src/util/virxml.c | 28 ++++++++++++++++++++++++++++ src/util/virxml.h | 3 +++ 5 files changed, 36 insertions(+), 4 deletions(-) -- 2.10.0

2 8

[libvirt] [PATCH 0/2] qemu: util: vz: support setting disk serial number
by Maxim Nestratov 20 Oct '16

20 Oct '16

The first patch is a preparation moving qemuSafeSerialParamValue to util, the second implements disk serial number setting in vz driver. Maxim Nestratov (2): util: qemu: make qemuSafeSerialParamValue function usable by other drivers vz: support setting disk serial number src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 19 +------------------ src/util/virutil.c | 16 ++++++++++++++++ src/util/virutil.h | 2 ++ src/vz/vz_sdk.c | 19 +++++++++++++++++++ src/vz/vz_utils.c | 5 ----- 6 files changed, 39 insertions(+), 23 deletions(-) -- 2.4.11

2 4