- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] bhyve: add e1000 nic support
by Roman Bogorodskiy 22 Sep '16

22 Sep '16

Fabian Freyer (1): bhyve: Separate out checks from virBhyveProbeCaps Roman Bogorodskiy (1): bhyve: add e1000 nic support src/bhyve/bhyve_capabilities.c | 58 ++++++++++++++++++---- src/bhyve/bhyve_capabilities.h | 1 + src/bhyve/bhyve_command.c | 32 ++++++++++-- .../bhyvexml2argvdata/bhyvexml2argv-net-e1000.args | 9 ++++ .../bhyvexml2argv-net-e1000.ldargs | 3 ++ .../bhyvexml2argvdata/bhyvexml2argv-net-e1000.xml | 22 ++++++++ tests/bhyvexml2argvtest.c | 7 ++- 7 files changed, 118 insertions(+), 14 deletions(-) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.xml -- 2.9.2

2 4

[libvirt] [PATCH] libvirt-nodedev.c:fix a typo
by Nitesh Konkar 22 Sep '16

22 Sep '16

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- src/libvirt-nodedev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c index e4e9836..59f020b 100644 --- a/src/libvirt-nodedev.c +++ b/src/libvirt-nodedev.c @@ -595,7 +595,7 @@ virNodeDeviceDetachFlags(virNodeDevicePtr dev, * virNodeDeviceReAttach: * @dev: pointer to the node device * - * Re-attach a previously dettached node device to the node so that it + * Re-attach a previously detached node device to the node so that it * may be used by the node again. * * Depending on the hypervisor, this may involve operations such -- 2.1.0

2 1

[libvirt] [PATCH] libvirt-admin.c:fix a typo
by Nitesh Konkar 22 Sep '16

22 Sep '16

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- src/libvirt-admin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c index 03245b6..88eef54 100644 --- a/src/libvirt-admin.c +++ b/src/libvirt-admin.c @@ -344,7 +344,7 @@ virAdmConnectRef(virAdmConnectPtr conn) * @libVer: where to store the library version * * Provides version information. @libVer is the version of the library and will - * allways be set unless an error occurs in which case an error code and a + * always be set unless an error occurs in which case an error code and a * generic message will be returned. @libVer format is as follows: * major * 1,000,000 + minor * 1,000 + release. * -- 2.1.0

2 1

[libvirt] [PATCH] domain_conf.c:fix a typo
by Nitesh Konkar 22 Sep '16

22 Sep '16

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ea246b0..28b81d2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -25447,7 +25447,7 @@ virDomainDiskDefCheckDuplicateInfo(const virDomainDiskDef *a, } /* Duplicate WWN/serial isn't usually problematic for the OS and - * forbiding it would possibly inhibit using multipath configurations */ + * forbidding it would possibly inhibit using multipath configurations */ return 0; } -- 2.1.0

2 1

[libvirt] [PATCH] driver.c:fix a typo
by Nitesh Konkar 22 Sep '16

22 Sep '16

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- src/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/driver.c b/src/driver.c index 1514a3b..67ac020 100644 --- a/src/driver.c +++ b/src/driver.c @@ -38,7 +38,7 @@ VIR_LOG_INIT("driver"); #ifdef WITH_DRIVER_MODULES -/* XXX re-implment this for other OS, or use libtools helper lib ? */ +/* XXX re-implement this for other OS, or use libtools helper lib ? */ # include <dlfcn.h> # define DEFAULT_DRIVER_DIR LIBDIR "/libvirt/connection-driver" -- 2.1.0

2 1

[libvirt] [PATCH] domain_conf.c:fix the comment.
by Nitesh Konkar 22 Sep '16

22 Sep '16

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ebddf5f..7daf2fd 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14091,9 +14091,9 @@ void virDomainNetRemoveHostdev(virDomainDefPtr def, virDomainNetDefPtr net) { - /* hostdev net devices are normally also be in the hostdevs - * array, but might have already been removed by the time we - * get here. + /* hostdev net devices are normally in the hostdevs + * array, but might have already been removed by the + * time we get here. */ virDomainHostdevDefPtr hostdev = virDomainNetGetActualHostdev(net); size_t i; -- 2.1.0

2 1

[libvirt] [PATCH] domain_conf.c:fix a typo
by Nitesh Konkar 22 Sep '16

22 Sep '16

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a70be31..ebddf5f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13936,7 +13936,7 @@ void virDomainDiskInsertPreAlloced(virDomainDefPtr def, virDomainDiskDefPtr disk) { int idx; - /* Tenatively plan to insert disk at the end. */ + /* Tentatively plan to insert disk at the end. */ int insertAt = -1; /* Then work backwards looking for disks on -- 2.1.0

2 1

[libvirt] [PATCH v4 0/2] qemu/gluster: add option for tuning debug logging level
by Prasanna Kumar Kalever 22 Sep '16

22 Sep '16

v4: Address comments by peter on v3 Mostly betterments in naming variables and grouping patterns in Caps by 5 Thanks to Peter v3: Add patch 2/2 which address capability checks Changed 'glusterfs_debug_level' to 'gluster_debug_level' agreeing to Peter Made changes in libvirtd_qemu.aug Thanks to Peter & Daniel v2: Modify test cases and syntax check changes as suggested by Peter in v1. Rename qemu_gfapi_debuglevel to glusterfs_debug_level as per Daniel comments. Fix to make debug_level changes effects on URI along with JSON. TODO: * changes in libvirtd_qemu.aug Which I don't understand for now * comment on debug_level variable in storage source Not sure what is the right place * Capablities check v1: Initial post *** BLURB HERE *** Prasanna Kumar Kalever (2): qemu/gluster: add option for tuning debug logging level qemu_capabilities: Introduce gluster specific debug capability src/qemu/libvirtd_qemu.aug | 3 +++ src/qemu/qemu.conf | 20 ++++++++++++++++++++ src/qemu/qemu_capabilities.c | 5 +++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 21 ++++++++++++++++++--- src/qemu/qemu_conf.c | 3 +++ src/qemu/qemu_conf.h | 1 + src/util/virstoragefile.h | 2 ++ .../qemuargv2xml-disk-drive-network-gluster.args | 7 ++++--- .../qemuxml2argv-disk-drive-network-gluster.args | 12 ++++++------ tests/qemuxml2argvtest.c | 3 ++- 11 files changed, 65 insertions(+), 13 deletions(-) -- 2.7.4

3 6

[libvirt] [libvirt-php][PATCH] libvirt_domain_get_screenshot_api: More memleak fixes and checks
by Michal Privoznik 22 Sep '16

22 Sep '16

Firstly, we are not checking whether virStreamNew succeeds or not. Secondly, we are not freeing the stream in all exit paths. Then we are copying the same pattern which frees allocated memory over and over again. Oh, and also we should abort stream if we are exiting abnormally. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under "I'm a lonely libvirt-php maintainer" rule. src/libvirt-php.c | 64 +++++++++++++++++++++++++++++-------------------------- 1 file changed, 34 insertions(+), 30 deletions(-) diff --git a/src/libvirt-php.c b/src/libvirt-php.c index 3aed882..df2f32a 100644 --- a/src/libvirt-php.c +++ b/src/libvirt-php.c @@ -4758,49 +4758,38 @@ PHP_FUNCTION(libvirt_domain_get_screenshot_api) RETURN_FALSE; #endif - GET_DOMAIN_FROM_ARGS("r|l",&zdomain, &screen); + GET_DOMAIN_FROM_ARGS("r|l", &zdomain, &screen); + + if (!(st = virStreamNew(domain->conn->conn, 0))) { + set_error("Cannot create new stream" TSRMLS_CC); + goto error; + } - st = virStreamNew(domain->conn->conn, 0); mime = virDomainScreenshot(domain->domain, st, screen, 0); if (!mime) { set_error_if_unset("Cannot get domain screenshot" TSRMLS_CC); - RETURN_FALSE; + goto error; } -#ifndef EXTWIN - if (mkstemp(file) == 0) { - free(mime); - RETURN_FALSE; - } -#endif - - if ((fd = open(file, O_WRONLY|O_CREAT|O_EXCL, 0666)) < 0) { - if (errno != EEXIST || - (fd = open(file, O_WRONLY|O_TRUNC, 0666)) < 0) { - virStreamFree(st); - set_error_if_unset("Cannot get create file to save domain screenshot" TSRMLS_CC); - free(mime); - RETURN_FALSE; - } + if (!(fd = mkstemp(file))) { + virStreamAbort(st); + set_error_if_unset("Cannot get create file to save domain screenshot" TSRMLS_CC); + goto error; } if (virStreamRecvAll(st, streamSink, &fd) < 0) { - virStreamFree(st); set_error_if_unset("Cannot receive screenshot data" TSRMLS_CC); - free(mime); - RETURN_FALSE; + virStreamAbort(st); + goto error; } - close(fd); - if (virStreamFinish(st) < 0) { - virStreamFree(st); set_error_if_unset("Cannot close stream for domain" TSRMLS_CC); - free(mime); - RETURN_FALSE; + goto error; } virStreamFree(st); + st = NULL; array_init(return_value); if (bin) { @@ -4811,19 +4800,34 @@ PHP_FUNCTION(libvirt_domain_get_screenshot_api) snprintf(fileNew, sizeof(fileNew), "%s.png", file); snprintf(tmp, sizeof(tmp), "%s %s %s > /dev/null 2> /dev/null", bin, file, fileNew); exitStatus = system(tmp); - unlink(file); if (WEXITSTATUS(exitStatus) != 0) - RETURN_FALSE; + goto error; + unlink(file); + close(fd); + fd = -1; VIRT_ADD_ASSOC_STRING(return_value, "file", fileNew); VIRT_ADD_ASSOC_STRING(return_value, "mime", "image/png"); - } - else { + } else { + unlink(file); + close(fd); + fd = -1; VIRT_ADD_ASSOC_STRING(return_value, "file", file); VIRT_ADD_ASSOC_STRING(return_value, "mime", mime); } free(mime); + return; + + error: + free(mime); + if (fd != -1) { + unlink(file); + close(fd); + } + if (st) + virStreamFree(st); + RETURN_FALSE; } /* -- 2.8.4

1 0

[libvirt] [PATCH 0/4] qemu: fix vcpupin/emulatorpin with --config on VMs with automatic NUMA pinning
by Peter Krempa 22 Sep '16

22 Sep '16

The automatic nodeset would creep into the persistent definition for live VMs with automatic pinning which is incorrect. https://bugzilla.redhat.com/show_bug.cgi?id=1365779 Peter Krempa (4): conf: Introduce virDomainObjGetOneDefState qemu: domain: Add macro to simplify access to vm private data qemu: driver: Don't return automatic NUMA vCPU pinning data for persistentDef qemu: driver: Don't return automatic NUMA emulator pinning data for persistentDef src/conf/domain_conf.c | 40 ++++++++++++++++++++++++++++++++++++---- src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_domain.h | 3 +++ src/qemu/qemu_driver.c | 23 +++++++++++++---------- 5 files changed, 56 insertions(+), 14 deletions(-) -- 2.10.0

3 9