- Devel - libvirt List Archives

[libvirt] [PATCH v2 0/6] Split out node device object into its own module
by John Ferlan 03 Mar '17

03 Mar '17

v1: http://www.redhat.com/archives/libvir-list/2017-March/msg00046.html Differences... patch 1 and 3 are the same and both were ACK'd patch 2 removes the lower case function name changes (a/k/a "vir" removal) patch 4 is new adding modifications as requested by Pavel from patch 1 comment patch 5 & 6 are new based on a type A reaction to seeing a deeply nested structure and picking it apart to allow for more direct access to the data fields via pointers which patch6 dutify does for virNodeDevCapDataPtr John Ferlan (6): conf: Introduce virnodedeviceobj conf: Adjust coding style for nodedev conf sources conf: Use consistent function name prefixes for virnodedeviceobj conf: Alter coding style of nodedev function prototypes conf: Clean up the _virNodeDevCapData nodedev: Reduce virNodeDevCapDataPtr usage po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/conf/node_device_conf.c | 757 ++++++------------------------ src/conf/node_device_conf.h | 316 ++++++------- src/conf/virnodedeviceobj.c | 558 ++++++++++++++++++++++ src/conf/virnodedeviceobj.h | 92 ++++ src/libvirt_private.syms | 23 +- src/node_device/node_device_driver.c | 30 +- src/node_device/node_device_driver.h | 2 +- src/node_device/node_device_hal.c | 14 +- src/node_device/node_device_linux_sysfs.c | 134 +++--- src/node_device/node_device_linux_sysfs.h | 4 +- src/node_device/node_device_udev.c | 198 ++++---- src/test/test_driver.c | 29 +- 14 files changed, 1164 insertions(+), 997 deletions(-) create mode 100644 src/conf/virnodedeviceobj.c create mode 100644 src/conf/virnodedeviceobj.h -- 2.9.3

3 10

[libvirt] [PATCH RFC 0/4] libxl: qemu agent support
by Joao Martins 03 Mar '17

03 Mar '17

Hey! Back when channels were introduced in libxl (in answer to Michal[0]) I suggested the idea of integrating qemu guest agent (which currently lives qemu driver). This series is an attempt at pulling qemu agent from qemu driver into util in using it in libxl in subsequent patches. What do folks think of the idea? Note that this is still all very RFC because 1) there's a lot of code we could potentially share between qemu and libxl with respect to finding guest agent config and keeping some of its state (see patch 3); 2) also we need to ignore "execute" messages to be able to query the agent and see it's returned data (patch 2). Which despite the commit not being incorrect I am not sure yet why we need it yet. As PoC I only implemented domainQemuAgentCommand/domainInterfaceAddresses, but there's a lot more driver APIs we can potentially introduce after this. Tracing all driver APIs that might require a guest agent: * domainFSThaw, domainFSFreeze, domainFSTrim, domainGetFSInfo * domainSetUserPassword * domainGetTime, domainSetTime * domainShutdown (with VIR_DOMAIN_SHUTDOWN_GUEST_AGENT) * domainReboot (with VIR_DOMAIN_REBOOT_GUEST_AGENT) * domainGetGuestVcpus * domainSetGuestVcpus * domainSetVcpusFlags (with VIR_DOMAIN_VCPU_GUEST) * domainGetVcpusFlags (with VIR_DOMAIN_VCPU_GUEST) Comments/Feedback is appreciated :) Cheers, Joao [0] https://www.spinics.net/linux/fedora/libvir/msg136685.html Joao Martins (4): qemu_agent: move agent into util qemu_agent: ignore requests echoed back by guest libxl: implement qemu-agent-command libxl: domainInterfaceAddresses agent support po/POTFILES.in | 2 +- src/Makefile.am | 2 +- src/libvirt_private.syms | 21 + src/libxl/libxl_domain.c | 239 ++++- src/libxl/libxl_domain.h | 16 + src/libxl/libxl_driver.c | 69 ++ src/qemu/qemu_agent.c | 2248 ----------------------------------------- src/qemu/qemu_agent.h | 123 --- src/qemu/qemu_domain.h | 2 +- src/qemu/qemu_driver.c | 2 +- src/util/virqemuagent.c | 2249 ++++++++++++++++++++++++++++++++++++++++++ src/util/virqemuagent.h | 123 +++ tests/qemuagenttest.c | 2 +- tests/qemumonitortestutils.c | 2 +- tests/qemumonitortestutils.h | 2 +- 15 files changed, 2723 insertions(+), 2379 deletions(-) delete mode 100644 src/qemu/qemu_agent.c delete mode 100644 src/qemu/qemu_agent.h create mode 100644 src/util/virqemuagent.c create mode 100644 src/util/virqemuagent.h -- 2.1.4

3 17

[libvirt] [PATCH] news: Add an empty <change> to each <section>
by Andrea Bolognani 03 Mar '17

03 Mar '17

The generated HTML will contain <ul></ul> otherwise, which triggers an error during 'make check'. The proper fix would be not to generate the problematic HTML in the first place but, while I'm working on it, this workaround will do. --- Pushed as build-breaker. Sorry for the noise. docs/news.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index bb67619..675faa7 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -12,10 +12,13 @@ <libvirt> <release version="v3.2.0" date="unreleased"> <section title="New features"> + <change/> </section> <section title="Improvements"> + <change/> </section> <section title="Bug fixes"> + <change/> </section> </release> <release version="v3.1.0" date="2017-03-03"> -- 2.7.4

1 0

[libvirt] [PATCH] Post-release version bump to 3.2.0
by Andrea Bolognani 03 Mar '17

03 Mar '17

--- Pushed as trivial. configure.ac | 2 +- docs/news.xml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ed49daa..e61ab7b 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [3.1.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [3.2.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/docs/news.xml b/docs/news.xml index 3cb93c3..bb67619 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -10,6 +10,14 @@ and optionally a description where it's explained in more detail --> <libvirt> + <release version="v3.2.0" date="unreleased"> + <section title="New features"> + </section> + <section title="Improvements"> + </section> + <section title="Bug fixes"> + </section> + </release> <release version="v3.1.0" date="2017-03-03"> <section title="New features"> <change> -- 2.7.4

1 0

[libvirt] Availability of libvirt-3.1.0
by Daniel Veillard 03 Mar '17

03 Mar '17

I'm a bit late but I finally pushed the release, the signed tarball and rpms are at the usual place: ftp://libvirt.org/libvirt/ I also pushed a libvirt-python release that one can find at ftp://libvirt.org/libvirt/python/ * New features - storage: Add Virtuozzo storage backend storage pool Add new storage backend to support pool and volume management within the Virtuozzo Storage environment. Virtuozzo Storage is a highly available distributed software defined storage with built-in replication and disaster recovery. - qemu: Add support for memory backing with file source Add support in numa topology for file source inside memory backing (hugepages are not needed) Three new elements <source/>,<access/> and <allocation/> were added to <memoryBacking/> element. Also new configuration parameter memory_backing_dir was added to qemu.conf. - network: make openvswitch call timeout configurable Adding the ability to specify the timeout value in seconds for openvswitch calls in the libvirtd configuration file. - bhyve: add e1000 NIC support Add support for e1000 NIC. Previously, the only available option was virtio-net. - libxl: add tunneled migration support Add tunneled migration to libxl driver, which is always capable of strong encryption and doesn't require any extra network connection other than what's required for remote access of libvirtd. - qemu: add rendernode argument Add a new attribute 'rendernode' to <gl> spice element. - nodedev: add drm capability Add a new 'drm' capability for Direct Rendering Manager (DRM) devices, providing device type information. - Add API for individual/specific vCPU hotplug The new API allows selecting specific vCPUs to be added/removed from the VM. The existing APIs allowed only adding/removing from the end which did not play well with NUMA. * Improvements - virsh: pool-list: allow both --uuid and --name in one command Adjust the virsh-pool command to support the --uuid and/or --name options in order to print just the --name and/or --uuid of pools. - Introduce MTU to domain <interface/> and <network> Allow setting MTU size for some types of domain interface and network. - libxl: improve support for <timer> configurations Add support for multiple timers. Extend the tsc timer to support the emulate mode. Improve conversion of timer XML to/from xl.cfg. - storage: modularize the storage driver Split up the storage driver backends into loadable modules so that binary distributions don't have to compromise on shipping the storage driver with all backends which may pull in too many dependencies. * Bug fixes - nodedev: Fabric name must not be required for fc_host capability fabric_name is one of many fc_host attributes in Linux that is optional and left to the low-level driver to decide if it is implemented. For example the zfcp device driver does not provide a fabric name for an fcp host. The requirement for the existence of a fabric name has been removed by making it optional. - bhyve: change address allocation schema for SATA disks Previously, the bhyve driver assigned PCI addresses to SATA disks directly rather than assigning that to a controller and using SATA addresses for disks. It was implemented this way because bhyve has no notion of an explicit SATA controller. However, as this doesn't match libvirt's understanding of disk addresses, the bhyve driver was changed to follow the common schema and have PCI addresses for SATA controllers and SATA addresses for disks. If you're having issues because of this, it's recommended to edit the domain's XML and remove <address type='pci'> from the <disk> elements with <target bus='sata'/> and let libvirt regenerate it properly. - libxl: maximum memory fixes Fix reporting of domain maximum memory. Fix setting dom0 maximum memory. - libxl: fix disk detach when <driver> not specified - libxl: fix dom0 autoballooning with Xen 4.8 - qemu: Allow empty script path to <interface/> Historically, this was always allowed. Unfortunately, due to some rework done for 1.3.2 release a bug was dragged in which suddenly stop allowing domain with such configuration to start. Thanks everybody for your contributions for this release, be it with code, bug reports, ideas, etc.... Enjoy the release ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [RFC v2 0/2] vireventpoll implimentation using epoll
by Derbyshev Dmitriy 03 Mar '17

03 Mar '17

From: Derbyshev Dmitry <dderbyshev(a)virtuozzo.com> Provides about 20% boost on local machine with 35 vms. virEventPollDispatchHandles can also be split to pass cb via epoll data field. Should start sending as PATCH instead? Changes since v1: * ifdef supstituded by 2 .c files with vireventpollinternal.h implementations * PROBE purged Derbyshev Dmitry (2): vireventpoll: isolate common code vireventpoll implimentation using epoll configure.ac | 28 + src/Makefile.am | 12 +- src/util/vireventepoll.c | 201 +++++++ src/util/vireventpoll.c | 700 ++-------------------- src/util/{vireventpoll.c => vireventpollcommon.c} | 231 ++----- src/util/vireventpollinternal.h | 91 +++ tests/commanddata/{test14.log => test3epoll.log} | 2 + tests/commandtest.c | 4 + 8 files changed, 451 insertions(+), 818 deletions(-) create mode 100644 src/util/vireventepoll.c copy src/util/{vireventpoll.c => vireventpollcommon.c} (78%) create mode 100644 src/util/vireventpollinternal.h copy tests/commanddata/{test14.log => test3epoll.log} (94%) -- 1.9.5.msysgit.0

3 4

[libvirt] [PATCH 0/2] qemu: Tiny cleanups
by Andrea Bolognani 02 Mar '17

02 Mar '17

Andrea Bolognani (2): qemu: Don't omit parentheses qemu: Use ARCH_IS_X86() more src/qemu/qemu_capabilities.c | 17 ++++++----------- src/qemu/qemu_parse_command.c | 6 ++---- 2 files changed, 8 insertions(+), 15 deletions(-) -- 2.7.4

2 4

[libvirt] [PATCH 0/2] Test suite fixes and small cleanups
by Andrea Bolognani 02 Mar '17

02 Mar '17

Andrea Bolognani (2): qemu: Drop QEMU_CAPS_PCI_MULTIBUS tests: Fix aliases for pSeries buses src/qemu/qemu_capabilities.c | 36 ++++++++-------------- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_capspriv.h | 4 +++ tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 - .../qemuxml2argv-memory-hotplug-ppc64-nonuma.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-ppc-dtb.args | 2 +- .../qemuxml2argv-ppc64-usb-controller-legacy.args | 2 +- .../qemuxml2argv-ppc64-usb-controller.args | 4 +-- .../qemuxml2argv-ppce500-serial.args | 2 +- .../qemuxml2argv-pseries-usb-default.args | 2 +- .../qemuxml2argv-pseries-usb-kbd.args | 2 +- .../qemuxml2argv-pseries-usb-multi.args | 4 +-- tests/qemuxml2argvtest.c | 8 +++-- 25 files changed, 32 insertions(+), 51 deletions(-) -- 2.7.4

2 3

[libvirt] [PATCH] Add aarch64 to virArch
by Matwey V. Kornilov 02 Mar '17

02 Mar '17

Hello, This patch is for allowing 32-bit ARMs for aarch64 hosts. Exact 32-bit personality for aarch64 is aarch32, but there is no such arch in libvirt, so we use arvm7l instead. Matwey V. Kornilov (1): Add aarch64 to virArch src/lxc/lxc_container.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.1.4

2 2

[libvirt] [PATCH 0/3] Split out node device object into its own module
by John Ferlan 02 Mar '17

02 Mar '17

Feedback from the initial pass at RFC for making a common pool object was that it got really confusing trying to manage the multitude of changes. See patch 3 of the series: http://www.redhat.com/archives/libvir-list/2017-February/msg00519.html So while I figure out what it'll take to make a better object framework, I figure I could start splitting out things a bit to make future work a bit easier to understand. Also rather than trying to do them all in one massive series, I can do shorter series contained to each of the driver conf's. Besides let's figure out whether all the thoughts and ideas are good. I would think moving to virnodedeviceobj wouldn't be an issue (other than needing to deal with backports). However, I'm sure there could be some "alternate opinions" over whether to make static functions not start with vir[DriverSubsystem] and rather go with driverSubsystem. Changing the API's to use the Obj is mainly a consistency thing. Let's see what falls out of this before I start queuing up other ones as it's a lot of rote work! John Ferlan (3): conf: Introduce virnodedeviceobj conf: Clean up nodedev code conf: Use consistent function name prefixes for virnodedeviceobj po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/conf/node_device_conf.c | 981 +++++++++-------------------------- src/conf/node_device_conf.h | 50 -- src/conf/virnodedeviceobj.c | 558 ++++++++++++++++++++ src/conf/virnodedeviceobj.h | 78 +++ src/libvirt_private.syms | 23 +- src/node_device/node_device_driver.c | 24 +- src/node_device/node_device_driver.h | 2 +- src/node_device/node_device_hal.c | 10 +- src/node_device/node_device_udev.c | 12 +- src/test/test_driver.c | 29 +- 12 files changed, 940 insertions(+), 831 deletions(-) create mode 100644 src/conf/virnodedeviceobj.c create mode 100644 src/conf/virnodedeviceobj.h -- 2.9.3

5 19