- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: fix crash on getting block stats for empty cdrom
by Nikolay Shirokovskiy 13 Apr '17

13 Apr '17

Looks like it was introduced in c5f61513. Before this commit handling empty cdrom was correct becase physical sizes of non block disks are not updated. Now when all types are supported we need to check for empty drives. [1] crash backtrace 0 __strrchr_sse42 () at ../sysdeps/x86_64/multiarch/strrchr.S:138 1 0x00007ffff7242192 in virFileIsSharedFSType (path=0x0, fstypes=63) at util/virfile.c:3351 2 0x00007ffff7242a5b in virFileIsSharedFS (path=0x0) at util/virfile.c:3557 3 0x00007fffdb835443 in qemuOpenFileAs (fallback_uid=0, fallback_gid=107, dynamicOwnership=true, path=0x0, oflags=0, needUnlink=0x0, bypassSecurityDriver=0x0) at qemu/qemu_driver.c:2927 4 0x00007fffdb83539b in qemuOpenFile (driver=0x7fffcc1062f0, vm=0x7fffcc25aa50, path=0x0, oflags=0, needUnlink=0x0, bypassSecurityDriver=0x0) at qemu/qemu_driver.c:2908 5 0x00007fffdb84d2d3 in qemuDomainStorageOpenStat (driver=0x7fffcc1062f0, cfg=0x7fffcc188880, vm=0x7fffcc25aa50, src=0x7fffcc256920, ret_fd=0x7fffe6a49488, ret_sb=0x7fffe6a49490) at qemu/qemu_driver.c:11266 6 0x00007fffdb84d4ff in qemuDomainStorageUpdatePhysical (driver=0x7fffcc1062f0, cfg=0x7fffcc188880, vm=0x7fffcc25aa50, src=0x7fffcc256920) at qemu/qemu_driver.c:11319 7 0x00007fffdb8661e7 in qemuDomainGetStatsOneBlock (driver=0x7fffcc1062f0, cfg=0x7fffcc188880, dom=0x7fffcc25aa50, record=0x7fffa8000e70, maxparams=0x7fffe6a49790, disk=0x7fffcc2565a0, src=0x7fffcc256920, block_idx=7, backing_idx=0, stats=0x7fffa8000e90) at qemu/qemu_driver.c:19223 8 0x00007fffdb86652b in qemuDomainGetStatsBlock (driver=0x7fffcc1062f0, dom=0x7fffcc25aa50, record=0x7fffa8000e70, maxparams=0x7fffe6a49790, privflags=1) at qemu/qemu_driver.c:19282 9 0x00007fffdb8669f7 in qemuDomainGetStats (conn=0x7fffb80009a0, dom=0x7fffcc25aa50, stats=127, record=0x7fffe6a49870, flags=1) at qemu/qemu_driver.c:19444 10 0x00007fffdb866dc8 in qemuConnectGetAllDomainStats (conn=0x7fffb80009a0, doms=0x0, ndoms=0, stats=127, retStats=0x7fffe6a499a0, flags=1) at qemu/qemu_driver.c:19534 11 0x00007ffff7388376 in virConnectGetAllDomainStats (conn=0x7fffb80009a0, stats=0, retStats=0x7fffe6a499a0, flags=1) at libvirt-domain.c:11311 --- src/qemu/qemu_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bc5e448..16b435a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19170,6 +19170,7 @@ qemuDomainGetStatsOneBlock(virQEMUDriverPtr driver, QEMU_ADD_NAME_PARAM(record, maxparams, "block", "name", block_idx, disk->dst); + if (virStorageSourceIsLocalStorage(src) && src->path) QEMU_ADD_NAME_PARAM(record, maxparams, "block", "path", block_idx, src->path); @@ -19216,7 +19217,7 @@ qemuDomainGetStatsOneBlock(virQEMUDriverPtr driver, if (entry->capacity) QEMU_ADD_BLOCK_PARAM_ULL(record, maxparams, block_idx, "capacity", entry->capacity); - if (entry->physical) { + if (entry->physical || virStorageSourceIsEmpty(src)) { QEMU_ADD_BLOCK_PARAM_ULL(record, maxparams, block_idx, "physical", entry->physical); } else { -- 1.8.3.1

1 1

[libvirt] [PATCH] test: virsh-optparse: Fix expected test output with new error checking
by Peter Krempa 13 Apr '17

13 Apr '17

Commit 4f4c3b1397c4b5d16af added code to remember errors during freeing of domain objects. This changed the output when testing scaled numbers parsing in virsh-optparse. Adjust the expected output. --- I didn't run it with VIR_TEST_RUN_EXPENSIVE. I'll look into whether that variable still makes sense. Pushed under the build-breaker rule. tests/virsh-optparse | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/virsh-optparse b/tests/virsh-optparse index cb0f3d4f3..1aef8d8d9 100755 --- a/tests/virsh-optparse +++ b/tests/virsh-optparse @@ -212,6 +212,7 @@ compare exp-err err || fail=1 # Numeric value with invalid suffix cat <<\EOF > exp-err || framework_failure error: Scaled numeric value '42WB' for <size> option is malformed or out of range +error: invalid argument: unknown suffix 'WB' EOF virsh -q -c $test_url setmaxmem test 42WB >out 2>err && fail=1 test -s out && fail=1 -- 2.12.2

1 0

[libvirt] question about virtlogd service restart
by Wang King 13 Apr '17

13 Apr '17

Hi all, I found that virtlogd cannot write qemu log and serial log anymore after restart it. It's because of the file descriptor which qemu connected to the virtlogd is broken, and cannot be reconnect after virtlogd restarted. Is this expected behavior or unresolved issue? Thanks Wang King

2 1

[libvirt] [PATCH] qemu: do not crash on USB address with no port and invalid bus
by Ján Tomko 12 Apr '17

12 Apr '17

Properly error out when the user requests a port from a bus that does not have a controller present in the domain XML. https://bugzilla.redhat.com/show_bug.cgi?id=1441589 --- src/conf/domain_addr.c | 3 ++- .../qemuxml2argv-usb-bus-missing.xml | 22 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 3 +++ 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-bus-missing.xml diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 35bdc34..8b61091 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -2009,7 +2009,8 @@ virDomainUSBAddressAssign(virDomainUSBAddressSetPtr addrs, if (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB) { VIR_DEBUG("A USB port on bus %u was requested", info->addr.usb.bus); - if (!addrs->buses[info->addr.usb.bus]) { + if (info->addr.usb.bus >= addrs->nbuses || + !addrs->buses[info->addr.usb.bus]) { virReportError(VIR_ERR_XML_ERROR, _("USB bus %u requested but no controller " "with that index is present"), info->addr.usb.bus); diff --git a/tests/qemuxml2argvdata/qemuxml2argv-usb-bus-missing.xml b/tests/qemuxml2argvdata/qemuxml2argv-usb-bus-missing.xml new file mode 100644 index 0000000..831a4c0 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-usb-bus-missing.xml @@ -0,0 +1,22 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <devices> + <emulator>/usr/bin/qemu-system-i686</emulator> + <controller type='usb' index='0'/> + <memballoon model='virtio'/> + <input type='mouse' bus='usb'> + <address type='usb' bus='0'/> + </input> + <hub type='usb'> + <address type='usb' bus='1'/> + </hub> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index ed99c21..c1b014b 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1341,6 +1341,9 @@ mymain(void) DO_TEST("usb-port-missing", QEMU_CAPS_CHARDEV, QEMU_CAPS_USB_HUB, QEMU_CAPS_NODEFCONFIG); + DO_TEST_PARSE_ERROR("usb-bus-missing", + QEMU_CAPS_CHARDEV, QEMU_CAPS_USB_HUB, + QEMU_CAPS_NODEFCONFIG); DO_TEST("usb-ports", QEMU_CAPS_CHARDEV, QEMU_CAPS_USB_HUB, QEMU_CAPS_NODEFCONFIG); -- 2.10.2

2 1

[libvirt] [PATCH 0/5] Enable CI build testing with Travis
by Daniel P. Berrange 12 Apr '17

12 Apr '17

Since we already sync our repo to github, we can easily take advantage of the free Travis CI system to improve our testing coverage. Our current CentOS CI hardware doesn't have scope for running many more VMs than it already does and even if it did, that imposes an administrative burden to manage the OS. So this uses Travis to get us automated testing of Ubuntu Precise & Trusty, with GCC and CLang, and OS-X with CLang. Daniel P. Berrange (5): annotate all mocked functions with noinline Prevent test failures with ebtables/iptables/ip6tables are missing Fix detection of required RBD version Ignore SASL deprecation warnings on OS-X Add travis build configuration .travis.yml | 85 ++++++++++++++++++++++++++++++++++++++++ build-aux/mock-noinline.pl | 72 ++++++++++++++++++++++++++++++++++ cfg.mk | 6 ++- m4/virt-storage-rbd.m4 | 16 +++++++- src/internal.h | 22 +++++++++++ src/qemu/qemu_capspriv.h | 2 +- src/rpc/virnetsaslcontext.c | 12 ++++++ src/rpc/virnetsocket.h | 6 ++- src/util/vircommand.h | 2 +- src/util/vircrypto.h | 2 +- src/util/virfile.h | 2 +- src/util/virhostcpu.h | 4 +- src/util/virmacaddr.h | 2 +- src/util/virnetdev.h | 9 +++-- src/util/virnetdevip.h | 2 +- src/util/virnetdevopenvswitch.h | 2 +- src/util/virnetdevtap.h | 6 +-- src/util/virnuma.h | 16 ++++---- src/util/virrandom.h | 6 +-- src/util/virscsi.h | 2 +- src/util/virscsivhost.h | 2 +- src/util/virtpm.h | 2 +- src/util/virutil.h | 10 ++--- src/util/viruuid.h | 2 +- tests/networkxml2firewalltest.c | 13 ++++++ tests/nwfilterebiptablestest.c | 13 ++++++ tests/nwfilterxml2firewalltest.c | 12 ++++++ tests/virfirewalltest.c | 13 ++++++ 28 files changed, 302 insertions(+), 41 deletions(-) create mode 100644 .travis.yml create mode 100644 build-aux/mock-noinline.pl -- 2.9.3

4 8

[libvirt] [PATCH 0/2] Fixes for CI virt-manager test failures
by John Ferlan 12 Apr '17

12 Apr '17

Test began failing after commit 'd06d1a32' and 'be3c2dfd': https://ci.centos.org/view/libvirt/job/virt-manager-master-check/systems=li… Needed to fix the aclfilter check in both NumOfDevices and GetNames John Ferlan (2): conf: Fix virNodeDeviceObjGetNames nnames increment nodedev: Fix aclfilter check src/conf/virnodedeviceobj.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.9.3

3 4

[libvirt] [PATCH v2 0/2] Simplify perf events handling a little
by Daniel P. Berrange 12 Apr '17

12 Apr '17

This was previously posted & acked here: https://www.redhat.com/archives/libvir-list/2016-December/msg00795.html but then i forgot to push it and also notice a bug in the first place. There were conflicts against current master too, so I'm reposting for new ACK.. Daniel P. Berrange (2): perf: get rid of pointless virPerfGetEventAttr() method perf: get rid of pointless virPerfGetEvent() method src/util/virperf.c | 185 +++++++++++++++++++++-------------------------------- 1 file changed, 73 insertions(+), 112 deletions(-) -- 2.9.3

2 5

[libvirt] RFC: fixing struct name in public header
by Daniel P. Berrange 12 Apr '17

12 Apr '17

Take a look at this def from libvirt-domain.h: typedef struct _virDomainInterfaceIPAddress virDomainIPAddress; typedef virDomainIPAddress *virDomainIPAddressPtr; struct _virDomainInterfaceIPAddress { int type; /* virIPAddrType */ char *addr; /* IP address */ unsigned int prefix; /* IP address prefix */ }; Notice the struct name is different from the typedef names. Technically renaming the struct to remove the 'Interface' word would be an API break. On the flip side though we don't expect any apps to use the struct name, but rather use the typedefs, hence use of '_' in the name. We could do what we did with the typed parameter stuff and rename the struct, but add a #define _virDomainInterfaceIPAddress _virDomainIPAddress Any thoughts ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|

4 4

[libvirt] [PATCH 0/2] qemu: conf: Fix memory leaks
by Peter Krempa 12 Apr '17

12 Apr '17

Peter Krempa (2): qemu: conf: Don't leak snapshot image format conf variable qemu: conf: Don't leak 'namespaces' temporary variable while parsing config src/qemu/qemu_conf.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.12.2

2 3

[libvirt] [PATCH] util: fix potential segfault
by Wang King 12 Apr '17

12 Apr '17

virBufferCurrentContent might be get a NULL string, and then without checking it, this can cause a segfault as strlen expects a string != NULL. Use virBufferCheckError to check error before calling strlen. --- src/util/virsystemd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index ceb1c1a..cfc4bdb 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -135,6 +135,8 @@ virSystemdAppendValidMachineName(virBufferPtr buf, bool skip_dot = false; for (; *name; name++) { + if (virBufferCheckError(buf) < 0) + break; if (strlen(virBufferCurrentContent(buf)) >= 64) break; -- 2.8.3

2 1