- Devel - libvirt List Archives

[libvirt] [PATCH] rpc: Allow up to 256K records to be returned from virConnectGetAllDomainStats.
by Richard W.M. Jones 26 May '17

26 May '17

In commit 89a706681cb3a4aa003d920db3163b809cfbc9ca, the returned array of stats is limited to REMOTE_DOMAIN_LIST_MAX entries (4096). As well as being far too low -- this breaks if a single guest is added with 320 disks -- it also seems as if use of REMOTE_DOMAIN_LIST_MAX was a mistake, and it should be using REMOTE_CONNECT_GET_ALL_DOMAIN_STATS_MAX instead. However REMOTE_CONNECT_GET_ALL_DOMAIN_STATS_MAX is also too low (also 4096), so this patch also increases the limit to something more sensible, allowing us to cope with lots of stats from lots of domains in future. (This limit could be increased further quite easily since each stats record takes about 32 bytes, and the maximum message size is currently 32 MB, so we could increase the limit by another factor of 4 without touching the maximum message size). I tested this using a guest with 320, 500 and 1000 disks with no issues. Signed-off-by: Richard W.M. Jones <rjones(a)redhat.com> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1440683 --- src/remote/remote_protocol.x | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index 25e62a181..142508713 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -233,7 +233,7 @@ const REMOTE_DOMAIN_FSFREEZE_MOUNTPOINTS_MAX = 256; const REMOTE_NETWORK_DHCP_LEASES_MAX = 65536; /* Upper limit on count of parameters returned via bulk stats API */ -const REMOTE_CONNECT_GET_ALL_DOMAIN_STATS_MAX = 4096; +const REMOTE_CONNECT_GET_ALL_DOMAIN_STATS_MAX = 262144; /* Upper limit of message size for tunable event. */ const REMOTE_DOMAIN_EVENT_TUNABLE_MAX = 2048; @@ -3264,7 +3264,7 @@ struct remote_domain_event_callback_agent_lifecycle_msg { }; struct remote_connect_get_all_domain_stats_ret { - remote_domain_stats_record retStats<REMOTE_DOMAIN_LIST_MAX>; + remote_domain_stats_record retStats<REMOTE_CONNECT_GET_ALL_DOMAIN_STATS_MAX>; }; struct remote_domain_fsinfo { -- 2.13.0

3 2

[libvirt] [PATCH] rpc: Double buffer size instead of quadrupling buffer size.
by Richard W.M. Jones 26 May '17

26 May '17

When increasing the buffer size up to VIR_NET_MESSAGE_MAX, we currently quadruple it each time. This unfortunately means that we cannot allow certain buffer sizes -- for example the current VIR_NET_MESSAGE_MAX == 33554432 can never be "hit" since ‘newlen’ jumps from 16MB to 64MB. Instead of quadrupling, double it each time. Thanks: Daniel Berrange. --- src/rpc/virnetmessage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetmessage.c b/src/rpc/virnetmessage.c index c3a2e595c..5908b074a 100644 --- a/src/rpc/virnetmessage.c +++ b/src/rpc/virnetmessage.c @@ -358,7 +358,8 @@ int virNetMessageEncodePayload(virNetMessagePtr msg, /* Try to encode the payload. If the buffer is too small increase it. */ while (!(*filter)(&xdr, data, 0)) { - unsigned int newlen = (msg->bufferLength - VIR_NET_MESSAGE_LEN_MAX) * 4; + unsigned int newlen = msg->bufferLength - VIR_NET_MESSAGE_LEN_MAX; + newlen *= 2; if (newlen > VIR_NET_MESSAGE_MAX) { virReportError(VIR_ERR_RPC, "%s", _("Unable to encode message payload")); -- 2.13.0

2 1

[libvirt] [PATCH] node: Don't return invalid pointers
by Peter Krempa 26 May '17

26 May '17

Commit 4337bc57be introduced code that would in certain error paths unref the last reference of a pointer, but return it. Clear the pointers before returning them --- src/node_device/node_device_driver.c | 8 ++++++-- src/test/test_driver.c | 4 +++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index ba3da6288..3a6eeaaae 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -241,8 +241,10 @@ nodeDeviceLookupByName(virConnectPtr conn, const char *name) goto cleanup; if ((ret = virGetNodeDevice(conn, name))) { - if (VIR_STRDUP(ret->parent, obj->def->parent) < 0) + if (VIR_STRDUP(ret->parent, obj->def->parent) < 0) { virObjectUnref(ret); + ret = NULL; + } } cleanup: @@ -285,8 +287,10 @@ nodeDeviceLookupSCSIHostByWWN(virConnectPtr conn, goto out; if ((dev = virGetNodeDevice(conn, obj->def->name))) { - if (VIR_STRDUP(dev->parent, obj->def->parent) < 0) + if (VIR_STRDUP(dev->parent, obj->def->parent) < 0) { virObjectUnref(dev); + dev = NULL; + } } virNodeDeviceObjUnlock(obj); goto out; diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2db3f7ddf..9330d9ea6 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5331,8 +5331,10 @@ testNodeDeviceLookupByName(virConnectPtr conn, const char *name) goto cleanup; if ((ret = virGetNodeDevice(conn, name))) { - if (VIR_STRDUP(ret->parent, obj->def->parent) < 0) + if (VIR_STRDUP(ret->parent, obj->def->parent) < 0) { virObjectUnref(ret); + ret = NULL; + } } cleanup: -- 2.12.2

2 1

[libvirt] [PATCH] node_device: fix memory leak in nodeDeviceSysfsGetSCSIHostCaps
by Yi Wang 26 May '17

26 May '17

The @tmp is allocated in virVHBAGetConfig in virVHBAIsVportCapable condition, it will lost when virVHBAGetConfig called again. Signed-off-by: Yi Wang <wang.yi59(a)zte.com.cn> --- src/node_device/node_device_linux_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/node_device/node_device_linux_sysfs.c b/src/node_device/node_device_linux_sysfs.c index 1b7aa94..a9c7c9c 100644 --- a/src/node_device/node_device_linux_sysfs.c +++ b/src/node_device/node_device_linux_sysfs.c @@ -95,7 +95,8 @@ nodeDeviceSysfsGetSCSIHostCaps(virNodeDevCapSCSIHostPtr scsi_host) goto cleanup; } - if (!(tmp = virVHBAGetConfig(NULL, scsi_host->host, + VIR_FREE(tmp); + if (!(tmp = virVHBAGetConfig(NULL, scsi_host->host, "npiv_vports_inuse"))) { VIR_WARN("Failed to read npiv_vports_inuse for host%d", scsi_host->host); -- 1.8.3.1

2 1

[libvirt] [PATCH] util: fix memory leak in virSocketAddrFormatFull
by Yi Wang 26 May '17

26 May '17

The @ipv6_host allocated in virAsprintf may be lost when virAsprintf addrstr failed. Signed-off-by: Yi Wang <wang.yi59(a)zte.com.cn> --- src/util/virsocketaddr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 9dffbc7..95b5274 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -417,8 +417,10 @@ virSocketAddrFormatFull(const virSocketAddr *addr, if (virAsprintf(&addrstr, "%s%s%s", ipv6_host ? ipv6_host : host, - separator ? separator : ":", port) == -1) + separator ? separator : ":", port) == -1) { + VIR_FREE(ipv6_host); goto error; + } VIR_FREE(ipv6_host); } else { -- 1.8.3.1

2 1

[libvirt] [PATCH 2/2] lxc: fixing wrong VIR_FREE after a return statement.
by Julio Faracco 26 May '17

26 May '17

There is a VIR_FREE after a return statement. That code section is never executed and for this reason the "tty" variable is not being freed. This commit rearrange the logic. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index a936342..af02b54 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1143,8 +1143,8 @@ static int lxcContainerSetupDevices(char **ttyPaths, size_t nttyPaths) return -1; if (virFileBindMountDevice(ttyPaths[i], tty) < 0) { - return -1; VIR_FREE(tty); + return -1; } VIR_FREE(tty); -- 1.8.3.1

2 1

[libvirt] [PATCH 1/2] configure: fixing acl missing variable.
by Julio Faracco 26 May '17

26 May '17

This commit fixes an acl missing variable. The virt-acl.m4 inside the macro directory does not contain the variable 'with_acl'. So, it is being set as an empty string "with_acl=''". This is causing a missing option during the configuration, even if you have acl libs installed. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- m4/virt-acl.m4 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/m4/virt-acl.m4 b/m4/virt-acl.m4 index f7d1c6d..d548729 100644 --- a/m4/virt-acl.m4 +++ b/m4/virt-acl.m4 @@ -23,8 +23,10 @@ AC_DEFUN([LIBVIRT_CHECK_ACL], [ ACL_CFLAGS="" ACL_LIBS="" + with_acl=no if test "x$ac_cv_header_sys_acl_h:x$with_linux" = "xyes:xyes"; then ACL_LIBS="-lacl" + with_acl=yes fi AC_SUBST([ACL_CFLAGS]) AC_SUBST([ACL_LIBS]) -- 1.8.3.1

2 1

[libvirt] [PATCH v2 0/3] Check for <memoryBacking/>
by Michal Privoznik 26 May '17

26 May '17

Technically this is v2 of: https://www.redhat.com/archives/libvir-list/2017-May/msg00626.html diff to v1: - Patches split and reworked as suggested by Peter in the review Michal Privoznik (3): virDomainDefCheckABIStabilityFlags: move memtune checks into a separate function virDomainXMLOption: Introduce virDomainABIStabilityDomain virQEMUDriverDomainABIStability: Check for memoryBacking src/conf/domain_conf.c | 93 ++++++++++++++++++++++++++++++-------------- src/conf/domain_conf.h | 16 +++++++- src/conf/snapshot_conf.c | 5 ++- src/conf/snapshot_conf.h | 3 +- src/libvirt_private.syms | 6 +++ src/libxl/libxl_conf.c | 2 +- src/libxl/libxl_domain.c | 4 +- src/lxc/lxc_conf.c | 3 +- src/openvz/openvz_driver.c | 2 +- src/phyp/phyp_driver.c | 2 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_conf.c | 3 +- src/qemu/qemu_domain.c | 41 +++++++++++++++++++ src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 7 ++-- src/test/test_driver.c | 8 ++-- src/uml/uml_driver.c | 2 +- src/vbox/vbox_common.c | 2 +- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.c | 2 +- src/xen/xen_driver.c | 2 +- src/xenapi/xenapi_driver.c | 2 +- tests/qemuargv2xmltest.c | 2 +- tests/qemuxml2argvtest.c | 2 +- tests/sexpr2xmltest.c | 2 +- tests/testutils.c | 4 +- tests/vmx2xmltest.c | 2 +- tests/xlconfigtest.c | 2 +- tests/xmconfigtest.c | 2 +- tests/xml2sexprtest.c | 2 +- tests/xml2vmxtest.c | 2 +- 31 files changed, 167 insertions(+), 63 deletions(-) -- 2.13.0

3 8

[libvirt] Remotable Libvirt
by Peter Volpe 25 May '17

25 May '17

Hi Everyone, We are working towards building on the virtualization management functionality in cockpit (http://cockpit-project.org/) and wanted to get some feedback on the best way to integrate with libvirt. As a quick overview, cockpit aims to talk to existing remotable system APIs. Usually these API’s take the form of dbus, REST or executable commands. The majority of cockpit is implemented in javascript. There is no cockpit backend that knows how to change a hostname for example. The cockpit backend knows how to handle a dbus payload. The javascript running in the users browser knows how to use the systemd dbus API at org.freedesktop.hostname1 to manage the system hostname. Right now some of the basics have been implemented by spawning commands on the system. This isn't ideal because it involves parsing / screen scraping output and doesn't support receiving events so we have to poll (ei run the command again) to keep the UI up to date. As far as I know libvirt doesn't currently have a remoteable API. It does have a daemon that communicates with clients via a XDR RPC. (https://libvirt.org/internals/rpc.html) However from what I'm hearing the RPC is considered an internal implementation and shouldn't be used by external applications. Is that still the case? Is there any chance of getting talking the daemon directly using the XDR standard for a subset of methods blessed as part of the externally supported API? An alternative is to implement a standards based remotable API, using something like dbus or REST, that can be used by external applications. I imagine that this would be at a bit of a higher level than the current RPC and contain at least some of the logic around the actions it performs rather than being a direct passthrough to the daemon. Of course that is a pretty big undertaking and would, in my opinion, only be worth it if there is broader interest in the community and use cases beyond what cockpit would like to.

1 0

[libvirt] RFE: virsh list improvement (--description and --details)
by Przemysław Sztoch 25 May '17

25 May '17

Hello, 1. Please add —description parameter to virsh list command. It should be similar to —title. It will be very helpful for administrators who like to leave the order and documentation after their work. 2. Please add new columns to virsh list (for —details): a) CPUs b) MaxMem c) Flags: p-persistent, t-transient, a-autostart, m-managed save, s-with snapshot(s) and total sum for column vCPUs and Mem. In my opinion it is very popular use case. It will help you control vCPU and memory overcommiting in very simple and fast way. Put flags on list will prevents many additional commands from being executed. You will get all important information in one place. 3. Please add —domtime parameter to virsh list command. It should show column with domain’s system time similar to virsh domtime domname --pretty. It will be very helpful for fast guest-agent checking for every domain. 4. Please add column Parent and Metadata to virsh snapshot-list. — Przemyslaw Sztoch

5 9