- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/7] Add new APIs to edit xml configuration of managed save state of a domain
by Kothapally Madhu Pavan 05 Jul '17

05 Jul '17

managedsave command offloads the user from managing the save state file. It does not need the user to specify saved state file location, all it takes is domain name to identify. This makes it much more comfortable to use in emergency where immediate shutdowm is needed. But it doesn't provide a way to edit XML description of the save state file without user going through an extra effort to search manually where the file actually exists. The series aims to overcome the above constraints by adding new APIs and commands to seemlessly edit the managed save state XML description using just the domain name. The Patches mainly make use of the save-image-edit code flow only to simplify the above use case. This patch set provides capability to Dump and Edit the XML configuration associated with a saved state file of a domain which was created by the managedsave command. The new command carry the similar options as the save-image-<XXX> commands to change the running state as to paused state or running on start. This is equivalent to: virsh managedsave-dumpxml domain-name > state-file.xml vi state-file.xml (or make changes with your other text editor) virsh managedsave-define domain-name state-file-xml or you can simply use: virsh managedsave-edit domain-name It's always better when we get more. Changes since v2: - refracted version references from 3.5.0 to 3.6.0 Changes since v1: - qemu implementation called directly rather than going through driver pointer in qemuDomainManagedSaveDefineXML. - check whether the managed save state file exists and report a error if it doesn't. Kothapally Madhu Pavan (7): lib: Add API to dump xml configuration of managed save state domain lib: Add API to edit domain's managed save state xml configuration qemu: Implement qemuDomainManagedSaveGetXMLDesc qemu: Implement qemuDomainManagedSaveDefineXML virsh: Implement managedsave-define command virsh: Implement managedsave-dumpxml command virsh: Implement managedsave-edit command include/libvirt/libvirt-domain.h | 6 ++ src/driver-hypervisor.h | 11 +++ src/libvirt-domain.c | 107 ++++++++++++++++++++ src/libvirt_public.syms | 6 ++ src/qemu/qemu_driver.c | 87 ++++++++++++++++ src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 31 +++++- src/remote_protocol-structs | 14 +++ tools/virsh-domain.c | 207 +++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 41 ++++++++ 10 files changed, 511 insertions(+), 1 deletion(-) -- 1.8.3.1

1 7

[libvirt] [PATCH v3 0/4] lxc improvements
by Cédric Bosdonnat 05 Jul '17

05 Jul '17

Hi all, Here is a series grouping several small patches I sent independently to the mailing list. Main change since v2: * <inituser> and <initgroup> have been changed to hold either a uid or name as text child, rather than in an attribute. * Moved the uid/gid setting to after the pivot_root to allow getting the uid/gid from name. Cédric Bosdonnat (4): lxc: allow defining environment variables util: share code between virExec and virCommandExec lxc: allow user to specify command working directory lxc: add possibility to define init uid/gid docs/formatdomain.html.in | 17 +++++++++ docs/schemas/domaincommon.rng | 29 +++++++++++++++ src/conf/domain_conf.c | 52 ++++++++++++++++++++++++++ src/conf/domain_conf.h | 11 ++++++ src/lxc/lxc_container.c | 59 ++++++++++++++++++++++++++++++ src/util/vircommand.c | 69 ++++++++++++++++++++--------------- tests/lxcxml2xmldata/lxc-initdir.xml | 30 +++++++++++++++ tests/lxcxml2xmldata/lxc-initenv.xml | 30 +++++++++++++++ tests/lxcxml2xmldata/lxc-inituser.xml | 31 ++++++++++++++++ tests/lxcxml2xmltest.c | 3 ++ 10 files changed, 302 insertions(+), 29 deletions(-) create mode 100644 tests/lxcxml2xmldata/lxc-initdir.xml create mode 100644 tests/lxcxml2xmldata/lxc-initenv.xml create mode 100644 tests/lxcxml2xmldata/lxc-inituser.xml -- 2.12.2

3 8

[libvirt] [PATCH] news: CPU add migration fix into Bug fixes
by Pavel Hrdina 04 Jul '17

04 Jul '17

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- docs/news.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index f38abeb91d..f590d9cdfc 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -197,6 +197,18 @@ QEMU releases older than 1.6. </description> </change> + <change> + <summary> + qemu: Fix migration to older libvirt/QEMU versions + </summary> + <description> + When the guest is started libvirt updates the CPU definition to + reflect the actual CPU features to enforce ABI. We need to send + original and updated CPU definition in order to support migration + to older libvirt/QEMU versions. Only the updated CPU definition + was send to destination. + </description> + </change> </section> </release> <release version="v3.4.0" date="2017-06-02"> -- 2.13.2

2 1

[libvirt] [PATCH v3 00/12] Make virNodeDeviceObj and virNodeDeviceObjList private
by John Ferlan 04 Jul '17

04 Jul '17

v2: https://www.redhat.com/archives/libvir-list/2017-May/msg00999.html Some patches from v2 were pushed (3, 4, 6, 7, 8, 9, 11, & 12), but a few remained from that series and are the first 5 patches of this series. What changed? -> Reworked the virNodeDeviceObjRemove patch (former patch 2, but new series patch 1). That affected the Test patch (former patch 1, but now patch 2). This patch removes the address of obj logic and moves the onus of the ObjFree to the caller (see patch for reason). -> Patch 3 is the former patch 5, with no essential change -> Patch 4 is the former patch 10, with no essential change -> Former patch 13 and 14, were altered to remove the offending address of pointer logic. The result is patch 5 which just essentially former patch 14 without the address of pointer logic. -> Patches 6-12 for this series are new, but follow along through the logic to make things private. John Ferlan (12): nodedev: Alter virNodeDeviceObjRemove test: Adjust cleanup/error paths for nodedev test APIs nodedev: Use common naming for virnodedeviceobj nodedev: Use consistent names for driver variables nodedev: Introduce virNodeDeviceObjNew nodedev: Introduce virNodeDeviceObjListNew nodedev: Alter node device obj list function names nodedev: Dereference the obj/def in virNodeDeviceObjListFind* APIs nodedev: Introduce virNodeDeviceGetSCSIHostCaps nodedev: Introduce virNodeDeviceObjListFindSCSIHostByWWNs nodedev: Privatize _virNodeDeviceObj and _virNodeDeviceObjList nodedev: Convert virNodeDeviceObj to use virObjectLockable src/conf/node_device_conf.c | 82 ++++++ src/conf/node_device_conf.h | 20 +- src/conf/virnodedeviceobj.c | 420 ++++++++++++++++++------------ src/conf/virnodedeviceobj.h | 67 ++--- src/libvirt_private.syms | 20 +- src/node_device/node_device_driver.c | 159 +++++------ src/node_device/node_device_hal.c | 47 ++-- src/node_device/node_device_linux_sysfs.c | 77 +----- src/node_device/node_device_udev.c | 52 ++-- src/test/test_driver.c | 136 +++++----- 10 files changed, 570 insertions(+), 510 deletions(-) -- 2.9.4

3 44

[libvirt] [PATCH] docs: add entry to download table listing the Rust language binding
by Daniel P. Berrange 04 Jul '17

04 Jul '17

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- docs/downloads.html.in | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 99da7a6..0306945 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -179,6 +179,22 @@ <td></td> </tr> <tr> + <td>Rust</td> + <td> + <a href="ftp://libvirt.org/libvirt/rust/">ftp</a> + <a href="http://libvirt.org/sources/rust/">http</a> + <a href="https://libvirt.org/sources/rust/">https</a> + </td> + <td> + <a href="http://libvirt.org/git/?p=libvirt-rust.git;a=summary">libvirt</a> + </td> + <td> + <a href="https://gitlab.com/libvirt/libvirt-rust">gitlab</a> + <a href="https://github.com/libvirt/libvirt-rust">github</a> + </td> + <td></td> + </tr> + <tr> <th colspan="7">Integration modules</th> </tr> <tr> -- 2.9.4

2 1

[libvirt] [PATCH] news: Update for 3.5.0 release
by Andrea Bolognani 04 Jul '17

04 Jul '17

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/news.xml | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 636154e..f38abeb 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -68,6 +68,15 @@ running. </description> </change> + <change> + <summary> + qemu: Allow VirtIO devices to use vIOMMU + </summary> + <description> + It is now possible to turn on IOTBL for the vIOMMU and have VirtIO + devices use it, provided they have been configured appropriately. + </description> + </change> </section> <section title="Improvements"> <change> @@ -100,6 +109,20 @@ gathered and presented in capabilities if available. </description> </change> + <change> + <summary> + apparmor: Several improvements + </summary> + <description> + Allow access to Ceph config, EFI firmware on both x86_64 and + aarch64, device tree on ppc64 and more. + </description> + </change> + <change> + <summary> + qemu: Support host-model on POWER9 machines + </summary> + </change> </section> <section title="Bug fixes"> <change> @@ -115,6 +138,65 @@ images when doing a block-commit. </description> </change> + <change> + <summary> + Parse decimal numbers in a locale-independent way + </summary> + <description> + Some locales, such as <code>de_DE</code> and <code>pt_BR</code>, + use comma rather than dot to separate the integer part from the + fractional part of a decimal number; however, several data sources + such as the kernel use a locale-independent representation and need + to be treated accordingly. + </description> + </change> + <change> + <summary> + Support compilation with newer compiler and libc versions + </summary> + <description> + Several fixes have been included to make compilation with Clang + 4.0.0, GCC 7.1 and glibc >= 2.25.90 possible. + </description> + </change> + <change> + <summary> + qemu: Query name for vhost-user interfaces at runtime + </summary> + <description> + This makes it possible to use <code>virsh</code> subcommands such + as <code>domiflist</code> and <code>domifstat</code> on vhost-user + interfaces. + </description> + </change> + <change> + <summary> + qemu: Set MTU for hotplugged interfaces correctly + </summary> + <description> + When hotplugging a network interface, the MTU was only set on the + guest side. Set it on the host side as well. + </description> + </change> + <change> + <summary> + qemu: Forbid updating MTU for interfaces of running guests + </summary> + <description> + The MTU setting can't be modified while the guest is running, so any + attempt to alter it at runtime will now result in an error rather + than being silently ignored. + </description> + </change> + <change> + <summary> + qemu: Fix specifying QXL heads with older QEMU releases + </summary> + <description> + Specifying the number of QXL heads was not working correctly for + QEMU releases older than 1.6. + </description> + </change> </section> </release> <release version="v3.4.0" date="2017-06-02"> -- 2.7.5

2 1

[libvirt] [PATCH RFC V2 0/2] Implement l3 CAT
by Eli Qiao 03 Jul '17

03 Jul '17

Allow user to define cachetune in domain xml. V2 -> V1 changes: * Redefine cachetune xml in domain xml. * Create a struct for driver to talk with util/virresctrl.* * Nit fixes Eli Qiao (2): Resctrl: Add new xml element to support cache tune Resctrl: Do cache allocation while boot a qemu VM docs/schemas/domaincommon.rng | 29 ++ include/libvirt/virterror.h | 1 + src/Makefile.am | 1 + src/conf/domain_conf.c | 112 ++++ src/conf/domain_conf.h | 19 + src/libvirt_private.syms | 9 + src/qemu/qemu_process.c | 81 +++ src/util/virerror.c | 1 + src/util/virresctrl.c | 822 ++++++++++++++++++++++++++++++ src/util/virresctrl.h | 88 ++++ tests/Makefile.am | 8 +- tests/virresctrldata/L3-free.schemata | 1 + tests/virresctrldata/L3CODE-free.schemata | 1 + tests/virresctrldata/L3DATA-free.schemata | 1 + tests/virresctrldata/linux-resctrl | 1 + tests/virresctrldata/linux-resctrl-cdp | 1 + tests/virresctrltest.c | 119 +++++ 17 files changed, 1294 insertions(+), 1 deletion(-) create mode 100644 src/util/virresctrl.c create mode 100644 src/util/virresctrl.h create mode 100644 tests/virresctrldata/L3-free.schemata create mode 100644 tests/virresctrldata/L3CODE-free.schemata create mode 100644 tests/virresctrldata/L3DATA-free.schemata create mode 120000 tests/virresctrldata/linux-resctrl create mode 120000 tests/virresctrldata/linux-resctrl-cdp create mode 100644 tests/virresctrltest.c -- 1.9.1

3 4

[libvirt] [PATCH] pci: add support for VMD domains
by Jon Derrick 01 Jul '17

01 Jul '17

VMD domains start at 0x10000, so expand dev->name to fit at least this many characters. Signed-off-by: Jon Derrick <jonathan.derrick(a)intel.com> --- src/util/virpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 2c1b758..b3afefe 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -50,7 +50,7 @@ VIR_LOG_INIT("util.pci"); #define PCI_SYSFS "/sys/bus/pci/" #define PCI_ID_LEN 10 /* "XXXX XXXX" */ -#define PCI_ADDR_LEN 13 /* "XXXX:XX:XX.X" */ +#define PCI_ADDR_LEN 14 /* "XXXXX:XX:XX.X" */ VIR_ENUM_IMPL(virPCIELinkSpeed, VIR_PCIE_LINK_SPEED_LAST, "", "2.5", "5", "8", "16") -- 2.9.3

1 0

[libvirt] [PATCH 00/10] conf: Clean up virDomain*Def creation
by Andrea Bolognani 30 Jun '17

30 Jun '17

This series is required to solve a known limitation in the current incarnation of device isolation support[1], namely the inability to isolate host devices coming from IOMMU group 0. The issue lies in the fact that virDomainDeviceInfo, and all virDomain*Def that embed it, are usually allocated through VIR_ALLOC(), which result in all their fields being initialized to zero. That's worked out just fine so far, because zero was a sensible default value for all existing fields; however, when implementing isolation groups, we add a new virDomainDeviceInfo::isolationGroup field which we need to be initialized to -1 instead so that it doesn't overlap with IOMMU group 0 mentioned above. Solving the issue involves creating twenty or so virDomain*DefNew() functions and using them instead of VIR_ALLOC() every time a virDomain*Def needs to be created, which is arguably a pretty good idea regardless. The series could probably be organized so that eg. the patch order makes more sense, but honestly I'm pretty tired right now and I just don't have it in me. Moreover, the goal of the series and its implementation are both straighforward enough that I feel reviewers will have no problem following along. My main concern with this series is that, while converting from VIR_ALLOC() to virDomain*DefNew(), I might simply have missed some instances. That would not cause any issue right away, but once we introduce isolation groups it would lead to suboptimal PCI addresses being allocated at best, and to perfectly legitimate hotplug requests being denied at worst. The fact that the test suite[2] passes gives me a lot of confidence that I haven't overlooked anything, but if anyone has clever ideas on how to be actually sure rather than merely confident please do let me know. [1] https://www.redhat.com/archives/libvir-list/2017-June/msg01018.html [2] That is, the version of it where the default isolation group being initialized correctly actually matters Andrea Bolognani (10): conf: Make virDomainDeviceGetInfo() private conf: Rename virDomainHostdevDefAlloc() to virDomainHostdevDefNew() conf: Clean up virDomainHostdevDefNew() conf: Clean up virDomain{Memory,Shmem}DefParseXML() conf: Move some virDomainDeviceInfo functions conf: Introduce virDomainDeviceInfoNew() conf: Clean up virDomainDeviceInfo functions conf, qemu: Use virDomainDeviceInfoNew() conf: Provide missing virDomain*DefNew() functions conf: Call virDomainDeviceInfoClear() in virDomain*DefNew() src/bhyve/bhyve_parse_command.c | 4 +- src/conf/device_conf.c | 146 ++++++++++++ src/conf/device_conf.h | 9 + src/conf/domain_addr.c | 6 +- src/conf/domain_conf.c | 486 ++++++++++++++++++++++++---------------- src/conf/domain_conf.h | 25 ++- src/libvirt_private.syms | 19 +- src/lxc/lxc_native.c | 2 +- src/openvz/openvz_conf.c | 2 +- src/qemu/qemu_command.c | 12 +- src/qemu/qemu_domain.c | 11 +- src/qemu/qemu_domain_address.c | 31 +-- src/qemu/qemu_hotplug.c | 5 +- src/qemu/qemu_parse_command.c | 31 +-- src/vbox/vbox_common.c | 14 +- src/vmx/vmx.c | 2 +- src/vz/vz_sdk.c | 6 +- src/xen/xen_driver.c | 2 +- src/xenapi/xenapi_driver.c | 2 +- src/xenconfig/xen_common.c | 4 +- src/xenconfig/xen_sxpr.c | 10 +- src/xenconfig/xen_xl.c | 4 +- src/xenconfig/xen_xm.c | 2 +- tests/virhostdevtest.c | 2 +- 24 files changed, 561 insertions(+), 276 deletions(-) -- 2.7.5

3 30

[libvirt] [PATCH] qemu: Don't update CPU when checking ABI stability
by Jiri Denemark 30 Jun '17

30 Jun '17

When checking ABI stability between two domain definitions, we first make migratable copies of them. However, we also asked for the guest CPU to be updated, even though the updated CPU is supposed to be already included in the original definitions. Moreover, if we do this on the destination host during migration, we're potentially updating the definition with according to an incompatible host CPU. While updating the CPU when checking ABI stability doesn't make any sense, it actually just worked because updating the CPU doesn't do anything for custom CPUs (only host-model CPUs are affected) and we updated both definitions in the same way. Less then a year ago commit v2.3.0-rc1~42 stopped updating the CPU in the definition we got internally and only the user supplied definition was updated. However, the same commit started updating host-model CPUs to custom CPUs which are not affected by the request to update the CPU. So it still seemed to work right, unless a user upgraded libvirt 2.2.0 to a newer version while there were some domains with host-model CPUs running on the host. Such domains couldn't be migrated with a user supplied XML since libvirt would complain: Target CPU mode custom does not match source host-model The fix is pretty straightforward, we just need to stop updating the CPU when checking ABI stability. https://bugzilla.redhat.com/show_bug.cgi?id=1463957 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_domain.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 8e7404da6..d9357f20c 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5926,7 +5926,6 @@ qemuDomainMigratableDefCheckABIStability(virQEMUDriverPtr driver, #define COPY_FLAGS (VIR_DOMAIN_XML_SECURE | \ - VIR_DOMAIN_XML_UPDATE_CPU | \ VIR_DOMAIN_XML_MIGRATABLE) bool -- 2.13.2

2 1