- Devel - libvirt List Archives

[libvirt] [PATCH v2] qemu: command: align disk serial check to schema
by Nikolay Shirokovskiy 23 Aug '17

23 Aug '17

Disk serial schema has extra '.+' allowed characters in comparison with check in code. Looks like there is no reason for that as qemu allows any character AFAIK for serial. This discrepancy is originated in 85d15b51 where ability to add serial was added. --- Diff from v1: * fix xml2argv disk serial test to use all valid chars Looks like there is no existing infrastructure to test every invalid character. src/qemu/qemu_command.c | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c76f923..c5369b0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -432,7 +432,7 @@ qemuBuildIoEventFdStr(virBufferPtr buf, } #define QEMU_SERIAL_PARAM_ACCEPTED_CHARS \ - "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_ " + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_ .+" static int qemuSafeSerialParamValue(const char *value) diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args index 2cefdca..fa0fc93 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args @@ -18,6 +18,6 @@ QEMU_AUDIO_DRV=none \ -boot c \ -usb \ -drive 'file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-1,\ -serial=\ \ WD-WMAP9A966149' \ +serial=abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_\ .+' \ -device ide-drive,bus=ide.0,unit=1,drive=drive-ide0-0-1,id=ide0-0-1 \ -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml index 565462e..d54d73b 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml @@ -17,7 +17,7 @@ <disk type='block' device='disk'> <source dev='/dev/HostVG/QEMUGuest1'/> <target dev='hda' bus='ide'/> - <serial> WD-WMAP9A966149</serial> + <serial>abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_ .+</serial> <address type='drive' controller='0' bus='0' target='0' unit='1'/> </disk> <controller type='usb' index='0'/> -- 1.8.3.1

2 3

[libvirt] [PATCH v4 00/17] virObject adjustments for common object
by John Ferlan 23 Aug '17

23 Aug '17

v3: https://www.redhat.com/archives/libvir-list/2017-June/msg00916.html Changes since v3 - honestly it's been too long to remember exactly what changes have taken place. This series provide the util/virobject changes and the implementation for nodedev, secret, interface, and network drivers/vir*obj's. The nwfilter is awaiting more upstream review and work and some more Storage Pool/Volume patches will be posted in conjunction with these. These changes also use the rwlocks Michal recently added to virobject as the means to provide locks for the LookupHash table(s). Although I understand it's not the preference of one reviewer, I've kept with the virObject model. If that still doesn't pass muster and someone else wants to create some other mechanism to combine the existing drivers in a more sane manner, then have at it. This is the model I've chosen. I personally don't see the value in just a shim API. This set of patches moves away from using a strict "uuid/name" designation in favor of using "key1" and "key2". While some may find that "too generic", I think that's the whole purpose of it. After some soul searching I feel using "name" or "uuid" is too restrictive and lends more towards the shim API model. Besides for some consumers they don't have a uuid (nodedev, interface, and nwfilter). In the long run it doesn't matter whether it's a uuid, name, or whatever as long as it's a character string. FWIW: Patches 1, 12, and 16 could be easily separated out, but since I was working in the area - they were added here as well. John Ferlan (17): util: Use VIR_ERROR instead of VIR_WARN util: Introduce virObjectLookupKeys util: Introduce virObjectLookupHash util: Introduce virObjectLookupKeys*Active API's util: Introduce virObjectLookupHash{Add|Remove} util: Introduce virObjectLookupHashFind[Locked] util: Introduce virObjectLookupHashForEach util: Introduce virObjectLookupHashSearch[Locked] nodedev: Use virObjectLookup{Keys|Hash} secret: Use virObjectLookup{Keys|Hash} util: Introduce virObjectLookupHashClone Revert "interface: Consume @def in virInterfaceObjNew" interface: Use virObjectLookup{Keys|Hash} test: Clean up test driver Interface interactions util: Introduce virObjectLookupHashPrune network: Fix virNetworkObjBridgeInUse return type network: Use virObjectLookup{Keys|Hash} src/conf/virinterfaceobj.c | 301 ++++++++++---------- src/conf/virnetworkobj.c | 293 ++++++-------------- src/conf/virnetworkobj.h | 5 +- src/conf/virnodedeviceobj.c | 286 ++++++------------- src/conf/virsecretobj.c | 263 +++++------------- src/libvirt_private.syms | 15 + src/test/test_driver.c | 55 +--- src/util/virobject.c | 658 +++++++++++++++++++++++++++++++++++++++++++- src/util/virobject.h | 119 ++++++++ tests/networkxml2conftest.c | 4 +- 10 files changed, 1190 insertions(+), 809 deletions(-) -- 2.9.4

2 21

[libvirt] [PATCHv2 0/3] conf: do not count per-device boot elements when parsing <os><boot>
by Ján Tomko 22 Aug '17

22 Aug '17

Ján Tomko (3): conf: rename virDomain*PostParseInternal to virDomain*PostParseCommon conf: create a thin wrapper above virDomainDefPostParse conf: do not count per-device boot elements when parsing <os><boot> src/conf/domain_conf.c | 82 +++++++++++++++++++++++++++----------------------- 1 file changed, 45 insertions(+), 37 deletions(-) -- 2.13.0

2 6

[libvirt] [PATCH 00/17] chardev parsing cleanup and improvements
by Pavel Hrdina 22 Aug '17

22 Aug '17

Pavel Hrdina (17): tests: introduce genericxml test for TCP chardev tests: introduce genericxml test for UDP chardev tests: introduce genericxml test for UNIX chardev conf: switch from while to for loop for chardev parsing conf: error out for multiple source elements while parsing chardev conf: error out for multiple log elements while parsing chardev conf: error out for multiple protocol elements while parsing chardev conf: move chardev protocol parsing to separate function conf: move chardev log parsing to separate function conf: move mode parsing of chardev source to separate function conf: move TCP chardev source parsing to separate function conf: move UDP chardev source parsing to separate function conf: move UNIX chardev source parsing to separate function conf: assign parsed strings directly into chardev source definition conf: move FILE chardev source parsing to separate function conf: separate PTY chardev source parsing conf: move chardev validation into virDomainDeviceDefValidateInternal src/conf/domain_conf.c | 700 ++++++++++++--------- .../generic-chardev-tcp-missing-host.xml | 25 + .../generic-chardev-tcp-missing-service.xml | 25 + .../generic-chardev-tcp-multiple-source.xml | 26 + tests/genericxml2xmlindata/generic-chardev-tcp.xml | 32 + ...generic-chardev-udp-missing-connect-service.xml | 24 + .../generic-chardev-udp-multiple-source.xml | 26 + tests/genericxml2xmlindata/generic-chardev-udp.xml | 47 ++ .../generic-chardev-unix-redirdev-missing-path.xml | 24 + .../generic-chardev-unix-rng-missing-path.xml | 25 + ...generic-chardev-unix-smartcard-missing-path.xml | 23 + .../genericxml2xmlindata/generic-chardev-unix.xml | 43 ++ .../genericxml2xmloutdata/generic-chardev-tcp.xml | 35 ++ .../genericxml2xmloutdata/generic-chardev-udp.xml | 47 ++ .../genericxml2xmloutdata/generic-chardev-unix.xml | 44 ++ tests/genericxml2xmltest.c | 20 + 16 files changed, 875 insertions(+), 291 deletions(-) create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-missing-host.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-missing-service.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp-multiple-source.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-tcp.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp-missing-connect-service.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp-multiple-source.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-udp.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-redirdev-missing-path.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-rng-missing-path.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix-smartcard-missing-path.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-unix.xml create mode 100644 tests/genericxml2xmloutdata/generic-chardev-tcp.xml create mode 100644 tests/genericxml2xmloutdata/generic-chardev-udp.xml create mode 100644 tests/genericxml2xmloutdata/generic-chardev-unix.xml -- 2.13.5

2 36

[libvirt] [PATCH] conf: do not count per-device boot elements when parsing <os><boot>
by Ján Tomko 22 Aug '17

22 Aug '17

When parsing bootable devices, we maintain a bitmap of used <boot order=""> elements. Use it in the post-parse function to figure out whether the user tried to mix per-device and per-domain boot elements. This removes the need to count them twice. --- src/conf/domain_conf.c | 46 ++++++++++++++++++++----------------------- src/conf/domain_conf.h | 3 ++- src/lxc/lxc_native.c | 2 +- src/qemu/qemu_driver.c | 6 +++--- src/qemu/qemu_parse_command.c | 2 +- src/qemu/qemu_process.c | 2 +- src/vmx/vmx.c | 2 +- src/xenconfig/xen_sxpr.c | 2 +- src/xenconfig/xen_xl.c | 2 +- src/xenconfig/xen_xm.c | 2 +- 10 files changed, 33 insertions(+), 36 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6f0f038b7..355da1478 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4784,7 +4784,8 @@ virDomainDefPostParseCPU(virDomainDefPtr def) static int virDomainDefPostParseInternal(virDomainDefPtr def, - struct virDomainDefPostParseDeviceIteratorData *data) + struct virDomainDefPostParseDeviceIteratorData *data, + virHashTablePtr bootHash) { /* verify init path for container based domains */ if (def->os.type == VIR_DOMAIN_OSTYPE_EXE && !def->os.init) { @@ -4793,6 +4794,20 @@ virDomainDefPostParseInternal(virDomainDefPtr def, return -1; } + if (def->os.type == VIR_DOMAIN_OSTYPE_HVM && bootHash) { + if (def->os.nBootDevs > 0 && virHashSize(bootHash) > 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("per-device boot elements cannot be used" + " together with os/boot elements")); + return -1; + } + + if (def->os.nBootDevs == 0 && virHashSize(bootHash) == 0) { + def->os.nBootDevs = 1; + def->os.bootDevs[0] = VIR_DOMAIN_BOOT_DISK; + } + } + if (virDomainVcpuDefPostParse(def) < 0) return -1; @@ -4861,7 +4876,8 @@ virDomainDefPostParse(virDomainDefPtr def, virCapsPtr caps, unsigned int parseFlags, virDomainXMLOptionPtr xmlopt, - void *parseOpaque) + void *parseOpaque, + virHashTablePtr bootHash) { int ret = -1; bool localParseOpaque = false; @@ -4917,7 +4933,7 @@ virDomainDefPostParse(virDomainDefPtr def, if (virDomainDefPostParseCheckFailure(def, parseFlags, ret) < 0) goto cleanup; - if ((ret = virDomainDefPostParseInternal(def, &data)) < 0) + if ((ret = virDomainDefPostParseInternal(def, &data, bootHash)) < 0) goto cleanup; if (xmlopt->config.assignAddressesCallback) { @@ -16135,28 +16151,11 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, int n; char *tmp = NULL; int ret = -1; - unsigned long deviceBoot; - - if (virXPathULong("count(./devices/disk[boot]" - "|./devices/interface[boot]" - "|./devices/hostdev[boot]" - "|./devices/redirdev[boot])", ctxt, &deviceBoot) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("cannot count boot devices")); - goto cleanup; - } /* analysis of the boot devices */ if ((n = virXPathNodeSet("./os/boot", ctxt, &nodes)) < 0) goto cleanup; - if (n > 0 && deviceBoot) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("per-device boot elements cannot be used" - " together with os/boot elements")); - goto cleanup; - } - for (i = 0; i < n && i < VIR_DOMAIN_BOOT_LAST; i++) { int val; char *dev = virXMLPropString(nodes[i], "dev"); @@ -16175,10 +16174,6 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, VIR_FREE(dev); def->os.bootDevs[def->os.nBootDevs++] = val; } - if (def->os.nBootDevs == 0 && !deviceBoot) { - def->os.nBootDevs = 1; - def->os.bootDevs[0] = VIR_DOMAIN_BOOT_DISK; - } if ((node = virXPathNode("./os/bootmenu[1]", ctxt))) { tmp = virXMLPropString(node, "enable"); @@ -18947,7 +18942,8 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; /* callback to fill driver specific domain aspects */ - if (virDomainDefPostParse(def, caps, flags, xmlopt, parseOpaque) < 0) + if (virDomainDefPostParse(def, caps, flags, xmlopt, parseOpaque, + bootHash) < 0) goto error; /* valdiate configuration */ diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1f1dc1de0..2fe7e545d 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2643,7 +2643,8 @@ int virDomainDefPostParse(virDomainDefPtr def, virCapsPtr caps, unsigned int parseFlags, virDomainXMLOptionPtr xmlopt, - void *parseOpaque); + void *parseOpaque, + virHashTablePtr bootHash); int virDomainDefValidate(virDomainDefPtr def, virCapsPtr caps, diff --git a/src/lxc/lxc_native.c b/src/lxc/lxc_native.c index 5fc6e7cda..1542eda11 100644 --- a/src/lxc/lxc_native.c +++ b/src/lxc/lxc_native.c @@ -1095,7 +1095,7 @@ lxcParseConfigString(const char *config, lxcSetCapDrop(vmdef, properties); if (virDomainDefPostParse(vmdef, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, - xmlopt, NULL) < 0) + xmlopt, NULL, NULL) < 0) goto cleanup; goto cleanup; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e9f07c6e7..f2cc1ee34 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7916,7 +7916,7 @@ qemuDomainAttachDeviceConfig(virDomainDefPtr vmdef, return -1; } - if (virDomainDefPostParse(vmdef, caps, parse_flags, xmlopt, NULL) < 0) + if (virDomainDefPostParse(vmdef, caps, parse_flags, xmlopt, NULL, NULL) < 0) return -1; return 0; @@ -8082,7 +8082,7 @@ qemuDomainDetachDeviceConfig(virDomainDefPtr vmdef, return -1; } - if (virDomainDefPostParse(vmdef, caps, parse_flags, xmlopt, NULL) < 0) + if (virDomainDefPostParse(vmdef, caps, parse_flags, xmlopt, NULL, NULL) < 0) return -1; return 0; @@ -8169,7 +8169,7 @@ qemuDomainUpdateDeviceConfig(virDomainDefPtr vmdef, return -1; } - if (virDomainDefPostParse(vmdef, caps, parse_flags, xmlopt, NULL) < 0) + if (virDomainDefPostParse(vmdef, caps, parse_flags, xmlopt, NULL, NULL) < 0) return -1; return 0; diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c index ee7112775..345d31e6a 100644 --- a/src/qemu/qemu_parse_command.c +++ b/src/qemu/qemu_parse_command.c @@ -2639,7 +2639,7 @@ qemuParseCommandLine(virCapsPtr caps, VIR_FREE(nics); - if (virDomainDefPostParse(def, caps, 0, xmlopt, NULL) < 0) + if (virDomainDefPostParse(def, caps, 0, xmlopt, NULL, NULL) < 0) goto error; if (cmd->num_args || cmd->num_env) { diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 589d0ed2c..d0e1ad6f7 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4696,7 +4696,7 @@ qemuProcessInit(virQEMUDriverPtr driver, if (vm->def->postParseFailed) { VIR_DEBUG("re-running the post parse callback"); - if (virDomainDefPostParse(vm->def, caps, 0, driver->xmlopt, NULL) < 0) + if (virDomainDefPostParse(vm->def, caps, 0, driver->xmlopt, NULL, NULL) < 0) goto cleanup; } diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 3e2f4c3e1..822ba1230 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -1819,7 +1819,7 @@ virVMXParseConfig(virVMXContext *ctx, } if (virDomainDefPostParse(def, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, - xmlopt, NULL) < 0) + xmlopt, NULL, NULL) < 0) goto cleanup; success = true; diff --git a/src/xenconfig/xen_sxpr.c b/src/xenconfig/xen_sxpr.c index fefa61ac2..ea19ca0bf 100644 --- a/src/xenconfig/xen_sxpr.c +++ b/src/xenconfig/xen_sxpr.c @@ -1458,7 +1458,7 @@ xenParseSxpr(const struct sexpr *root, } if (virDomainDefPostParse(def, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, - xmlopt, NULL) < 0) + xmlopt, NULL, NULL) < 0) goto error; return def; diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index d168d3fa4..11eb1a2e6 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -882,7 +882,7 @@ xenParseXL(virConfPtr conf, goto cleanup; if (virDomainDefPostParse(def, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, - xmlopt, NULL) < 0) + xmlopt, NULL, NULL) < 0) goto cleanup; return def; diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index 8ef68bbc0..5f4572b84 100644 --- a/src/xenconfig/xen_xm.c +++ b/src/xenconfig/xen_xm.c @@ -461,7 +461,7 @@ xenParseXM(virConfPtr conf, goto cleanup; if (virDomainDefPostParse(def, caps, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE, - xmlopt, NULL) < 0) + xmlopt, NULL, NULL) < 0) goto cleanup; return def; -- 2.13.0

2 1

[libvirt] [PATCH] conf: useserial: drop useless check for serial devices
by Ján Tomko 22 Aug '17

22 Aug '17

Since its introduction in commit 874e65aa, if someone requests: <os><bios useserial="yes"/><os/> we report an error if we cannot successfully count the number of serial devices via an XPath query. Instead of fixing the check (and moving it to the validation phase, to prevent existing domains from disappearing), drop it completely. For QEMU, the number of serials is checked when building the command line. --- src/conf/domain_conf.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3bef5bed3..e563007ba 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16127,7 +16127,7 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, int n; char *tmp = NULL; int ret = -1; - unsigned long deviceBoot, serialPorts; + unsigned long deviceBoot; if (virXPathULong("count(./devices/disk[boot]" "|./devices/interface[boot]" @@ -16204,18 +16204,10 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt, if ((node = virXPathNode("./os/bios[1]", ctxt))) { tmp = virXMLPropString(node, "useserial"); if (tmp) { - if (STREQ(tmp, "yes")) { - if (virXPathULong("count(./devices/serial)", - ctxt, &serialPorts) < 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("need at least one serial port " - "for useserial")); - goto cleanup; - } + if (STREQ(tmp, "yes")) def->os.bios.useserial = VIR_TRISTATE_BOOL_YES; - } else { + else def->os.bios.useserial = VIR_TRISTATE_BOOL_NO; - } VIR_FREE(tmp); } -- 2.13.0

2 1

[libvirt] [PATCH V2 0/2] Don't autogenerate seclabels of type 'none'
by Jim Fehlig 21 Aug '17

21 Aug '17

V2 of https://www.redhat.com/archives/libvir-list/2017-August/msg00376.html The first patch fixes a few issues I found in securityselinuxtest while working on the second patch. In V2, a seclabel is not generated if the domain has no seclabel and confinement is disabled. Jim Fehlig (2): Fix building domain def in securityselinuxtest Don't autogenerate seclabels of type 'none' src/security/security_manager.c | 42 +++++++++++++++++++++-------------------- tests/securityselinuxtest.c | 14 +++++++++----- 2 files changed, 31 insertions(+), 25 deletions(-) -- 2.13.1

2 8

[libvirt] [PATCH] Doc fix of /etc/libvirt/libvirt-guests
by Lily Zhu 21 Aug '17

21 Aug '17

As in previous doc, it may cause confusion about whether parallel_shutdown would take effect when guests are asked to suspend on host shutdown. Hence, changed the doc of parallel_shutdown, make it more clear. Signed-off-by: Lily Zhu <lizhu(a)redhat.com> --- tools/libvirt-guests.sysconf | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libvirt-guests.sysconf b/tools/libvirt-guests.sysconf index 2770056..785c3c0 100644 --- a/tools/libvirt-guests.sysconf +++ b/tools/libvirt-guests.sysconf @@ -24,8 +24,10 @@ # value suitable for your guests. #ON_SHUTDOWN=suspend -# If set to non-zero, shutdown will suspend guests concurrently. Number of -# guests on shutdown at any time will not exceed number set in this variable. +# Number of guests will be shutdown concurrently, taking effect when +# "ON_SHUTDOWN" is set to "shutdown". If Set to 0, guests will be +# shutdown one after another. Number of guests on shutdown at any +# time will not exceed number set in this variable. #PARALLEL_SHUTDOWN=0 # Number of seconds we're willing to wait for a guest to shut down. If parallel -- 1.8.3.1

2 1

[libvirt] [PATCH] docs: Improve PCI topology and hotplug guidelines
by Andrea Bolognani 21 Aug '17

21 Aug '17

Address some minor flaws in the original document that were pointed out during review. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/pci-hotplug.html.in | 46 ++++++++++++++++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 14 deletions(-) diff --git a/docs/pci-hotplug.html.in b/docs/pci-hotplug.html.in index 809e36f5d..a90d47bc3 100644 --- a/docs/pci-hotplug.html.in +++ b/docs/pci-hotplug.html.in @@ -13,10 +13,12 @@ <p> The reason for this apparent limitation is the fact that each hotplugged PCI device might require additional PCI controllers to - be added to the guest, and libvirt has no way of knowing in advance - how many devices will be hotplugged during the guest's lifetime, - thus making it impossible to automatically provide the right amount - of PCI controllers: any arbitrary number would end up being too big + be added to the guest. Since most PCI controllers can't be + hotplugged, they need to be added before the guest is started; + however, libvirt has no way of knowing in advance how many devices + will be hotplugged during the guest's lifetime, thus making it + impossible to automatically provide the right amount of PCI + controllers: any arbitrary number would end up being too big for some users, and too small for others. </p> <p> @@ -53,6 +55,14 @@ emulated or assigned from the host. </p> <p> + If you have a very specialized use case, such as the appliances + used by <a href="http://libguestfs.org/">libguestfs</a> behind + the scenes to access disk images, and this automatically-added + <code>pcie-root-port</code> controller ends up being a nuisance, + you can prevent libvirt from adding it by manually managing PCI + controllers and addresses according to you needs. + </p> + <p> Slots on the <code>pcie-root</code> controller do not support hotplug, so the device will be hotplugged into the <code>pcie-root-port</code> controller. If you plan to hotplug @@ -73,6 +83,12 @@ remaining details automatically. </p> <p> + Note that if you're adding PCI controllers to a guest at the + same time you're also adding PCI devices, some of the + controllers will be used for the newly-added devices and won't + be available for hotplug once the guest has been started. + </p> + <p> If you expect to hotplug legacy PCI devices, then you will need specialized controllers, since all those mentioned above are intended for PCI Express devices only: add @@ -84,7 +100,8 @@ <p> and you'll be able to hotplug up to 31 legacy PCI devices, - either emulated or assigned from the host. + either emulated or assigned from the host, in the slots + from 0x01 to 0x1f of the <code>pci-bridge</code> controller. </p> <h3><a name="x86_64-i440fx">i440fx (pc) machine type</a></h3> @@ -98,9 +115,10 @@ <controller type='pci' index='0' model='pci-root'/></pre> <p> - where each of the 31 slots on the <code>pci-root</code> - controller is hotplug capable and can accept a legacy PCI - device, either emulated or assigned from the guest. + where each of the 31 slots (from 0x01 to 0x1f) on the + <code>pci-root</code> controller is hotplug capable and + can accept a legacy PCI device, either emulated or + assigned from the guest. </p> <h2><a name="ppc64">ppc64 architecture</a></h2> @@ -119,12 +137,12 @@ </controller></pre> <p> - The 31 slots on a <code>pci-root</code> controller are all - hotplug capable and, despite the name suggesting otherwise, - starting with QEMU 2.9 all of them can accept PCI Express - devices in addition to legacy PCI devices; however, - libvirt will only place emulated devices on the default - <code>pci-root</code> controller. + The 31 slots, from 0x01 to 0x1f, on a <code>pci-root</code> + controller are all hotplug capable and, despite the name + suggesting otherwise, starting with QEMU 2.9 all of them + can accept PCI Express devices in addition to legacy PCI + devices; however, libvirt will only place emulated devices + on the default <code>pci-root</code> controller. </p> <p> In order to take advantage of improved error reporting and -- 2.13.5

2 2

[libvirt] [PATCH] virsh: Honour --readonly with cmdConnect and no name
by Martin Kletzander 21 Aug '17

21 Aug '17

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- tools/virsh.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 94bb7ff6c93a..9883e87df2b5 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -218,7 +218,13 @@ virshReconnect(vshControl *ctl, const char *name, bool readonly, bool force) { bool connected = false; virshControlPtr priv = ctl->privData; - bool ro = name ? readonly : priv->readonly; + + /* If the flag was not specified, then it depends on whether we are + * reconnecting to the default URI (in which case we want to keep the + * readonly flag as it was) or to a specified URI in which case it + * should stay false */ + if (!readonly && !name) + readonly = priv->readonly; if (priv->conn) { int ret; @@ -233,7 +239,7 @@ virshReconnect(vshControl *ctl, const char *name, bool readonly, bool force) "disconnect from the hypervisor")); } - priv->conn = virshConnect(ctl, name ? name : ctl->connname, ro); + priv->conn = virshConnect(ctl, name ? name : ctl->connname, readonly); if (!priv->conn) { if (disconnected) -- 2.14.1

2 3