- Devel - libvirt List Archives

[libvirt] [PATCH 0/5] introduce reconnect feature for chardev devices
by Pavel Hrdina 29 Aug '17

29 Aug '17

Pavel Hrdina (5): qemu: introduce QEMU_CAPS_CHARDEV_RECONNECT conf: introduce reconnect element for chardev source tests: add generic xml chardev reconnect tests qemu: implement chardev source reconnect tests: add qemu chardev srouce reconnect tests docs/formatdomain.html.in | 11 ++ docs/schemas/domaincommon.rng | 12 +++ src/conf/domain_conf.c | 119 +++++++++++++++++++-- src/conf/domain_conf.h | 11 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 17 +++ src/qemu/qemu_domain.c | 101 +++++++++++++++++ .../generic-chardev-reconnect-invalid-mode.xml | 26 +++++ .../generic-chardev-reconnect-missing-timeout.xml | 26 +++++ .../generic-chardev-reconnect.xml | 32 ++++++ .../generic-chardev-reconnect.xml | 33 ++++++ tests/genericxml2xmltest.c | 5 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../qemuxml2argv-channel-reconnect.args | 31 ++++++ ...uxml2argv-chardev-reconnect-invalid-timeout.xml | 23 ++++ .../qemuxml2argv-chardev-reconnect.args | 40 +++++++ .../qemuxml2argv-chardev-reconnect.xml | 46 ++++++++ tests/qemuxml2argvtest.c | 11 ++ 31 files changed, 552 insertions(+), 8 deletions(-) create mode 100644 tests/genericxml2xmlindata/generic-chardev-reconnect-invalid-mode.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-reconnect-missing-timeout.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-reconnect.xml create mode 100644 tests/genericxml2xmloutdata/generic-chardev-reconnect.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-reconnect.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-chardev-reconnect-invalid-timeout.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-chardev-reconnect.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-chardev-reconnect.xml -- 2.13.5

3 13

[libvirt] [PATCH v2 0/2] Have qemuDomainUndefineFlags grab a job
by Michal Privoznik 29 Aug '17

29 Aug '17

This is v2 to: https://www.redhat.com/archives/libvir-list/2017-August/msg00222.html diff to v1: - Split qemuDomainRemoveInactive into two functions so that its safe to call it from places where we already have a job. Michal Privoznik (2): qemu: Introduce and use qemuDomainRemoveInactiveJob qemuDomainUndefineFlags: Grab QEMU_JOB_MODIFY src/qemu/qemu_domain.c | 36 +++++++++++++++++++++++++++--------- src/qemu/qemu_domain.h | 3 +++ src/qemu/qemu_driver.c | 47 ++++++++++++++++++++++++++--------------------- src/qemu/qemu_migration.c | 10 +++++----- src/qemu/qemu_process.c | 10 +++++----- 5 files changed, 66 insertions(+), 40 deletions(-) -- 2.13.0

2 6

[libvirt] [libvirt-php][PATCH 0/3] Couple of trivial fixes/improvements
by Michal Privoznik 29 Aug '17

29 Aug '17

*** BLURB HERE *** Michal Privoznik (3): Shut up automake libvirt-php.c: Reorder includes examples: Initialize $ret in index.php configure.ac | 4 ++++ examples/index.php | 1 + src/libvirt-php.c | 8 ++++---- 3 files changed, 9 insertions(+), 4 deletions(-) -- 2.13.5

2 6

[libvirt] [PATCH v4 0/3] Add support for Veritas HyperScale (VxHS) block device protocol
by Ashish Mittal 29 Aug '17

29 Aug '17

From: Ashish Mittal <ashish.mittal(a)veritas.com> QEMU changes for VxHS (including TLS support) are already upstream. This series of patches adds support for VxHS block devices in libvirt. Patch 1 adds the base functionality for supporting VxHS protocol. Patch 2 adds two new configuration options in qemu.conf to enable TLS for VxHS devices. Patch 3 implements the main TLS functionality. Ashish Mittal (3): Add support for Veritas HyperScale (VxHS) block device protocol conf: Introduce TLS options for VxHS block device clients Add TLS support for Veritas HyperScale (VxHS) block device protocol docs/formatdomain.html.in | 31 ++++- docs/schemas/domaincommon.rng | 18 +++ src/conf/domain_conf.c | 19 +++ src/libxl/libxl_conf.c | 1 + src/qemu/libvirtd_qemu.aug | 4 + src/qemu/qemu.conf | 23 +++ src/qemu/qemu_command.c | 155 +++++++++++++++++++++ src/qemu/qemu_conf.c | 7 + src/qemu/qemu_conf.h | 3 + src/qemu/qemu_driver.c | 3 + src/qemu/qemu_parse_command.c | 25 ++++ src/qemu/test_libvirtd_qemu.aug.in | 2 + src/util/virstoragefile.c | 77 +++++++++- src/util/virstoragefile.h | 10 ++ src/xenconfig/xen_xl.c | 1 + .../qemuargv2xml-disk-drive-network-vxhs-fail.args | 24 ++++ tests/qemuargv2xmltest.c | 17 ++- ...ml2argv-disk-drive-network-tlsx509-err-vxhs.xml | 34 +++++ ...-disk-drive-network-tlsx509-multidisk-vxhs.args | 41 ++++++ ...k-drive-network-tlsx509-multidisk-vxhs.args.new | 41 ++++++ ...v-disk-drive-network-tlsx509-multidisk-vxhs.xml | 56 ++++++++ ...muxml2argv-disk-drive-network-tlsx509-vxhs.args | 28 ++++ ...emuxml2argv-disk-drive-network-tlsx509-vxhs.xml | 34 +++++ .../qemuxml2argv-disk-drive-network-vxhs.args | 25 ++++ .../qemuxml2argv-disk-drive-network-vxhs.xml | 34 +++++ tests/qemuxml2argvtest.c | 10 ++ tests/virstoragetest.c | 30 ++++ 27 files changed, 748 insertions(+), 5 deletions(-) create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-vxhs-fail.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-err-vxhs.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.args.new create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-vxhs.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-vxhs.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.xml -- 2.5.5

4 24

[libvirt] [PATCH v2 0/3] Some domain name handling improvements
by Martin Kletzander 29 Aug '17

29 Aug '17

*** BRULB THERE *** Martin Kletzander (3): conf: Properly truncate wide character names in virDomainObjGetShortName qemu: Use short domain name in qemuDomainGetPreservedMountPath docs: Update news with domain name bug fixes docs/news.xml | 20 ++++++++++++++++++++ src/conf/domain_conf.c | 45 ++++++++++++++++++++++++++++++++++++++++++--- src/qemu/qemu_domain.c | 10 ++++++++-- 3 files changed, 70 insertions(+), 5 deletions(-) -- 2.14.1

2 7

[libvirt] [PATCH 0/2] Alter refresh algorithm for volWipe
by John Ferlan 29 Aug '17

29 Aug '17

Alter wipeVol to do same refresh operation as pool refresh would do. John Ferlan (2): storage: Introduce virStorageBackendRefreshVolTargetUpdate storage: Use virStorageBackendRefreshVolTargetUpdate after wipeVol src/storage/storage_driver.c | 7 ++-- src/storage/storage_util.c | 82 +++++++++++++++++++++++++++++--------------- src/storage/storage_util.h | 3 ++ 3 files changed, 62 insertions(+), 30 deletions(-) -- 2.9.5

2 7

[libvirt] [libvirt-go PATCH] Add MigrateGetMaxDowntime API
by John Ferlan 29 Aug '17

29 Aug '17

Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- This is a "best guess" effort - basically copied some previous examples from recent comments, built, and ran the same test that the CI build test runs. domain.go | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/domain.go b/domain.go index cc786dd..f83aa31 100644 --- a/domain.go +++ b/domain.go @@ -2319,6 +2319,21 @@ func (d *Domain) MigrateSetMaxSpeed(speed uint64, flags uint32) error { return nil } +func (d *Domain) MigrateGetMaxDowntime(flags uint32) (uint64, error) { + var downtime C.ulonglong + + if C.LIBVIR_VERSION_NUMBER < 3007000 { + return 0, GetNotImplementedError("virDomainMigrateGetMaxDowntime") + } + + ret := C.virDomainMigrateGetMaxDowntime(d.ptr, &downtime, C.uint(flags)) + if ret == -1 { + return 0, GetLastError() + } + + return uint64(downtime), nil +} + func (d *Domain) MigrateSetMaxDowntime(downtime uint64, flags uint32) error { ret := C.virDomainMigrateSetMaxDowntime(d.ptr, C.ulonglong(downtime), C.uint(flags)) if ret == -1 { -- 2.9.5

1 1

[libvirt] [libvirt-python PATCH 0/2] Python bindings for virDomainMigrateGetMaxDowntime
by John Ferlan 29 Aug '17

29 Aug '17

Implement the bindings similar to previous such implementations for Compression cache (commit id's 7465d31bb and feae4e052) John Ferlan (2): Introduce virDomainMigrateGetMaxDowntime API Implement virDomainMigrateGetMaxDowntime generator.py | 1 + libvirt-override-api.xml | 7 +++++++ libvirt-override.c | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+) -- 2.9.5

1 3

[libvirt] [libvirt-perl PATCH] Add migrate_get_max_downtime
by John Ferlan 29 Aug '17

29 Aug '17

Add new API for 3.7 pushed code for virDomainMigrateGetMaxDowntime Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Changes | 1 + Virt.xs | 15 +++++++++++++++ lib/Sys/Virt/Domain.pm | 6 ++++++ 3 files changed, 22 insertions(+) diff --git a/Changes b/Changes index e7f6cde..a3e507f 100644 --- a/Changes +++ b/Changes @@ -3,6 +3,7 @@ Revision history for perl module Sys::Virt 3.7.0 2017-00-00 - Add VIR_FROM_RESCTRL constant + - Add migrate_get_max_downtime 3.5.0 2017-07-06 diff --git a/Virt.xs b/Virt.xs index d3019ee..11c3d8f 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5325,6 +5325,21 @@ migrate_set_max_downtime(dom, downtime, flags=0) _croak_error(); +SV * +migrate_get_max_downtime(dom, flags=0) + virDomainPtr dom; + unsigned int flags; + PREINIT: + unsigned long long downtime; + CODE: + if (virDomainMigrateGetMaxDowntime(dom, &downtime, flags) < 0) + _croak_error(); + + RETVAL = virt_newSVull(downtime); + OUTPUT: + RETVAL + + void migrate_set_max_speed(dom, bandwidth, flags=0) virDomainPtr dom; diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 20ecf9f..030e1e3 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -1254,6 +1254,12 @@ at the cost of longer time blackout for the guest OS at the switch over point. The C<downtime> parameter is measured in milliseconds. The C<$flags> parameter is currently unused and defaults to zero. +=item $downtime = $dom->migrate_get_max_downtime($flags=0) +Get the current value of the maximum downtime allowed during a +migration of a guest. The returned <downtime> value is measured +in milliseconds. The C<$flags> parameter is currently unused and +defaults to zero. + =item $dom->migrate_set_max_speed($bandwidth, $flags=0) Set the maximum allowed bandwidth during migration of the guest. -- 2.9.5

1 1

[libvirt] [PATCH v4 0/7] Add new APIs to edit xml configuration of managed save state of a domain
by Kothapally Madhu Pavan 28 Aug '17

28 Aug '17

managedsave command offloads the user from managing the save state file. It does not need the user to specify saved state file location, all it takes is domain name to identify. This makes it much more comfortable to use in emergency where immediate shutdowm is needed. But it doesn't provide a way to edit XML description of the save state file without user going through an extra effort to search manually where the file actually exists. The series aims to overcome the above constraints by adding new APIs and commands to seemlessly edit the managed save state XML description using just the domain name. The Patches mainly make use of the save-image-edit code flow only to simplify the above use case. This patch set provides capability to Dump and Edit the XML configuration associated with a saved state file of a domain which was created by the managedsave command. The new command carry the similar options as the save-image-<XXX> commands to change the running state as to paused state or running on start. This is equivalent to: virsh managedsave-dumpxml domain-name > state-file.xml vi state-file.xml (or make changes with your other text editor) virsh managedsave-define domain-name state-file-xml or you can simply use: virsh managedsave-edit domain-name It's always better when we get more. Changes since v3: - refracted version references from 3.6.0 to 3.7.0 - fixed typo in error message. Changes since v2: - refracted version references from 3.5.0 to 3.6.0 Changes since v1: - qemu implementation called directly rather than going through driver pointer in qemuDomainManagedSaveDefineXML. - check whether the managed save state file exists and report a error if it doesn't. Kothapally Madhu Pavan (7): lib: Add API to dump xml configuration of managed save state domain lib: Add API to edit domain's managed save state xml configuration qemu: Implement qemuDomainManagedSaveGetXMLDesc qemu: Implement qemuDomainManagedSaveDefineXML virsh: Implement managedsave-define command virsh: Implement managedsave-dumpxml command virsh: Implement managedsave-edit command include/libvirt/libvirt-domain.h | 6 ++ src/driver-hypervisor.h | 11 +++ src/libvirt-domain.c | 107 ++++++++++++++++++++ src/libvirt_public.syms | 6 ++ src/qemu/qemu_driver.c | 87 ++++++++++++++++ src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 31 +++++- src/remote_protocol-structs | 14 +++ tools/virsh-domain.c | 207 +++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 41 ++++++++ 10 files changed, 511 insertions(+), 1 deletion(-) -- 1.8.3.1

2 11