- Devel - libvirt List Archives

[PATCH] esxConnectListAllDomains: Don't propagate failure to lookup a single domain
by Peter Krempa 26 Mar '25

26 Mar '25

From: Peter Krempa <pkrempa(a)redhat.com> In esxConnectListAllDomains if the lookup of the VM name and UUID fails for a single VM (possible e.g. with broken storage) the whole API would return failure even when there are working VMs. Rework the lookup so that if a subset fails we ignore the failure on those. We report an error only if lookup of all of the objects failed. Failure is reported from the last one. Resolves: https://issues.redhat.com/browse/RHEL-80606 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/esx/esx_driver.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 554fb3e18f..d869481698 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -4792,18 +4792,21 @@ esxConnectListAllDomains(virConnectPtr conn, virtualMachine = virtualMachine->_next) { g_autofree char *name = NULL; - if (needIdentity) { - if (esxVI_GetVirtualMachineIdentity(virtualMachine, &id, - &name, uuid) < 0) { + /* If the lookup of the required properties fails for some of the machines + * in the list it's preferrable to return the valid objects instead of + * failing outright */ + if ((needIdentity && esxVI_GetVirtualMachineIdentity(virtualMachine, &id, &name, uuid) < 0) || + (needPowerState && esxVI_GetVirtualMachinePowerState(virtualMachine, &powerState) < 0)) { + + /* Raise error from last lookup if we didn't successfuly fetch any + * domain objecst yet */ + if (count == 0 && !virtualMachine->_next) goto cleanup; - } - } - if (needPowerState) { - if (esxVI_GetVirtualMachinePowerState(virtualMachine, - &powerState) < 0) { - goto cleanup; - } + /* failure to fetch information of a single VM must not interrupt + * the lookup of the rest */ + virResetLastError(); + continue; } /* filter by active state */ -- 2.49.0

2 3

[PATCH] NEWS: Mention bump to qemu-6.2, vhost-user shmem check and stats params discoverabilty
by Peter Krempa 26 Mar '25

26 Mar '25

From: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 18d45656b8..2855ec77e4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,11 @@ v11.2.0 (unreleased) * **Removed features** + * Remove support for qemu-6.1 and older + + Libvirt now requires *qemu-6.2* or newer based on our platform support + policy. + * **New features** * qemu: Add new 'image_format' parameter to virDomainSaveParams @@ -87,6 +92,21 @@ v11.2.0 (unreleased) The new error codes are ``VIR_ERR_AGENT_COMMAND_TIMEOUT`` and ``VIR_ERR_AGENT_COMMAND_FAILED``. + * qemu: Use common check for shared memory use for ``vhost-user`` network devices + + Historically libvirt printed only a warning if the ``vhost-user`` network + was misconfigured. Since we enforce proper configuration for other device + types using ``vhost-user`` it is now enforced also for network devices and + prints an actual error on misconfiguration. + + + * Introduce constants for discoverability of entries in bulk stats APIs + + Libvirt introduced constants exposed by our API description XML which allows + discoverability of new entries in typed parameter names returned by + ``virConnectGetAllDomainStats``, ``virDomainListGetStats``, and + ``virDomainGetGuestInfo``. + * **Bug fixes** * qemu: attach virtio-mem with CCW address -- 2.49.0

2 1

[PATCH V4 00/18] qemu: support mapped-ram+directio+mulitfd
by Jim Fehlig 25 Mar '25

25 Mar '25

V4 series adding support for QEMU's mapped-ram stream format [1] and migration capability. The use of mapped-ram is controlled by extending save_image_format setting in qemu.conf with a new 'sparse' option. The 'raw' format continues to be the default. Also included are patches that leverage mapped-ram to add support for parallel save/restore. Changes in V4: * Rebased on latest master, including the series "qemu: Support specifying save image format" V1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MNB… V2: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/GNJ… V3: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/SK2… [1] https://gitlab.com/qemu-project/qemu/-/blob/master/docs/devel/migration/map… Claudio Fontana (3): include: Define constants for parallel save/restore tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command Jim Fehlig (15): lib: virDomain{Save,Restore}Params: Ensure absolute path qemu: Add function to get FDPass object from monitor qemu: Add function to check capability in migration params qemu: Add function to get bool value from migration params qemu: Add mapped-ram migration capability qemu: Add function to get migration params for save qemu_saveimage: add "sparse" to supported save image formats qemu: Add helper function for creating save image fd qemu: Add support for mapped-ram on save qemu: Move creation of qemuProcessIncomingDef struct qemu: Apply migration parameters in qemuMigrationDstRun qemu: Add support for mapped-ram on restore qemu: Support O_DIRECT with mapped-ram on save qemu: Support O_DIRECT with mapped-ram on restore qemu: Add support for parallel save and restore docs/manpages/virsh.rst | 21 +++- include/libvirt/libvirt-domain.h | 11 ++ src/libvirt-domain.c | 92 +++++++++++--- src/qemu/qemu.conf.in | 9 +- src/qemu/qemu_driver.c | 78 +++++++++--- src/qemu/qemu_fd.c | 46 +++++++ src/qemu/qemu_fd.h | 4 + src/qemu/qemu_migration.c | 204 ++++++++++++++++++++++--------- src/qemu/qemu_migration.h | 10 +- src/qemu/qemu_migration_params.c | 92 ++++++++++++++ src/qemu/qemu_migration_params.h | 17 +++ src/qemu/qemu_monitor.c | 37 ++++++ src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_process.c | 100 ++++++++++----- src/qemu/qemu_process.h | 19 ++- src/qemu/qemu_saveimage.c | 120 ++++++++++++------ src/qemu/qemu_saveimage.h | 4 + src/qemu/qemu_snapshot.c | 15 ++- tools/virsh-domain.c | 81 ++++++++++-- 19 files changed, 775 insertions(+), 190 deletions(-) -- 2.43.0

3 45

Entering freeze for libvirt-11.2.0
by Jiri Denemark 25 Mar '25

25 Mar '25

I have just tagged v11.2.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 0

[PATCH] NEWS: Mention virsh hypervisor-cpu-models command
by Boris Fiuczynski 25 Mar '25

25 Mar '25

Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1fc80e2496..18d45656b8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -67,6 +67,14 @@ v11.2.0 (unreleased) restore. Using multiple channels can reduce the time required to save and restore domains. + * virsh: Introduce new hypervisor-cpu-models command + + Added a new virsh command ``hypervisor-cpu-models``. The command pulls from + the existing domcapabilities XML and uses xpath to parse CPU model strings. + By default, only models reported as usable by the hypervisor on the host + system are printed. A user may specify ``--all`` to also print models which + are not supported on the host. + * **Improvements** * qemu: Improved guest agent corner case error reporting -- 2.47.0

2 1

[PATCH v3 0/3] Reflect MAC change in live domain XML
by Michal Privoznik 25 Mar '25

25 Mar '25

v3 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MW4… or: https://marc.info/?l=libvir-list&m=174230601829060&w=2 since our list archive is giving me some HTTP error currently. diff to v2: - Rebased (there were some public APIs merged meanwhile, creating a conflict in RPC files), - switched from 'guestAddress' to 'currentAddress'. Michal Prívozník (3): qemu: Reflect MAC address change in live domain XML Introduce NIC_MAC_CHANGE event qemu: Emit NIC_MAC_CHANGE event docs/formatdomain.rst | 5 ++ examples/c/misc/event-test.c | 14 +++++ include/libvirt/libvirt-domain.h | 28 +++++++++ src/conf/domain_conf.c | 6 ++ src/conf/domain_conf.h | 3 + src/conf/domain_event.c | 93 +++++++++++++++++++++++++++++ src/conf/domain_event.h | 12 ++++ src/conf/schemas/domaincommon.rng | 5 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_domain.c | 48 ++++++++++++++- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 11 ++-- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 32 ++++++++++ src/remote/remote_driver.c | 34 +++++++++++ src/remote/remote_protocol.x | 16 ++++- src/remote_protocol-structs | 8 +++ tools/virsh-domain-event.c | 20 +++++++ 18 files changed, 334 insertions(+), 8 deletions(-) -- 2.48.1

2 4

[PATCH] docs: add table showing guest IP/DNS/gateway settings when using SLIRP
by Laine Stump 25 Mar '25

25 Mar '25

When using the default SLIRP backend for <interface type='user'>, the <ip address='blah' prefix='blur'/> setting doesn't behave as might be expected (i.e. it doesn't set the guest interface IP/prefix to exactly the provided values). This *should* have created questions when users originally encountered it, but instead it has become more apparent as people are contemplating switching from using the SLIRP backend to using passt instead (with passt, the <ip> settings do behave "as expected"). In order to make this difference in behavior less mysterious, Yalan Zhang kindly took the time to test and document the effect of various representative <ip> settings on guest interface config when SLIRP is used (see https://issues.redhat.com/browse/RHEL-46601) this patch adds that same table to libvirt's documentation. Signed-off-by: Laine Stump <laine(a)redhat.com> --- docs/formatdomain.rst | 69 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 58 insertions(+), 11 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index aae58fab60..a6d0660135 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5239,15 +5239,7 @@ network address by including an ``ip`` element specifying an IPv4 address in its one mandatory attribute, ``address``. Optionally, a second ``ip`` element with a ``family`` attribute set to "ipv6" can be specified to add an IPv6 address to the interface. ``address``. -Optionally, an address ``prefix`` can be specified. These settings are -surprisingly **not** used by SLIRP to set the exact IP address; -instead they are used to determine what network/subnet the guest's IP -address should be on, and the guest will be given an address in that -subnet, but the host portion of the address will still be "2.15". In -the example below, for example, the guest will be given the IP address -172.17.2.15 (**note that the '1.1' in the host portion of the address -has been ignored**), default route of 172.17.2.2, and DNS server -172.17.2.3. +Optionally, an address ``prefix`` can be specified. :: @@ -5263,6 +5255,59 @@ has been ignored**), default route of 172.17.2.2, and DNS server </devices> ... +These settings are surprisingly **not** used by SLIRP to set the exact +IP address; instead they are used to determine what **network/subnet** +the guest's IP address should be on, and the guest will be given an +address in that subnet, but the host portion of the address will still +be the host portion of "10.0.2.15" (based on the configured prefix (or +a prefix of 24 if no prefix is specified). The DNS and default gateway +addresses given to the guest will be similarly based on the network +portion of the configuration-provided <ip> combined with the host +portion of SLIRPs default settings for DNS/gateway +(10.0.2.3/10.0.2.2). To help resolve the confusion of the previous +sentences, the table below shows examples of the settings that will be +provided to the guest (via a DHCP response) to use for its interface +config (ip/prefix, DNS, default gateway) for various settings of <ip> +element address and prefix in libvirt's <interface type='user'> +config: + +.. list-table:: + :header-rows: 1 + + * - libvirt <ip> element + - guest ip/prefix + - guest DNS + - guest default gateway + + * - (unspecified) + - 10.0.2.15/24 + - 10.0.2.3 + - 10.0.2.2 + + * - address='172.17.1.1' + prefix='16' + - 172.17.2.15/16 + - 172.17.2.3 + - 172.17.2.2 + + * - address='172.17.1.1' + prefix='24' + - 172.17.1.15/24 + - 172.17.1.3 + - 172.17.1.2 + + * - address='172.17.1.1' + prefix='8' + - 172.0.2.15/16 + - 172.0.2.3 + - 172.0.2.2 + + * - address='172.17.1.1' + prefix='23' + - 172.17.0.15/23 + - 172.17.0.3 + - 172.17.0.2 + Userspace connection using passt ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -5304,8 +5349,10 @@ any conflict). Also different from SLIRP's behavior: if you do specify IP address(es), the exact address and netmask/prefix you specify will be provided to the guest (i.e. passt doesn't interpret the <ip> settings -as a network address like SLIRP does, but as a host address). In -example given above, the guest IP would be set to exactly 172.17.1.1. +as a network address like SLIRP does, but as a host address). In the +table of examples given above, the guest IP would be set to exactly +172.17.1.1 in all cases (the DNS and default gateway will be set +the same as they are on the host). Just as with SLIRP, though, once traffic from the guest leaves the host towards the rest of the network, it will always appear as if it -- 2.48.1

2 1

[PATCH] NEWS: qemu: Support for Block Disk Along with Throttle Filters
by Harikumar Rajkumar 25 Mar '25

25 Mar '25

NEWS: qemu: Support for Block Disk Along with Throttle Filters Harikumar Rajkumar (1): NEWS: Support block disk along with throttle filters NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.48.1

2 2

[libvirt PATCH] qemu_driver: Fix virDomainSaveImageDefineXML
by Pavel Hrdina 24 Mar '25

24 Mar '25

From: Pavel Hrdina <phrdina(a)redhat.com> Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore sparse images but changed the boolean that controls if we open the file as read-only or read-write. Editing XML in the save image resulted in following error message: failed to write header to domain save file '/data/images/fedora40.save': Bad file descriptor Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3cf21380ed..056a9e579d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5945,7 +5945,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path, if (qemuSaveImageGetMetadata(driver, NULL, path, &def, &data) < 0) goto cleanup; - fd = qemuSaveImageOpen(driver, path, false, false, NULL, false); + fd = qemuSaveImageOpen(driver, path, false, false, NULL, true); if (fd < 0) goto cleanup; -- 2.49.0

2 1

[libvirt PATCH 0/6] cleanup and fixes of the mapped-ram feature
by Pavel Hrdina 24 Mar '25

24 Mar '25

Pavel Hrdina (6): tools: remove --parallel from virsh restore command tools: remote --parallel from virsh save command qemu: remove VIR_DOMAIN_SAVE_PARALLEL flag tools: use virDomainRestoreParams only when necessary tools: use virDomainSaveParams only when necessary virsh: add --image-format option to the save command docs/manpages/virsh.rst | 24 +++++---- include/libvirt/libvirt-domain.h | 1 - src/qemu/qemu_driver.c | 6 +-- src/qemu/qemu_migration_params.c | 34 ++++++------ tools/virsh-domain.c | 93 ++++++++++++++++---------------- 5 files changed, 80 insertions(+), 78 deletions(-) -- 2.48.1

4 11