- Devel - libvirt List Archives

[libvirt] [PATCH 00/17] Move qemu command line controller checks to qemuDomainDeviceDefValidateController* checks
by John Ferlan 06 Dec '17

06 Dec '17

Recent series to just move IDE checks: (v4: https://www.redhat.com/archives/libvir-list/2017-December/msg00049.html) gave me enough "push" in order to move the bulk of qemu_command controller command line build "validation" checks into their own Validation helpers. The IDE only checks are essentially incorporated into this series. John Ferlan (14): qemu: Introduce qemuDomainDeviceDefValidateController qemu: Introduce qemuDomainDeviceDefSkipController qemu: Use virDomainControllerType in qemuBuildControllerDevStr switch qemu: Move CCW S390 Address check to controller def validate qemu: Introduce qemuDomainDeviceDefValidateControllerSCSI qemu: Introduce qemuDomainDeviceDefValidateControllerPCI qemu: Use virDomainPCIControllerOpts in qemuBuildControllerDevStr qemu: Move PCI command modelName check to controller def validate qemu: Move PCI command modelName TypeToString to controller def validate qemu: Move PCI more command checks to controller def validate qemu: Complete PCI command checks to controller def validate qemu: Introduce qemuDomainDeviceDefValidateControllerSATA qemu: Introduce qemuDomainDeviceDefValidateControllerUSB qemu: Complete move USB command checks to controller def validate Lin Ma (3): tests: Remove use of IDE disk for pseries floppy test tests: Drop IDE controller in CCW qemu: Introduce qemuDomainDeviceDefValidateControllerIDE src/qemu/qemu_command.c | 566 ++------------------ src/qemu/qemu_command.h | 2 + src/qemu/qemu_domain.c | 590 ++++++++++++++++++++- src/qemu/qemu_domain.h | 12 + .../qemuhotplug-base-ccw-live+ccw-virtio.xml | 4 - ...ive-with-2-ccw-virtio+ccw-virtio-1-explicit.xml | 4 - ...live-with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 4 - ...qemuhotplug-base-ccw-live-with-2-ccw-virtio.xml | 4 - ...-live-with-ccw-virtio+ccw-virtio-2-explicit.xml | 4 - ...-base-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 4 - .../qemuhotplug-base-ccw-live-with-ccw-virtio.xml | 4 - .../qemuhotplug-base-ccw-live.xml | 4 - tests/qemumemlocktest.c | 14 + .../qemuxml2argv-disk-floppy-pseries.args | 24 - .../qemuxml2argv-disk-floppy-pseries.xml | 7 - tests/qemuxml2argvtest.c | 18 +- tests/qemuxml2xmltest.c | 20 +- 17 files changed, 689 insertions(+), 596 deletions(-) delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-floppy-pseries.args -- 2.13.6

2 26

[libvirt] [sandbox 0/6] Misc patches
by Cédric Bosdonnat 06 Dec '17

06 Dec '17

Hi all, Here are a few patches I found sitting on my local copy. I also added a few patches to convert to python3. Cédric Bosdonnat (6): Pass debug and verbose values to init machine: use squash security mode for non-root virt-sandbox mounts Add tests .log and .trs files to gitignore service: fix bad ConfigMountHostImage constructor call Convert to python3 Don't hardcode interpreter path .gitignore | 2 + bin/virt-sandbox-image | 2 +- bin/virt-sandbox-service | 75 +++++++++++++---------- bin/virt-sandbox.c | 3 + examples/demo.py | 2 +- examples/shell.py | 2 +- examples/virt-sandbox-mkinitrd.py | 2 +- examples/virt-sandbox.py | 2 +- libvirt-sandbox/image/cli.py | 20 +++--- libvirt-sandbox/image/sources/base.py | 1 - libvirt-sandbox/image/sources/docker.py | 42 ++++++------- libvirt-sandbox/image/sources/virtbuilder.py | 1 - libvirt-sandbox/image/template.py | 8 +-- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 5 +- libvirt-sandbox/libvirt-sandbox-config.c | 75 +++++++++++++++++++++++ libvirt-sandbox/libvirt-sandbox-config.h | 6 ++ libvirt-sandbox/libvirt-sandbox-init-common.c | 3 + libvirt-sandbox/libvirt-sandbox.sym | 4 ++ 18 files changed, 179 insertions(+), 76 deletions(-) -- 2.15.1

3 16

[libvirt] [PATCH jenkins-ci] Trigger rebuild of libvirt-go-xml when libvirt changes
by Daniel P. Berrange 06 Dec '17

06 Dec '17

Although the core code in libvirt-go-xml doesn't depend on libvirt, the test suite pulls in libvirt.git to validate XML parsing against all XML files found under libvirt.git/tests. We should thus have a dependancy in jenkins to trigger rebuilds when libvirt changes. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- projects/libvirt-go-xml.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/libvirt-go-xml.yaml b/projects/libvirt-go-xml.yaml index 3083b9f..126058b 100644 --- a/projects/libvirt-go-xml.yaml +++ b/projects/libvirt-go-xml.yaml @@ -15,6 +15,6 @@ export TEST_ARGS="-tags xmlroundtrip" jobs: - go-build-job: - parent_jobs: + parent_jobs: 'libvirt-master-build' - go-check-job: parent_jobs: 'libvirt-go-xml-master-build' -- 2.14.3

2 1

[libvirt] [jenkins-ci PATCH] guests: install additional debugging tools
by Pavel Hrdina 06 Dec '17

06 Dec '17

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- guests/vars/mappings.yml | 14 ++++++++++++++ guests/vars/projects/base.yml | 4 ++++ 2 files changed, 18 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index eca8dbe..ff97231 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -100,6 +100,9 @@ mappings: default: gcc FreeBSD: + gdb: + default: gdb + gettext: default: gettext @@ -306,6 +309,9 @@ mappings: pkg: libxslt rpm: libxslt-devel + lsof: + default: lsof + lvm2: default: lvm2 FreeBSD: @@ -390,6 +396,10 @@ mappings: deb: libnetcf-dev rpm: netcf-devel + netstat: + default: net-tools + FreeBSD: + numad: default: numad FreeBSD: @@ -631,6 +641,10 @@ mappings: rpm: spice-gtk3-devel CentOS6: + strace: + default: strace + FreeBSD: + unzip: default: unzip FreeBSD: diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index d82f6b9..352e85a 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -6,12 +6,16 @@ packages: - ccache - cppi - gcc + - gdb - gettext - glibc - libtool - libtoolize + - lsof - make + - netstat - patch - perl - pkg-config - rpmbuild + - strace -- 2.13.6

2 1

[libvirt] [PATCH] nwfilter: don't crash listing filters in unprivileged daemon
by Daniel P. Berrange 06 Dec '17

06 Dec '17

The unprivileged libvirtd does not support nwfilter config, by leaves the driver active. It is supposed to result in all APIs being an effective no-op, but several APIs rely on driver->nwfilters being non-NULL, or they will reference a NULL pointer. Rather than adding checks for NULL in many places, just make sure driver->nwfilters is always initialized. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/nwfilter/nwfilter_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index 2f9a51c405..89b767fe11 100644 --- a/src/nwfilter/nwfilter_driver.c +++ b/src/nwfilter/nwfilter_driver.c @@ -189,6 +189,8 @@ nwfilterStateInitialize(bool privileged, /* remember that we are going to use firewalld */ driver->watchingFirewallD = (sysbus != NULL); driver->privileged = privileged; + if (!(driver->nwfilters = virNWFilterObjListNew())) + goto error; if (!privileged) return 0; @@ -244,9 +246,6 @@ nwfilterStateInitialize(bool privileged, goto error; } - if (!(driver->nwfilters = virNWFilterObjListNew())) - goto error; - if (virNWFilterObjListLoadAllConfigs(driver->nwfilters, driver->configDir) < 0) goto error; @@ -271,6 +270,7 @@ nwfilterStateInitialize(bool privileged, virNWFilterIPAddrMapShutdown(); err_free_driverstate: + virNWFilterObjListFree(driver->nwfilters); VIR_FREE(driver); return -1; -- 2.14.3

3 2

[libvirt] [rust PATCH] README: update libvirt.org links
by Ján Tomko 05 Dec '17

05 Dec '17

The documentation page used the link from before libvirt.h was split into multiple files. The master repo linked to the go bindings. Fix both and switch them to https, which is now default for the website. --- Although trivial, I did not push these since I'm not a maintainer. README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 29d38a2..5643f74 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,7 @@ The bindings use standard errors handling from Rust. Each method ## Documentation -* http://libvirt.org/html/libvirt-libvirt.html +* https://libvirt.org/html/index.html * https://docs.rs/crate/virt/ ## Tests/Exercises @@ -87,7 +87,7 @@ Or to send all patches on the current branch, against master Note the master GIT repository is at -* http://libvirt.org/git/?p=libvirt-go.git;a=summary +* https://libvirt.org/git/?p=libvirt-rust.git;a=summary The following automatic read-only mirrors are available as a convenience to allow contributors to "fork" the repository: -- 2.13.6

2 1

[libvirt] [PATCH] maint: Bump version number to 4.0.0
by Andrea Bolognani 05 Dec '17

05 Dec '17

As documented in https://libvirt.org/downloads.html#schedule https://libvirt.org/downloads.html#numbering the next release will happen in the middle of January 2018 and, being the first release of a new year, will bring a brand new major version number with it. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the "I can't believe you got it wrong, Michal!" rule. configure.ac | 2 +- docs/news.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ec98e83d7..fba4e4bf5 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [3.11.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] +AC_INIT([libvirt], [4.0.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/docs/news.xml b/docs/news.xml index 72bdea220..0ec9857e2 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -33,7 +33,7 @@ --> <libvirt> - <release version="v3.11.0" date="unreleased"> + <release version="v4.0.0" date="unreleased"> <section title="New features"> </section> <section title="Improvements"> -- 2.14.3

1 0

[libvirt] [PATCH 0/3] macOS build and CI fixes
by Andrea Bolognani 05 Dec '17

05 Dec '17

The first one is technically a build breaker, but only affects development builds so it can wait the end of the freeze I guess. The second patch gets Travis to the point where the build failure would actually show up, and the last one is just a small cleanup. Andrea Bolognani (3): util: gettid() is Linux-specific travis: Upgrade brew packages travis: Don't try to install brew packages twice .travis.yml | 2 +- src/util/virthread.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.14.3

2 6

[libvirt] [PATCH 0/4] tests: Drop more useless prefixes
by Michal Privoznik 05 Dec '17

05 Dec '17

Yet again, trimmed patches, whole patches can be found here: https://github.com/zippy2/libvirt/commits/qemuxml2xmldata Michal Privoznik (4): test: Drop useless prefix for qemuagent test data test: Drop useless prefix for qemuargv2xml test data test: Drop useless prefix for qemuxml2xmldata test data test: Drop useless prefix for genericxml2xml test data tests/genericxml2xmltest.c | 4 ++-- tests/qemuagenttest.c | 2 +- tests/qemuargv2xmltest.c | 4 ++-- tests/qemuxml2xmltest.c | 8 ++++---- <trim/> 684 files changed, 15 insertions(+), 15 deletions(-) -- 2.13.6

2 5

[libvirt] libvirt 3.9.0 locks (was libvirt 3.5.0 locks)
by Vasiliy Tolstov 05 Dec '17

05 Dec '17

Hi again. I'm still try to determine why my libvirtd locks, this is another portion of gdb stuff: https://gist.github.com/vtolstov/ae8c4a67e15b2fbd14bbb95c226fb427 error looks in logs like: Dec 01 12:35:49 cn04 libvirtd[1171]: 2017-12-01 09:35:49.637+0000: 28063: error : qemuDomainObjBeginJobInternal:4403 : Timed out during operation: cannot acquire state change lock (held by remoteDispatchConnectGetAllDomainStats) Dec 01 12:35:49 cn04 libvirtd[1171]: 2017-12-01 09:35:49.637+0000: 28063: warning : qemuDomainObjBeginJobInternal:4391 : Cannot start job (destroy, none) for domain 225560-20001; current job is (query, none) owned by (1180 remoteDispatchConnectGetAllDomainStats, 0 <null>) for (30s, 0s) and virsh list says that domain in shutdown state (but qemu process already exited). Please, help me to solve this issue. -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

3 7