- Devel - libvirt List Archives

[libvirt] [PATCH] cpu: Add support for al57 Intel features
by Shaohe Feng 01 Feb '18

01 Feb '18

We can start qemu with a "cpu,+la57" to set 57-bit vitrual address space. So VM can be aware that it need to enable 5-level paging. Corresponding QEMU commits: al57 6c7c3c21f95dd9af8a0691c0dd29b07247984122 --- src/cpu/cpu_map.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index e5da7a8..922a195 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -285,6 +285,9 @@ <feature name='ospke'> <cpuid eax_in='0x07' ecx_in='0x00' ecx='0x00000010'/> </feature> + <feature name='la57'> + <cpuid eax_in='0x07' ecx_in='0x00' ecx='0x00010000'/> + </feature> <feature name='avx512-4vnniw'> <cpuid eax_in='0x07' ecx_in='0x00' edx='0x00000004'/> -- 2.7.4

4 6

[libvirt] [PATCH go] go: Add ERR_DEVICE_MISSING constants
by Chen Hanxiao 01 Feb '18

01 Feb '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- error.go | 3 +++ error_compat.h | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/error.go b/error.go index fb218f7..9de277c 100644 --- a/error.go +++ b/error.go @@ -353,6 +353,9 @@ const ( // error in libssh transport driver ERR_LIBSSH = ErrorNumber(C.VIR_ERR_LIBSSH) + + // libvirt fail to find the desired device + ERR_DEVICE_MISSING = ErrorNumber(C.VIR_ERR_DEVICE_MISSING) ) type ErrorDomain int diff --git a/error_compat.h b/error_compat.h index f26dc09..64ed991 100644 --- a/error_compat.h +++ b/error_compat.h @@ -147,4 +147,10 @@ #define VIR_FROM_RESCTRL 67 #endif +/* 4.1.0 */ + +#ifndef VIR_ERR_DEVICE_MISSING +#define VIR_ERR_DEVICE_MISSING 99 +#endif + #endif /* LIBVIRT_GO_ERROR_COMPAT_H__ */ -- 2.14.3

2 1

[libvirt] [PATCH perl] perl: Add ERR_DEVICE_MISSING constants
by Chen Hanxiao 01 Feb '18

01 Feb '18

From: Chen Hanxiao <chenhanxiao(a)gmail.com> Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- Changes | 2 +- Virt.xs | 1 + lib/Sys/Virt/Error.pm | 4 ++++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Changes b/Changes index eda3ec5..22d5752 100644 --- a/Changes +++ b/Changes @@ -2,7 +2,7 @@ Revision history for perl module Sys::Virt 4.1.0 2018-00-00 - - XXX + - Add VIR_ERR_DEVICE_MISSING constants 4.0.0 2018-01-23 diff --git a/Virt.xs b/Virt.xs index 7d2f1a7..f19880f 100644 --- a/Virt.xs +++ b/Virt.xs @@ -9488,4 +9488,5 @@ BOOT: REGISTER_CONSTANT(VIR_ERR_NO_CLIENT, ERR_NO_CLIENT); REGISTER_CONSTANT(VIR_ERR_AGENT_UNSYNCED, ERR_AGENT_UNSYNCED); REGISTER_CONSTANT(VIR_ERR_LIBSSH, ERR_LIBSSH); + REGISTER_CONSTANT(VIR_ERR_DEVICE_MISSING, ERR_DEVICE_MISSING); } diff --git a/lib/Sys/Virt/Error.pm b/lib/Sys/Virt/Error.pm index b97985d..78f33f3 100644 --- a/lib/Sys/Virt/Error.pm +++ b/lib/Sys/Virt/Error.pm @@ -812,6 +812,10 @@ Libvirt guest agent replies with wrong id to guest-sync command The libSSH operation failed +=item Sys::Virt::Error::ERR_DEVICE_MISSING + +Libvirt fail to find the desired device. + =back =head1 AUTHORS -- 2.14.3

2 1

[libvirt] [PATCH] conf: Small indentation and coding style fixes
by Andrea Bolognani 01 Feb '18

01 Feb '18

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. src/conf/domain_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8efe83489..b83e31d8c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -26862,8 +26862,9 @@ virDomainDefFormatInternal(virDomainDefPtr def, case VIR_DOMAIN_FEATURE_CAPABILITIES: if (def->features[i] == VIR_DOMAIN_CAPABILITIES_POLICY_DEFAULT && - !virDomainDefHasCapabilitiesFeatures(def)) + !virDomainDefHasCapabilitiesFeatures(def)) { break; + } virBufferAsprintf(buf, "<capabilities policy='%s'>\n", virDomainCapabilitiesPolicyTypeToString(def->features[i])); -- 2.14.3

1 0

[libvirt] [PATCH 00/10] Enable direct use of secondary drivers
by Daniel P. Berrangé 31 Jan '18

31 Jan '18

Currently the secondary drivers can only be used if you have a connection to a primary hypervisor driver. This series introduces explicit URIs that allow opening a connection that only talks to a specific secondary driver. In the future these URIs will resolve to individual daemons containing those drivers. This also allows us to fix long standing problems with most code that uses secrets internally. We need to pass a virConnectPtr into such code but some call stacks don't have a connection available. In some cases we open a temporary connection to the QEMU driver, but this is suboptimal for deployments without the QEMU driver present. Daniel P. Berrangé (10): storage: move driver registration back to end of the file storage: allow opening with storage:///system and storage:///session URIs network: move driver registration back to end of the file network: allow opening with network:///system and network:///session URIs nwfilter: allow opening with nwfilter:///system URI interface: allow opening with interface:///system and interface:///session URIs nodedev: allow opening with nodedev:///system and nodedev:///session URIs secret: allow opening with secret:///system and secret:///session URIs storage: open secret driver connection at time of use storage: remove virConnectPtr from all backend functions src/interface/interface_backend_netcf.c | 98 ++++++++- src/interface/interface_backend_udev.c | 97 ++++++++- src/network/bridge_driver.c | 185 +++++++++++++---- src/network/bridge_driver_platform.h | 3 + src/node_device/node_device_driver.c | 73 ++++++- src/node_device/node_device_driver.h | 9 + src/node_device/node_device_hal.c | 18 ++ src/node_device/node_device_udev.c | 19 ++ src/nwfilter/nwfilter_driver.c | 83 ++++++++ src/secret/secret_driver.c | 95 +++++++++ src/storage/storage_backend.h | 45 ++-- src/storage/storage_backend_disk.c | 30 +-- src/storage/storage_backend_fs.c | 15 +- src/storage/storage_backend_gluster.c | 9 +- src/storage/storage_backend_iscsi.c | 24 +-- src/storage/storage_backend_logical.c | 38 ++-- src/storage/storage_backend_mpath.c | 5 +- src/storage/storage_backend_rbd.c | 53 ++--- src/storage/storage_backend_scsi.c | 46 +++-- src/storage/storage_backend_sheepdog.c | 33 ++- src/storage/storage_backend_vstorage.c | 10 +- src/storage/storage_backend_zfs.c | 15 +- src/storage/storage_driver.c | 351 ++++++++++++++++++++------------ src/storage/storage_util.c | 146 ++++++------- src/storage/storage_util.h | 39 ++-- tests/storagevolxml2argvtest.c | 7 +- 26 files changed, 1047 insertions(+), 499 deletions(-) -- 2.14.3

4 21

[libvirt] [PATCH] util: use union for sockaddr structs to avoid aliasing
by Daniel P. Berrangé 31 Jan '18

31 Jan '18

From: "Daniel P. Berrange" <berrange(a)redhat.com> Some platforms/toolchains will complain about casting sockaddr_storage to sockaddr_un because it breaks strict aliasing rule ../../src/util/virutil.c: In function 'virGetUNIXSocketPath': ../../src/util/virutil.c:2005: error: dereferencing pointer 'un' does break strict-aliasing rules [-Wstrict-aliasing] Change the code to use a union, in the same way that the virsocketaddr.h header does. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as (yet another) CI build fix src/util/virutil.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index c23fa8f92e..cd6fbf2f30 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -1985,30 +1985,33 @@ virGetListenFDs(void) #ifdef HAVE_SYS_UN_H char *virGetUNIXSocketPath(int fd) { - struct sockaddr_storage ss = { 0 }; - struct sockaddr_un *un = (struct sockaddr_un *)&ss; - socklen_t len = sizeof(ss); + union { + struct sockaddr sa; + struct sockaddr_storage ss; + struct sockaddr_un un; + } addr = { .ss = { 0 } }; + socklen_t len = sizeof(addr.ss); char *path; - if (getsockname(fd, (struct sockaddr *)&ss, &len) < 0) { + if (getsockname(fd, &addr.sa, &len) < 0) { virReportSystemError(errno, _("Unable to get address of FD %d"), fd); return NULL; } - if (ss.ss_family != AF_UNIX) { + if (addr.ss.ss_family != AF_UNIX) { virReportSystemError(EINVAL, _("FD %d is not a UNIX socket, has af=%d"), - fd, ss.ss_family); + fd, addr.ss.ss_family); return NULL; } - if (un->sun_path[0] == '\0') - un->sun_path[0] = '@'; + if (addr.un.sun_path[0] == '\0') + addr.un.sun_path[0] = '@'; - if (VIR_ALLOC_N(path, sizeof(un->sun_path) + 1) < 0) + if (VIR_ALLOC_N(path, sizeof(addr.un.sun_path) + 1) < 0) return NULL; - memcpy(path, un->sun_path, sizeof(un->sun_path)); - path[sizeof(un->sun_path)] = '\0'; + memcpy(path, addr.un.sun_path, sizeof(addr.un.sun_path)); + path[sizeof(addr.un.sun_path)] = '\0'; return path; } -- 2.14.3

1 0

[libvirt] [PATCH] Fixed virGetUNIXSocketPath stub on Win32
by Daniel P. Berrangé 31 Jan '18

31 Jan '18

The _() macro was not terminated and an argument needs to be marked as unused. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a win32 build fix src/util/virutil.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index 8352e0f1f1..c23fa8f92e 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -2014,10 +2014,10 @@ char *virGetUNIXSocketPath(int fd) #else /* HAVE_SYS_UN_H */ -char *virGetUNIXSocketPath(int fd) +char *virGetUNIXSocketPath(int fd ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", - _("UNIX sockets not supported on this platform"); + _("UNIX sockets not supported on this platform")); return NULL; } -- 2.14.3

1 0

[libvirt] [PATCH 0/9] Set the SCSI controller model during post parse
by John Ferlan 31 Jan '18

31 Jan '18

Fallout or a pile yak shavings from the series to move the controller validation from command line building into domain xml validation: https://www.redhat.com/archives/libvir-list/2018-January/msg00188.html This series grabs the first patch from the other series that was essentially already ACK'd, but instead of heading down the path of "working around" the fact that SCSI controller model may not be set after domain post processing, this series builds up a series of changes to implement altering the SCSI controller model during device post processing rather than waiting for the validation phase to "cheat" and alter a local model value temporarily. The first 4 patches are relatively straightforward and don't change any of the outputs. Starting with patch 5, things get a bit more interesting. Patch 6 is where the conversion to set the default model for SCSI controllers starts... Patch 7 is where things got a bit tricky w/r/t the implicit controller... Patches 8 and 9 just perform cleanup from that setting. If this is accepted - I'll go back to the other series to adjust and repost; otherwise, we can determine whether the other series is necessary or if we're just happy with the way things are. John Ferlan (9): qemu: Split qemuDomainSetSCSIControllerModel conf: Rework and rename virDomainDeviceFindControllerModel qemu: Introduce qemuDomainFindSCSIControllerModel qemu: Introduce qemuDomainGetSCSIControllerModel qemu: Fetch/save the default SCSI controller model during hotplug qemu: Introduce qemuDomainSetSCSIControllerModel conf: Allow configuration of implicit controller model qemu: Reduce need to call qemuDomainGetSCSIControllerModel qemu: Update qemuDomainFindSCSIControllerModel return src/conf/domain_conf.c | 41 ++++-- src/conf/domain_conf.h | 6 +- src/libvirt_private.syms | 2 +- src/qemu/qemu_alias.c | 14 +- src/qemu/qemu_alias.h | 3 +- src/qemu/qemu_command.c | 88 +++++++++--- src/qemu/qemu_command.h | 3 +- src/qemu/qemu_domain.c | 8 +- src/qemu/qemu_domain_address.c | 149 +++++++++++---------- src/qemu/qemu_domain_address.h | 11 +- src/qemu/qemu_hotplug.c | 14 +- src/vbox/vbox_common.c | 8 +- tests/qemuargv2xmldata/nomachine-ppc64.xml | 2 +- tests/qemuargv2xmldata/pseries-disk.xml | 2 +- .../qemuhotplug-base-with-scsi-controller-live.xml | 8 +- ...se-without-scsi-controller-live+disk-scsi-2.xml | 8 +- tests/qemuxml2xmloutdata/disk-scsi-device-auto.xml | 2 +- .../hostdev-scsi-lsi-iscsi-auth.xml | 2 +- .../qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi.xml | 2 +- tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 2 +- 20 files changed, 229 insertions(+), 146 deletions(-) -- 2.13.6

2 11

[libvirt] [PATCH] virUSBDeviceNew: Construct vroot path properly
by Michal Privoznik 31 Jan '18

31 Jan '18

When starting an LXC container, the /dev entries are created under temp root (/var/run/libvirt/lxc/$name.dev), relabelled and then the root is pivoted. However, when it comes to USB devices which keep path to the device in the structure we need a way to override the default /dev/usb/... path because we want to work with the one under temp root. That's what @vroot argument is for in virUSBDeviceNew. However, what is being passed there is: vroot = /var/run/libvirt/lxc/lxc_0.dev/bus/usb Therefore, constructed path is wrong: dev->path = //var/run/libvirt/lxc/lxc_0.dev/bus/usb//dev/bus/usb/002/002 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virusb.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/util/virusb.c b/src/util/virusb.c index 6359235ff..f06639eec 100644 --- a/src/util/virusb.c +++ b/src/util/virusb.c @@ -343,9 +343,13 @@ virUSBDeviceNew(unsigned int bus, virUSBDeviceFree(dev); return NULL; } - if (virAsprintf(&dev->path, "%s" USB_DEVFS "%03d/%03d", - vroot ? vroot : "", - dev->bus, dev->dev) < 0) { + + if ((vroot && + virAsprintf(&dev->path, "%s/%03d/%03d", + vroot, dev->bus, dev->dev) < 0) || + (!vroot && + virAsprintf(&dev->path, USB_DEVFS "%03d/%03d", + dev->bus, dev->dev) < 0)) { virUSBDeviceFree(dev); return NULL; } -- 2.13.6

2 1

[libvirt] [PATCH] blockjob: Fix a error checking of blockjob status in some case
by Jie Wang 31 Jan '18

31 Jan '18

offset and len can also be equal to 0 on failed if blockjob return status:"BLOCK_JOB_COMPLETED" with error:"File descriptor in bad state", this bug can be reproduced easily if you perform a async block job on read only filesystem, so it's very worthwhile for us to check 'error' in this case. --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 5ddd855..442b218 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -889,7 +889,7 @@ qemuMonitorJSONHandleBlockJobImpl(qemuMonitorPtr mon, case VIR_DOMAIN_BLOCK_JOB_COMPLETED: error = virJSONValueObjectGetString(data, "error"); /* Make sure the whole device has been processed */ - if (offset != len) + if (offset != len || error) event = VIR_DOMAIN_BLOCK_JOB_FAILED; break; case VIR_DOMAIN_BLOCK_JOB_CANCELED: -- 1.8.3.1

3 2