- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: remove unused QEMU_CAPS_ENABLE_KVM
by Klim Kireev 02 Mar '18

02 Mar '18

It needs for the -enable-kvm flag. This qemu flag can be compiled out, but we already detect that case with the QEMU_CAPS_KVM check. So this check is redundant and can be removed Signed-off-by: Klim Kireev <klim.s.kireev(a)gmail.com> --- src/qemu/qemu_capabilities.c | 13 +------------ src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 14 ++------------ tests/qemucaps2xmldata/all_1.6.0-1.caps | 2 +- tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps | 2 +- tests/qemuhelptest.c | 8 +++----- tests/qemuxml2argvdata/controller-order.args | 1 - tests/qemuxml2argvdata/cpu-host-kvmclock.args | 1 - tests/qemuxml2argvdata/cpu-kvmclock.args | 1 - tests/qemuxml2argvtest.c | 11 +++++------ 10 files changed, 14 insertions(+), 41 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index b5eb8cf46..2a373d3a2 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1091,7 +1091,6 @@ virQEMUCapsInitGuestFromBinary(virCapsPtr caps, if (virFileExists("/dev/kvm") && (virQEMUCapsGet(qemubinCaps, QEMU_CAPS_KVM) || - virQEMUCapsGet(qemubinCaps, QEMU_CAPS_ENABLE_KVM) || kvmbin)) haskvm = true; @@ -1260,7 +1259,7 @@ virQEMUCapsComputeCmdFlags(const char *help, if (strstr(help, "-no-kvm")) virQEMUCapsSet(qemuCaps, QEMU_CAPS_KVM); if (strstr(help, "-enable-kvm")) - virQEMUCapsSet(qemuCaps, QEMU_CAPS_ENABLE_KVM); + virQEMUCapsSet(qemuCaps, QEMU_CAPS_KVM); if (strstr(help, ",process=")) virQEMUCapsSet(qemuCaps, QEMU_CAPS_NAME_PROCESS); @@ -3201,7 +3200,6 @@ virQEMUCapsProbeQMPKVMState(virQEMUCapsPtr qemuCaps, virQEMUCapsClear(qemuCaps, QEMU_CAPS_KVM); } else if (!enabled) { virQEMUCapsClear(qemuCaps, QEMU_CAPS_KVM); - virQEMUCapsSet(qemuCaps, QEMU_CAPS_ENABLE_KVM); } return 0; @@ -4388,15 +4386,6 @@ virQEMUCapsIsValid(void *data, kvmUsable = virFileAccessibleAs("/dev/kvm", R_OK | W_OK, priv->runUid, priv->runGid) == 0; - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM) && - virQEMUCapsGet(qemuCaps, QEMU_CAPS_ENABLE_KVM) && - kvmUsable) { - VIR_DEBUG("KVM was not enabled when probing '%s', " - "but it should be usable now", - qemuCaps->binary); - return false; - } - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM) && !kvmUsable) { VIR_DEBUG("KVM was enabled when probing '%s', " diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index c2ec2be19..11a10b2f6 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -79,7 +79,7 @@ typedef enum { X_QEMU_CAPS_XEN_DOMID, /* -xen-domid */ X_QEMU_CAPS_MIGRATE_QEMU_UNIX, /* qemu migration via unix sockets */ X_QEMU_CAPS_CHARDEV, /* Is the new -chardev arg available */ - QEMU_CAPS_ENABLE_KVM, /* -enable-kvm flag */ + X_QEMU_CAPS_ENABLE_KVM, /* -enable-kvm flag */ QEMU_CAPS_MONITOR_JSON, /* JSON mode for monitor */ /* 25 */ diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9b1affd30..a68bf088e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6992,13 +6992,10 @@ qemuBuildObsoleteAccelArg(virCommandPtr cmd, const virDomainDef *def, virQEMUCapsPtr qemuCaps) { - bool disableKVM = false; - bool enableKVM = false; - switch ((int)def->virtType) { case VIR_DOMAIN_VIRT_QEMU: if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM)) - disableKVM = true; + virCommandAddArg(cmd, "-no-kvm"); break; case VIR_DOMAIN_VIRT_KQEMU: @@ -7007,9 +7004,7 @@ qemuBuildObsoleteAccelArg(virCommandPtr cmd, break; case VIR_DOMAIN_VIRT_KVM: - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_ENABLE_KVM)) { - enableKVM = true; - } else if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM)) { + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("the QEMU binary does not support kvm")); return -1; @@ -7023,11 +7018,6 @@ qemuBuildObsoleteAccelArg(virCommandPtr cmd, return -1; } - if (disableKVM) - virCommandAddArg(cmd, "-no-kvm"); - if (enableKVM) - virCommandAddArg(cmd, "-enable-kvm"); - return 0; } diff --git a/tests/qemucaps2xmldata/all_1.6.0-1.caps b/tests/qemucaps2xmldata/all_1.6.0-1.caps index d39d0bebb..35b737a40 100644 --- a/tests/qemucaps2xmldata/all_1.6.0-1.caps +++ b/tests/qemucaps2xmldata/all_1.6.0-1.caps @@ -2,7 +2,7 @@ <flag name='mem-path'/> <flag name='drive-serial'/> <flag name='chardev'/> - <flag name='enable-kvm'/> + <flag name='kvm'/> <flag name='monitor-json'/> <flag name='balloon'/> <flag name='device'/> diff --git a/tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps b/tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps index 5a0372c91..5e99e7d43 100644 --- a/tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps +++ b/tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps @@ -2,7 +2,7 @@ <flag name='mem-path'/> <flag name='drive-serial'/> <flag name='chardev'/> - <flag name='enable-kvm'/> + <flag name='kvm'/> <flag name='monitor-json'/> <flag name='balloon'/> <flag name='device'/> diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index 1336eeef5..fb1998c84 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -147,7 +147,7 @@ mymain(void) DO_TEST("qemu-0.12.1", 12001, 0, 0, QEMU_CAPS_DRIVE_SERIAL, - QEMU_CAPS_ENABLE_KVM, + QEMU_CAPS_KVM, QEMU_CAPS_SDL, QEMU_CAPS_RTC, QEMU_CAPS_NO_HPET, @@ -182,7 +182,6 @@ mymain(void) QEMU_CAPS_DRIVE_SERIAL, QEMU_CAPS_MEM_PATH, QEMU_CAPS_SDL, - QEMU_CAPS_ENABLE_KVM, QEMU_CAPS_RTC, QEMU_CAPS_NO_HPET, QEMU_CAPS_NO_KVM_PIT, @@ -220,7 +219,6 @@ mymain(void) QEMU_CAPS_DRIVE_SERIAL, QEMU_CAPS_MEM_PATH, QEMU_CAPS_SDL, - QEMU_CAPS_ENABLE_KVM, QEMU_CAPS_MONITOR_JSON, QEMU_CAPS_NETDEV, QEMU_CAPS_RTC, @@ -267,7 +265,7 @@ mymain(void) QEMU_CAPS_DRIVE_SERIAL, QEMU_CAPS_MEM_PATH, QEMU_CAPS_SDL, - QEMU_CAPS_ENABLE_KVM, + QEMU_CAPS_KVM, QEMU_CAPS_MONITOR_JSON, QEMU_CAPS_NETDEV, QEMU_CAPS_RTC, @@ -338,7 +336,7 @@ mymain(void) QEMU_CAPS_DRIVE_SERIAL, QEMU_CAPS_MEM_PATH, QEMU_CAPS_SDL, - QEMU_CAPS_ENABLE_KVM, + QEMU_CAPS_KVM, QEMU_CAPS_MONITOR_JSON, QEMU_CAPS_NETDEV, QEMU_CAPS_RTC, diff --git a/tests/qemuxml2argvdata/controller-order.args b/tests/qemuxml2argvdata/controller-order.args index 70a8ba9ce..fea56cc05 100644 --- a/tests/qemuxml2argvdata/controller-order.args +++ b/tests/qemuxml2argvdata/controller-order.args @@ -8,7 +8,6 @@ QEMU_AUDIO_DRV=spice \ -name fdr \ -S \ -M rhel6.1.0 \ --enable-kvm \ -m 4096 \ -smp 4,sockets=4,cores=1,threads=1 \ -uuid d091ea82-29e6-2e34-3005-f02617b36e87 \ diff --git a/tests/qemuxml2argvdata/cpu-host-kvmclock.args b/tests/qemuxml2argvdata/cpu-host-kvmclock.args index 1e45f0558..b82962b23 100644 --- a/tests/qemuxml2argvdata/cpu-host-kvmclock.args +++ b/tests/qemuxml2argvdata/cpu-host-kvmclock.args @@ -8,7 +8,6 @@ QEMU_AUDIO_DRV=none \ -name QEMUGuest1 \ -S \ -M pc \ --enable-kvm \ -cpu host,-kvmclock \ -m 214 \ -smp 6,sockets=6,cores=1,threads=1 \ diff --git a/tests/qemuxml2argvdata/cpu-kvmclock.args b/tests/qemuxml2argvdata/cpu-kvmclock.args index 358b9be05..06a96ae4b 100644 --- a/tests/qemuxml2argvdata/cpu-kvmclock.args +++ b/tests/qemuxml2argvdata/cpu-kvmclock.args @@ -8,7 +8,6 @@ QEMU_AUDIO_DRV=none \ -name QEMUGuest1 \ -S \ -M pc \ --enable-kvm \ -cpu core2duo,-kvmclock \ -m 214 \ -smp 6,sockets=6,cores=1,threads=1 \ diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 688846b9b..67836a936 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -796,16 +796,15 @@ mymain(void) DO_TEST("clock-france", QEMU_CAPS_RTC); DO_TEST("clock-hpet-off", QEMU_CAPS_RTC); DO_TEST("clock-catchup", QEMU_CAPS_RTC); - DO_TEST("cpu-kvmclock", QEMU_CAPS_ENABLE_KVM); - DO_TEST("cpu-host-kvmclock", QEMU_CAPS_ENABLE_KVM); + DO_TEST("cpu-kvmclock", QEMU_CAPS_KVM); + DO_TEST("cpu-host-kvmclock", QEMU_CAPS_KVM); DO_TEST("kvmclock", QEMU_CAPS_KVM); DO_TEST("clock-timer-hyperv-rtc", QEMU_CAPS_KVM); - DO_TEST("cpu-eoi-disabled", QEMU_CAPS_ENABLE_KVM); - DO_TEST("cpu-eoi-enabled", QEMU_CAPS_ENABLE_KVM); + DO_TEST("cpu-eoi-disabled", NONE); + DO_TEST("cpu-eoi-enabled", NONE); DO_TEST("controller-order", QEMU_CAPS_KVM, - QEMU_CAPS_ENABLE_KVM, QEMU_CAPS_BOOT_MENU, QEMU_CAPS_PIIX3_USB_UHCI, QEMU_CAPS_PCI_MULTIFUNCTION, @@ -821,7 +820,7 @@ mymain(void) DO_TEST("eoi-enabled", NONE); DO_TEST("pv-spinlock-disabled", NONE); DO_TEST("pv-spinlock-enabled", NONE); - DO_TEST("kvmclock+eoi-disabled", QEMU_CAPS_ENABLE_KVM); + DO_TEST("kvmclock+eoi-disabled", NONE); DO_TEST("hyperv", NONE); DO_TEST("hyperv-off", NONE); -- 2.16.1

2 1

[libvirt] [tck PATCH 0/2] set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test
by Laine Stump 02 Mar '18

02 Mar '18

We've recently discovered two separate bugs that caused libvirt's "DHCP Snooping" feature to not work: https://bugzilla.redhat.com/show_bug.cgi?id=1529338 - libvirt regression https://bugzilla.redhat.com/show_bug.cgi?id=1547237 - libpcap regression Since we didn't have any test suite covering that code, we had the embarrassment of learning of it from someone else's QE (RHV/oVirt QE at Red Hat). This series adds the necessary stuff to the test domain config of libvirt-tck's "no-ip-spoofing" test to exercise the DHCPSnoop thread. (There may be a much better way of dealing with a hash-inside-a-hash; I am an imbecile at perl, and arrived at this code by trial, error, and google searches). Laine Stump (2): new helper function get_network_ip() set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test lib/Sys/Virt/TCK.pm | 11 ++++++++--- lib/Sys/Virt/TCK/DomainBuilder.pm | 8 +++++++- lib/Sys/Virt/TCK/NetworkHelpers.pm | 10 ++++++++++ scripts/nwfilter/220-no-ip-spoofing.t | 9 ++++++++- 4 files changed, 33 insertions(+), 5 deletions(-) -- 2.14.3

1 3

[libvirt] [PATCH] tests: introduce qemucapsfixreplies helper
by Pavel Hrdina 01 Mar '18

01 Mar '18

Sometimes we don't regenerate QEMU capabilities replies using QEMU binary but we simply add a new entry manually. In that case you need to manually fix all the replies ids. This helper will do that for you. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- tests/qemucapsfixreplies | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100755 tests/qemucapsfixreplies diff --git a/tests/qemucapsfixreplies b/tests/qemucapsfixreplies new file mode 100755 index 0000000000..25b1e597a9 --- /dev/null +++ b/tests/qemucapsfixreplies @@ -0,0 +1,22 @@ +#!/bin/sh + +if [ "$1" == "--help" ] || [ $# != 1 ] || [ ! -f $1 ]; then + echo "This script fixes replies ids in QEMU replies files." + echo "" + echo " Usage: $0 path/to/qemu.replies" + exit 0; +fi + +awk -i inplace \ + 'BEGIN {count=1; pattern="libvirt-[0-9]+"} + { + if (match($0, "libvirt-1[^0-9]")) { + count=1; + } + if (match($0, pattern)) { + str="libvirt-" count; + sub(pattern, str, $0); + count++; + } + print + }' $1 -- 2.14.3

2 2

[libvirt] [PATCH] news: Update release notes
by --help 01 Mar '18

01 Mar '18

Signed-off-by: --help <mprivozn(a)redhat.com> --- docs/news.xml | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 86a0c8d18..53bf9a49c 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,28 @@ using the <code>cachetune</code> element in <code>cputune</code>. </description> </change> + <change> + <summary> + Allow opening secondary drivers + </summary> + <description> + Up until now it was possible to connect to only hypervisor drivers + (e.g. qemu:///system, lxc:///, vbox:///system, and so on). The + internal drivers (like network driver, node device driver, etc.) were + hidden from users and users could use them only indirectly. Starting + with this release new connection URIs are accepted. For instance + network:///system, storage:///system and so on. + </description> + </change> + <change> + <summary> + virtlogd, virtlockd: Add support for admin protocol + </summary> + <description> + These two daemons now support admin protocol through which some admin + info can be gathered or some configuration tweaked on the fly. + </description> + </change> </section> <section title="Improvements"> <change> @@ -82,8 +104,88 @@ libxl: add support for setting clock offset and adjustment </summary> </change> + <change> + <summary> + Make port allocator global + </summary> + <description> + Up until now each driver had their own port allocator module. This + meant that info on port usage was not shared. Starting with this + release, the port allocator module is made global and therefore + drivers allocate ports from global pool. + </description> + </change> + <change> + <summary> + src: Enable building with GCC 8.0 + </summary> + <description> + GCC 8.0 added more warnings which found some genuine problems with our code. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + qemu: Check for unsafe migration more thoroughly + </summary> + <description> + If a domain disk is stored on local filesystem (e.g. ext4) but is + not being migrated it is very likely that domain is not able to + run on destination. Regardless of share/cache mode. + </description> + </change> + <change> + <summary> + qemu: Fix updating device with boot order + </summary> + <description> + Starting with 3.7.0 release updating any device with boot order would + fail with 'boot order X is already used by another device' while in + fact it was the very same device. + </description> + </change> + <change> + <summary> + virlog: determine the hostname on startup CVE-2018-6764 + </summary> + <description> + At later point it might not be possible or even safe to use + getaddrinfo(). It can in turn result in a load of NSS module which + can even be loaded from unsage guest filesystem and thus escape the + confinment of its container. + </description> + </change> + <change> + <summary> + qemu: Rework vCPU statistics fetching + </summary> + <description> + Fetching vCPU statistics was very expensive because it lead to waking + up vCPU threads in QEMU and thus it degraded performance. The code + was reworked so that fetching statistics does not wake up halted + vCPUs. + </description> + </change> + <change> + <summary> + qemu: unlink memory backing file on domain shutdown + </summary> + <description> + Depending on the filesystem where domain memory is stored, some files + might have been left behind. This is not a problem on hugetlbfs, but + it is a problem on regular filesystems like ext4. + </description> + </change> + <change> + <summary> + qemu: Fix shutting down domains in parallel + </summary> + <description> + If multiple domains were being shut down in parallel, libvirtd might + have deadlocked. + </description> + </change> </section> </release> <release version="v4.0.0" date="2018-01-19"> -- 2.16.1

7 21

[libvirt] [PATCH] src: Fix checking for clang
by Andrea Bolognani 01 Mar '18

01 Mar '18

The check was trying to use the shell variable $CC instead of the make variable $(CC); it also interpreted grep's return code wrong: 1 means the provided pattern was *not* matched. As a result, pdwtags was never run, not even when building with gcc. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 5794915246..3bf2da543d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -668,8 +668,7 @@ struct_prefix = ($(libs_prefix)|$(other_prefix)) # which causes the comparison against expected output to fail, so skip # if using clang as CC. PDWTAGS = \ - $(AM_V_GEN)$CC -v 2>&1 | grep -q clang; \ - if test $$? == 1; then \ + $(AM_V_GEN)if $(CC) -v 2>&1 | grep -q clang; then \ echo 'WARNING: skipping pdwtags test with Clang' >&2; \ exit 0; \ fi; \ -- 2.14.3

2 1

[libvirt] [PATCH] virtio-scsi: Add virtqueue_size parameter for qemu
by Klim Kireev 01 Mar '18

01 Mar '18

In QEMU commit 5c0919d02066c3d0eb896c33265ad90101a6a84a adds new option virtqueue_size. This Patch allows this option to be set in libvirt. --- docs/formatdomain.html.in | 6 ++++++ src/conf/domain_conf.c | 12 ++++++++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 3 +++ 4 files changed, 22 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6fd2189cd..2f33b5e70 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3867,6 +3867,12 @@ host. <span class="since">Since 1.2.7 (QEMU and KVM only)</span> </dd> + <dt><code>virtqueue_size</code></dt> + <dd> + The optional <code>virtqueue_size</code> attribute specifies the size of + virtio queue. + <span class="since">Since 3.7.0 (QEMU and KVM only)</span> + </dd> <dt><code>max_sectors</code></dt> <dd> The optional <code>max_sectors</code> attribute specifies the maximum diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d96b012b9..36a4deea2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9976,6 +9976,7 @@ virDomainControllerDefParseXML(virDomainXMLOptionPtr xmlopt, char *model = NULL; char *queues = NULL; char *cmd_per_lun = NULL; + char *virtqueue_size = NULL; char *max_sectors = NULL; bool processedModel = false; char *modelName = NULL; @@ -10035,6 +10036,7 @@ virDomainControllerDefParseXML(virDomainXMLOptionPtr xmlopt, queues = virXMLPropString(cur, "queues"); cmd_per_lun = virXMLPropString(cur, "cmd_per_lun"); max_sectors = virXMLPropString(cur, "max_sectors"); + virtqueue_size = virXMLPropString(cur, "virtqueue_size"); ioeventfd = virXMLPropString(cur, "ioeventfd"); iothread = virXMLPropString(cur, "iothread"); @@ -10089,6 +10091,12 @@ virDomainControllerDefParseXML(virDomainXMLOptionPtr xmlopt, goto error; } + if (virtqueue_size && virStrToLong_ui(virtqueue_size, NULL, 10, &def->virtqueue_size) < 0) { + virReportError(VIR_ERR_XML_ERROR, + _("Malformed 'virtqueue_size' value '%s'"), virtqueue_size); + goto error; + } + if (max_sectors && virStrToLong_ui(max_sectors, NULL, 10, &def->max_sectors) < 0) { virReportError(VIR_ERR_XML_ERROR, _("Malformed 'max_sectors' value %s"), max_sectors); @@ -10310,6 +10318,7 @@ virDomainControllerDefParseXML(virDomainXMLOptionPtr xmlopt, VIR_FREE(model); VIR_FREE(queues); VIR_FREE(cmd_per_lun); + VIR_FREE(virtqueue_size); VIR_FREE(max_sectors); VIR_FREE(modelName); VIR_FREE(chassisNr); @@ -23293,6 +23302,9 @@ virDomainControllerDriverFormat(virBufferPtr buf, if (def->cmd_per_lun) virBufferAsprintf(&driverBuf, " cmd_per_lun='%u'", def->cmd_per_lun); + if (def->virtqueue_size) + virBufferAsprintf(&driverBuf, " virtqueue_size='%u'", def->virtqueue_size); + if (def->max_sectors) virBufferAsprintf(&driverBuf, " max_sectors='%u'", def->max_sectors); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 368f16f3f..141bd1aca 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -816,6 +816,7 @@ struct _virDomainControllerDef { int model; /* -1 == undef */ unsigned int queues; unsigned int cmd_per_lun; + unsigned int virtqueue_size; unsigned int max_sectors; int ioeventfd; /* enum virTristateSwitch */ unsigned int iothread; /* unused = 0, > 0 specific thread # */ diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index fa0aa5d5c..9b1affd30 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2808,6 +2808,9 @@ qemuBuildControllerDevStr(const virDomainDef *domainDef, if (def->queues) virBufferAsprintf(&buf, ",num_queues=%u", def->queues); + if (def->virtqueue_size) + virBufferAsprintf(&buf, ",virtqueue_size=%u", def->virtqueue_size); + if (def->cmd_per_lun) virBufferAsprintf(&buf, ",cmd_per_lun=%u", def->cmd_per_lun); -- 2.16.1

2 1

[libvirt] [PATCH] docs: remove legacy XHTML <!DOCTYPE> declaration
by Daniel P. Berrangé 28 Feb '18

28 Feb '18

We have switched the docs to using the HTML5 doctype declaration in commit b1c81567c7172bc9dcd701cf46ea3f87725d62c7 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Wed Jul 26 18:01:25 2017 +0100 docs: switch to using HTML5 doctype declaration Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a trivial fix docs/pci-hotplug.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/pci-hotplug.html.in b/docs/pci-hotplug.html.in index 4ac87d644f..9a26645aa4 100644 --- a/docs/pci-hotplug.html.in +++ b/docs/pci-hotplug.html.in @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<!DOCTYPE html> <html xmlns="http://www.w3.org/1999/xhtml"> <body> <h1>PCI topology and hotplug</h1> -- 2.14.3

1 0

[libvirt] [PATCH v2 0/5] Misc improvements & fixes to Travis
by Daniel P. Berrangé 28 Feb '18

28 Feb '18

Changed in v2: - Dropped VPATH patch, since distcheck is doing that already - Skip pdwtags when building with clang - Run install & dist on OS-X - Test systemd as well as upstart - Pass initscript configure flags to distcheck, not autogen.sh Daniel P. Berrangé (5): make: skip pdwtags when building with CLang travis: drop precise distro jobs travis: run "make distcheck" instead of just "make check" travis: test "make install" and "make dist" on OS-X travis: test upstart/systemd init script handling .travis.yml | 22 +++++++++++----------- src/Makefile.am | 10 +++++++++- 2 files changed, 20 insertions(+), 12 deletions(-) -- 2.14.3

2 13

[libvirt] [PATCH 0/3] qemu: Fix updating device with boot order
by Jiri Denemark 28 Feb '18

28 Feb '18

Commit v3.7.0-14-gc57f3fd2f8 prevented adding a <boot order='x'/> element to an inactive domain with global <boot dev='...'/> element. However, as a result of that change updating any device with boot order would fail with 'boot order X is already used by another device', where "another device" is in fact the device which is being updated. To fix this we have to ignore the device which we're about to update when checking for boot order conflicts. https://bugzilla.redhat.com/show_bug.cgi?id=1546971 Jiri Denemark (3): lxc: Drop useless check in live device update Pass oldDev to virDomainDefCompatibleDevice on device update qemu: Fix updating device with boot order src/conf/domain_conf.c | 30 ++++++++++++++++++++++------- src/conf/domain_conf.h | 3 ++- src/lxc/lxc_driver.c | 18 +++++++++--------- src/qemu/qemu_driver.c | 51 ++++++++++++++++++++++++++++++++++++++++---------- 4 files changed, 75 insertions(+), 27 deletions(-) -- 2.16.2

3 5

[libvirt] Entering freeze for libvirt 4.1.0 release
by Daniel Veillard 28 Feb '18

28 Feb '18

I didn't sent a warning mail, but people reminded me that it's time to roll the releases, so I just tagged rc1 in git head and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ Looks fine with my limited testing, amazingly https://ci.centos.org/view/libvirt/ is all green so things seems they should go smoothly, that said the devil is in the details so please give this RC1 some testing especially on other platforms and OSes ! It all goes well I will push rc2 on Wed and the final release early Fri, but in the meantime, please test it :-) thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1