- Devel - libvirt List Archives

[libvirt] [PATCH 0/3] virSysinfo: Introduce SMBIOS type 3 support
by Zhuangyanying 15 Feb '18

15 Feb '18

From: Zhuang Yanying <ann.zhuangyanying(a)huawei.com> Some applications inside VM need to access SMBIOS Chassis Asset Tag, which should be emulated. access inside VM (for example) Linux: /sys/class/dmi/id/chassis_asset_tag. Windows: (Get-WmiObject Win32_SystemEnclosure).SMBIOSAssetTag wirhin Windows PowerShell. It has already been realized in qemu: SMBIOS: Build aggregate smbios tables and entry point https://git.qemu.org/?p=qemu.git;a=commit;h=c97294ec1b9e36887e119589d456557… but not in libvirt. we realize it here. As an example, you could use something like <chassis> <entry name='manufacturer'>Huawei</entry> <entry name='version'>To be filled by O.E.M.</entry> <entry name='serial'>To be filled by O.E.M.</entry> <entry name='asset'>To be filled by O.E.M.</entry> <entry name='sku'>Type3Sku1</entry> </chassis> BTW: I'll be on vacation for china spring festival for the next week, I'll response as soon as I get back if there's any modification needed. Zhuang Yanying (3): conf: add support for setting Chassis SMBIOS data fields qemu: add support for generating SMBIOS Chassis strings command line news: add support for setting Chassis SMBIOS data fields docs/formatdomain.html.in | 23 +++++++ docs/news.xml | 5 ++ docs/schemas/domaincommon.rng | 22 ++++++ src/conf/domain_conf.c | 55 +++++++++++++++ src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 51 ++++++++++++++ src/util/virsysinfo.c | 133 +++++++++++++++++++++++++++++++++++- src/util/virsysinfo.h | 13 ++++ tests/qemuxml2argvdata/smbios.args | 2 + tests/qemuxml2argvdata/smbios.xml | 7 ++ tests/qemuxml2xmloutdata/smbios.xml | 7 ++ 11 files changed, 318 insertions(+), 1 deletion(-) -- 1.8.3.1

2 5

[libvirt] Should we switch to a different JSON library?
by Martin Kletzander 14 Feb '18

14 Feb '18

Hi everyone, so we are using yajl for parsing JSON. However there are some reasons why we might consider switching to another one: 1) It is basically dead upstream 2) We're just using the lexer part of it 3) We only use it for parsing 4) The are workarounds for it in the code So I looked at some options and found few other libraries, I only took those that are widely available (read: I checked if some random downstream distro has them), however most of them were not very much usable. Except one. But here's the list of few others that didn't look that bad either. All are MIT-licensed, try to be thread-safe and support pkg-config: - libfastjson [1] - from rsyslog community, optimized for working with logs, used almost only by rsyslog, it's supposed to have doxygen docs, they switched to libfastjson from json-c due to some problems with it (performance, ref counting bug, ...) - json-c [2] - looked abandoned until I looked at the proper github page, "documentation" in doxygen - Jansson [3] - I really like this one. The API seems very intuitive, it has nice documentation [4] in readthedocs (and I'm not talking about the visual style, but how easy is to find information), it can be used for formatting JSON in a similar way we are doing it. It has json_auto_t (optional) type that uses the attribute cleanup for automatic scope dereference (just in case we want to use it), it has iterators... did I tell you I like this one a lot? What do you (others) think of switching the JSON library? Do you know about any other projects that could be used considering license, platform support, etc.? Also feel free to fix any mistakes I might have posted. I double-checked it, but you know, "trust, but verify". Have a nice day, Martin [1] https://github.com/rsyslog/libfastjson [2] https://github.com/json-c/json-c [3] http://www.digip.org/jansson/ [4] https://jansson.readthedocs.io/

7 9

[libvirt] [PATCH 0/6] spec: Misc cleanups and improvements
by Jiri Denemark 14 Feb '18

14 Feb '18

Jiri Denemark (6): spec: Enable fuse only if LXC is enabled spec: Build virt-login-shell iff LXC driver is enabled spec: Drop checks for old Fedora releases spec: Prepare for future RHEL spec: Fix indentation in daemon's triggerpostun spec: Drop overlapping triggers libvirt.spec.in | 64 ++++++++++++++++++++++----------------------------------- 1 file changed, 25 insertions(+), 39 deletions(-) -- 2.16.1

2 12

[libvirt] [PATCH v2 0/2] Fix parsing and formatting of 'UnixSocketAddress' qapi type
by Peter Krempa 14 Feb '18

14 Feb '18

v2: Don't 'fix' it for gluster disks which use old syntax not conforming to the schema in qemu. Peter Krempa (2): storage: Fix formatting and parsing of qemu type 'UnixSocketAddress' virstoragetest: Add test case for NBD over unix socket with new syntax src/qemu/qemu_block.c | 13 +++++++++++-- src/util/virstoragefile.c | 8 +++++++- tests/virstoragetest.c | 9 +++++++++ 3 files changed, 27 insertions(+), 3 deletions(-) -- 2.15.0

2 3

[libvirt] [jenkins-ci PATCH] jobs: Shorten name for python-distutils jobs
by Andrea Bolognani 14 Feb '18

14 Feb '18

Instead of passing the full name of the Python binary as 'python', only pass the major version as 'pyver' and build everything else based on that. Doing so allows us to make a few things, most notably job names, slightly shorter and nicer. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- I wouldn't bother changing this if the previous change to Python jobs had already been deployed, but since it hasn't yet might as well have nicer names instead :) jobs/python-distutils.yaml | 22 +++++++++++----------- projects/libvirt-python.yaml | 16 ++++++++-------- projects/virt-manager.yaml | 14 +++++++------- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/jobs/python-distutils.yaml b/jobs/python-distutils.yaml index 122c759..ff68c29 100644 --- a/jobs/python-distutils.yaml +++ b/jobs/python-distutils.yaml @@ -1,11 +1,11 @@ - job-template: id: python-distutils-build-job - name: '{name}-{branch}-{python}-build' + name: '{name}-{branch}-py{pyver}-build' project-type: matrix - description: '{title} Build ({python})' + description: '{title} Build (Python {pyver})' command_pre_build: '' - workspace: '{name}-{branch}-{python}' + workspace: '{name}-{branch}-py{pyver}' child-workspace: '.' block-downstream: true block-upstream: true @@ -43,8 +43,8 @@ {global_env} {local_env} {command_pre_build} - {python} ./setup.py build - {python} ./setup.py install --prefix=$VIRT_PREFIX + python{pyver} ./setup.py build + python{pyver} ./setup.py install --prefix=$VIRT_PREFIX publishers: - email: recipients: '{obj:spam}' @@ -54,9 +54,9 @@ - job-template: id: python-distutils-check-job - name: '{name}-{branch}-{python}-check' + name: '{name}-{branch}-py{pyver}-check' project-type: matrix - description: '{title} Check ({python})' + description: '{title} Check (Python {pyver})' workspace: '{name}-{branch}' child-workspace: '.' block-downstream: true @@ -83,7 +83,7 @@ - shell: | {global_env} {local_env} - {python} ./setup.py test + python{pyver} ./setup.py test publishers: - email: recipients: '{obj:spam}' @@ -92,9 +92,9 @@ - job-template: id: python-distutils-rpm-job - name: '{name}-{branch}-{python}-rpm' + name: '{name}-{branch}-py{pyver}-rpm' project-type: matrix - description: '{title} RPM ({python})' + description: '{title} RPM (Python {pyver})' workspace: '{name}-{branch}' child-workspace: '.' block-downstream: true @@ -122,7 +122,7 @@ {global_env} {local_env} sed -i -e 's/BuildRequires: libvirt.*devel.*//' *.spec.in - {python} ./setup.py rpm + python{pyver} ./setup.py rpm publishers: - email: recipients: '{obj:spam}' diff --git a/projects/libvirt-python.yaml b/projects/libvirt-python.yaml index e065c5d..1c29321 100644 --- a/projects/libvirt-python.yaml +++ b/projects/libvirt-python.yaml @@ -14,10 +14,10 @@ title: Libvirt Python jobs: - python-distutils-build-job: - python: python2 + pyver: 2 parent_jobs: 'libvirt-master-build' - python-distutils-build-job: - python: python3 + pyver: 3 parent_jobs: 'libvirt-master-build' machines: - libvirt-debian-8 @@ -28,11 +28,11 @@ - libvirt-freebsd-10 - libvirt-freebsd-11 - python-distutils-check-job: - python: python2 - parent_jobs: 'libvirt-python-master-{python}-build' + pyver: 2 + parent_jobs: 'libvirt-python-master-py{pyver}-build' - python-distutils-check-job: - python: python3 - parent_jobs: 'libvirt-python-master-{python}-build' + pyver: 3 + parent_jobs: 'libvirt-python-master-py{pyver}-build' machines: - libvirt-debian-8 - libvirt-debian-9 @@ -42,8 +42,8 @@ - libvirt-freebsd-10 - libvirt-freebsd-11 - python-distutils-rpm-job: - python: python2 - parent_jobs: 'libvirt-python-master-{python}-check' + pyver: 2 + parent_jobs: 'libvirt-python-master-py{pyver}-check' machines: - libvirt-centos-6 - libvirt-centos-7 diff --git a/projects/virt-manager.yaml b/projects/virt-manager.yaml index b5b0df5..8f3112e 100644 --- a/projects/virt-manager.yaml +++ b/projects/virt-manager.yaml @@ -11,18 +11,18 @@ title: Virtual Machine Manager jobs: - python-distutils-build-job: - python: python3 + pyver: 3 parent_jobs: - - 'libvirt-python-master-{python}-build' + - 'libvirt-python-master-py{pyver}-build' - 'libosinfo-master-build' command_pre_build: | - {python} ./setup.py configure --prefix=$VIRT_PREFIX + python{pyver} ./setup.py configure --prefix=$VIRT_PREFIX - python-distutils-check-job: - python: python3 - parent_jobs: 'virt-manager-master-{python}-build' + pyver: 3 + parent_jobs: 'virt-manager-master-py{pyver}-build' - python-distutils-rpm-job: - python: python3 - parent_jobs: 'virt-manager-master-{python}-check' + pyver: 3 + parent_jobs: 'virt-manager-master-py{pyver}-check' machines: - libvirt-fedora-26 - libvirt-fedora-27 -- 2.14.3

2 1

[libvirt] [PATCH 0/3] Fix parsing and formatting of 'UnixSocketAddress' qapi type
by Peter Krempa 14 Feb '18

14 Feb '18

Fix the naming mistake, add tests and remove useless comment. Peter Krempa (3): storage: Fix formatting and parsing of qemu type 'UnixSocketAddress' virstoragetest: Add test case for NBD over unix socket with new syntax qemu: block: Remove misleading part of comment in qemuBlockStorageSourceBuildJSONSocketAddress src/qemu/qemu_block.c | 7 +------ src/util/virstoragefile.c | 2 +- tests/virstoragetest.c | 13 +++++++++++-- 3 files changed, 13 insertions(+), 9 deletions(-) -- 2.15.0

2 7

[libvirt] [PATCHv2 0/1] Function declarations match definitions
by Chris Venteicher 14 Feb '18

14 Feb '18

Interested in fixing mismatches between function parameter names in declarations (header files) and definitions (.c files)? This is a cosmetic / redability fix and does not change functionality. This is patch 1 of larger set of 22 patches that fix parameter names across the libvirt source code. If there is interest I can send the entire patch set. These are cosmetic redability fixes automatically generated by clang-tidy. make check and make syntax-check pass successfully after the 22 patches are applied. This is my first submission so please point out any issues and I will be glad to fix. Chris Venteicher (1): include: function parameter names same in declaration include/libvirt/libvirt-domain.h | 18 +++++++------- include/libvirt/libvirt-event.h | 4 ++-- include/libvirt/libvirt-host.h | 4 ++-- include/libvirt/libvirt-network.h | 4 ++-- include/libvirt/libvirt-nwfilter.h | 2 +- include/libvirt/libvirt-qemu.h | 2 +- include/libvirt/libvirt-secret.h | 4 ++-- include/libvirt/libvirt-storage.h | 12 +++++----- include/libvirt/libvirt-stream.h | 22 ++++++++--------- src/libvirt-domain.c | 48 +++++++++++++++++++------------------- src/libvirt-network.c | 10 ++++---- 11 files changed, 65 insertions(+), 65 deletions(-) -- 2.14.1

4 6

[libvirt] Default USB controller model vs PCI address assignment
by Daniel P. Berrangé 14 Feb '18

14 Feb '18

GCC8 identified a critical flaw in the QEMU post-parse callback They switch() based on the virDomainControllDef 'model', carefully listing every single enum case..... but no default statement. Unfortunately it is valid for "model" to have the valid "-1" which does not map to any enum constant. So the lack of any "default" statement, means when dealing with the USB controller we mistakenly fall through to the IDE controller code. The SCSI controller simililarly falls through to the virtio serial controller case. I tried just adding the obvious default case: diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index e28119e4b..3eaa22e39 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -532,6 +532,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDefPtr dev, case VIR_DOMAIN_CONTROLLER_MODEL_USB_QUSB2: /* xen only */ case VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE: case VIR_DOMAIN_CONTROLLER_MODEL_USB_LAST: + default: return 0; } @@ -553,6 +554,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDefPtr dev, return pciFlags; case VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LAST: + default: return 0; } This causes many of the QEMU test cases to fail now with a message "internal error: Cannot automatically add a new PCI bus for a device with connect flags 00" I could theoretically make the "default:" case return "pciFlags" when model == -1, but this seems dubious because it feels like it is blindly assuming that any unknown controller model is PCI based, but it would be functionally equivalent to the current behaviour where USB accidentally falls through to the IDE code. Thoughts ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

2 1

[libvirt] [PATCH v2 0/3] Fix compat with GCC8
by Daniel P. Berrangé 13 Feb '18

13 Feb '18

In this second version I enable -Wswitch-enum to strongly validate all switches cover all enum cases. Daniel P. Berrangé (3): Turn on -Wswitch-enum and fix all problems it identifies Fix more switch fallthrough identified by gcc8 Disable gcc8 -Wcast-function-type warnings from -Wextra m4/virt-compile-warnings.m4 | 9 ++++-- src/conf/domain_audit.c | 1 + src/conf/domain_conf.c | 47 +++++++++++++++++++++++++++---- src/conf/nwfilter_conf.c | 32 ++++++++++++++++++++- src/esx/esx_driver.c | 1 + src/esx/esx_vi.c | 11 +++++--- src/esx/esx_vi_types.c | 9 +++--- src/hyperv/hyperv_driver.c | 18 ++++++++++-- src/libxl/libxl_driver.c | 2 +- src/lxc/lxc_container.c | 7 +++-- src/lxc/lxc_controller.c | 10 ++++++- src/lxc/lxc_driver.c | 40 +++++++++++++++++++++++--- src/nwfilter/nwfilter_ebiptables_driver.c | 16 +++++++---- src/nwfilter/nwfilter_learnipaddr.c | 6 +++- src/qemu/qemu_command.c | 28 ++++++++++++------ src/qemu/qemu_domain.c | 35 ++++++++++++++++++----- src/qemu/qemu_domain_address.c | 11 ++++++++ src/qemu/qemu_driver.c | 27 ++++++++++++------ src/qemu/qemu_hotplug.c | 36 +++++++++++++++++++---- src/qemu/qemu_migration.c | 11 +++++++- src/qemu/qemu_process.c | 2 ++ src/rpc/virnetclient.c | 2 ++ src/rpc/virnetclientprogram.c | 1 + src/rpc/virnetserverprogram.c | 4 +++ src/security/security_driver.c | 1 + src/util/virconf.c | 13 ++++++++- src/util/virfirewall.c | 7 +++-- src/util/virlog.c | 10 ++++++- src/util/virnetdevvportprofile.c | 11 +++++++- src/vmx/vmx.c | 27 ++++++++++++++++-- src/xenconfig/xen_common.c | 17 +++++++++-- src/xenconfig/xen_xl.c | 8 +++++- tools/virt-host-validate-qemu.c | 3 +- 33 files changed, 389 insertions(+), 74 deletions(-) -- 2.16.1

1 4

[libvirt] [PATCH 0/6] Cleanups in QEMU driver wrt virConnectPtr
by Daniel P. Berrangé 13 Feb '18

13 Feb '18

There are many places we can stop passing around virConnectPtr now and directly open secondary drivers where required instead. Daniel P. Berrangé (6): conf: reimplement virDomainNetResolveActualType in terms of public API qemu: stop passing virConnectPtr into qemuMonitorStartCPUs conf: stop passing virConnectPtr into virDomainDiskTranslateSourcePool qemu: don't pass virConnectPtr around for secrets qemu: stop passing in virConnectPtr for looking up networks qemu: remove virConnectPtr from some more startup code paths src/conf/domain_conf.c | 90 +++++++++++++++++++++++++---- src/conf/domain_conf.h | 14 +---- src/network/bridge_driver.c | 76 +----------------------- src/qemu/qemu_conf.c | 3 +- src/qemu/qemu_conf.h | 3 +- src/qemu/qemu_domain.c | 111 +++++++++++++++++------------------ src/qemu/qemu_domain.h | 15 ++--- src/qemu/qemu_driver.c | 126 +++++++++++++++------------------------- src/qemu/qemu_hotplug.c | 66 +++++++++------------ src/qemu/qemu_hotplug.h | 15 ++--- src/qemu/qemu_migration.c | 18 +++--- src/qemu/qemu_monitor.c | 10 ++-- src/qemu/qemu_monitor.h | 11 +--- src/qemu/qemu_monitor_json.c | 3 +- src/qemu/qemu_monitor_json.h | 3 +- src/qemu/qemu_monitor_text.c | 9 +-- src/qemu/qemu_monitor_text.h | 3 +- src/qemu/qemu_process.c | 134 +++++++++++++++++-------------------------- src/qemu/qemu_process.h | 12 ++-- tests/qemuhotplugtest.c | 4 +- tests/qemumonitorjsontest.c | 2 +- 21 files changed, 298 insertions(+), 430 deletions(-) -- 2.14.3

2 12