- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] rpc: fix memleak
by Nikolay Shirokovskiy 26 Feb '18

26 Feb '18

Nikolay Shirokovskiy (2): daemon: fix rpc event leak on error path in remoteDispatchObjectEventSend lxc: fix rpc event leak on error path in virLXCControllerEventSend src/lxc/lxc_controller.c | 3 ++- src/remote/remote_daemon_dispatch.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) -- 1.8.3.1

2 4

[libvirt] [RFC] libvirt hexagon sticker design
by Erik Skultety 26 Feb '18

26 Feb '18

Hi folks, those who attended at least one conference for the past year have probably noticed the rising trend (more like "sticker hype") of FOSS projects giving away these hexagon stickers, it's very inexpensive way of making some promo for their project and since we don't do many promos (AFAIK none to be precise) I guess as a project that's been going strong for 12 years already we should probably start somewhere, even baby steps count (as it turns out in this case - - literally...). So, I've taken our libvirt-publican repo and came up with a few various color combinations for libvirt hexagon sticker design. Below you can find links to my personal google drive (these are hexagon meshes, I can, or anyone can for that matter, isolate individual designs and send them as separate patches on demand), since each of the SVGs is over 1.5MB and I'd easily run into message size limits for the mailing list, had I gone with sending these as patches against libvirt-publican. Lastly, I just want to point out, if it's not obvious, that the last design was meant as a joke (apparently I had a bit too much fun spending time on this) reflecting what's becoming "the new black" in "sticker design world" - emphasis on simplification while retaining its expressiveness and unambiguity (yeah, right...) - but I'm not going to point the finger, but there's a heptagon involved ;). Cheers, Erik [1] https://drive.google.com/open?id=1xhn0GLvCKMcEOUnqn6boghaUOgjA8sOG [2] https://drive.google.com/open?id=1b2MUyv0eo723F2rorWnmv1sTeCycUCN4 [joke] https://drive.google.com/open?id=1SBjJn2eptXFQVPuEMxzGY8CX6TFX1IzP [3] https://github.com/terinjokes/StickerConstructorSpec PS: the last link is the specification I used for the design PS-2: if someone would like to point out that the joke proposal is missing a few color combination, it was on purpose...

7 19

[libvirt] [PATCH for release 0/3] Fix broken migration
by Michal Privoznik 26 Feb '18

26 Feb '18

Currently, we are unable to migrate ANY domain. These should get in before the release. Okay, the first one is not that crucial. The last one is! Michal Privoznik (3): qemuMigrationSrcIsSafe: Check local storage more thoroughly qemuProcessLaunch: Print all arguments to debug qemu: Add virConnectPtr back to some migration methods src/qemu/qemu_driver.c | 12 ++++++------ src/qemu/qemu_migration.c | 45 ++++++++++++++++++++++++++++----------------- src/qemu/qemu_migration.h | 2 ++ src/qemu/qemu_process.c | 4 ++-- 4 files changed, 38 insertions(+), 25 deletions(-) -- 2.16.1

2 6

[libvirt] [PATCH 0/2] vz: build fixes
by Nikolay Shirokovskiy 26 Feb '18

26 Feb '18

Build is broken only in not yet released 4.1. Nikolay Shirokovskiy (2): vz: build fix after excluding cross driver headers vz: build fix: handle missing switch enum cases src/vz/vz_sdk.c | 17 +++++++++-------- src/vz/vz_utils.c | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) -- 1.8.3.1

2 3

[libvirt] [PATCH] util: xml: Don't conflict with other libxml2 user callbacks
by Cole Robinson 26 Feb '18

26 Feb '18

lxml is a popular python XML processing library. It uses libxml2 behind the scenes, and registers custom callbacks via xmlSetExternalEntityLoader. However this can cause crashes if if an app uses both lxml and libxml2 together in the same process. This is a known limitation of lxml and libxml2 generally. It also prevents us from using lxml in virt-manager: https://bugzilla.redhat.com/show_bug.cgi?id=1544019 However it's easy enough to work around in libvirt, by unsetting the EntityLoader callback to a known state before we ask libxml2 to parse a file from disk. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/util/virxml.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/util/virxml.c b/src/util/virxml.c index 6e87605ea..3e01794f9 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -810,9 +810,14 @@ virXMLParseHelper(int domcode, pctxt->sax->error = catchXMLError; if (filename) { + /* Reset any libxml2 file callbacks, other libs (like python lxml) + * may have set their own which can get crashy */ + xmlExternalEntityLoader origloader = xmlGetExternalEntityLoader(); + xmlSetExternalEntityLoader(xmlNoNetExternalEntityLoader); xml = xmlCtxtReadFile(pctxt, filename, NULL, XML_PARSE_NONET | XML_PARSE_NOWARNING); + xmlSetExternalEntityLoader(origloader); } else { xml = xmlCtxtReadDoc(pctxt, BAD_CAST xmlStr, url, NULL, XML_PARSE_NONET | -- 2.14.3

3 2

[libvirt] [PATCH 00/16] some more vboxDump cleanups
by Ján Tomko 23 Feb '18

23 Feb '18

Inspired-by: Laine Stump <laine(a)laine.org> Day-of-the-week: Friday <6> Ján Tomko (16): vboxDumpSharedFolders: rename non-standard label vboxDumpSharedFolders: remove pointless comment vboxDumpSharedFolders: return a value vboxDumpNetwork: add temp variable for current network vboxDumpNetwork: rename to vboxDumpNetworks vboxDumpNetwork: re-introduce this function vboxDumpNetworks: reduce indentation level vboxDumpNetwork: allocate the network too vboxDumpNetworks: delete pointless comment vboxDumpNetworks: do not allocate def->nets upfront vboxDumpNetwork: use virMacAddrParseHex vboxDumpNetwork: Use a single utf16 variable vboxDumpNetwork: Use a single utf8 temp variable vboxDumpNetwork: use a switch for attachmentType vboxDumpNetwork: use VIR_STEAL_PTR instead of VIR_STRDUP vboxDumpNetwork: use switch for adapterType src/vbox/vbox_common.c | 243 ++++++++++++++++++++++++------------------------- 1 file changed, 120 insertions(+), 123 deletions(-) -- 2.13.6

2 17

[libvirt] [PATCH jenkins-ci] Fix workspace for python check/rpm jobs
by Daniel P. Berrangé 23 Feb '18

23 Feb '18

The check/rpm jobs were using a different workspace to the build job, so never saw the correct content. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix for virt-manager CI jobs/python-distutils.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jobs/python-distutils.yaml b/jobs/python-distutils.yaml index 510769e..16eca1c 100644 --- a/jobs/python-distutils.yaml +++ b/jobs/python-distutils.yaml @@ -58,7 +58,7 @@ name: '{name}-{branch}-py{pyver}-check' project-type: matrix description: '{title} Check (Python {pyver})' - workspace: '{name}-{branch}' + workspace: '{name}-{branch}-py{pyver}' child-workspace: '.' block-downstream: true block-upstream: true @@ -97,7 +97,7 @@ name: '{name}-{branch}-py{pyver}-rpm' project-type: matrix description: '{title} RPM (Python {pyver})' - workspace: '{name}-{branch}' + workspace: '{name}-{branch}-py{pyver}' child-workspace: '.' block-downstream: true block-upstream: true -- 2.14.3

1 0

[libvirt] [PATCH] tools: avoid text spilling into variables
by Dariusz Gadomski 23 Feb '18

23 Feb '18

From: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> While libvirt-guests.sh is running cases can let guest_is_on fail which causes check_guests_shutdown to print output. That output shall not spill into the users of function check_guests_shutdown which is therefore now returning values in a variable like guest_is_on already did. Original-Author: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> Modified-By: Jorge Niedbalski <niedbalski(a)ubuntu.com> --- tools/libvirt-guests.sh.in | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 8a158cca4..91a2f3283 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -329,12 +329,13 @@ guest_count() # check_guests_shutdown URI GUESTS # check if shutdown is complete on guests in "GUESTS" and returns only # guests that are still shutting down +# Result is returned in "guests_shutting_down" check_guests_shutdown() { uri=$1 guests=$2 - guests_up= + guests_shutting_down= for guest in $guests; do if ! guest_is_on "$uri" "$guest" >/dev/null 2>&1; then eval_gettext "Failed to determine state of guest: \$guest. Not tracking it anymore." @@ -342,10 +343,9 @@ check_guests_shutdown() continue fi if "$guest_running"; then - guests_up="$guests_up $guest" + guests_shutting_down="$guests_shutting_down $guest" fi done - echo "$guests_up" } # print_guests_shutdown URI BEFORE AFTER @@ -392,8 +392,10 @@ shutdown_guests_parallel() guest=$1 shift guests=$* - shutdown_guest_async "$uri" "$guest" - on_shutdown="$on_shutdown $guest" + if [ -z "$(echo $on_shutdown | grep $guest)" -a -n "$(guest_name "$uri" "$guest")" ]; then + shutdown_guest_async "$uri" "$guest" + on_shutdown="$on_shutdown $guest" + fi done sleep 1 @@ -420,7 +422,8 @@ shutdown_guests_parallel() fi on_shutdown_prev=$on_shutdown - on_shutdown=$(check_guests_shutdown "$uri" "$on_shutdown") + check_guests_shutdown "$uri" "$on_shutdown" + on_shutdown="$guests_shutting_down" print_guests_shutdown "$uri" "$on_shutdown_prev" "$on_shutdown" done } -- 2.14.1

2 1

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: virt-manager-master-py3-check » libvirt-debian-9 #14
by Cole Robinson 23 Feb '18

23 Feb '18

I'm confused why this is still failing. I set up a debian9 vm, reproduced the issue which fails about 50% of the time, and verified that commit 059fb7d0ba1d414db3db485903972b48c1dda629 fixes it completely, or at least I can't reproduce. But this is still failing. Weirdly though On 02/22/2018 04:18 PM, ci(a)centos.org wrote: > See <https://ci.centos.org/job/virt-manager-master-py3-check/systems=libvirt-deb…> > > ------------------------------------------ > Started by upstream project "virt-manager-master-py3-check" build number 14 > originally caused by: > Started by upstream project "virt-manager-master-py3-build" build number 14 > originally caused by: > Started by an SCM change > [EnvInject] - Loading node environment variables. > Building remotely on libvirt-debian-9 (libvirt) in workspace <https://ci.centos.org/job/virt-manager-master-py3-check/systems=libvirt-deb…> > [virt-manager-master] $ /bin/sh -xe /tmp/jenkins3940620727838286920.sh > + MAKE=make > + uname > + unamestr=Linux > + [ Linux = FreeBSD ] > + export PATH=/home/jenkins/build/libvirt/bin:/home/jenkins/build/libvirt/bin:/home/jenkins/build/libvirt/bin:/home/jenkins/build/libvirt/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games > + export PYTHONPATH=/home/jenkins/build/libvirt/lib/python3.4/site-packages:/home/jenkins/build/libvirt/lib64/python3.4/site-packages:/home/jenkins/build/libvirt/lib/python3.5/site-packages:/home/jenkins/build/libvirt/lib64/python3.5/site-packages:/home/jenkins/build/libvirt/lib/python3.6/site-packages:/home/jenkins/build/libvirt/lib64/python3.6/site-packages:/home/jenkins/build/libvirt/lib/python3.7/site-packages:/home/jenkins/build/libvirt/lib64/python3.7/site-packages > + python3 ./setup.py test > running test > ..............................................................................................................................F...............................................................................................................................................s........................................................................................................................................................................ > ====================================================================== > FAIL: testCLI0002virt_install_singleton_config_2 (tests.clitest.CLITests) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "<https://ci.centos.org/job/virt-manager-master-py3-check/systems=libvirt-deb…",> line 1110, in <lambda> > return lambda s: cmdtemplate(s, cmd) > File "<https://ci.centos.org/job/virt-manager-master-py3-check/systems=libvirt-deb…",> line 1109, in cmdtemplate > _cmdobj.run(self) > File "<https://ci.centos.org/job/virt-manager-master-py3-check/systems=libvirt-deb…",> line 277, in run > tests.fail(err) These line numbers don't match up with the line numbers in virt-manager git master. Is there some chance it's using old code? it certainly seems to be detecting new commits coming in which trigger builds, but I thing something weird is going on here - Cole

2 1

[libvirt] [PATCH] make: fix VPATH install of upstart files
by Daniel P. Berrangé 23 Feb '18

23 Feb '18

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix src/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index a7f03319c1..cb30c50f14 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -3181,7 +3181,8 @@ install-upstart: install-sysconfig for f in $(UPSTART_FILES:%.upstart=%); \ do \ tgt=`basename $$f` ; \ - $(INSTALL_SCRIPT) $$f.upstart $(DESTDIR)$(sysconfdir)/event.d/$$tgt ; \ + $(INSTALL_SCRIPT) $(srcdir)/$$f.upstart \ + $(DESTDIR)$(sysconfdir)/event.d/$$tgt ; \ done uninstall-upstart: uninstall-sysconfig -- 2.14.3

1 0