- Devel - libvirt List Archives

[libvirt] [PATCH] util: fix spelling in virSocketAddrParseAny docs
by Jim Fehlig 05 Apr '18

05 Apr '18

s/netork/network/ Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- Pushing as trivial. src/util/virsocketaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 4f2457629..5c3bfad0a 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -176,7 +176,7 @@ int virSocketAddrParse(virSocketAddrPtr addr, const char *val, int family) * or 2001:db8:85a3:0:0:8a2e:370:7334. * * When @val is a network host name, this function may be susceptible to a - * delay due to potentially lengthy netork host address lookups. + * delay due to potentially lengthy network host address lookups. * * Returns the length of the network address or -1 in case of error. */ -- 2.16.2

1 0

[libvirt] anyone ever seen virDomainCreateWithFlags() essentially hang?
by Chris Friesen 05 Apr '18

05 Apr '18

I'm investigating something weird with libvirt 1.2.17 and qemu 2.3.0. I'm using the python bindings, and I seem to have a case where libvirtmod.virDomainCreateWithFlags() hung rather than returned. Then, about 15min later a subsequent call to libvirtmod.virDomainDestroy() from a different eventlet within the same process seems to have "unblocked" the original creation call, which raised an exception and an error code of libvirt.VIR_ERR_INTERNAL_ERROR. The virDomainDestroy() call came back with an error of "Requested operation is not valid: domain is not running". The corresponding qemu logs show the guest starting up and then a bit over 15min later there is a "shutting down" log. At shutdown time the libvirtd log shows "qemuMonitorIORead:609 : Unable to read from monitor: Connection reset by peer". The parent function did two additional retries, and both the retries failed in similar fashion. In all three caess there seems to be a pattern of the qemu instance starting up but virDomainCreateWithFlags() not returning, then a subsequent virDomainDestroy() call for the same domain causing the virDomainCreateWithFlags() call to get "unblocked" and return -1 leading to an exception in the python code. Any ideas what might cause this behaviour? I haven't reproduced the "hanging" behaviour myself, I'm working entirely off of logs from the affected system. Thanks, Chris

2 2

[libvirt] Run libvirtd from git: virsh hangs
by Mathieu Tarral 05 Apr '18

05 Apr '18

Hi, I managed to compile libvirt from the git repo, now i have some trouble to run it. This is what i did: I configured the source to use /var because i wanted the socket to be at the same place as the system one (/var/run/libvirt/libvirt-sock) ./configure --prefix=$HOME/usr --localstatedir=/var make make install at this point i stopped my system libvirtd and virtlogd sudo systemctl stop libvirtd sudo systemctl stop virtlogd And then i launched my custom libvirtd and virtlogd cd $HOME/usr/sbin sudo ./libvirtd -v sudo ./virtlogd -v After that i tried to list the available domains with virsh (using the system binary) sudo virsh virsh # list --all And this call hangs forever. There is no more output in libvirtd stdout/stderr, even if i set log_level to 1. Did i miss anything in the configuration ? Thanks guys ! -- Mathieu Tarral

3 4

[libvirt] [PATCH v4 0/3] Improve handling of multipath devices
by Michal Privoznik 05 Apr '18

05 Apr '18

The saga continues. v3: https://www.redhat.com/archives/libvir-list/2018-April/msg00083.html diff to v3: - hopefully all Peter's review comments are worked in now. Michal Privoznik (3): util: Introduce virDevMapperGetTargets qemu_cgroup: Handle device mapper targets properly news: Document device mapper fix docs/news.xml | 12 +++ libvirt.spec.in | 2 + src/libvirt_private.syms | 4 + src/qemu/qemu_cgroup.c | 46 ++++++++++- src/util/Makefile.inc.am | 2 + src/util/virdevmapper.c | 199 +++++++++++++++++++++++++++++++++++++++++++++++ src/util/virdevmapper.h | 31 ++++++++ 7 files changed, 293 insertions(+), 3 deletions(-) create mode 100644 src/util/virdevmapper.c create mode 100644 src/util/virdevmapper.h -- 2.16.1

2 7

[libvirt] [dbus PATCH] test: Don't hardcode python3 path
by Andrea Bolognani 05 Apr '18

05 Apr '18

Using /usr/bin/python3 is fine for Linux, but it's not portable to other operating systems such as FreeBSD, where the binary lives under /usr/local/bin instead. Use /usr/bin/env to abstract the issue away. With this, 'make check' completes successfully on FreeBSD 10, 11 and -CURRENT. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- test/test_connect.py | 2 +- test/test_domain.py | 2 +- test/test_network.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_connect.py b/test/test_connect.py index 440a496..d972561 100755 --- a/test/test_connect.py +++ b/test/test_connect.py @@ -1,4 +1,4 @@ -#!/usr/bin/python3 +#!/usr/bin/env python3 import dbus import libvirttest diff --git a/test/test_domain.py b/test/test_domain.py index d36adf7..7ec2318 100755 --- a/test/test_domain.py +++ b/test/test_domain.py @@ -1,4 +1,4 @@ -#!/usr/bin/python3 +#!/usr/bin/env python3 import dbus import libvirttest diff --git a/test/test_network.py b/test/test_network.py index 97ab0aa..5178862 100755 --- a/test/test_network.py +++ b/test/test_network.py @@ -1,4 +1,4 @@ -#!/usr/bin/python3 +#!/usr/bin/env python3 import dbus import libvirttest -- 2.14.3

2 1

[libvirt] [dbus PATCH 00/10] Impement some APIs for network Interface
by Katerina Koukiou 05 Apr '18

05 Apr '18

Katerina Koukiou (10): Implement BridgeName property for Network interface. Implement Autostart property for Network Interface Implement UUID property for Network interface. Implement NetworkLookupByUUID method for network interface. Rename virtDBusEventsRegisterEvent to virtDBusDomainEventsRegisterEvent Rename callback_ids variable to domain_callback_ids Register Network Lifecycle Events Implement Destroy method for Network Interface. Implement Undefine method for Network Interface Implement Create method for Network Interface data/org.libvirt.Connect.xml | 12 ++++ data/org.libvirt.Network.xml | 24 ++++++++ src/connect.c | 50 +++++++++++++++-- src/connect.h | 3 +- src/events.c | 112 ++++++++++++++++++++++++++++--------- src/network.c | 128 +++++++++++++++++++++++++++++++++++++++++++ test/test_connect.py | 1 + test/test_network.py | 43 +++++++++++++++ 8 files changed, 342 insertions(+), 31 deletions(-) -- 2.15.0

2 21

[libvirt] [PATCH] qemu: use target.port for isa-serial
by Thilo Cestonaro 05 Apr '18

05 Apr '18

A configured target.port is currently totaly ignored, while contsructing qemu commandline, for all types of serial devices. This patch adds a -device parameter "index" for the target model isa-serial. This enables the user to specify which serial device will end in which ttySX device. --- src/qemu/qemu_command.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index bbd3cd0a7..a685abec0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10290,6 +10290,22 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, virDomainChrSerialTargetModelTypeToString(serial->targetModel), serial->info.alias, serial->info.alias); + switch ((virDomainChrSerialTargetModel) serial->targetModel) { + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_ISA_SERIAL: + if (serial->target.port != -1) + virBufferAsprintf(&cmd, ",index=%d", serial->target.port); + break; + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_NONE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_USB_SERIAL: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_PCI_SERIAL: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SPAPR_VTY: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_PL011: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SCLPCONSOLE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_SCLPLMCONSOLE: + case VIR_DOMAIN_CHR_SERIAL_TARGET_MODEL_LAST: + break; + } + if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0) goto error; -- 2.15.1

1 0

[libvirt] [PATCH] qemu: cpu: fix fullCPU to include all emulatable qemu features
by Nikolay Shirokovskiy 05 Apr '18

05 Apr '18

On Core i5 650 guest fail to start with error [1] if guest cpu config is taken from domcapabilities and check is set to partial. The problem is in qemu caps fullCPU calculation in virQEMUCapsInitHostCPUModel. It is supposed to include features emulated by qemu and missed on host. Some of such features may be not included however. For mentioned cpu host cpu is detected as Westmere and guest cpu as SandyBridge. x2apic is missed on host and provided by installed qemu. The feature is not mentioned in guest cpu features explicitly because SandyBridge model include it. As a result fullCPU does not include x2apic too. Solution is to expand guest cpu features before updating fullCPU features. [1] error: the CPU is incompatible with host CPU: Host CPU does not provide required features: x2apic, tsc-deadline --- src/qemu/qemu_capabilities.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 9c1eeac..edba716 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3475,6 +3475,7 @@ virQEMUCapsInitHostCPUModel(virQEMUCapsPtr qemuCaps, virDomainVirtType type) { virCPUDefPtr cpu = NULL; + virCPUDefPtr cpuExpanded = NULL; virCPUDefPtr migCPU = NULL; virCPUDefPtr hostCPU = NULL; virCPUDefPtr fullCPU = NULL; @@ -3504,9 +3505,13 @@ virQEMUCapsInitHostCPUModel(virQEMUCapsPtr qemuCaps, NULL, NULL))) goto error; - for (i = 0; i < cpu->nfeatures; i++) { - if (cpu->features[i].policy == VIR_CPU_FEATURE_REQUIRE && - virCPUDefUpdateFeature(fullCPU, cpu->features[i].name, + if (!(cpuExpanded = virCPUDefCopy(cpu)) || + virCPUExpandFeatures(qemuCaps->arch, cpuExpanded) < 0) + goto error; + + for (i = 0; i < cpuExpanded->nfeatures; i++) { + if (cpuExpanded->features[i].policy == VIR_CPU_FEATURE_REQUIRE && + virCPUDefUpdateFeature(fullCPU, cpuExpanded->features[i].name, VIR_CPU_FEATURE_REQUIRE) < 0) goto error; } @@ -3528,6 +3533,7 @@ virQEMUCapsInitHostCPUModel(virQEMUCapsPtr qemuCaps, virQEMUCapsSetHostModel(qemuCaps, type, cpu, migCPU, fullCPU); cleanup: + virCPUDefFree(cpuExpanded); virCPUDefFree(hostCPU); return; -- 1.8.3.1

2 3

[libvirt] Libvirt master compilation failed
by Mathieu Tarral 05 Apr '18

05 Apr '18

Hello, i have been trying to compile the latest libvirt from the Github mirror. I checked out on this commit: 3487973ee0c730b6fbfc6183af798c46ae3b85ff virjsontest: Use a more stable floating point number for testing But the compilation failed with this error: CC ssh.o CCLD ssh CC qemucapsprobe.o CCLD qemucapsprobe CC nsslinktest-nsslinktest.o CCLD nsslinktest CC nssguestlinktest-nsslinktest.o CCLD nssguestlinktest make[2]: Leaving directory '/var/ansible/libvirt/tests' Making all in po make[2]: Entering directory '/var/ansible/libvirt/po' test ! -f ./libvirt.pot || \ test -z "af.gmo am.gmo anp.gmo ar.gmo as.gmo ast.gmo bal.gmo be.gmo bg.gmo bn.gmo bn_IN.gmo bo.gmo br.gmo brx.gmo bs.gmo ca.gmo cs.gmo cy.gmo da.gmo de.gmo de_CH.gmo el.gmo en_GB.gmo eo.gmo es.gmo et.gmo eu.gmo fa.gmo fi.gmo fr.gmo gl.gmo gu.gmo he.gmo hi.gmo hr.gmo hu.gmo ia.gmo id.gmo ilo.gmo is.gmo it.gmo ja.gmo ka.gmo kk.gmo km.gmo kn.gmo ko.gmo kw.gmo kw(a)kkcor.gmo kw(a)uccor.gmo kw_GB.gmo ky.gmo lt.gmo lv.gmo mai.gmo mk.gmo ml.gmo mn.gmo mr.gmo ms.gmo nb.gmo nds.gmo ne.gmo nl.gmo nn.gmo nso.gmo or.gmo pa.gmo pl.gmo pt.gmo pt_BR.gmo ro.gmo ru.gmo si.gmo sk.gmo sl.gmo sq.gmo sr.gmo sr(a)latin.gmo sv.gmo ta.gmo te.gmo tg.gmo th.gmo tr.gmo tw.gmo uk.gmo ur.gmo vi.gmo wba.gmo yo.gmo zh_CN.gmo zh_HK.gmo zh_TW.gmo zu.gmo" || make af.gmo am.gmo anp.gmo ar.gmo as.gmo ast.gmo bal.gmo be.gmo bg.gmo bn.gmo bn_IN.gmo bo.gmo br.gmo brx.gmo bs.gmo ca.gmo cs.gmo cy.gmo da.gmo de.gmo de_CH.gmo el.gmo en_GB.gmo eo.gmo es.gmo et.gmo eu.gmo fa.gmo fi.gmo fr.gmo gl.gmo gu.gmo he.gmo hi.gmo hr.gmo hu.gmo ia.gmo id.gmo ilo.gmo is.gmo it.gmo ja.gmo ka.gmo kk.gmo km.gmo kn.gmo ko.gmo kw.gmo kw(a)kkcor.gmo kw(a)uccor.gmo kw_GB.gmo ky.gmo lt.gmo lv.gmo mai.gmo mk.gmo ml.gmo mn.gmo mr.gmo ms.gmo nb.gmo nds.gmo ne.gmo nl.gmo nn.gmo nso.gmo or.gmo pa.gmo pl.gmo pt.gmo pt_BR.gmo ro.gmo ru.gmo si.gmo sk.gmo sl.gmo sq.gmo sr.gmo sr(a)latin.gmo sv.gmo ta.gmo te.gmo tg.gmo th.gmo tr.gmo tw.gmo uk.gmo ur.gmo vi.gmo wba.gmo yo.gmo zh_CN.gmo zh_HK.gmo zh_TW.gmo zu.gmo make[3]: Entering directory '/var/ansible/libvirt/po' rm -f af.gmo && : -c --statistics -o af.gmo af.po mv: cannot stat 't-af.gmo': No such file or directory Makefile:470: recipe for target 'af.gmo' failed make[3]: *** [af.gmo] Error 1 make[3]: Leaving directory '/var/ansible/libvirt/po' Makefile:507: recipe for target 'stamp-po' failed make[2]: *** [stamp-po] Error 2 make[2]: Leaving directory '/var/ansible/libvirt/po' Makefile:2121: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/var/ansible/libvirt' Makefile:2014: recipe for target 'all' failed make: *** [all] Error 2 I'm on Debian stretch, i installed every dependency required by the configure script. Any ideas what's wrong here ? Thanks. -- Mathieu Tarral

2 2

[libvirt] [PATCH v2 0/8] Prepare for daemon split
by Daniel P. Berrangé 05 Apr '18

05 Apr '18

When we split up the daemons, libvirtd will need to forward different sets of APIs to different daemons. This means libvirtd is going to need to have multiple virConnectPtr instances open. This series prepares for that by introducing "separate" connections, which are actually just an extra reference on the current single connection. This will facilitate later changes. Daniel P. Berrangé (8): rpc: refactor way connection object is generated for remote dispatch remote: push check for conn down into remoteClientFreePrivateCallbacks remote: use a separate connection for interface APIs remote: use a separate connection for network APIs remote: use a separate connection for nodedev APIs remote: use a separate connection for nwfilter APIs remote: use a separate connection for secret APIs remote: use a separate connection for storage APIs src/remote/remote_daemon.h | 6 +++ src/remote/remote_daemon_dispatch.c | 94 +++++++++++++++++++------------- src/rpc/gendispatch.pl | 104 +++++++++++++++++++++++++----------- 3 files changed, 138 insertions(+), 66 deletions(-) -- 2.14.3

2 9