- Devel - libvirt List Archives

[libvirt] [PATCH] tests: Fix incorrect check for virNetServerClientClose call
by John Ferlan 19 Apr '18

19 Apr '18

Commit id '6df5d777' somehow during the move from one branch to another added an erroneous '!'... Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushing under the trivial rule. Not quite sure how a git am from my Coverity tree added the not in the condition. tests/virnetserverclienttest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virnetserverclienttest.c b/tests/virnetserverclienttest.c index aa3f0bcf9b..1759d76630 100644 --- a/tests/virnetserverclienttest.c +++ b/tests/virnetserverclienttest.c @@ -152,7 +152,7 @@ static int testIdentity(const void *opaque ATTRIBUTE_UNUSED) ret = 0; cleanup: virObjectUnref(sock); - if (!client) + if (client) virNetServerClientClose(client); virObjectUnref(client); virObjectUnref(ident); -- 2.13.6

1 0

[libvirt] [PATCH 0/3] query-cpu-model-baseline QMP command
by Chris Venteicher 19 Apr '18

19 Apr '18

Implementation of libvirt functions to support the QEMU query-cpu-model-baseline QMP command. This is part of resolution of: https://bugzilla.redhat.com/show_bug.cgi?id=1511999 Signed-off-by: Chris Venteicher <cventeic(a)redhat.com> Chris Venteicher (3): qemu_monitor_json: Populate CPUModelInfo struct from json qemu_monitor_json: Build Json CPU Model Info qemu_monitor: query-cpu-model-baseline QMP command src/qemu/qemu_monitor.c | 16 ++++ src/qemu/qemu_monitor.h | 5 ++ src/qemu/qemu_monitor_json.c | 179 +++++++++++++++++++++++++++++++++++++------ src/qemu/qemu_monitor_json.h | 7 ++ 4 files changed, 185 insertions(+), 22 deletions(-) -- 2.14.1

4 12

[libvirt] [PATCH v2 0/2] Don't choke on valid NUMA nodesets on daemon restart
by Andrea Bolognani 19 Apr '18

19 Apr '18

Changes from [v1]: * make sure the tests pass even when compiling --without-qemu; * actually run syntax-check before sending out patches. [v1] https://www.redhat.com/archives/libvir-list/2018-April/msg00937.html Andrea Bolognani (2): tests: Create full host NUMA topology in more cases qemu: Figure out nodeset bitmap size correctly src/qemu/qemu_domain.c | 10 ++++- tests/qemustatusxml2xmldata/modern-in.xml | 2 +- tests/testutils.c | 51 ++++++++++++++++++++++++ tests/testutils.h | 2 + tests/testutilsqemu.c | 7 +++- tests/vircapstest.c | 66 +++---------------------------- 6 files changed, 74 insertions(+), 64 deletions(-) -- 2.14.3

2 4

[libvirt] [PATCH python] Fix build with older libvirt versions
by Daniel P. Berrangé 19 Apr '18

19 Apr '18

The libvirt python module is supposed to build with historical versions of the API back to 0.9.1, which means all constants / methods must be commit 314b2346df2d8e2d7d705b003c693b4fa0189bdf Author: Edgar Kaziakhmedov <edgar.kaziakhmedov(a)virtuozzo.com> Date: Wed Feb 7 17:49:30 2018 +0300 Set hints for virPyDictToTypedParams Predefine hints for all parameters possible to avoid wrong type convert. This broke the build against any libvirt < 2.0.0 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt-override.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 580c259..b4c1529 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -7740,22 +7740,54 @@ libvirt_virDomainMigrateGetMaxDowntime(PyObject *self ATTRIBUTE_UNUSED, #if LIBVIR_CHECK_VERSION(1, 1, 0) static virPyTypedParamsHint virPyDomainMigrate3Params[] = { +# ifdef VIR_MIGRATE_PARAM_URI { VIR_MIGRATE_PARAM_URI, VIR_TYPED_PARAM_STRING }, +# endif +# ifdef VIR_MIGRATE_PARAM_DEST_NAME { VIR_MIGRATE_PARAM_DEST_NAME, VIR_TYPED_PARAM_STRING }, +# endif +# ifdef VIR_MIGRATE_PARAM_DEST_XML { VIR_MIGRATE_PARAM_DEST_XML, VIR_TYPED_PARAM_STRING }, +# endif +# ifdef VIR_MIGRATE_PARAM_PERSIST_XML { VIR_MIGRATE_PARAM_PERSIST_XML, VIR_TYPED_PARAM_STRING }, +# endif +# ifdef VIR_MIGRATE_PARAM_BANDWIDTH { VIR_MIGRATE_PARAM_BANDWIDTH, VIR_TYPED_PARAM_ULLONG }, +# endif +# ifdef VIR_MIGRATE_PARAM_GRAPHICS_URI { VIR_MIGRATE_PARAM_GRAPHICS_URI, VIR_TYPED_PARAM_STRING }, +# endif +# ifdef VIR_MIGRATE_PARAM_LISTEN_ADDRESS { VIR_MIGRATE_PARAM_LISTEN_ADDRESS, VIR_TYPED_PARAM_STRING }, +# endif +# ifdef VIR_MIGRATE_PARAM_MIGRATE_DISKS { VIR_MIGRATE_PARAM_MIGRATE_DISKS, VIR_TYPED_PARAM_STRING }, +# endif +# ifdef VIR_MIGRATE_PARAM_DISKS_PORT { VIR_MIGRATE_PARAM_DISKS_PORT, VIR_TYPED_PARAM_INT }, +# endif +# ifdef VIR_MIGRATE_PARAM_COMPRESSION { VIR_MIGRATE_PARAM_COMPRESSION, VIR_TYPED_PARAM_STRING }, +# endif +# ifdef VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL { VIR_MIGRATE_PARAM_COMPRESSION_MT_LEVEL, VIR_TYPED_PARAM_INT }, +# endif +# ifdef VIR_MIGRATE_PARAM_COMPRESSION_MT_THREADS { VIR_MIGRATE_PARAM_COMPRESSION_MT_THREADS, VIR_TYPED_PARAM_INT }, +# endif +# ifdef VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS { VIR_MIGRATE_PARAM_COMPRESSION_MT_DTHREADS, VIR_TYPED_PARAM_INT }, +# endif +# ifdef VIR_MIGRATE_PARAM_COMPRESSION_XBZRLE_CACHE { VIR_MIGRATE_PARAM_COMPRESSION_XBZRLE_CACHE, VIR_TYPED_PARAM_ULLONG }, +# endif +# ifdef VIR_MIGRATE_PARAM_AUTO_CONVERGE_INITIAL { VIR_MIGRATE_PARAM_AUTO_CONVERGE_INITIAL, VIR_TYPED_PARAM_INT }, +# endif +# ifdef VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT { VIR_MIGRATE_PARAM_AUTO_CONVERGE_INCREMENT, VIR_TYPED_PARAM_INT }, +# endif }; -- 2.14.3

2 2

[libvirt] [PATCH v2] qemuDomainObjPrivateDataClear: Don't leak @migParams
by Michal Privoznik 19 Apr '18

19 Apr '18

Allocated in qemuMigrationParamsNew() we need to free priv->job.migParams when no longer needed. ==8061== 234 (192 direct, 42 indirect) bytes in 1 blocks are definitely lost in loss record 112 of 123 ==8061== at 0x4C2CF26: calloc (vg_replace_malloc.c:711) ==8061== by 0x5325D05: virAlloc (viralloc.c:144) ==8061== by 0x1984F9: qemuMigrationParamsNew (qemu_migration_params.c:218) ==8061== by 0x19A352: qemuMigrationParamsParse (qemu_migration_params.c:1185) ==8061== by 0x1604D8: qemuDomainObjPrivateXMLParseJob (qemu_domain.c:2390) ==8061== by 0x160AE9: qemuDomainObjPrivateXMLParse (qemu_domain.c:2517) ==8061== by 0x5419EAE: virDomainObjParseXML (domain_conf.c:20442) ==8061== by 0x541A25E: virDomainObjParseNode (domain_conf.c:20555) ==8061== by 0x541A2FC: virDomainObjParseFile (domain_conf.c:20574) ==8061== by 0x13607D: testCompareStatusXMLToXMLFiles (qemuxml2xmltest.c:75) ==8061== by 0x14F3E8: virTestRun (testutils.c:180) ==8061== by 0x14DCD0: mymain (qemuxml2xmltest.c:1200) Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index e2a8450e2e..027321e1d4 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1895,6 +1895,8 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivatePtr priv) virBitmapFree(priv->migrationCaps); priv->migrationCaps = NULL; + + qemuMigrationParamsFree(priv->job.migParams); } -- 2.16.1

2 3

[libvirt] [PATCH 0/2] Don't choke on valid NUMA nodesets on daemon restart
by Andrea Bolognani 19 Apr '18

19 Apr '18

Details in the commit message for 2/2 and the bug report referenced therein. Andrea Bolognani (2): tests: Create full host NUMA topology by default qemu: Figure out nodeset bitmap size correctly src/qemu/qemu_domain.c | 11 +++++- tests/qemustatusxml2xmldata/modern-in.xml | 2 +- tests/testutilsqemu.c | 57 +++++++++++++++++++++++++++- tests/vircapstest.c | 62 +------------------------------ 4 files changed, 68 insertions(+), 64 deletions(-) -- 2.14.3

2 8

[libvirt] [dbus PATCH] Fix memory leaks introduced by commits 40dc3b and 408a25
by Katerina Koukiou 19 Apr '18

19 Apr '18

Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com> --- src/domain.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/domain.c b/src/domain.c index 6c44377..ae1b68f 100644 --- a/src/domain.c +++ b/src/domain.c @@ -506,7 +506,7 @@ virtDBusDomainBlockPeek(GVariant *inArgs, gsize size; guint flags; g_autofree guchar *buffer = NULL; - GVariantBuilder *builder; + GVariantBuilder builder; GVariant *res; g_variant_get(inArgs, "(&sttu)", &disk, &offset, &size, &flags); @@ -519,11 +519,11 @@ virtDBusDomainBlockPeek(GVariant *inArgs, if (virDomainBlockPeek(domain, disk, offset, size, buffer, flags) < 0) return virtDBusUtilSetLastVirtError(error); - builder = g_variant_builder_new(G_VARIANT_TYPE("ay")); + g_variant_builder_init(&builder, G_VARIANT_TYPE("ay")); for (unsigned int i = 0; i < size; i++) - g_variant_builder_add(builder, "y", buffer[i]); + g_variant_builder_add(&builder, "y", buffer[i]); - res = g_variant_builder_end(builder); + res = g_variant_builder_end(&builder); *outArgs = g_variant_new_tuple(&res, 1); } @@ -1221,7 +1221,7 @@ virtDBusDomainMemoryPeek(GVariant *inArgs, gsize size; guint flags; g_autofree guchar *buffer = NULL; - GVariantBuilder *builder; + GVariantBuilder builder; GVariant *res; g_variant_get(inArgs, "(ttu)", &offset, &size, &flags); @@ -1234,11 +1234,11 @@ virtDBusDomainMemoryPeek(GVariant *inArgs, if (virDomainMemoryPeek(domain, offset, size, buffer, flags) < 0) return virtDBusUtilSetLastVirtError(error); - builder = g_variant_builder_new(G_VARIANT_TYPE("ay")); + g_variant_builder_init(&builder, G_VARIANT_TYPE("ay")); for (unsigned int i = 0; i < size; i++) - g_variant_builder_add(builder, "y", buffer[i]); + g_variant_builder_add(&builder, "y", buffer[i]); - res = g_variant_builder_end(builder); + res = g_variant_builder_end(&builder); *outArgs = g_variant_new_tuple(&res, 1); } -- 2.15.0

2 1

[libvirt] [PATCH v2 0/5] uml: Clean/fix test driver usage of FindBy{UUID|ID}
by John Ferlan 19 Apr '18

19 Apr '18

Patches 9-11 of larger series: v1: https://www.redhat.com/archives/libvir-list/2018-March/msg00489.html Changes since v1: * Patches 1 and 2 new - essentially they fix issues with how virDomainObjListRemove was used inconsistently. * Patch 3 should be the same or very similar to the former patch 9: https://www.redhat.com/archives/libvir-list/2018-March/msg00498.html * Patch 4 should be the same as former patch 10: https://www.redhat.com/archives/libvir-list/2018-March/msg00499.html * Patch 5 is altered to also fix virDomainObjListRemove inconsistencies John Ferlan (5): uml: Fix umlProcessAutoDestroyDom dom processing uml: Fix umlInotifyEvent dom object handling uml: Create accessors to virDomainObjListFindByUUID uml: Add more specific error message on failed FindBy call uml: Use virDomainObjListFindBy{UUID|ID}Ref src/uml/uml_driver.c | 353 +++++++++++++++++---------------------------------- 1 file changed, 116 insertions(+), 237 deletions(-) -- 2.13.6

3 13

[libvirt] [PATCH v2 0/7] qemu: Add support for 'write-cache' disk frontend argument (blockdev-add saga)
by Peter Krempa 19 Apr '18

19 Apr '18

Version 2: - new and better testing against the newest capability file - reordered test case, so that the new parameter is visibly added Peter Krempa (7): tests: qemu: Add helper code to lookup most recent capability file tests: qemuxml2argv: Add infrastructure to pass output file suffix tests: qemuxml2argv: Add infrastructure for testing with real qemuCaps qemu: domain: Add helper for translating disk cachemode to qemu flags tests: qemuxml2argv: Test formatting of 'write-cache' parameter qemu: caps: Add capability for 'write-cache' parameter of disk frontends qemu: Format 'write-cache' parameter for disk frontends src/qemu/qemu_capabilities.c | 5 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 27 +++++++ src/qemu/qemu_domain.c | 75 +++++++++++++++++ src/qemu/qemu_domain.h | 6 ++ tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../disk-drive-write-cache.new.args | 45 +++++++++++ tests/qemuxml2argvdata/disk-drive-write-cache.xml | 45 +++++++++++ tests/qemuxml2argvtest.c | 81 ++++++++++++++++++- tests/testutilsqemu.c | 94 ++++++++++++++++++++++ tests/testutilsqemu.h | 5 ++ 26 files changed, 397 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.new.args create mode 100644 tests/qemuxml2argvdata/disk-drive-write-cache.xml -- 2.16.2

3 22

[libvirt] [dbus PATCH v2 0/3] Introduce more Domain* APIs
by Katerina Koukiou 19 Apr '18

19 Apr '18

Changes to v1: Resending unmerged patches from previous patchset with fixed comments. Katerina Koukiou (3): Implement FSFreeze method for Domain Interface Implement FSThaw method for Domain Interface Implement GetControlInfo method for Domain Interface data/org.libvirt.Domain.xml | 20 ++++++ src/domain.c | 144 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 164 insertions(+) -- 2.15.0

3 8