- Devel - libvirt List Archives

[libvirt] [PATCH] maint: typo fix in VIR_MIGRATE_PARAM_URI
by Eric Blake 11 May '18

11 May '18

s/filed/field/ Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the trivial rule include/libvirt/libvirt-domain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 12fd34037e..d7cbd18796 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -837,7 +837,7 @@ typedef enum { * the destination host has multiple interfaces and a specific interface is * required to transmit migration data. * - * This filed may not be used when VIR_MIGRATE_TUNNELLED flag is set. + * This field may not be used when VIR_MIGRATE_TUNNELLED flag is set. */ # define VIR_MIGRATE_PARAM_URI "migrate_uri" -- 2.14.3

1 0

[libvirt] [PATCH v5 0/7] Enable memory-backend-file.discard-data
by Michal Privoznik 11 May '18

11 May '18

v5 of: https://www.redhat.com/archives/libvir-list/2018-April/msg02029.html diff to v4: - last patch in the original series is split into two, - more tests added - couple of small changes (e.g. s/int/virTristateBool/) Michal Privoznik (7): qemuMonitorJSONGetDeviceProps: Separate props processing qemu_monitor: Introduce qemuMonitorGetObjectProps qemu_capabilities: Introduce QEMU_CAPS_QOM_LIST_PROPERTIES qemu_capabilities: Introduce QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD conf: Move virDomainMemtune formatting into a separate function conf: Introduce memoryBacking/discard qemu: Implement memoryBacking/discard docs/formatdomain.html.in | 34 +- docs/schemas/cputypes.rng | 5 + docs/schemas/domaincommon.rng | 10 + src/conf/domain_conf.c | 150 +- src/conf/domain_conf.h | 3 + src/conf/numa_conf.c | 27 + src/conf/numa_conf.h | 3 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 22 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_command.c | 27 +- src/qemu/qemu_monitor.c | 13 + src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 89 +- src/qemu/qemu_monitor_json.h | 4 + .../caps_2.12.0.aarch64.replies | 416 +- tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 4 +- .../qemucapabilitiesdata/caps_2.12.0.ppc64.replies | 4454 ++++++++++---------- tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 4 +- .../qemucapabilitiesdata/caps_2.12.0.s390x.replies | 78 +- tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 2 + .../caps_2.12.0.x86_64.replies | 804 ++-- tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 4 +- tests/qemuxml2argvdata/hugepages-pages.args | 12 +- tests/qemuxml2argvdata/hugepages-pages.xml | 3 +- tests/qemuxml2argvdata/hugepages-pages3.args | 3 +- tests/qemuxml2argvdata/hugepages-pages3.xml | 4 +- tests/qemuxml2argvdata/hugepages-pages7.args | 3 +- tests/qemuxml2argvdata/hugepages-pages7.xml | 4 +- tests/qemuxml2argvtest.c | 9 +- tests/qemuxml2xmloutdata/hugepages-pages.xml | 3 +- tests/qemuxml2xmloutdata/hugepages-pages3.xml | 4 +- 32 files changed, 3337 insertions(+), 2869 deletions(-) -- 2.16.1

2 10

[libvirt] [PATCH v2 0/4] Reimplement logging wildcards to use full shell glob syntax
by Daniel P. Berrangé 11 May '18

11 May '18

This series provides a more generalized support for wildcards in logging and removes the ordering constraint. Changed in v2: - Improve various config file comments (Erik) - Always use fnmatch as performance hit vs strstr will be inconsequential in real world (Dan). Daniel P. Berrangé (4): Revert "util: virlog: Introduce wildcard to log filters" log: rename virLogFlags to virLogFilterFlags to match docs log: support logging using shell wildcard syntax log: update docs for daemons to improve user understanding src/locking/test_virtlockd.aug.in | 2 +- src/locking/virtlockd.conf | 65 +++++++++++++++++++++++++---------- src/logging/test_virtlogd.aug.in | 2 +- src/logging/virtlogd.conf | 68 +++++++++++++++++++++++++----------- src/remote/libvirtd.conf | 72 +++++++++++++++++++++++---------------- src/remote/test_libvirtd.aug.in | 2 +- src/util/virlog.c | 49 +++----------------------- src/util/virlog.h | 3 +- 8 files changed, 146 insertions(+), 117 deletions(-) -- 2.14.3

2 10

[libvirt] [dbus PATCH 0/2] Fixes required before first release
by Katerina Koukiou 11 May '18

11 May '18

Katerina Koukiou (2): domain: Replace State property with GetState method Replace uint -> int wherever libvirt uses int type data/org.libvirt.Connect.xml | 18 +++++------ data/org.libvirt.Domain.xml | 26 +++++++++------- data/org.libvirt.Network.xml | 2 +- data/org.libvirt.Secret.xml | 2 +- data/org.libvirt.StoragePool.xml | 2 +- src/connect.c | 6 ++-- src/domain.c | 67 ++++++++++++++++++++++------------------ src/events.c | 12 +++---- src/network.c | 4 +-- src/secret.c | 2 +- src/storagepool.c | 2 +- tests/test_domain.py | 9 +++--- 12 files changed, 80 insertions(+), 72 deletions(-) -- 2.15.0

3 6

[libvirt] [PATCH] virbuffer: Set child buffer indent properly
by Michal Privoznik 11 May '18

11 May '18

There's this macro virBufferSetChildIndent which sets offset of child buffer from given parent buffer. However, it is calling virBufferAdjustIndent() which only adds adjustment instead of calling virBufferSetIndent() which clears out any adjustment previously set. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virbuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h index 4f5ed162fb..e95ee878a1 100644 --- a/src/util/virbuffer.h +++ b/src/util/virbuffer.h @@ -112,7 +112,7 @@ void virBufferSetIndent(virBufferPtr, int indent); * child buffer. */ # define virBufferSetChildIndent(childBuf_, parentBuf_) \ - virBufferAdjustIndent(childBuf_, virBufferGetIndent(parentBuf_, false) + 2) + virBufferSetIndent(childBuf_, virBufferGetIndent(parentBuf_, false) + 2) int virBufferGetIndent(const virBuffer *buf, bool dynamic); -- 2.16.1

2 1

[libvirt] [dbus PATCH 00/22] StoragePool remains and Domain Events
by Katerina Koukiou 11 May '18

11 May '18

Katerina Koukiou (22): Implement StoragePoolCreateXML method for Connect Interface Implement StoragePoolDefineXML method for Connect Interface events: Register VIR_STORAGE_POOL_EVENT_ID_REFRESH events: Register VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE events: Register VIR_DOMAIN_EVENT_ID_BALLOON_CHANGE events: Register VIR_DOMAIN_EVENT_ID_BLOCK_JOB events: Register VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2 events: Register VIR_DOMAIN_EVENT_ID_CONTROL_ERROR events: Register VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED events: Register VIR_DOMAIN_EVENT_ID_GRAPHICS events: Register VIR_DOMAIN_EVENT_ID_REBOOT events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON events: Register VIR_DOMAIN_EVENT_ID_JOB_COMPLETED events: Register VIR_DOMAIN_EVENT_ID_METADATA_CHANGE events: Register VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION events: Register VIR_DOMAIN_EVENT_ID_PMSUSPEND events: Register VIR_DOMAIN_EVENT_ID_PMSUSPEND_DISK events: Register VIR_DOMAIN_EVENT_ID_PMWAKEUP events: Register VIR_DOMAIN_EVENT_ID_RTC_CHANGE events: Register VIR_DOMAIN_EVENT_ID_TUNABLE events: Register VIR_DOMAIN_EVENT_ID_WATCHDOG data/org.libvirt.Connect.xml | 14 + data/org.libvirt.Domain.xml | 108 ++++++++ data/org.libvirt.StoragePool.xml | 4 + src/connect.c | 62 +++++ src/events.c | 549 +++++++++++++++++++++++++++++++++++++++ tests/test_connect.py | 48 ++++ tests/test_storage.py | 10 + 7 files changed, 795 insertions(+) -- 2.15.0

2 45

[libvirt] [PATCHv2 00/12] Switch from yajl to Jansson
by Ján Tomko 11 May '18

11 May '18

Per the discussion here: https://www.redhat.com/archives/libvir-list/2017-November/msg00225.html Switch from using yajl to Jansson. v1: https://www.redhat.com/archives/libvir-list/2018-March/msg01781.html Patches 5-11 are meant to be squashed together before pushing, but are posted separately here in hope it will make reviewing them easier. Ján Tomko (12): virJSONValue: remove unused 'protect' property tests: replace references to yajl build: add --with-jansson build: undef WITH_JANSSON for SETUID_RPC_CLIENT Switch from yajl to Jansson FIXUP: Adjust test data for Jansson FIXUP: Remove functions using yajl FIXUP: make nss depend on Jansson instead of yajl FIXUP: compile and link with Jansson instead of yajl FIXUP: s/WITH_YAJL/WITH_JANSSON/ FIXUP: libvirt.spec: use jansson instead of yajl build: require Jansson if QEMU driver is enabled config-post.h | 1 + configure.ac | 3 + libvirt.spec.in | 4 +- m4/virt-driver-qemu.m4 | 8 +- m4/virt-jansson.m4 | 29 + m4/virt-nss.m4 | 4 +- m4/virt-yajl.m4 | 27 +- src/Makefile.am | 8 +- src/qemu/qemu_driver.c | 2 +- src/util/Makefile.inc.am | 4 +- src/util/virjson.c | 614 ++++++--------------- tests/Makefile.am | 12 +- tests/cputest.c | 16 +- tests/libxlxml2domconfigtest.c | 4 +- tests/qemuagenttest.c | 4 +- .../xml2json/file-backing_basic-aio_threads.json | 9 +- .../file-backing_basic-cache-directsync.json | 9 +- .../xml2json/file-backing_basic-cache-none.json | 9 +- .../xml2json/file-backing_basic-cache-unsafe.json | 9 +- .../file-backing_basic-cache-writeback.json | 9 +- .../file-backing_basic-cache-writethrough.json | 9 +- .../xml2json/file-backing_basic-detect.json | 9 +- .../xml2json/file-backing_basic-noopts.json | 9 +- .../xml2json/file-backing_basic-unmap-detect.json | 9 +- .../xml2json/file-backing_basic-unmap-ignore.json | 9 +- .../xml2json/file-backing_basic-unmap.json | 9 +- .../file-qcow2-backing-chain-encryption.json | 3 +- .../xml2json/file-qcow2-backing-chain-noopts.json | 27 +- .../file-qcow2-backing-chain-unterminated.json | 3 +- .../network-qcow2-backing-chain-cache-unsafe.json | 3 +- ...etwork-qcow2-backing-chain-encryption_auth.json | 3 +- tests/qemucapabilitiestest.c | 4 +- tests/qemucaps2xmltest.c | 4 +- tests/qemucommandutiltest.c | 4 +- tests/qemuhotplugtest.c | 4 +- tests/qemumigparamsdata/empty.json | 4 +- tests/qemumigparamsdata/unsupported.json | 4 +- tests/qemumigparamstest.c | 4 +- tests/qemumonitorjsontest.c | 4 +- tests/virmacmaptestdata/empty.json | 4 +- tests/virmocklibxl.c | 4 +- tests/virnetdaemontest.c | 2 +- tests/virstoragetest.c | 4 +- 43 files changed, 292 insertions(+), 632 deletions(-) create mode 100644 m4/virt-jansson.m4 -- 2.16.1

2 26

[libvirt] [REPOST PATCHv3 0/6] Add support for VM Generation ID (vmgenid)
by John Ferlan 11 May '18

11 May '18

Repost of : https://www.redhat.com/archives/libvir-list/2018-May/msg00251.html to update patch 2 with the recent capabilities changes. Sync'd up to commit id 'c9da6cbe'. Cover from the v3 posting: v2: https://www.redhat.com/archives/libvir-list/2018-April/msg02234.html Changes since v2: * Essentially handle comments from code review of original series from comments received for patch 6: https://www.redhat.com/archives/libvir-list/2018-April/msg02240.html It's a somewhat simplified approach removing the ABI checks and the adjustment to the genid value as part of domain def copy. * (NEW) Patch 5 - add a 'genid' domain capability (similar to how Cole added support for vmcoreinfo). Since the apps need a way to determine whether this is enabled, this seems to be the best way. John Ferlan (6): conf: Add VM Generation ID parse/format support qemu: Add VM Generation ID device capability qemu: Alter VM Generation ID for specific startup/launch transitions qemu: Add VM Generation ID to qemu command line domcaps: Add 'genid' to domain capabilities docs: Add news article for VM Generation ID docs/formatdomain.html.in | 27 +++++++++++ docs/formatdomaincaps.html.in | 7 ++- docs/news.xml | 13 ++++++ docs/schemas/domaincaps.rng | 7 +++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_capabilities.c | 3 ++ src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 54 ++++++++++++++++++++++ src/conf/domain_conf.h | 5 ++ src/qemu/qemu_capabilities.c | 6 +++ src/qemu/qemu_capabilities.h | 3 ++ src/qemu/qemu_command.c | 24 ++++++++++ src/qemu/qemu_driver.c | 17 +++++-- src/qemu/qemu_process.c | 46 +++++++++++++++++- src/qemu/qemu_process.h | 1 + tests/domaincapsschemadata/basic.xml | 1 + tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsschemadata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsschemadata/full.xml | 1 + tests/domaincapsschemadata/libxl-xenfv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenfv.xml | 1 + tests/domaincapsschemadata/libxl-xenpv-usb.xml | 1 + tests/domaincapsschemadata/libxl-xenpv.xml | 1 + tests/domaincapsschemadata/qemu_1.7.0.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.12.0.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsschemadata/qemu_2.6.0.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 + .../domaincapsschemadata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsschemadata/qemu_2.8.0.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.9.0-q35.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsschemadata/qemu_2.9.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../qemuxml2argvdata/genid-auto.x86_64-latest.args | 30 ++++++++++++ tests/qemuxml2argvdata/genid-auto.xml | 32 +++++++++++++ tests/qemuxml2argvdata/genid.x86_64-latest.args | 30 ++++++++++++ tests/qemuxml2argvdata/genid.xml | 32 +++++++++++++ tests/qemuxml2argvtest.c | 4 ++ tests/qemuxml2xmloutdata/genid-active.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-auto-active.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-auto-inactive.xml | 32 +++++++++++++ tests/qemuxml2xmloutdata/genid-inactive.xml | 32 +++++++++++++ tests/qemuxml2xmltest.c | 5 +- 53 files changed, 504 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxml2argvdata/genid-auto.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/genid-auto.xml create mode 100644 tests/qemuxml2argvdata/genid.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/genid.xml create mode 100644 tests/qemuxml2xmloutdata/genid-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-active.xml create mode 100644 tests/qemuxml2xmloutdata/genid-auto-inactive.xml create mode 100644 tests/qemuxml2xmloutdata/genid-inactive.xml -- 2.14.3

1 6

[libvirt] [PATCH] virsh: Don't skip the first entry when the typed command share same prefix
by Lin Ma 11 May '18

11 May '18

Signed-off-by: Lin Ma <lma(a)suse.com> --- tools/vsh.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index f76076b164..1516e578d9 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -3495,11 +3495,11 @@ cmdComplete(vshControl *ctl, const vshCmd *cmd) if (!(matches = vshReadlineCompletion(arg, 0, 0))) goto cleanup; - /* According to rl_completion_matches documentation, the - * first entry in @matches array is some dummy substitution - * string for @arg. Skip it. */ - for (iter = &matches[1]; *iter; iter++) + for (iter = matches; *iter; iter++) { + if (iter == matches && matches[1]) + continue; printf("%s\n", *iter); + } ret = true; cleanup: -- 2.16.2

2 1

Re: [libvirt] ZFS backend does fail if used on non top level pools
by Brian Candler 11 May '18

11 May '18

> This one is the "unknown" for me. What happens if you create > Xzfs/images/vol1 (or your command below) without first creating Xzfs/images? Answer: it fails, unless you give the '-p' flag. -p Creates all the non-existing parent datasets. Datasets created in this manner are automatically mounted according to the mountpoint property inherited from their parent. Any property specified on the command line using the -o option is ignored. If the target filesystem already exists, the operation completes successfully. Example: given an existing zfs pool called "zfs": # zfs create zfs/foo/bar cannot create 'zfs/foo/bar': parent does not exist # zfs create -p zfs/foo/bar # zfs list zfs/foo NAME USED AVAIL REFER MOUNTPOINT zfs/foo 192K 23.5G 96K /zfs/foo # zfs list -r zfs/foo NAME USED AVAIL REFER MOUNTPOINT zfs/foo 192K 23.5G 96K /zfs/foo zfs/foo/bar 96K 23.5G 96K /zfs/foo/bar However, I don't see this as a problem for libvirt. The parent should already exist when you define the pool, and I expect libvirt will only create immediate children. > If one digs into the virStorageBackendZFSBuildPool they will see libvirt > pool create/build processing would "zpool create $name $path[0...n]" > where $name is the "source.name" (in your case Xzfs/images) and > $path[0...n] would be the various paths (in your case tmp/Xzfs) Just to be clear, creating a zpool ("zpool create") is different to creating a zfs dataset ("zfs create"). By analogy to LVM: a zpool is like a volume group, and a zfs dataset/zvol is like a logical volume. A zpool (or VG) is created from a collection of block devices - or something which looks like a block device, e.g. a partition or a loopback-mounted file. Those are $path[0...n] in the above, and would be called "physical volumes" in LVM. "zfs create" then creates a dataset (filesystem) or zvol (block device) which draws space out of the zpool. The analogous operation in LVM is "lvcreate", although it will only give you a block device - it's up to you to make a filesystem within it. In summary: zpool create ==> vgcreate (*) zfs create -V ==> lvcreate (*) LVM also requires you to label the block devices with "pvcreate" before you can add them to a volume group. zpool create doesn't require this. From my point of view, as a libvirt user: I *could* dedicate an entire zpool to libvirt, but I don't want to. It would mean libvirt has full ownership of that set of physical disks, and I may want to use the space for other things as well. What I want to do is to allow libvirt to use an existing zpool, with a parent dataset which it can allocate underneath, like this: zfs create zfs/libvirt virsh pool-define-as --name zfs --source-name zfs/libvirt --type zfs (instead of using pool-create/pool-build). This not only makes it clear which datasets belong to libvirt, but allows me to do things like storage accounting at the parent dataset level. And actually, this almost works. It's just the pool refresh which fails, because it tries to treat "zfs/images" as if it were a zpool. Stripping off everything up to the first slash for "zpool get" would fix this. Arguably this uncovers a couple of other related issues to do with error handling: - to the end user, "virsh pool-refresh" silently appears to work (unless you dig down deep into logs), even though the underlying "zpool get" returns with an error - by this stage, pool-refresh has already destroyed all existing libvirt volumes which were previously in the pool Regards, Brian.

1 0