- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/8] Make use of autofree within storage code
by John Ferlan 12 Feb '19

12 Feb '19

v2: https://www.redhat.com/archives/libvir-list/2019-February/msg00477.html Changes since v2: * Pushed what was already agreed upon w/ R-by's, so in order to apply this you'll need to get all those changes. * Repost extractions of code that were requested in code review, but not formally R-by'd (patches 1-5). NB: Although Erik did agree in principle to what was changed for patch5, I figured posting would be better than assuming. * (NEW) patches 6 & 7 are a result of comment from v2 patch1 where it was noted that @authdef could have been overwritten * Patch8 is R-by'd from Jano; however, Erik has noted a failure for src/util/virstoragefile.c to build on MinGW. Neither of us have any idea what the failure is, so I'll leave this in the series to at least get through patches 1-7. "A" thought to resolve this issue is to remove the 'inline' from the VIR_DEFINE_AUTOPTR_FUNC definition. I have seen this before from a review of LXC code: https://www.redhat.com/archives/libvir-list/2019-January/msg00975.html where the "fix" for my environment was to remove the "inline". While I assume that'd work here, it's still not clear why src/conf changes are fine, but src/util changes are not. John Ferlan (8): storage: Cleanup virStorageFileBackendGlusterReadlinkCallback storage: Use VIR_AUTOFREE for storage backends storage: Rework ret logic in storageBackendUpdateVolTargetInfo storage: Use VIR_AUTOCLOSE tests: Fix memory leak in testCompareXMLToArgvFiles conf: Check for duplicate authdef during hostdev iSCSI processing util: Check for duplicated id in virStorageSourceParseRBDColonString util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource src/conf/domain_conf.c | 9 +- src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_driver.c | 9 +- src/qemu/qemu_migration.c | 3 +- src/storage/storage_backend.c | 9 +- src/storage/storage_backend_disk.c | 62 +++---- src/storage/storage_backend_fs.c | 17 +- src/storage/storage_backend_gluster.c | 33 ++-- src/storage/storage_backend_iscsi.c | 72 +++----- src/storage/storage_backend_iscsi_direct.c | 36 ++-- src/storage/storage_backend_logical.c | 35 ++-- src/storage/storage_backend_mpath.c | 17 +- src/storage/storage_backend_rbd.c | 35 ++-- src/storage/storage_backend_scsi.c | 77 +++------ src/storage/storage_backend_sheepdog.c | 27 +-- src/storage/storage_backend_vstorage.c | 25 +-- src/storage/storage_backend_zfs.c | 15 +- src/storage/storage_file_fs.c | 15 +- src/storage/storage_file_gluster.c | 16 +- src/storage/storage_util.c | 182 ++++++++------------ src/util/virstoragefile.c | 185 +++++++++------------ src/util/virstoragefile.h | 1 + tests/qemublocktest.c | 6 +- tests/storagepoolxml2argvtest.c | 13 +- tests/virstoragetest.c | 50 +++--- 25 files changed, 349 insertions(+), 603 deletions(-) -- 2.20.1

2 17

[libvirt] Wiki account request
by Pino Toscano 12 Feb '19

12 Feb '19

Hi, I'd like an account on the libvirt wiki, so I can add ideas to the GSoC page. Thanks, -- Pino Toscano

2 1

[libvirt] [PATCH 0/5] Remove some volOptions from virStoragePoolTypeInfo
by John Ferlan 12 Feb '19

12 Feb '19

While working through changes to add storage pool capabilities I found that the volOptions definitions for a few pool types were not necessary and in a couple of cases wrong. Figured I would extract them out of my work on those adjustments while I'm still working through the code. John Ferlan (5): conf: Remove volOptions for VIR_STORAGE_POOL_SHEEPDOG conf: Remove volOptions for VIR_STORAGE_POOL_RBD conf: Remove volOptions for VIR_STORAGE_POOL_SCSI conf: Remove volOptions for VIR_STORAGE_POOL_ISCSI[_DIRECT] conf: Remove volOptions for VIR_STORAGE_POOL_MPATH src/conf/storage_conf.c | 21 --------------------- tests/storagevolxml2xmlout/vol-sheepdog.xml | 1 - 2 files changed, 22 deletions(-) -- 2.20.1

1 6

[libvirt] [PATCH 0/4] virsh: iothreadinfo fixes
by Ján Tomko 12 Feb '19

12 Feb '19

Ján Tomko (4): virsh: reduce the optimism in cmdIOThreadInfo virsh: do not assign negative values to niothreads virsh: remove redundant virshNodeGetCPUCount virsh: initialize info in cmdIOThreadInfo tools/virsh-domain.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) -- 2.19.2

2 5

[libvirt] [PATCH] qemu: do not format <usedQMP/> in qemu caps XML
by Ján Tomko 12 Feb '19

12 Feb '19

Since commit a7424faff QMP is always used. Also, commit 932534e8 removed the last use of this apart from: * parsing/formatting this in the caps cache * using it as a temporary variable to know when to report an error Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Note that the second use should be removed by this series: https://www.redhat.com/archives/libvir-list/2019-January/msg00310.html which I am unable to apply. src/qemu/qemu_capabilities.c | 7 ------- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 1 - tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 1 - tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 1 - 37 files changed, 43 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index f035e68251..9d9c8096ba 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3357,7 +3357,6 @@ virQEMUCapsParseSEVInfo(virQEMUCapsPtr qemuCaps, xmlXPathContextPtr ctxt) * <qemuctime>234235253</qemuctime> * <selfctime>234235253</selfctime> * <selfvers>1002016</selfvers> - * <usedQMP/> * <flag name='foo'/> * <flag name='bar'/> * ... @@ -3418,9 +3417,6 @@ virQEMUCapsLoadCache(virArch hostArch, if (virXPathULong("string(./selfvers)", ctxt, &lu) == 0) qemuCaps->libvirtVersion = lu; - qemuCaps->usedQMP = virXPathBoolean("count(./usedQMP) > 0", - ctxt) > 0; - if ((n = virXPathNodeSet("./flag", ctxt, &nodes)) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("failed to parse qemu capabilities flags")); @@ -3761,9 +3757,6 @@ virQEMUCapsFormatCache(virQEMUCapsPtr qemuCaps) virBufferAsprintf(&buf, "<selfvers>%lu</selfvers>\n", (unsigned long)qemuCaps->libvirtVersion); - if (qemuCaps->usedQMP) - virBufferAddLit(&buf, "<usedQMP/>\n"); - for (i = 0; i < QEMU_CAPS_LAST; i++) { if (virQEMUCapsGet(qemuCaps, i)) { virBufferAsprintf(&buf, "<flag name='%s'/>\n", diff --git a/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml index b54b438f63..d626910258 100644 --- a/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml index 4754467ce7..c281cd5f7f 100644 --- a/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml index 84d9777f68..bb6c598fc2 100644 --- a/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml index c632a1332b..340a725287 100644 --- a/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml index 6c537567cd..e8bf3cef9f 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='virtio-tx-alg'/> diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml index ca481f84ce..b24e26dfc5 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='virtio-tx-alg'/> diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml index dced5b51f9..6707633b14 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='virtio-tx-alg'/> <flag name='virtio-blk-pci.ioeventfd'/> diff --git a/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml index 2b40d0e28f..1e3a4d753c 100644 --- a/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml index 82daefafa0..a781af8a04 100644 --- a/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='virtio-tx-alg'/> <flag name='virtio-blk-pci.ioeventfd'/> diff --git a/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml index 25c22e34f6..1ebf54baae 100644 --- a/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml index 0d22eff9b9..4531964c75 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='virtio-tx-alg'/> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml index c20ecbfa51..835d36425f 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='virtio-tx-alg'/> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml index 0beb46aeb8..4988ab3fe7 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='virtio-tx-alg'/> <flag name='virtio-blk-pci.ioeventfd'/> diff --git a/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml index 39cd9aebf5..301ab899bb 100644 --- a/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml index 9fbb010feb..14de9d7b3b 100644 --- a/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml index 5bae2bd700..24f47515d4 100644 --- a/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml b/tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml index a06ca127b3..59688ea09f 100644 --- a/tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='ccid-emulated'/> diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml index a932756151..0ceadb42c0 100644 --- a/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='virtio-tx-alg'/> diff --git a/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml index dd1d3accf9..828ee630af 100644 --- a/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml index c48711eba4..77e067e9ba 100644 --- a/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='virtio-tx-alg'/> <flag name='virtio-blk-pci.ioeventfd'/> diff --git a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml index 0106c16eaa..9e9aeb1449 100644 --- a/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml index 232060ddff..87cc501e25 100644 --- a/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='virtio-tx-alg'/> <flag name='virtio-blk-pci.ioeventfd'/> diff --git a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml index 6bcb1034f8..5eb786945b 100644 --- a/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml index 2344a5f9aa..0bc61f9c2b 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='virtio-tx-alg'/> diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml index fd1518b929..f628417a0d 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='virtio-tx-alg'/> <flag name='virtio-blk-pci.ioeventfd'/> diff --git a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml index 360ce218f4..fe3385680a 100644 --- a/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml index 71198a608a..4de8f17f51 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='virtio-tx-alg'/> diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml b/tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml index 1ff0e12f01..669c0dd786 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='scsi-disk.channel'/> <flag name='scsi-block'/> <flag name='transaction'/> diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml b/tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml index 1f07d6ad65..7884d6c07f 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='scsi-disk.channel'/> <flag name='scsi-block'/> <flag name='transaction'/> diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml b/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml index b784360a6a..57d9fc6770 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='virtio-tx-alg'/> <flag name='virtio-blk-pci.ioeventfd'/> diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml index 4b28962bb9..ad942520e9 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml b/tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml index 11be58b496..1ad1dbcdbc 100644 --- a/tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='hda-duplex'/> <flag name='virtio-tx-alg'/> diff --git a/tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml index f13ef0ece2..39b910e3b1 100644 --- a/tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml b/tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml index 3d958db461..14fd0228ea 100644 --- a/tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml +++ b/tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='spice'/> <flag name='hda-duplex'/> <flag name='ccid-emulated'/> diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml b/tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml index 40083843f2..437e711293 100644 --- a/tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml +++ b/tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='spice'/> <flag name='hda-duplex'/> <flag name='ccid-emulated'/> diff --git a/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml index 109b1ff753..88e9e029fb 100644 --- a/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml @@ -2,7 +2,6 @@ <qemuctime>0</qemuctime> <selfctime>0</selfctime> <selfvers>0</selfvers> - <usedQMP/> <flag name='kvm'/> <flag name='no-hpet'/> <flag name='spice'/> -- 2.19.2

2 1

[libvirt] [PATCH 0/9] virsh domfsinfo fixes
by Ján Tomko 12 Feb '19

12 Feb '19

Fix a crash and other issues: https://bugzilla.redhat.com/show_bug.cgi?id=1676354 Ján Tomko (9): vshtabletest: indent strings with expected output vsh-table: allow empty columns virsh: introduce ninfos variable in cmdDomFSInfo virsh: rename ret to rc in cmdDomFSInfo virsh: do not access uninitialized memory in cmdDomFSInfo virsh: introduce 'ret' in cmdDomFSInfo virsh: do not report error on zero filesystems in cmdDomFSInfo virsh: use virBufferTrim in cmdDomFSInfo virsh: allow empty targets in cmdDomFSInfo tests/vshtabletest.c | 78 +++++++++++++++++++++++--------------------- tools/virsh-domain.c | 35 +++++++++++--------- tools/vsh-table.c | 3 -- 3 files changed, 60 insertions(+), 56 deletions(-) -- 2.19.2

2 12

[libvirt] [PATCH 0/5] tools: Adapt to newer wireshark
by Michal Privoznik 12 Feb '19

12 Feb '19

While implementing some other feature I wanted to use wireshark to debug a migration issue. Only then I found that our wireshark plugin is no longer being loaded. Here are the fixes. Michal Prívozník (5): tools: Cleanup packet-libvirt.h tools: Keep wireshark plugin registration code in git wireshark: Provide registration code for newer wireshark m4: Put wireshark plugin into epan/ directory tools: Drop support for pre-2.4.0 wireshark .gitignore | 1 - cfg.mk | 2 +- libvirt.spec.in | 10 +- m4/virt-wireshark.m4 | 10 +- tools/Makefile.am | 15 +- tools/wireshark/src/packet-libvirt.c | 106 +++++++----- tools/wireshark/src/packet-libvirt.h | 93 +---------- tools/wireshark/src/plugin.c | 86 ++++++++++ tools/wireshark/util/make-dissector-reg | 205 ------------------------ 9 files changed, 170 insertions(+), 358 deletions(-) create mode 100644 tools/wireshark/src/plugin.c delete mode 100755 tools/wireshark/util/make-dissector-reg -- 2.19.2

2 9

[libvirt] [PATCH v2 00/32] Make use of autofree within storage code
by John Ferlan 12 Feb '19

12 Feb '19

v1: https://www.redhat.com/archives/libvir-list/2019-February/msg00187.html Much of this was R-by'd for V1 with caveats for splitting things out, etc. Still since there isn't an end of release rush ;-) - I figure reposting everything before doing any sort of push would be more prudent and conservative course of action! I've added R-by's for many of the patches, but with all the requested change - there were a few that we hadn't "closed on" from v1 that didn't get an R-by... The following is a "map" of the patches: Patches 1-3 = Old Patch1 - All 3 R-by'd Patch 4 = Old Patch2 - Has R-by Patches 5-7 = Old Patch3 - All 3 R-by'd Patches 8-9 = Old Patch4 - 8 needs an R-by, although 9 has it Patch 10 = Old Patch5 - Has R-by Patch 11 = Old Patch6 - Has R-by Patch 12 = Old Patch7 - Needs R-by since I kept VIR_STEAL_PTR logic in virStorageBackendLogicalFindPoolSourcesFunc Patch 13 = Old Patch8 - Has R-by Patches 14-15 = Old Patch9 - Didn't include R-by since I split out the noted issue in virStorageBackendSCSINewLun Patch 16 = Old Patch10 - Has R-by Patches 17-18 = Old Patch11 - Both have R-by Patches 19-21 = Old Patch12 - All 3 R-by'd Patch 22 = Old Patch13 - Has R-by Patch 23 = Old Patch14 - Has R-by Patch 24 = NEW - "Fallout" from Old Patch4 review Patch 25 = Old Patch15 - Took implicity R-by for VIR_STEAL_PTR extraction Patches 26-32 = Old Patch15 - None have R-by. I split out the @def/@ret logic, then created the VIR_AUTOPTR patch from there. If the virstoragefile modifications are too much no big deal. Perhaps they can be reworked or just dropped. Everyone has their favorite way of doing things I guess. John Ferlan (32): conf,util,qemu: Use VIR_STEAL_PTR for authdef processing util: Rework virStorageAuthDefCopy util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageAuthDef conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStoragePoolSource storage: Use VIR_STEAL_PTR for gluster volume processing conf: Rework virStorageVolDefParseXML conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageVolDef conf: Rework virStoragePoolDefParseXML conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStoragePoolDef storage: Use VIR_AUTOPTR(virString) storage: Use VIR_AUTOPTR(virCommand) storage: Use VIR_AUTOFREE for storage backends storage: Use VIR_AUTOFREE for storage driver util: Fix virStorageBackendSCSINewLun error handling storage: Use VIR_AUTOFREE for storage util conf: Use VIR_AUTOFREE for storage_conf util: Use VIR_STEAL_PTR in virstoragefile util: Use VIR_AUTOFREE for virstoragefile test: Cleanup testDomainRenameCallback test: Remove unused @xml from testDomainSnapshotCreateXML test: Use VIR_AUTOFREE for test driver tests: Use VIR_AUTOFREE for various storage tests storage: Use VIR_AUTOCLOSE tests: Fix memory leak in testCompareXMLToArgvFiles storage: Use VIR_STEAL_PTR in storageBackendProbeTarget util: Rename variable in virStorageFileMetadataNew util: Rename variable in virStorageSourceCopy util: Rename variable in virStorageSourceNewFromBackingRelative util: Rename variable in virStorageSourceNewFromBackingAbsolute util: Rename variable in virStorageSourceNewFromBacking tests: Rename variable in testStorageFileGetMetadata util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource src/conf/domain_conf.c | 35 +- src/conf/storage_conf.c | 334 +++++------ src/conf/storage_conf.h | 4 + src/conf/virstorageobj.c | 27 +- src/esx/esx_storage_backend_vmfs.c | 6 +- src/phyp/phyp_driver.c | 6 +- src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_driver.c | 9 +- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_parse_command.c | 6 +- src/storage/storage_backend.c | 9 +- src/storage/storage_backend_disk.c | 147 ++--- src/storage/storage_backend_fs.c | 59 +- src/storage/storage_backend_gluster.c | 45 +- src/storage/storage_backend_iscsi.c | 76 +-- src/storage/storage_backend_iscsi_direct.c | 61 +- src/storage/storage_backend_logical.c | 139 ++--- src/storage/storage_backend_mpath.c | 42 +- src/storage/storage_backend_rbd.c | 44 +- src/storage/storage_backend_scsi.c | 81 +-- src/storage/storage_backend_sheepdog.c | 107 ++-- src/storage/storage_backend_vstorage.c | 39 +- src/storage/storage_backend_zfs.c | 77 +-- src/storage/storage_driver.c | 85 +-- src/storage/storage_file_fs.c | 15 +- src/storage/storage_file_gluster.c | 16 +- src/storage/storage_util.c | 553 +++++++----------- src/test/test_driver.c | 208 +++---- src/util/virstoragefile.c | 620 +++++++++------------ src/util/virstoragefile.h | 3 + src/vbox/vbox_storage.c | 3 +- tests/qemublocktest.c | 6 +- tests/storagebackendsheepdogtest.c | 59 +- tests/storagepoolxml2argvtest.c | 29 +- tests/storagepoolxml2xmltest.c | 36 +- tests/storagevolxml2argvtest.c | 56 +- tests/storagevolxml2xmltest.c | 44 +- tests/virstoragetest.c | 111 ++-- tests/virstorageutiltest.c | 7 +- 39 files changed, 1181 insertions(+), 2029 deletions(-) -- 2.20.1

3 89

[libvirt] [tck PATCH] Set cache=none for KVM guests
by Daniel P. Berrangé 11 Feb '19

11 Feb '19

QEMU will refuse to live migrate with the default caching mode, so we must explicitly set cache=none for the migration tests to pass. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- lib/Sys/Virt/TCK/DomainBuilder.pm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/Sys/Virt/TCK/DomainBuilder.pm b/lib/Sys/Virt/TCK/DomainBuilder.pm index 7a25d42..399534c 100644 --- a/lib/Sys/Virt/TCK/DomainBuilder.pm +++ b/lib/Sys/Virt/TCK/DomainBuilder.pm @@ -396,11 +396,16 @@ sub as_xml { type => $disk->{type}, $disk->{device} ? (device => $disk->{device}) : ()); + my @driver = (); + if ($self->{type} eq "qemu" || + $self->{type} eq "kvm") { + push @driver, "cache", "none"; + } if ($disk->{format}) { - $w->emptyTag("driver", - name => $disk->{format}->{name}, - type => $disk->{format}->{type}); + push @driver, "name", $disk->{format}->{name}, + "type", $disk->{format}->{type}; } + $w->emptyTag("driver", @driver); if ($disk->{type} eq "block") { $w->emptyTag("source", -- 2.20.1

2 1

[libvirt] [libvirt-go PATCH 0/2] Add VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY constant
by Erik Skultety 11 Feb '19

11 Feb '19

Erik Skultety (2): Add VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY constant Introduce DomainMigrateMaxSpeedFlags constant domain.go | 14 ++++++++++++-- domain_compat.h | 9 +++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) -- 2.20.1

2 5