- Devel - libvirt List Archives

[libvirt] [PATCH 0/4] libxl: add support for max grant frames
by Jim Fehlig 15 Mar '19

15 Mar '19

This patch series takes the long road on the way to adding support for Xen's max_grant_frames to libvirt. Patch1 adds a new 'xenbus' controller type that supports a maxGrantFrames attribute. maxGrantFrames describes the maximum IO buffer space (or DMA space) available in the xenbus controller for use by connected paravirtual devices. Patch2 adds a xenbus controller to the domXML in post-parse callback if one is not explicitly specified, with downside of requiring touching all test files. Patch3 adds support for max grant frames in the libxl driver and a test to check the libxl domain config generator. Patch4 adds support for the setting on the domXML<->native config converter and also includes a test. Jim Fehlig (4): conf: Add a new 'xenbus' controller type libxl: Add implicit xenbus controller libxl: Add support for max_grant_frames xenconfig: Add support for max_grant_frames docs/formatdomain.html.in | 6 ++ docs/schemas/domaincommon.rng | 11 +++ src/conf/domain_conf.c | 25 ++++++ src/conf/domain_conf.h | 8 ++ src/libxl/libxl_conf.c | 9 ++ src/libxl/libxl_domain.c | 5 ++ src/qemu/qemu_command.c | 1 + src/qemu/qemu_domain.c | 2 + src/qemu/qemu_domain_address.c | 1 + src/xenconfig/xen_xl.c | 56 ++++++++++++ .../max-gntframes-hvm.json | 90 +++++++++++++++++++ .../max-gntframes-hvm.xml | 37 ++++++++ tests/libxlxml2domconfigtest.c | 3 + tests/sexpr2xmldata/sexpr2xml-boot-grub.xml | 1 + .../sexpr2xmldata/sexpr2xml-bridge-ipaddr.xml | 1 + tests/sexpr2xmldata/sexpr2xml-curmem.xml | 1 + .../sexpr2xml-disk-block-shareable.xml | 1 + tests/sexpr2xmldata/sexpr2xml-disk-block.xml | 1 + .../sexpr2xml-disk-drv-blktap-qcow.xml | 1 + .../sexpr2xml-disk-drv-blktap-raw.xml | 1 + .../sexpr2xml-disk-drv-blktap2-raw.xml | 1 + tests/sexpr2xmldata/sexpr2xml-disk-file.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 1 + .../sexpr2xml-fv-empty-kernel.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-force-hpet.xml | 1 + .../sexpr2xml-fv-force-nohpet.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-localtime.xml | 1 + .../sexpr2xml-fv-net-netfront.xml | 1 + .../sexpr2xml-fv-parallel-tcp.xml | 1 + .../sexpr2xml-fv-serial-dev-2-ports.xml | 1 + .../sexpr2xml-fv-serial-dev-2nd-port.xml | 1 + .../sexpr2xml-fv-serial-file.xml | 1 + .../sexpr2xml-fv-serial-null.xml | 1 + .../sexpr2xml-fv-serial-pipe.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-serial-pty.xml | 1 + .../sexpr2xml-fv-serial-stdio.xml | 1 + .../sexpr2xml-fv-serial-tcp-telnet.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-serial-udp.xml | 1 + .../sexpr2xml-fv-serial-unix.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-sound-all.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-sound.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml | 1 + .../sexpr2xmldata/sexpr2xml-fv-usbtablet.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-utc.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv-v2.xml | 1 + tests/sexpr2xmldata/sexpr2xml-fv.xml | 1 + tests/sexpr2xmldata/sexpr2xml-net-bridged.xml | 1 + tests/sexpr2xmldata/sexpr2xml-net-e1000.xml | 1 + tests/sexpr2xmldata/sexpr2xml-net-routed.xml | 1 + .../sexpr2xml-no-source-cdrom.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pci-devs.xml | 1 + .../sexpr2xml-pv-bootloader-cmdline.xml | 1 + .../sexpr2xmldata/sexpr2xml-pv-bootloader.xml | 1 + .../sexpr2xmldata/sexpr2xml-pv-localtime.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-vcpus.xml | 1 + .../sexpr2xml-pv-vfb-new-vncdisplay.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv-vfb-new.xml | 1 + .../sexpr2xml-pv-vfb-type-crash.xml | 1 + tests/sexpr2xmldata/sexpr2xml-pv.xml | 1 + tests/sexpr2xmldata/sexpr2xml-vif-rate.xml | 1 + tests/xlconfigdata/test-channel-pty.xml | 1 + tests/xlconfigdata/test-channel-unix.xml | 1 + .../test-disk-positional-parms-full.xml | 1 + .../test-disk-positional-parms-partial.xml | 1 + tests/xlconfigdata/test-disk-qed.xml | 1 + tests/xlconfigdata/test-fullvirt-cpuid.xml | 1 + ...ullvirt-direct-kernel-boot-bogus-extra.xml | 1 + ...test-fullvirt-direct-kernel-boot-extra.xml | 1 + .../test-fullvirt-direct-kernel-boot.xml | 1 + .../xlconfigdata/test-fullvirt-hpet-timer.xml | 1 + .../test-fullvirt-multi-timer.xml | 1 + .../test-fullvirt-multiserial.xml | 1 + tests/xlconfigdata/test-fullvirt-multiusb.xml | 1 + .../test-fullvirt-nestedhvm-disabled.xml | 1 + .../xlconfigdata/test-fullvirt-nestedhvm.xml | 1 + tests/xlconfigdata/test-fullvirt-nohap.xml | 1 + tests/xlconfigdata/test-fullvirt-ovmf.xml | 1 + .../test-fullvirt-ovswitch-tagged.xml | 1 + .../test-fullvirt-ovswitch-trunked.xml | 1 + .../xlconfigdata/test-fullvirt-tsc-timer.xml | 1 + tests/xlconfigdata/test-fullvirt-type.xml | 1 + tests/xlconfigdata/test-fullvirt-vnuma.xml | 1 + tests/xlconfigdata/test-max-gntframes.cfg | 13 +++ tests/xlconfigdata/test-max-gntframes.xml | 32 +++++++ tests/xlconfigdata/test-new-disk.xml | 1 + ...test-paravirt-cmdline-bogus-extra-root.xml | 1 + .../test-paravirt-cmdline-extra-root.xml | 1 + tests/xlconfigdata/test-paravirt-cmdline.xml | 1 + tests/xlconfigdata/test-paravirt-maxvcpus.xml | 1 + tests/xlconfigdata/test-paravirt-type.xml | 1 + tests/xlconfigdata/test-pvh-type.xml | 1 + .../test-rbd-multihost-noauth.xml | 1 + tests/xlconfigdata/test-spice-features.xml | 1 + tests/xlconfigdata/test-spice.xml | 1 + tests/xlconfigdata/test-usb.xml | 1 + tests/xlconfigdata/test-usbctrl.xml | 1 + tests/xlconfigdata/test-vif-multi-ip.xml | 1 + tests/xlconfigdata/test-vif-rate.xml | 1 + tests/xlconfigdata/test-vif-typename.xml | 1 + tests/xlconfigtest.c | 4 + .../xmconfigdata/test-disk-drv-blktap-raw.xml | 1 + .../test-disk-drv-blktap2-raw.xml | 1 + tests/xmconfigdata/test-escape-paths.xml | 1 + .../test-fullvirt-default-feature.xml | 1 + .../xmconfigdata/test-fullvirt-force-hpet.xml | 1 + .../test-fullvirt-force-nohpet.xml | 1 + .../xmconfigdata/test-fullvirt-localtime.xml | 1 + .../test-fullvirt-net-netfront.xml | 1 + .../xmconfigdata/test-fullvirt-new-cdrom.xml | 1 + tests/xmconfigdata/test-fullvirt-nohap.xml | 1 + .../test-fullvirt-parallel-tcp.xml | 1 + .../test-fullvirt-serial-file.xml | 1 + .../test-fullvirt-serial-null.xml | 1 + .../test-fullvirt-serial-pipe.xml | 1 + .../xmconfigdata/test-fullvirt-serial-pty.xml | 1 + .../test-fullvirt-serial-stdio.xml | 1 + .../test-fullvirt-serial-tcp-telnet.xml | 1 + .../xmconfigdata/test-fullvirt-serial-tcp.xml | 1 + .../xmconfigdata/test-fullvirt-serial-udp.xml | 1 + .../test-fullvirt-serial-unix.xml | 1 + tests/xmconfigdata/test-fullvirt-sound.xml | 1 + tests/xmconfigdata/test-fullvirt-usbmouse.xml | 1 + .../xmconfigdata/test-fullvirt-usbtablet.xml | 1 + tests/xmconfigdata/test-fullvirt-utc.xml | 1 + tests/xmconfigdata/test-no-source-cdrom.xml | 1 + .../xmconfigdata/test-paravirt-extra-root.xml | 1 + tests/xmconfigdata/test-paravirt-maxvcpus.xml | 1 + .../xmconfigdata/test-paravirt-net-e1000.xml | 1 + .../test-paravirt-net-vifname.xml | 1 + .../test-paravirt-new-pvfb-vncdisplay.xml | 1 + tests/xmconfigdata/test-paravirt-new-pvfb.xml | 1 + tests/xmconfigdata/test-paravirt-root.xml | 1 + tests/xmconfigdata/test-paravirt-vcpu.xml | 1 + tests/xmconfigdata/test-pci-devs.xml | 1 + 136 files changed, 423 insertions(+) create mode 100644 tests/libxlxml2domconfigdata/max-gntframes-hvm.json create mode 100644 tests/libxlxml2domconfigdata/max-gntframes-hvm.xml create mode 100644 tests/xlconfigdata/test-max-gntframes.cfg create mode 100644 tests/xlconfigdata/test-max-gntframes.xml -- 2.20.1

3 12

[libvirt] [PATCH 0/2] Require YAJL for QEMU build
by Michal Privoznik 14 Mar '19

14 Mar '19

This also fixes a problem that Cole reported on IRC where qemufirmware test is failing on FreeBSD because QEMU driver is enabled but there's no YAJL. Michal Prívozník (2): virt-yajl.m4: Drop useless check for qemu virt-driver-qemu.m4: Require YAJL m4/virt-driver-qemu.m4 | 9 +++++++++ m4/virt-yajl.m4 | 20 -------------------- 2 files changed, 9 insertions(+), 20 deletions(-) -- 2.19.2

4 7

[libvirt] [PATCH] virstoragefile: identify GPFS as cluster FS
by Diego Michelotto 14 Mar '19

14 Mar '19

GPFS is 'IBM General Parallel File System', also called 'IBM Spectrum Scale', stalls when a process issues a lot of fsyncs in a short timeframe. It is better if the VM I/O is not synchronous. It is racommended to use writeback caching policy. In order to permit that it is added VIR_FILE_SHFS_GPFS to the list of shared file systems in virStorageFileIsClusterFS function. Signed-off-by: Diego Michelotto <diego.michelotto(a)cnaf.infn.it> --- src/util/virstoragefile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index b2e308d81d..0fe2819dc6 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -1349,7 +1349,8 @@ int virStorageFileIsClusterFS(const char *path) return virFileIsSharedFSType(path, VIR_FILE_SHFS_GFS2 | VIR_FILE_SHFS_OCFS | - VIR_FILE_SHFS_CEPH); + VIR_FILE_SHFS_CEPH | + VIR_FILE_SHFS_GPFS); } #ifdef LVS -- 2.20.1

2 2

[libvirt] [PATCH v2 0/5] qemu_hotplug: Fix a rare race condition when detaching a device twice
by Michal Privoznik 14 Mar '19

14 Mar '19

v2 of: https://www.redhat.com/archives/libvir-list/2019-March/msg00753.html diff to v1: - qemuDomainDeleteDevice now can do enter/exit monitor - qemuMonitorDelDevice doesn't report error on DeviceNotFound - On DeviceNotFound the caller is made wait for event, if none came Michal Prívozník (5): qemu_hotplug: Introduce and use qemuDomainDeleteDevice DO NOT APPLY: Simple reproducer qemuMonitorJSONDelDevice: Return -2 on DeviceNotFound error qemu_hotplug: Fix a rare race condition when detaching a device twice DO NOT APPLY: Revert simple reproducer src/qemu/qemu_domain.h | 1 + src/qemu/qemu_hotplug.c | 326 ++++++++++++++++------------------- src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor_json.c | 5 + 4 files changed, 167 insertions(+), 175 deletions(-) -- 2.19.2

2 16

[libvirt] [PATCH 0/8] Remove some unnecessary compatibility stuff
by Andrea Bolognani 14 Mar '19

14 Mar '19

Andrea Bolognani (8): tests: Drop CONFIG_HEADER from TESTS_ENVIRONMENT tests: Drop LIBVIRT_DRIVER_DIR from TESTS_ENVIRONMENT tests: Don't use TEST_DRIVER_DIR in virTestCaptureProgramExecChild() tests: Don't define TEST_DRIVER_DIR tests: Stop looking for abs_top_srcdir in the environment Fix names for abs_top_{src,build}dir variables tests: Don't redefine variables for TESTS_ENVIRONMENT Don't define abs_* variables ourselves src/Makefile.am | 10 ++-------- src/conf/domain_conf.c | 2 +- src/cpu/cpu_map.c | 4 ++-- src/driver.c | 2 +- src/locking/lock_driver_lockd.c | 2 +- src/locking/lock_manager.c | 2 +- src/logging/log_manager.c | 2 +- src/lxc/lxc_conf.c | 2 +- src/network/bridge_driver.c | 2 +- src/remote/remote_driver.c | 2 +- src/storage/storage_backend.c | 2 +- src/storage/storage_backend_disk.c | 4 ++-- src/util/virfile.c | 4 ++-- src/util/virstoragefilebackend.c | 2 +- tests/Makefile.am | 31 ++++++------------------------ tests/libxlxml2domconfigtest.c | 5 ----- tests/networkxml2firewalltest.c | 6 ------ tests/nwfilterxml2firewalltest.c | 6 ------ tests/qemumemlocktest.c | 5 ----- tests/qemuxml2argvtest.c | 5 ----- tests/testutils.c | 1 - tests/virschematest.c | 2 +- tests/virscsitest.c | 5 ----- tests/virshtest.c | 4 ++-- tests/virtestmock.c | 4 ++-- 25 files changed, 29 insertions(+), 87 deletions(-) -- 2.20.1

3 12

[libvirt] [PATCH] docs: rng: make newly introduced features in domcaps optional
by Nikolay Shirokovskiy 14 Mar '19

14 Mar '19

<features> was introduced in 24f17f55 and have only gic child element at the time. Thus from backcompat POV the other children are optional. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- docs/schemas/domaincaps.rng | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng index 7d80693..2258365 100644 --- a/docs/schemas/domaincaps.rng +++ b/docs/schemas/domaincaps.rng @@ -183,9 +183,15 @@ <element name='features'> <interleave> <ref name='gic'/> - <ref name='vmcoreinfo'/> - <ref name='vmgenid'/> - <ref name='sev'/> + <optional> + <ref name='vmcoreinfo'/> + </optional> + <optional> + <ref name='vmgenid'/> + </optional> + <optional> + <ref name='sev'/> + </optional> </interleave> </element> </define> -- 1.8.3.1

2 1

[libvirt] [PATCH] conf: Introduce virDomainDefCputuneValidate helper
by Suyang Chen 14 Mar '19

14 Mar '19

move all the def->cputune 'period must be in range' and 'quota must be in range' errors into two macros and called in virDomainDefCputuneValidate function and have it called from virDomainDefValidateInternal function Reason: Two macros maybe easier to debug and change in the future Solve the first two small tasks in bitsizedtask: "Move validation checks out of domain XML parsing" Signed-off-by: Suyang Chen <dawson0xff(a)gmail.com> --- src/conf/domain_conf.c | 109 +++++++++++++++-------------------------- 1 file changed, 40 insertions(+), 69 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 356a9ae56c..c159cffa05 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6565,6 +6565,43 @@ virDomainDefLifecycleActionValidate(const virDomainDef *def) return 0; } +#define CPUTUNE_VALIDATE_PERIOD(name) \ + if (def->cputune.name > 0 && \ + (def->cputune.name < 1000 || def->cputune.name > 1000000)) { \ + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, \ + _("Value of cputune '%s' must be in range " \ + "[1000, 1000000]"), #name); \ + return -1; \ + } + +#define CPUTUNE_VALIDATE_QUOTA(name) \ + if (def->cputune.name > 0 && \ + (def->cputune.name < 1000 || \ + def->cputune.name > 18446744073709551LL)) { \ + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, \ + _("Value of cputune '%s' must be in range " \ + "[1000, 18446744073709551]"), #name); \ + return -1; \ + } + +static int +virDomainDefCputuneValidate(const virDomainDef *def) +{ + CPUTUNE_VALIDATE_PERIOD(period) + CPUTUNE_VALIDATE_PERIOD(global_period) + CPUTUNE_VALIDATE_PERIOD(emulator_period) + CPUTUNE_VALIDATE_PERIOD(iothread_period) + + CPUTUNE_VALIDATE_QUOTA(quota) + CPUTUNE_VALIDATE_QUOTA(global_quota) + CPUTUNE_VALIDATE_QUOTA(emulator_quota) + CPUTUNE_VALIDATE_QUOTA(iothread_quota) + + return 0; +} + +#undef CPUTUNE_VALIDATE_PERIOD +#undef CPUTUNE_VALIDATE_QUOTA static int virDomainDefMemtuneValidate(const virDomainDef *def) @@ -6685,6 +6722,9 @@ virDomainDefValidateInternal(const virDomainDef *def, if (virDomainDefOSValidate(def, xmlopt) < 0) return -1; + if (virDomainDefCputuneValidate(def) < 0) + return -1; + return 0; } @@ -19673,14 +19713,6 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } - if (def->cputune.period > 0 && - (def->cputune.period < 1000 || def->cputune.period > 1000000)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Value of cputune period must be in range " - "[1000, 1000000]")); - goto error; - } - if (virXPathLongLong("string(./cputune/quota[1])", ctxt, &def->cputune.quota) < -1) { virReportError(VIR_ERR_XML_ERROR, "%s", @@ -19688,15 +19720,6 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } - if (def->cputune.quota > 0 && - (def->cputune.quota < 1000 || - def->cputune.quota > 18446744073709551LL)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Value of cputune quota must be in range " - "[1000, 18446744073709551]")); - goto error; - } - if (virXPathULongLong("string(./cputune/global_period[1])", ctxt, &def->cputune.global_period) < -1) { virReportError(VIR_ERR_XML_ERROR, "%s", @@ -19704,14 +19727,6 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } - if (def->cputune.global_period > 0 && - (def->cputune.global_period < 1000 || def->cputune.global_period > 1000000)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Value of cputune global period must be in range " - "[1000, 1000000]")); - goto error; - } - if (virXPathLongLong("string(./cputune/global_quota[1])", ctxt, &def->cputune.global_quota) < -1) { virReportError(VIR_ERR_XML_ERROR, "%s", @@ -19719,15 +19734,6 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } - if (def->cputune.global_quota > 0 && - (def->cputune.global_quota < 1000 || - def->cputune.global_quota > 18446744073709551LL)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Value of cputune global quota must be in range " - "[1000, 18446744073709551]")); - goto error; - } - if (virXPathULongLong("string(./cputune/emulator_period[1])", ctxt, &def->cputune.emulator_period) < -1) { virReportError(VIR_ERR_XML_ERROR, "%s", @@ -19735,15 +19741,6 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } - if (def->cputune.emulator_period > 0 && - (def->cputune.emulator_period < 1000 || - def->cputune.emulator_period > 1000000)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Value of cputune emulator_period must be in range " - "[1000, 1000000]")); - goto error; - } - if (virXPathLongLong("string(./cputune/emulator_quota[1])", ctxt, &def->cputune.emulator_quota) < -1) { virReportError(VIR_ERR_XML_ERROR, "%s", @@ -19751,14 +19748,6 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } - if (def->cputune.emulator_quota > 0 && - (def->cputune.emulator_quota < 1000 || - def->cputune.emulator_quota > 18446744073709551LL)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Value of cputune emulator_quota must be in range " - "[1000, 18446744073709551]")); - goto error; - } if (virXPathULongLong("string(./cputune/iothread_period[1])", ctxt, &def->cputune.iothread_period) < -1) { @@ -19767,15 +19756,6 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } - if (def->cputune.iothread_period > 0 && - (def->cputune.iothread_period < 1000 || - def->cputune.iothread_period > 1000000)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Value of cputune iothread_period must be in range " - "[1000, 1000000]")); - goto error; - } - if (virXPathLongLong("string(./cputune/iothread_quota[1])", ctxt, &def->cputune.iothread_quota) < -1) { virReportError(VIR_ERR_XML_ERROR, "%s", @@ -19783,15 +19763,6 @@ virDomainDefParseXML(xmlDocPtr xml, goto error; } - if (def->cputune.iothread_quota > 0 && - (def->cputune.iothread_quota < 1000 || - def->cputune.iothread_quota > 18446744073709551LL)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Value of cputune iothread_quota must be in range " - "[1000, 18446744073709551]")); - goto error; - } - if ((n = virXPathNodeSet("./cputune/vcpupin", ctxt, &nodes)) < 0) goto error; -- 2.20.1

2 1

[libvirt] [PATCH] news: Document recent snapshot topological flag
by Eric Blake 14 Mar '19

14 Mar '19

A new API flag is news-worthy. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- I'll probably push this one as trivial in 24 hours, if it does not get a review sooner. docs/news.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 896700fa97..1973a0096d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -82,6 +82,18 @@ chooses. </description> </change> + <change> + <summary> + snapshots: Topologically-sorted listing + </summary> + <description> + A new flag VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL is available + for the various snapshot listing APIs such as + virDomainSnapshotListAll(). For drivers that support the + flag, the listed snapshots are guaranteed to be sorted such + that parents occur before children. + </description> + </change> </section> <section title="Improvements"> </section> -- 2.20.1

2 1

[libvirt] [PATCH 0/2] Remove --enable-test-coverage, promote 'make coverage'
by Cole Robinson 14 Mar '19

14 Mar '19

This is my follow up to my message here: https://www.redhat.com/archives/libvir-list/2019-February/msg01213.html This removes our custom ./configure --enable-test-coverage and 'make cov' targets in favor of gnulib's 'make coverage' which IMO is much simpler to use. See the mail above for full explanation Patch #2 adds some hacking.html docs, see that for some details about gnulib's features here. Cole Robinson (2): configure: Remove --enable-test-coverage docs: hacking: Add 'Code coverage reports' section Makefile.am | 20 +++----------------- configure.ac | 18 ------------------ docs/hacking.html.in | 29 +++++++++++++++++++++++++++++ examples/Makefile.am | 2 +- src/Makefile.am | 3 +-- src/remote/Makefile.inc.am | 2 -- tests/Makefile.am | 2 -- tools/Makefile.am | 6 ------ 8 files changed, 34 insertions(+), 48 deletions(-) -- 2.20.1

2 4

[libvirt] [PATCH] docs: Consistent spacing in *GetXMLDesc functions
by Eric Blake 14 Mar '19

14 Mar '19

We copy-and-paste a lot of our docs, as evidenced by the number of *GetXMLDesc() functions which had the same unusual indentation and missing capital in the second sentence of the returns paragraph. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the trivial rule. src/libvirt-domain-snapshot.c | 4 ++-- src/libvirt-domain.c | 12 ++++++------ src/libvirt-interface.c | 4 ++-- src/libvirt-network.c | 8 ++++---- src/libvirt-nwfilter.c | 8 ++++---- 5 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index 23c0b84d9e..947547627a 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -254,8 +254,8 @@ virDomainSnapshotCreateXML(virDomainPtr domain, * VIR_DOMAIN_SNAPSHOT_XML_SECURE; this flag is rejected on read-only * connections. * - * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case + * of error. The caller must free() the returned value. */ char * virDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot, diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 072b92b717..be5b1f6740 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -2570,8 +2570,8 @@ virDomainGetControlInfo(virDomainPtr domain, * XML might not validate against the schema, so it is mainly for * internal use. * - * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case + * of error. The caller must free() the returned value. */ char * virDomainGetXMLDesc(virDomainPtr domain, unsigned int flags) @@ -2619,8 +2619,8 @@ virDomainGetXMLDesc(virDomainPtr domain, unsigned int flags) * generates libvirt domain XML. The format of the native * data is hypervisor dependent. * - * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case + * of error. The caller must free() the returned value. */ char * virConnectDomainXMLFromNative(virConnectPtr conn, @@ -2669,8 +2669,8 @@ virConnectDomainXMLFromNative(virConnectPtr conn, * a native configuration file describing the domain. * The format of the native data is hypervisor dependent. * - * Returns a 0 terminated UTF-8 encoded native config datafile, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated UTF-8 encoded native config datafile, or + * NULL in case of error. The caller must free() the returned value. */ char * virConnectDomainXMLToNative(virConnectPtr conn, diff --git a/src/libvirt-interface.c b/src/libvirt-interface.c index 69415293ed..7228ddca57 100644 --- a/src/libvirt-interface.c +++ b/src/libvirt-interface.c @@ -403,8 +403,8 @@ virInterfaceGetMACString(virInterfacePtr iface) * is not set, the ip address and netmask will be the current live * setting of the interface, not the settings from the config files. * - * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case + * of error. The caller must free() the returned value. */ char * virInterfaceGetXMLDesc(virInterfacePtr iface, unsigned int flags) diff --git a/src/libvirt-network.c b/src/libvirt-network.c index 9f9e0ddaf8..d46a7d5c47 100644 --- a/src/libvirt-network.c +++ b/src/libvirt-network.c @@ -783,8 +783,8 @@ virNetworkGetUUIDString(virNetworkPtr network, char *buf) * VIR_NETWORK_XML_INACTIVE, then the expansion of virtual interfaces is * not performed. * - * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case + * of error. The caller must free() the returned value. */ char * virNetworkGetXMLDesc(virNetworkPtr network, unsigned int flags) @@ -820,8 +820,8 @@ virNetworkGetXMLDesc(virNetworkPtr network, unsigned int flags) * Provides a bridge interface name to which a domain may connect * a network interface in order to join the network. * - * Returns a 0 terminated interface name, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated interface name, or NULL in case of + * error. The caller must free() the returned value. */ char * virNetworkGetBridgeName(virNetworkPtr network) diff --git a/src/libvirt-nwfilter.c b/src/libvirt-nwfilter.c index 3da85adc9e..16eceb6525 100644 --- a/src/libvirt-nwfilter.c +++ b/src/libvirt-nwfilter.c @@ -453,8 +453,8 @@ virNWFilterUndefine(virNWFilterPtr nwfilter) * Provide an XML description of the network filter. The description may be * reused later to redefine the network filter with virNWFilterCreateXML(). * - * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case + * of error. The caller must free() the returned value. */ char * virNWFilterGetXMLDesc(virNWFilterPtr nwfilter, unsigned int flags) @@ -770,8 +770,8 @@ virNWFilterBindingDelete(virNWFilterBindingPtr binding) * Provide an XML description of the network filter. The description may be * reused later to redefine the network filter with virNWFilterCreateXML(). * - * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case of error. - * the caller must free() the returned value. + * Returns a 0 terminated UTF-8 encoded XML instance, or NULL in case + * of error. The caller must free() the returned value. */ char * virNWFilterBindingGetXMLDesc(virNWFilterBindingPtr binding, unsigned int flags) -- 2.20.1

1 0