- Devel - libvirt List Archives

[libvirt] [PATCH] network: drop back compat code loading actual bridge name
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

The actual network def was updated to save the bridge name back in 1.2.11: commit a3609121799d44898a3e0d0bf92b755e55e7b418 Author: Laine Stump <laine(a)laine.org> Date: Fri Nov 21 12:20:37 2014 -0500 network: save bridge name in ActualNetDef when actualType==network too The chance that someone is running libvirt < 1.2.11 and wants todo a live upgrade to 5.3.0 without a host reboot is essentially zero. We can thus reasonably drop the back compat code now. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/network/bridge_driver.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 6f88adf3b7..0c65c48b1a 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4812,17 +4812,6 @@ networkNotifyActualDevice(virNetworkPtr net, goto error; } - /* if we're restarting libvirtd after an upgrade from a version - * that didn't save bridge name in actualNetDef for - * actualType==network, we need to copy it in so that it will be - * available in all cases - */ - if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK && - !iface->data.network.actual->data.bridge.brname && - (VIR_STRDUP(iface->data.network.actual->data.bridge.brname, - netdef->bridge) < 0)) - goto error; - /* see if we're connected to the correct bridge */ if (netdef->bridge) { bool useOVS = false; -- 2.20.1

2 1

[libvirt] Reproducible VM start bug which affects libvirt 5.1.0 and 5.2.0
by Frank Schreuder 04 Apr '19

04 Apr '19

Hello, I am currently running into a reproducible libvirt bug which affects libvirt 5.1.0 and 5.2.0. There seem to be a racecondition in the nwfilter-define and virsh start commands. Several times a day I'm not able to start a VM anymore with the following error message: error: Failed to start domain test error: internal error: Failed to apply firewall rules /sbin/iptables -w -I FORWARD 1 -j libvirt-in: iptables v1.6.0: Couldn't load target `libvirt-in':No such file or directory To fix this issue I have to restart libvirt. Some iptable chains are missing, which is probably caused by a nwfilter-define operation. I'm able to reproduce this bug within 2 hours by running 2 loops. One loop is defining nwfilters and the second loop is destroying and starting multiple VMs. I found an entry in the changelog of libvirt 5.1.0, which seems related to this bug: Create private chains for virtual network firewall rules Historically firewall rules for virtual networks were added straight into the base chains. This works but has a number of bugs and design limitations. To address them, libvirt now puts firewall rules into its own chains. Note that with this change the filter, nat and mangle tables are required for both IPv4 and IPv6. So far I am not able to reproduce this bug on libvirt 5.0.0. Is there any information I can provide to the mailinglist to help debug and/or fix this bug? I am also willing to test patches. With kind regards, Frank Schreuder

2 3

[libvirt] [PATCH v3 00/36] network: refactor to decouple virt drivers from network driver
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

An update to v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00681.html v2: https://www.redhat.com/archives/libvir-list/2019-February/msg01581.html Currently the network driver registers a set of callbacks with the virt driver in order to handle allocating/releasing network ports associated with guest NICs. This series introduces a virNetworkPortPtr object and associated XML that describes a network port. The virt drivers now call public APIs associated with this new object to create/delete ports for guest NICs. Changed in v3: - Remove unused API symbol - Fix dist of test data files Changed in v2: - Fix many bugs related to upgrades with running VMs - Convert over bandwidth controls to the new APIs - Handle reconnecting VIFs to bridges during startup - Much much more that I can't remember Daniel P. Berrangé (36): network: restrict usage of port management APIs network: pass a virNetworkPtr to port management APIs conf: simplify link from hostdev back to network device network: add missing bandwidth limits for bridge forward type network: use 'bridge' as actual type instead of 'network' util: add helper method for re-attaching a tap device to a bridge network: use virNetDevTapReattachBridge API virt drivers: don't handle type=network after resolving actual network type network: move re-attach of bridge device out of network driver network: move fixup for domain actual net def out of network driver network: unconditionally merge port profiles conf: don't pass interface type into virNetDevBandwidthParse conf: introduce virNetworkPortDefPtr struct and XML support network: stop passing virDomainNetDefPtr into bandwidth functions network: make networkLogAllocation independent of domain conf util: add API for copying virtual port profile data conf: add APIs to convert virDomainNetDef to virNetworkPortDef network: convert networkAllocateActualDevice to virNetworkPortDef network: convert networkNotifyActualDevice to virNetworkPortDef network: convert networkReleaseActualDevice to virNetworkPortDef network: convert hook script to take a network port XML network: remove the virDomainNetBandwidthChangeAllowed callback network: introduce networkAllocatePort network: introduce networkNotifyPort network: introduce networkReleasePort network: introduce networkUpdatePortBandwidth network: add public APIs for network port object access: add permissions for network port objects remote: add support for new network port APIs virsh: add support for network port APIs conf: support recording ports against virNetworkObjPtr network: add implementation of network port APIs lxc, libxl: notify network driver of NICs during reconnect lxc, libxl: save domain status after reconnect conf: record a portid against the domain conf conf: switch over to use network port APIs for virt drivers docs/formatdomain.html.in | 8 + docs/hooks.html.in | 24 +- docs/schemas/domaincommon.rng | 5 + include/libvirt/libvirt-network.h | 122 ++ include/libvirt/virterror.h | 3 + src/access/genpolkit.pl | 2 +- src/access/viraccessdriver.h | 6 + src/access/viraccessdrivernop.c | 11 + src/access/viraccessdriverpolkit.c | 26 + src/access/viraccessdriverstack.c | 25 + src/access/viraccessmanager.c | 16 + src/access/viraccessmanager.h | 6 + src/access/viraccessperm.c | 6 + src/access/viraccessperm.h | 44 + src/conf/Makefile.inc.am | 2 + src/conf/domain_conf.c | 557 ++++++- src/conf/domain_conf.h | 63 +- src/conf/netdev_bandwidth_conf.c | 22 +- src/conf/netdev_bandwidth_conf.h | 2 +- src/conf/network_conf.c | 4 +- src/conf/virnetworkobj.c | 303 ++++ src/conf/virnetworkobj.h | 34 + src/conf/virnetworkportdef.c | 514 +++++++ src/conf/virnetworkportdef.h | 112 ++ src/datatypes.c | 60 + src/datatypes.h | 41 + src/driver-network.h | 41 + src/libvirt-network.c | 444 ++++++ src/libvirt_private.syms | 25 +- src/libvirt_public.syms | 12 + src/libxl/libxl_conf.c | 21 +- src/libxl/libxl_domain.c | 28 +- src/libxl/libxl_driver.c | 60 +- src/lxc/lxc_driver.c | 37 +- src/lxc/lxc_process.c | 56 +- src/network/bridge_driver.c | 1364 +++++++++-------- src/qemu/qemu_command.c | 11 +- src/qemu/qemu_domain_address.c | 4 +- src/qemu/qemu_driver.c | 10 +- src/qemu/qemu_hotplug.c | 84 +- src/qemu/qemu_hotplug.h | 2 +- src/qemu/qemu_interface.c | 12 +- src/qemu/qemu_process.c | 32 +- src/remote/remote_daemon_dispatch.c | 73 + src/remote/remote_driver.c | 69 + src/remote/remote_protocol.x | 124 +- src/remote_protocol-structs | 69 + src/rpc/gendispatch.pl | 18 +- src/util/virerror.c | 9 + src/util/virhook.c | 4 +- src/util/virhook.h | 4 +- src/util/virhostdev.c | 17 +- src/util/virnetdevtap.c | 69 + src/util/virnetdevtap.h | 12 + src/util/virnetdevvportprofile.c | 16 + src/util/virnetdevvportprofile.h | 2 + tests/Makefile.am | 7 + .../net-virtio-network-portgroup.xml | 6 +- tests/virnetdevbandwidthtest.c | 2 +- .../plug-bridge-mactbl.xml | 9 + .../virnetworkportxml2xmldata/plug-bridge.xml | 12 + .../virnetworkportxml2xmldata/plug-direct.xml | 12 + .../plug-hostdev-pci.xml | 12 + tests/virnetworkportxml2xmldata/plug-none.xml | 8 + tests/virnetworkportxml2xmltest.c | 104 ++ tools/virsh-completer.c | 50 + tools/virsh-completer.h | 4 + tools/virsh-network.c | 399 ++++- tools/virsh-network.h | 5 + 69 files changed, 4526 insertions(+), 851 deletions(-) create mode 100644 src/conf/virnetworkportdef.c create mode 100644 src/conf/virnetworkportdef.h create mode 100644 tests/virnetworkportxml2xmldata/plug-bridge-mactbl.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-bridge.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-direct.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-hostdev-pci.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-none.xml create mode 100644 tests/virnetworkportxml2xmltest.c -- 2.20.1

4 94

[libvirt] [PATCH] docs: stop advertizing FTP or HTTP for downloads of libvirt
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

On the modern internet it is not credible to continue to advertize software downloads over unencrypted connections. Even if users could theoretically use GPG to verify the signatures, not all our downloads and signed and few people know how to correctly verify signatures. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/downloads.html.in | 61 ++++++++++++++---------------------------- 1 file changed, 20 insertions(+), 41 deletions(-) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 657cd6a6f8..0722469eb9 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -27,8 +27,7 @@ <tr> <td>libvirt</td> <td> - <a href="ftp://libvirt.org/libvirt/">ftp</a> - <a href="https://libvirt.org/sources/">https</a> + <a href="https://libvirt.org/sources/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt.git;a=summary">libvirt</a> @@ -48,8 +47,7 @@ <tr> <td>C#</td> <td> - <a href="ftp://libvirt.org/libvirt/csharp/">ftp</a> - <a href="https://libvirt.org/sources/csharp/">https</a> + <a href="https://libvirt.org/sources/csharp/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-csharp.git;a=summary">libvirt</a> @@ -63,8 +61,7 @@ <tr> <td>Go</td> <td> - <a href="ftp://libvirt.org/libvirt/go/">ftp</a> - <a href="https://libvirt.org/sources/go/">https</a> + <a href="https://libvirt.org/sources/go/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-go.git;a=summary">libvirt</a> @@ -80,8 +77,7 @@ <tr> <td>Java</td> <td> - <a href="ftp://libvirt.org/libvirt/java/">ftp</a> - <a href="https://libvirt.org/sources/java/">https</a> + <a href="https://libvirt.org/sources/java/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-java.git;a=summary">libvirt</a> @@ -95,8 +91,7 @@ <tr> <td>OCaml</td> <td> - <a href="ftp://libvirt.org/libvirt/ocaml/">ftp</a> - <a href="https://libvirt.org/sources/ocaml/">https</a> + <a href="https://libvirt.org/sources/ocaml/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-ocaml.git;a=summary">libvirt</a> @@ -127,8 +122,7 @@ <tr> <td>PHP</td> <td> - <a href="ftp://libvirt.org/libvirt/php/">ftp</a> - <a href="https://libvirt.org/sources/php/">https</a> + <a href="https://libvirt.org/sources/php/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-php.git;a=summary">libvirt</a> @@ -142,8 +136,7 @@ <tr> <td>Python</td> <td> - <a href="ftp://libvirt.org/libvirt/python/">ftp</a> - <a href="https://libvirt.org/sources/python/">https</a> + <a href="https://libvirt.org/sources/python/">libvirt</a> <a href="https://pypi.python.org/pypi/libvirt-python">pypi</a> </td> <td> @@ -158,8 +151,7 @@ <tr> <td>Ruby</td> <td> - <a href="ftp://libvirt.org/libvirt/ruby/">ftp</a> - <a href="https://libvirt.org/sources/ruby/">https</a> + <a href="https://libvirt.org/sources/ruby/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=ruby-libvirt.git;a=summary">libvirt</a> @@ -173,8 +165,7 @@ <tr> <td>Rust</td> <td> - <a href="ftp://libvirt.org/libvirt/rust/">ftp</a> - <a href="https://libvirt.org/sources/rust/">https</a> + <a href="https://libvirt.org/sources/rust/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-rust.git;a=summary">libvirt</a> @@ -191,8 +182,7 @@ <tr> <td>GLib / GConfig / GObject</td> <td> - <a href="ftp://libvirt.org/libvirt/glib/">ftp</a> - <a href="https://libvirt.org/sources/glib/">https</a> + <a href="https://libvirt.org/sources/glib/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-glib.git;a=summary">libvirt</a> @@ -206,8 +196,7 @@ <tr> <td>Go XML</td> <td> - <a href="ftp://libvirt.org/libvirt/go/">ftp</a> - <a href="https://libvirt.org/sources/go/">https</a> + <a href="https://libvirt.org/sources/go/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-go-xml.git;a=summary">libvirt</a> @@ -223,8 +212,7 @@ <tr> <td>D-Bus</td> <td> - <a href="ftp://libvirt.org/libvirt/dbus/">ftp</a> - <a href="https://libvirt.org/sources/dbus/">https</a> + <a href="https://libvirt.org/sources/dbus/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-dbus.git;a=summary">libvirt</a> @@ -238,8 +226,7 @@ <tr> <td>Console Proxy</td> <td> - <a href="ftp://libvirt.org/libvirt/consoleproxy/">ftp</a> - <a href="https://libvirt.org/sources/consoleproxy/">https</a> + <a href="https://libvirt.org/sources/consoleproxy/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-console-proxy.git;a=summary">libvirt</a> @@ -253,8 +240,7 @@ <tr> <td>CIM provider</td> <td> - <a href="ftp://libvirt.org/libvirt/CIM/">ftp</a> - <a href="https://libvirt.org/sources/CIM/">https</a> + <a href="https://libvirt.org/sources/CIM/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-cim.git;a=summary">libvirt</a> @@ -268,8 +254,7 @@ <tr> <td>CIM utils</td> <td> - <a href="ftp://libvirt.org/libvirt/CIM/">ftp</a> - <a href="https://libvirt.org/sources/CIM/">https</a> + <a href="https://libvirt.org/sources/CIM/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libcmpiutil.git;a=summary">libvirt</a> @@ -283,8 +268,7 @@ <tr> <td>SNMP</td> <td> - <a href="ftp://libvirt.org/libvirt/snmp/">ftp</a> - <a href="https://libvirt.org/sources/snmp/">https</a> + <a href="https://libvirt.org/sources/snmp/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-snmp.git;a=summary">libvirt</a> @@ -298,8 +282,7 @@ <tr> <td>Application Sandbox</td> <td> - <a href="ftp://libvirt.org/libvirt/sandbox/">ftp</a> - <a href="https://libvirt.org/sources/sandbox/">https</a> + <a href="https://libvirt.org/sources/sandbox/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-sandbox.git;a=summary">libvirt</a> @@ -316,8 +299,7 @@ <tr> <td>TCK</td> <td> - <a href="ftp://libvirt.org/libvirt/tck/">ftp</a> - <a href="https://libvirt.org/sources/tck/">https</a> + <a href="https://libvirt.org/sources/tck/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-tck.git;a=summary">libvirt</a> @@ -422,14 +404,11 @@ <p> Most modules have releases made available for download on the project - site, via FTP, HTTP or HTTPS. Some modules are instead made available - at alternative locations, for example, the Perl binding is made - available only on CPAN. + site via HTTPS. Some modules are instead made available at alternative + locations, for example, the Perl binding is made available only on CPAN. </p> <ul> - <li><a href="ftp://libvirt.org/libvirt/">libvirt.org FTP server</a></li> - <li><a href="https://libvirt.org/sources/">libvirt.org HTTP server</a></li> <li><a href="https://libvirt.org/sources/">libvirt.org HTTPS server</a></li> </ul> -- 2.20.1

2 3

[libvirt] [jenkins-ci PATCH] lcitool: include gdb, strace, lsof & netstat by default
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

When debugging why tests fail it is important to have commonly used tools like gdb, strace, lsof and netstat available. Note that although the entry for FreeBSD is blank for strace and net-tools, the truss (strace equiv) and netstat tools will be present as they are part of the FreeBSD base install. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 14 ++++++++++++++ guests/vars/projects/base.yml | 4 ++++ 2 files changed, 18 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 92681c2..50f07fa 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -164,6 +164,9 @@ mappings: default: gcc FreeBSD: + gdb: + default: gdb + gettext: default: gettext @@ -425,6 +428,9 @@ mappings: rpm: libxslt-devel cross-policy-deb: foreign + lsof: + default: lsof + lvm2: default: lvm2 FreeBSD: @@ -601,6 +607,10 @@ mappings: rpm: netcf-devel cross-policy-deb: skip + net-tools: + default: net-tools + FreeBSD: + numad: default: numad FreeBSD: @@ -868,6 +878,10 @@ mappings: rpm: spice-gtk3-devel cross-policy-deb: foreign + strace: + default: strace + FreeBSD: + sudo: default: sudo diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index 49d4d2e..b3d1d47 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -9,16 +9,20 @@ packages: - chrony - cppi - gcc + - gdb - gettext - git - glibc - libtool - libtoolize + - lsof + - net-tools - make - patch - perl - pkg-config - rpmbuild - screen + - strace - sudo - vim -- 2.19.2

2 1

[libvirt] [python PATCH] rpm: use new python macros for build/install rules
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

The new %py{2,3}_{build,install} macros ensure that the right compiler and linker flags are used when building python modules. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt-python.spec.in | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 5bcf1eb..8dd261f 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -119,19 +119,35 @@ exit 1 %endif %if %{with_python2} +%if 0%{?fedora} >= 29 || 0%{?rhel} >= 8 +%py2_build +%else CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py build %endif +%endif %if %{with_python3} +%if 0%{?fedora} >= 29 || 0%{?rhel} >= 8 +%py3_build +%else CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build %endif +%endif %install %if %{with_python2} +%if 0%{?fedora} || 0%{?rhel} >= 8 +%py2_install +%else %{__python2} setup.py install --skip-build --root=%{buildroot} %endif +%endif %if %{with_python3} +%if 0%{?fedora} || 0%{?rhel} >= 8 +%py3_install +%else %{__python3} setup.py install --skip-build --root=%{buildroot} %endif +%endif %check %if %{with_python2} -- 2.20.1

2 2

[libvirt] [PATCH] docs: update Perl download to point to modern CPAN site
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

The search.cpan.org site is a transparent redirect to metacpan.org these days, so we should just point directly to the new site. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/downloads.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 0722469eb9..e84455ca04 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -105,7 +105,7 @@ <tr> <td>Perl (Sys::Virt)</td> <td> - <a href="http://search.cpan.org/dist/Sys-Virt/">cpan</a> + <a href="https://metacpan.org/release/Sys-Virt/">cpan</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-perl.git;a=summary">libvirt</a> @@ -115,7 +115,7 @@ <a href="https://github.com/libvirt/libvirt-perl">github</a> </td> <td> - <a href="http://search.cpan.org/dist/Sys-Virt/">api ref</a> + <a href="https://metacpan.org/release/Sys-Virt/">api ref</a> <a href="https://libvirt.org/git/?p=libvirt-perl.git;a=blob;f=Changes;hb=HEAD">changes</a> </td> </tr> -- 2.20.1

2 1

[libvirt] [jenkins-ci PATCH] Ensure ca-certificates are installed
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

On Red Hat variant distros ca-certificates gets pulled in automatically by other packages we require. This doesn't happen on Debian and so any use of https URIs fails. This prevents git from cloning submodules over https. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/base.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 50f07fa..b369c0a 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -99,6 +99,10 @@ mappings: bash-completion: default: bash-completion + ca-certificates: + default: ca-certificates + FreeBSD: + ccache: default: ccache CentOS: diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index b3d1d47..a7e572b 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -5,6 +5,7 @@ packages: - autopoint - bash - bash-completion + - ca-certificates - ccache - chrony - cppi -- 2.19.2

2 1

[libvirt] [PATCH libvirt-python v3] Implement virDomainGetStateParams API
by Bjoern Walk 04 Apr '19

04 Apr '19

From: Marc Hartmayer <mhartmay(a)linux.ibm.com> This patch adds the Python binding for the virDomainGetStateParams API. The Python side can be generated automatically, the C side cannot. Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> Signed-off-by: Marc Hartmayer <mhartmay(a)linux.ibm.com> Signed-off-by: Bjoern Walk <bwalk(a)linux.ibm.com> --- generator.py | 1 + libvirt-override-api.xml | 6 +++++ libvirt-override.c | 48 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+) diff --git a/generator.py b/generator.py index ffa3ce56..005be502 100755 --- a/generator.py +++ b/generator.py @@ -496,6 +496,7 @@ skip_impl = ( 'virConnectBaselineHypervisorCPU', 'virDomainGetLaunchSecurityInfo', 'virNodeGetSEVInfo', + 'virDomainGetStateParams', ) lxc_skip_impl = ( diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml index 7f578e01..fab62447 100644 --- a/libvirt-override-api.xml +++ b/libvirt-override-api.xml @@ -754,5 +754,11 @@ <arg name='conn' type='virConnectPtr' info='pointer to hypervisor connection'/> <arg name='flags' type='int' info='unused, always pass 0'/> </function> + <function name='virDomainGetStateParams' file='python'> + <info>Extract domain state and additional information (if available).</info> + <arg name='dom' type='virDomainPtr' info='pointer to the domain'/> + <arg name='flags' type='unsigned int' info='extra flags; not used yet, so callers should always pass 0'/> + <return type='char *' info="dictionary of state data"/> + </function> </symbols> </api> diff --git a/libvirt-override.c b/libvirt-override.c index c5e2908c..e96a35a0 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -9946,6 +9946,51 @@ libvirt_virNodeGetSEVInfo(PyObject *self ATTRIBUTE_UNUSED, #endif /* LIBVIR_CHECK_VERSION(4, 5, 0) */ +#if LIBVIR_CHECK_VERSION(5, 3, 0) +static PyObject * +libvirt_virDomainGetStateParams(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) +{ + PyObject *py_retval = VIR_PY_NONE; + PyObject *pyobj_domain; + virDomainPtr domain; + int state; + int reason; + virTypedParameterPtr params = NULL; + int nparams = 0; + unsigned int flags; + int c_retval; + + if (!PyArg_ParseTuple(args, (char *)"OI:virDomainGetStateParams", + &pyobj_domain, &flags)) + return NULL; + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainGetStateParams(domain, &state, &reason, &params, + &nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval < 0) + goto error; + + if ((py_retval = PyTuple_New(3)) == NULL) + goto error; + + VIR_PY_TUPLE_SET_GOTO(py_retval, 0, libvirt_intWrap(state), error); + VIR_PY_TUPLE_SET_GOTO(py_retval, 1, libvirt_intWrap(reason), error); + VIR_PY_TUPLE_SET_GOTO(py_retval, 2, getPyVirTypedParameter(params, nparams), error); + + return py_retval; + +error: + Py_XDECREF(py_retval); + virTypedParamsFree(params, nparams); + return VIR_PY_NONE; +} +#endif /* LIBVIR_CHECK_VERSION(5, 2, 0) */ + + /************************************************************************ * * * The registration stuff * @@ -10192,6 +10237,9 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainGetLaunchSecurityInfo", libvirt_virDomainGetLaunchSecurityInfo, METH_VARARGS, NULL}, {(char *) "virNodeGetSEVInfo", libvirt_virNodeGetSEVInfo, METH_VARARGS, NULL}, #endif /* LIBVIR_CHECK_VERSION(4, 5, 0) */ +#if LIBVIR_CHECK_VERSION(5, 3, 0) + {(char *) "virDomainGetStateParams", libvirt_virDomainGetStateParams, METH_VARARGS, NULL}, +#endif /* LIBVIR_CHECK_VERSION(5, 3, 0) */ {NULL, NULL, 0, NULL} }; -- 2.19.1

1 0

[libvirt] [PATCH v2 0/3] qemu: don't duplicate suspended events and state changes
by Nikolay Shirokovskiy 03 Apr '19

03 Apr '19

Patches 1 and 2 are already Reviewed-by: John. Patch 3 needs Peter comments. Diff from v1: ============ - minor rebase changes - minor changes according to review [1] PATCH v1 : https://www.redhat.com/archives/libvir-list/2018-October/msg00591.html Nikolay Shirokovskiy (3): qemu: Pass stop reason from qemuProcessStopCPUs to stop handler qemu: Map suspended state reason to suspended event detail qemu: Don't duplicate suspend events and state changes src/qemu/qemu_domain.c | 34 ++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 7 +++++++ src/qemu/qemu_driver.c | 26 +++----------------------- src/qemu/qemu_migration.c | 42 ++++++------------------------------------ src/qemu/qemu_migration.h | 4 ---- src/qemu/qemu_process.c | 38 +++++++++++++++++++++++++------------- 6 files changed, 75 insertions(+), 76 deletions(-) -- 1.8.3.1

3 6