- Devel - libvirt List Archives

[libvirt PATCH] meson: Fix yajl workaround
by Andrea Bolognani 10 Jan '22

10 Jan '22

Recent versions of Meson report WARNING: pkgconfig variable 'cflags' not defined for dependency yajl. which makes sense, because "cflags" is not one of the variables reported by $ pkg-config --print-variables yajl and $ pkg-config --variable=cflags yajl doesn't work either. Use "includedir", which is a proper pkg-config variable, instead. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- meson.build | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index ec7dcffac4..214a3f05eb 100644 --- a/meson.build +++ b/meson.build @@ -1356,17 +1356,18 @@ if yajl_dep.found() # # [1] https://github.com/Homebrew/homebrew-core/pull/74516 if host_machine.system() != 'linux' - cflags = yajl_dep.get_pkgconfig_variable('cflags') - if cflags.contains('include/yajl') + includedir = yajl_dep.get_pkgconfig_variable('includedir') + if includedir.contains('include/yajl') rc = run_command( 'python3', '-c', 'print("@0@".replace("@1@", "@2@"))'.format( - cflags, 'include/yajl', 'include', + includedir, 'include/yajl', 'include', ), check: true, ) + includedir = rc.stdout().strip() yajl_dep = declare_dependency( - compile_args: rc.stdout().strip().split(), + compile_args: [ '-I' + includedir ], dependencies: [ yajl_dep ], ) endif -- 2.31.1

2 2

[PATCH v3 00/12] Add riscv kvm accel support
by Yifei Jiang 10 Jan '22

10 Jan '22

This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. Because of RISC-V KVM has been merged into the Linux master, so this series are changed from RFC to patch. Several steps to use this: 1. Build emulation $ ./configure --target-list=riscv64-softmmu $ make -j$(nproc) 2. Build kernel 3. Build QEMU VM Cross built in riscv toolchain. $ PKG_CONFIG_LIBDIR=<toolchain pkgconfig path> $ export PKG_CONFIG_SYSROOT_DIR=<toolchain sysroot path> $ ./configure --target-list=riscv64-softmmu --enable-kvm \ --cross-prefix=riscv64-linux-gnu- --disable-libiscsi --disable-glusterfs \ --disable-libusb --disable-usb-redir --audio-drv-list= --disable-opengl \ --disable-libxml2 $ make -j$(nproc) 4. Start emulation $ ./qemu-system-riscv64 -M virt -m 4096M -cpu rv64,x-h=true -nographic \ -name guest=riscv-hyp,debug-threads=on \ -smp 4 \ -bios ./fw_jump.bin \ -kernel ./Image \ -drive file=./hyp.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" 5. Start kvm-acceled QEMU VM in emulation $ ./qemu-system-riscv64 -M virt,accel=kvm -m 1024M -cpu host -nographic \ -name guest=riscv-guset \ -smp 2 \ -bios none \ -kernel ./Image \ -drive file=./guest.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" Changes since patch v2 - Create a macro for get and put timer csr. - Remove M-mode PLIC contexts when kvm is enabled. - Add get timer frequency. - Move cpu_host_load to vmstate_kvmtimer. Changes since patch v1 - Rebase on recent commit a216e7cf119c91ffdf5931834a1a030ebea40d70 - Sync-up headers with Linux-5.16-rc4. - Fixbug in kvm_arch_init_vcpu. - Create a macro for get and put regs csr. - Start kernel directly when kvm_enabled. - Use riscv_cpu_set_irq to inject KVM interrupts. - Use the Semihosting Console API for RISC-V kvm handle sbi. - Update vmstate_riscv_cpu version id. Placing kvm_timer into a subsection. Changes since RFC v6 - Rebase on recent commit 8627edfb3f1fca24a96a0954148885c3241c10f8 - Sync-up headers with Linux-5.16-rc1 Changes since RFC v5 - Rebase on QEMU v6.1.0-rc1 and kvm-riscv linux v19. - Move kvm interrupt setting to riscv_cpu_update_mip(). - Replace __u64 with uint64_t. Changes since RFC v4 - Rebase on QEMU v6.0.0-rc2 and kvm-riscv linux v17. - Remove time scaling support as software solution is incomplete. Because it will cause unacceptable performance degradation. and We will post a better solution. - Revise according to Alistair's review comments. - Remove compile time XLEN checks in kvm_riscv_reg_id - Surround TYPE_RISCV_CPU_HOST definition by CONFIG_KVM and share it between RV32 and RV64. - Add kvm-stub.c for reduce unnecessary compilation checks. - Add riscv_setup_direct_kernel() to direct boot kernel for KVM. Changes since RFC v3 - Rebase on QEMU v5.2.0-rc2 and kvm-riscv linux v15. - Add time scaling support(New patches 13, 14 and 15). - Fix the bug that guest vm can't reboot. Changes since RFC v2 - Fix checkpatch error at target/riscv/sbi_ecall_interface.h. - Add riscv migration support. Changes since RFC v1 - Add separate SBI ecall interface header. - Add riscv32 kvm accel support. Yifei Jiang (12): update-linux-headers: Add asm-riscv/kvm.h target/riscv: Add target/riscv/kvm.c to place the public kvm interface target/riscv: Implement function kvm_arch_init_vcpu target/riscv: Implement kvm_arch_get_registers target/riscv: Implement kvm_arch_put_registers target/riscv: Support start kernel directly by KVM target/riscv: Support setting external interrupt by KVM target/riscv: Handle KVM_EXIT_RISCV_SBI exit target/riscv: Add host cpu type target/riscv: Add kvm_riscv_get/put_regs_timer target/riscv: Implement virtual time adjusting with vm state changing target/riscv: Support virtual time context synchronization hw/intc/sifive_plic.c | 8 +- hw/riscv/boot.c | 16 +- hw/riscv/virt.c | 87 +++-- include/hw/riscv/boot.h | 1 + linux-headers/asm-riscv/kvm.h | 128 +++++++ meson.build | 2 + target/riscv/cpu.c | 29 +- target/riscv/cpu.h | 11 + target/riscv/kvm-stub.c | 30 ++ target/riscv/kvm.c | 533 +++++++++++++++++++++++++++++ target/riscv/kvm_riscv.h | 25 ++ target/riscv/machine.c | 30 ++ target/riscv/meson.build | 1 + target/riscv/sbi_ecall_interface.h | 72 ++++ 14 files changed, 944 insertions(+), 29 deletions(-) create mode 100644 linux-headers/asm-riscv/kvm.h create mode 100644 target/riscv/kvm-stub.c create mode 100644 target/riscv/kvm.c create mode 100644 target/riscv/kvm_riscv.h create mode 100644 target/riscv/sbi_ecall_interface.h -- 2.19.1

4 21

[PATCH v7 0/2] remove sysconfig files
by Olaf Hering 07 Jan '22

07 Jan '22

style issues in docs/ and libvirt.spec.in (abologna) rebased to 4b77b194069f048e6efdaf5d363098ae039dc4f5 Olaf Hering (2): remove sysconfig files NEWS: mention removal of sysconfig NEWS.rst | 10 ++++ docs/daemons.rst | 21 ++++++++ docs/remote.html.in | 6 +-- libvirt.spec.in | 69 +++++++++++++++++++------ src/ch/meson.build | 5 -- src/ch/virtchd.service.in | 1 + src/ch/virtchd.sysconf | 3 -- src/interface/meson.build | 5 -- src/interface/virtinterfaced.service.in | 1 + src/interface/virtinterfaced.sysconf | 3 -- src/libxl/meson.build | 5 -- src/libxl/virtxend.service.in | 1 + src/libxl/virtxend.sysconf | 3 -- src/locking/meson.build | 5 -- src/locking/virtlockd.service.in | 1 + src/locking/virtlockd.sysconf | 3 -- src/logging/meson.build | 5 -- src/logging/virtlogd.sysconf | 3 -- src/lxc/meson.build | 5 -- src/lxc/virtlxcd.service.in | 1 + src/lxc/virtlxcd.sysconf | 3 -- src/meson.build | 16 ------ src/network/meson.build | 5 -- src/network/virtnetworkd.service.in | 1 + src/network/virtnetworkd.sysconf | 3 -- src/node_device/meson.build | 5 -- src/node_device/virtnodedevd.service.in | 1 + src/node_device/virtnodedevd.sysconf | 3 -- src/nwfilter/meson.build | 5 -- src/nwfilter/virtnwfilterd.service.in | 1 + src/nwfilter/virtnwfilterd.sysconf | 3 -- src/qemu/meson.build | 5 -- src/qemu/virtqemud.service.in | 7 +++ src/qemu/virtqemud.sysconf | 12 ----- src/remote/libvirtd.service.in | 7 +++ src/remote/libvirtd.sysconf | 21 -------- src/remote/meson.build | 10 ---- src/remote/virtproxyd.service.in | 1 + src/remote/virtproxyd.sysconf | 3 -- src/secret/meson.build | 5 -- src/secret/virtsecretd.service.in | 1 + src/secret/virtsecretd.sysconf | 3 -- src/storage/meson.build | 5 -- src/storage/virtstoraged.service.in | 1 + src/storage/virtstoraged.sysconf | 3 -- src/vbox/meson.build | 5 -- src/vbox/virtvboxd.service.in | 1 + src/vbox/virtvboxd.sysconf | 3 -- src/vz/meson.build | 5 -- src/vz/virtvzd.service.in | 1 + src/vz/virtvzd.sysconf | 3 -- tools/libvirt-guests.sh.in | 40 ++++++++++++++ tools/libvirt-guests.sysconf | 50 ------------------ tools/meson.build | 6 --- 54 files changed, 155 insertions(+), 245 deletions(-) delete mode 100644 src/ch/virtchd.sysconf delete mode 100644 src/interface/virtinterfaced.sysconf delete mode 100644 src/libxl/virtxend.sysconf delete mode 100644 src/locking/virtlockd.sysconf delete mode 100644 src/logging/virtlogd.sysconf delete mode 100644 src/lxc/virtlxcd.sysconf delete mode 100644 src/network/virtnetworkd.sysconf delete mode 100644 src/node_device/virtnodedevd.sysconf delete mode 100644 src/nwfilter/virtnwfilterd.sysconf delete mode 100644 src/qemu/virtqemud.sysconf delete mode 100644 src/remote/libvirtd.sysconf delete mode 100644 src/remote/virtproxyd.sysconf delete mode 100644 src/secret/virtsecretd.sysconf delete mode 100644 src/storage/virtstoraged.sysconf delete mode 100644 src/vbox/virtvboxd.sysconf delete mode 100644 src/vz/virtvzd.sysconf delete mode 100644 tools/libvirt-guests.sysconf

3 8

[PATCH] do not report generic OPERATION_FAILED error when calling virConnectOpenAuth()
by Ani Sinha 07 Jan '22

07 Jan '22

virConnectOpenAuth() calls virConnectOpenInternal(). This later function generates fine grained errors arising from various failure conditions that are more accurate than a "catch all" broader VIR_ERR_OPERATION_FAILED error that the callers of this function generates. Remove the broader error so that more specific errors can be caught and processed. Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/libxl/libxl_migration.c | 3 --- src/qemu/qemu_migration.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 6d0ab4ee28..bc2b5401da 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -1134,9 +1134,6 @@ libxlDomainMigrationSrcPerformP2P(libxlDriverPrivate *driver, virObjectLock(vm); if (dconn == NULL) { - virReportError(VIR_ERR_OPERATION_FAILED, - _("Failed to connect to remote libvirt URI %s: %s"), - dconnuri, virGetLastErrorMessage()); return ret; } diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index b9d7d582f5..2635ef1162 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5145,9 +5145,6 @@ qemuMigrationSrcPerformPeer2Peer(virQEMUDriver *driver, goto cleanup; if (dconn == NULL) { - virReportError(VIR_ERR_OPERATION_FAILED, - _("Failed to connect to remote libvirt URI %s: %s"), - dconnuri, virGetLastErrorMessage()); return -1; } -- 2.25.1

2 2

[PATCH] src: Don't check for retval of g_strsplit()
by Michal Privoznik 07 Jan '22

07 Jan '22

The g_strsplit() function can return NULL if and only if either the input string is NULL or delimiter is NULL or an empty string. In neither of places we call it any of the conditions is true and thus we don't need to check for the return value. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libxl/xen_xl.c | 2 -- src/util/vircgroupv2.c | 2 -- src/util/virprocess.c | 2 -- src/util/virresctrl.c | 2 -- 4 files changed, 8 deletions(-) diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 7604e3d534..869083a1d1 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -265,8 +265,6 @@ xenParseXLCPUID(virConf *conf, virDomainDef *def) } cpuid_pairs = g_strsplit(cpuid_str, ",", 0); - if (!cpuid_pairs) - return -1; if (!cpuid_pairs[0]) return 0; diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c index 4c110940cf..f00a8f154b 100644 --- a/src/util/vircgroupv2.c +++ b/src/util/vircgroupv2.c @@ -286,8 +286,6 @@ virCgroupV2ParseControllersFile(virCgroup *group, virTrimSpaces(contStr, NULL); contList = g_strsplit(contStr, " ", 20); - if (!contList) - return -1; tmp = contList; diff --git a/src/util/virprocess.c b/src/util/virprocess.c index b559a4257e..06767dbf51 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1837,8 +1837,6 @@ virProcessGetSchedInfo(unsigned long long *cpuWait, return -1; lines = g_strsplit(data, "\n", 0); - if (!lines) - return -1; for (i = 0; lines[i] != NULL; i++) { const char *line = lines[i]; diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index edbf078654..fe45ad3c64 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -1646,8 +1646,6 @@ virResctrlAllocParseCacheLine(virResctrlInfo *resctrl, } caches = g_strsplit(tmp, ";", 0); - if (!caches) - return 0; for (next = caches; *next; next++) { if (virResctrlAllocParseProcessCache(resctrl, alloc, level, type, *next) < 0) -- 2.34.1

2 1

[libvirt PATCH 0/2] docs: Replace node.gif with node.png
by Andrea Bolognani 07 Jan '22

07 Jan '22

Andrea Bolognani (2): docs: Update node.svg docs: Replace node.gif with node.png docs/goals.html.in | 2 +- docs/images/meson.build | 2 +- docs/images/node.gif | Bin 1397 -> 0 bytes docs/images/node.png | Bin 0 -> 5532 bytes docs/images/node.svg | 174 +++++++++++++++++++++++++++++++++------- 5 files changed, 145 insertions(+), 33 deletions(-) delete mode 100644 docs/images/node.gif create mode 100644 docs/images/node.png -- 2.31.1

2 4

[libvirt PATCH v3 0/4] docs: Unclutter top-level directory
by Andrea Bolognani 07 Jan '22

07 Jan '22

Changes from [v2]: * drop all changes related to icons. Changes from [v1]: * extend scope to include icons and CSS files. [v2] https://listman.redhat.com/archives/libvir-list/2021-December/msg00828.html [v1] https://listman.redhat.com/archives/libvir-list/2021-December/msg00818.html Andrea Bolognani (4): docs: Drop structures.svg docs: Move all images to a subdirectory docs: Move all CSS files to a subdirectory docs: Move font definitions with other CSS files docs/api.rst | 6 +- docs/{fonts/stylesheet.css => css/fonts.css} | 18 +- docs/{ => css}/generic.css | 0 docs/{ => css}/libvirt.css | 4 +- docs/{ => css}/main.css | 2 +- docs/css/meson.build | 17 ++ docs/{ => css}/mobile.css | 2 +- docs/fonts/meson.build | 1 - docs/goals.html.in | 2 +- docs/{ => images}/event_loop_simple.png | Bin docs/{ => images}/event_loop_simple.svg | 0 docs/{ => images}/event_loop_worker.png | Bin docs/{ => images}/event_loop_worker.svg | 0 docs/{ => images}/libvirt-daemon-arch.png | Bin docs/{ => images}/libvirt-daemon-arch.svg | 0 docs/{ => images}/libvirt-driver-arch.png | Bin docs/{ => images}/libvirt-driver-arch.svg | 0 docs/{ => images}/libvirt-object-model.png | Bin docs/{ => images}/libvirt-object-model.svg | 0 .../libvirt-virConnect-example.png | Bin .../libvirt-virConnect-example.svg | 0 docs/images/meson.build | 24 +++ .../{ => images}/migration-managed-direct.png | Bin .../{ => images}/migration-managed-direct.svg | 0 docs/{ => images}/migration-managed-p2p.png | Bin docs/{ => images}/migration-managed-p2p.svg | 0 docs/{ => images}/migration-native.png | Bin docs/{ => images}/migration-native.svg | 0 docs/{ => images}/migration-tunnel.png | Bin docs/{ => images}/migration-tunnel.svg | 0 .../migration-unmanaged-direct.png | Bin .../migration-unmanaged-direct.svg | 0 docs/{ => images}/node.gif | Bin docs/{ => images}/node.svg | 0 docs/internals.html.in | 2 +- docs/internals/eventloop.html.in | 4 +- docs/meson.build | 18 +- docs/migration.rst | 10 +- docs/page.xsl | 2 +- docs/structures.svg | 187 ------------------ 40 files changed, 69 insertions(+), 230 deletions(-) rename docs/{fonts/stylesheet.css => css/fonts.css} (60%) rename docs/{ => css}/generic.css (100%) rename docs/{ => css}/libvirt.css (98%) rename docs/{ => css}/main.css (68%) create mode 100644 docs/css/meson.build rename docs/{ => css}/mobile.css (95%) rename docs/{ => images}/event_loop_simple.png (100%) rename docs/{ => images}/event_loop_simple.svg (100%) rename docs/{ => images}/event_loop_worker.png (100%) rename docs/{ => images}/event_loop_worker.svg (100%) rename docs/{ => images}/libvirt-daemon-arch.png (100%) rename docs/{ => images}/libvirt-daemon-arch.svg (100%) rename docs/{ => images}/libvirt-driver-arch.png (100%) rename docs/{ => images}/libvirt-driver-arch.svg (100%) rename docs/{ => images}/libvirt-object-model.png (100%) rename docs/{ => images}/libvirt-object-model.svg (100%) rename docs/{ => images}/libvirt-virConnect-example.png (100%) rename docs/{ => images}/libvirt-virConnect-example.svg (100%) create mode 100644 docs/images/meson.build rename docs/{ => images}/migration-managed-direct.png (100%) rename docs/{ => images}/migration-managed-direct.svg (100%) rename docs/{ => images}/migration-managed-p2p.png (100%) rename docs/{ => images}/migration-managed-p2p.svg (100%) rename docs/{ => images}/migration-native.png (100%) rename docs/{ => images}/migration-native.svg (100%) rename docs/{ => images}/migration-tunnel.png (100%) rename docs/{ => images}/migration-tunnel.svg (100%) rename docs/{ => images}/migration-unmanaged-direct.png (100%) rename docs/{ => images}/migration-unmanaged-direct.svg (100%) rename docs/{ => images}/node.gif (100%) rename docs/{ => images}/node.svg (100%) delete mode 100644 docs/structures.svg -- 2.31.1

2 11

[PATCH] virprocess: Provide non-Linux stubs for virProcessGet{Stat, Sched}Info
by Michal Privoznik 07 Jan '22

07 Jan '22

Both virProcessGetStatInfo() and virProcessGetSchedInfo() are Linux centric. Provide stubs for non-Linux platforms. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virprocess.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index c74bd16fe6..5788faea9c 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1766,6 +1766,7 @@ virProcessGetStat(pid_t pid, } +#ifdef __linux__ int virProcessGetStatInfo(unsigned long long *cpuTime, int *lastCpu, @@ -1873,3 +1874,26 @@ virProcessGetSchedInfo(unsigned long long *cpuWait, return 0; } + +#else +int +virProcessGetStatInfo(unsigned long long *cpuTime G_GNUC_UNUSED, + int *lastCpu G_GNUC_UNUSED, + long *vm_rss G_GNUC_UNUSED, + pid_t pid G_GNUC_UNUSED, + pid_t tid G_GNUC_UNUSED) +{ + errno = ENOSYS; + return -1; +} + +int +virProcessGetSchedInfo(unsigned long long *cpuWait G_GNUC_UNUSED, + pid_t pid G_GNUC_UNUSED, + pid_t tid G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("scheduler information is not supported on this platform")); + return -1; +} +#endif /* __linux__ */ -- 2.34.1

6 16

[PATCH] report error when virProcessGetStatInfo() is unable to parse data
by Ani Sinha 07 Jan '22

07 Jan '22

Currently virProcessGetStatInfo() always returns success and only logs error when it is unable to parse the data. Make this function actually report the error and return a negative value in this error scenario. Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/util/virprocess.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index c74bd16fe6..b9f498d5d8 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1783,7 +1783,11 @@ virProcessGetStatInfo(unsigned long long *cpuTime, virStrToLong_ullp(proc_stat[VIR_PROCESS_STAT_STIME], NULL, 10, &systime) < 0 || virStrToLong_l(proc_stat[VIR_PROCESS_STAT_RSS], NULL, 10, &rss) < 0 || virStrToLong_i(proc_stat[VIR_PROCESS_STAT_PROCESSOR], NULL, 10, &cpu) < 0) { - VIR_WARN("cannot parse process status data"); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot parse process status data for pid '%d/%d'"), + (int) pid, (int) tid); + + return -1; } /* We got jiffies -- 2.25.1

2 3

[PATCH v2] report error when virProcessGetStatInfo() is unable to parse data
by Ani Sinha 07 Jan '22

07 Jan '22

Currently virProcessGetStatInfo() always returns success and only logs error when it is unable to parse the data. Make this function actually report the error and return a negative value in this error scenario. Fix the callers so that they do not override the error generated. Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/ch/ch_driver.c | 2 -- src/qemu/qemu_driver.c | 7 +------ src/util/virprocess.c | 6 +++++- 3 files changed, 6 insertions(+), 9 deletions(-) changelog: v2: fixed the callers diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 53e0872207..3cbc668489 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -1073,8 +1073,6 @@ chDomainHelperGetVcpus(virDomainObj *vm, if (virProcessGetStatInfo(&vcpuinfo->cpuTime, &vcpuinfo->cpu, NULL, vm->pid, vcpupid) < 0) { - virReportSystemError(errno, "%s", - _("cannot get vCPU placement & pCPU time")); return -1; } } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4974450333..015ffb2ce7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1359,8 +1359,6 @@ qemuDomainHelperGetVcpus(virDomainObj *vm, if (virProcessGetStatInfo(&vcpuinfo->cpuTime, &vcpuinfo->cpu, NULL, vm->pid, vcpupid) < 0) { - virReportSystemError(errno, "%s", - _("cannot get vCPU placement & pCPU time")); return -1; } } @@ -2521,8 +2519,6 @@ qemuDomainGetInfo(virDomainPtr dom, if (virDomainObjIsActive(vm)) { if (virProcessGetStatInfo(&(info->cpuTime), NULL, NULL, vm->pid, 0) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("cannot read cputime for domain")); goto cleanup; } } @@ -10530,8 +10526,7 @@ qemuDomainMemoryStatsInternal(virQEMUDriver *driver, } if (virProcessGetStatInfo(NULL, NULL, &rss, vm->pid, 0) < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("cannot get RSS for domain")); + return -1; } else { stats[ret].tag = VIR_DOMAIN_MEMORY_STAT_RSS; stats[ret].val = rss; diff --git a/src/util/virprocess.c b/src/util/virprocess.c index c74bd16fe6..b9f498d5d8 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1783,7 +1783,11 @@ virProcessGetStatInfo(unsigned long long *cpuTime, virStrToLong_ullp(proc_stat[VIR_PROCESS_STAT_STIME], NULL, 10, &systime) < 0 || virStrToLong_l(proc_stat[VIR_PROCESS_STAT_RSS], NULL, 10, &rss) < 0 || virStrToLong_i(proc_stat[VIR_PROCESS_STAT_PROCESSOR], NULL, 10, &cpu) < 0) { - VIR_WARN("cannot parse process status data"); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot parse process status data for pid '%d/%d'"), + (int) pid, (int) tid); + + return -1; } /* We got jiffies -- 2.25.1

1 0

[libvirt PATCH v4 00/19] qemu: Introduce hvf domain type for Hypervisor.framework
by Andrea Bolognani 07 Jan '22

07 Jan '22

In order to hopefully address [libvirt#147] at long last, I've picked up Roman's patches from 2018 and attempted to forward-port them. More specifically, I've used the [roolebo/hvf-domain] branch as a starting point, since it seems to contain a few improvements over [v2] and was just easier to pick up. The code is mostly his own, so I've retained the existing authorship information, but I've dropped Reviewed-by tags for commits that have been modified in non-trivial ways. I've applied very minimal style tweaks along the way, but overall I've tried to modify the existing patches as little as possible. I've added a few changes of my own, which I've marked as "fixup!" when I felt that they should be squashed into the previous patch rather than existing as separate commits. The new test cases, such as they are, pass, and no regressions to KVM support appear to have been introduced in the process. I don't currently have access to a machine running macOS, so I can't verify that it's actually possible to start a hardware-accelerated VM. Changes from [v3]: * reintroduced the patch that was missing in the initial version of the forward-port; * converted the documentation to reStructuredText and trimmed it significantly; * reworked virQEMUCapsAccelStr() based on Dan's suggestions; * reworked macOS support in the test suite based on Dan's suggestions; * fixed a few minor issues found while doing the above. Changes from [v2]: * rebased on top of master; * added a couple of simple test cases. Useful links: * GitLab: [abologna/hvf] * CI: [pipeline] [libvirt#147] https://gitlab.com/libvirt/libvirt/-/issues/147 [roolebo/hvf-domain] https://github.com/roolebo/libvirt/tree/hvf-domain [abologna/hvf] https://gitlab.com/abologna/libvirt/-/commits/hvf [pipeline] https://gitlab.com/abologna/libvirt/-/pipelines/443320533 [v3] https://listman.redhat.com/archives/libvir-list/2022-January/msg00131.html [v2] https://listman.redhat.com/archives/libvir-list/2018-November/msg00802.html Andrea Bolognani (6): qemu: Only probe KVM on Linux tests: Introduce testQemuHostOS tests: Add macOS support to testutilsqemu tests: Add macOS support to qemuxml2*test tests: Add HVF test cases fixup! NEWS: Mention Apple Silicon support for HVF Roman Bolshakov (13): qemu: Add KVM CPUs into cache only if KVM is present conf: Add hvf domain type qemu: Define hvf capability qemu: Query hvf capability on macOS qemu: Expose hvf domain type if hvf is supported qemu: Introduce virQEMUCapsAccelStr qemu: Introduce virQEMUCapsTypeIsAccelerated qemu: Introduce virQEMUCapsHaveAccel qemu: Correct CPU capabilities probing for hvf docs: Add hvf on QEMU driver page docs: Note hvf support for domain elements docs: Add support page for libvirt on macOS news: Mention hvf domain type NEWS.rst | 6 + docs/docs.html.in | 3 + docs/drvqemu.rst | 48 +++++- docs/formatdomain.rst | 22 +-- docs/index.html.in | 4 +- docs/macos.rst | 44 ++++++ docs/meson.build | 1 + docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 135 ++++++++++++++-- src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 4 + src/qemu/qemu_process.c | 10 +- .../hvf-aarch64-virt-headless.args | 48 ++++++ .../hvf-aarch64-virt-headless.xml | 45 ++++++ .../hvf-x86_64-q35-headless.args | 47 ++++++ .../hvf-x86_64-q35-headless.x86_64-latest.err | 1 + .../hvf-x86_64-q35-headless.xml | 44 ++++++ tests/qemuxml2argvtest.c | 43 ++++- .../hvf-aarch64-virt-headless.xml | 94 +++++++++++ .../hvf-x86_64-q35-headless.xml | 97 ++++++++++++ tests/qemuxml2xmltest.c | 43 ++++- tests/testutilsqemu.c | 147 ++++++++++++++---- tests/testutilsqemu.h | 10 ++ 25 files changed, 837 insertions(+), 65 deletions(-) create mode 100644 docs/macos.rst create mode 100644 tests/qemuxml2argvdata/hvf-aarch64-virt-headless.args create mode 100644 tests/qemuxml2argvdata/hvf-aarch64-virt-headless.xml create mode 100644 tests/qemuxml2argvdata/hvf-x86_64-q35-headless.args create mode 100644 tests/qemuxml2argvdata/hvf-x86_64-q35-headless.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/hvf-x86_64-q35-headless.xml create mode 100644 tests/qemuxml2xmloutdata/hvf-aarch64-virt-headless.xml create mode 100644 tests/qemuxml2xmloutdata/hvf-x86_64-q35-headless.xml -- 2.31.1

1 19

.conf file setting(s) for packet filtering backend(s)
by Laine Stump 07 Jan '22

07 Jan '22

(this probably will make no sense to anyone who hasn't spent time looking at daemonConfig*, in which case you can go ahead and hit Delete now. At any rate I'm just tossing this out into the void to see if anyone has any ideas/opinions, so in *any* case feel free to hit delete!) Happy New Year! and time for another bit of confused ramblings trying to figure out how to do something that ends up being non-confused and straightforward. I'm currently working on switching the backend of the network driver from using iptables to using nftables. Due to some functionality that is not available with nftables (the rule that fixes up the checksum of DHCP packets which, btw, is only relevant for *very* old guests, e.g. RHEL5), this needs to be opt-in via a config file setting. In the meantime, in order to make this doable in a reasonable amount of time, I am *not* converting the nwfilter driver right away, and when I do it will need its own config file setting for opt-in. I've never before looked at the code for the .conf file settings at all. I had assumed there would be some sort of "pull" API, where code in the drivers could call, e.g. virConfGetString("filter_backend") and it would return the config setting to the caller. But when I look at it, I see that all daemons use the same daemonConfigLoadFile() called from remote_daemon.c:main() (which is shared by all the daemons) and the daemonConfig object that is created to hold the config settings that are read is only visible within main() - the only way that a config setting is used is by main() "pushing" it out to a static variable somewhere else where it is later retrieved by the interested party, e.g. the way that main() calls daemonSetupNetDevOpenvswitch(config), which then sets the static virNetDevOpenvswitchTimeout in util/virnetdevopenvswitch.c. (NB: util/virnetdevopenvswitch.c is linked into every deamon, so even for the daemons that don't use it, calls to virnetdevopenvswitch.c functions still compile properly (and calling them is harmless), so virNetDevOpenvswitchTimeout is set even for daemons that never call openvswitch APIs). If I could count on all builds using split daemons (i.e. separate virtnetworkd and virtnwfilterd) then I could add a similar API in virfirewall.c that remote_daemon.c:main() could use to set "filter_backend" into a static in virfirewall.c (which is used by both drivers) and everything would just happily work: virtnetworkd.conf: filter_backend = nftables virtnwfilterd.conf filter_backend = iptables However, I need to also deal with the possibility that the nwfilter and network drivers are in the same unified libvirtd binary, and in that case both drivers would have the same virfirewall.c:filter_backend setting, thus making it impossible to use the iptables backend for the nwfilter driver and nftables backend for the network driver. For that case I would need separate settings in the config for each driver, e.g. libvirtd.conf: network_filter_backend = nftables nwfilter_backend = iptables and then those would need to be stored off somewhere different for each driver, then they would use it to set the backend for each virFirewall object as it is created. Organizationally, it would make the most sense for these settings (and the API to set them) to be located in the drivers that use them (so, for example, network_filter_backend could live in network/bridge_driver_linux.c and nwfilter_backend could live in nwfilter/nwfilter_driver.c). But that would mean that remote_daemon.c:main() would need to directly call functions in those files, which is a no-no (because, in the case of split daemons, you either have one or the other at build time, but never both). So should I perhaps declare the nftables backend for nwfilter to be a lost cause until everyone moves to split daemons, add a "filter_backend" setting that is directly set in virfirewall.c (by remote_daemon.c:main()), and then provide some sort of override in virFirewallNew so calls from the nwfilter driver can say "ignore the filter_backend setting and use iptables"? Or should we make the virConf APIs beefier, and add facilities to save off the entire daemonConfig object and make its contents available via something like virConfGetString("network_filter_backend")? But if I did that, it would mean two differently-named config entries, and it would certainly be nice if I didn't have to introduce daemon-specific names like this that would need to be carried over from libvirtd.conf into virtnwfilterd.conf and virtnetworkd.conf (where differing names would no longer be required). I suppose I could go "full MS" and introduce the concept of sections to the conf file, so libvirtd.conf could have something like this: [network] filter_backend = nftables [nwfilter] filter_backend = iptables but that seems like a lot of work for something that will be obsolete in a year or so anyway (when the unified daemon is a thing of the past). Am I thinking about details too much and missing an obvious simple solution? (I think until/unless I or someone else comes up with a better idea, I'm going to go with a single filter_backend setting set in virfirewall.c that is somehow overridden when the virFirewall calls come from the nwfilter driver. Then if everyone moves to split daemons before I get around to making the nwfilter driver support nftables, the problem will end up just solving itself; otherwise I can think of some other piece of ugliness to make it work).

2 3

[PATCH] src: Don't check for retval of some glib functions
by Michal Privoznik 07 Jan '22

07 Jan '22

There are a few glib functions that abort on OOM and thus there's no point in checking their retval against NULL. Nevertheless, we do have those checks in a few places. Remove them. Generated using the following spatch: @@ expression x; identifier n; expression r; @@ ( x = g_strdup_printf(...); | x = g_strdup_vprintf(...); | x = g_strdup(...); | x = g_strndup(...); | x = g_new0(...); | x = g_realloc(...); ) ... when != x - if(!x) ( - return r; | - goto n; ) Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/hyperv/hyperv_driver.c | 14 -------------- src/util/virprocess.c | 2 -- 2 files changed, 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 3327f0132e..7b684e04ba 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -482,8 +482,6 @@ hypervDomainAddVirtualDiskParent(virDomainPtr domain, parent__PATH = g_strdup_printf("\\\\%s\\Root\\Virtualization\\V2:" "Msvm_ResourceAllocationSettingData.InstanceID=\"%s\"", hostname, parentInstanceIDEscaped); - if (!parent__PATH) - return -1; if (hypervSetEmbeddedProperty(controllerResource, "Parent", parent__PATH) < 0) return -1; @@ -529,9 +527,6 @@ hypervDomainAddVirtualHardDisk(virDomainPtr domain, "Msvm_ResourceAllocationSettingData.InstanceID=\"%s\"", hostname, vhdInstanceIdEscaped); - if (!vhd__PATH) - return -1; - if (hypervSetEmbeddedProperty(volumeResource, "Parent", vhd__PATH) < 0) return -1; @@ -660,8 +655,6 @@ hypervDomainAttachPhysicalDisk(virDomainPtr domain, controller__PATH = g_strdup_printf("\\\\%s\\Root\\Virtualization\\V2:" "Msvm_ResourceAllocationSettingData.InstanceID=\"%s\"", hostname, controllerInstanceIdEscaped); - if (!controller__PATH) - return -1; if (hypervSetEmbeddedProperty(diskResource, "Parent", controller__PATH) < 0) return -1; @@ -711,8 +704,6 @@ hypervDomainAddOpticalDrive(virDomainPtr domain, parent__PATH = g_strdup_printf("\\\\%s\\Root\\Virtualization\\V2:" "Msvm_ResourceAllocationSettingData.InstanceID=\"%s\"", hostname, parentInstanceIDEscaped); - if (!parent__PATH) - return -1; if (hypervSetEmbeddedProperty(driveResource, "Parent", parent__PATH) < 0) return -1; @@ -756,8 +747,6 @@ hypervDomainAddOpticalDisk(virDomainPtr domain, vhd__PATH = g_strdup_printf("\\\\%s\\Root\\Virtualization\\V2:" "Msvm_ResourceAllocationSettingData.InstanceID=\"%s\"", hostname, vhdInstanceIdEscaped); - if (!vhd__PATH) - return -1; if (hypervSetEmbeddedProperty(volumeResource, "Parent", vhd__PATH) < 0) return -1; @@ -829,9 +818,6 @@ hypervDomainAttachFloppy(virDomainPtr domain, "Msvm_ResourceAllocationSettingData.InstanceID=\"%s\"", hostname, vhdInstanceIdEscaped); - if (!vfd__PATH) - return -1; - if (hypervSetEmbeddedProperty(volumeResource, "Parent", vfd__PATH) < 0) return -1; diff --git a/src/util/virprocess.c b/src/util/virprocess.c index c74bd16fe6..66b20b0a33 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1826,8 +1826,6 @@ virProcessGetSchedInfo(unsigned long long *cpuWait, proc = g_strdup_printf("/proc/%d/task/%d/sched", (int) pid, (int) tid); else proc = g_strdup_printf("/proc/%d/sched", (int) pid); - if (!proc) - return -1; /* The file is not guaranteed to exist (needs CONFIG_SCHED_DEBUG) */ if (access(proc, R_OK) < 0) { -- 2.34.1

2 1

[PATCH] change return type of virURIParamAppend() to void type
by Ani Sinha 07 Jan '22

07 Jan '22

virURIParamAppend() unconditionally returns 0. Simplify and make the return type as void type. Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/util/viruri.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/util/viruri.c b/src/util/viruri.c index 3c73188a55..88bb0cc1f8 100644 --- a/src/util/viruri.c +++ b/src/util/viruri.c @@ -34,7 +34,7 @@ VIR_LOG_INIT("util.uri"); -static int +static void virURIParamAppend(virURI *uri, const char *name, const char *value) @@ -52,7 +52,7 @@ virURIParamAppend(virURI *uri, uri->params[uri->paramsCount].ignore = false; uri->paramsCount++; - return 0; + return; } @@ -113,8 +113,7 @@ virURIParseParams(virURI *uri) } /* Append to the parameter set. */ - if (virURIParamAppend(uri, name, NULLSTR_EMPTY(value)) < 0) - return -1; + virURIParamAppend(uri, name, NULLSTR_EMPTY(value)); next: query = end; -- 2.25.1

2 1

[PATCH] NEWS: Fix indentation
by Andrea Bolognani 07 Jan '22

07 Jan '22

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. NEWS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index 3c06fdde0f..7ee03fde0e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -42,12 +42,12 @@ v8.0.0 (unreleased) as ``VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES`` exposed via ``virsh migrate --copy-storage-synchronous-writes``. - * Introduce TCG domain features + * Introduce TCG domain features Libvirt is now able to set the size of translation block cache size (tb-size) for TCG domains. - * qemu: Add new API to inject a launch secret in a domain + * qemu: Add new API to inject a launch secret in a domain New API ``virDomainSetLaunchSecurityState()`` and virsh command ``domsetlaunchsecstate`` are added to support injecting a launch secret -- 2.31.1

1 0

[PATCH 00/21] qemuxml2*test: Improve handling of capabilities
by Peter Krempa 06 Jan '22

06 Jan '22

This series originally started as an attempt to remove pointless copying of capabilitiy objects in the qemuxml2argvtest which actually took ~40% of the runtime of the test. Obviously few snags and places for improvements were noticed along the way. Peter Krempa (21): qemuProcessPrepareQEMUCaps: Don't clear QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE qemuDomainNeedsFDC: Simplify and improve checking if a machine needs FDC qemuxml2argvtest: Remove redundant floppy controller tests testutilsqemu: Remove unused non-x86 fake machine types tests: qemuxml2argvdata: Remove use of 'pc-1.0' and 'pc-1.2' machine types tests: qemuxml2argvdata: Remove specific q35 machine types from fake-caps tests qemuxml2xmltest: Replace 'interface-server' by 'net-server' test case qemuxml2(argv|xml)test: Enable 'controller-usb-order' for qemuxml2argv and convert it to latest caps qemuxml2(argv|xml)test: Unify usage of DO_TEST_CAPS_LATEST tests: qemuxml2argvdata: Purge versioned i440fx machine types from fake-caps tests qemuhotplugtestdomains: Remove unnecessary use of versioned pc machine types securityselinuxlabeldata: Purge unneeded versioned machine type testutilsqemu: Remove unused fake-caps x86 machine types qemuxml2argvdata: Use proper arch and emulator for x86 real capability tests qemuxml2argvdata: Use proper arch and emulator for aarch64 real capability tests qemuxml2argvtest: Don't insert capabilities into cache twice qemuxml2(xml|argv)test: Test real state of things with 'x86-kvm-32-on-64' qemuxml2argvtest: Enable qemuxml2argv version of 'blkdeviotune' test qemuxml2argvtest: Convert 'missing-machine' to DO_TEST_CAPS_LATEST qemuTestCapsCacheInsert: Extract code for popluating fake machine types qemuTestCapsCacheInsert: Rewrite caps cache insertion src/qemu/qemu_domain.c | 17 +- src/qemu/qemu_process.c | 9 +- ...g-console-compat-2-live+console-virtio.xml | 2 +- .../qemuhotplug-console-compat-2-live.xml | 2 +- tests/qemusecuritytest.c | 3 +- .../audio-alsa-best.x86_64-4.1.0.args | 2 +- .../audio-alsa-best.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-alsa-best.xml | 4 +- .../audio-alsa-full.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-alsa-full.xml | 4 +- .../audio-alsa-minimal.x86_64-4.1.0.args | 2 +- .../audio-alsa-minimal.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-alsa-minimal.xml | 4 +- .../audio-coreaudio-best.x86_64-4.1.0.args | 2 +- .../audio-coreaudio-best.x86_64-latest.args | 2 +- .../qemuxml2argvdata/audio-coreaudio-best.xml | 4 +- .../audio-coreaudio-full.x86_64-latest.args | 2 +- .../qemuxml2argvdata/audio-coreaudio-full.xml | 4 +- .../audio-coreaudio-minimal.x86_64-4.1.0.args | 2 +- ...audio-coreaudio-minimal.x86_64-latest.args | 2 +- .../audio-coreaudio-minimal.xml | 4 +- ...audio-default-nographics.x86_64-4.1.0.args | 2 +- ...udio-default-nographics.x86_64-latest.args | 2 +- .../audio-default-nographics.xml | 4 +- tests/qemuxml2argvdata/audio-default-sdl.args | 2 +- .../audio-default-sdl.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-default-sdl.xml | 4 +- .../qemuxml2argvdata/audio-default-spice.args | 2 +- .../audio-default-spice.x86_64-latest.args | 2 +- .../qemuxml2argvdata/audio-default-spice.xml | 4 +- tests/qemuxml2argvdata/audio-default-vnc.args | 2 +- .../audio-default-vnc.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-default-vnc.xml | 4 +- .../audio-file-best.x86_64-4.1.0.args | 2 +- .../audio-file-best.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-file-best.xml | 4 +- .../audio-file-full.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-file-full.xml | 4 +- .../audio-file-minimal.x86_64-4.1.0.args | 2 +- .../audio-file-minimal.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-file-minimal.xml | 4 +- .../audio-jack-full.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-jack-full.xml | 4 +- .../audio-jack-minimal.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-jack-minimal.xml | 4 +- .../audio-many-backends.x86_64-latest.args | 2 +- .../qemuxml2argvdata/audio-many-backends.xml | 4 +- .../audio-none-best.x86_64-4.1.0.args | 2 +- .../audio-none-best.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-none-best.xml | 4 +- .../audio-none-full.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-none-full.xml | 4 +- .../audio-none-minimal.x86_64-4.1.0.args | 2 +- .../audio-none-minimal.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-none-minimal.xml | 4 +- .../audio-oss-best.x86_64-4.1.0.args | 2 +- .../audio-oss-best.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-oss-best.xml | 4 +- .../audio-oss-full.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-oss-full.xml | 4 +- .../audio-oss-minimal.x86_64-4.1.0.args | 2 +- .../audio-oss-minimal.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-oss-minimal.xml | 4 +- .../audio-pulseaudio-best.x86_64-4.1.0.args | 2 +- .../audio-pulseaudio-best.x86_64-latest.args | 2 +- .../audio-pulseaudio-best.xml | 4 +- .../audio-pulseaudio-full.x86_64-latest.args | 2 +- .../audio-pulseaudio-full.xml | 4 +- ...audio-pulseaudio-minimal.x86_64-4.1.0.args | 2 +- ...udio-pulseaudio-minimal.x86_64-latest.args | 2 +- .../audio-pulseaudio-minimal.xml | 4 +- .../audio-sdl-best.x86_64-4.1.0.args | 2 +- .../audio-sdl-best.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-sdl-best.xml | 4 +- .../audio-sdl-full.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-sdl-full.xml | 4 +- .../audio-sdl-minimal.x86_64-4.1.0.args | 2 +- .../audio-sdl-minimal.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-sdl-minimal.xml | 4 +- .../audio-spice-best.x86_64-4.1.0.args | 2 +- .../audio-spice-best.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-spice-best.xml | 4 +- .../audio-spice-full.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/audio-spice-full.xml | 4 +- .../audio-spice-minimal.x86_64-4.1.0.args | 2 +- .../audio-spice-minimal.x86_64-latest.args | 2 +- .../qemuxml2argvdata/audio-spice-minimal.xml | 4 +- tests/qemuxml2argvdata/bios-nvram-secure.args | 2 +- tests/qemuxml2argvdata/bios-nvram-secure.xml | 2 +- .../blkdeviotune-group-num.x86_64-4.1.0.args | 2 +- .../blkdeviotune-group-num.x86_64-latest.args | 2 +- .../blkdeviotune-group-num.xml | 4 +- .../blkdeviotune-max-length.x86_64-4.1.0.args | 2 +- ...blkdeviotune-max-length.x86_64-latest.args | 2 +- .../blkdeviotune-max-length.xml | 4 +- .../blkdeviotune-max.x86_64-4.1.0.args | 2 +- .../blkdeviotune-max.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/blkdeviotune-max.xml | 4 +- .../blkdeviotune.x86_64-latest.args | 40 ++++ tests/qemuxml2argvdata/blkdeviotune.xml | 4 +- tests/qemuxml2argvdata/boot-floppy-q35.args | 2 +- tests/qemuxml2argvdata/boot-floppy-q35.xml | 2 +- .../qemuxml2argvdata/console-compat-auto.args | 2 +- .../console-compat-auto.x86_64-latest.args | 2 +- .../qemuxml2argvdata/console-compat-auto.xml | 4 +- .../console-compat-chardev.args | 2 +- .../console-compat-chardev.x86_64-latest.args | 2 +- .../console-compat-chardev.xml | 4 +- tests/qemuxml2argvdata/console-compat.args | 2 +- .../console-compat.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/console-compat.xml | 4 +- .../controller-usb-order.x86_64-latest.args | 38 ++++ .../controller-virtio-scsi.x86_64-latest.args | 2 +- .../controller-virtio-scsi.xml | 4 +- .../disk-address-conflict.xml | 4 +- .../disk-aio.x86_64-2.12.0.args | 2 +- .../disk-aio.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-aio.xml | 4 +- .../disk-arm-virtio-sd.aarch64-4.0.0.args | 3 +- .../disk-arm-virtio-sd.aarch64-latest.args | 3 +- tests/qemuxml2argvdata/disk-arm-virtio-sd.xml | 5 +- .../disk-attaching-partition-nosupport.xml | 4 +- .../disk-backing-chains-index.xml | 4 +- ...-backing-chains-noindex.x86_64-2.12.0.args | 2 +- ...-backing-chains-noindex.x86_64-latest.args | 2 +- .../disk-backing-chains-noindex.xml | 4 +- .../disk-blockio.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-blockio.xml | 4 +- .../disk-boot-cdrom.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-boot-cdrom.xml | 4 +- .../disk-boot-disk.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-boot-disk.xml | 4 +- .../disk-cdrom-bus-other.x86_64-latest.args | 2 +- .../qemuxml2argvdata/disk-cdrom-bus-other.xml | 4 +- ...m-empty-network-invalid.x86_64-latest.args | 2 +- .../disk-cdrom-empty-network-invalid.xml | 4 +- .../disk-cdrom.x86_64-2.12.0.args | 2 +- .../disk-cdrom.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom.xml | 4 +- .../disk-device-lun-type-invalid.xml | 4 +- .../disk-error-policy.x86_64-2.12.0.args | 2 +- .../disk-error-policy.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-error-policy.xml | 4 +- .../disk-fdc-incompatible-address.xml | 4 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 42 ---- .../qemuxml2argvdata/disk-floppy-q35-2_11.xml | 38 ---- .../disk-floppy-q35-2_9.x86_64-2.12.0.args | 36 ---- ...rgs => disk-floppy-q35.x86_64-2.12.0.args} | 2 +- ...rgs => disk-floppy-q35.x86_64-latest.args} | 2 +- ...floppy-q35-2_9.xml => disk-floppy-q35.xml} | 2 +- .../disk-floppy-tray.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-floppy-tray.xml | 4 +- .../disk-floppy.x86_64-2.12.0.args | 2 +- .../disk-floppy.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-floppy.xml | 4 +- tests/qemuxml2argvdata/disk-fmt-cow.xml | 4 +- tests/qemuxml2argvdata/disk-fmt-dir.xml | 4 +- tests/qemuxml2argvdata/disk-fmt-iso.xml | 4 +- .../disk-fmt-qcow.x86_64-4.1.0.args | 2 +- .../disk-fmt-qcow.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-fmt-qcow.xml | 4 +- .../disk-geometry.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-geometry.xml | 4 +- .../disk-hostdev-scsi-address-conflict.xml | 4 +- .../disk-ide-incompatible-address.xml | 4 +- .../disk-ide-split.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-ide-split.xml | 4 +- .../disk-ide-wwn.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-ide-wwn.xml | 4 +- .../disk-metadata-cache.x86_64-latest.args | 2 +- .../qemuxml2argvdata/disk-metadata-cache.xml | 4 +- .../disk-missing-target-invalid.xml | 4 +- .../disk-network-gluster.x86_64-2.12.0.args | 2 +- .../disk-network-gluster.x86_64-latest.args | 2 +- .../qemuxml2argvdata/disk-network-gluster.xml | 4 +- ...-network-iscsi-auth-secrettype-invalid.xml | 4 +- ...sk-network-iscsi-auth-wrong-secrettype.xml | 4 +- .../disk-network-iscsi.x86_64-2.12.0.args | 2 +- .../disk-network-iscsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-iscsi.xml | 4 +- .../disk-network-nbd.x86_64-2.12.0.args | 2 +- .../disk-network-nbd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-nbd.xml | 4 +- tests/qemuxml2argvdata/disk-network-nfs.xml | 2 +- ...sk-network-rbd-no-colon.x86_64-latest.args | 2 +- .../disk-network-rbd-no-colon.xml | 4 +- .../disk-network-rbd.x86_64-2.12.0.args | 2 +- .../disk-network-rbd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-rbd.xml | 4 +- .../disk-network-sheepdog.x86_64-2.12.0.args | 2 +- .../disk-network-sheepdog.x86_64-6.0.0.args | 2 +- .../disk-network-sheepdog.xml | 4 +- .../disk-network-source-auth-both.xml | 4 +- ...isk-network-source-auth.x86_64-2.12.0.args | 2 +- ...isk-network-source-auth.x86_64-latest.args | 2 +- .../disk-network-source-auth.xml | 4 +- ...isk-network-tlsx509-nbd.x86_64-2.12.0.args | 1 - .../disk-network-tlsx509-nbd.xml | 2 +- ...sk-network-tlsx509-vxhs.x86_64-2.12.0.args | 1 - .../disk-network-tlsx509-vxhs.xml | 2 +- .../disk-no-boot.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-no-boot.xml | 4 +- .../disk-nvme.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-nvme.xml | 4 +- .../disk-order.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-order.xml | 4 +- .../disk-readonly-disk.x86_64-2.12.0.args | 2 +- .../disk-readonly-disk.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-readonly-disk.xml | 4 +- .../disk-rotation.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-rotation.xml | 4 +- tests/qemuxml2argvdata/disk-same-targets.xml | 4 +- .../disk-sata-device.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-sata-device.xml | 4 +- .../disk-sata-incompatible-address.xml | 4 +- .../disk-scsi-device-auto.x86_64-latest.args | 2 +- .../disk-scsi-device-auto.xml | 4 +- .../disk-scsi-disk-split.x86_64-latest.args | 2 +- .../qemuxml2argvdata/disk-scsi-disk-split.xml | 4 +- .../disk-scsi-disk-vpd-build-error.xml | 4 +- .../disk-scsi-disk-vpd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-scsi-disk-vpd.xml | 4 +- .../disk-scsi-disk-wwn.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-scsi-disk-wwn.xml | 4 +- .../disk-scsi-incompatible-address.xml | 4 +- ...sk-scsi-lun-passthrough.x86_64-latest.args | 2 +- .../disk-scsi-lun-passthrough.xml | 4 +- .../disk-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-scsi.xml | 4 +- .../disk-serial.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-serial.xml | 4 +- tests/qemuxml2argvdata/disk-shared-qcow.xml | 4 +- .../disk-shared.x86_64-2.12.0.args | 2 +- .../disk-shared.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-shared.xml | 4 +- .../disk-slices.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-slices.xml | 4 +- .../disk-snapshot.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-snapshot.xml | 4 +- .../disk-source-pool-mode.x86_64-4.1.0.args | 2 +- .../disk-source-pool-mode.x86_64-latest.args | 2 +- .../disk-source-pool-mode.xml | 4 +- .../disk-source-pool.x86_64-4.1.0.args | 2 +- .../disk-source-pool.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-source-pool.xml | 4 +- .../disk-transient.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-transient.xml | 4 +- ...sk-usb-device-removable.x86_64-latest.args | 2 +- .../disk-usb-device-removable.xml | 4 +- .../disk-usb-device.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-usb-device.xml | 4 +- tests/qemuxml2argvdata/disk-usb-pci.xml | 4 +- tests/qemuxml2argvdata/disk-vhostuser.xml | 2 +- .../disk-virtio-queues.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-virtio-queues.xml | 4 +- ...irtio-scsi-reservations.x86_64-2.12.0.args | 2 +- ...virtio-scsi-reservations.x86_64-5.2.0.args | 2 +- ...irtio-scsi-reservations.x86_64-latest.args | 2 +- .../disk-virtio-scsi-reservations.xml | 4 +- .../disk-virtio.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-virtio.xml | 4 +- .../encrypted-disk-usage.x86_64-4.1.0.args | 2 +- .../encrypted-disk-usage.x86_64-latest.args | 2 +- .../qemuxml2argvdata/encrypted-disk-usage.xml | 4 +- .../encrypted-disk.x86_64-4.1.0.args | 2 +- .../encrypted-disk.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/encrypted-disk.xml | 4 +- .../eoi-disabled.x86_64-4.0.0.args | 4 +- .../eoi-disabled.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/eoi-disabled.xml | 4 +- .../eoi-enabled.x86_64-4.0.0.args | 4 +- .../eoi-enabled.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/eoi-enabled.xml | 4 +- .../fd-memory-no-numa-topology.args | 2 +- .../fd-memory-no-numa-topology.xml | 2 +- .../fd-memory-numa-topology.args | 2 +- .../fd-memory-numa-topology.xml | 2 +- .../fd-memory-numa-topology2.args | 2 +- .../fd-memory-numa-topology2.xml | 2 +- .../fd-memory-numa-topology3.args | 2 +- .../fd-memory-numa-topology3.xml | 2 +- .../fips-enabled.x86_64-5.1.0.args | 2 +- .../fips-enabled.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/fips-enabled.xml | 4 +- .../floppy-drive-fat.x86_64-2.12.0.args | 2 +- .../floppy-drive-fat.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/floppy-drive-fat.xml | 4 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/fs9p.xml | 4 +- ...egl-headless-rendernode.x86_64-latest.args | 2 +- .../graphics-egl-headless-rendernode.xml | 4 +- .../graphics-egl-headless.args | 2 +- .../graphics-egl-headless.x86_64-latest.args | 2 +- .../graphics-egl-headless.xml | 4 +- .../graphics-sdl-egl-headless.xml | 4 +- ...s-spice-agent-file-xfer.x86_64-latest.args | 2 +- .../graphics-spice-agent-file-xfer.xml | 4 +- ...aphics-spice-agentmouse.x86_64-latest.args | 2 +- .../graphics-spice-agentmouse.xml | 4 +- ...s-spice-auto-socket-cfg.x86_64-latest.args | 2 +- .../graphics-spice-auto-socket-cfg.xml | 4 +- ...phics-spice-auto-socket.x86_64-latest.args | 2 +- .../graphics-spice-auto-socket.xml | 4 +- ...phics-spice-compression.x86_64-latest.args | 2 +- .../graphics-spice-compression.xml | 4 +- ...hics-spice-egl-headless.x86_64-latest.args | 2 +- .../graphics-spice-egl-headless.xml | 4 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 2 +- .../graphics-spice-gl-auto-rendernode.xml | 4 +- .../graphics-spice-invalid-egl-headless.xml | 4 +- .../graphics-spice-no-args.x86_64-latest.args | 2 +- .../graphics-spice-no-args.xml | 4 +- .../graphics-spice-qxl-vga.x86_64-latest.args | 2 +- .../graphics-spice-qxl-vga.xml | 4 +- .../graphics-spice-sasl.x86_64-latest.args | 2 +- .../qemuxml2argvdata/graphics-spice-sasl.xml | 4 +- .../graphics-spice-socket.x86_64-latest.args | 2 +- .../graphics-spice-socket.xml | 4 +- .../graphics-spice-timeout.x86_64-latest.args | 2 +- .../graphics-spice-timeout.xml | 4 +- ...raphics-spice-usb-redir.x86_64-latest.args | 2 +- .../graphics-spice-usb-redir.xml | 4 +- .../graphics-spice.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-spice.xml | 4 +- ...ics-vnc-auto-socket-cfg.x86_64-2.11.0.args | 2 +- ...ics-vnc-auto-socket-cfg.x86_64-latest.args | 2 +- .../graphics-vnc-auto-socket-cfg.xml | 4 +- ...raphics-vnc-auto-socket.x86_64-2.11.0.args | 2 +- ...raphics-vnc-auto-socket.x86_64-latest.args | 2 +- .../graphics-vnc-auto-socket.xml | 4 +- ...aphics-vnc-egl-headless.x86_64-2.11.0.args | 2 +- ...aphics-vnc-egl-headless.x86_64-latest.args | 2 +- .../graphics-vnc-egl-headless.xml | 4 +- ...hics-vnc-no-listen-attr.x86_64-2.11.0.args | 2 +- ...hics-vnc-no-listen-attr.x86_64-latest.args | 2 +- .../graphics-vnc-no-listen-attr.xml | 4 +- .../graphics-vnc-none.x86_64-2.11.0.args | 2 +- .../graphics-vnc-none.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-none.xml | 4 +- .../graphics-vnc-policy.x86_64-2.11.0.args | 2 +- .../graphics-vnc-policy.x86_64-latest.args | 2 +- .../qemuxml2argvdata/graphics-vnc-policy.xml | 4 +- .../graphics-vnc-power.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-power.xml | 4 +- ...remove-generated-socket.x86_64-2.11.0.args | 2 +- ...remove-generated-socket.x86_64-latest.args | 2 +- .../graphics-vnc-remove-generated-socket.xml | 4 +- .../graphics-vnc-sasl.x86_64-2.11.0.args | 2 +- .../graphics-vnc-sasl.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-sasl.xml | 4 +- ...-vnc-socket-new-cmdline.x86_64-2.11.0.args | 2 +- ...-vnc-socket-new-cmdline.x86_64-latest.args | 2 +- .../graphics-vnc-socket-new-cmdline.xml | 4 +- .../graphics-vnc-socket.x86_64-2.11.0.args | 2 +- .../graphics-vnc-socket.x86_64-latest.args | 2 +- .../qemuxml2argvdata/graphics-vnc-socket.xml | 4 +- .../graphics-vnc-tls-secret.x86_64-5.2.0.args | 2 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 2 +- .../graphics-vnc-tls-secret.xml | 4 +- .../graphics-vnc-tls.x86_64-2.11.0.args | 2 +- .../graphics-vnc-tls.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-tls.xml | 4 +- .../graphics-vnc-websocket.x86_64-2.11.0.args | 2 +- .../graphics-vnc-websocket.x86_64-latest.args | 2 +- .../graphics-vnc-websocket.xml | 4 +- .../graphics-vnc.x86_64-2.11.0.args | 2 +- .../graphics-vnc.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc.xml | 4 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 2 +- .../hostdev-mdev-display-ramfb.xml | 4 +- ...play-spice-egl-headless.x86_64-latest.args | 2 +- ...ostdev-mdev-display-spice-egl-headless.xml | 4 +- ...ev-display-spice-opengl.x86_64-latest.args | 2 +- .../hostdev-mdev-display-spice-opengl.xml | 4 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 2 +- .../hostdev-mdev-display-vnc-egl-headless.xml | 4 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 2 +- .../hostdev-mdev-display-vnc.xml | 4 +- .../hostdev-scsi-lsi.x86_64-4.1.0.args | 2 +- .../hostdev-scsi-lsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hostdev-scsi-lsi.xml | 4 +- .../hostdev-scsi-vhost-scsi-pci-boot-fail.xml | 4 +- .../hostdev-scsi-vhost-scsi-pcie.args | 2 +- .../hostdev-scsi-vhost-scsi-pcie.xml | 2 +- ...hostdev-scsi-virtio-scsi.x86_64-4.1.0.args | 2 +- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 2 +- .../hostdev-scsi-virtio-scsi.xml | 4 +- .../hostdevs-drive-address-conflict.xml | 4 +- .../hugepages-memaccess3.x86_64-latest.args | 2 +- .../qemuxml2argvdata/hugepages-memaccess3.xml | 2 +- .../hugepages-numa-default-dimm.args | 2 +- .../hugepages-numa-default-dimm.xml | 2 +- .../hugepages-numa-default.args | 2 +- .../hugepages-numa-default.xml | 2 +- .../hugepages-nvdimm.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hugepages-nvdimm.xml | 4 +- .../hyperv-off.x86_64-4.0.0.args | 2 +- .../hyperv-off.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hyperv-off.xml | 4 +- .../hyperv-panic.x86_64-4.0.0.args | 4 +- .../hyperv-panic.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hyperv-panic.xml | 4 +- .../hyperv-passthrough.x86_64-6.1.0.args | 2 +- .../hyperv-passthrough.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hyperv-passthrough.xml | 4 +- .../hyperv-stimer-direct.x86_64-latest.args | 2 +- .../qemuxml2argvdata/hyperv-stimer-direct.xml | 4 +- .../qemuxml2argvdata/hyperv.x86_64-4.0.0.args | 4 +- .../hyperv.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hyperv.xml | 4 +- .../input-linux.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/input-linux.xml | 4 +- tests/qemuxml2argvdata/interface-server.xml | 131 ------------ ...othreads-virtio-scsi-pci.x86_64-5.2.0.args | 2 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 2 +- .../iothreads-virtio-scsi-pci.xml | 4 +- .../kvmclock+eoi-disabled.x86_64-4.0.0.args | 4 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 2 +- .../kvmclock+eoi-disabled.xml | 4 +- ...v-missing-platform-info.x86_64-2.12.0.args | 2 +- ...nch-security-sev-missing-platform-info.xml | 2 +- .../luks-disks.x86_64-4.1.0.args | 1 + tests/qemuxml2argvdata/luks-disks.xml | 5 +- .../memfd-memory-default-hugepage.xml | 5 +- tests/qemuxml2argvdata/memfd-memory-numa.xml | 5 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-access.xml | 4 +- ...ory-hotplug-nvdimm-align.x86_64-5.2.0.args | 2 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-align.xml | 4 +- ...ory-hotplug-nvdimm-label.x86_64-5.2.0.args | 2 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-label.xml | 4 +- ...mory-hotplug-nvdimm-pmem.x86_64-5.2.0.args | 2 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-pmem.xml | 4 +- ...-hotplug-nvdimm-readonly.x86_64-5.2.0.args | 2 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-readonly.xml | 4 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm.xml | 4 +- ...mory-hotplug-virtio-mem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-mem.xml | 2 +- ...mory-hotplug-virtio-pmem.x86_64-5.2.0.args | 2 +- ...ory-hotplug-virtio-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-pmem.xml | 2 +- .../misc-no-reboot.x86_64-5.2.0.args | 2 +- .../misc-no-reboot.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/misc-no-reboot.xml | 4 +- tests/qemuxml2argvdata/missing-machine.err | 1 - .../missing-machine.x86_64-latest.err | 1 + tests/qemuxml2argvdata/missing-machine.xml | 2 +- .../mlock-off.x86_64-3.0.0.args | 2 +- .../mlock-off.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/mlock-off.xml | 4 +- .../mlock-on.x86_64-3.0.0.args | 2 +- .../mlock-on.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/mlock-on.xml | 4 +- .../name-escape.x86_64-2.11.0.args | 2 +- .../name-escape.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/name-escape.xml | 4 +- tests/qemuxml2argvdata/net-user.args | 2 +- .../net-user.x86_64-4.0.0.args | 2 +- tests/qemuxml2argvdata/net-user.xml | 4 +- .../net-vdpa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/net-vdpa.xml | 4 +- tests/qemuxml2argvdata/net-vhostuser.args | 2 +- .../net-vhostuser.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/net-vhostuser.xml | 4 +- .../qemuxml2argvdata/pages-dimm-discard.args | 2 +- tests/qemuxml2argvdata/pages-dimm-discard.xml | 2 +- .../panic-double.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/panic-double.xml | 4 +- .../panic-no-address.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/panic-no-address.xml | 4 +- .../qemuxml2argvdata/panic.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/panic.xml | 4 +- .../parallel-parport-chardev.args | 2 +- ...arallel-parport-chardev.x86_64-latest.args | 2 +- .../parallel-parport-chardev.xml | 4 +- .../parallel-tcp-chardev.args | 2 +- .../parallel-tcp-chardev.x86_64-latest.args | 2 +- .../qemuxml2argvdata/parallel-tcp-chardev.xml | 4 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 2 +- tests/qemuxml2argvdata/pci-autoadd-addr.xml | 2 +- tests/qemuxml2argvdata/pci-autoadd-idx.args | 2 +- tests/qemuxml2argvdata/pci-autoadd-idx.xml | 2 +- tests/qemuxml2argvdata/pci-autofill-addr.args | 2 +- tests/qemuxml2argvdata/pci-autofill-addr.xml | 2 +- .../pci-bridge-duplicate-index.xml | 2 +- .../pci-bridge-many-disks.args | 2 +- .../pci-bridge-many-disks.xml | 2 +- .../pci-bridge-negative-index-invalid.xml | 2 +- tests/qemuxml2argvdata/pci-bridge.args | 2 +- tests/qemuxml2argvdata/pci-bridge.xml | 2 +- .../pci-expander-bus-bad-bus.xml | 2 +- .../pci-expander-bus-bad-node.xml | 2 +- tests/qemuxml2argvdata/pci-expander-bus.args | 2 +- tests/qemuxml2argvdata/pci-expander-bus.xml | 2 +- tests/qemuxml2argvdata/pci-many.args | 2 +- tests/qemuxml2argvdata/pci-many.xml | 2 +- tests/qemuxml2argvdata/pci-root-address.xml | 2 +- .../pci-root-nonzero-index.xml | 2 +- .../pci-serial-dev-chardev.args | 2 +- .../pci-serial-dev-chardev.x86_64-latest.args | 2 +- .../pci-serial-dev-chardev.xml | 4 +- .../pcie-expander-bus-bad-machine.xml | 2 +- tests/qemuxml2argvdata/pcihole64-gib.xml | 2 +- tests/qemuxml2argvdata/pcihole64-none.xml | 2 +- tests/qemuxml2argvdata/pcihole64.args | 2 +- tests/qemuxml2argvdata/pcihole64.xml | 2 +- .../pv-spinlock-disabled.x86_64-4.0.0.args | 4 +- .../pv-spinlock-disabled.x86_64-latest.args | 2 +- .../qemuxml2argvdata/pv-spinlock-disabled.xml | 4 +- .../pv-spinlock-enabled.x86_64-4.0.0.args | 4 +- .../pv-spinlock-enabled.x86_64-latest.args | 2 +- .../qemuxml2argvdata/pv-spinlock-enabled.xml | 4 +- .../q35-pm-disable-fallback.args | 2 +- .../q35-pm-disable-fallback.xml | 2 +- tests/qemuxml2argvdata/q35-pm-disable.args | 2 +- tests/qemuxml2argvdata/q35-pm-disable.xml | 2 +- .../q35-virt-manager-basic.args | 2 +- .../q35-virt-manager-basic.xml | 2 +- .../qemu-ns.x86_64-4.0.0.args | 2 +- .../qemu-ns.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/qemu-ns.xml | 4 +- .../seclabel-dynamic-none-relabel.xml | 2 +- .../serial-dev-chardev-iobase.args | 2 +- ...rial-dev-chardev-iobase.x86_64-latest.args | 2 +- .../serial-dev-chardev-iobase.xml | 4 +- .../qemuxml2argvdata/serial-dev-chardev.args | 2 +- .../serial-dev-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-dev-chardev.xml | 4 +- .../qemuxml2argvdata/serial-file-chardev.args | 2 +- .../serial-file-chardev.x86_64-latest.args | 2 +- .../qemuxml2argvdata/serial-file-chardev.xml | 4 +- tests/qemuxml2argvdata/serial-file-log.args | 2 +- .../serial-file-log.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-file-log.xml | 4 +- .../qemuxml2argvdata/serial-many-chardev.args | 2 +- .../serial-many-chardev.x86_64-latest.args | 2 +- .../qemuxml2argvdata/serial-many-chardev.xml | 4 +- .../qemuxml2argvdata/serial-pty-chardev.args | 2 +- .../serial-pty-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-pty-chardev.xml | 4 +- .../serial-spiceport-nospice.args | 2 +- ...erial-spiceport-nospice.x86_64-latest.args | 2 +- .../serial-spiceport-nospice.xml | 4 +- tests/qemuxml2argvdata/serial-spiceport.args | 2 +- .../serial-spiceport.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-spiceport.xml | 4 +- .../qemuxml2argvdata/serial-tcp-chardev.args | 2 +- .../serial-tcp-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-tcp-chardev.xml | 4 +- .../serial-tcp-telnet-chardev.args | 2 +- ...rial-tcp-telnet-chardev.x86_64-latest.args | 2 +- .../serial-tcp-telnet-chardev.xml | 4 +- .../serial-tcp-tlsx509-chardev-notls.args | 2 +- ...p-tlsx509-chardev-notls.x86_64-latest.args | 2 +- .../serial-tcp-tlsx509-chardev-notls.xml | 4 +- .../serial-tcp-tlsx509-chardev-verify.args | 2 +- ...-tlsx509-chardev-verify.x86_64-latest.args | 2 +- .../serial-tcp-tlsx509-chardev-verify.xml | 4 +- .../serial-tcp-tlsx509-chardev.args | 2 +- ...ial-tcp-tlsx509-chardev.x86_64-latest.args | 2 +- .../serial-tcp-tlsx509-chardev.xml | 4 +- .../serial-tcp-tlsx509-secret-chardev.args | 2 +- ...-tlsx509-secret-chardev.x86_64-latest.args | 2 +- .../serial-tcp-tlsx509-secret-chardev.xml | 4 +- .../qemuxml2argvdata/serial-udp-chardev.args | 2 +- .../serial-udp-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-udp-chardev.xml | 4 +- .../qemuxml2argvdata/serial-unix-chardev.args | 2 +- .../serial-unix-chardev.x86_64-latest.args | 2 +- .../qemuxml2argvdata/serial-unix-chardev.xml | 4 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 2 +- .../serial-vc-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-vc-chardev.xml | 4 +- tests/qemuxml2argvdata/user-aliases-usb.args | 2 +- tests/qemuxml2argvdata/user-aliases-usb.xml | 2 +- tests/qemuxml2argvdata/user-aliases.args | 2 +- tests/qemuxml2argvdata/user-aliases.xml | 2 +- tests/qemuxml2argvdata/user-aliases2.xml | 2 +- .../vcpu-placement-static.args | 2 +- .../vcpu-placement-static.xml | 2 +- ...host-user-gpu-secondary.x86_64-latest.args | 2 +- .../vhost-user-gpu-secondary.xml | 4 +- .../vhost-user-vga.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vhost-user-vga.xml | 4 +- tests/qemuxml2argvdata/vhost-vsock.xml | 5 +- ...eo-bochs-display-device.x86_64-latest.args | 2 +- .../video-bochs-display-device.xml | 4 +- ...o-qxl-sec-device-vram64.x86_64-latest.args | 2 +- .../video-qxl-sec-device-vram64.xml | 4 +- ...video-ramfb-display-device-pci-address.xml | 4 +- ...eo-ramfb-display-device.x86_64-latest.args | 2 +- .../video-ramfb-display-device.xml | 4 +- .../watchdog-device.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/watchdog-device.xml | 4 +- .../watchdog-dump.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/watchdog-dump.xml | 4 +- .../watchdog-injectnmi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/watchdog-injectnmi.xml | 4 +- .../watchdog.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/watchdog.xml | 4 +- ...gs => x86-kvm-32-on-64.x86_64-latest.args} | 14 +- tests/qemuxml2argvtest.c | 39 ++-- ...audio-default-nographics.x86_64-latest.xml | 4 +- .../audio-default-sdl.x86_64-latest.xml | 4 +- .../audio-default-spice.x86_64-latest.xml | 4 +- .../audio-default-vnc.x86_64-latest.xml | 4 +- .../blkdeviotune.x86_64-latest.xml | 4 +- .../console-compat-auto.xml | 4 +- tests/qemuxml2xmloutdata/console-compat.xml | 4 +- ...=> controller-usb-order.x86_64-latest.xml} | 3 + .../controller-virtio-scsi.xml | 4 +- tests/qemuxml2xmloutdata/disk-aio.xml | 4 +- .../disk-arm-virtio-sd.aarch64-latest.xml | 5 +- .../disk-backing-chains-index-active.xml | 4 +- .../disk-backing-chains-index-inactive.xml | 4 +- .../disk-backing-chains-noindex.xml | 4 +- tests/qemuxml2xmloutdata/disk-boot-cdrom.xml | 4 +- tests/qemuxml2xmloutdata/disk-boot-disk.xml | 4 +- .../disk-cdrom-bus-other.xml | 4 +- ...om-empty-network-invalid.x86_64-latest.xml | 4 +- tests/qemuxml2xmloutdata/disk-cdrom.xml | 4 +- .../qemuxml2xmloutdata/disk-error-policy.xml | 4 +- tests/qemuxml2xmloutdata/disk-floppy.xml | 4 +- tests/qemuxml2xmloutdata/disk-fmt-qcow.xml | 4 +- .../disk-metadata-cache.x86_64-latest.xml | 4 +- .../disk-network-gluster.xml | 4 +- .../qemuxml2xmloutdata/disk-network-iscsi.xml | 4 +- tests/qemuxml2xmloutdata/disk-network-nbd.xml | 4 +- ...isk-network-nfs-inactive.x86_64-latest.xml | 2 +- .../disk-network-nfs.x86_64-latest.xml | 2 +- tests/qemuxml2xmloutdata/disk-network-rbd.xml | 4 +- .../disk-network-sheepdog.xml | 4 +- .../disk-network-source-auth.xml | 4 +- .../disk-network-tlsx509-nbd.xml | 2 +- .../disk-network-tlsx509-vxhs.xml | 2 +- .../disk-rotation.x86_64-latest.xml | 4 +- .../disk-scsi-device-auto.xml | 4 +- .../qemuxml2xmloutdata/disk-scsi-disk-vpd.xml | 4 +- .../disk-scsi.x86_64-latest.xml | 4 +- tests/qemuxml2xmloutdata/disk-serial.xml | 4 +- .../disk-slices.x86_64-latest.xml | 4 +- .../disk-source-pool-mode.xml | 4 +- tests/qemuxml2xmloutdata/disk-source-pool.xml | 4 +- .../disk-transient.x86_64-latest.xml | 4 +- tests/qemuxml2xmloutdata/disk-usb-device.xml | 4 +- .../disk-vhostuser.x86_64-latest.xml | 2 +- tests/qemuxml2xmloutdata/disk-virtio.xml | 4 +- tests/qemuxml2xmloutdata/encrypted-disk.xml | 4 +- tests/qemuxml2xmloutdata/eoi-disabled.xml | 4 +- tests/qemuxml2xmloutdata/eoi-enabled.xml | 4 +- tests/qemuxml2xmloutdata/floppy-drive-fat.xml | 4 +- .../graphics-egl-headless-rendernode.xml | 4 +- ...cs-spice-auto-socket-cfg.x86_64-latest.xml | 4 +- ...aphics-spice-auto-socket.x86_64-latest.xml | 4 +- ...aphics-spice-compression.x86_64-latest.xml | 4 +- ...phics-spice-egl-headless.x86_64-latest.xml | 4 +- .../graphics-spice-qxl-vga.x86_64-latest.xml | 4 +- .../graphics-spice-socket.x86_64-latest.xml | 4 +- .../graphics-spice-timeout.x86_64-latest.xml | 4 +- .../graphics-spice.x86_64-latest.xml | 4 +- .../graphics-vnc-auto-socket-cfg.xml | 4 +- .../graphics-vnc-auto-socket.xml | 4 +- .../graphics-vnc-egl-headless.xml | 4 +- .../graphics-vnc-no-listen-attr.xml | 4 +- ...ics-vnc-remove-generated-socket-active.xml | 4 +- ...s-vnc-remove-generated-socket-inactive.xml | 4 +- .../qemuxml2xmloutdata/graphics-vnc-sasl.xml | 4 +- .../graphics-vnc-socket.xml | 4 +- tests/qemuxml2xmloutdata/graphics-vnc-tls.xml | 4 +- .../graphics-vnc-websocket.xml | 4 +- tests/qemuxml2xmloutdata/graphics-vnc.xml | 4 +- ...stdev-mdev-display-ramfb.x86_64-latest.xml | 4 +- tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 4 +- .../hostdev-scsi-vhost-scsi-pcie.xml | 2 +- .../hostdev-scsi-virtio-scsi.xml | 4 +- tests/qemuxml2xmloutdata/hyperv-off.xml | 4 +- tests/qemuxml2xmloutdata/hyperv-panic.xml | 4 +- .../qemuxml2xmloutdata/hyperv-passthrough.xml | 4 +- .../hyperv-stimer-direct.xml | 4 +- tests/qemuxml2xmloutdata/hyperv.xml | 4 +- tests/qemuxml2xmloutdata/interface-server.xml | 138 ------------ .../iothreads-virtio-scsi-pci.xml | 4 +- ...ml => luks-disks-source.x86_64-latest.xml} | 5 +- ...disks.xml => luks-disks.x86_64-latest.xml} | 0 ...memory-default-hugepage.x86_64-latest.xml} | 0 ...ml => memfd-memory-numa.x86_64-latest.xml} | 0 tests/qemuxml2xmloutdata/misc-no-reboot.xml | 4 +- tests/qemuxml2xmloutdata/net-server.xml | 43 ++++ tests/qemuxml2xmloutdata/net-user.xml | 4 +- tests/qemuxml2xmloutdata/net-vdpa.xml | 4 +- tests/qemuxml2xmloutdata/net-vhostuser.xml | 4 +- tests/qemuxml2xmloutdata/panic-double.xml | 4 +- tests/qemuxml2xmloutdata/panic-no-address.xml | 4 +- tests/qemuxml2xmloutdata/panic.xml | 4 +- tests/qemuxml2xmloutdata/pci-autoadd-addr.xml | 2 +- tests/qemuxml2xmloutdata/pci-autoadd-idx.xml | 2 +- .../qemuxml2xmloutdata/pci-autofill-addr.xml | 2 +- .../pci-bridge-many-disks.xml | 2 +- tests/qemuxml2xmloutdata/pci-bridge.xml | 2 +- tests/qemuxml2xmloutdata/pci-expander-bus.xml | 2 +- tests/qemuxml2xmloutdata/pci-many.xml | 2 +- .../pci-serial-dev-chardev.xml | 4 +- tests/qemuxml2xmloutdata/pcihole64-gib.xml | 2 +- tests/qemuxml2xmloutdata/pcihole64-none.xml | 2 +- tests/qemuxml2xmloutdata/pcihole64.xml | 2 +- .../pv-spinlock-disabled.xml | 4 +- .../pv-spinlock-enabled.xml | 4 +- .../q35-virt-manager-basic.xml | 2 +- .../qemu-ns.x86_64-latest.xml | 4 +- ...seclabel-dynamic-none-relabel-inactive.xml | 2 +- .../serial-spiceport-nospice.xml | 4 +- tests/qemuxml2xmloutdata/serial-spiceport.xml | 4 +- .../serial-tcp-tlsx509-chardev.xml | 4 +- ...l => tseg-explicit-size.x86_64-latest.xml} | 29 ++- ...xml => vhost-vsock-auto.x86_64-latest.xml} | 5 +- ...sock.xml => vhost-vsock.x86_64-latest.xml} | 0 tests/qemuxml2xmloutdata/watchdog.xml | 4 +- .../x86-kvm-32-on-64.x86_64-latest.xml | 27 +++ tests/qemuxml2xmltest.c | 39 +--- tests/securityselinuxlabeldata/chardev.xml | 2 +- tests/securityselinuxlabeldata/disks.xml | 2 +- tests/securityselinuxlabeldata/kernel.xml | 2 +- tests/securityselinuxlabeldata/nfs.xml | 2 +- tests/testutilsqemu.c | 198 +++++++++++------- tests/vircapstest.c | 6 - 730 files changed, 1362 insertions(+), 1575 deletions(-) create mode 100644 tests/qemuxml2argvdata/blkdeviotune.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/controller-usb-order.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_11.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_11.xml delete mode 100644 tests/qemuxml2argvdata/disk-floppy-q35-2_9.x86_64-2.12.0.args rename tests/qemuxml2argvdata/{disk-floppy-q35-2_11.x86_64-2.12.0.args => disk-floppy-q35.x86_64-2.12.0.args} (96%) rename tests/qemuxml2argvdata/{disk-floppy-q35-2_9.x86_64-latest.args => disk-floppy-q35.x86_64-latest.args} (96%) rename tests/qemuxml2argvdata/{disk-floppy-q35-2_9.xml => disk-floppy-q35.xml} (95%) delete mode 100644 tests/qemuxml2argvdata/interface-server.xml delete mode 100644 tests/qemuxml2argvdata/missing-machine.err create mode 100644 tests/qemuxml2argvdata/missing-machine.x86_64-latest.err rename tests/qemuxml2argvdata/{x86-kvm-32-on-64.args => x86-kvm-32-on-64.x86_64-latest.args} (53%) rename tests/qemuxml2xmloutdata/{controller-usb-order.xml => controller-usb-order.x86_64-latest.xml} (93%) delete mode 100644 tests/qemuxml2xmloutdata/interface-server.xml rename tests/qemuxml2xmloutdata/{luks-disks-source.xml => luks-disks-source.x86_64-latest.xml} (95%) rename tests/qemuxml2xmloutdata/{luks-disks.xml => luks-disks.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{memfd-memory-default-hugepage.xml => memfd-memory-default-hugepage.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{memfd-memory-numa.xml => memfd-memory-numa.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/net-server.xml rename tests/qemuxml2xmloutdata/{tseg-explicit-size.xml => tseg-explicit-size.x86_64-latest.xml} (61%) rename tests/qemuxml2xmloutdata/{vhost-vsock-auto.xml => vhost-vsock-auto.x86_64-latest.xml} (88%) rename tests/qemuxml2xmloutdata/{vhost-vsock.xml => vhost-vsock.x86_64-latest.xml} (100%) create mode 100644 tests/qemuxml2xmloutdata/x86-kvm-32-on-64.x86_64-latest.xml -- 2.31.1

2 42

[PATCH] Make virConnectOpenInternal() report error in all cases
by Ani Sinha 06 Jan '22

06 Jan '22

virConnectOpenInternal() does not report error in all failure scenarios, except in some specific cases. This inconsistent behavior forces the caller of this function report a generic error for all failure modes which then hides specific error scenarios. This change makes virConnectOpenInternal() report failure in all cases so that it can generate specific errors based on the type of failure encountered. The reporiting of the errors can be made more fine grained in subsequent changes. Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/libvirt.c | 24 ++++++++++++++++-------- src/libxl/libxl_migration.c | 3 --- src/qemu/qemu_migration.c | 3 --- 3 files changed, 16 insertions(+), 14 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 45315f484c..53ceee1359 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -893,8 +893,12 @@ virConnectOpenInternal(const char *name, bool embed = false; ret = virGetConnect(); - if (ret == NULL) + if (ret == NULL) { + virReportError(VIR_ERR_INVALID_CONN, + _("Failed to create connection object for URI %s"), + NULLSTR(name)); return NULL; + } if (virConfLoadConfig(&conf, "libvirt.conf") < 0) goto failed; @@ -974,7 +978,7 @@ virConnectOpenInternal(const char *name, virReportError(VIR_ERR_NO_CONNECT, _("URI '%s' does not include a driver name"), name); - goto failed; + goto failed_no_report; } if (virConnectCheckURIMissingSlash(uristr, @@ -992,7 +996,7 @@ virConnectOpenInternal(const char *name, virReportError(VIR_ERR_NO_CONNECT, _("URI scheme '%s' for embedded driver is not valid"), ret->uri->scheme); - goto failed; + goto failed_no_report; } root = virURIGetParam(ret->uri, "root"); @@ -1002,7 +1006,7 @@ virConnectOpenInternal(const char *name, if (!g_path_is_absolute(root)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("root path must be absolute")); - goto failed; + goto failed_no_report; } if (virEventRequireImpl() < 0) @@ -1062,7 +1066,7 @@ virConnectOpenInternal(const char *name, __FILE__, __FUNCTION__, __LINE__, _("libvirt was built without the '%s' driver"), ret->uri->scheme); - goto failed; + goto failed_no_report; } VIR_DEBUG("trying driver %zu (%s) ...", @@ -1112,13 +1116,13 @@ virConnectOpenInternal(const char *name, virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Driver %s cannot be used in embedded mode"), virConnectDriverTab[i]->hypervisorDriver->name); - goto failed; + goto failed_no_report; } /* before starting the new connection, check if the driver only works * with a server, and so return an error if the server is missing */ if (virConnectDriverTab[i]->remoteOnly && ret->uri && !ret->uri->server) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("URI is missing the server part")); - goto failed; + goto failed_no_report; } ret->driver = virConnectDriverTab[i]->hypervisorDriver; @@ -1155,7 +1159,7 @@ virConnectOpenInternal(const char *name, if (!ret->driver) { /* If we reach here, then all drivers declined the connection. */ virReportError(VIR_ERR_NO_CONNECT, "%s", NULLSTR(name)); - goto failed; + goto failed_no_report; } VIR_FREE(uristr); @@ -1163,6 +1167,10 @@ virConnectOpenInternal(const char *name, return ret; failed: + virReportError(VIR_ERR_OPERATION_FAILED, + _("Failed to connect to remote libvirt URI %s"), + NULLSTR(uristr)); + failed_no_report: VIR_FREE(uristr); virObjectUnref(ret); diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 6d0ab4ee28..bc2b5401da 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -1134,9 +1134,6 @@ libxlDomainMigrationSrcPerformP2P(libxlDriverPrivate *driver, virObjectLock(vm); if (dconn == NULL) { - virReportError(VIR_ERR_OPERATION_FAILED, - _("Failed to connect to remote libvirt URI %s: %s"), - dconnuri, virGetLastErrorMessage()); return ret; } diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index b9d7d582f5..2635ef1162 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5145,9 +5145,6 @@ qemuMigrationSrcPerformPeer2Peer(virQEMUDriver *driver, goto cleanup; if (dconn == NULL) { - virReportError(VIR_ERR_OPERATION_FAILED, - _("Failed to connect to remote libvirt URI %s: %s"), - dconnuri, virGetLastErrorMessage()); return -1; } -- 2.25.1

4 4

[PATCH v2 0/2] qemu: Work around qemu not sending DEVICE_DELETED when device is configured via JSON
by Peter Krempa 06 Jan '22

06 Jan '22

QEMU fix was posted https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg00542.html I'll hold off this version until just before the freeze. In case the qemu commit gets merged we can avoid some of the churn by adding in-progress qemu caps and updating to it. Note that I've trimmed patch 1 when sent to the list. See them in full at: https://gitlab.com/pipo.sk/libvirt/-/commits/device-add-json-revert-2 v2: - dropped patch 2, folded important bits from the commit message into commit message for patch 1 Peter Krempa (2): qemu: Revert to using non-JSON commandline for -device NEWS: Mention device hot-unplug regression with qemu-6.2 and workarounds for it NEWS.rst | 31 ++++++++++++++ src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- .../caps_6.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - .../caps_6.2.0.x86_64.xml | 1 - ...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 6 +-- ...fault-cpu-tcg-virt-4.2.aarch64-latest.args | 6 +-- .../aarch64-tpm.aarch64-latest.args | 2 +- .../aarch64-virt-graphics.aarch64-latest.args | 36 ++++++++-------- .../aarch64-virt-headless.aarch64-latest.args | 28 ++++++------- .../audio-alsa-best.x86_64-latest.args | 4 +- .../audio-alsa-full.x86_64-latest.args | 4 +- .../audio-alsa-minimal.x86_64-latest.args | 4 +- .../audio-coreaudio-best.x86_64-latest.args | 4 +- .../audio-coreaudio-full.x86_64-latest.args | 4 +- ...audio-coreaudio-minimal.x86_64-latest.args | 4 +- ...udio-default-nographics.x86_64-latest.args | 4 +- .../audio-default-sdl.x86_64-latest.args | 6 +-- .../audio-default-spice.x86_64-latest.args | 6 +-- .../audio-default-vnc.x86_64-latest.args | 6 +-- .../audio-file-best.x86_64-latest.args | 4 +- .../audio-file-full.x86_64-latest.args | 4 +- .../audio-file-minimal.x86_64-latest.args | 4 +- .../audio-jack-full.x86_64-latest.args | 4 +- .../audio-jack-minimal.x86_64-latest.args | 4 +- .../audio-many-backends.x86_64-latest.args | 14 +++---- .../audio-none-best.x86_64-latest.args | 4 +- .../audio-none-full.x86_64-latest.args | 4 +- .../audio-none-minimal.x86_64-latest.args | 4 +- .../audio-oss-best.x86_64-latest.args | 4 +- .../audio-oss-full.x86_64-latest.args | 4 +- .../audio-oss-minimal.x86_64-latest.args | 4 +- .../audio-pulseaudio-best.x86_64-latest.args | 4 +- .../audio-pulseaudio-full.x86_64-latest.args | 4 +- ...udio-pulseaudio-minimal.x86_64-latest.args | 4 +- .../audio-sdl-best.x86_64-latest.args | 4 +- .../audio-sdl-full.x86_64-latest.args | 4 +- .../audio-sdl-minimal.x86_64-latest.args | 4 +- .../audio-spice-best.x86_64-latest.args | 4 +- .../audio-spice-full.x86_64-latest.args | 4 +- .../audio-spice-minimal.x86_64-latest.args | 4 +- .../blkdeviotune-group-num.x86_64-latest.args | 8 ++-- ...blkdeviotune-max-length.x86_64-latest.args | 8 ++-- .../blkdeviotune-max.x86_64-latest.args | 8 ++-- .../channel-unix-guestfwd.x86_64-latest.args | 4 +- .../console-compat-auto.x86_64-latest.args | 8 ++-- .../console-compat-chardev.x86_64-latest.args | 8 ++-- .../console-compat.x86_64-latest.args | 6 +-- .../console-virtio-unix.x86_64-latest.args | 10 ++--- .../controller-virtio-scsi.x86_64-latest.args | 24 +++++------ ...-Icelake-Server-pconfig.x86_64-latest.args | 4 +- .../cpu-host-model.x86_64-latest.args | 10 ++--- .../cpu-translation.x86_64-latest.args | 4 +- .../cputune-cpuset-big-id.x86_64-latest.args | 6 +-- ...ult-video-type-aarch64.aarch64-latest.args | 6 +-- ...default-video-type-ppc64.ppc64-latest.args | 8 ++-- .../devices-acpi-index.x86_64-latest.args | 16 +++---- .../disk-aio-io_uring.x86_64-latest.args | 6 +-- .../disk-aio.x86_64-latest.args | 8 ++-- .../disk-arm-virtio-sd.aarch64-latest.args | 2 +- ...-backing-chains-noindex.x86_64-latest.args | 16 +++---- .../disk-blockio.x86_64-latest.args | 8 ++-- .../disk-boot-cdrom.x86_64-latest.args | 6 +-- .../disk-boot-disk.x86_64-latest.args | 6 +-- .../disk-cache.x86_64-latest.args | 14 +++---- .../disk-cdrom-bus-other.x86_64-latest.args | 6 +-- ...m-empty-network-invalid.x86_64-latest.args | 4 +- .../disk-cdrom-network.x86_64-latest.args | 10 ++--- .../disk-cdrom-tray.x86_64-latest.args | 10 ++--- .../disk-cdrom.x86_64-latest.args | 10 ++--- .../disk-copy_on_read.x86_64-latest.args | 12 +++--- .../disk-detect-zeroes.x86_64-latest.args | 8 ++-- .../disk-discard.x86_64-latest.args | 8 ++-- .../disk-error-policy.x86_64-latest.args | 8 ++-- .../disk-floppy-q35-2_11.x86_64-latest.args | 12 +++--- .../disk-floppy-q35-2_9.x86_64-latest.args | 12 +++--- .../disk-floppy-tray.x86_64-latest.args | 10 ++--- .../disk-floppy.x86_64-latest.args | 8 ++-- .../disk-fmt-qcow.x86_64-latest.args | 6 +-- .../disk-geometry.x86_64-latest.args | 6 +-- .../disk-ide-split.x86_64-latest.args | 8 ++-- .../disk-ide-wwn.x86_64-latest.args | 6 +-- .../disk-ioeventfd.x86_64-latest.args | 12 +++--- .../disk-metadata-cache.x86_64-latest.args | 8 ++-- .../disk-network-gluster.x86_64-latest.args | 8 ++-- .../disk-network-http.x86_64-latest.args | 10 ++--- .../disk-network-iscsi.x86_64-latest.args | 18 ++++---- .../disk-network-nbd.x86_64-latest.args | 12 +++--- .../disk-network-nfs.x86_64-latest.args | 6 +-- ...-network-rbd-encryption.x86_64-latest.args | 12 +++--- ...sk-network-rbd-no-colon.x86_64-latest.args | 8 ++-- .../disk-network-rbd.x86_64-latest.args | 14 +++---- ...isk-network-source-auth.x86_64-latest.args | 8 ++-- ...isk-network-tlsx509-nbd.x86_64-latest.args | 4 +- .../disk-no-boot.x86_64-latest.args | 8 ++-- .../disk-nvme.x86_64-latest.args | 12 +++--- .../disk-order.x86_64-latest.args | 12 +++--- .../disk-readonly-disk.x86_64-latest.args | 8 ++-- .../disk-rotation.x86_64-latest.args | 12 +++--- .../disk-sata-device.x86_64-latest.args | 8 ++-- .../disk-scsi-device-auto.x86_64-latest.args | 10 ++--- .../disk-scsi-disk-split.x86_64-latest.args | 20 ++++----- .../disk-scsi-disk-vpd.x86_64-latest.args | 12 +++--- .../disk-scsi-disk-wwn.x86_64-latest.args | 12 +++--- ...sk-scsi-lun-passthrough.x86_64-latest.args | 12 +++--- .../disk-scsi.x86_64-latest.args | 26 ++++++------ .../disk-serial.x86_64-latest.args | 8 ++-- .../disk-shared.x86_64-latest.args | 14 +++---- .../disk-slices.x86_64-latest.args | 14 +++---- .../disk-snapshot.x86_64-latest.args | 10 ++--- .../disk-source-pool-mode.x86_64-latest.args | 12 +++--- .../disk-source-pool.x86_64-latest.args | 14 +++---- .../disk-transient.x86_64-latest.args | 6 +-- ...sk-usb-device-removable.x86_64-latest.args | 8 ++-- .../disk-usb-device.x86_64-latest.args | 8 ++-- .../disk-vhostuser.x86_64-latest.args | 8 ++-- .../disk-virtio-queues.x86_64-latest.args | 8 ++-- ...irtio-scsi-reservations.x86_64-latest.args | 10 ++--- .../disk-virtio.x86_64-latest.args | 10 ++--- .../encrypted-disk-usage.x86_64-latest.args | 6 +-- .../encrypted-disk.x86_64-latest.args | 6 +-- .../eoi-disabled.x86_64-latest.args | 4 +- .../eoi-enabled.x86_64-latest.args | 4 +- .../event_idx.x86_64-latest.args | 12 +++--- ...d-memory-numa-topology4.x86_64-latest.args | 4 +- .../fips-enabled.x86_64-latest.args | 6 +-- .../floppy-drive-fat.x86_64-latest.args | 6 +-- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 6 +-- .../genid-auto.x86_64-latest.args | 4 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 4 +- ...egl-headless-rendernode.x86_64-latest.args | 6 +-- .../graphics-egl-headless.x86_64-latest.args | 6 +-- ...s-spice-agent-file-xfer.x86_64-latest.args | 8 ++-- ...aphics-spice-agentmouse.x86_64-latest.args | 10 ++--- ...s-spice-auto-socket-cfg.x86_64-latest.args | 4 +- ...phics-spice-auto-socket.x86_64-latest.args | 4 +- ...phics-spice-compression.x86_64-latest.args | 8 ++-- ...hics-spice-egl-headless.x86_64-latest.args | 6 +-- ...pice-gl-auto-rendernode.x86_64-latest.args | 6 +-- .../graphics-spice-no-args.x86_64-latest.args | 6 +-- .../graphics-spice-qxl-vga.x86_64-latest.args | 8 ++-- .../graphics-spice-sasl.x86_64-latest.args | 6 +-- .../graphics-spice-socket.x86_64-latest.args | 4 +- .../graphics-spice-timeout.x86_64-latest.args | 14 +++---- ...raphics-spice-usb-redir.x86_64-latest.args | 16 +++---- .../graphics-spice.x86_64-latest.args | 8 ++-- ...ics-vnc-auto-socket-cfg.x86_64-latest.args | 6 +-- ...raphics-vnc-auto-socket.x86_64-latest.args | 4 +- ...aphics-vnc-egl-headless.x86_64-latest.args | 6 +-- ...hics-vnc-no-listen-attr.x86_64-latest.args | 6 +-- .../graphics-vnc-none.x86_64-latest.args | 4 +- .../graphics-vnc-policy.x86_64-latest.args | 6 +-- .../graphics-vnc-power.x86_64-latest.args | 6 +-- ...remove-generated-socket.x86_64-latest.args | 6 +-- .../graphics-vnc-sasl.x86_64-latest.args | 6 +-- ...-vnc-socket-new-cmdline.x86_64-latest.args | 4 +- .../graphics-vnc-socket.x86_64-latest.args | 4 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 4 +- .../graphics-vnc-tls.x86_64-latest.args | 4 +- .../graphics-vnc-websocket.x86_64-latest.args | 4 +- .../graphics-vnc.x86_64-latest.args | 6 +-- ...tdev-mdev-display-ramfb.x86_64-latest.args | 8 ++-- ...play-spice-egl-headless.x86_64-latest.args | 6 +-- ...ev-display-spice-opengl.x86_64-latest.args | 6 +-- ...isplay-vnc-egl-headless.x86_64-latest.args | 6 +-- ...ostdev-mdev-display-vnc.x86_64-latest.args | 6 +-- .../hostdev-scsi-lsi.x86_64-latest.args | 20 ++++----- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 22 +++++----- .../hugepages-memaccess3.x86_64-latest.args | 2 +- .../hugepages-nvdimm.x86_64-latest.args | 4 +- .../hyperv-off.x86_64-latest.args | 4 +- .../hyperv-panic.x86_64-latest.args | 2 +- .../hyperv-passthrough.x86_64-latest.args | 2 +- .../hyperv-stimer-direct.x86_64-latest.args | 2 +- .../hyperv.x86_64-latest.args | 2 +- .../input-linux.x86_64-latest.args | 4 +- .../intel-iommu-aw-bits.x86_64-latest.args | 2 +- ...ntel-iommu-caching-mode.x86_64-latest.args | 2 +- ...ntel-iommu-device-iotlb.x86_64-latest.args | 2 +- .../intel-iommu-eim.x86_64-latest.args | 2 +- .../intel-iommu.x86_64-latest.args | 2 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 10 ++--- .../kvmclock+eoi-disabled.x86_64-latest.args | 4 +- ...nch-security-sev-direct.x86_64-latest.args | 4 +- ...luks-disks-source-qcow2.x86_64-latest.args | 16 +++---- .../luks-disks-source.x86_64-latest.args | 14 +++---- .../luks-disks.x86_64-latest.args | 8 ++-- ...memory-default-hugepage.x86_64-latest.args | 4 +- .../memfd-memory-numa.x86_64-latest.args | 6 +-- ...y-hotplug-nvdimm-access.x86_64-latest.args | 8 ++-- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 8 ++-- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 8 ++-- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 8 ++-- ...hotplug-nvdimm-readonly.x86_64-latest.args | 8 ++-- .../memory-hotplug-nvdimm.x86_64-latest.args | 8 ++-- ...mory-hotplug-virtio-mem.x86_64-latest.args | 10 ++--- ...ory-hotplug-virtio-pmem.x86_64-latest.args | 8 ++-- .../misc-no-reboot.x86_64-latest.args | 4 +- .../mlock-off.x86_64-latest.args | 2 +- .../mlock-on.x86_64-latest.args | 2 +- .../name-escape.x86_64-latest.args | 20 ++++----- .../net-vdpa.x86_64-latest.args | 4 +- .../net-vhostuser.x86_64-latest.args | 8 ++-- .../numatune-hmat.x86_64-latest.args | 4 +- ...emnode-restrictive-mode.x86_64-latest.args | 4 +- .../numatune-memnode.x86_64-latest.args | 4 +- .../numatune-system-memory.x86_64-latest.args | 2 +- .../os-firmware-bios.x86_64-latest.args | 16 +++---- ...re-efi-no-enrolled-keys.x86_64-latest.args | 6 +-- ...os-firmware-efi-secboot.x86_64-latest.args | 16 +++---- .../os-firmware-efi.x86_64-latest.args | 16 +++---- .../panic-double.x86_64-latest.args | 4 +- .../panic-no-address.x86_64-latest.args | 8 ++-- .../qemuxml2argvdata/panic.x86_64-latest.args | 8 ++-- ...arallel-parport-chardev.x86_64-latest.args | 8 ++-- .../parallel-tcp-chardev.x86_64-latest.args | 8 ++-- .../parallel-unix-chardev.x86_64-latest.args | 8 ++-- ...pi-root-hotplug-disable.x86_64-latest.args | 4 +- ...cpi-root-hotplug-enable.x86_64-latest.args | 4 +- .../pci-serial-dev-chardev.x86_64-latest.args | 8 ++-- ...e-expander-bus-aarch64.aarch64-latest.args | 2 +- ...cie-root-port-nohotplug.x86_64-latest.args | 18 ++++---- ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 8 ++-- ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args | 8 ++-- ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args | 8 ++-- ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args | 8 ++-- ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args | 8 ++-- ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args | 8 ++-- .../ppc64-pseries-graphics.ppc64-latest.args | 22 +++++----- .../ppc64-pseries-headless.ppc64-latest.args | 16 +++---- .../ppc64-tpmproxy-single.ppc64-latest.args | 6 +-- .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 8 ++-- .../pv-spinlock-disabled.x86_64-latest.args | 4 +- .../pv-spinlock-enabled.x86_64-latest.args | 4 +- .../qemu-ns.x86_64-latest.args | 6 +-- ...rial-dev-chardev-iobase.x86_64-latest.args | 8 ++-- .../serial-dev-chardev.x86_64-latest.args | 8 ++-- .../serial-file-chardev.x86_64-latest.args | 8 ++-- .../serial-file-log.x86_64-latest.args | 6 +-- .../serial-many-chardev.x86_64-latest.args | 10 ++--- .../serial-pty-chardev.x86_64-latest.args | 8 ++-- ...erial-spiceport-nospice.x86_64-latest.args | 6 +-- .../serial-spiceport.x86_64-latest.args | 12 +++--- .../serial-tcp-chardev.x86_64-latest.args | 8 ++-- ...rial-tcp-telnet-chardev.x86_64-latest.args | 8 ++-- ...p-tlsx509-chardev-notls.x86_64-latest.args | 10 ++--- ...-tlsx509-chardev-verify.x86_64-latest.args | 10 ++--- ...ial-tcp-tlsx509-chardev.x86_64-latest.args | 10 ++--- ...-tlsx509-secret-chardev.x86_64-latest.args | 10 ++--- .../serial-udp-chardev.x86_64-latest.args | 10 ++--- .../serial-unix-chardev.x86_64-latest.args | 8 ++-- .../serial-vc-chardev.x86_64-latest.args | 8 ++-- ...rtcard-passthrough-unix.x86_64-latest.args | 8 ++-- .../tpm-emulator-spapr.ppc64-latest.args | 14 +++---- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 6 +-- ...pm-emulator-tpm2-pstate.x86_64-latest.args | 6 +-- .../tpm-emulator-tpm2.x86_64-latest.args | 6 +-- .../tpm-emulator.x86_64-latest.args | 6 +-- .../tpm-passthrough-crb.x86_64-latest.args | 6 +-- .../tpm-passthrough.x86_64-latest.args | 6 +-- .../tseg-explicit-size.x86_64-latest.args | 10 ++--- .../usb-redir-unix.x86_64-latest.args | 14 +++---- ...vhost-user-fs-fd-memory.x86_64-latest.args | 2 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 12 +++--- ...host-user-gpu-secondary.x86_64-latest.args | 10 ++--- .../vhost-user-vga.x86_64-latest.args | 8 ++-- .../vhost-vsock-auto.x86_64-latest.args | 6 +-- .../vhost-vsock.x86_64-latest.args | 6 +-- ...eo-bochs-display-device.x86_64-latest.args | 8 ++-- ...video-qxl-device-vram64.x86_64-latest.args | 6 +-- ...o-qxl-sec-device-vram64.x86_64-latest.args | 8 ++-- ...eo-ramfb-display-device.x86_64-latest.args | 8 ++-- ...video-virtio-vga-gpu-gl.x86_64-latest.args | 8 ++-- .../virtio-9p-createmode.x86_64-latest.args | 14 +++---- .../virtio-9p-multidevs.x86_64-latest.args | 12 +++--- .../virtio-lun.x86_64-latest.args | 12 +++--- ...virtio-non-transitional.x86_64-latest.args | 42 +++++++++---------- ...-options-controller-ats.x86_64-latest.args | 12 +++--- ...ptions-controller-iommu.x86_64-latest.args | 12 +++--- ...tions-controller-packed.x86_64-latest.args | 12 +++--- ...virtio-options-disk-ats.x86_64-latest.args | 8 ++-- ...rtio-options-disk-iommu.x86_64-latest.args | 8 ++-- ...tio-options-disk-packed.x86_64-latest.args | 8 ++-- .../virtio-options-fs-ats.x86_64-latest.args | 8 ++-- ...virtio-options-fs-iommu.x86_64-latest.args | 8 ++-- ...irtio-options-fs-packed.x86_64-latest.args | 8 ++-- ...irtio-options-input-ats.x86_64-latest.args | 8 ++-- ...tio-options-input-iommu.x86_64-latest.args | 8 ++-- ...io-options-input-packed.x86_64-latest.args | 8 ++-- ...-options-memballoon-ats.x86_64-latest.args | 4 +- ...loon-freepage-reporting.x86_64-latest.args | 4 +- ...ptions-memballoon-iommu.x86_64-latest.args | 4 +- ...tions-memballoon-packed.x86_64-latest.args | 4 +- .../virtio-options-net-ats.x86_64-latest.args | 8 ++-- ...irtio-options-net-iommu.x86_64-latest.args | 8 ++-- ...rtio-options-net-packed.x86_64-latest.args | 8 ++-- .../virtio-options-rng-ats.x86_64-latest.args | 8 ++-- ...irtio-options-rng-iommu.x86_64-latest.args | 8 ++-- ...rtio-options-rng-packed.x86_64-latest.args | 8 ++-- ...irtio-options-video-ats.x86_64-latest.args | 8 ++-- ...tio-options-video-iommu.x86_64-latest.args | 8 ++-- ...io-options-video-packed.x86_64-latest.args | 8 ++-- .../virtio-options.x86_64-latest.args | 28 ++++++------- .../virtio-rng-builtin.x86_64-latest.args | 6 +-- .../virtio-rng-egd-unix.x86_64-latest.args | 6 +-- .../virtio-transitional.x86_64-latest.args | 26 ++++++------ .../watchdog-device.x86_64-latest.args | 8 ++-- .../watchdog-dump.x86_64-latest.args | 8 ++-- .../watchdog-injectnmi.x86_64-latest.args | 8 ++-- .../watchdog.x86_64-latest.args | 6 +-- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 6 +-- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 14 +++---- ...efault-cpu-tcg-features.x86_64-latest.args | 10 ++--- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 6 +-- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 14 +++---- .../x86_64-pc-graphics.x86_64-latest.args | 20 ++++----- .../x86_64-pc-headless.x86_64-latest.args | 16 +++---- .../x86_64-q35-graphics.x86_64-latest.args | 34 +++++++-------- .../x86_64-q35-headless.x86_64-latest.args | 30 ++++++------- 320 files changed, 1332 insertions(+), 1305 deletions(-) -- 2.31.1

1 2

[libvirt PATCH 0/2] qemu: virtiofs: add killpriv_v2 support (virtiofs epopee)
by Ján Tomko 06 Jan '22

06 Jan '22

Ján Tomko (2): conf: add killpriv v2 attribute for virtiofs qemu: virtiofs: add (no_)killpriv_v2 support docs/formatdomain.rst | 4 ++++ docs/schemas/domaincommon.rng | 7 +++++++ src/conf/domain_conf.c | 15 +++++++++++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_virtiofs.c | 5 +++++ .../qemuxml2argvdata/vhost-user-fs-fd-memory.xml | 1 + 6 files changed, 33 insertions(+) -- 2.31.1

2 4

[libvirt PATCH v3 00/13] cgroup and thread management in ch driver.
by Praveen K Paladugu 06 Jan '22

06 Jan '22

This patchset adds support for cgroup management of ch threads. This version correctly manages cgroups for vcpu and emulator threads created by ch. cgroup management for iothreads is not yet supported. Along with cgroup management, this patchset also enables support for pinning vcpu and emulator threads to selected host cpus. v3: * addrressed all the formatting comments in v2 patch set * dropped indentation patches are they do not adhere to libvirt coding style * fixed build issue in qemu driver that was introduced in v2 Praveen K Paladugu (5): util: Helper functions to get process info ch_driver,ch_domain: vcpu info getter callbacks qemu,hypervisor: refactor some cgroup mgmt methods ch_process: Setup emulator and iothread settings ch_driver: emulator threadinfo & pinning callbacks Vineeth Pillai (8): ch_domain: add virCHDomainGetMonitor helper method ch_domain: add methods to manage private vcpu data ch_driver: domainGetVcpuPinInfo and nodeGetCPUMap ch_monitor: Get nicindexes in prep for cgroup mgmt ch: methods for cgroup mgmt in ch driver ch_driver,ch_domain: vcpupin callback in ch driver ch_driver: enable typed param string for numatune ch_driver: add numatune callbacks for CH driver src/ch/ch_conf.c | 2 + src/ch/ch_conf.h | 6 +- src/ch/ch_domain.c | 172 ++++++- src/ch/ch_domain.h | 32 +- src/ch/ch_driver.c | 789 +++++++++++++++++++++++++++++++++ src/ch/ch_monitor.c | 341 +++++++++++--- src/ch/ch_monitor.h | 60 ++- src/ch/ch_process.c | 385 +++++++++++++++- src/ch/ch_process.h | 3 + src/ch/meson.build | 1 + src/hypervisor/domain_cgroup.c | 426 +++++++++++++++++- src/hypervisor/domain_cgroup.h | 52 +++ src/libvirt_private.syms | 15 + src/qemu/qemu_cgroup.c | 410 +---------------- src/qemu/qemu_cgroup.h | 11 - src/qemu/qemu_driver.c | 130 +----- src/qemu/qemu_hotplug.c | 7 +- src/qemu/qemu_process.c | 20 +- src/util/virprocess.c | 108 +++++ src/util/virprocess.h | 5 + 20 files changed, 2357 insertions(+), 618 deletions(-) -- 2.27.0

2 21

[PATCH] util: Improve log out parsing errors
by Martin Kletzander 06 Jan '22

06 Jan '22

Suggested-by: Erik Skultety <eskultet(a)redhat.com> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/util/virlog.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 139dce8d0220..b44ad0ef6c47 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1487,21 +1487,21 @@ virLogParseOutput(const char *src) if (!(tokens = g_strsplit(src, ":", 0)) || (count = g_strv_length(tokens)) < 2) { virReportError(VIR_ERR_INVALID_ARG, - _("Malformed format for output '%s'"), src); + _("Malformed format for log output '%s'"), src); return NULL; } if (virStrToLong_uip(tokens[0], NULL, 10, &prio) < 0 || (prio < VIR_LOG_DEBUG) || (prio > VIR_LOG_ERROR)) { virReportError(VIR_ERR_INVALID_ARG, - _("Invalid priority '%s' for output '%s'"), + _("Invalid log priority '%s' for log output '%s'"), tokens[0], src); return NULL; } if ((dest = virLogDestinationTypeFromString(tokens[1])) < 0) { virReportError(VIR_ERR_INVALID_ARG, - _("Invalid destination '%s' for output '%s'"), + _("Invalid log destination '%s' for log output '%s'"), tokens[1], src); return NULL; } @@ -1511,7 +1511,7 @@ virLogParseOutput(const char *src) ((dest == VIR_LOG_TO_FILE || dest == VIR_LOG_TO_SYSLOG) && count != 3)) { virReportError(VIR_ERR_INVALID_ARG, - _("Output '%s' does not meet the format requirements " + _("Log output '%s' does not meet the format requirements " "for destination type '%s'"), src, tokens[1]); return NULL; } -- 2.34.1

2 2

[RFC] qemu_migration: Fix virConnectOpenAuth error code
by Raphael Norwitz 06 Jan '22

06 Jan '22

Today if virConnectOpenAuth fails, qemuMigrationSrcPerformPeer2Peer() returns VIR_ERR_OPERATION_FAILED. This change switches that error code to VIR_ERR_NO_CONNECT, which is more accurate. This should help libvirt consumers more intellegently retry migrations on intermittent connection failures. CC: Bhuvnesh Jain <bhuvnesh.jain(a)nutanix.com> Suggested-by: John Levon <john.levon(a)nutanix.com> Signed-off-by: Raphael Norwitz <raphael.norwitz(a)nutanix.com> --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index b9d7d582f5..f7ced209a4 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5145,7 +5145,7 @@ qemuMigrationSrcPerformPeer2Peer(virQEMUDriver *driver, goto cleanup; if (dconn == NULL) { - virReportError(VIR_ERR_OPERATION_FAILED, + virReportError(VIR_ERR_NO_CONNECT, _("Failed to connect to remote libvirt URI %s: %s"), dconnuri, virGetLastErrorMessage()); return -1; -- 2.20.1

3 5

[PATCH] qemu: agent: remove all code around disabled DEBUG_IO/DEBUG_RAW_IO definitions
by Ani Sinha 06 Jan '22

06 Jan '22

DEBUG_IO and DEBUG_RAW_IO are disabled and hence the code #defined under them are useless. Remove them. Also remove similar useless code from qemu_monitor_json. See also 4aae00bf1287f ("qemu: monitor: Remove disabled debug infrastructure") Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/qemu/qemu_agent.c | 51 ------------------------------------ src/qemu/qemu_monitor_json.c | 4 --- 2 files changed, 55 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index cb3bf97415..f33cd47078 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -48,9 +48,6 @@ VIR_LOG_INIT("qemu.qemu_agent"); #define LINE_ENDING "\n" -#define DEBUG_IO 0 -#define DEBUG_RAW_IO 0 - /* We read from QEMU until seeing a \r\n pair to indicate a * completed reply or event. To avoid memory denial-of-service * though, we must have a size limit on amount of data we @@ -137,25 +134,6 @@ static int qemuAgentOnceInit(void) VIR_ONCE_GLOBAL_INIT(qemuAgent); -#if DEBUG_RAW_IO -static char * -qemuAgentEscapeNonPrintable(const char *text) -{ - size_t i; - g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - for (i = 0; text[i] != '\0'; i++) { - if (text[i] == '\\') - virBufferAddLit(&buf, "\\\\"); - else if (g_ascii_isprint(text[i]) || text[i] == '\n' || - (text[i] == '\r' && text[i+1] == '\n')) - virBufferAddChar(&buf, text[i]); - else - virBufferAsprintf(&buf, "\\x%02x", text[i]); - } - return virBufferContentAndReset(&buf); -} -#endif - static void qemuAgentDispose(void *obj) { @@ -300,14 +278,6 @@ static int qemuAgentIOProcessData(qemuAgent *agent, { int used = 0; size_t i = 0; -#if DEBUG_IO -# if DEBUG_RAW_IO - g_autofree char *str1 = qemuAgentEscapeNonPrintable(data); - VIR_ERROR(_("[%s]"), str1); -# else - VIR_DEBUG("Data %zu bytes [%s]", len, data); -# endif -#endif while (used < len) { char *nl = strstr(data + used, LINE_ENDING); @@ -344,17 +314,6 @@ qemuAgentIOProcess(qemuAgent *agent) if (agent->msg && agent->msg->txOffset == agent->msg->txLength) msg = agent->msg; -#if DEBUG_IO -# if DEBUG_RAW_IO - g_autofree char *str1 = qemuAgentEscapeNonPrintable(msg ? msg->txBuffer : ""); - g_autofree char *str2 = qemuAgentEscapeNonPrintable(agent->buffer); - VIR_ERROR(_("Process %zu %p %p [[[%s]]][[[%s]]]"), - agent->bufferOffset, agent->msg, msg, str1, str2); -# else - VIR_DEBUG("Process %zu", agent->bufferOffset); -# endif -#endif - len = qemuAgentIOProcessData(agent, agent->buffer, agent->bufferOffset, msg); @@ -369,9 +328,6 @@ qemuAgentIOProcess(qemuAgent *agent) VIR_FREE(agent->buffer); agent->bufferOffset = agent->bufferLength = 0; } -#if DEBUG_IO - VIR_DEBUG("Process done %zu used %d", agent->bufferOffset, len); -#endif if (msg && msg->finished) virCondBroadcast(&agent->notify); return len; @@ -455,10 +411,6 @@ qemuAgentIORead(qemuAgent *agent) agent->buffer[agent->bufferOffset] = '\0'; } -#if DEBUG_IO - VIR_DEBUG("Now read %zu bytes of data", agent->bufferOffset); -#endif - return ret; } @@ -527,9 +479,6 @@ qemuAgentIO(GSocket *socket G_GNUC_UNUSED, virObjectRef(agent); /* lock access to the agent and protect fd */ virObjectLock(agent); -#if DEBUG_IO - VIR_DEBUG("Agent %p I/O on watch %d socket %p cond %d", agent, agent->socket, cond); -#endif if (agent->fd == -1 || !agent->watch) { virObjectUnlock(agent); diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index e45b43eb5a..0f1999f413 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -280,10 +280,6 @@ int qemuMonitorJSONIOProcess(qemuMonitor *mon, } } -#if DEBUG_IO - VIR_DEBUG("Total used %d bytes out of %zd available in buffer", used, len); -#endif - return used; } -- 2.25.1

2 2

[PATCH v3] Add VM info to improve error log message for qemu monitor
by Rohit Kumar 06 Jan '22

06 Jan '22

This change adds the domain name in the error and debug logs during monitor IO processing so that we may infer which VM experienced errors such as IO or socket hangup. This may help in debugging monitor IO errors. Signed-off-by: Rohit Kumar <rohit.kumar3(a)nutanix.com> --- src/qemu/qemu_monitor.c | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index dda6ae9796..2b4582578a 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -80,6 +80,7 @@ struct _qemuMonitor { GSource *watch; virDomainObj *vm; + char *domainName; qemuMonitorCallbacks *cb; void *callbackOpaque; @@ -243,6 +244,7 @@ qemuMonitorDispose(void *obj) virCondDestroy(&mon->notify); g_free(mon->buffer); g_free(mon->balloonpath); + g_free(mon->domainName); } @@ -583,8 +585,8 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, if (!error && !mon->goteof && cond & G_IO_ERR) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Invalid file descriptor while waiting for monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Invalid file descriptor while waiting for monitor (vm='%s')"), mon->domainName); mon->goteof = true; } } @@ -609,13 +611,14 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, virResetLastError(); } else { if (virGetLastErrorCode() == VIR_ERR_OK && !mon->goteof) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Error while processing monitor IO")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Error while processing monitor IO (vm='%s')"), mon->domainName); virCopyLastError(&mon->lastError); virResetLastError(); } - VIR_DEBUG("Error on monitor %s", NULLSTR(mon->lastError.message)); + VIR_DEBUG("Error on monitor %s mon=%p vm=%p name=%s", + NULLSTR(mon->lastError.message), mon, mon->vm, mon->domainName); /* If IO process resulted in an error & we have a message, * then wakeup that waiter */ if (mon->msg && !mon->msg->finished) { @@ -636,7 +639,8 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering EOF callback"); + VIR_DEBUG("Triggering EOF callback mon=%p vm=%p name=%s", + mon, mon->vm, mon->domainName); (eofNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else if (error) { @@ -646,7 +650,8 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering error callback"); + VIR_DEBUG("Triggering error callback mon=%p vm=%p name=%s", + mon, mon->vm, mon->domainName); (errorNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else { @@ -694,6 +699,7 @@ qemuMonitorOpenInternal(virDomainObj *vm, mon->fd = fd; mon->context = g_main_context_ref(context); mon->vm = virObjectRef(vm); + mon->domainName = g_strdup(NULLSTR(vm->def->name)); mon->waitGreeting = true; mon->cb = cb; mon->callbackOpaque = opaque; @@ -935,14 +941,14 @@ qemuMonitorSend(qemuMonitor *mon, /* Check whether qemu quit unexpectedly */ if (mon->lastError.code != VIR_ERR_OK) { - VIR_DEBUG("Attempt to send command while error is set %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Attempt to send command while error is set %s mon=%p vm=%p name=%s", + NULLSTR(mon->lastError.message), mon, mon->vm, mon->domainName); virSetError(&mon->lastError); return -1; } if (mon->goteof) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("End of file from qemu monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("End of file from qemu monitor (vm='%s')"), mon->domainName); return -1; } @@ -955,15 +961,15 @@ qemuMonitorSend(qemuMonitor *mon, while (!mon->msg->finished) { if (virCondWait(&mon->notify, &mon->parent.lock) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to wait on monitor condition")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to wait on monitor condition (vm='%s')"), mon->domainName); goto cleanup; } } if (mon->lastError.code != VIR_ERR_OK) { - VIR_DEBUG("Send command resulted in error %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Send command resulted in error %s mon=%p vm=%p name=%s", + NULLSTR(mon->lastError.message), mon, mon->vm, mon->domainName); virSetError(&mon->lastError); goto cleanup; } -- 2.25.1

3 3

[libvirt PATCH] util: fix prototype of virDaemonSetupLogging
by Ján Tomko 06 Jan '22

06 Jan '22

The commit that added error checking to this function forgot to adjust the WIN32 stub. Fixes: a873924e36b28c5b125621e35b32beb6b077bcc8 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as a build fix. src/util/virdaemon.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c index 5c0ca534cf..00bd7095f6 100644 --- a/src/util/virdaemon.c +++ b/src/util/virdaemon.c @@ -275,17 +275,17 @@ int virDaemonForkIntoBackground(const char *argv0 G_GNUC_UNUSED) return -1; } -void virDaemonSetupLogging(const char *daemon_name G_GNUC_UNUSED, - unsigned int log_level G_GNUC_UNUSED, - char *log_filters G_GNUC_UNUSED, - char *log_outputs G_GNUC_UNUSED, - bool privileged G_GNUC_UNUSED, - bool verbose G_GNUC_UNUSED, - bool godaemon G_GNUC_UNUSED) +int virDaemonSetupLogging(const char *daemon_name G_GNUC_UNUSED, + unsigned int log_level G_GNUC_UNUSED, + char *log_filters G_GNUC_UNUSED, + char *log_outputs G_GNUC_UNUSED, + bool privileged G_GNUC_UNUSED, + bool verbose G_GNUC_UNUSED, + bool godaemon G_GNUC_UNUSED) { /* NOOP */ errno = ENOTSUP; - return; + return -1; } int virDaemonUnixSocketPaths(const char *sock_prefix G_GNUC_UNUSED, -- 2.31.1

2 1

[PATCH] Account for fact that virDomainDeviceDefCopy() does an inactive copy
by Michal Privoznik 06 Jan '22

06 Jan '22

In a few places (e.g. device attach/detach/update) we are given a device XML, parse it but then need a copy of parsed data so that the original can be passed to function handling the request over inactive XML and the copy is then passed to function handling the operation over live XML. Note, both functions consume passed device on success, hence the need for copy. The problem is in combination of how the copy is obtained and where is passed. The copy is done by calling virDomainDeviceDefCopy() which does only inactive copy, i.e. no live information is copied over (e.g. no aliases). Then, this copy (inactive XML effectively) is passed to function handling live part of the operation (e.g. qemuDomainUpdateDeviceLive()) and the definition containing all the juicy, live bits is passed to function handling inactive part of the operation (e.g. qemuDomainUpdateDeviceConfig()). This is rather suboptimal, and XML copies should be passed to their respective functions. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2036895 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/lxc/lxc_driver.c | 10 +++++----- src/qemu/qemu_driver.c | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index fe583ccb76..7bc39120ee 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -4308,17 +4308,17 @@ static int lxcDomainAttachDeviceFlags(virDomainPtr dom, false) < 0) goto endjob; - if ((ret = lxcDomainAttachDeviceConfig(vmdef, dev)) < 0) + if ((ret = lxcDomainAttachDeviceConfig(vmdef, dev_copy)) < 0) goto endjob; } if (flags & VIR_DOMAIN_AFFECT_LIVE) { - if (virDomainDefCompatibleDevice(vm->def, dev_copy, NULL, + if (virDomainDefCompatibleDevice(vm->def, dev, NULL, VIR_DOMAIN_DEVICE_ACTION_ATTACH, true) < 0) goto endjob; - if ((ret = lxcDomainAttachDeviceLive(driver, vm, dev_copy)) < 0) + if ((ret = lxcDomainAttachDeviceLive(driver, vm, dev)) < 0) goto endjob; /* * update domain status forcibly because the domain status may be @@ -4475,12 +4475,12 @@ static int lxcDomainDetachDeviceFlags(virDomainPtr dom, if (!vmdef) goto endjob; - if ((ret = lxcDomainDetachDeviceConfig(vmdef, dev)) < 0) + if ((ret = lxcDomainDetachDeviceConfig(vmdef, dev_copy)) < 0) goto endjob; } if (flags & VIR_DOMAIN_AFFECT_LIVE) { - if ((ret = lxcDomainDetachDeviceLive(driver, vm, dev_copy)) < 0) + if ((ret = lxcDomainDetachDeviceLive(driver, vm, dev)) < 0) goto endjob; /* * update domain status forcibly because the domain status may be diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b8537a4260..b1255da9f2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8020,7 +8020,7 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr dom, /* virDomainDefCompatibleDevice call is delayed until we know the * device we're going to update. */ - if ((ret = qemuDomainUpdateDeviceConfig(vmdef, dev, priv->qemuCaps, + if ((ret = qemuDomainUpdateDeviceConfig(vmdef, dev_copy, priv->qemuCaps, parse_flags, driver->xmlopt)) < 0) goto endjob; @@ -8029,7 +8029,7 @@ static int qemuDomainUpdateDeviceFlags(virDomainPtr dom, if (flags & VIR_DOMAIN_AFFECT_LIVE) { /* virDomainDefCompatibleDevice call is delayed until we know the * device we're going to update. */ - if ((ret = qemuDomainUpdateDeviceLive(vm, dev_copy, dom, force)) < 0) + if ((ret = qemuDomainUpdateDeviceLive(vm, dev, dom, force)) < 0) goto endjob; qemuDomainSaveStatus(vm); @@ -8100,7 +8100,7 @@ qemuDomainDetachDeviceLiveAndConfig(virQEMUDriver *driver, if (!vmdef) goto cleanup; - if (qemuDomainDetachDeviceConfig(vmdef, dev, priv->qemuCaps, + if (qemuDomainDetachDeviceConfig(vmdef, dev_copy, priv->qemuCaps, parse_flags, driver->xmlopt) < 0) goto cleanup; @@ -8109,7 +8109,7 @@ qemuDomainDetachDeviceLiveAndConfig(virQEMUDriver *driver, if (flags & VIR_DOMAIN_AFFECT_LIVE) { int rc; - if ((rc = qemuDomainDetachDeviceLive(vm, dev_copy, driver, false)) < 0) + if ((rc = qemuDomainDetachDeviceLive(vm, dev, driver, false)) < 0) goto cleanup; if (rc == 0 && qemuDomainUpdateDeviceList(driver, vm, QEMU_ASYNC_JOB_NONE) < 0) -- 2.34.1

2 1

[PATCH v1 34/34] linux-user: Remove the deprecated ppc64abi32 target
by Alex Bennée 05 Jan '22

05 Jan '22

From: Thomas Huth <thuth(a)redhat.com> It's likely broken, and nobody cared for picking it up again during the deprecation phase, so let's remove this now. Since this is the last entry in deprecated_targets_list, remove the related code in the configure script, too. Signed-off-by: Thomas Huth <thuth(a)redhat.com> Reviewed-by: Richard Henderson <richard.henderson(a)linaro.org> Acked-by: Cédric Le Goater <clg(a)kaod.org> Acked-by: Alex Bennée <alex.bennee(a)linaro.org> Message-Id: <20211215084958.185214-1-thuth(a)redhat.com> Signed-off-by: Alex Bennée <alex.bennee(a)linaro.org> --- docs/about/deprecated.rst | 7 ----- docs/about/removed-features.rst | 8 +++++ docs/user/main.rst | 1 - configure | 29 +------------------ configs/targets/ppc64abi32-linux-user.mak | 8 ----- linux-user/ppc/target_syscall.h | 4 +-- linux-user/syscall_defs.h | 6 ++-- linux-user/elfload.c | 4 +-- linux-user/ppc/signal.c | 11 ++----- .gitlab-ci.d/buildtest.yml | 27 ----------------- .../dockerfiles/debian-ppc64el-cross.docker | 2 +- tests/tcg/configure.sh | 2 +- 12 files changed, 21 insertions(+), 88 deletions(-) delete mode 100644 configs/targets/ppc64abi32-linux-user.mak diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 5693abb663..7f12f53713 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -396,13 +396,6 @@ The above, converted to the current supported format:: linux-user mode CPUs -------------------- -``ppc64abi32`` CPUs (since 5.2) -''''''''''''''''''''''''''''''' - -The ``ppc64abi32`` architecture has a number of issues which regularly -trip up our CI testing and is suspected to be quite broken. For that -reason the maintainers strongly suspect no one actually uses it. - MIPS ``I7200`` CPU (since 5.2) '''''''''''''''''''''''''''''' diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index d42c3341de..f92b8bd738 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -594,6 +594,14 @@ the upstream Linux kernel in 2018, and it has also been dropped from glibc, so there is no new Linux development taking place with this architecture. For running the old binaries, you can use older versions of QEMU. +``ppc64abi32`` CPUs (removed in 7.0) +'''''''''''''''''''''''''''''''''''' + +The ``ppc64abi32`` architecture has a number of issues which regularly +tripped up the CI testing and was suspected to be quite broken. For that +reason the maintainers strongly suspected no one actually used it. + + System emulator devices ----------------------- diff --git a/docs/user/main.rst b/docs/user/main.rst index e08d4be63b..6f2ffa080f 100644 --- a/docs/user/main.rst +++ b/docs/user/main.rst @@ -166,7 +166,6 @@ Other binaries - user mode (PowerPC) - * ``qemu-ppc64abi32`` TODO. * ``qemu-ppc64`` TODO. * ``qemu-ppc`` TODO. diff --git a/configure b/configure index 030728d11e..0c57a063c6 100755 --- a/configure +++ b/configure @@ -1273,8 +1273,6 @@ if [ "$ARCH" = "unknown" ]; then fi default_target_list="" -deprecated_targets_list=ppc64abi32-linux-user -deprecated_features="" mak_wilds="" if [ "$softmmu" = "yes" ]; then @@ -1287,16 +1285,6 @@ if [ "$bsd_user" = "yes" ]; then mak_wilds="${mak_wilds} $source_path/configs/targets/*-bsd-user.mak" fi -# If the user doesn't explicitly specify a deprecated target we will -# skip it. -if test -z "$target_list"; then - if test -z "$target_list_exclude"; then - target_list_exclude="$deprecated_targets_list" - else - target_list_exclude="$target_list_exclude,$deprecated_targets_list" - fi -fi - for config in $mak_wilds; do target="$(basename "$config" .mak)" if echo "$target_list_exclude" | grep -vq "$target"; then @@ -1315,11 +1303,9 @@ Standard options: --prefix=PREFIX install in PREFIX [$prefix] --interp-prefix=PREFIX where to find shared libraries, etc. use %M for cpu name [$interp_prefix] - --target-list=LIST set target list (default: build all non-deprecated) + --target-list=LIST set target list (default: build all) $(echo Available targets: $default_target_list | \ fold -s -w 53 | sed -e 's/^/ /') -$(echo Deprecated targets: $deprecated_targets_list | \ - fold -s -w 53 | sed -e 's/^/ /') --target-list-exclude=LIST exclude a set of targets from the default target-list Advanced options (experts only): @@ -1804,13 +1790,6 @@ else done fi -for target in $target_list; do - # if a deprecated target is enabled we note it here - if echo "$deprecated_targets_list" | grep -q "$target"; then - add_to deprecated_features $target - fi -done - # see if system emulation was really requested case " $target_list " in *"-softmmu "*) softmmu=yes @@ -3950,12 +3929,6 @@ else fi fi -if test -n "${deprecated_features}"; then - echo "Warning, deprecated features enabled." - echo "Please see docs/about/deprecated.rst" - echo " features: ${deprecated_features}" -fi - # Create list of config switches that should be poisoned in common code... # but filter out CONFIG_TCG and CONFIG_USER_ONLY which are special. target_configs_h=$(ls *-config-devices.h *-config-target.h 2>/dev/null) diff --git a/configs/targets/ppc64abi32-linux-user.mak b/configs/targets/ppc64abi32-linux-user.mak deleted file mode 100644 index 0945451081..0000000000 --- a/configs/targets/ppc64abi32-linux-user.mak +++ /dev/null @@ -1,8 +0,0 @@ -TARGET_ARCH=ppc64 -TARGET_ABI32=y -TARGET_BASE_ARCH=ppc -TARGET_ABI_DIR=ppc -TARGET_SYSTBL_ABI=common,nospu,32 -TARGET_SYSTBL=syscall.tbl -TARGET_WORDS_BIGENDIAN=y -TARGET_XML_FILES= gdb-xml/power64-core.xml gdb-xml/power-fpu.xml gdb-xml/power-altivec.xml gdb-xml/power-spe.xml gdb-xml/power-vsx.xml diff --git a/linux-user/ppc/target_syscall.h b/linux-user/ppc/target_syscall.h index b9c4b813d3..30591806f0 100644 --- a/linux-user/ppc/target_syscall.h +++ b/linux-user/ppc/target_syscall.h @@ -36,7 +36,7 @@ struct target_pt_regs { abi_ulong link; abi_ulong xer; abi_ulong ccr; -#if defined(TARGET_PPC64) && !defined(TARGET_ABI32) +#if defined(TARGET_PPC64) abi_ulong softe; #else abi_ulong mq; /* 601 only (not used at present) */ @@ -58,7 +58,7 @@ struct target_revectored_struct { * flags masks */ -#if defined(TARGET_PPC64) && !defined(TARGET_ABI32) +#if defined(TARGET_PPC64) #ifdef TARGET_WORDS_BIGENDIAN #define UNAME_MACHINE "ppc64" #else diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 0b13975937..7a8f24967d 100644 --- a/linux-user/syscall_defs.h +++ b/linux-user/syscall_defs.h @@ -1607,7 +1607,7 @@ struct target_stat64 { struct target_stat { abi_ulong st_dev; abi_ulong st_ino; -#if defined(TARGET_PPC64) && !defined(TARGET_ABI32) +#if defined(TARGET_PPC64) abi_ulong st_nlink; unsigned int st_mode; #else @@ -1628,12 +1628,12 @@ struct target_stat { abi_ulong target_st_ctime_nsec; abi_ulong __unused4; abi_ulong __unused5; -#if defined(TARGET_PPC64) && !defined(TARGET_ABI32) +#if defined(TARGET_PPC64) abi_ulong __unused6; #endif }; -#if !defined(TARGET_PPC64) || defined(TARGET_ABI32) +#if !defined(TARGET_PPC64) #define TARGET_HAS_STRUCT_STAT64 struct QEMU_PACKED target_stat64 { unsigned long long st_dev; diff --git a/linux-user/elfload.c b/linux-user/elfload.c index fa9dae5f3f..130dcb0e14 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -718,7 +718,7 @@ static inline void init_thread(struct target_pt_regs *regs, #define ELF_MACHINE PPC_ELF_MACHINE #define ELF_START_MMAP 0x80000000 -#if defined(TARGET_PPC64) && !defined(TARGET_ABI32) +#if defined(TARGET_PPC64) #define elf_check_arch(x) ( (x) == EM_PPC64 ) @@ -870,7 +870,7 @@ static uint32_t get_elf_hwcap2(void) static inline void init_thread(struct target_pt_regs *_regs, struct image_info *infop) { _regs->gpr[1] = infop->start_stack; -#if defined(TARGET_PPC64) && !defined(TARGET_ABI32) +#if defined(TARGET_PPC64) if (get_ppc64_abi(infop) < 2) { uint64_t val; get_user_u64(val, infop->entry + 8); diff --git a/linux-user/ppc/signal.c b/linux-user/ppc/signal.c index 176c9d8503..ec0b9c0df3 100644 --- a/linux-user/ppc/signal.c +++ b/linux-user/ppc/signal.c @@ -477,9 +477,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, int i, err = 0; #if defined(TARGET_PPC64) struct target_sigcontext *sc = 0; -#if !defined(TARGET_ABI32) struct image_info *image = ((TaskState *)thread_cpu->opaque)->info; -#endif #endif rt_sf_addr = get_sigframe(ka, env, sizeof(*rt_sf)); @@ -530,7 +528,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, env->gpr[5] = (target_ulong) h2g(&rt_sf->uc); env->gpr[6] = (target_ulong) h2g(rt_sf); -#if defined(TARGET_PPC64) && !defined(TARGET_ABI32) +#if defined(TARGET_PPC64) if (get_ppc64_abi(image) < 2) { /* ELFv1 PPC64 function pointers are pointers to OPD entries. */ struct target_func_ptr *handler = @@ -562,7 +560,7 @@ sigsegv: } -#if !defined(TARGET_PPC64) || defined(TARGET_ABI32) +#if !defined(TARGET_PPC64) long do_sigreturn(CPUPPCState *env) { struct target_sigcontext *sc = NULL; @@ -575,12 +573,9 @@ long do_sigreturn(CPUPPCState *env) if (!lock_user_struct(VERIFY_READ, sc, sc_addr, 1)) goto sigsegv; -#if defined(TARGET_PPC64) - set.sig[0] = sc->oldmask + ((uint64_t)(sc->_unused[3]) << 32); -#else __get_user(set.sig[0], &sc->oldmask); __get_user(set.sig[1], &sc->_unused[3]); -#endif + target_to_host_sigset_internal(&blocked, &set); set_sigmask(&blocked); diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 8f2a3c8f5b..0aa70213fb 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -473,33 +473,6 @@ tsan-build: TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user MAKE_CHECK_ARGS: bench V=1 -# These targets are on the way out -build-deprecated: - extends: .native_build_job_template - needs: - job: amd64-debian-user-cross-container - variables: - IMAGE: debian-all-test-cross - CONFIGURE_ARGS: --disable-tools - MAKE_CHECK_ARGS: build-tcg - TARGETS: ppc64abi32-linux-user - artifacts: - expire_in: 2 days - paths: - - build - -# We split the check-tcg step as test failures are expected but we still -# want to catch the build breaking. -check-deprecated: - extends: .native_test_job_template - needs: - - job: build-deprecated - artifacts: true - variables: - IMAGE: debian-all-test-cross - MAKE_CHECK_ARGS: check-tcg - allow_failure: true - # gprof/gcov are GCC features build-gprof-gcov: extends: .native_build_job_template diff --git a/tests/docker/dockerfiles/debian-ppc64el-cross.docker b/tests/docker/dockerfiles/debian-ppc64el-cross.docker index 1146a06be6..5de12b01cd 100644 --- a/tests/docker/dockerfiles/debian-ppc64el-cross.docker +++ b/tests/docker/dockerfiles/debian-ppc64el-cross.docker @@ -16,7 +16,7 @@ RUN apt update && \ # Specify the cross prefix for this image (see tests/docker/common.rc) ENV QEMU_CONFIGURE_OPTS --cross-prefix=powerpc64le-linux-gnu- -ENV DEF_TARGET_LIST ppc64-softmmu,ppc64-linux-user,ppc64abi32-linux-user +ENV DEF_TARGET_LIST ppc64-softmmu,ppc64-linux-user # Install extra libraries to increase code coverage RUN apt update && \ diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 309335a2bd..763e9b6ad8 100755 --- a/tests/tcg/configure.sh +++ b/tests/tcg/configure.sh @@ -167,7 +167,7 @@ for target in $target_list; do container_image=debian-nios2-cross container_cross_cc=nios2-linux-gnu-gcc ;; - ppc-*|ppc64abi32-*) + ppc-*) container_hosts=x86_64 container_image=debian-powerpc-test-cross container_cross_cc=powerpc-linux-gnu-gcc-10 -- 2.30.2

1 0

[PATCH 0/8] Fix an unfortunate deadlock
by Martin Kletzander 05 Jan '22

05 Jan '22

Before this series: # LIBVIRT_LOG_OUTPUTS=1:asdf:fdsa:meh libvirtd <possible_deadlock> After this series: # LIBVIRT_LOG_OUTPUTS=1:asdf:fdsa:meh libvirtd libvirt: error : invalid argument: Invalid destination 'asdf' for output '1:asdf:fdsa:meh' Martin Kletzander (8): util: Report error in virLogParseDefaultPriority util: Do not hide errors in virLogSetDefaultOutput util: Report error in virLogSetDefaultOutputToFile util: Initialize virLogMutex statically Exit on errors from virDaemonSetupLogging util: Check for errors in virLogSetFromEnv Dispatch error in virInitialize Do not print error in remote_daemon.c:main src/admin/libvirt-admin.c | 3 ++- src/libvirt.c | 35 ++++++++++----------------- src/locking/lock_daemon.c | 15 ++++++------ src/logging/log_daemon.c | 15 ++++++------ src/lxc/lxc_controller.c | 3 ++- src/remote/remote_daemon.c | 19 +++++++-------- src/remote/remote_ssh_helper.c | 3 ++- src/security/virt-aa-helper.c | 3 ++- src/util/vircommand.c | 3 ++- src/util/virdaemon.c | 34 ++++++++++++++++---------- src/util/virdaemon.h | 14 +++++------ src/util/virlog.c | 44 ++++++++++++++++++++++------------ src/util/virlog.h | 4 ++-- tests/testutils.c | 4 +++- 14 files changed, 111 insertions(+), 88 deletions(-) -- 2.34.1

2 18

[libvirt PATCH 00/17] qemu: Introduce hvf domain type for Hypervisor.framework
by Andrea Bolognani 05 Jan '22

05 Jan '22

In order to hopefully address [libvirt#147] at long last, I've picked up Roman's patches from 2018 and attempted to forward-port them. More specifically, I've used the [roolebo/hvf-domain] branch as a starting point, since it seems to contain a few improvements over [v2] and was just easier to pick up. The code is mostly his own, so I've retained the existing authorship information, but I've dropped Reviewed-by tags for commits that have been modified in non-trivial ways. I've applied very minimal style tweaks along the way, but overall I've tried to modify the existing patches as little as possible. I've added a few changes of my own, which I've marked as "fixup!" when I felt that they should be squashed into the previous patch rather than existing as separate commits. The new test cases, such as they are, pass, and no regressions to KVM support appear to have been introduced in the process. I don't currently have access to a machine running macOS, so I can't verify that it's actually possible to start a hardware-accelerated VM. Changes from [v2]: * rebased on top of master; * added a couple of simple test cases. Notes / to do items: * I've skipped [kvmonly] because it was not obvious how to forward-port it, and things generally seemed to work fine even without it. I have some ideas on how to integrate the logic in the current version of the code if it turns out to be necessary after all; * I've also skipped most of the changes to docs/formatdomain.rst, namely the ones that replaced "QEMU" or "QEMU/KVM" in :since: blocks. I'm not yet sure how to best deal with the situation, but adding "and HVF" everywhere is almost certainly not it; * docs/macos.html.in needs to be converted to ReStructuredText before merging. Useful links: * GitLab: [abologna/hvf] * CI: [pipeline] [libvirt#147] https://gitlab.com/libvirt/libvirt/-/issues/147 [roolebo/hvf-domain] https://github.com/roolebo/libvirt/tree/hvf-domain [abologna/hvf] https://gitlab.com/abologna/libvirt/-/commits/hvf [pipeline] https://gitlab.com/abologna/libvirt/-/pipelines/441350810 [kvmonly] https://github.com/roolebo/libvirt/commit/1752ccbfe53bf4f89f3f45e4ef96b7da7… [v2] https://listman.redhat.com/archives/libvir-list/2018-November/msg00802.html Andrea Bolognani (4): fixup! qemu: Fix HVF architecture check tests: Add HVF support to testutilsqemu tests: Add HVF test cases fixup! NEWS: Mention Apple Silicon support for HVF Roman Bolshakov (13): conf: Add hvf domain type qemu: Define hvf capability qemu: Query hvf capability on macOS qemu: Expose hvf domain type if hvf is supported qemu: Introduce virQEMUCapsTypeIsAccelerated qemu: Introduce virQEMUCapsHaveAccel qemu: Introduce virQEMUCapsAccelStr qemu: Make error message accel-agnostic qemu: Correct CPU capabilities probing for hvf docs: Add hvf on QEMU driver page docs: Note hvf support for domain elements docs: Add support page for libvirt on macOS news: Mention hvf domain type NEWS.rst | 9 + docs/docs.html.in | 3 + docs/drvqemu.rst | 48 +++- docs/formatdomain.rst | 22 +- docs/index.html.in | 4 +- docs/macos.html.in | 229 ++++++++++++++++++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 107 +++++++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 4 + src/qemu/qemu_process.c | 2 +- .../hvf-aarch64-virt-headless.args | 48 ++++ .../hvf-aarch64-virt-headless.xml | 45 ++++ .../hvf-x86_64-q35-headless.args | 47 ++++ .../hvf-x86_64-q35-headless.xml | 44 ++++ tests/qemuxml2argvtest.c | 18 ++ .../hvf-aarch64-virt-headless.xml | 94 +++++++ .../hvf-x86_64-q35-headless.xml | 97 ++++++++ tests/qemuxml2xmltest.c | 18 ++ tests/testutilsqemu.c | 40 +++ 22 files changed, 857 insertions(+), 26 deletions(-) create mode 100644 docs/macos.html.in create mode 100644 tests/qemuxml2argvdata/hvf-aarch64-virt-headless.args create mode 100644 tests/qemuxml2argvdata/hvf-aarch64-virt-headless.xml create mode 100644 tests/qemuxml2argvdata/hvf-x86_64-q35-headless.args create mode 100644 tests/qemuxml2argvdata/hvf-x86_64-q35-headless.xml create mode 100644 tests/qemuxml2xmloutdata/hvf-aarch64-virt-headless.xml create mode 100644 tests/qemuxml2xmloutdata/hvf-x86_64-q35-headless.xml -- 2.31.1

2 35

Plans for the next release
by Jiri Denemark 05 Jan '22

05 Jan '22

We are getting close to the next release of libvirt. To aim for the release on Jan 14 I suggest entering the freeze on Monday Jan 10 and tagging RC2 on Wednesday Jan 12. I hope this works for everyone. Jirka

1 0

[PATCH] ci: Refresh configuration
by Andrea Bolognani 04 Jan '22

04 Jan '22

Notable changes: * drop parted and XFS headers. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the CI refresh rule. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/441266800 Full patch: https://gitlab.com/libvirt/libvirt/-/commit/4c7316b2f00c847bc5dc9c8218c2585… ci/containers/centos-8.Dockerfile | 2 -- ci/containers/centos-stream-8.Dockerfile | 2 -- ci/containers/debian-10-cross-aarch64.Dockerfile | 4 +--- ci/containers/debian-10-cross-armv6l.Dockerfile | 4 +--- ci/containers/debian-10-cross-armv7l.Dockerfile | 4 +--- ci/containers/debian-10-cross-i686.Dockerfile | 4 +--- ci/containers/debian-10-cross-mips.Dockerfile | 4 +--- ci/containers/debian-10-cross-mips64el.Dockerfile | 4 +--- ci/containers/debian-10-cross-mipsel.Dockerfile | 4 +--- ci/containers/debian-10-cross-ppc64le.Dockerfile | 4 +--- ci/containers/debian-10-cross-s390x.Dockerfile | 4 +--- ci/containers/debian-10.Dockerfile | 2 -- ci/containers/debian-11-cross-aarch64.Dockerfile | 4 +--- ci/containers/debian-11-cross-armv6l.Dockerfile | 4 +--- ci/containers/debian-11-cross-armv7l.Dockerfile | 4 +--- ci/containers/debian-11-cross-i686.Dockerfile | 4 +--- ci/containers/debian-11-cross-mips64el.Dockerfile | 4 +--- ci/containers/debian-11-cross-mipsel.Dockerfile | 4 +--- ci/containers/debian-11-cross-ppc64le.Dockerfile | 4 +--- ci/containers/debian-11-cross-s390x.Dockerfile | 4 +--- ci/containers/debian-11.Dockerfile | 2 -- ci/containers/debian-sid-cross-aarch64.Dockerfile | 4 +--- ci/containers/debian-sid-cross-armv6l.Dockerfile | 4 +--- ci/containers/debian-sid-cross-armv7l.Dockerfile | 4 +--- ci/containers/debian-sid-cross-i686.Dockerfile | 4 +--- ci/containers/debian-sid-cross-mips64el.Dockerfile | 4 +--- ci/containers/debian-sid-cross-mipsel.Dockerfile | 4 +--- ci/containers/debian-sid-cross-ppc64le.Dockerfile | 4 +--- ci/containers/debian-sid-cross-s390x.Dockerfile | 4 +--- ci/containers/debian-sid.Dockerfile | 2 -- ci/containers/fedora-34.Dockerfile | 2 -- ci/containers/fedora-35-cross-mingw32.Dockerfile | 1 - ci/containers/fedora-35-cross-mingw64.Dockerfile | 1 - ci/containers/fedora-35.Dockerfile | 2 -- ci/containers/fedora-rawhide-cross-mingw32.Dockerfile | 1 - ci/containers/fedora-rawhide-cross-mingw64.Dockerfile | 1 - ci/containers/fedora-rawhide.Dockerfile | 2 -- ci/containers/opensuse-leap-152.Dockerfile | 4 +--- ci/containers/opensuse-tumbleweed.Dockerfile | 4 +--- ci/containers/ubuntu-1804.Dockerfile | 2 -- ci/containers/ubuntu-2004.Dockerfile | 2 -- 41 files changed, 27 insertions(+), 105 deletions(-) diff --git a/ci/containers/centos-8.Dockerfile b/ci/containers/centos-8.Dockerfile index 358069ad88..f01ca6a0d9 100644 --- a/ci/containers/centos-8.Dockerfile +++ b/ci/containers/centos-8.Dockerfile @@ -67,7 +67,6 @@ RUN dnf update -y && \ ninja-build \ numactl-devel \ numad \ - parted \ parted-devel \ perl \ pkgconfig \ @@ -85,7 +84,6 @@ RUN dnf update -y && \ systemd-devel \ systemtap-sdt-devel \ wireshark-devel \ - xfsprogs-devel \ yajl-devel && \ dnf autoremove -y && \ dnf clean all -y && \ [... a lot more like this ...] -- 2.31.1

1 0

[PATCH] NEWS: Add entries for libxl changes during 8.0.0 development
by Jim Fehlig 04 Jan '22

04 Jan '22

Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e7d5316721..d819b6c226 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,11 @@ v8.0.0 (unreleased) * **Security** + * libxl: Fix potential deadlock and crash (CVE-2021-4147) + + A rouge guest could continuously reboot itself and cause libvirtd on the + host to deadlock or crash, resulting in a denial of service condition. + * **Removed features** * qemu: Explicitly forbid live changing nodeset for strict numatune @@ -44,6 +49,8 @@ v8.0.0 (unreleased) * **Improvements** + * libxl: Implement the virDomainGetMessages API + * **Bug fixes** -- 2.34.1

2 2

[PATCH 0/2] KVM features: two almost trivial cleanups
by Michal Privoznik 04 Jan '22

04 Jan '22

I've noticed these while reviewing a patch that touched this part of code. Michal Prívozník (2): qemuxml2xmloutdata: Turn kvm-features.xml and kvm-features-off.xml into symlinks domain_conf: Use virXMLFormatElement*() more in virDomainDefFormatFeatures() src/conf/domain_conf.c | 21 +++++----- tests/qemuxml2argvdata/kvm-features-off.xml | 7 +++- tests/qemuxml2argvdata/kvm-features.xml | 7 +++- tests/qemuxml2xmloutdata/kvm-features-off.xml | 38 +------------------ tests/qemuxml2xmloutdata/kvm-features.xml | 38 +------------------ 5 files changed, 22 insertions(+), 89 deletions(-) mode change 100644 => 120000 tests/qemuxml2xmloutdata/kvm-features-off.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/kvm-features.xml -- 2.32.0

2 4

[PATCH 0/2] virnetdevopenvswitch: Fix 'burst' value passed to ovs-vsctl
by Michal Privoznik 04 Jan '22

04 Jan '22

*** BLURB HERE *** Michal Prívozník (2): docs: Clarify 'burst' units for QoS virnetdevopenvswitch: Fix 'burst' value passed to ovs-vsctl docs/formatnetwork.html.in | 2 +- src/util/virnetdevbandwidth.h | 8 ++++---- src/util/virnetdevopenvswitch.c | 16 +++++++++------- 3 files changed, 14 insertions(+), 12 deletions(-) -- 2.34.1

2 4

[libvirt PATCH 0/3] storage: Use the FICLONE ioctl unconditionally on Linux
by Andrea Bolognani 04 Jan '22

04 Jan '22

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/438075320 Andrea Bolognani (3): storage: Use the FICLONE ioctl unconditionally on Linux meson: Don't look for btrfs and xfs headers spec: Drop BuildRequires on xfsprogs-devel libvirt.spec.in | 2 -- meson.build | 4 ---- src/storage/storage_util.c | 14 ++------------ 3 files changed, 2 insertions(+), 18 deletions(-) -- 2.31.1

3 5

[libvirt PATCH v2 0/6] docs: Unclutter top-level directory
by Andrea Bolognani 04 Jan '22

04 Jan '22

Note that the icons part is untested, because testing it properly would require uploading the generated website to some publicly-accessible location and browsing it using various devices. I have, however, looked at a few popular websites and I've seen them use icons that are not in the top-level directory, so I'm reasonably confident that icons will keep working fine even after moving them. Changes from [v1]: * extend scope to include icons and CSS files. [v1] https://listman.redhat.com/archives/libvir-list/2021-December/msg00818.html Andrea Bolognani (6): docs: Drop structures.svg docs: Add <link> pointing to favicon.ico docs: Move all images to a subdirectory docs: Move all icons to a subdirectory docs: Move all CSS files to a subdirectory docs: Move font definitions with other CSS files docs/api.rst | 6 +- docs/browserconfig.xml | 2 +- docs/{fonts/stylesheet.css => css/fonts.css} | 18 +- docs/{ => css}/generic.css | 0 docs/{ => css}/libvirt.css | 4 +- docs/{ => css}/main.css | 2 +- docs/css/meson.build | 17 ++ docs/{ => css}/mobile.css | 2 +- docs/fonts/meson.build | 1 - docs/goals.html.in | 2 +- docs/{ => icons}/android-chrome-192x192.png | Bin docs/{ => icons}/android-chrome-256x256.png | Bin docs/{ => icons}/apple-touch-icon.png | Bin docs/{ => icons}/favicon-16x16.png | Bin docs/{ => icons}/favicon-32x32.png | Bin docs/{ => icons}/favicon.ico | Bin docs/icons/meson.build | 19 ++ docs/{ => icons}/mstile-150x150.png | Bin docs/{ => images}/event_loop_simple.png | Bin docs/{ => images}/event_loop_simple.svg | 0 docs/{ => images}/event_loop_worker.png | Bin docs/{ => images}/event_loop_worker.svg | 0 docs/{ => images}/libvirt-daemon-arch.png | Bin docs/{ => images}/libvirt-daemon-arch.svg | 0 docs/{ => images}/libvirt-driver-arch.png | Bin docs/{ => images}/libvirt-driver-arch.svg | 0 docs/{ => images}/libvirt-object-model.png | Bin docs/{ => images}/libvirt-object-model.svg | 0 .../libvirt-virConnect-example.png | Bin .../libvirt-virConnect-example.svg | 0 docs/images/meson.build | 24 +++ .../{ => images}/migration-managed-direct.png | Bin .../{ => images}/migration-managed-direct.svg | 0 docs/{ => images}/migration-managed-p2p.png | Bin docs/{ => images}/migration-managed-p2p.svg | 0 docs/{ => images}/migration-native.png | Bin docs/{ => images}/migration-native.svg | 0 docs/{ => images}/migration-tunnel.png | Bin docs/{ => images}/migration-tunnel.svg | 0 .../migration-unmanaged-direct.png | Bin .../migration-unmanaged-direct.svg | 0 docs/{ => images}/node.gif | Bin docs/{ => images}/node.svg | 0 docs/internals.html.in | 2 +- docs/internals/eventloop.html.in | 4 +- docs/manifest.json | 4 +- docs/meson.build | 26 +-- docs/migration.rst | 10 +- docs/page.xsl | 9 +- docs/structures.svg | 187 ------------------ 50 files changed, 96 insertions(+), 243 deletions(-) rename docs/{fonts/stylesheet.css => css/fonts.css} (60%) rename docs/{ => css}/generic.css (100%) rename docs/{ => css}/libvirt.css (98%) rename docs/{ => css}/main.css (68%) create mode 100644 docs/css/meson.build rename docs/{ => css}/mobile.css (95%) rename docs/{ => icons}/android-chrome-192x192.png (100%) rename docs/{ => icons}/android-chrome-256x256.png (100%) rename docs/{ => icons}/apple-touch-icon.png (100%) rename docs/{ => icons}/favicon-16x16.png (100%) rename docs/{ => icons}/favicon-32x32.png (100%) rename docs/{ => icons}/favicon.ico (100%) create mode 100644 docs/icons/meson.build rename docs/{ => icons}/mstile-150x150.png (100%) rename docs/{ => images}/event_loop_simple.png (100%) rename docs/{ => images}/event_loop_simple.svg (100%) rename docs/{ => images}/event_loop_worker.png (100%) rename docs/{ => images}/event_loop_worker.svg (100%) rename docs/{ => images}/libvirt-daemon-arch.png (100%) rename docs/{ => images}/libvirt-daemon-arch.svg (100%) rename docs/{ => images}/libvirt-driver-arch.png (100%) rename docs/{ => images}/libvirt-driver-arch.svg (100%) rename docs/{ => images}/libvirt-object-model.png (100%) rename docs/{ => images}/libvirt-object-model.svg (100%) rename docs/{ => images}/libvirt-virConnect-example.png (100%) rename docs/{ => images}/libvirt-virConnect-example.svg (100%) create mode 100644 docs/images/meson.build rename docs/{ => images}/migration-managed-direct.png (100%) rename docs/{ => images}/migration-managed-direct.svg (100%) rename docs/{ => images}/migration-managed-p2p.png (100%) rename docs/{ => images}/migration-managed-p2p.svg (100%) rename docs/{ => images}/migration-native.png (100%) rename docs/{ => images}/migration-native.svg (100%) rename docs/{ => images}/migration-tunnel.png (100%) rename docs/{ => images}/migration-tunnel.svg (100%) rename docs/{ => images}/migration-unmanaged-direct.png (100%) rename docs/{ => images}/migration-unmanaged-direct.svg (100%) rename docs/{ => images}/node.gif (100%) rename docs/{ => images}/node.svg (100%) delete mode 100644 docs/structures.svg -- 2.31.1

2 9

[PATCH 0/2] gnutls: Be more clever about DH key size
by Michal Privoznik 04 Jan '22

04 Jan '22

See 2/2 for explanation. Ideally, we wouldn't use gnutls_dh_params_generate2() at all, per [1]. But that would require bumping minimal required version to gnutls-3.6.0 and I'm not sure how available it is in OSes we support. Therefore, for now let's stick with patch 2/2. 1: https://www.gnutls.org/manual/html_node/Parameter-generation.html Michal Prívozník (2): virnettlscontext: Drop gnutls_dh_set_prime_bits() virnettlscontext: Don't pass static key length to gnutls_dh_params_generate2() src/rpc/virnettlscontext.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) -- 2.32.0

6 13

[PATCH 0/3] qemu: Work around qemu not sending DEVICE_DELETED when device is configured via JSON
by Peter Krempa 04 Jan '22

04 Jan '22

See patches for justification. Peter Krempa (3): qemu: Revert to using non-JSON commandline for -device qemu: capabilities: Condemn the use of 'device.json' capability name NEWS: Mention device hot-unplug regression with qemu-6.2 and workarounds for it NEWS.rst | 31 ++++++++++++++ src/qemu/qemu_capabilities.c | 4 +- src/qemu/qemu_capabilities.h | 3 +- .../caps_6.2.0.aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 - .../caps_6.2.0.x86_64.xml | 1 - ...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 6 +-- ...fault-cpu-tcg-virt-4.2.aarch64-latest.args | 6 +-- .../aarch64-tpm.aarch64-latest.args | 2 +- .../aarch64-virt-graphics.aarch64-latest.args | 36 ++++++++-------- .../aarch64-virt-headless.aarch64-latest.args | 28 ++++++------- .../audio-alsa-best.x86_64-latest.args | 4 +- .../audio-alsa-full.x86_64-latest.args | 4 +- .../audio-alsa-minimal.x86_64-latest.args | 4 +- .../audio-coreaudio-best.x86_64-latest.args | 4 +- .../audio-coreaudio-full.x86_64-latest.args | 4 +- ...audio-coreaudio-minimal.x86_64-latest.args | 4 +- ...udio-default-nographics.x86_64-latest.args | 4 +- .../audio-default-sdl.x86_64-latest.args | 6 +-- .../audio-default-spice.x86_64-latest.args | 6 +-- .../audio-default-vnc.x86_64-latest.args | 6 +-- .../audio-file-best.x86_64-latest.args | 4 +- .../audio-file-full.x86_64-latest.args | 4 +- .../audio-file-minimal.x86_64-latest.args | 4 +- .../audio-jack-full.x86_64-latest.args | 4 +- .../audio-jack-minimal.x86_64-latest.args | 4 +- .../audio-many-backends.x86_64-latest.args | 14 +++---- .../audio-none-best.x86_64-latest.args | 4 +- .../audio-none-full.x86_64-latest.args | 4 +- .../audio-none-minimal.x86_64-latest.args | 4 +- .../audio-oss-best.x86_64-latest.args | 4 +- .../audio-oss-full.x86_64-latest.args | 4 +- .../audio-oss-minimal.x86_64-latest.args | 4 +- .../audio-pulseaudio-best.x86_64-latest.args | 4 +- .../audio-pulseaudio-full.x86_64-latest.args | 4 +- ...udio-pulseaudio-minimal.x86_64-latest.args | 4 +- .../audio-sdl-best.x86_64-latest.args | 4 +- .../audio-sdl-full.x86_64-latest.args | 4 +- .../audio-sdl-minimal.x86_64-latest.args | 4 +- .../audio-spice-best.x86_64-latest.args | 4 +- .../audio-spice-full.x86_64-latest.args | 4 +- .../audio-spice-minimal.x86_64-latest.args | 4 +- .../blkdeviotune-group-num.x86_64-latest.args | 8 ++-- ...blkdeviotune-max-length.x86_64-latest.args | 8 ++-- .../blkdeviotune-max.x86_64-latest.args | 8 ++-- .../channel-unix-guestfwd.x86_64-latest.args | 4 +- .../console-compat-auto.x86_64-latest.args | 8 ++-- .../console-compat-chardev.x86_64-latest.args | 8 ++-- .../console-compat.x86_64-latest.args | 6 +-- .../console-virtio-unix.x86_64-latest.args | 10 ++--- .../controller-virtio-scsi.x86_64-latest.args | 24 +++++------ ...-Icelake-Server-pconfig.x86_64-latest.args | 4 +- .../cpu-host-model.x86_64-latest.args | 10 ++--- .../cpu-translation.x86_64-latest.args | 4 +- .../cputune-cpuset-big-id.x86_64-latest.args | 6 +-- ...ult-video-type-aarch64.aarch64-latest.args | 6 +-- ...default-video-type-ppc64.ppc64-latest.args | 8 ++-- .../devices-acpi-index.x86_64-latest.args | 16 +++---- .../disk-aio-io_uring.x86_64-latest.args | 6 +-- .../disk-aio.x86_64-latest.args | 8 ++-- .../disk-arm-virtio-sd.aarch64-latest.args | 2 +- ...-backing-chains-noindex.x86_64-latest.args | 16 +++---- .../disk-blockio.x86_64-latest.args | 8 ++-- .../disk-boot-cdrom.x86_64-latest.args | 6 +-- .../disk-boot-disk.x86_64-latest.args | 6 +-- .../disk-cache.x86_64-latest.args | 14 +++---- .../disk-cdrom-bus-other.x86_64-latest.args | 6 +-- ...m-empty-network-invalid.x86_64-latest.args | 4 +- .../disk-cdrom-network.x86_64-latest.args | 10 ++--- .../disk-cdrom-tray.x86_64-latest.args | 10 ++--- .../disk-cdrom.x86_64-latest.args | 10 ++--- .../disk-copy_on_read.x86_64-latest.args | 12 +++--- .../disk-detect-zeroes.x86_64-latest.args | 8 ++-- .../disk-discard.x86_64-latest.args | 8 ++-- .../disk-error-policy.x86_64-latest.args | 8 ++-- .../disk-floppy-q35-2_11.x86_64-latest.args | 12 +++--- .../disk-floppy-q35-2_9.x86_64-latest.args | 12 +++--- .../disk-floppy-tray.x86_64-latest.args | 10 ++--- .../disk-floppy.x86_64-latest.args | 8 ++-- .../disk-fmt-qcow.x86_64-latest.args | 6 +-- .../disk-geometry.x86_64-latest.args | 6 +-- .../disk-ide-split.x86_64-latest.args | 8 ++-- .../disk-ide-wwn.x86_64-latest.args | 6 +-- .../disk-ioeventfd.x86_64-latest.args | 12 +++--- .../disk-metadata-cache.x86_64-latest.args | 8 ++-- .../disk-network-gluster.x86_64-latest.args | 8 ++-- .../disk-network-http.x86_64-latest.args | 10 ++--- .../disk-network-iscsi.x86_64-latest.args | 18 ++++---- .../disk-network-nbd.x86_64-latest.args | 12 +++--- .../disk-network-nfs.x86_64-latest.args | 6 +-- ...-network-rbd-encryption.x86_64-latest.args | 12 +++--- ...sk-network-rbd-no-colon.x86_64-latest.args | 8 ++-- .../disk-network-rbd.x86_64-latest.args | 14 +++---- ...isk-network-source-auth.x86_64-latest.args | 8 ++-- ...isk-network-tlsx509-nbd.x86_64-latest.args | 4 +- .../disk-no-boot.x86_64-latest.args | 8 ++-- .../disk-nvme.x86_64-latest.args | 12 +++--- .../disk-order.x86_64-latest.args | 12 +++--- .../disk-readonly-disk.x86_64-latest.args | 8 ++-- .../disk-rotation.x86_64-latest.args | 12 +++--- .../disk-sata-device.x86_64-latest.args | 8 ++-- .../disk-scsi-device-auto.x86_64-latest.args | 10 ++--- .../disk-scsi-disk-split.x86_64-latest.args | 20 ++++----- .../disk-scsi-disk-vpd.x86_64-latest.args | 12 +++--- .../disk-scsi-disk-wwn.x86_64-latest.args | 12 +++--- ...sk-scsi-lun-passthrough.x86_64-latest.args | 12 +++--- .../disk-scsi.x86_64-latest.args | 26 ++++++------ .../disk-serial.x86_64-latest.args | 8 ++-- .../disk-shared.x86_64-latest.args | 14 +++---- .../disk-slices.x86_64-latest.args | 14 +++---- .../disk-snapshot.x86_64-latest.args | 10 ++--- .../disk-source-pool-mode.x86_64-latest.args | 12 +++--- .../disk-source-pool.x86_64-latest.args | 14 +++---- .../disk-transient.x86_64-latest.args | 6 +-- ...sk-usb-device-removable.x86_64-latest.args | 8 ++-- .../disk-usb-device.x86_64-latest.args | 8 ++-- .../disk-vhostuser.x86_64-latest.args | 8 ++-- .../disk-virtio-queues.x86_64-latest.args | 8 ++-- ...irtio-scsi-reservations.x86_64-latest.args | 10 ++--- .../disk-virtio.x86_64-latest.args | 10 ++--- .../encrypted-disk-usage.x86_64-latest.args | 6 +-- .../encrypted-disk.x86_64-latest.args | 6 +-- .../eoi-disabled.x86_64-latest.args | 4 +- .../eoi-enabled.x86_64-latest.args | 4 +- .../event_idx.x86_64-latest.args | 12 +++--- ...d-memory-numa-topology4.x86_64-latest.args | 4 +- .../fips-enabled.x86_64-latest.args | 6 +-- .../floppy-drive-fat.x86_64-latest.args | 6 +-- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 6 +-- .../genid-auto.x86_64-latest.args | 4 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 4 +- ...egl-headless-rendernode.x86_64-latest.args | 6 +-- .../graphics-egl-headless.x86_64-latest.args | 6 +-- ...s-spice-agent-file-xfer.x86_64-latest.args | 8 ++-- ...aphics-spice-agentmouse.x86_64-latest.args | 10 ++--- ...s-spice-auto-socket-cfg.x86_64-latest.args | 4 +- ...phics-spice-auto-socket.x86_64-latest.args | 4 +- ...phics-spice-compression.x86_64-latest.args | 8 ++-- ...hics-spice-egl-headless.x86_64-latest.args | 6 +-- ...pice-gl-auto-rendernode.x86_64-latest.args | 6 +-- .../graphics-spice-no-args.x86_64-latest.args | 6 +-- .../graphics-spice-qxl-vga.x86_64-latest.args | 8 ++-- .../graphics-spice-sasl.x86_64-latest.args | 6 +-- .../graphics-spice-socket.x86_64-latest.args | 4 +- .../graphics-spice-timeout.x86_64-latest.args | 14 +++---- ...raphics-spice-usb-redir.x86_64-latest.args | 16 +++---- .../graphics-spice.x86_64-latest.args | 8 ++-- ...ics-vnc-auto-socket-cfg.x86_64-latest.args | 6 +-- ...raphics-vnc-auto-socket.x86_64-latest.args | 4 +- ...aphics-vnc-egl-headless.x86_64-latest.args | 6 +-- ...hics-vnc-no-listen-attr.x86_64-latest.args | 6 +-- .../graphics-vnc-none.x86_64-latest.args | 4 +- .../graphics-vnc-policy.x86_64-latest.args | 6 +-- .../graphics-vnc-power.x86_64-latest.args | 6 +-- ...remove-generated-socket.x86_64-latest.args | 6 +-- .../graphics-vnc-sasl.x86_64-latest.args | 6 +-- ...-vnc-socket-new-cmdline.x86_64-latest.args | 4 +- .../graphics-vnc-socket.x86_64-latest.args | 4 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 4 +- .../graphics-vnc-tls.x86_64-latest.args | 4 +- .../graphics-vnc-websocket.x86_64-latest.args | 4 +- .../graphics-vnc.x86_64-latest.args | 6 +-- ...tdev-mdev-display-ramfb.x86_64-latest.args | 8 ++-- ...play-spice-egl-headless.x86_64-latest.args | 6 +-- ...ev-display-spice-opengl.x86_64-latest.args | 6 +-- ...isplay-vnc-egl-headless.x86_64-latest.args | 6 +-- ...ostdev-mdev-display-vnc.x86_64-latest.args | 6 +-- .../hostdev-scsi-lsi.x86_64-latest.args | 20 ++++----- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 22 +++++----- .../hugepages-memaccess3.x86_64-latest.args | 2 +- .../hugepages-nvdimm.x86_64-latest.args | 4 +- .../hyperv-off.x86_64-latest.args | 4 +- .../hyperv-panic.x86_64-latest.args | 2 +- .../hyperv-passthrough.x86_64-latest.args | 2 +- .../hyperv-stimer-direct.x86_64-latest.args | 2 +- .../hyperv.x86_64-latest.args | 2 +- .../input-linux.x86_64-latest.args | 4 +- .../intel-iommu-aw-bits.x86_64-latest.args | 2 +- ...ntel-iommu-caching-mode.x86_64-latest.args | 2 +- ...ntel-iommu-device-iotlb.x86_64-latest.args | 2 +- .../intel-iommu-eim.x86_64-latest.args | 2 +- .../intel-iommu.x86_64-latest.args | 2 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 10 ++--- .../kvmclock+eoi-disabled.x86_64-latest.args | 4 +- ...nch-security-sev-direct.x86_64-latest.args | 4 +- ...luks-disks-source-qcow2.x86_64-latest.args | 16 +++---- .../luks-disks-source.x86_64-latest.args | 14 +++---- .../luks-disks.x86_64-latest.args | 8 ++-- ...memory-default-hugepage.x86_64-latest.args | 4 +- .../memfd-memory-numa.x86_64-latest.args | 6 +-- ...y-hotplug-nvdimm-access.x86_64-latest.args | 8 ++-- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 8 ++-- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 8 ++-- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 8 ++-- ...hotplug-nvdimm-readonly.x86_64-latest.args | 8 ++-- .../memory-hotplug-nvdimm.x86_64-latest.args | 8 ++-- ...mory-hotplug-virtio-mem.x86_64-latest.args | 10 ++--- ...ory-hotplug-virtio-pmem.x86_64-latest.args | 8 ++-- .../misc-no-reboot.x86_64-latest.args | 4 +- .../mlock-off.x86_64-latest.args | 2 +- .../mlock-on.x86_64-latest.args | 2 +- .../name-escape.x86_64-latest.args | 20 ++++----- .../net-vdpa.x86_64-latest.args | 4 +- .../net-vhostuser.x86_64-latest.args | 8 ++-- .../numatune-hmat.x86_64-latest.args | 4 +- ...emnode-restrictive-mode.x86_64-latest.args | 4 +- .../numatune-memnode.x86_64-latest.args | 4 +- .../numatune-system-memory.x86_64-latest.args | 2 +- .../os-firmware-bios.x86_64-latest.args | 16 +++---- ...re-efi-no-enrolled-keys.x86_64-latest.args | 6 +-- ...os-firmware-efi-secboot.x86_64-latest.args | 16 +++---- .../os-firmware-efi.x86_64-latest.args | 16 +++---- .../panic-double.x86_64-latest.args | 4 +- .../panic-no-address.x86_64-latest.args | 8 ++-- .../qemuxml2argvdata/panic.x86_64-latest.args | 8 ++-- ...arallel-parport-chardev.x86_64-latest.args | 8 ++-- .../parallel-tcp-chardev.x86_64-latest.args | 8 ++-- .../parallel-unix-chardev.x86_64-latest.args | 8 ++-- ...pi-root-hotplug-disable.x86_64-latest.args | 4 +- ...cpi-root-hotplug-enable.x86_64-latest.args | 4 +- .../pci-serial-dev-chardev.x86_64-latest.args | 8 ++-- ...e-expander-bus-aarch64.aarch64-latest.args | 2 +- ...cie-root-port-nohotplug.x86_64-latest.args | 18 ++++---- ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 8 ++-- ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args | 8 ++-- ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args | 8 ++-- ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args | 8 ++-- ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args | 8 ++-- ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args | 8 ++-- .../ppc64-pseries-graphics.ppc64-latest.args | 22 +++++----- .../ppc64-pseries-headless.ppc64-latest.args | 16 +++---- .../ppc64-tpmproxy-single.ppc64-latest.args | 6 +-- .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 8 ++-- .../pv-spinlock-disabled.x86_64-latest.args | 4 +- .../pv-spinlock-enabled.x86_64-latest.args | 4 +- .../qemu-ns.x86_64-latest.args | 6 +-- ...rial-dev-chardev-iobase.x86_64-latest.args | 8 ++-- .../serial-dev-chardev.x86_64-latest.args | 8 ++-- .../serial-file-chardev.x86_64-latest.args | 8 ++-- .../serial-file-log.x86_64-latest.args | 6 +-- .../serial-many-chardev.x86_64-latest.args | 10 ++--- .../serial-pty-chardev.x86_64-latest.args | 8 ++-- ...erial-spiceport-nospice.x86_64-latest.args | 6 +-- .../serial-spiceport.x86_64-latest.args | 12 +++--- .../serial-tcp-chardev.x86_64-latest.args | 8 ++-- ...rial-tcp-telnet-chardev.x86_64-latest.args | 8 ++-- ...p-tlsx509-chardev-notls.x86_64-latest.args | 10 ++--- ...-tlsx509-chardev-verify.x86_64-latest.args | 10 ++--- ...ial-tcp-tlsx509-chardev.x86_64-latest.args | 10 ++--- ...-tlsx509-secret-chardev.x86_64-latest.args | 10 ++--- .../serial-udp-chardev.x86_64-latest.args | 10 ++--- .../serial-unix-chardev.x86_64-latest.args | 8 ++-- .../serial-vc-chardev.x86_64-latest.args | 8 ++-- ...rtcard-passthrough-unix.x86_64-latest.args | 8 ++-- .../tpm-emulator-spapr.ppc64-latest.args | 14 +++---- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 6 +-- ...pm-emulator-tpm2-pstate.x86_64-latest.args | 6 +-- .../tpm-emulator-tpm2.x86_64-latest.args | 6 +-- .../tpm-emulator.x86_64-latest.args | 6 +-- .../tpm-passthrough-crb.x86_64-latest.args | 6 +-- .../tpm-passthrough.x86_64-latest.args | 6 +-- .../tseg-explicit-size.x86_64-latest.args | 10 ++--- .../usb-redir-unix.x86_64-latest.args | 14 +++---- ...vhost-user-fs-fd-memory.x86_64-latest.args | 2 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 12 +++--- ...host-user-gpu-secondary.x86_64-latest.args | 10 ++--- .../vhost-user-vga.x86_64-latest.args | 8 ++-- .../vhost-vsock-auto.x86_64-latest.args | 6 +-- .../vhost-vsock.x86_64-latest.args | 6 +-- ...eo-bochs-display-device.x86_64-latest.args | 8 ++-- ...video-qxl-device-vram64.x86_64-latest.args | 6 +-- ...o-qxl-sec-device-vram64.x86_64-latest.args | 8 ++-- ...eo-ramfb-display-device.x86_64-latest.args | 8 ++-- ...video-virtio-vga-gpu-gl.x86_64-latest.args | 8 ++-- .../virtio-9p-createmode.x86_64-latest.args | 14 +++---- .../virtio-9p-multidevs.x86_64-latest.args | 12 +++--- .../virtio-lun.x86_64-latest.args | 12 +++--- ...virtio-non-transitional.x86_64-latest.args | 42 +++++++++---------- ...-options-controller-ats.x86_64-latest.args | 12 +++--- ...ptions-controller-iommu.x86_64-latest.args | 12 +++--- ...tions-controller-packed.x86_64-latest.args | 12 +++--- ...virtio-options-disk-ats.x86_64-latest.args | 8 ++-- ...rtio-options-disk-iommu.x86_64-latest.args | 8 ++-- ...tio-options-disk-packed.x86_64-latest.args | 8 ++-- .../virtio-options-fs-ats.x86_64-latest.args | 8 ++-- ...virtio-options-fs-iommu.x86_64-latest.args | 8 ++-- ...irtio-options-fs-packed.x86_64-latest.args | 8 ++-- ...irtio-options-input-ats.x86_64-latest.args | 8 ++-- ...tio-options-input-iommu.x86_64-latest.args | 8 ++-- ...io-options-input-packed.x86_64-latest.args | 8 ++-- ...-options-memballoon-ats.x86_64-latest.args | 4 +- ...loon-freepage-reporting.x86_64-latest.args | 4 +- ...ptions-memballoon-iommu.x86_64-latest.args | 4 +- ...tions-memballoon-packed.x86_64-latest.args | 4 +- .../virtio-options-net-ats.x86_64-latest.args | 8 ++-- ...irtio-options-net-iommu.x86_64-latest.args | 8 ++-- ...rtio-options-net-packed.x86_64-latest.args | 8 ++-- .../virtio-options-rng-ats.x86_64-latest.args | 8 ++-- ...irtio-options-rng-iommu.x86_64-latest.args | 8 ++-- ...rtio-options-rng-packed.x86_64-latest.args | 8 ++-- ...irtio-options-video-ats.x86_64-latest.args | 8 ++-- ...tio-options-video-iommu.x86_64-latest.args | 8 ++-- ...io-options-video-packed.x86_64-latest.args | 8 ++-- .../virtio-options.x86_64-latest.args | 28 ++++++------- .../virtio-rng-builtin.x86_64-latest.args | 6 +-- .../virtio-rng-egd-unix.x86_64-latest.args | 6 +-- .../virtio-transitional.x86_64-latest.args | 26 ++++++------ .../watchdog-device.x86_64-latest.args | 8 ++-- .../watchdog-dump.x86_64-latest.args | 8 ++-- .../watchdog-injectnmi.x86_64-latest.args | 8 ++-- .../watchdog.x86_64-latest.args | 6 +-- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 6 +-- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 14 +++---- ...efault-cpu-tcg-features.x86_64-latest.args | 10 ++--- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 6 +-- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 14 +++---- .../x86_64-pc-graphics.x86_64-latest.args | 20 ++++----- .../x86_64-pc-headless.x86_64-latest.args | 16 +++---- .../x86_64-q35-graphics.x86_64-latest.args | 34 +++++++-------- .../x86_64-q35-headless.x86_64-latest.args | 30 ++++++------- 320 files changed, 1335 insertions(+), 1306 deletions(-) -- 2.31.1

4 12

[PATCH 0/3] VirtioNet RSS support
by Andrew Melnychenko 04 Jan '22

04 Jan '22

This series of patches add RSS property support for virtio-net-pci. Virtio RSS effectively works with TAP devices, it requires additional vectors for VirtioNet, queues for TAP device, and vCPU cores. Example of device configuration: ``` <interface type="network"> <mac address="52:54:00:c4:90:25"/> <source network="default"/> <model type="virtio"/> <driver name="qemu" queues="9" rss="on" rss_hash_report="off"/> <address type="pci" domain="0x0000" bus="0x01" slot="0x00" function="0x0"/> </interface> ``` Capability "rss" enables RSS, "rss_hash_report" - enables hashes in vheader. For now, "rss" property will trigger "in-qemu" RSS in most cases. Current Qemu(6.2) supports eBPF RSS that may require additional capabilities. In future, the helper will be provided. And this code is the base for VirtIO RSS. Changes since RFC: * rebased and refactored * added tests * postponed the helper Andrew Melnychenko (3): domain_conf: Added configs for RSS and Hash report. qemu_capabilities: Added capabilites for qemu's "rss" and "hash". test: Added caps, xml2argv and xml2xml tests. docs/formatdomain.rst | 15 ++++++++ docs/schemas/domaincommon.rng | 10 ++++++ src/conf/domain_conf.c | 31 +++++++++++++++- src/conf/domain_conf.h | 2 ++ src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 2 ++ src/qemu/qemu_validate.c | 16 +++++++++ .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + tests/qemuxml2argvdata/net-virtio-hash.args | 35 +++++++++++++++++++ tests/qemuxml2argvdata/net-virtio-hash.xml | 29 +++++++++++++++ tests/qemuxml2argvdata/net-virtio-rss.args | 35 +++++++++++++++++++ tests/qemuxml2argvdata/net-virtio-rss.xml | 29 +++++++++++++++ .../qemuxml2argvdata/net-virtio-rsshash.args | 35 +++++++++++++++++++ tests/qemuxml2argvdata/net-virtio-rsshash.xml | 29 +++++++++++++++ .../virtio-options.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-options.xml | 2 +- tests/qemuxml2argvtest.c | 7 ++++ 30 files changed, 292 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/net-virtio-hash.args create mode 100644 tests/qemuxml2argvdata/net-virtio-hash.xml create mode 100644 tests/qemuxml2argvdata/net-virtio-rss.args create mode 100644 tests/qemuxml2argvdata/net-virtio-rss.xml create mode 100644 tests/qemuxml2argvdata/net-virtio-rsshash.args create mode 100644 tests/qemuxml2argvdata/net-virtio-rsshash.xml -- 2.34.1

4 8

[PATCH V4 0/6] Add virDomainSetLaunchSecurityState API
by Jim Fehlig 04 Jan '22

04 Jan '22

V4 of https://listman.redhat.com/archives/libvir-list/2021-December/msg00686.html Similar to previous versions, this series is compile-tested only. I plan to work on functional testing soon. Changes since V3: - Set secret and secret header read buffer to 64k - Add capability for sev-inject-launch-secret qmp command - Add NEWS entry Jim Fehlig (6): libvirt: Introduce virDomainSetLaunchSecurityState public API remote: Add RPC support for the virDomainSetLaunchSecurityState API qemu_capabilities: Introduce QEMU_CAPS_SEV_INJECT_LAUNCH_SECRET qemu: Implement the virDomainSetLaunchSecurityState API tools: Add domsetlaunchsecstate virsh command NEWS: Mention new virDomainSetLaunchSecurityState API NEWS.rst | 6 + docs/manpages/virsh.rst | 25 ++++ include/libvirt/libvirt-domain.h | 36 ++++++ src/driver-hypervisor.h | 7 ++ src/libvirt-domain.c | 62 ++++++++++ src/libvirt_public.syms | 5 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 100 ++++++++++++++++ src/qemu/qemu_monitor.c | 14 +++ src/qemu/qemu_monitor.h | 7 ++ src/qemu/qemu_monitor_json.c | 45 ++++++++ src/qemu/qemu_monitor_json.h | 6 + src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 ++- src/remote_protocol-structs | 9 ++ .../caps_6.0.0.x86_64.xml | 1 + .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + tests/qemumonitorjsontest.c | 3 + tools/virsh-domain.c | 107 ++++++++++++++++++ 21 files changed, 455 insertions(+), 1 deletion(-) -- 2.34.1

2 9

[PATCH 0/4] Rework <tpm/> formatting
by Michal Privoznik 04 Jan '22

04 Jan '22

Please note that the test suite is temporarily broken after 2/4 but fixed in 3/4. This could be resolved be swapping those two patches, but I figured I keep the order to demonstrate the bug. However, I can do the swap if desired. Michal Prívozník (4): qemuxml2xmltest: Introduce tpm-emulator-spapr test qemuxml2xmloutdata: Turn tpm-*.xml files into symlinks conf: Rework <tpm/> formatting conf: Make virDomainTPMDefFormat() return void src/conf/domain_conf.c | 65 +++++++--------- tests/qemuxml2argvdata/tpm-emulator-spapr.xml | 74 +++++++++++-------- .../tpm-emulator-tpm2-enc.xml | 12 ++- .../tpm-emulator-tpm2-pstate.xml | 12 ++- tests/qemuxml2argvdata/tpm-emulator-tpm2.xml | 13 +++- tests/qemuxml2argvdata/tpm-emulator.xml | 12 ++- .../qemuxml2argvdata/tpm-passthrough-crb.xml | 12 ++- tests/qemuxml2argvdata/tpm-passthrough.xml | 12 ++- .../tpm-emulator-spapr.ppc64-latest.xml | 1 + .../tpm-emulator-tpm2-enc.x86_64-latest.xml | 41 +--------- ...tpm-emulator-tpm2-pstate.x86_64-latest.xml | 39 +--------- .../tpm-emulator-tpm2.x86_64-latest.xml | 44 +---------- .../tpm-emulator.x86_64-latest.xml | 39 +--------- .../tpm-passthrough-crb.x86_64-latest.xml | 41 +--------- .../tpm-passthrough.x86_64-latest.xml | 41 +--------- tests/qemuxml2xmltest.c | 1 + 16 files changed, 138 insertions(+), 321 deletions(-) create mode 120000 tests/qemuxml2xmloutdata/tpm-emulator-spapr.ppc64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-emulator-tpm2-enc.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-emulator-tpm2-pstate.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-emulator-tpm2.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-emulator.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-passthrough-crb.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-passthrough.x86_64-latest.xml -- 2.34.1

4 12

[PATCH] rpc: Require dtrace sources to be generated first
by Michal Privoznik 04 Jan '22

04 Jan '22

The virt_socket_lib is built from virnetsocket.c (among others). But this file includes virprobe.h which includes libvirt_probes.h which is a generated file. But this dependency is not recorded in meson which may lead to a failed build. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I don't know if this is the right fix or we need to go with declare_dependency(), or even something else. But this fixes the build for me. src/rpc/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/meson.build b/src/rpc/meson.build index 7fde92e6cf..36a2809adf 100644 --- a/src/rpc/meson.build +++ b/src/rpc/meson.build @@ -9,6 +9,7 @@ socket_sources = [ virt_socket_lib = static_library( 'virt_socket', [ + dtrace_gen_headers, socket_sources, ], dependencies: [ -- 2.32.0

2 1

[PATCH v2] Add VM info to improve error log message for qemu monitor
by Rohit Kumar 04 Jan '22

04 Jan '22

This patch is to determine the VM which had IO or socket hangup error. Accessing directly vm->def->name inside qemuMonitorIO() or qemuMonitorSend() might leads to illegal access as we are out of 'vm' context and vm->def might not exist. Adding a field "domainName" inside mon object to access vm name and initialising it when creating mon object. Signed-off-by: Rohit Kumar <rohit.kumar3(a)nutanix.com> --- diff to v1: - Adding a field domainName inside _qemuMonitor struct for accessing vm name instead of directly accessing mon->vm->def->name. - Link to v1: https://listman.redhat.com/archives/libvir-list/2021-December/msg00217.html - Talked with peter on RFC and he suggested me to add a field inside monitor struct to get VM name. src/qemu/qemu_monitor.c | 47 +++++++++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index dda6ae9796..c3a0227795 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -80,6 +80,7 @@ struct _qemuMonitor { GSource *watch; virDomainObj *vm; + char *domainName; qemuMonitorCallbacks *cb; void *callbackOpaque; @@ -243,6 +244,7 @@ qemuMonitorDispose(void *obj) virCondDestroy(&mon->notify); g_free(mon->buffer); g_free(mon->balloonpath); + g_free(mon->domainName); } @@ -530,13 +532,18 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, qemuMonitor *mon = opaque; bool error = false; bool hangup = false; + virDomainObj *vm = NULL; + char *vmName = NULL; virObjectRef(mon); + vm = mon->vm; + vmName = mon->domainName; + /* lock access to the monitor and protect fd */ virObjectLock(mon); #if DEBUG_IO - VIR_DEBUG("Monitor %p I/O on socket %p cond %d", mon, socket, cond); + VIR_DEBUG("Monitor %p I/O on socket %p cond %d vm=%p name=%s", mon, socket, cond, vm, NULLSTR(vmName)); #endif if (mon->fd == -1 || !mon->watch) { virObjectUnlock(mon); @@ -583,8 +590,8 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, if (!error && !mon->goteof && cond & G_IO_ERR) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Invalid file descriptor while waiting for monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("%s: Invalid file descriptor while waiting for monitor"), NULLSTR(vmName)); mon->goteof = true; } } @@ -609,13 +616,14 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, virResetLastError(); } else { if (virGetLastErrorCode() == VIR_ERR_OK && !mon->goteof) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Error while processing monitor IO")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("%s: Error while processing monitor IO"), NULLSTR(vmName)); virCopyLastError(&mon->lastError); virResetLastError(); } - VIR_DEBUG("Error on monitor %s", NULLSTR(mon->lastError.message)); + VIR_DEBUG("Error on monitor %s mon=%p vm=%p name=%s", + NULLSTR(mon->lastError.message), mon, vm, NULLSTR(vmName)); /* If IO process resulted in an error & we have a message, * then wakeup that waiter */ if (mon->msg && !mon->msg->finished) { @@ -631,22 +639,22 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, * will try to acquire the virDomainObj *mutex next */ if (mon->goteof) { qemuMonitorEofNotifyCallback eofNotify = mon->cb->eofNotify; - virDomainObj *vm = mon->vm; /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering EOF callback"); + VIR_DEBUG("Triggering EOF callback mon=%p vm=%p name=%s", + mon, vm, NULLSTR(vmName)); (eofNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else if (error) { qemuMonitorErrorNotifyCallback errorNotify = mon->cb->errorNotify; - virDomainObj *vm = mon->vm; /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering error callback"); + VIR_DEBUG("Triggering error callback mon=%p vm=%p name=%s", + mon, vm, NULLSTR(vmName)); (errorNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else { @@ -694,6 +702,7 @@ qemuMonitorOpenInternal(virDomainObj *vm, mon->fd = fd; mon->context = g_main_context_ref(context); mon->vm = virObjectRef(vm); + mon->domainName = g_strdup(vm->def->name); mon->waitGreeting = true; mon->cb = cb; mon->callbackOpaque = opaque; @@ -932,17 +941,19 @@ qemuMonitorSend(qemuMonitor *mon, qemuMonitorMessage *msg) { int ret = -1; + virDomainObj *vm = mon->vm; + char *vmName = mon->domainName; /* Check whether qemu quit unexpectedly */ if (mon->lastError.code != VIR_ERR_OK) { - VIR_DEBUG("Attempt to send command while error is set %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Attempt to send command while error is set %s mon=%p vm=%p name=%s", + NULLSTR(mon->lastError.message), mon, vm, NULLSTR(vmName)); virSetError(&mon->lastError); return -1; } if (mon->goteof) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("End of file from qemu monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("%s: End of file from qemu monitor"), NULLSTR(vmName)); return -1; } @@ -955,15 +966,15 @@ qemuMonitorSend(qemuMonitor *mon, while (!mon->msg->finished) { if (virCondWait(&mon->notify, &mon->parent.lock) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to wait on monitor condition")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("%s: Unable to wait on monitor condition"), NULLSTR(vmName)); goto cleanup; } } if (mon->lastError.code != VIR_ERR_OK) { - VIR_DEBUG("Send command resulted in error %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Send command resulted in error %s mon=%p vm=%p name=%s", + NULLSTR(mon->lastError.message), mon, vm, NULLSTR(vmName)); virSetError(&mon->lastError); goto cleanup; } -- 2.25.1

3 12

[PATCH v2 0/3] Rework <tpm/> formatting
by Michal Privoznik 04 Jan '22

04 Jan '22

v2 of: https://listman.redhat.com/archives/libvir-list/2022-January/msg00047.html diff to v1: - Pushed 1/4 from the original series, because it was acked and independent of the rest. - Swapped two patches to make the test suite pass after each single patch. - Renamed variable in 1/3 (3/4 in the original series) per Peter's suggestion. Michal Prívozník (3): conf: Rework <tpm/> formatting qemuxml2xmloutdata: Turn tpm-*.xml files into symlinks conf: Make virDomainTPMDefFormat() return void src/conf/domain_conf.c | 65 ++++++++----------- .../tpm-emulator-tpm2-enc.xml | 12 +++- .../tpm-emulator-tpm2-pstate.xml | 12 +++- tests/qemuxml2argvdata/tpm-emulator-tpm2.xml | 13 +++- tests/qemuxml2argvdata/tpm-emulator.xml | 12 +++- .../qemuxml2argvdata/tpm-passthrough-crb.xml | 12 +++- tests/qemuxml2argvdata/tpm-passthrough.xml | 12 +++- .../tpm-emulator-tpm2-enc.x86_64-latest.xml | 41 +----------- ...tpm-emulator-tpm2-pstate.x86_64-latest.xml | 39 +---------- .../tpm-emulator-tpm2.x86_64-latest.xml | 44 +------------ .../tpm-emulator.x86_64-latest.xml | 39 +---------- .../tpm-passthrough-crb.x86_64-latest.xml | 41 +----------- .../tpm-passthrough.x86_64-latest.xml | 41 +----------- 13 files changed, 94 insertions(+), 289 deletions(-) mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-emulator-tpm2-enc.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-emulator-tpm2-pstate.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-emulator-tpm2.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-emulator.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-passthrough-crb.x86_64-latest.xml mode change 100644 => 120000 tests/qemuxml2xmloutdata/tpm-passthrough.x86_64-latest.xml -- 2.34.1

2 4

[PATCH] conf: Extend TPM ABI stability check for <active_pcr_banks/>
by Michal Privoznik 04 Jan '22

04 Jan '22

Changing <active_pcr_banks/> means changing the guest ABI and as such must be prevented on both restoring from a file or migration. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2035888 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_conf.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 716c6d2240..bba662bf4c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -21994,6 +21994,20 @@ virDomainTPMDefCheckABIStability(virDomainTPMDef *src, return false; } + switch (src->type) { + case VIR_DOMAIN_TPM_TYPE_EMULATOR: + if (src->data.emulator.activePcrBanks != dst->data.emulator.activePcrBanks) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Target active PCR banks doesn't match source")); + return false; + } + break; + + case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH: + case VIR_DOMAIN_TPM_TYPE_LAST: + break; + } + return virDomainDeviceInfoCheckABIStability(&src->info, &dst->info); } -- 2.34.1

2 1

[PATCH] ci: Refresh configuration
by Andrea Bolognani 03 Jan '22

03 Jan '22

Notable changes: * drop libdbus and radvd; * add codespell. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the CI refresh rule. Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/440555431 Full patch: https://gitlab.com/libvirt/libvirt/-/commit/d004171806f1364c8a0112e02329ff0… ci/cirrus/freebsd-12.vars | 2 +- ci/cirrus/freebsd-13.vars | 2 +- ci/cirrus/freebsd-current.vars | 2 +- ci/cirrus/macos-11.vars | 2 +- ci/containers/centos-8.Dockerfile | 4 +--- ci/containers/centos-stream-8.Dockerfile | 4 +--- ci/containers/debian-10-cross-aarch64.Dockerfile | 3 +-- ci/containers/debian-10-cross-armv6l.Dockerfile | 3 +-- ci/containers/debian-10-cross-armv7l.Dockerfile | 3 +-- ci/containers/debian-10-cross-i686.Dockerfile | 3 +-- ci/containers/debian-10-cross-mips.Dockerfile | 3 +-- ci/containers/debian-10-cross-mips64el.Dockerfile | 3 +-- ci/containers/debian-10-cross-mipsel.Dockerfile | 3 +-- ci/containers/debian-10-cross-ppc64le.Dockerfile | 3 +-- ci/containers/debian-10-cross-s390x.Dockerfile | 3 +-- ci/containers/debian-10.Dockerfile | 3 +-- ci/containers/debian-11-cross-aarch64.Dockerfile | 6 ++---- ci/containers/debian-11-cross-armv6l.Dockerfile | 6 ++---- ci/containers/debian-11-cross-armv7l.Dockerfile | 6 ++---- ci/containers/debian-11-cross-i686.Dockerfile | 6 ++---- ci/containers/debian-11-cross-mips64el.Dockerfile | 6 ++---- ci/containers/debian-11-cross-mipsel.Dockerfile | 6 ++---- ci/containers/debian-11-cross-ppc64le.Dockerfile | 6 ++---- ci/containers/debian-11-cross-s390x.Dockerfile | 6 ++---- ci/containers/debian-11.Dockerfile | 6 ++---- ci/containers/debian-sid-cross-aarch64.Dockerfile | 6 ++---- ci/containers/debian-sid-cross-armv6l.Dockerfile | 6 ++---- ci/containers/debian-sid-cross-armv7l.Dockerfile | 6 ++---- ci/containers/debian-sid-cross-i686.Dockerfile | 6 ++---- ci/containers/debian-sid-cross-mips64el.Dockerfile | 6 ++---- ci/containers/debian-sid-cross-mipsel.Dockerfile | 6 ++---- ci/containers/debian-sid-cross-ppc64le.Dockerfile | 6 ++---- ci/containers/debian-sid-cross-s390x.Dockerfile | 6 ++---- ci/containers/debian-sid.Dockerfile | 6 ++---- ci/containers/fedora-34.Dockerfile | 8 +++----- ci/containers/fedora-35-cross-mingw32.Dockerfile | 6 ++---- ci/containers/fedora-35-cross-mingw64.Dockerfile | 6 ++---- ci/containers/fedora-35.Dockerfile | 8 +++----- ci/containers/fedora-rawhide-cross-mingw32.Dockerfile | 6 ++---- ci/containers/fedora-rawhide-cross-mingw64.Dockerfile | 6 ++---- ci/containers/fedora-rawhide.Dockerfile | 8 +++----- ci/containers/opensuse-leap-152.Dockerfile | 3 +-- ci/containers/opensuse-tumbleweed.Dockerfile | 3 +-- ci/containers/ubuntu-1804.Dockerfile | 6 ++---- ci/containers/ubuntu-2004.Dockerfile | 6 ++---- 45 files changed, 75 insertions(+), 145 deletions(-) diff --git a/ci/cirrus/freebsd-13.vars b/ci/cirrus/freebsd-13.vars index 4845d8d461..480a403361 100644 --- a/ci/cirrus/freebsd-13.vars +++ b/ci/cirrus/freebsd-13.vars @@ -11,6 +11,6 @@ MAKE='/usr/local/bin/gmake' NINJA='/usr/local/bin/ninja' PACKAGING_COMMAND='pkg' PIP3='/usr/local/bin/pip-3.8' -PKGS='augeas bash-completion ca_root_nss ccache cppi curl cyrus-sasl dbus diffutils diskscrub dnsmasq fusefs-libs gettext git glib gmake gnugrep gnutls gsed libpcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 pkgconf polkit py38-docutils py38-flake8 python3 qemu radvd readline yajl' +PKGS='augeas bash-completion ca_root_nss ccache codespell cppi curl cyrus-sasl diffutils diskscrub dnsmasq fusefs-libs gettext git glib gmake gnugrep gnutls gsed libpcap libpciaccess libssh libssh2 libxml2 libxslt meson ninja perl5 pkgconf polkit py38-docutils py38-flake8 python3 qemu readline yajl' PYPI_PKGS='' PYTHON='/usr/local/bin/python3' diff --git a/ci/containers/debian-11.Dockerfile b/ci/containers/debian-11.Dockerfile index e26b89d1d9..ce66568fb5 100644 --- a/ci/containers/debian-11.Dockerfile +++ b/ci/containers/debian-11.Dockerfile @@ -17,6 +17,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ ca-certificates \ ccache \ clang \ + codespell \ cpp \ diffutils \ dnsmasq-base \ @@ -39,7 +40,6 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ libc6-dev \ libcap-ng-dev \ libcurl4-gnutls-dev \ - libdbus-1-dev \ libdevmapper-dev \ libfuse-dev \ libglib2.0-dev \ @@ -81,14 +81,12 @@ RUN export DEBIAN_FRONTEND=noninteractive && \ python3 \ python3-docutils \ qemu-utils \ - radvd \ scrub \ sed \ systemtap-sdt-dev \ wireshark-dev \ xfslibs-dev \ - xsltproc \ - zfs-fuse && \ + xsltproc && \ eatmydata apt-get autoremove -y && \ eatmydata apt-get autoclean -y && \ sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ [... a lot more like this ...] -- 2.31.1

1 0

[PATCH] qemu: monitor: Remove disabled debug infrastructure
by Peter Krempa 03 Jan '22

03 Jan '22

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_monitor.c | 44 ----------------------------------------- 1 file changed, 44 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index dda6ae9796..32e4ff1191 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -56,9 +56,6 @@ VIR_LOG_INIT("qemu.qemu_monitor"); -#define DEBUG_IO 0 -#define DEBUG_RAW_IO 0 - /* We read from QEMU until seeing a \r\n pair to indicate a * completed reply or event. To avoid memory denial-of-service * though, we must have a size limit on amount of data we @@ -210,25 +207,6 @@ VIR_ENUM_IMPL(qemuMonitorMemoryFailureAction, "ignore", "inject", "fatal", "reset"); -#if DEBUG_RAW_IO -static char * -qemuMonitorEscapeNonPrintable(const char *text) -{ - size_t i; - g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - for (i = 0; text[i] != '\0'; i++) { - if (g_ascii_isprint(text[i]) || - text[i] == '\n' || - (text[i] == '\r' && text[i + 1] == '\n')) - virBufferAddChar(&buf, text[i]); - else - virBufferAsprintf(&buf, "0x%02x", text[i]); - } - return virBufferContentAndReset(&buf); -} -#endif - - static void qemuMonitorDispose(void *obj) { @@ -329,17 +307,6 @@ qemuMonitorIOProcess(qemuMonitor *mon) if (mon->msg && mon->msg->txOffset == mon->msg->txLength) msg = mon->msg; -#if DEBUG_IO -# if DEBUG_RAW_IO - char *str1 = qemuMonitorEscapeNonPrintable(msg ? msg->txBuffer : ""); - char *str2 = qemuMonitorEscapeNonPrintable(mon->buffer); - VIR_ERROR(_("Process %d %p %p [[[[%s]]][[[%s]]]"), (int)mon->bufferOffset, mon->msg, msg, str1, str2); - VIR_FREE(str1); - VIR_FREE(str2); -# else - VIR_DEBUG("Process %d", (int)mon->bufferOffset); -# endif -#endif PROBE_QUIET(QEMU_MONITOR_IO_PROCESS, "mon=%p buf=%s len=%zu", mon, mon->buffer, mon->bufferOffset); @@ -360,10 +327,6 @@ qemuMonitorIOProcess(qemuMonitor *mon) VIR_FREE(mon->buffer); mon->bufferOffset = mon->bufferLength = 0; } -#if DEBUG_IO - VIR_DEBUG("Process done %d used %d", (int)mon->bufferOffset, len); -#endif - /* As the monitor mutex was unlocked in qemuMonitorJSONIOProcess() * while dealing with qemu event, mon->msg could be changed which * means the above 'msg' may be invalid, thus we use 'mon->msg' here */ @@ -505,10 +468,6 @@ qemuMonitorIORead(qemuMonitor *mon) mon->buffer[mon->bufferOffset] = '\0'; } -#if DEBUG_IO - VIR_DEBUG("Now read %d bytes of data", (int)mon->bufferOffset); -#endif - return ret; } @@ -535,9 +494,6 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, /* lock access to the monitor and protect fd */ virObjectLock(mon); -#if DEBUG_IO - VIR_DEBUG("Monitor %p I/O on socket %p cond %d", mon, socket, cond); -#endif if (mon->fd == -1 || !mon->watch) { virObjectUnlock(mon); virObjectUnref(mon); -- 2.31.1

2 1

CDROM hotplug not supported even with usb bus
by Tianren Zhang 03 Jan '22

03 Jan '22

Hi, I am using libvirt-4.5.0 + qemu-kvm-ev-2.12.0 and I have a question about the cdrom function of libvirt. When I tried to attach a CD ROM, it rejected the operation showing "cdrom/floppy device hotplug isn't supported". I understand that it should be rejected when the IDE bus is used, but the hotplug with USB bus is totally feasible, as it's also supported in qemu, in this case, should it be allowed for hotplug? I have not tried the newest version of libvirt yet, but looking at the upstream source code it seems that there is no change regarding this issue. Thank you, Tianren Zhang

2 1

[PATCH] virnettlscontext: Generate longer DH keys
by Michal Privoznik 03 Jan '22

03 Jan '22

Currently, we generate 2048 bits long DH keys. This may look enough, but it's not very future proof. When system crypto policy is tightened only 3072 or longer keys are valid. From CRYPTO-POLICIES(7): FUTURE A conservative security policy that is believed to withstand any near-term future attacks. ... • DH params size: >= 3072 • RSA keys size: >= 3072 This policy corresponds to GNUTLS_SEC_PARAM_HIGH parameters. Therefore, pass that to gnutls_sec_param_to_pk_bits() to get longer key. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Technically, this is a v2 of: https://listman.redhat.com/archives/libvir-list/2021-December/msg00827.html and was already reviewed. I'm sending it here because I've split the original patch into two. The first one, which switches to gnutls_sec_param_to_pk_bits() usage is merged. The second one (this one) which lengthens the key is not. src/rpc/virnettlscontext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 55da485f96..f0b1e8f9c1 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -718,7 +718,7 @@ static virNetTLSContext *virNetTLSContextNew(const char *cacert, if (isServer) { unsigned int bits = 0; - bits = gnutls_sec_param_to_pk_bits(GNUTLS_PK_DH, GNUTLS_SEC_PARAM_MEDIUM); + bits = gnutls_sec_param_to_pk_bits(GNUTLS_PK_DH, GNUTLS_SEC_PARAM_HIGH); if (bits == 0) { virReportError(VIR_ERR_SYSTEM_ERROR, "%s", _("Unable to get key length for diffie-hellman parameters")); -- 2.34.1

2 1

[libvirt PATCH 0/3] tests: virtimetest: Skip more tests near year's end
by Andrea Bolognani 03 Jan '22

03 Jan '22

Failed pipeline: https://gitlab.com/libvirt/libvirt/-/pipelines/439750804 Fixed pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/439847251 Andrea Bolognani (3): tests: virtimetest: Move comment tests: virtimetest: Skip more tests near year's end tests: virtimetest: Mention GLib version containing fix tests/virtimetest.c | 58 ++++++++++++++++++++++----------------------- 1 file changed, 28 insertions(+), 30 deletions(-) -- 2.31.1

2 5