- Devel - libvirt List Archives

[Libvir] Win Pro 64 dies in second half of windows guest installation
by Lawrence Nitz 10 Oct '07

10 Oct '07

When I set up a guest VM using virtp-install on a Fedor a 7 system, the process gets as far as reading the raw device (/dev/scd0) for the install disk, writes the basic windows data onto the disk, and then reboots to complete the Windows installation. At this point the installation hangs, with a diagnostic that says the file cannot be found. The same error occurs whether the install is from the hard disk image or from the cd-rom. The install gets half done, and has nothing to read when the install program restarts itself. In the Virt manager the edit command allows me to edit the machine, but not to add back the cd drive, only add network cards and hard disk partitions. Any help by a more experienced virt-install user would be much appreciated. Larry Nitz.

1 0

[Libvir] Problems with defineXML in python..
by Mark Dehus 10 Oct '07

10 Oct '07

I am having some problems getting libvirt under python to work properly. I can setup new domains by using the createLinux() function, but when I attempt to use defineXML() it fails with no reason given other then "virDomainDefineXML() failed". I am using the same XML file for both functions. This is on a Ubuntu 7.04 server running python 2.5 & libvirt 0.1.8 (from the ubuntu universe repo). Here is my test code: import libvirt import sys import xml import random try: conn = libvirt.open(None) except Exception, e: print e if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) create = True if create: xmlfile = open('webserv.xml') xmldesc = xmlfile.read() xmlfile.close() try: # webserv = conn.createLinux(xmldesc, 0) webserv = conn.defineXML(xmldesc) except Exception, e: print 'Failed to create webserv: %s' % e sys.exit(1) if webserv is None: print 'whoops this shouldnt happen!' conn.create(webserv) try: print "Domain 0: id %d running %s" % (webserv.ID(), webserv.OSType()) print webserv.info() print webserv.XMLDesc(0) except Exception, e: print e #webserv.shutdown() And the XML file: <domain type='xen' > <name>webserv</name> <os> <type>linux</type> <kernel>/boot/vmlinuz-2.6.19-4-generic-amd64</kernel> <initrd>/boot/initrd.img-2.6.19-4-generic-amd64</initrd> <root>/dev/hda1</root> </os> <memory>1024</memory> <vcpu>1</vcpu> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <interface type='bridge'> <source bridge='xenbr0'/> <mac address='00:16:3e:24:27:a5'/> <script path='vif-bridge'/> </interface> <graphics type='vnc' port='5902'/> <disk type='file' device='disk'> <driver name='tap' type='aio'/> <source file='/virtual/images/webserv/webserv.img'/> <target dev='hda1'/> </disk> <console tty='/dev/pts/4'/> </devices> </domain> Am I missing something simple, or is there a bug? Thanks!

2 1

[Libvir] [PATCH] Topology fix for "no cpus"
by beth kon 08 Oct '07

08 Oct '07

Here is a resubmission of this patch, corrected. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

2 1

[Libvir] [PATCH] Found minor bug in topology code
by beth kon 05 Oct '07

05 Oct '07

I found a problem with an error path... I was cutting off incrementing of a value in the loop then checking if it was too big after the loop, so the way it was structured, it could never happen. Here is the fix. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

2 1

[Libvir] PATCH: Updated patches for PolicyKit support
by Daniel P. Berrange 03 Oct '07

03 Oct '07

A few weeks back I posted some prototype patches for PolicyKit support to allow the main libvirt daemon socket to be made world-accessible. PolicyKit then can do ACLs on incoming connections, allowing definition of rules which could for example, allow only the user who owns the active X login sesion http://www.redhat.com/archives/libvir-list/2007-August/msg00027.html This is an updated patch which takes account of a change in the PolicyKit XML file syntax between 0.4 and 0.5 releases. The configure.in scripts has been tweaked to automatically disable PolicyKit if pkg-config is not available instead of aborting. The code for getting UNIX socket credentials has been factored out into its own method. There is still only a Linux implementation. I was going to take the code for other OS from DBus, but DBus is currently under a GPL/Academic license options, which is not compatible with LGPL. Fortunately DBus is in middle of re-licensing to X11 style which is LGPL compatible, so in a week or so's time we'll be able to safely take their OS portability code for socket credentials. I short-circuit the logic to always allow root. This allows existing people running libvirt tools as root to continue use without any regressions. There is one small issue still that the default policy I provide only allows the use of read-only connections if the user is logged into to the desktop. This is a partial regression - the admin can edit /etc/PolicyKit/PolicyKit.conf and add a site-local rule allowing all users access, regardless of whether they're in a session. I've spoken with David Zeuthan and he's going to add ability to specify rules for non-session clients in the default policy config files, which will fix this minor regression. Once this is done the libvirt default policy will be identical to current file permission based policy (root == full access, non-root == read only). As I mentioned previously, with this change it is now possible to open a full read-write connection from virt-manager running as non-root. Depending on site policy it will optionally prompt for root password (su style equiv) or the user's password (sudo style equiv) without needing virt-manager itself to gain any elevated privileges. When compiling with PolicyKit support, the default file permissions for both the main & readonly UNIX sockets in the daemon switch to 0777, instead of the previous 0700 & 0777. It is possible to turn off PolicyKit auth in the daemon config file, even if it is compiled in - in which case the default permissions get set back to 0700 & 0777. Although in previous feedback Daniel suggested I leave the LIBVIRTD_AUTH_POLKIT constant compiled in all the time, I feel it is better to remove it when the policykit support is disabled in configure. This removes the need to have extra switch/case statements to explicitly reject LIBVIRTD_AUTH_POLKIT auth, since it will be handle by the 'default:' statement which already has code to reject connections. I've done more extensive testing with virt-manager since my previous patch, and its working very nicely with the new UI which allows multiple hypervisor connections. Instead of asking for the root password up-front at app start time, we now only need ask for it if the user connects to a local HV. If they only ever manage remote connections we don't need to do anything with the local root password. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 4

[Libvir] Release of libvirt-0.3.3
by Daniel Veillard 30 Sep '07

30 Sep '07

More than a month without a release ... it was clearly time to push the bits out. Available as usual from ftp://libvirt.org/libvirt/ A lot of new things in the last month: * New features: - Avahi mDNS daemon export (Daniel Berrange) - NUMA support (Beth Kan) * Documentation: - cleanups (Toth Istvan) - typos (Eduardo Pereira) * Bug fixes: - memory corruption on large dumps (Masayuki Sunou) - fix virsh vncdisplay command exit (Masayuki Sunou) - Fix network stats TX/RX result (Richard Jones) - warning on Xen 3.0.3 (Richard Jones) - missing buffer check in virDomainXMLDevID (Hugh Brock) - avoid zombies when using remote (Daniel Berrange) - xend connection error message (Richard Jones) - avoid ssh tty prompt (Daniel Berrange) - username handling for remote URIs (Fabian Deutsch) - fix potential crash on multiple input XML tags (Daniel Berrange) - Solaris Xen hypercalls fixup (Mark Johnson) * Improvements: - OpenVZ support (Shuveb Hussain and Anoop Cyriac) - CD-Rom reload on XEn (Hugh Brock) - PXE boot got QEmu/KVM (Daniel Berrange) - QEmu socket permissions customization (Daniel Berrange) - more QEmu support (Richard Jones) - better path detection for qemu and dnsmasq (Richard Jones) - QEmu flags are per-Domain (Daniel Berrange) - virsh freecell command - Solaris portability fixes (Mark Johnson) - default bootloader support (Daniel Berrange) - new virNodeGetFreeMemory API - vncpasswd extraction in configuration files if secure (Mark Johnson and Daniel Berrange) - Python bindings for block and interface statistics * Code cleanups: - virDrvOpenRemoteFlags definition (Richard Jones) - configure tests and output (Daniel Berrange) Thanks to everybody who helped with sugegstion, bug reports patches and more ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] PATCH: vncpasswd
by Mark Johnson 30 Sep '07

30 Sep '07

This adds support for handling vncpasswd.. MRJ vncpasswd support diff --git a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -1657,11 +1657,14 @@ xend_parse_sexp_desc(virConnectPtr conn, } else if (tmp && !strcmp(tmp, "vnc")) { int port = xenStoreDomainGetVNCPort(conn, domid); const char *listenAddr = sexpr_node(node, "device/vfb/vnclisten"); + const char *vncPasswd = sexpr_node(node, "device/vfb/vncpasswd"); const char *keymap = sexpr_node(node, "device/vfb/keymap"); virBufferVSprintf(&buf, " <input type='mouse' bus='%s'/>\n", hvm ? "ps2": "xen"); virBufferVSprintf(&buf, " <graphics type='vnc' port='%d'", port); if (listenAddr) virBufferVSprintf(&buf, " listen='%s'", listenAddr); + if (vncPasswd) + virBufferVSprintf(&buf, " passwd='%s'", vncPasswd); if (keymap) virBufferVSprintf(&buf, " keymap='%s'", keymap); virBufferAdd(&buf, "/>\n", 3); @@ -1723,6 +1726,7 @@ xend_parse_sexp_desc(virConnectPtr conn, if (tmp[0] == '1') { int port = xenStoreDomainGetVNCPort(conn, domid); const char *listenAddr = sexpr_fmt_node(root, "domain/image/%s/vnclisten", hvm ? "hvm" : "linux"); + const char *vncPasswd = sexpr_fmt_node(root, "domain/image/%s/vncpasswd", hvm ? "hvm" : "linux"); const char *keymap = sexpr_fmt_node(root, "domain/image/%s/keymap", hvm ? "hvm" : "linux"); /* For Xen >= 3.0.3, don't generate a fixed port mapping * because it will almost certainly be wrong ! Just leave @@ -1736,6 +1740,8 @@ xend_parse_sexp_desc(virConnectPtr conn, virBufferVSprintf(&buf, " <graphics type='vnc' port='%d'", port); if (listenAddr) virBufferVSprintf(&buf, " listen='%s'", listenAddr); + if (vncPasswd) + virBufferVSprintf(&buf, " passwd='%s'", vncPasswd); if (keymap) virBufferVSprintf(&buf, " keymap='%s'", keymap); virBufferAdd(&buf, "/>\n", 3);

2 2

[Libvir] PATCH: Allow emptry bootloader
by Daniel P. Berrange 30 Sep '07

30 Sep '07

Latest XenD allows for default bootloader to be used if one is not defined for a paravirt OS. libvirt doesn't currently cope with this (see Solaris thread), since it requires either a bootloader or kernel to always be present. The attached patch allows for an emptry bootloader element to indicate that the domain should use the default. <domain type='xen' id='-1'> <name>rhel5pv</name> <uuid>614d7eb0-c6b1-5235-ac39-361b20f6cd49</uuid> <bootloader/> <os> <type>linux</type> </os> ...snip... </domain> The current API for looking up nodes in the SEXPR did not allow for the scenario where you might want to lookup a node with no content, eg (bootloader ) This distinction is needed here, so I added an sexpr_has() method to check for this. Second, it fixes a long standing bug where we'd record an error about the missing kernel or bootloader, but then continue generating (malformed) XML anyway. With this patch, it will correctly fail if the empty bootloader field is missing from the SEXPR. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 4

[Libvir] [RFC][PATCH 0/2] Tested NUMA patches for available memory and topology
by beth kon 30 Sep '07

30 Sep '07

I have tested the patches on a NUMA and a non-NUMA configuration, and they fundamentally appear to work. The first patch is for accessing available memory on a per-node basis. The second patch is for accessing NUMA node topology. I've gotten some helpful suggestions about my string parsing code, introducing me to sscanf :-). I've become convinced that there are more elegant ways to do this which would have about the same level of error checking. However, I am out of time if Daniel wants to check this in this week. So I offer what I do have, which functions, but is not elegant. I have been playing with other ways to do this and am not far from finished. So, Daniel, you need to tell me if you want to take this code, and possibly upgrade to something more compact later, or if you'd like to wait for the next revision. One point to comment on for posterity is that the string returned from xend is not what might be expected. An example: printf("string is %s\n", tempstr); would return string is node0:0\n node1:1 So, this means that the '\n' sent by the xend python code is somehow translated to "\n". And the trailing '\n' that should be there isn't. Instead there is a '\0'. Looking at the xend code, it would appear this string should look like: "node0:0\n node1:1\n" where these are '\n'. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

4 11

[Libvir] Updated Solaris dom0 patch (part 1)
by Mark Johnson 29 Sep '07

29 Sep '07

I've broken this patch up into a few pieces to make it more reviewable and tried to address the comments from the previous patch (Jun 15th'ish if your looking). Here is first part... tested on today's CVS bits on a FC7 dom0 (LD_PRELOAD=src/.libs/libvirt.so src/.libs/virsh) One note, it looks like you still need a xend change on FC7 before the no kernel/bootloader option works. It looks like it's close though.. works fine with them of course. More details... [root@fedora solaris]# cat guest.py name = "solaris" vcpus = 1 memory = "512" #bootloader = "/usr/bin/pygrub" #kernel = "/platform/i86xpv/kernel/unix" #ramdisk = "/platform/i86pc/boot_archive" extra = "-k" root = "/dev/dsk/c0d0s0" disk = ['file:/export/guests/solaris/disk.img,0,w'] vif = ['bridge=xenbr0'] on_shutdown = "destroy" on_reboot = "restart" on_crash = "destroy" [root@fedora solaris]# xm list -l solaris (domain (on_crash destroy) (uuid 72f9b45e-4be9-bf1f-a500-3707b9c3922c) (bootloader_args ) (vcpus 1) (name solaris) (on_poweroff destroy) (on_reboot restart) (bootloader ) (maxmem 512) (memory 512) (shadow_memory 0) (cpu_weight 256) (cpu_cap 0) (features ) (on_xend_start ignore) (on_xend_stop ignore) (image (linux (kernel ) (args 'root=/dev/dsk/c0d0s0 -k'))) (status 0) (device (vif (bridge xenbr0) (uuid 9a8d5a2f-0a70-3a1f-fed0-fd2459e63733))) (device (vbd (uuid a6ba2241-1019-151e-6dd7-28638d3e17b7) (bootable 1) (driver paravirtualised) (dev 0) (uname file:/export/guests/solaris/disk.img) (mode w) ) ) ) [root@fedora solaris]# virsh # start solaris Domain solaris started virsh # dominfo solaris Id: 5 Name: solaris UUID: 72f9b45e-4be9-bf1f-a500-3707b9c3922c OS Type: linux State: no state CPU(s): 1 CPU time: 2.1s Max memory: 524288 kB Used memory: 524288 kB virsh # console solaris libvir: Xen Daemon error : internal error domain information incomplete, missing kernel & bootloader domain.xml:25: parser error : Opening and ending tag mismatch: os line 4 and domain </domain> ^ domain.xml:26: parser error : Premature end of data in tag domain line 1 ^ virsh # quit [root@fedora solaris]# xm console solaris Loading kmdb... SunOS Release 5.11 Version matrix-devel-build 32-bit Copyright 1983-2007 Sun Microsystems, Inc. All rights reserved. Use is subject to license terms. WARNING: Found xen v3.1.0-rc7-2934.fc7 but need xen v3.0.4-1-xvm WARNING: The kernel may not function correctly Hostname: unknown Reading ZFS config: done. Sep 28 18:48:53 unknown ntpdate[419]: no server suitable for synchronization found unknown console login: root Password: Last login: Fri Sep 28 18:45:46 on console Sep 28 18:50:30 unknown login: ROOT LOGIN /dev/console Sun Microsystems Inc. SunOS 5.11 matrix-devel-build October 2007 bfu'ed from /net/girltalk/export/xvm/matrix-devel/archives/i386/nightly-nd on 2007-09-28 Sun Microsystems Inc. SunOS 5.11 xen-nv66-2007-06-24 October 2007 # poweroff Sep 28 18:50:33 unknown poweroff: initiated by root on /dev/console [root@fedora solaris]# Thanks, MRJ --- Solaris dom0 support diff --git a/src/xen_internal.c b/src/xen_internal.c --- a/src/xen_internal.c +++ b/src/xen_internal.c @@ -56,9 +56,10 @@ typedef struct v0_hypercall_struct { unsigned long op; unsigned long arg[5]; } v0_hypercall_t; + +#ifdef __linux__ #define XEN_V0_IOCTL_HYPERCALL_CMD \ _IOC(_IOC_NONE, 'P', 0, sizeof(v0_hypercall_t)) - /* the new one */ typedef struct v1_hypercall_struct { @@ -67,8 +68,12 @@ typedef struct v1_hypercall_struct } v1_hypercall_t; #define XEN_V1_IOCTL_HYPERCALL_CMD \ _IOC(_IOC_NONE, 'P', 0, sizeof(v1_hypercall_t)) - typedef v1_hypercall_t hypercall_t; +#elif define(__sun__) +typedef privcmd_hypercall_t hypercall_t; +#else +#error "unsupported platform" +#endif #ifndef __HYPERVISOR_sysctl #define __HYPERVISOR_sysctl 35 @@ -314,6 +319,26 @@ typedef union xen_getschedulerid xen_get dominfo.v2.handle : \ dominfo.v2d5.handle)) + +static int +lock_pages(void *addr, size_t len) +{ +#ifdef __linux__ + return (mlock(addr, len)); +#elif define(__sun) + return (0); +#endif +} + +static int +unlock_pages(void *addr, size_t len) +{ +#ifdef __linux__ + return (munlock(addr, len)); +#elif define(__sun) + return (0); +#endif +} struct xen_v0_getdomaininfolistop { @@ -616,7 +641,17 @@ typedef struct xen_op_v2_dom xen_op_v2_d #include "xen_unified.h" #include "xen_internal.h" -#define XEN_HYPERVISOR_SOCKET "/proc/xen/privcmd" +#ifdef __linux__ +#define XEN_HYPERVISOR_SOCKET "/proc/xen/privcmd" +#define HYPERVISOR_CAPABILITIES "/sys/hypervisor/properties/capabilities" +#define CPUINFO "/proc/cpuinfo" +#elif define(__sun__) +#define XEN_HYPERVISOR_SOCKET "/dev/xen/privcmd" +#define HYPERVISOR_CAPABILITIES "" +#define CPUINFO "/dev/cpu/self/cpuid" +#else +#error "unsupported platform" +#endif #ifndef PROXY static const char * xenHypervisorGetType(virConnectPtr conn); @@ -773,7 +808,7 @@ xenHypervisorDoV0Op(int handle, xen_op_v hc.op = __HYPERVISOR_dom0_op; hc.arg[0] = (unsigned long) op; - if (mlock(op, sizeof(dom0_op_t)) < 0) { + if (lock_pages(op, sizeof(dom0_op_t)) < 0) { virXenError(VIR_ERR_XEN_CALL, " locking", sizeof(*op)); return (-1); } @@ -783,7 +818,7 @@ xenHypervisorDoV0Op(int handle, xen_op_v virXenError(VIR_ERR_XEN_CALL, " ioctl ", xen_ioctl_hypercall_cmd); } - if (munlock(op, sizeof(dom0_op_t)) < 0) { + if (unlock_pages(op, sizeof(dom0_op_t)) < 0) { virXenError(VIR_ERR_XEN_CALL, " releasing", sizeof(*op)); ret = -1; } @@ -814,7 +849,7 @@ xenHypervisorDoV1Op(int handle, xen_op_v hc.op = __HYPERVISOR_dom0_op; hc.arg[0] = (unsigned long) op; - if (mlock(op, sizeof(dom0_op_t)) < 0) { + if (lock_pages(op, sizeof(dom0_op_t)) < 0) { virXenError(VIR_ERR_XEN_CALL, " locking", sizeof(*op)); return (-1); } @@ -824,7 +859,7 @@ xenHypervisorDoV1Op(int handle, xen_op_v virXenError(VIR_ERR_XEN_CALL, " ioctl ", xen_ioctl_hypercall_cmd); } - if (munlock(op, sizeof(dom0_op_t)) < 0) { + if (unlock_pages(op, sizeof(dom0_op_t)) < 0) { virXenError(VIR_ERR_XEN_CALL, " releasing", sizeof(*op)); ret = -1; } @@ -856,7 +891,7 @@ xenHypervisorDoV2Sys(int handle, xen_op_ hc.op = __HYPERVISOR_sysctl; hc.arg[0] = (unsigned long) op; - if (mlock(op, sizeof(dom0_op_t)) < 0) { + if (lock_pages(op, sizeof(dom0_op_t)) < 0) { virXenError(VIR_ERR_XEN_CALL, " locking", sizeof(*op)); return (-1); } @@ -866,7 +901,7 @@ xenHypervisorDoV2Sys(int handle, xen_op_ virXenError(VIR_ERR_XEN_CALL, " sys ioctl ", xen_ioctl_hypercall_cmd); } - if (munlock(op, sizeof(dom0_op_t)) < 0) { + if (unlock_pages(op, sizeof(dom0_op_t)) < 0) { virXenError(VIR_ERR_XEN_CALL, " releasing", sizeof(*op)); ret = -1; } @@ -898,7 +933,7 @@ xenHypervisorDoV2Dom(int handle, xen_op_ hc.op = __HYPERVISOR_domctl; hc.arg[0] = (unsigned long) op; - if (mlock(op, sizeof(dom0_op_t)) < 0) { + if (lock_pages(op, sizeof(dom0_op_t)) < 0) { virXenError(VIR_ERR_XEN_CALL, " locking", sizeof(*op)); return (-1); } @@ -908,7 +943,7 @@ xenHypervisorDoV2Dom(int handle, xen_op_ virXenError(VIR_ERR_XEN_CALL, " ioctl ", xen_ioctl_hypercall_cmd); } - if (munlock(op, sizeof(dom0_op_t)) < 0) { + if (unlock_pages(op, sizeof(dom0_op_t)) < 0) { virXenError(VIR_ERR_XEN_CALL, " releasing", sizeof(*op)); ret = -1; } @@ -936,7 +971,7 @@ virXen_getdomaininfolist(int handle, int { int ret = -1; - if (mlock(XEN_GETDOMAININFOLIST_DATA(dominfos), + if (lock_pages(XEN_GETDOMAININFOLIST_DATA(dominfos), XEN_GETDOMAININFO_SIZE * maxids) < 0) { virXenError(VIR_ERR_XEN_CALL, " locking", XEN_GETDOMAININFO_SIZE * maxids); @@ -992,7 +1027,7 @@ virXen_getdomaininfolist(int handle, int if (ret == 0) ret = op.u.getdomaininfolist.num_domains; } - if (munlock(XEN_GETDOMAININFOLIST_DATA(dominfos), + if (unlock_pages(XEN_GETDOMAININFOLIST_DATA(dominfos), XEN_GETDOMAININFO_SIZE * maxids) < 0) { virXenError(VIR_ERR_XEN_CALL, " release", XEN_GETDOMAININFO_SIZE * maxids); @@ -1679,7 +1714,7 @@ virXen_setvcpumap(int handle, int id, un if (hypervisor_version > 1) { xen_op_v2_dom op; - if (mlock(cpumap, maplen) < 0) { + if (lock_pages(cpumap, maplen) < 0) { virXenError(VIR_ERR_XEN_CALL, " locking", maplen); return (-1); } @@ -1697,7 +1732,7 @@ virXen_setvcpumap(int handle, int id, un } ret = xenHypervisorDoV2Dom(handle, &op); - if (munlock(cpumap, maplen) < 0) { + if (unlock_pages(cpumap, maplen) < 0) { virXenError(VIR_ERR_XEN_CALL, " release", maplen); ret = -1; } @@ -1794,7 +1829,7 @@ virXen_getvcpusinfo(int handle, int id, ipt->cpu = op.u.getvcpuinfod5.online ? (int)op.u.getvcpuinfod5.cpu : -1; } if ((cpumap != NULL) && (maplen > 0)) { - if (mlock(cpumap, maplen) < 0) { + if (lock_pages(cpumap, maplen) < 0) { virXenError(VIR_ERR_XEN_CALL, " locking", maplen); return (-1); } @@ -1812,7 +1847,7 @@ virXen_getvcpusinfo(int handle, int id, op.u.getvcpumapd5.cpumap.nr_cpus = maplen * 8; } ret = xenHypervisorDoV2Dom(handle, &op); - if (munlock(cpumap, maplen) < 0) { + if (unlock_pages(cpumap, maplen) < 0) { virXenError(VIR_ERR_XEN_CALL, " release", maplen); ret = -1; } @@ -1963,6 +1998,7 @@ xenHypervisorInit(void) goto detect_v2; } +#ifndef __sun__ /* * check if the old hypercall are actually working */ @@ -1980,6 +2016,7 @@ xenHypervisorInit(void) hypervisor_version = 0; goto done; } +#endif /* * we faild to make any hypercall diff --git a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -1280,9 +1280,7 @@ xend_parse_sexp_desc_os(virConnectPtr xe virBufferVSprintf(buf, " <type>hvm</type>\n"); tmp = sexpr_node(node, "domain/image/hvm/kernel"); if (tmp == NULL && !bootloader) { - virXendError(xend, VIR_ERR_INTERNAL_ERROR, - _("domain information incomplete, missing kernel & bootloader")); - return(-1); + virBufferVSprintf(buf, " \n"); } if (tmp) virBufferVSprintf(buf, " <loader>%s</loader>\n", tmp); @@ -1311,9 +1309,7 @@ xend_parse_sexp_desc_os(virConnectPtr xe virBufferVSprintf(buf, " <type>linux</type>\n"); tmp = sexpr_node(node, "domain/image/linux/kernel"); if (tmp == NULL && !bootloader) { - virXendError(xend, VIR_ERR_INTERNAL_ERROR, - _("domain information incomplete, missing kernel & bootloader")); - return(-1); + virBufferVSprintf(buf, " \n"); } if (tmp) virBufferVSprintf(buf, " <kernel>%s</kernel>\n", tmp); diff --git a/src/xml.c b/src/xml.c --- a/src/xml.c +++ b/src/xml.c @@ -703,10 +703,7 @@ virDomainParseXMLOSDescPV(virConnectPtr return (-1); } virBufferAdd(buf, "(image (linux ", 14); - if (kernel == NULL) { - virXMLError(conn, VIR_ERR_NO_KERNEL, NULL, 0); - return (-1); - } else { + if (kernel != NULL) { virBufferVSprintf(buf, "(kernel '%s')", (const char *) kernel); } if (initrd != NULL) diff --git a/src/xs_internal.c b/src/xs_internal.c --- a/src/xs_internal.c +++ b/src/xs_internal.c @@ -31,7 +31,13 @@ #include "xs_internal.h" #include "xen_internal.h" /* for xenHypervisorCheckID */ +#ifdef __linux__ #define XEN_HYPERVISOR_SOCKET "/proc/xen/privcmd" +#elif define(__sun__) +#define XEN_HYPERVISOR_SOCKET "/dev/xen/privcmd" +#else +#error "unsupported platform" +#endif #ifndef PROXY static char *xenStoreDomainGetOSType(virDomainPtr domain);

2 2

[Libvir] updated: Support Sun's Compiler
by Mark Johnson 29 Sep '07

29 Sep '07

I've cleaned up the patch from the previous comments... Sorry I'm off the original thread, switched over to mutt and am waiting for fetchmail to catch up with gmail.. tested on today's CVS bits on a FC7 dom0 (LD_PRELOAD=src/.libs/libvirt.so src/.libs/virsh) Thanks, MRJ --- fixes to compile with Sun's CC diff --git a/src/internal.h b/src/internal.h --- a/src/internal.h +++ b/src/internal.h @@ -25,11 +25,6 @@ extern "C" { #define _(str) dgettext(GETTEXT_PACKAGE, (str)) #define N_(str) dgettext(GETTEXT_PACKAGE, (str)) #define gettext_noop(str) (str) - -#ifdef __GNUC__ -#ifdef HAVE_ANSIDECL_H -#include <ansidecl.h> -#endif /* String equality tests, suggested by Jim Meyering. */ #define STREQ(a,b) (strcmp((a),(b)) == 0) @@ -39,6 +34,15 @@ extern "C" { #define STREQLEN(a,b,n) (strncmp((a),(b),(n)) == 0) #define STRNEQLEN(a,b,n) (strncmp((a),(b),(n)) != 0) +#ifndef __GNUC__ +#define __FUNCTION__ __func__ +#endif + +#ifdef __GNUC__ +#ifdef HAVE_ANSIDECL_H +#include <ansidecl.h> +#endif + /** * ATTRIBUTE_UNUSED: * @@ -61,7 +65,7 @@ extern "C" { #else #define ATTRIBUTE_UNUSED #define ATTRIBUTE_FORMAT(...) -#endif +#endif /* __GNUC__ */ /** * TODO: diff --git a/src/sexpr.c b/src/sexpr.c --- a/src/sexpr.c +++ b/src/sexpr.c @@ -80,11 +80,11 @@ sexpr_free(struct sexpr *sexpr) switch (sexpr->kind) { case SEXPR_CONS: - sexpr_free(sexpr->car); - sexpr_free(sexpr->cdr); + sexpr_free(sexpr->u.s.car); + sexpr_free(sexpr->u.s.cdr); break; case SEXPR_VALUE: - free(sexpr->value); + free(sexpr->u.value); break; case SEXPR_NIL: break; @@ -127,12 +127,12 @@ sexpr_string(const char *str, ssize_t le return ret; ret->kind = SEXPR_VALUE; if (len > 0) { - ret->value = strndup(str, len); + ret->u.value = strndup(str, len); } else { - ret->value = strdup(str); - } - - if (ret->value == NULL) { + ret->u.value = strdup(str); + } + + if (ret->u.value == NULL) { return NULL; } @@ -157,8 +157,8 @@ sexpr_cons(struct sexpr *car, struct sex if (ret == NULL) return ret; ret->kind = SEXPR_CONS; - ret->car = car; - ret->cdr = cdr; + ret->u.s.car = car; + ret->u.s.cdr = cdr; return ret; } @@ -174,12 +174,12 @@ append(struct sexpr *lst, struct sexpr * append(struct sexpr *lst, struct sexpr *value) { while (lst->kind != SEXPR_NIL) { - lst = lst->cdr; + lst = lst->u.s.cdr; } lst->kind = SEXPR_CONS; - lst->car = value; - lst->cdr = sexpr_nil(); + lst->u.s.car = value; + lst->u.s.cdr = sexpr_nil(); } /** @@ -228,18 +228,18 @@ sexpr2string(struct sexpr * sexpr, char if (tmp == 0) goto error; ret += tmp; - tmp = sexpr2string(sexpr->car, buffer + ret, n_buffer - ret); + tmp = sexpr2string(sexpr->u.s.car, buffer + ret, n_buffer - ret); if (tmp == 0) goto error; ret += tmp; - while (sexpr->cdr->kind != SEXPR_NIL) { - sexpr = sexpr->cdr; + while (sexpr->u.s.cdr->kind != SEXPR_NIL) { + sexpr = sexpr->u.s.cdr; tmp = snprintf(buffer + ret, n_buffer - ret, " "); if (tmp == 0) goto error; ret += tmp; tmp = - sexpr2string(sexpr->car, buffer + ret, n_buffer - ret); + sexpr2string(sexpr->u.s.car, buffer + ret, n_buffer - ret); if (tmp == 0) goto error; ret += tmp; @@ -250,12 +250,12 @@ sexpr2string(struct sexpr * sexpr, char ret += tmp; break; case SEXPR_VALUE: - if (strchr(sexpr->value, ' ')) + if (strchr(sexpr->u.value, ' ')) tmp = snprintf(buffer + ret, n_buffer - ret, "'%s'", - sexpr->value); + sexpr->u.value); else tmp = snprintf(buffer + ret, n_buffer - ret, "%s", - sexpr->value); + sexpr->u.value); if (tmp == 0) goto error; ret += tmp; @@ -346,8 +346,8 @@ _string2sexpr(const char *buffer, size_t ptr++; } - ret->value = strndup(start, ptr - start); - if (ret->value == NULL) { + ret->u.value = strndup(start, ptr - start); + if (ret->u.value == NULL) { virSexprError(VIR_ERR_NO_MEMORY, _("failed to copy a string")); } @@ -361,15 +361,15 @@ _string2sexpr(const char *buffer, size_t ptr++; } - ret->value = strndup(start, ptr - start); - if (ret->value == NULL) { + ret->u.value = strndup(start, ptr - start); + if (ret->u.value == NULL) { virSexprError(VIR_ERR_NO_MEMORY, _("failed to copy a string")); } } ret->kind = SEXPR_VALUE; - if (ret->value == NULL) + if (ret->u.value == NULL) goto error; } @@ -426,11 +426,11 @@ sexpr_lookup(struct sexpr *sexpr, const ptr = buffer; token = strsep(&ptr, "/"); - if (sexpr->kind != SEXPR_CONS || sexpr->car->kind != SEXPR_VALUE) { - return NULL; - } - - if (strcmp(sexpr->car->value, token) != 0) { + if (sexpr->kind != SEXPR_CONS || sexpr->u.s.car->kind != SEXPR_VALUE) { + return NULL; + } + + if (strcmp(sexpr->u.s.car->u.value, token) != 0) { return NULL; } @@ -440,16 +440,16 @@ sexpr_lookup(struct sexpr *sexpr, const if (token == NULL) continue; - sexpr = sexpr->cdr; - for (i = sexpr; i->kind != SEXPR_NIL; i = i->cdr) { + sexpr = sexpr->u.s.cdr; + for (i = sexpr; i->kind != SEXPR_NIL; i = i->u.s.cdr) { if (i->kind != SEXPR_CONS || - i->car->kind != SEXPR_CONS || - i->car->car->kind != SEXPR_VALUE) { + i->u.s.car->kind != SEXPR_CONS || + i->u.s.car->u.s.car->kind != SEXPR_VALUE) { continue; } - if (strcmp(i->car->car->value, token) == 0) { - sexpr = i->car; + if (strcmp(i->u.s.car->u.s.car->u.value, token) == 0) { + sexpr = i->u.s.car; break; } } @@ -463,10 +463,10 @@ sexpr_lookup(struct sexpr *sexpr, const return NULL; } - if (sexpr->kind != SEXPR_CONS || sexpr->cdr->kind != SEXPR_CONS) - return NULL; - - return sexpr->cdr; + if (sexpr->kind != SEXPR_CONS || sexpr->u.s.cdr->kind != SEXPR_CONS) + return NULL; + + return sexpr->u.s.cdr; } /** @@ -484,7 +484,7 @@ sexpr_node(struct sexpr *sexpr, const ch { struct sexpr *n = sexpr_lookup(sexpr, node); - return (n && n->car->kind == SEXPR_VALUE) ? n->car->value : NULL; + return (n && n->u.s.car->kind == SEXPR_VALUE) ? n->u.s.car->u.value : NULL; } /** diff --git a/src/sexpr.h b/src/sexpr.h --- a/src/sexpr.h +++ b/src/sexpr.h @@ -29,9 +29,9 @@ struct sexpr { struct { struct sexpr *car; struct sexpr *cdr; - }; + } s; char *value; - }; + } u; }; /* conversion to/from strings */ diff --git a/src/virsh.c b/src/virsh.c --- a/src/virsh.c +++ b/src/virsh.c @@ -4295,9 +4295,9 @@ vshDomainStateToString(int state) case VIR_DOMAIN_CRASHED: return gettext_noop("crashed"); default: - return gettext_noop("no state"); /* = dom0 state */ - } - return NULL; + ;/*FALLTHROUGH*/ + } + return gettext_noop("no state"); /* = dom0 state */ } static const char * @@ -4311,9 +4311,9 @@ vshDomainVcpuStateToString(int state) case VIR_VCPU_RUNNING: return gettext_noop("running"); default: - return gettext_noop("no state"); - } - return NULL; + ;/*FALLTHROUGH*/ + } + return gettext_noop("no state"); } static int @@ -4825,7 +4825,7 @@ vshParseArgv(vshControl * ctl, int argc, } last = argv[i]; } - end = end ? : argc; + end = end ? end : argc; /* standard (non-command) options */ while ((arg = getopt_long(end, argv, "d:hqtc:vrl:", opt, &idx)) != -1) { diff --git a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -189,9 +189,9 @@ virXendErrorInt(virConnectPtr conn, virE #define foreach(iterator, start) \ - for (_for_i = (start), *iterator = (start)->car; \ + for (_for_i = (start), *iterator = (start)->u.s.car; \ _for_i->kind == SEXPR_CONS; \ - _for_i = _for_i->cdr, iterator = _for_i->car) + _for_i = _for_i->u.s.cdr, iterator = _for_i->u.s.car) #define foreach_node(iterator, start, path) \ foreach(iterator, start) \ @@ -661,23 +661,22 @@ xend_node_op(virConnectPtr xend, const c * Returns 0 in case of success, -1 in case of failure. */ static int -xend_op_ext(virConnectPtr xend, const char *name, char *error, - size_t n_error, const char *key, ...) +xend_op(virConnectPtr xend, const char *name, const char *key, ...) { char buffer[1024]; + char error[1024]; va_list ap; int ret; snprintf(buffer, sizeof(buffer), "/xend/domain/%s", name); va_start(ap, key); - ret = xend_op_ext2(xend, buffer, error, n_error, key, ap); + ret = xend_op_ext2(xend, buffer, error, sizeof(error), key, ap); va_end(ap); return ret; } -#define xend_op(xend, name, key, ...) ({char error[1024]; xend_op_ext(xend, name, error, sizeof(error), key, __VA_ARGS__);}) #endif /* ! PROXY */ /** @@ -960,11 +959,11 @@ xenDaemonListDomainsOld(virConnectPtr xe if (root == NULL) goto error; - for (_for_i = root, node = root->car; _for_i->kind == SEXPR_CONS; - _for_i = _for_i->cdr, node = _for_i->car) { + for (_for_i = root, node = root->u.s.car; _for_i->kind == SEXPR_CONS; + _for_i = _for_i->u.s.cdr, node = _for_i->u.s.car) { if (node->kind != SEXPR_VALUE) continue; - extra += strlen(node->value) + 1; + extra += strlen(node->u.value) + 1; count++; } @@ -976,13 +975,13 @@ xenDaemonListDomainsOld(virConnectPtr xe ptr += sizeof(char *) * (count + 1); i = 0; - for (_for_i = root, node = root->car; _for_i->kind == SEXPR_CONS; - _for_i = _for_i->cdr, node = _for_i->car) { + for (_for_i = root, node = root->u.s.car; _for_i->kind == SEXPR_CONS; + _for_i = _for_i->u.s.cdr, node = _for_i->u.s.car) { if (node->kind != SEXPR_VALUE) continue; ret[i] = ptr; - strcpy(ptr, node->value); - ptr += strlen(node->value) + 1; + strcpy(ptr, node->u.value); + ptr += strlen(node->u.value) + 1; i++; } @@ -1461,8 +1460,8 @@ xend_parse_sexp_desc(virConnectPtr conn, if ((tmp != NULL) && (tmp[0] != 0)) virBufferVSprintf(&buf, " <emulator>%s</emulator>\n", tmp); - for (cur = root; cur->kind == SEXPR_CONS; cur = cur->cdr) { - node = cur->car; + for (cur = root; cur->kind == SEXPR_CONS; cur = cur->u.s.cdr) { + node = cur->u.s.car; /* Normally disks are in a (device (vbd ...)) block but blktap disks ended up in a differently named (device (tap ....)) block.... */ @@ -1701,8 +1700,8 @@ xend_parse_sexp_desc(virConnectPtr conn, /* in case of HVM we have devices emulation */ if (hvm) { - for (cur = sexpr_lookup(root, "domain/image/hvm"); cur && cur->kind == SEXPR_CONS; cur = cur->cdr) { - node = cur->car; + for (cur = sexpr_lookup(root, "domain/image/hvm"); cur && cur->kind == SEXPR_CONS; cur = cur->u.s.cdr) { + node = cur->u.s.car; if (sexpr_lookup(node, "usbdevice")) { tmp = sexpr_node(node, "usbdevice"); if (tmp && *tmp) { @@ -2677,11 +2676,11 @@ xenDaemonListDomains(virConnectPtr conn, ret = 0; - for (_for_i = root, node = root->car; _for_i->kind == SEXPR_CONS; - _for_i = _for_i->cdr, node = _for_i->car) { + for (_for_i = root, node = root->u.s.car; _for_i->kind == SEXPR_CONS; + _for_i = _for_i->u.s.cdr, node = _for_i->u.s.car) { if (node->kind != SEXPR_VALUE) continue; - id = xenDaemonDomainLookupByName_ids(conn, node->value, NULL); + id = xenDaemonDomainLookupByName_ids(conn, node->u.value, NULL); if (id >= 0) ids[ret++] = (int) id; if (ret >= maxids) @@ -2715,8 +2714,8 @@ xenDaemonNumOfDomains(virConnectPtr conn ret = 0; - for (_for_i = root, node = root->car; _for_i->kind == SEXPR_CONS; - _for_i = _for_i->cdr, node = _for_i->car) { + for (_for_i = root, node = root->u.s.car; _for_i->kind == SEXPR_CONS; + _for_i = _for_i->u.s.cdr, node = _for_i->u.s.car) { if (node->kind != SEXPR_VALUE) continue; ret++; @@ -2884,11 +2883,11 @@ xenDaemonDomainGetVcpus(virDomainPtr dom memset(cpumaps, 0, maxinfo * maplen); /* scan the sexprs from "(vcpu (number x)...)" and get parameter values */ - for (s = root; s->kind == SEXPR_CONS; s = s->cdr) { - if ((s->car->kind == SEXPR_CONS) && - (s->car->car->kind == SEXPR_VALUE) && - !strcmp(s->car->car->value, "vcpu")) { - t = s->car; + for (s = root; s->kind == SEXPR_CONS; s = s->u.s.cdr) { + if ((s->u.s.car->kind == SEXPR_CONS) && + (s->u.s.car->u.s.car->kind == SEXPR_VALUE) && + !strcmp(s->u.s.car->u.s.car->u.value, "vcpu")) { + t = s->u.s.car; vcpu = ipt->number = sexpr_int(t, "vcpu/number"); if ((oln = sexpr_int(t, "vcpu/online")) != 0) { if (sexpr_int(t, "vcpu/running")) ipt->state = VIR_VCPU_RUNNING; @@ -2905,14 +2904,14 @@ xenDaemonDomainGetVcpus(virDomainPtr dom * get sexpr from "(cpumap (x y z...))" and convert values * to bitmap */ - for (t = t->cdr; t->kind == SEXPR_CONS; t = t->cdr) - if ((t->car->kind == SEXPR_CONS) && - (t->car->car->kind == SEXPR_VALUE) && - !strcmp(t->car->car->value, "cpumap") && - (t->car->cdr->kind == SEXPR_CONS)) { - for (t = t->car->cdr->car; t->kind == SEXPR_CONS; t = t->cdr) - if (t->car->kind == SEXPR_VALUE) { - cpu = strtol(t->car->value, NULL, 0); + for (t = t->u.s.cdr; t->kind == SEXPR_CONS; t = t->u.s.cdr) + if ((t->u.s.car->kind == SEXPR_CONS) && + (t->u.s.car->u.s.car->kind == SEXPR_VALUE) && + !strcmp(t->u.s.car->u.s.car->u.value, "cpumap") && + (t->u.s.car->u.s.cdr->kind == SEXPR_CONS)) { + for (t = t->u.s.car->u.s.cdr->u.s.car; t->kind == SEXPR_CONS; t = t->u.s.cdr) + if (t->u.s.car->kind == SEXPR_VALUE) { + cpu = strtol(t->u.s.car->u.value, NULL, 0); if (cpu >= 0 && (VIR_CPU_MAPLEN(cpu+1) <= maplen)) { VIR_USE_CPU(cpumap, cpu); } @@ -3434,8 +3433,8 @@ xenDaemonNumOfDefinedDomains(virConnectP ret = 0; - for (_for_i = root, node = root->car; _for_i->kind == SEXPR_CONS; - _for_i = _for_i->cdr, node = _for_i->car) { + for (_for_i = root, node = root->u.s.car; _for_i->kind == SEXPR_CONS; + _for_i = _for_i->u.s.cdr, node = _for_i->u.s.car) { if (node->kind != SEXPR_VALUE) continue; ret++; @@ -3464,12 +3463,12 @@ int xenDaemonListDefinedDomains(virConne ret = 0; - for (_for_i = root, node = root->car; _for_i->kind == SEXPR_CONS; - _for_i = _for_i->cdr, node = _for_i->car) { + for (_for_i = root, node = root->u.s.car; _for_i->kind == SEXPR_CONS; + _for_i = _for_i->u.s.cdr, node = _for_i->u.s.car) { if (node->kind != SEXPR_VALUE) continue; - names[ret++] = strdup(node->value); + names[ret++] = strdup(node->u.value); if (ret >= maxnames) break; }

2 2

Fwd: [Libvir] Updated Solaris dom0 patch (part 1)
by Mark Johnson 28 Sep '07

28 Sep '07

sorry, missed the cc..... ---------- Forwarded message ---------- From: Mark Johnson <johnson.nh(a)gmail.com> Date: Sep 28, 2007 4:09 PM Subject: Re: [Libvir] Updated Solaris dom0 patch (part 1) To: "Daniel P. Berrange" <berrange(a)redhat.com> On 9/28/07, Daniel P. Berrange <berrange(a)redhat.com> wrote: > On Fri, Sep 28, 2007 at 03:03:15PM -0400, Mark Johnson wrote: > > > > I've broken this patch up into a few pieces to make > > it more reviewable and tried to address the comments > > from the previous patch (Jun 15th'ish if your looking). > > > > Here is first part... > > > > tested on today's CVS bits on a FC7 dom0 > > (LD_PRELOAD=src/.libs/libvirt.so src/.libs/virsh) > > > > One note, it looks like you still need a xend change on > > FC7 before the no kernel/bootloader option works. It > > looks like it's close though.. works fine with them > > of course. > > > > > > More details... > > > > > > [root@fedora solaris]# cat guest.py > > name = "solaris" > > vcpus = 1 > > memory = "512" > > > > #bootloader = "/usr/bin/pygrub" > > #kernel = "/platform/i86xpv/kernel/unix" > > #ramdisk = "/platform/i86pc/boot_archive" > > extra = "-k" > > > > root = "/dev/dsk/c0d0s0" > > disk = ['file:/export/guests/solaris/disk.img,0,w'] > > Oooh, that's interesting. Can you explain a little about Solaris paravirt > disk naming, since it doesn't use xvdN/hdN/sdN style config ? No, it uses a disk #... 0, 1, 2, 3, 4.. We also have a PV :cdrom e.g. for an install... disk = ['file:/tank/guests/install/solaris/66-0624-nd.iso,6:cdrom,r', 'file:/tank/guests/install/solaris/disk.img,0,w'] > Does the > HVM disk naming still use the named devs ? Yes. That is the same. > Also one other question. There is a config option > > builder='linux' > > Which is never used on Linux since 'linux' is the default. Do you change > the default on Solaris, or dooes the existing 'linux' builder work just > fine with Solaris DomU images ? I guess the latter, since the SEXPR > you have below is using 'linux'. Yep, we use the linux domain builder... > > [root@fedora solaris]# xm list -l solaris > > (domain > > (on_crash destroy) > > (uuid 72f9b45e-4be9-bf1f-a500-3707b9c3922c) > > (bootloader_args ) > > (vcpus 1) > > (name solaris) > > (on_poweroff destroy) > > (on_reboot restart) > > (bootloader ) > > Since I notice it has the bootloader bit in the SEXPR, I'm thinking I'll > tweak our XML generation so it at least includes an empty <bootloade/> > since there may be tools using libvirt which expect at least one of <os> > or <bootloader> and using an empty tag may keep them happier. > > eg, it'd probably avoid this problem... OK. MRJ > > virsh # console solaris > > libvir: Xen Daemon error : internal error domain information incomplete, missing kernel & bootloader > > domain.xml:25: parser error : Opening and ending tag mismatch: os line 4 and domain > > </domain> > > ^ > > domain.xml:26: parser error : Premature end of data in tag domain line 1 > > > Though obviously your patch fixes that too. > > Dan. > -- > |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| > |=- Perl modules: http://search.cpan.org/~danberr/ -=| > |=- Projects: http://freshmeat.net/~danielpb/ -=| > |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| >

1 0

[Libvir] [RFC][PATCH 1/2] Tested NUMA patches for available memory and topology
by beth kon 28 Sep '07

28 Sep '07

Patch for accessing available memory. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

5 12

[Libvir] PATCH: Fix crash parsing input devices for QEMU
by Daniel P. Berrange 28 Sep '07

28 Sep '07

There is an edge case in parsing of input devices where if you have a PS2 mouse defined, before a USB tablet, it could generate a null pointer deference & thus crash. Normally you'd only have one pointer defined, but one might add a USB tablet for getting a improved mouse experience. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] [RFC][PATCH 2/2] Tested NUMA patches for available memory and topology
by beth kon 28 Sep '07

28 Sep '07

Patch for accessing topology information. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

1 0

[Libvir] PATCH: Allow remote driver to handle any connection URI
by Daniel P. Berrange 28 Sep '07

28 Sep '07

We currently have logic in the remote driver so that it handles the local QEMU driver URIs, so they get re-directed to the daemon. It also handles networking APIs for Xen driver. For normal APIs, Xen has the auto-spawned setuid proxy daemon. This was very useful at the time we wrote it, but it only supports a handful of operations, and only in read-only mode. One other factor is that SUSE, for example, do not ship it because it is setuid. I don't know whether this is just a general policy, or just because they've not had time to audit it, but that's not very good for their users. With the development of the remote driver & the flexible UNIX socket perms & group ownership, or with policykit support it is possible to replace the proxy with calls straight to the remote daemon. So this patch is the first step by allowing the remote driver to handle any hypervisor connection URI. If it doesn't have a hostname or transport specified, then it automatically tries to connect to the local libvirt daemon over UNIX sockets. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

4 7

[Libvir] virt-df (a 'df' tool for virtual domains)
by Richard W.M. Jones 27 Sep '07

27 Sep '07

Brave (or foolhardy?) souls may want to try out the almost-working version of 'virt-df' that I wrote: hg clone http://hg.et.redhat.com/virt/applications/virt-top--devel Usage is similar to ordinary 'df'. It understands the -h (human-readable) and -i (show inodes) options. You need to run it on the dom0, it won't work remotely. # virt-df.opt -c qemu:///system debian32kvm /dev/hda (3.9 GiB) /var/lib/xen/images/debian32kvm.img hda1 3662792 990276 2672516 Linux ext2/3 hda5 232908 Linux swap [The numbers are 1K blocks total, used, available] # virt-df.opt -c qemu:///system -h debian32kvm /dev/hda (3.9 GiB) /var/lib/xen/images/debian32kvm.img hda1 3.5 GiB 967.1 MiB 2.5 GiB Linux ext2/3 hda5 227.4 MiB Linux swap From the README file: virt-df is a 'df' tool for printing out the used and available disk space in all active and inactive domains. Without this tool you would need to log in to each domain individually or set up monitoring. It is only a proof-of-concept. Please bare in mind the following limitations when using this tool: (1) It does not work over remote connections. Part of the reason why I wrote virt-df was to get an idea of how the remote storage API for libvirt might look. (2) It only understands a limited set of partition types. Assuming that the files and partitions that we get back from libvirt / Xen correspond to block devices in the guests, we can go some way towards manually parsing those partitions to find out what they contain. We can read the MBR, EBR, superblocks and so on. However that's a lot of parsing work, and currently there is no library which understands a wide range of partition schemes and filesystem types (not even libparted which doesn't support LVM yet). The Linux kernel does support that, but there's not really any good way to access that work. The current implementation uses a hand-coded parser which understands some simple formats (MBR, EBR, ext2/3, not LVM yet but coming soon). In future we should use something like libparted. (3) The statistics you get are delayed. The real state of, for example, an ext2 filesystem is only stored in the memory of the guest's kernel. The ext2 superblock contains some meta-information about blocks used and free, but this superblock is not up to date. In fact the guest kernel may not update it even on a 'sync', not until the filesystem is unmounted. Some operations do appear to write the superblock, for example fsync(2) [that is my reading of the ext2/3 source code at least]. $ wc -l virt-df/*.ml 84 virt-df/virt_df_ext2.ml 24 virt-df/virt_df_linux_swap.ml 22 virt-df/virt_df_lvm2.ml 5 virt-df/virt_df_main.ml 460 virt-df/virt_df.ml 595 total Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 4

[Libvir] topology test program
by beth kon 27 Sep '07

27 Sep '07

Daniel, As we discussed, here is the program I was using for testing different topology strings. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

1 0

[Libvir] /etc/sysconfig/keyboard syntax subtilities
by Guillaume Rousse 27 Sep '07

27 Sep '07

virtmanager split content of /etc/sysconfig/keyboard on '"' for determining keyboard. On mandriva system, there isn't any quote in this file: see http://qa.mandriva.com/show_bug.cgi?id=34190 Here is a patch making parsing of this file a bit more robust. -- Guillaume Rousse Moyens Informatiques - INRIA Futurs Tel: 01 69 35 69 62

2 1

[Libvir] trouble using ssh tunnel for remote hypervisor
by Guillaume Rousse 27 Sep '07

27 Sep '07

Hello. I'm trying to use ssh tunnel for remote hypervisor access. However, I'm can't make it working... [guillaume@oberkampf ~]$ LC_ALL=C virsh --connect xen+ssh://root@acacia.futurs.inria.fr list --all libvir: error : could not connect to xen:// error: failed to connect to the hypervisor error: no valid connection On the remote host: [root@acacia ~]# libvirtd --verbose libvir: error : could not connect to xen:// It seems the error lies between libvirtd and the local hypervisor. And indeed, local usage of virsh with xen:// URLs fail: [root@acacia ~]# LC_ALL=C virsh -c xen:// list libvir: error : could not connect to xen:// error: failed to connect to the hypervisor error: no valid connection Using xen:///, instead of xen://, as explained at http://libvirt.org/uri.html, is OK, despite a few error messages: [root@acacia ~]# LC_ALL=C virsh -c xen:/// list libvir: Remote error : No such file or directory libvir: warning : Failed to find the network: Is the daemon running ? Id Name State ---------------------------------- 0 Domain-0 running 1 barman blocked 2 cocktail blocked 3 mojito blocked >From the documentation, it seems xen:// transport implies TLS, and requires an host name, so it is quite normal it fails here (I didn't generated any certificate). But how can I force libvirtd to use xen:/// transport then ? I don't see anything related in libvirt configuration documentation at http://libvirt.org/remote.html ? Neither about how to configure it for listening on unix transport, as explained in svn+ssh transport requirements on the same page (but I presume it is the default) ? Also, from where does those error and warning come ? [root@acacia ~]# LC_ALL=C virsh -c xen:/// list libvir: Remote error : No such file or directory libvir: warning : Failed to find the network: Is the daemon running ? [..] I'm using libvirt 0.3.2 on mandriva 2007.1, with xen 3.1.0. -- Guillaume Rousse Moyens Informatiques - INRIA Futurs Tel: 01 69 35 69 62

4 4

[Libvir] python libvirt methods to virDomainBlockStats and virDomainInterfaceStats
by Marco Sinhoreli 27 Sep '07

27 Sep '07

Hello all, I'm using libvirt from cvs, and in libvirt.h there are virDomainBlockStats, and virDomainInterfaceStats calls. I think it is compiled into libvirtmod, then I'm trying to write two methods, blockStats, and interfacesStats in the class virDomain at the libvirt.py library file. I'm not a specialist in python programming and it's not working. Bellow folow the code I have been wrote: def blockStats(self): """Block device stats for virDomainBlockStats """ ret = libvirtmod.virDomainBlockStats(self._o) if ret is None: raise libvirtError ('virDomainBlockStats() failed', dom=self) return ret def interfaceStats(self): """Network interface stats for virDomainInterfaceStats.""" ret = libvirtmod.virDomainInterfaceStats(self._o) if ret is None: raise libvirtError ('virDomainInterfaceStats() failed', dom=self) return ret Any help will be welcome. Best regards -- Marco Sinhoreli

2 3

[Libvir] [RFC][PATCH 1/2] NUMA memory and topology patches
by beth kon 26 Sep '07

26 Sep '07

[PATCH 1/2] - add capability to access free memory information on each NUMA cell. Signed-off-by: Beth Kon (eak(a)us.ibm.com) -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

4 9

[Libvir] [PATCH] virsh NUMA command freecell
by Daniel Veillard 26 Sep '07

26 Sep '07

Useful for testing the virNodeGetCellsFreeMemory() call, it requires the 3 precedent NUMA patches. The patch lack the documentation update. The function takes an optional argument which is the cell number. If no cell is provided it will print the total free memory available on the Node. A more useful function would be to find the cell with the most available memory, but that one should still be useful and not just for testing. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] [RFC][PATCH 2/2] NUMA memory and topology patches
by beth kon 25 Sep '07

25 Sep '07

[PATCH 2/2] - add capability to access topology information (cell to cpu mapping) for each numa cell. Signed-off-by: Beth Kon (eak(a)us.ibm.com) -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

2 1

[Libvir] [RFC][PATCH 0/2] NUMA memory and topology patches
by beth kon 25 Sep '07

25 Sep '07

I am reposting an updated patch for accessing NUMA cell available memory, and posting the initial patch for accessing NUMA topology information. Again, this code is primarily untested. I am looking for comments in parallel with the testing I will begin tomorrow. These patches prereq Daniel Veillard's initial framework patch: https://www.redhat.com/archives/libvir-list/2007-September/msg00069.html [PATCH 1/2] - add capability to access free memory information on each NUMA cell. [PATCH 2/2] - add capability to access topology information (cell to cpu mapping) for each numa cell. I have not yet added the full node available memory API call that was discussed on the list. As I understand the NUMA code is more urgent. If you would like to get this code in too, I can create another patch for that. My focus for the moment is testing. Signed-off-by: Beth Kon (eak(a)us.ibm.com) -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

1 0

[Libvir] RFC PATCH - Initial NodeGetCellsFreeMemory patch
by beth kon 24 Sep '07

24 Sep '07

Here is my first pass at a patch for accessing the available memory associated with each NUMA cell through libvirt. The initial framework patch provided by Daniel Veillard is a prereq of this patch: https://www.redhat.com/archives/libvir-list/2007-September/msg00069.html I have not yet tested this. I'm just distributing for comments. A few comments/questions: 1) I think I got the versioning stuff right but that deserves a close look. 2) In Daniel's patch, libvirt.h and libvirt.h.in were identical. I assumed the patch would be before running autogen.sh, and only contain changes in libvirt.h.in, so that's how I did mine. Let me know if I misunderstand something here. 3) I had to put #ifdef PROXY around calls to virXenErrorFunc in xenHypervisorNodeGetCellsFreeMemory to get this to build. I haven't figured out how the proxy code works so am not sure if this is the right approach. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

3 6

[Libvir] Remotely starting a fully-virtualized guest
by Meng Kuan 24 Sep '07

24 Sep '07

Hi, I am trying to start a fully virtualized guest called "full1" remotely. The connection URI I am using is "xen+ssh://root@dell1/". (Note that I am able to start/stop/resume/shutdown para-virtualized guests without any problems with this connection URI.) The XML definition for the fully virtualized guest is this: <domain type='xen'> <name>full1</name> <os> <type>hvm</type> <loader>/usr/lib/xen/boot/hvmloader</loader> <boot dev='hd'/> </os> <memory>1048576</memory> <vcpu>2</vcpu> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <features> <acpi/> <apic/> <pae/> </features> <clock offset='utc'/> <devices> <emulator>/usr/lib64/xen/bin/qemu-dm</emulator> <interface type='bridge'> <source bridge='xenbr0'/> <script path='vif-bridge'/> </interface> <disk type='file' device='disk'> <driver name='file'/> <source file='/xen/full1.img'/> <target dev='hda'/> </disk> <graphics type='vnc' port='5904'/> </devices> </domain> The guest failed to start up and this is what I found in the xend.log file: [2007-09-24 18:55:46 xend.XendDomainInfo 4176] DEBUG (XendDomainInfo: 190) XendDomainInfo.create(['vm', ['name', 'full1'] , ['memory', '1024'], ['maxmem', '1024'], ['vcpus', '2'], ['on_poweroff', 'destroy'], ['on_reboot', 'restart'], ['on_crash ', 'restart'], ['image', ['hvm', ['kernel', '/usr/lib/xen/boot/ hvmloader'], ['device_model', '/usr/lib64/xen/bin/qemu-dm '], ['vcpus', '2'], ['boot', 'c'], ['acpi', '1'], ['apic', '1'], ['pae', '1'], ['usb', '1'], ['vnc', '1'], ['vncdisplay' , '4']]], ['device', ['vbd', ['dev', 'hda:disk'], ['uname', 'file:/ xen/full1.img'], ['mode', 'w']]], ['device', ['vif', ['bridge', 'xenbr0'], ['script', 'vif-bridge'], ['type', 'ioemu']]]]) [2007-09-24 18:55:46 xend.XendDomainInfo 4176] DEBUG (XendDomainInfo: 296) parseConfig: config is ['vm', ['name', 'full1' ], ['memory', '1024'], ['maxmem', '1024'], ['vcpus', '2'], ['on_poweroff', 'destroy'], ['on_reboot', 'restart'], ['on_cras h', 'restart'], ['image', ['hvm', ['kernel', '/usr/lib/xen/boot/ hvmloader'], ['device_model', '/usr/lib64/xen/bin/qemu-d m'], ['vcpus', '2'], ['boot', 'c'], ['acpi', '1'], ['apic', '1'], ['pae', '1'], ['usb', '1'], ['vnc', '1'], ['vncdisplay ', '4']]], ['device', ['vbd', ['dev', 'hda:disk'], ['uname', 'file:/ xen/full1.img'], ['mode', 'w']]], ['device', ['vif', ['bridge', 'xenbr0'], ['script', 'vif-bridge'], ['type', 'ioemu']]]] [2007-09-24 18:55:46 xend.XendDomainInfo 4176] DEBUG (XendDomainInfo: 397) parseConfig: result is {'shadow_memory': None, 'start_time': None, 'uuid': None, 'on_crash': 'restart', 'on_reboot': 'restart', 'localtime': None, 'image': ['hvm', [' kernel', '/usr/lib/xen/boot/hvmloader'], ['device_model', '/usr/lib64/ xen/bin/qemu-dm'], ['vcpus', '2'], ['boot', 'c'], ['acpi', '1'], ['apic', '1'], ['pae', '1'], ['usb', '1'], ['vnc', '1'], ['vncdisplay', '4']], 'on_poweroff': 'destroy', 'bootloader_args': None, 'cpus': None, 'name': 'full1', 'backend': [], 'vcpus': 2, 'cpu_weight': None, 'features': None, 'vcpu_avail': None, 'memory': 768, 'device': [('vbd', ['vbd', ['dev', 'hda:disk'], ['uname', 'file:/xen/full1.img'], [' mode', 'w']]), ('vif', ['vif', ['bridge', 'xenbr0'], ['script', 'vif- bridge'], ['type', 'ioemu']])], 'bootloader': None, 'cpu': None, 'maxmem': 768} [2007-09-24 18:55:46 xend.XendDomainInfo 4176] DEBUG (XendDomainInfo: 1264) XendDomainInfo.construct: None [2007-09-24 18:55:46 xend.XendDomainInfo 4176] DEBUG (XendDomainInfo: 1296) XendDomainInfo.initDomain: 91 1.0 [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: boot, val: c [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: fda, val: None [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: fdb, val: None [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: soundhw, val: None [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: localtime, val: None [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: serial, val: None [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: std-vga, val: None [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: isa, val: None [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: vcpus, val: 2 [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: acpi, val: 1 [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: usb, val: 1 [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: usbdevice, val: None [2007-09-24 18:55:46 xend 4176] DEBUG (image:329) args: k, val: None [2007-09-24 18:55:46 xend.XendDomainInfo 4176] ERROR (XendDomainInfo: 202) Domain construction failed Traceback (most recent call last): File "/usr/lib64/python2.4/site-packages/xen/xend/ XendDomainInfo.py", line 195, in create vm.initDomain() File "/usr/lib64/python2.4/site-packages/xen/xend/ XendDomainInfo.py", line 1309, in initDomain self.info['device']) File "/usr/lib64/python2.4/site-packages/xen/xend/image.py", line 45, in create return findImageHandlerClass(imageConfig)(vm, imageConfig, deviceConfig) File "/usr/lib64/python2.4/site-packages/xen/xend/image.py", line 75, in __init__ self.configure(imageConfig, deviceConfig) File "/usr/lib64/python2.4/site-packages/xen/xend/image.py", line 272, in configure self.dmargs += self.configVNC(imageConfig) File "/usr/lib64/python2.4/site-packages/xen/xend/image.py", line 383, in configVNC ret += ['-vnc', '%d' % vncdisplay] TypeError: int argument required [2007-09-24 18:55:46 xend.XendDomainInfo 4176] DEBUG (XendDomainInfo: 1463) XendDomainInfo.destroy: domid=91 [2007-09-24 18:55:46 xend.XendDomainInfo 4176] DEBUG (XendDomainInfo: 1471) XendDomainInfo.destroyDomain(91) [2007-09-24 18:55:46 xend 4176] ERROR (SrvBase:88) Request create failed. Traceback (most recent call last): File "/usr/lib64/python2.4/site-packages/xen/web/SrvBase.py", line 85, in perform return op_method(op, req) File "/usr/lib64/python2.4/site-packages/xen/xend/server/ SrvDomainDir.py", line 82, in op_create raise XendError("Error creating domain: " + str(ex)) XendError: Error creating domain: int argument required It seems that xend got a string instead of an integer for the vnc port. I modified the file "image.py" at line 383 from this ret += ['-vnc', '%d' % vncdisplay] to this: ret += ['-vnc', '%s' % vncdisplay] Restarted xend for the change to take effect and then try starting the guest again. This time the guest gets created but its state does not change to "running". # xm list Name ID Mem(MiB) VCPUs State Time(s) Domain-0 0 451 2 r----- 356.7 full1 88 773 1 ------ 0.0 I removed the following vnc line from the xml definition and try again: <graphics type='vnc' port='5904'/> The guest gets created but again its state is not "running". According to xml format documentation the <graphics> tag is required. At this point I am stumped. Any ideas what else I can try? cheers, mengkuan

2 2

[Libvir] PATCH 0/5: Rework the configure script
by Daniel P. Berrange 24 Sep '07

24 Sep '07

The following series of patches re-work the configure to solve a number of issues. I'll describe each one alongside its respective patch... Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

6 28

Re: [Libvir] RFC PATCH - Initial NodeGetCellsFreeMemory patch
by beth kon 21 Sep '07

21 Sep '07

oops... meant to post to list as well beth kon wrote: > Daniel Veillard wrote: > >> On Thu, Sep 20, 2007 at 05:10:49PM -0400, beth kon wrote: >> >> >>> Here is my first pass at a patch for accessing the available memory >>> associated with each NUMA cell through libvirt. >>> >> >> Thanks ! >> >> > Thanks for the quick comments! > >>> +struct xen_v2s4_availheap { >>> + uint32_t min_bitwidth; /* Smallest address width (zero if don't >>> care). */ >>> + uint32_t max_bitwidth; /* Largest address width (zero if don't >>> care). */ >>> >> >> I'm a bit puzzled by those 2 fields I still wonder what it is about :-) >> >> >> > I was puzzled too! These fields are related to the case when 32 bit > guests need to reserve certain ranges of memory for DMA, for example. > I checked with Ryan and he assured me we don't need to worry about > those fields for these purposes. > >>> + int32_t node; /* NUMA node (-1 for sum across all nodes). */ >>> + uint64_t avail_bytes; /* Bytes available in the specified region. */ >>> +}; >>> + >>> +typedef struct xen_v2s4_availheap xen_v2s4_availheap; >>> + >>> >> [...] >> >> > What does [...] mean? :-) > >> >> >>> +xenHypervisorNodeGetCellsFreeMemory(virConnectPtr conn, long long >>> *freeMems, >>> + int startCell, int maxCells) >>> { >>> - if ((conn == NULL) || (freeMems == NULL) || (nbCells < 0)) >>> - return -1; >>> + xen_op_v2_sys op_sys; >>> + int i, ret, nbCells; >>> + virNodeInfo nodeInfo; >>> + virNodeInfoPtr nodeInfoPtr = &nodeInfo; >>> + xenUnifiedPrivatePtr priv; >>> + >>> + if ((conn == NULL) || (freeMems == NULL) || (maxCells < 0)) >>> + return -1; >>> >> >> Hum, actually, that would catch the (maxCells == -1) so that won't work >> and won't catch maxCells == 0 which could lead to a segfault. Maybe >> (maxCells == 0) || (maxCells < -1) should be used instead. >> >> >> > Yes, you're right. I added maxcells = -1 and startCell as an > afterthought, and it shows! > >>> + /* get actual number of cells */ >>> + if (xenDaemonNodeGetInfo(conn, nodeInfoPtr)) { >>> >> >> Hum, since the number of cells is static, maybe this should be stored >> permanently in a variable on init. The xenDaemon RPC will be orders >> of magnitude >> more expensive than the direct hypercall below. >> >> >> >>> + virXenError(VIR_ERR_XEN_CALL, " cannot determine actual number of >>> cells", 0); >>> + return -1; >>> + } >>> + nbCells = nodeInfoPtr->nodes; >>> + >>> + if (maxCells > nbCells) >>> + maxCells = nbCells; >>> >> >> >> > I wondered about that. Would you like me to make that change as part > of this patch? > >> Hum ... maxCells is the number of entries in the array, I'm afraid >> you will >> need 2 counters or I misunderstood the way the API works (possible :-), >> I would fill in freeMems[] starting at index 0 for startCell, and >> going up. >> That feels more coherent than leaving uninitialized values at the >> start of >> the array: >> >> for (i = startCell, j = 0;(i < nbCells) && (j < maxCells);i++,j++) { >> op_sys.u.availheap.node = i; >> ret = xenHypervisorDoV2Sys(priv->handle, &op_sys); >> if (ret < 0) >> return(-1); >> freeMems[j] = op_sys.u.availheap.avail_bytes; >> } >> return (j); >> >> >> > Yes, right again! > > Thanks so much for the great feedback! > -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

2 1

[Libvir] How to deploy Virtual Machine via libvirt
by Omer Khalid 21 Sep '07

21 Sep '07

Hi, I have been using libvirt in my python software for a while just to get deployed domain information. Usually I create a xen configuration file with all the parameters and trigger a "xm create -f file" command to deploy the VM. The problem I have noticed since some time is that as this command is forwarded from Python to Xen, and no error code is returned; I loose track if the domain deployment request fails which is rare but happens. So I thought to use libvirt for virtual machine deployment, and wondered if there are python bindings which I could use. I also try to look up for some kind of small example code to deploy a VM via libvirt on the libvirt site but didn't succeed to find. Can any body help me out with their experience? Thanks, Omer -- ---------------------------------------------------------- CERN – European Organization for Nuclear Research, IT Department, CH-1211 Geneva 23, Switzerland Phone: +41 (0) 22 767 2224 Fax: +41 (0) 22 766 8683 E-mail : Omer.Khalid(a)cern.ch Homepage: http://cern.ch/Omer.Khalid

2 3

[Libvir] Java bindings
by Tóth István 21 Sep '07

21 Sep '07

Hello! A development version of the java bindings I've been working on are available at : http://tiger.3ginformatika.hu/java-libvirt.tgz I'd appreciate your feedback on it. Building: Have java/gcc set up correctly through alternatives ( I use jpackage sun java 1.5.0 on Fedora 7 x86_64) Fix the include path in jni/Makefile run build.sh You should have the .so and .jar files built, and see the output from the basic test program. Using: See the test in build.sh Note: It's meant to be a thin translation layer on top of libvirt. The object model is similar to the python one. All error handling is done exclusively through exceptions. No documentation yet, but It's pretty self-explanatory. The build system is very primitive, I just hacked together something to build it outside my eclipse devel environment. The bindings are pretty complete, but minimally tested. License is LGPL. Best regards István

3 6

[Libvir] [PATCH] add no_tty flag for ssh
by Richard W.M. Jones 21 Sep '07

21 Sep '07

This patch adds an extra no_tty=1 flag to the connection URI. This stops ssh from asking for a password if it can't log in automatically. Typical use-case for this is in graphical programs where if ssh asks for a password it would cause the GUI program to hang. Example: $ virsh -c xen+ssh://xxx/ list rjones@xxx's password: Permission denied, please try again. rjones@xxx's password: Permission denied, please try again. rjones@xxx's password: Permission denied (publickey,gssapi-with-mic,password). libvir: Remote error : Connection reset by peer error: failed to connect to the hypervisor error: no valid connection $ virsh -c xen+ssh://xxx/?no_tty=1 list Permission denied (publickey,gssapi-with-mic,password). libvir: Remote error : Connection reset by peer error: failed to connect to the hypervisor error: no valid connection Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 8

[Libvir] PATCH: Do proper URI parsing for QEMU driver
by Daniel P. Berrange 21 Sep '07

21 Sep '07

The QEMU driver doesn't cope with URI parameters appended to the end of a path since it is just doing strcmp on the URI. This patch makes it use libxml's URI parsing code Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

[Libvir] [PATCH] detect path of dnsmasq, brctl
by Richard W.M. Jones 20 Sep '07

20 Sep '07

I have found 3 bugs in libvirtd in the way that it runs the external programs dnsmasq and brctl. Bug (1) is that it searches the $PATH to find dnsmasq. This is normally OK when libvirtd is launched from start-up scripts, but it's not very helpful if you run libvirtd by hand because likely-as-not your path won't contain /usr/sbin (the normal location of dnsmasq). Bug (2) is that if libvirtd can't execvp dnsmasq, then it doesn't fail in any obvious way. Bug (3) is that the path to brctl is hard-coded. This patch fixes bugs (1) & (3), but does not fix bug (2). Firstly configure has been changed so that it searches for dnsmasq and brctl programs in the usual places. If it find them then it generates a config.h file which looks like this: -------------------- /* Location or name of the brctl program (see bridge-utils) */ #define BRCTL "/usr/sbin/brctl" /* Location or name of the dnsmasq program */ #define DNSMASQ "/usr/sbin/dnsmasq" -------------------- If it doesn't find them then it just includes the program names, not full paths: -------------------- /* Location or name of the brctl program (see bridge-utils) */ #define BRCTL "brctl" /* Location or name of the dnsmasq program */ #define DNSMASQ "dnsmasq" -------------------- The code continues to use execvp to actually run the programs, so if the program names contain '/' then the absolute paths are used directly, otherwise execvp will do a shell-like search for the program along $PATH. Please nota bene the change to the spec file. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 2

Re: [Libvir] PATCH: Explicit detection of KVM version
by Daniel P. Berrange 20 Sep '07

20 Sep '07

On Thu, Sep 20, 2007 at 10:45:03AM +0200, Gerd Hoffmann wrote: > Daniel P. Berrange wrote: > > Before starting any guest, the QEMU driver needs to figure out what version > > of QEMU is in use & thus determine whether it supports particular command > > line flags. We currently do that just by calling /usr/bin/qemu, since all > > the various qemu-system-XXX binaries share the same syntax. The only problem > > is that qemu-kvm does not neccessarily match the version of qemu installed. > > So we detect QEMU version 0.8.2, but KVM is 0.9.0 based. The result is that > > we pass the wrong style VNC argument to KVM & it fails to start. The second > > problem is that even if you only ever want to run KVM guests, you still have > > to have KVM itself installed. > > We have the same problem if the domain.xml has > "<emulator>/path/to/qemu-foo</emulator>" specified, which I think isn't > addressed by this patch ... Nope it is not addressed. I think maybe instead of detecting once for QEMU and KVM for the QEMU driver as whole, I'll move the flags into the per-VM data structure. This will have extra overhead, since for each distinct VM we'll have todo a test launch of QEMU, but VM creation is not a performance bottleneck so I don't think its an issue. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

1 1

[Libvir] PATCH: Remove Xen Proxy driver
by Daniel P. Berrange 20 Sep '07

20 Sep '07

Since the previous patch allows the remote daemon to serve all the functions of the current Xen Proxy driver, this patch simply removes the Xen proxy and its driver. $ diffstat .hg/patches/remote-proxy Makefile.am | 2 a/proxy/.cvsignore | 5 a/proxy/Makefile.am | 19 a/proxy/libvirt_proxy.c | 852 ------------------------------------ a/src/proxy_internal.c | 1124 ------------------------------------------------ a/src/proxy_internal.h | 116 ---- src/Makefile.am | 1 src/xen_unified.c | 51 -- src/xen_unified.h | 9 9 files changed, 15 insertions(+), 2164 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 5

[Libvir] [PATCH] Add support for virConnectGetHostname and virConnectGetURI for qemu
by Richard W.M. Jones 20 Sep '07

20 Sep '07

Specifically this just adds support for virConnectGetHostname on qemu:/// URIs. Because of the way that the qemu driver now works, calls to virConnectGetURI are answered by the remote driver before the qemu driver ever sees them, so they have worked all along. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 3

[Libvir] PATCH: Explicit detection of KVM version
by Daniel P. Berrange 20 Sep '07

20 Sep '07

Before starting any guest, the QEMU driver needs to figure out what version of QEMU is in use & thus determine whether it supports particular command line flags. We currently do that just by calling /usr/bin/qemu, since all the various qemu-system-XXX binaries share the same syntax. The only problem is that qemu-kvm does not neccessarily match the version of qemu installed. So we detect QEMU version 0.8.2, but KVM is 0.9.0 based. The result is that we pass the wrong style VNC argument to KVM & it fails to start. The second problem is that even if you only ever want to run KVM guests, you still have to have KVM itself installed. This patch tweaks the feature/version detection so we do separate detection just for KVM. With this applied I can successfully start KVM guests if the QEMU version is different, or even if QEMU is not installed. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 2

[Libvir] [PATCH] virConnectNumOfDefinedDomains should set virterror if cannot connect to xend
by Richard W.M. Jones 19 Sep '07

19 Sep '07

As well as $SUBJECT this also adds a comment so that the apparent lack of error in another part of the code is clear. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

3 2

[Libvir] PATCH: Cleanup conditionals from proxy driver in Xen code
by Daniel P. Berrange 19 Sep '07

19 Sep '07

The various xen drivers have alot of their code conditionally compiled using #ifdef PROXY to avoid functions when built into the proxy. Without the proxy this is no longer needed. There are a couple of functions that were only used by the proxy & so can go completely. $ diffstat .hg/patches/proxy-cpp-cleanup xen_internal.c | 24 +------------------ xend_internal.c | 70 +++----------------------------------------------------- xml.c | 2 - xs_internal.c | 59 +---------------------------------------------- 4 files changed, 8 insertions(+), 147 deletions(-) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] PATCH: Allow control over UNIX socket perms & group in libvirtd
by Daniel P. Berrange 19 Sep '07

19 Sep '07

When I submitted the patches for PolicyKit[1] support a few weeks back Rich suggested that we should have the ability to set UNIX socket permissions and group ownership regardless. So this patch adds that ability. The default setting is still, group=root, and mode=0700 for R/W socket and mode=0777 for the R/O socket. It is possible to override this via the config file eg, Don't allow R/O monitoring unix_sock_ro_perms="0700" eg, Allow any user in 'admin' group to manage VMs unix_sock_group="admin" unix_sock_rw_perms="0770" eg, Allow anyone todo anything unix_sock_rw_perms="0777" NB, the fchgrp, and fchown syscalls don't have any effect on sockets, so to set the group ownership & desired mode, I have to play games with the setgid() and umask() calls prior to bind(), and then restore them to their original values. NB, the virConf apis don't seem to recognise Octal numbers when parsing the config file, so I've used strings for the permissions. Not a big deal really unless someone desperately wants to fix the config file parser... Dan. [1] A new set of patches will be forthcoming soon... -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 3

[Libvir] PATCH: Avahi advertisement for libvirtd
by Daniel P. Berrange 19 Sep '07

19 Sep '07

This is a serious patch at supporting Avahi advertisement of the libvirtd service. - configure by default will probe to see if avahi is available and if found will enable appropriate code. --with-avahi will force error if not found --without-avahi will disable it with no checking - HAVE_AVAHI is defined in config.h if avahi is found & used to conditionally enable some code in qemud/qemud.c - HAVE_AVAHI is also a Makefile conditional to enable compilation of the mdns.c and mdns.h files. A little makefile rearrangement was needed to make sure variables like EXTRA_DIST were defined before we appended to them with += - The code in mdns.c contains all the support for dealing with the Avahi APIs. - The primary Avahi API is horribily complicated for day-to-day use in application code, exposing far too much of the event loop and state machine. So we expose a simplified API to libvirt in mdns.h - We fully support the Avahi state machine, so you can start libvirt even if Avahi is not running on the machine. If you later start Avahi, then libvirt will automatically detect & register with it. Likewise if you stop Avahi we handle that gracefully by shutting down our internal mdns support & waiting for avahi to restart. NB this does require that the DBus system bus daemon is running. This is a limitation of the current Avahi client library & not our use of it. It is expected this will be fixed in future avahi releases. - The Avahi client library is basically a shim which talks to the Avahi daemon using DBus system daemon. The DBus stuff doesn't leak out of the Avahi APIs - it is loosely couple - all we need do is provide Avahi with an event loop implementation which was surprisingly easy. The libvirtd daemon does now indirectly link with DBus, but I don't see any problem with this. Don't want it - then use --without-avahi - We advertise a service name of _libvirt._tcp The IETF draft recommends use of the name from /etc/services associated with your app. There is a way to register official Avahi services names. We don't have an /etc/service name registered either though. - If TLS is *not* enabled, we advertise _libvirt._tcp with a port number of 0. The use of a port number 0 is explicitly allowed by the IETF draft docs - see [1] "8. Flagship Naming". If seeing the _libvirt._tcp service with a port of 0, then clients should figure out some way to to tunnel to the UNXI domain socket on the advertised machine. The tunnel mechanism is undefined, though SSH is the obvious choice. If TLS is enabled, then we use getsockname() to fetch the actual port number we're listening on for the TLS enabled socket. This plays nice with admins ability to override the port number. Clients can still of course choose to tunnel instead of use TLS. NB. we explicitly refuse to advertise the non-TLS port. - The default service name we advertise is 'Virtualization Host %h' where '%h' is the short hostname (ie without domain name). This has to be less than 63 characters & stripping domain name is usual practice, since this is implicit from the mdns domain you are browsing. This can be overridden with mdns_name="Blah" in the libvirtd.conf configuration file. Service names *must* be unique in the LAN. If a name clashes, then avahi appends junk like #1, #2, #3... until it is unique. - Even when compiled in, use of Avahi mdns can be disabled by setting the mdns_adv=0 config file parameter in /etc/libvirt/libvirtd.conf - This patch does not advertise any per-VM VNC server instances, but I have prepared the APIs in mdns.h to be ready to support that with minimal effort. A pre-requisite for this is an extension to the driver API to get async signals when VMs start & stop, since making the daemon poll hypervisors will suck big time. When implemented each VM will be its own mdns 'group' and the VNC server associated with it will be the 'service' advertised in that group. Having applied this patch & started the daemon, if /etc/init.d/avahi-daemon is running, you should see the service advertised on the LAN. As mentioned earlier if you start Avahi daemon after libvirt it should detect this too. You can verify by running the following on another box on the same local LAN segment. $ avahi-browse --resolve _libvirt._tcp When you start libvirtd on the other box the avahi-browse should print out a record. It should look like this: + eth0 IPv4 Virtualization Host avocado _libvirt._tcp local = eth0 IPv4 Virtualization Host avocado _libvirt._tcp local hostname = [avocado.local] address = [10.13.7.48] port = [16514] txt = ["org.freedesktop.Avahi.cookie=3025088350"] If you've not configured TLS, then port will be '0' instead of 16514. So that brings me nicely onto the main outstanding issue. Notice the hostname is 'avocado.local' - this is the standard mdns practice for zero-conf DNS hostnames. If you're /etc/nsswitch.conf is setup correctly the name avocado.local will actually resolve to the IP address you see there of '10.13.7.48' (well s/avocado/your hostname/ of course). Well, x509 certificates include a FQDN in them & the client is expected to validate the certificate hostname against the hostname it connected to. Now my FQDN is avocado.virt.boston.redhat.com which is obviously going to not validate against avocado.local. There're a couple of ways around this issue I can come up with so far - Recommend that the client try to reverse-DNS the 'address' field from the mdns advertisement. If reverse-DNS is working, 10.13.7.48 will be transformed into 'avocado.virt.boston.redhat.com' which the client can then connect to. - Add TXT record containing the hostname associated with the certificate. If the client were to use this record, then obviously any validation of it against the resulting certificate is sort-of pointless, since both came from the server. The first approach rather had this drawback too. - Advertise the records in the real domain 'virt.boston.redhat.com' instead of '.local'. Not been able to make this work. - Simply don't bother validating the remote hostname against the server certificate cname. ie, take the position that if using zero-conf then you already have some implicit level of trust in your LAN and validating the cert against the CA cert is sufficient & hostname matching can be ignored. These are all mildy abusing mdns / zeroconf, but then x509 certificates don't really fit into the model of 'zero conf' in the first place. If people want true zero-conf then the (SSH) tunnel is better (and always available), but if they've setup certificates they should still be allowed to use zero-conf to at least locate hosts. So mildly abusing the rules is reasonable IMHO. Personally I'm tending towards the latter approach. Regards, Dan. [1] http://files.dns-sd.org/draft-cheshire-dnsext-dns-sd.txt -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

3 5

[Libvir] PATCH: Allow updating of timer & file handle event watches
by Daniel P. Berrange 19 Sep '07

19 Sep '07

The forthcoming patch to add Avahi support requires a couple of enhancements to our event loop to support integration with Avahi's event callback needs - Ability to update the event mask for a pre-existing file handle watch - Ability to change the frequency of a timer watch - Ability to have a timer which fires immediately - Ability to disable events on a timer watch The first point was trivial - just change the 'events' flag we have recorded in the virEventHandle struct. The second point was also trivial - just change the period of the timer as recorded in virEventTimer struct. The last two points were more tricky, but doable. To fire a timer immediately I tweaked the logic so that it allows a frequency of '0'. Obviously to avoid spinning 100%, the app should unregister the timer once it has fired the desired number of times (usually 1). To disable a timer temporarily I allow the use of '-1' in the frequency. THe code had a bad mix of terminology using a 'timer' and 'timeout' field in the virEventTimer struct which confused me no end. So I renamed the 'timeout' field to 'frequency' which reflects its actual purpose. Finally, when building with debugging, the event loop can generate alot of data, so I added a EVENT_DEBUG macro to the file which prefixes EVENT: on all debug output so allow easy filtering. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 3

[Libvir] PATCH: Disable automake portability warnings
by Daniel P. Berrange 19 Sep '07

19 Sep '07

The latest automake has a nasty habit of complaining about use of GNU Make features such as wildcards. We use these extensively in the tests/ directory since there are so many test datafiles, listing them explicitly is a waste of time. The attached patch passes the -Wno-portability flag to automake to make it keep quiet. NB, to do this required a bit of a re-working of the automake/autoconf initialization stuff. Our current configure script uses AC_INIT and AM_INIT_AUTOMAKE in the so called 'legacy style'. To quote the automake manual [quote] If your `configure.ac' has: AC_INIT([src/foo.c]) AM_INIT_AUTOMAKE([mumble], [1.5]) you can modernize it as follows: AC_INIT([mumble], [1.5]) AC_CONFIG_SRCDIR([src/foo.c]) AM_INIT_AUTOMAKE [/quote] This re-arrangement is valid on any non-jurassic era automake & only impacts developers running autogen.sh - not end users running the configure script itself. The one complication is that the version given to AC_INIT must be a literal, but we currently used an environment variable. So m4 black-magic gets around this problem. I also killed LIBVIRT_VERSION_EXTRA since it is not referenced anywhere in the source tree. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 2

[Libvir] Network blocking issue
by Shuveb Hussain 17 Sep '07

17 Sep '07

Hi, I observed this while using the python bindings and accessing a remote host with libvirt: >>> import libvirt >>> c = libvirt.open('xen://veetee/') >>> c.getInfo() ['i686', 2021, 2, 1864, 1, 1, 2, 1] >>> c.getInfo() ['i686', 2021, 2, 1864, 1, 1, 2, 1] # remove network cable from remote machine now >>> c.getInfo() # blocks forever.... What is the problem here and is there a solution to this? I am running FC7 and here is the version info from virsh: virsh # version Compiled against library: libvir 0.3.2 Using library: libvir 0.3.2 Using API: Xen 3.0.1 Running hypervisor: Xen 3.1.0 I observed this for more than 10 mins, it was still hung. Thanks in advance! -- Shuveb Hussain. Money has nothing to do with Happiness, But, Poverty has a lot to do with Sorrow. Company: www.binarykarma.com Blog: www.binarykarma.org

4 9

[Libvir] NUMA topology calls
by beth kon 17 Sep '07

17 Sep '07

Daniel, We agreed that xenHypervisorGetCapabilities will call a xend_internal.c function to get the topology through xend. Was your intent to extend xenDaemonNodeGetInfo or have a new function, such as xenDaemonNodeGetTopology? I assumed a new function would be cleaner, but you didn't include such a function in your patch so I'm not sure if you had some other idea. -- Elizabeth Kon (Beth) IBM Linux Technology Center Open Hypervisor Team email: eak(a)us.ibm.com

2 1

[Libvir] PATCH: Prevent zombie ssh tunnels
by Daniel P. Berrange 17 Sep '07

17 Sep '07

I noticed that when using the SSH tunnel for the remote driver I ended up with alot of zombie SSH processes. We simply forgot to waitpid() on the child when a connection attempt failed, or when shutting down an open remote connection. Attached is a possible patch Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

4 10

[Libvir] RFC: Broadcast our presence with avahi
by Daniel P. Berrange 14 Sep '07

14 Sep '07

All the really trendy network services these days broadcast their presence on the LAN using mDNS. In Linux world this means becoming an Avahi client and registering our services. virt-manager is also able to become an Avahi client and browser for services. So you'll be able to let the user just pick a host straight off a list instead of typing in hostname. The attached patch does two things: - Extends our event loop implementation so it can modify the event mask associated with an FD, and the timeout associated with a timer. While you could simulate this with an add & remove, this has the possibility of failure (from malloc). Merely updating an existing event can be done without failure. Avahi needs this ability for its event loop integration - Added qemu/mdns.c file to actually provide the service information. This has two parts. The first section of code is taken straight from one of the Avahi example programs. The second section is a implementaiton of the Avahi event loop contract in terms of our event API - it works very nicely which says good things about design of our event loop Some things... - I arbitrarily picked a service type of '_libvirtd._tcp'. The docs on picking service types seem non-existant on Avahi website, but it seems to be common to use service name from /etc/services and protocol both prefixed with _. - I advertise two subtypes, of '_xen.libvirtd._tcp' and '_qemu.libvirtd._tcp' What I actually want todo is to be able to probe the libvirt local drivers to auto-discover what virtualization platforms are available. A sort of lightweight virConnectOpen which merely returns TRUE/FALSE and doesn't actually allocate a virConnectPtr object. Need to extend the internal driver API for this. - I want to advertise whether the server is configured with TLS certs or not, so remote clients can automatically choose to use SSH urls with the remote driver if neccessary. - Let the admin turn advertisement on/off in the config file because some people may not like it on their LAN. If you fancy trying it, avahi-browse --all from another host on the LAN should show the service being advertised. The advertisements do not cross LAN routers by default. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

4 8

[Libvir] Segfault with invalid virConnectPtr
by Richard W.M. Jones 13 Sep '07

13 Sep '07

Program terminated with signal 11, Segmentation fault. #0 0x0000003d8b472a1b in free () from /lib64/libc.so.6 (gdb) bt #0 0x0000003d8b472a1b in free () from /lib64/libc.so.6 #1 0x00002aaaaaae8dd7 in virResetError (err=0x33535c8) at virterror.c:111 #2 0x00002aaaaaae8fce in __virRaiseError (conn=0x33535a0, dom=0x0, net=0x0, domain=0, code=6, level=VIR_ERR_ERROR, str1=0x2aaaaab0c678 "invalid connection pointer in %s", str2=0x2aaaaab08560 "virConnectNumOfDomains", str3=0x0, int1=0, int2=0, msg=0x2aaaaab0c678 "invalid connection pointer in %s") at virterror.c:358 #3 0x00002aaaaaacfa8e in virLibConnError (conn=0x33535a0, error=VIR_ERR_INVALID_CONN, info=0x2aaaaab08560 "virConnectNumOfDomains") at libvirt.c:127 #4 0x00002aaaaaad1052 in virConnectNumOfDomains (conn=0x736e6961) at libvirt.c:758 #5 0x000000000043fa4e in ?? () A preliminary look at the code seems to indicate a fault in this logic: int virConnectNumOfDomains(virConnectPtr conn) { DEBUG("conn=%p", conn); if (!VIR_IS_CONNECT(conn)) { virLibConnError(conn, VIR_ERR_INVALID_CONN, __FUNCTION__); The VIR_IS_CONNECT macro is defined as: #define VIR_CONNECT_MAGIC 0x4F23DEAD #define VIR_IS_CONNECT(obj) ((obj) && (obj)->magic==VIR_CONNECT_MAGIC) Obviously if VIR_IS_CONNECT fails then "conn" should not be used further, so calling virLibConnError (conn, ...) is wrong. Personally I think when we detect memory corruption in a C program we should just call abort(). I'll see if I can come up with a patch to fix this later ... at the moment I'm more interested in why my program is passing an invalid connection pointer in the first place :-( Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 4

[Libvir] [PATCH] properly check buffer size in virDomainXMLDevID
by Hugh Brock 12 Sep '07

12 Sep '07

As promised, a patch to protect the 80-character "device id" buffer from overflow by the unbounded "device=" XML attribute. Before, a large "device" attribute gave a stack overflow error; now it merely results in an obscure (but non-fatal) xend error like so: libvir: Xen Daemon error : POST operation failed: (xend.err "invalid literal for int() with base 10: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'") (the long string of "x"es was my way of overflowing the buffer). Please ACK... --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock(a)redhat.com | virtualization library http://libvirt.org

2 3