- Devel - libvirt List Archives

[libvirt] [PATCH] chown kernel/initrd before spawning qemu
by Mark McLoughlin 06 Aug '09

06 Aug '09

If we're running qemu unprivileged, we need to chown any supplied kernel or initrd before spawning it. * src/qemu_driver.c: rename qemuDomainSetDiskOwnership() to qemuDomainSetFileOwnership(), pass it a path string instead of a disk definition and use it for chowning the kernel/initrd in qemuDomainSetAllDeviceOwnership() --- src/qemu_driver.c | 20 ++++++++++++-------- 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 412b68d..bd58435 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -1684,18 +1684,18 @@ static int qemuDomainSetHostdevOwnership(virConnectPtr conn, } -static int qemuDomainSetDiskOwnership(virConnectPtr conn, - virDomainDiskDefPtr def, +static int qemuDomainSetFileOwnership(virConnectPtr conn, + const char *path, uid_t uid, gid_t gid) { - if (!def->src) + if (!path) return 0; - VIR_DEBUG("Setting ownership on %s to %d:%d", def->src, uid, gid); - if (chown(def->src, uid, gid) < 0) { + VIR_DEBUG("Setting ownership on %s to %d:%d", path, uid, gid); + if (chown(path, uid, gid) < 0) { virReportSystemError(conn, errno, _("cannot set ownership on %s"), - def->src); + path); return -1; } return 0; @@ -1725,7 +1725,7 @@ static int qemuDomainSetDeviceOwnership(virConnectPtr conn, (def->data.disk->readonly || def->data.disk->shared)) return 0; - return qemuDomainSetDiskOwnership(conn, def->data.disk, uid, gid); + return qemuDomainSetFileOwnership(conn, def->data.disk->src, uid, gid); case VIR_DOMAIN_DEVICE_HOSTDEV: return qemuDomainSetHostdevOwnership(conn, def->data.hostdev, uid, gid); @@ -1753,12 +1753,16 @@ static int qemuDomainSetAllDeviceOwnership(virConnectPtr conn, uid = restore ? 0 : driver->user; gid = restore ? 0 : driver->group; + if (qemuDomainSetFileOwnership(conn, def->os.kernel, uid, gid) < 0 || + qemuDomainSetFileOwnership(conn, def->os.initrd, uid, gid) < 0) + return -1; + for (i = 0 ; i < def->ndisks ; i++) { if (restore && (def->disks[i]->readonly || def->disks[i]->shared)) continue; - if (qemuDomainSetDiskOwnership(conn, def->disks[i], uid, gid) < 0) + if (qemuDomainSetFileOwnership(conn, def->disks[i]->src, uid, gid) < 0) return -1; } -- 1.6.2.5

2 3

[libvirt] VMware ESX 3/3: Cleanup varaible naming
by Matthias Bolte 06 Aug '09

06 Aug '09

Subject says it all. No functional change included. Matthias

3 2

[libvirt] virt-manager
by Michael Zeller 06 Aug '09

06 Aug '09

okay so using virt-manager it only lists my root partition as storage, or atleast thats what it appears So it says I can only make a vm the size of 9G when my home partition has 800+G is there a way to change that?

2 1

[libvirt] libvirt-0.3.3-14.el5 (redhat rpm) vs libvirt-0.6.5 (source)
by Jim Bergensen 06 Aug '09

06 Aug '09

Hello everyone, I am looking to write a simple php interface to create, stop, start, restart, configure, backup, transfer VM's across a network of servers. Storage is done locally on the particular node (lvm), but I am considering to do this through iscsi in the future. Xen, KVM, IP management, firewalling is an important requirement. The redhat backport version looks outdated, but I know the version number isn't the best way to compare features. My questions are: - Featurewise, is the difference between the redhat version and the libvirt.org source version small or as big as it looks (branch versions?) - Considering the above functions I am going to need, will the redhat version suffice? Any help would be truely appreciated, Thank you, Jim

4 4

[Fwd: Re: [libvirt] Release of libvirt-0.7.0]
by Robert L Cochran 06 Aug '09

06 Aug '09

Ooops! I sent this to Dan when I meant to send it to the list. To be a bit repetitive...how do I get this for Fedora 11 -- and all of its dependencies? Thanks Bob -------- Original Message -------- Subject: Re: [libvirt] Release of libvirt-0.7.0 Date: Wed, 05 Aug 2009 16:37:09 -0400 From: Robert L Cochran <cochranb(a)speakeasy.net> To: veillard(a)redhat.com How do I get this for Fedora 11 -- and all of its dependencies? Thanks a lot! Bob On 08/05/2009 11:15 AM, Daniel Veillard wrote: > A couple days later than expected, but considering the current > flow of fixes, that's not a bad thing. This is a huge release, > this includes more than 250 commits in a month and many new > functionalities or drivers, and a lot of improvements and bug fixes: > > New features: > - Interface implementation based on netcf (Laine Stump Daniel Veillard) > - Add new net filesystem glusterfs (Harshavardhana) > - Initial VMWare ESX driver (Matthias Bolte) > - Add support for VBox 3 and event callbacks on vbox (Pritesh Kothari) > - First version of the Power Hypervisor driver (Eduardo Otubo) > - Run QEMU guests as an unprivileged user (Daniel P. Berrange) > - Support cgroups in QEMU driver (Daniel P. Berrange) > - QEmu hotplug NIC support (Mark McLoughlin) > - Storage cloning for LVM and Disk backends(Cole Robinson) > - Switching to GIT (Jim Meyering) > > Documentation: > - Typo and comment fixes (Aron Griffis) > - Fix virCapabilitiesDefaultGuestMachine documentation. (Chris Lalancette) > - ESX Scheduler documentation and cleanup (Matthias Bolte) > - Update the java bindings page (Bryan Kearney) > - Added Matthias Bolte to AUTHORS list (Daniel Veillard) > - doc: clone+build instructions (Jim Meyering) > - docs: say that the old repository is deprecated... (Jim Meyering) > - document tcp listen and raw wire option (Guido Günther) > - Fix docs and code disagreements for character devices. (Cole Robinson) > - Fix documentation of virStoragePoolUndefine return (Thomas Treutner) > - Fix gitweb link on download page. (Cole Robinson) > - update download informations after switch to git (Daniel Veillard) > - Update links to bugzilla (Garry Dolley) > - Update the links for RHEL libvirt bugzillas (Garry Dolley) > > Portability: > - Xen Inotify support needs sys/inotify.h (Maximilian Wilhelm) > - Workaround for broken GCC in Debian Etch (Maximilian Wilhelm) > - LXC driver requires sched.h and unshare() (Maximilian Wilhelm) > - Configure UML support only if sys/inotify.h present (Maximilian Wilhelm) > - Fix libcurl automatic check and ESX status (Maximilian Wilhelm) > - Enable ESX driver build on Mingw32 (Daniel P. Berrange) > - Fix build on mingw32 by disabling netcf (Daniel P. Berrange) > - Reduce glusterfs dependency to 2.0.1 (Mark McLoughlin) > - Desactivate phyp build and indicate libssh builreq (Daniel Veillard) > - Fix misc Win32 compile warnings (Daniel P. Berrange) > - Rename variable for compilation in Mingw32 (end) (Laine Stump) > - Rename variable for compilation in Mingw32 (Laine Stump) > - rpm spec cleanup and split off client only package (Daniel Veillard) > > Bug fixes: > - Add uniqueness checking for LXC define/create methods (Daniel P. Berrange) > - Fix removal of transient VMs when LXC aborts (Daniel P. Berrange) > - Don't try to activate cgroups if not present for LXC (Daniel P. Berrange) > - Refresh /etc/xen if inotify wasn't (Cole Robinson) > - Don't loose id on xen domain redefine (Cole Robinson) > - Fix memory leak in openvz driver (Daniel P. Berrange) > - Protected against potential crash scenarios (Daniel P. Berrange) > - Fix crash when attempting to shutdown inactive QEMU vm (Daniel P. Berrange) > - Fix PCIe FLR detection (Mark McLoughlin) > - Set perms on /var/lib/libvirt/images to 0711 (Mark McLoughlin) > - Fix problem writing QEMU pidfile (Daniel P. Berrange) > - Fix vcpupin on Xen problem (Henrik Persson) > - Fix RPM upgrades from F11 to F12 (Daniel P. Berrange) > - Fix deadlock in remote driver domain events (Daniel P. Berrange) > - qemu: fix monitor socket reconnection (Ryota Ozaki) > - Fix polkit/netcf disabling on older fedoras (Mark McLoughlin) > - Fix crashes in Xen capabilities code (Daniel P. Berrange) > - Always add -no-kvm and -no-kqemu, for qemu domains (Jim Paris) > - Avoid raising an internal error (Paolo Bonzini) > - Don't allow NULL paths for BlockStats and InterfaceStats (Cole Robinson) > - Don't leak vm->monitorpath on re-connect (Mark McLoughlin) > - Don't restore labels on shared/readonly disks (Daniel P. Berrange) > - Ensure spawned children have a stderr/out set to /dev/null if requested (Daniel P. Berrange) > - Ensure test:/// URIs get routed to the non-privileged libvirtd (Daniel P. Berrange) > - fix another failing "make distcheck" (qemuhelptest) (Jim Meyering) > - Fix an uninitialized variable in Unix socket open (Jun Koi) > - Fix configure flags in spec file (Daniel Veillard) > - Fix error reporting for security driver over remote protocol (Daniel P. Berrange) > - fix failing "make distcheck" (Jim Meyering) > - Fix free of unitialized data upon PCI open fail (Daniel P. Berrange) > - Fix informations about previous git server (Daniel Veillard) > - Fix memory leaks in esxDomainDumpXML (Matthias Bolte) > - Fix multiple memory leaks in virsh (Laine Stump) > - Fix PCI device hotplug/unplug with newer QEMU (Daniel P. Berrange) > - Fix problem with QEMU monitor welcome prompt confusing libvirt after a libvirtd daemon restart with active guests (Daniel P. Berrange) > - Fix python examples to use read-write conn (Dan Kenigsberg) > - Fix reconnect bug for VBox (Pritesh Kothari) > - Fix SELinux denial during hotplug (Daniel P. Berrange) > - Fix typo in check for glusterfs format pools (Daniel P. Berrange) > - Fix typo in storage cloning (Daniel P. Berrange) > - qemu: Check driver is initialized up front, to avoid segfault. (Cole Robinson) > - qemu: Try multiple times to open unix monitor socket (Cole Robinson) > - Release conn lock before reporting errors (end) (Laine Stump) > - Release conn lock before reporting interface errors (Laine Stump) > - Remove the network backend if NIC hotplug fails (Mark McLoughlin) > - Set specific flags for glusterfs fs mounts (Harshavardhana) > - storage: disk: Default to 'ext2' for new volumes. (Cole Robinson) > - storage: disk: Fix parthelper '-g' option handling. (Cole Robinson) > - storage: disk: Fix segfault creating volume without target path (Cole Robinson) > - storage: Fix deadlock when cloning across pools. (Cole Robinson) > - Update modified mac address in place in virGetInterface (Laine Stump) > > Improvements: > - Add an allocation unit when calling qemu-img (Ryota Ozaki) > - Improve diagnostics when pidfile writing fails (Daniel P. Berrange) > - Disable IPv6 on virtual networks (Daniel P. Berrange) > - Allow dnsmasq to provide DNS without DHCP (Daniel P. Berrange) > - Fix an initialization problem in previous patch (Aron Griffis) > - Remove MAX_TAP_ID and let kernel do numbering (Aron Griffis) > - Kernel command line support for UML (Ron Yorston) > - Activate the interface drivers, and cleanups (Daniel Veillard) > - Add an error code for conflicting mac addresses (Laine Stump) > - Add a test interface driver (Laine Stump) > - Add canonical machine name to capabilities output (Mark McLoughlin) > - add cd and pwd commands to virsh (Paolo Bonzini) > - Add checks for some NIC hotplug related features added in qemu-0.10.0 (Mark McLoughlin) > - Add domain autostart for LXC driver (Daniel P. Berrange) > - Add domain events support to LXC driver (Daniel P. Berrange) > - Add interface object list manipulation functions (Laine Stump) > - Add internal XML parsing/formatting flag (Mark McLoughlin) > - Add netcf XML schemas and test data (Daniel Veillard) > - Add new net filesystem glusterfs (Harshavardhana) > - Add NIC and hostnet names to domain state XML (Mark McLoughlin) > - Add no_verify query parameter to ESX URIs (Matthias Bolte) > - Add SCM_RIGHTS support to QEMU monitor code (Mark McLoughlin) > - Add support for attaching network/bridge NICs in QEMU driver (Mark McLoughlin) > - add support for netcf XML import and export (Daniel Veillard) > - Add support for network device detach (Mark McLoughlin) > - Add support for physical memory access for QEmu (Nguyen Anh Quynh) > - Add support for VBox 3 and event callbacks on vbox (Pritesh Kothari) > - Add the monitor type to the domain state XML (Mark McLoughlin) > - Add virCapsGuestMachine structure (Mark McLoughlin) > - Add virsh commands for network interface management (Laine Stump) > - Allow autostart of libvirtd to be disabled with LIBVIRT_AUTOSTART=0 (Daniel P. Berrange) > - Allow leading dots in VMX config entry names (Matthias Bolte) > - Assign names to qemu NICs and network backends (Mark McLoughlin) > - Basic qemu NIC hotplug support (Mark McLoughlin) > - build: adjust aclocal's search patch to prefer gnulib's m4 files. (Jim Meyering) > - build: automatically rerun ./bootstrap when needed (Jim Meyering) > - build: make autogen.sh use autoreconf -if (Jim Meyering) > - build: submodule machinery now works also when no tag is reachable (Jim Meyering) > - Canonicalize qemu machine types (Mark McLoughlin) > - Change code generator to give async event messages their own postfix (Daniel P. Berrange) > - Change the way client event loop watches are managed (Daniel P. Berrange) > - Decode incoming request header before invoking dispatch code (Daniel P. Berrange) > - Define an API for registering incoming message dispatch filters (Daniel P. Berrange) > - ESX driver accept VI API version 4.0 (Matthias Bolte) > - Fill in vCPU<-> pCPU current mapping, and vCPU cpuTime for QEMU (Daniel P. Berrange) > - generate ChangeLog from git logs into distribution tarball (Jim Meyering) > - Implement qemu dump capabilities (Paolo Bonzini) > - Implement schedular tunables API using cgroups (Daniel P. Berrange) > - Implement the new virinterface functions (Laine Stump) > - Make cgroups a little more efficient (Daniel P. Berrange) > - Make it easier to debug tests running programs (Daniel P. Berrange) > - Make qemuBuildHostNetStr() take tapfd as a string (Mark McLoughlin) > - Make QEMU cgroups use configurable (Daniel P. Berrange) > - Make qemuCmdFlags available in qemudDomainAttachDevice() (Mark McLoughlin) > - Move queuing of RPC replies into dispatch code (Daniel P. Berrange) > - Move vnet_hdr logic into qemudNetworkIfaceConnect() and export it (Mark McLoughlin) > - Netcf based interface driver implementation (Laine Stump) > - netcf XML validation and input and output tests (Daniel Veillard) > - Only probe qemu for machine types when binary changes (Mark McLoughlin) > - Place every QEMU guest in a private cgroup (Daniel P. Berrange) > - Probe for QEMU machine types (Mark McLoughlin) > - Probe QEMU directly for machine aliases if not found in capabilties (Mark McLoughlin) > - Public API for new virInterface functions (Laine Stump) > - python: Raise exceptions if virDomain*Stats fail. (Cole Robinson) > - Refactor cgroups to allow a group per driver to be managed directly (Daniel P. Berrange) > - Re-factor pci_add reply parsing and parse domain/bus numbers (Mark McLoughlin) > - Retain disk PCI address across libvirtd restarts (Mark McLoughlin) > - Retain PCI address from NIC attach (Mark McLoughlin) > - Run QEMU guests as an unprivileged user (Daniel P. Berrange) > - Separate code for encoding outgoing remote message headers (Daniel P. Berrange) > - Split generic RPC message dispatch code out from remote protocol API handlers (Daniel P. Berrange) > - Split out code for handling incoming method call messages (Daniel P. Berrange) > - storage: Break out actual raw cloning to separate function. (Cole Robinson) > - storage: cleanup: do away with 'createFile' (Cole Robinson) > - storage: disk: Use capacity, not allocation, when creating volume. (Cole Robinson) > - storage: Don't try sparse detection if writing to block device. (Cole Robinson) > - storage: Implement 'CreateBlockFrom' helper. (Cole Robinson) > - storage: Implement CreateVolFrom for logical and disk backend. (Cole Robinson) > - storage: Move most of the FS creation functions to common backend. (Cole Robinson) > - storage: Refactor FS backend 'create' function choosing. (Cole Robinson) > - Store the interface vlan number in the domain state (Mark McLoughlin) > - Support<video> element for QEMU guests (Daniel P. Berrange) > - Support<video> tag for defining VGA card properties (Daniel P. Berrange) > - Switch to using a unix socket for the qemu monitor (Mark McLoughlin) > - test: Generate net interface names when assigning XML. (Cole Robinson) > - test: Implement BlockStats and InterfaceStats (Cole Robinson) > - Use cgroups for block device whitelisting in QEMU guests (Daniel P. Berrange) > - Use enums for cgroup controller types / labels (Daniel P. Berrange) > - Use sendmsg() on QEMU monitor socket (Mark McLoughlin) > - Use virDomainChrTypeFromString() instead of open coding (Mark McLoughlin) > - Use virFileReadAll/virFileWriteStr for key cgroup read/write helpers (Daniel P. Berrange) > - virGetinterface matching of MAC and interface name (Laine Stump) > > Cleanups: > - Fix configure checks from previous commits (Daniel P. Berrange) > - Avoid a warning if compiling without inotify (Daniel P. Berrange) > - Remove a stray semicolon (Daniel Veillard) > - Extend the ESX URL to habdle ports and GSX (Matthias Bolte) > - Fix escaping of 8-bit high characters (Daniel P. Berrange) > - Remove ATTRIBUTE_UNUSED from flags to qemudDomainMigratePerform. (Chris Lalancette) > - Add a comment about setting errors after qemudStartVMDaemon(). (Chris Lalancette) > - Fix an erroneous debug error to KVM; it should read QEMU/KVM. (Chris Lalancette) > - Remove a stray semicolon in qemudDomainMigratePrepare2. (Chris Lalancette) > - Convert a few stray users of free() in libvirt.c to VIR_FREE(). (Chris Lalancette) > - Use virGetHostname instead of gethostname. (Chris Lalancette) > - Fix up a minor indentation issue with virDomainMigratePrepare. (Chris Lalancette) > - Fix up a silly typo in apibuild.py. (Chris Lalancette) > - Avoid warning when compiling without IFF_VNET_HDR (Maximilian Wilhelm) > - Capilize libvirt-client summary (Mark McLoughlin) > - Move ldconfig calls to libvirt-client %post/%postun (Mark McLoughlin) > - Convert NEWS to UTF-8 (Mark McLoughlin) > - Fix trailing whitespace in NEWS (Mark McLoughlin) > - No need to build require both python-devel and python (Mark McLoughlin) > - Remove executable perms from /etc/sysconfig/libvirtd (Mark McLoughlin) > - Use a %postun -p for one line scriptlet (Mark McLoughlin) > - Don't explicitly require libxml2 (Mark McLoughlin) > - Fix some unowned directories (Mark McLoughlin) > - Kill qemu BuildRequires (Mark McLoughlin) > - Enable netcf by default (Mark McLoughlin) > - Default to with_polkit (Mark McLoughlin) > - Make vbox support configurable (Mark McLoughlin) > - Build with --without-capng if capng is disabled (Mark McLoughlin) > - BuildRequires libcap-ng-devel not capng-devel (Mark McLoughlin) > - Drop curl host check when using ESX without check (Shahar Klein) > - Fix typo in xen capabilities code (Daniel P. Berrange) > - Add bare format string to printf-derivatives troubles (Laine Stump) > - Add phyp files to POTFILES, to make syntax-check happy. (Cole Robinson) > - avoid a make distcheck failure: distribute docs/schemas/interface.rng (Jim Meyering) > - avoid a make distcheck failure: distribute tests/interfaceschemadata/ (Jim Meyering) > - avoid a "make syntax-check" failure (Jim Meyering) > - build: do not emit a trailing blank line into VC'd file, NEWS (Jim Meyering) > - build: update from gnulib, for latest maint.mk (Jim Meyering) > - Clean up error handling in qemudDomainAttachNetDevice() (Mark McLoughlin) > - Cleanup qemu binary detection logic in qemudCapsInitGuest() (Mark McLoughlin) > - Commit newly generated docs, after changes from commit 2348cf. (Cole Robinson) > - Factor qemuBuildHostNetStr() out from qemuBuildCommandLine() (Mark McLoughlin) > - Factor qemuBuildNicStr() out from qemuBuildCommandLine() (Mark McLoughlin) > - Factor qemudMonitorSend() out of qemudMonitorCommandExtra() (Mark McLoughlin) > - Fix cgroup compile warnings (Daniel P. Berrange) > - Fix misc build problems due to new drivers (Daniel P. Berrange) > - Fix wierd build problems due to autopoint overwriting gnulib m4 (Daniel P. Berrange) > - Makefile.cfg: Rename to... (Jim Meyering) > - make .gnulib a submodule (Jim Meyering) > - make "make syntax-check" consistent with "git diff --check" (Jim Meyering) > - Minor qemu monitor coding style fixes (Mark McLoughlin) > - Prepare to use maint.mk from gnulib (Jim Meyering) > - Refactor incoming message handling to prepare for data stream support (Daniel P. Berrange) > - Refactor message sending to allow code reuse for data streams (Daniel P. Berrange) > - remove all .cvsignore files (Jim Meyering) > - remove all trailing blank lines (Jim Meyering) > - Remove some unused variables and cut long lines (Daniel Veillard) > - Remove trailing blank lines (Daniel Veillard) > - Rename a bunch of internal methods to clarify their meaning (Daniel P. Berrange) > - Rename 'direction' to 'type' in remote_message_header (Daniel P. Berrange) > - Report the object name on lookup error (Daniel Veillard) > - Simplify remote driver error reporting (Daniel P. Berrange) > - skip some of gnulib's new rules (Jim Meyering) > - use automake-1.11's silent-rules option, when possible (Jim Meyering) > - use gnumakefile and maintainer-makefile modules from gnulib (Jim Meyering) > > > It's also good to see a lot of new contributors in this release, > so thanks to everybody ! > > Daniel > >

2 1

[libvirt] VMware ESX 2/3: Fix memleak if esxOpen fails
by Matthias Bolte 06 Aug '09

06 Aug '09

Subject says it all. Matthias

2 1

[libvirt] VMware ESX 1/3: Add proper OOM reporting for esxDomainGetOSType
by Matthias Bolte 06 Aug '09

06 Aug '09

Subject says it all. Matthias

2 1

[libvirt] running with UID != 0: internal error about bridged network
by Harald Dunkel 06 Aug '09

06 Aug '09

Hi folks, I would like to avoid running the virtual hosts with UID=0. But if I try to create a new virtual machine without being root, then it fails with % name=Lenny_amd64 % kvmdir=/local/kvm % mkdir -p $kvmdir/$name % qemu-img create -f qcow2 $kvmdir/$name/hda.qcow2 32G Formatting '/local/kvm/Lenny_amd64/hda.qcow2', fmt=qcow2, size=33554432 kB % virt-install --connect=qemu:///session -n $name -r 1024 -vcpus=1 -f $kvmdir/$name/hda.qcow2 --network=bridge:br0 --vnc --accelerate -v -c /usr/local/source/hdunkel/debian-502-i386-netinst.iso --os-type=linux --os-variant=debianLenny 14:18:35.586: warning : Cannot set group when not running as root 14:18:35.757: error : Domain not found: no domain with matching name 'Lenny_amd64' libvir: QEMU error : Domain not found: no domain with matching name 'Lenny_amd64' The log file shows [Wed, 05 Aug 2009 14:18:35 virt-install 14229] ERROR (virt-install:786) internal error Failed to add tap interface 'vnet%d' to bridge 'br0' : Operation not permitted Traceback (most recent call last): File "/usr/bin/virt-install", line 780, in <module> main() File "/usr/bin/virt-install", line 678, in main start_time, guest.start_install) File "/usr/bin/virt-install", line 733, in do_install dom = install_func(conscb, progresscb, wait=(not wait)) File "/var/lib/python-support/python2.5/virtinst/Guest.py", line 541, in start_install return self._do_install(consolecb, meter, removeOld, wait) File "/var/lib/python-support/python2.5/virtinst/Guest.py", line 633, in _do_install self.domain = self.conn.createLinux(install_xml, 0) File "/usr/lib/python2.5/site-packages/libvirt.py", line 892, in createLinux if ret is None:raise libvirtError('virDomainCreateLinux() failed', conn=self) libvirtError: internal error Failed to add tap interface 'vnet%d' to bridge 'br0' : Operation not permitted Of course an unprivileged user is not allowed to mess around with the network interfaces, but since it says "internal error" I wonder how this is supposed to work? Is there something misconfigured? Any helpful comments would be highly appreciated Harri

2 1

[libvirt] [PATCH 0/7] QEMU network/bridge backed NIC hotplug
by Mark McLoughlin 05 Aug '09

05 Aug '09

Hey, So, here are the patches needed to complete the QEMU NIC hotplug work by supporting network and bridge backed interfaces. We support this by passing a tap file descriptor to qemu over the monitor socket using SCM_RIGHTS. The monitor commands required for this (getfd and closefd) are queued up in Anthony's queue and should be in qemu-0.11-rc1 which is due to be released very soon: http://repo.or.cz/w/qemu/aliguori-queue.git?a=commitdiff;h=4edd6c2645 http://repo.or.cz/w/qemu/aliguori-queue.git?a=commitdiff;h=f4069061e3 Note: I just remembered I'm not handling missing support for these commands very well. I'll make it handle an 'unknown command' reply gracefully by failing the attach tommorrow. Cheers, Mark.

6 41

[libvirt] Release of libvirt-0.7.0
by Daniel Veillard 05 Aug '09

05 Aug '09

A couple days later than expected, but considering the current flow of fixes, that's not a bad thing. This is a huge release, this includes more than 250 commits in a month and many new functionalities or drivers, and a lot of improvements and bug fixes: New features: - Interface implementation based on netcf (Laine Stump Daniel Veillard) - Add new net filesystem glusterfs (Harshavardhana) - Initial VMWare ESX driver (Matthias Bolte) - Add support for VBox 3 and event callbacks on vbox (Pritesh Kothari) - First version of the Power Hypervisor driver (Eduardo Otubo) - Run QEMU guests as an unprivileged user (Daniel P. Berrange) - Support cgroups in QEMU driver (Daniel P. Berrange) - QEmu hotplug NIC support (Mark McLoughlin) - Storage cloning for LVM and Disk backends(Cole Robinson) - Switching to GIT (Jim Meyering) Documentation: - Typo and comment fixes (Aron Griffis) - Fix virCapabilitiesDefaultGuestMachine documentation. (Chris Lalancette) - ESX Scheduler documentation and cleanup (Matthias Bolte) - Update the java bindings page (Bryan Kearney) - Added Matthias Bolte to AUTHORS list (Daniel Veillard) - doc: clone+build instructions (Jim Meyering) - docs: say that the old repository is deprecated... (Jim Meyering) - document tcp listen and raw wire option (Guido Günther) - Fix docs and code disagreements for character devices. (Cole Robinson) - Fix documentation of virStoragePoolUndefine return (Thomas Treutner) - Fix gitweb link on download page. (Cole Robinson) - update download informations after switch to git (Daniel Veillard) - Update links to bugzilla (Garry Dolley) - Update the links for RHEL libvirt bugzillas (Garry Dolley) Portability: - Xen Inotify support needs sys/inotify.h (Maximilian Wilhelm) - Workaround for broken GCC in Debian Etch (Maximilian Wilhelm) - LXC driver requires sched.h and unshare() (Maximilian Wilhelm) - Configure UML support only if sys/inotify.h present (Maximilian Wilhelm) - Fix libcurl automatic check and ESX status (Maximilian Wilhelm) - Enable ESX driver build on Mingw32 (Daniel P. Berrange) - Fix build on mingw32 by disabling netcf (Daniel P. Berrange) - Reduce glusterfs dependency to 2.0.1 (Mark McLoughlin) - Desactivate phyp build and indicate libssh builreq (Daniel Veillard) - Fix misc Win32 compile warnings (Daniel P. Berrange) - Rename variable for compilation in Mingw32 (end) (Laine Stump) - Rename variable for compilation in Mingw32 (Laine Stump) - rpm spec cleanup and split off client only package (Daniel Veillard) Bug fixes: - Add uniqueness checking for LXC define/create methods (Daniel P. Berrange) - Fix removal of transient VMs when LXC aborts (Daniel P. Berrange) - Don't try to activate cgroups if not present for LXC (Daniel P. Berrange) - Refresh /etc/xen if inotify wasn't (Cole Robinson) - Don't loose id on xen domain redefine (Cole Robinson) - Fix memory leak in openvz driver (Daniel P. Berrange) - Protected against potential crash scenarios (Daniel P. Berrange) - Fix crash when attempting to shutdown inactive QEMU vm (Daniel P. Berrange) - Fix PCIe FLR detection (Mark McLoughlin) - Set perms on /var/lib/libvirt/images to 0711 (Mark McLoughlin) - Fix problem writing QEMU pidfile (Daniel P. Berrange) - Fix vcpupin on Xen problem (Henrik Persson) - Fix RPM upgrades from F11 to F12 (Daniel P. Berrange) - Fix deadlock in remote driver domain events (Daniel P. Berrange) - qemu: fix monitor socket reconnection (Ryota Ozaki) - Fix polkit/netcf disabling on older fedoras (Mark McLoughlin) - Fix crashes in Xen capabilities code (Daniel P. Berrange) - Always add -no-kvm and -no-kqemu, for qemu domains (Jim Paris) - Avoid raising an internal error (Paolo Bonzini) - Don't allow NULL paths for BlockStats and InterfaceStats (Cole Robinson) - Don't leak vm->monitorpath on re-connect (Mark McLoughlin) - Don't restore labels on shared/readonly disks (Daniel P. Berrange) - Ensure spawned children have a stderr/out set to /dev/null if requested (Daniel P. Berrange) - Ensure test:/// URIs get routed to the non-privileged libvirtd (Daniel P. Berrange) - fix another failing "make distcheck" (qemuhelptest) (Jim Meyering) - Fix an uninitialized variable in Unix socket open (Jun Koi) - Fix configure flags in spec file (Daniel Veillard) - Fix error reporting for security driver over remote protocol (Daniel P. Berrange) - fix failing "make distcheck" (Jim Meyering) - Fix free of unitialized data upon PCI open fail (Daniel P. Berrange) - Fix informations about previous git server (Daniel Veillard) - Fix memory leaks in esxDomainDumpXML (Matthias Bolte) - Fix multiple memory leaks in virsh (Laine Stump) - Fix PCI device hotplug/unplug with newer QEMU (Daniel P. Berrange) - Fix problem with QEMU monitor welcome prompt confusing libvirt after a libvirtd daemon restart with active guests (Daniel P. Berrange) - Fix python examples to use read-write conn (Dan Kenigsberg) - Fix reconnect bug for VBox (Pritesh Kothari) - Fix SELinux denial during hotplug (Daniel P. Berrange) - Fix typo in check for glusterfs format pools (Daniel P. Berrange) - Fix typo in storage cloning (Daniel P. Berrange) - qemu: Check driver is initialized up front, to avoid segfault. (Cole Robinson) - qemu: Try multiple times to open unix monitor socket (Cole Robinson) - Release conn lock before reporting errors (end) (Laine Stump) - Release conn lock before reporting interface errors (Laine Stump) - Remove the network backend if NIC hotplug fails (Mark McLoughlin) - Set specific flags for glusterfs fs mounts (Harshavardhana) - storage: disk: Default to 'ext2' for new volumes. (Cole Robinson) - storage: disk: Fix parthelper '-g' option handling. (Cole Robinson) - storage: disk: Fix segfault creating volume without target path (Cole Robinson) - storage: Fix deadlock when cloning across pools. (Cole Robinson) - Update modified mac address in place in virGetInterface (Laine Stump) Improvements: - Add an allocation unit when calling qemu-img (Ryota Ozaki) - Improve diagnostics when pidfile writing fails (Daniel P. Berrange) - Disable IPv6 on virtual networks (Daniel P. Berrange) - Allow dnsmasq to provide DNS without DHCP (Daniel P. Berrange) - Fix an initialization problem in previous patch (Aron Griffis) - Remove MAX_TAP_ID and let kernel do numbering (Aron Griffis) - Kernel command line support for UML (Ron Yorston) - Activate the interface drivers, and cleanups (Daniel Veillard) - Add an error code for conflicting mac addresses (Laine Stump) - Add a test interface driver (Laine Stump) - Add canonical machine name to capabilities output (Mark McLoughlin) - add cd and pwd commands to virsh (Paolo Bonzini) - Add checks for some NIC hotplug related features added in qemu-0.10.0 (Mark McLoughlin) - Add domain autostart for LXC driver (Daniel P. Berrange) - Add domain events support to LXC driver (Daniel P. Berrange) - Add interface object list manipulation functions (Laine Stump) - Add internal XML parsing/formatting flag (Mark McLoughlin) - Add netcf XML schemas and test data (Daniel Veillard) - Add new net filesystem glusterfs (Harshavardhana) - Add NIC and hostnet names to domain state XML (Mark McLoughlin) - Add no_verify query parameter to ESX URIs (Matthias Bolte) - Add SCM_RIGHTS support to QEMU monitor code (Mark McLoughlin) - Add support for attaching network/bridge NICs in QEMU driver (Mark McLoughlin) - add support for netcf XML import and export (Daniel Veillard) - Add support for network device detach (Mark McLoughlin) - Add support for physical memory access for QEmu (Nguyen Anh Quynh) - Add support for VBox 3 and event callbacks on vbox (Pritesh Kothari) - Add the monitor type to the domain state XML (Mark McLoughlin) - Add virCapsGuestMachine structure (Mark McLoughlin) - Add virsh commands for network interface management (Laine Stump) - Allow autostart of libvirtd to be disabled with LIBVIRT_AUTOSTART=0 (Daniel P. Berrange) - Allow leading dots in VMX config entry names (Matthias Bolte) - Assign names to qemu NICs and network backends (Mark McLoughlin) - Basic qemu NIC hotplug support (Mark McLoughlin) - build: adjust aclocal's search patch to prefer gnulib's m4 files. (Jim Meyering) - build: automatically rerun ./bootstrap when needed (Jim Meyering) - build: make autogen.sh use autoreconf -if (Jim Meyering) - build: submodule machinery now works also when no tag is reachable (Jim Meyering) - Canonicalize qemu machine types (Mark McLoughlin) - Change code generator to give async event messages their own postfix (Daniel P. Berrange) - Change the way client event loop watches are managed (Daniel P. Berrange) - Decode incoming request header before invoking dispatch code (Daniel P. Berrange) - Define an API for registering incoming message dispatch filters (Daniel P. Berrange) - ESX driver accept VI API version 4.0 (Matthias Bolte) - Fill in vCPU <-> pCPU current mapping, and vCPU cpuTime for QEMU (Daniel P. Berrange) - generate ChangeLog from git logs into distribution tarball (Jim Meyering) - Implement qemu dump capabilities (Paolo Bonzini) - Implement schedular tunables API using cgroups (Daniel P. Berrange) - Implement the new virinterface functions (Laine Stump) - Make cgroups a little more efficient (Daniel P. Berrange) - Make it easier to debug tests running programs (Daniel P. Berrange) - Make qemuBuildHostNetStr() take tapfd as a string (Mark McLoughlin) - Make QEMU cgroups use configurable (Daniel P. Berrange) - Make qemuCmdFlags available in qemudDomainAttachDevice() (Mark McLoughlin) - Move queuing of RPC replies into dispatch code (Daniel P. Berrange) - Move vnet_hdr logic into qemudNetworkIfaceConnect() and export it (Mark McLoughlin) - Netcf based interface driver implementation (Laine Stump) - netcf XML validation and input and output tests (Daniel Veillard) - Only probe qemu for machine types when binary changes (Mark McLoughlin) - Place every QEMU guest in a private cgroup (Daniel P. Berrange) - Probe for QEMU machine types (Mark McLoughlin) - Probe QEMU directly for machine aliases if not found in capabilties (Mark McLoughlin) - Public API for new virInterface functions (Laine Stump) - python: Raise exceptions if virDomain*Stats fail. (Cole Robinson) - Refactor cgroups to allow a group per driver to be managed directly (Daniel P. Berrange) - Re-factor pci_add reply parsing and parse domain/bus numbers (Mark McLoughlin) - Retain disk PCI address across libvirtd restarts (Mark McLoughlin) - Retain PCI address from NIC attach (Mark McLoughlin) - Run QEMU guests as an unprivileged user (Daniel P. Berrange) - Separate code for encoding outgoing remote message headers (Daniel P. Berrange) - Split generic RPC message dispatch code out from remote protocol API handlers (Daniel P. Berrange) - Split out code for handling incoming method call messages (Daniel P. Berrange) - storage: Break out actual raw cloning to separate function. (Cole Robinson) - storage: cleanup: do away with 'createFile' (Cole Robinson) - storage: disk: Use capacity, not allocation, when creating volume. (Cole Robinson) - storage: Don't try sparse detection if writing to block device. (Cole Robinson) - storage: Implement 'CreateBlockFrom' helper. (Cole Robinson) - storage: Implement CreateVolFrom for logical and disk backend. (Cole Robinson) - storage: Move most of the FS creation functions to common backend. (Cole Robinson) - storage: Refactor FS backend 'create' function choosing. (Cole Robinson) - Store the interface vlan number in the domain state (Mark McLoughlin) - Support <video> element for QEMU guests (Daniel P. Berrange) - Support <video> tag for defining VGA card properties (Daniel P. Berrange) - Switch to using a unix socket for the qemu monitor (Mark McLoughlin) - test: Generate net interface names when assigning XML. (Cole Robinson) - test: Implement BlockStats and InterfaceStats (Cole Robinson) - Use cgroups for block device whitelisting in QEMU guests (Daniel P. Berrange) - Use enums for cgroup controller types / labels (Daniel P. Berrange) - Use sendmsg() on QEMU monitor socket (Mark McLoughlin) - Use virDomainChrTypeFromString() instead of open coding (Mark McLoughlin) - Use virFileReadAll/virFileWriteStr for key cgroup read/write helpers (Daniel P. Berrange) - virGetinterface matching of MAC and interface name (Laine Stump) Cleanups: - Fix configure checks from previous commits (Daniel P. Berrange) - Avoid a warning if compiling without inotify (Daniel P. Berrange) - Remove a stray semicolon (Daniel Veillard) - Extend the ESX URL to habdle ports and GSX (Matthias Bolte) - Fix escaping of 8-bit high characters (Daniel P. Berrange) - Remove ATTRIBUTE_UNUSED from flags to qemudDomainMigratePerform. (Chris Lalancette) - Add a comment about setting errors after qemudStartVMDaemon(). (Chris Lalancette) - Fix an erroneous debug error to KVM; it should read QEMU/KVM. (Chris Lalancette) - Remove a stray semicolon in qemudDomainMigratePrepare2. (Chris Lalancette) - Convert a few stray users of free() in libvirt.c to VIR_FREE(). (Chris Lalancette) - Use virGetHostname instead of gethostname. (Chris Lalancette) - Fix up a minor indentation issue with virDomainMigratePrepare. (Chris Lalancette) - Fix up a silly typo in apibuild.py. (Chris Lalancette) - Avoid warning when compiling without IFF_VNET_HDR (Maximilian Wilhelm) - Capilize libvirt-client summary (Mark McLoughlin) - Move ldconfig calls to libvirt-client %post/%postun (Mark McLoughlin) - Convert NEWS to UTF-8 (Mark McLoughlin) - Fix trailing whitespace in NEWS (Mark McLoughlin) - No need to build require both python-devel and python (Mark McLoughlin) - Remove executable perms from /etc/sysconfig/libvirtd (Mark McLoughlin) - Use a %postun -p for one line scriptlet (Mark McLoughlin) - Don't explicitly require libxml2 (Mark McLoughlin) - Fix some unowned directories (Mark McLoughlin) - Kill qemu BuildRequires (Mark McLoughlin) - Enable netcf by default (Mark McLoughlin) - Default to with_polkit (Mark McLoughlin) - Make vbox support configurable (Mark McLoughlin) - Build with --without-capng if capng is disabled (Mark McLoughlin) - BuildRequires libcap-ng-devel not capng-devel (Mark McLoughlin) - Drop curl host check when using ESX without check (Shahar Klein) - Fix typo in xen capabilities code (Daniel P. Berrange) - Add bare format string to printf-derivatives troubles (Laine Stump) - Add phyp files to POTFILES, to make syntax-check happy. (Cole Robinson) - avoid a make distcheck failure: distribute docs/schemas/interface.rng (Jim Meyering) - avoid a make distcheck failure: distribute tests/interfaceschemadata/ (Jim Meyering) - avoid a "make syntax-check" failure (Jim Meyering) - build: do not emit a trailing blank line into VC'd file, NEWS (Jim Meyering) - build: update from gnulib, for latest maint.mk (Jim Meyering) - Clean up error handling in qemudDomainAttachNetDevice() (Mark McLoughlin) - Cleanup qemu binary detection logic in qemudCapsInitGuest() (Mark McLoughlin) - Commit newly generated docs, after changes from commit 2348cf. (Cole Robinson) - Factor qemuBuildHostNetStr() out from qemuBuildCommandLine() (Mark McLoughlin) - Factor qemuBuildNicStr() out from qemuBuildCommandLine() (Mark McLoughlin) - Factor qemudMonitorSend() out of qemudMonitorCommandExtra() (Mark McLoughlin) - Fix cgroup compile warnings (Daniel P. Berrange) - Fix misc build problems due to new drivers (Daniel P. Berrange) - Fix wierd build problems due to autopoint overwriting gnulib m4 (Daniel P. Berrange) - Makefile.cfg: Rename to... (Jim Meyering) - make .gnulib a submodule (Jim Meyering) - make "make syntax-check" consistent with "git diff --check" (Jim Meyering) - Minor qemu monitor coding style fixes (Mark McLoughlin) - Prepare to use maint.mk from gnulib (Jim Meyering) - Refactor incoming message handling to prepare for data stream support (Daniel P. Berrange) - Refactor message sending to allow code reuse for data streams (Daniel P. Berrange) - remove all .cvsignore files (Jim Meyering) - remove all trailing blank lines (Jim Meyering) - Remove some unused variables and cut long lines (Daniel Veillard) - Remove trailing blank lines (Daniel Veillard) - Rename a bunch of internal methods to clarify their meaning (Daniel P. Berrange) - Rename 'direction' to 'type' in remote_message_header (Daniel P. Berrange) - Report the object name on lookup error (Daniel Veillard) - Simplify remote driver error reporting (Daniel P. Berrange) - skip some of gnulib's new rules (Jim Meyering) - use automake-1.11's silent-rules option, when possible (Jim Meyering) - use gnumakefile and maintainer-makefile modules from gnulib (Jim Meyering) It's also good to see a lot of new contributors in this release, so thanks to everybody ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] address incompatible change of qemu-img
by Ryota Ozaki 05 Aug '09

05 Aug '09

Hi, Latest qemu-img (maybe from 0.11.0-rc0 or later?) changes default unit of size as bytes, it was kilo-bytes so far. (see http://www.mail-archive.com/kvm@vger.kernel.org/msg19183.html) This patch addresses this incompatibility by adding postfix 'K'. This fix is able to keep backward compatibility for old qemu as well, and also even if qemu-img falls back old style or any, this explicit specifying should work well. Thanks, ozaki-r >From 7d3dd9e592deab5a1d793532cf230d8367372280 Mon Sep 17 00:00:00 2001 From: Ryota Ozaki <ozaki.ryota(a)gmail.com> Date: Tue, 4 Aug 2009 11:11:31 +0900 Subject: [PATCH] address incompatible change of qemu-img --- src/storage_backend.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/storage_backend.c b/src/storage_backend.c index 07a2e48..8824218 100644 --- a/src/storage_backend.c +++ b/src/storage_backend.c @@ -446,7 +446,7 @@ virStorageBackendCreateQemuImg(virConnectPtr conn, /* Size in KB */ - snprintf(size, sizeof(size), "%llu", vol->capacity/1024); + snprintf(size, sizeof(size), "%lluK", vol->capacity/1024); if (virRun(conn, imgargv, NULL) < 0) { VIR_FREE(imgargv[0]); -- 1.6.0.6

2 1

[libvirt] [PATCH] Support the usage of socat instead of netcat
by Jonas Eriksson 05 Aug '09

05 Aug '09

Some netcat implementations does not support unix domain sockets (-U). Distros that ship these implementations often also ships socat, that do support this. This is a reworked patch based on the openSUSE libvirt package. The original patch may be found in this source rpm: http://download.opensuse.org/source/distribution/11.1/repo/oss/suse/src/lib… * configure.in: Check for --with-socat and set USE_SOCAT in config.h * src/remote_internal.c: Honour USE_SOCAT by selecting between netcat/nc and socat at compile time. --- configure.in | 7 +++++++ src/remote_internal.c | 13 +++++++++++++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/configure.in b/configure.in index b905b23..732ef68 100644 --- a/configure.in +++ b/configure.in @@ -153,6 +153,13 @@ if test -n "$MODPROBE"; then [Location or name of the modprobe program]) fi +dnl Check if socat should be used instead of netcat +AC_ARG_WITH([socat], +[ --with-socat use socat instead of netcat (off)]) +if test "$with_socat" = "yes" ; then + AC_DEFINE_UNQUOTED([USE_SOCAT], 1, [whether socat should be used instead of netcat]) +fi + dnl Specific dir for HTML output ? AC_ARG_WITH([html-dir], [AC_HELP_STRING([--with-html-dir=path], [path to base html directory, default $datadir/doc/html])], diff --git a/src/remote_internal.c b/src/remote_internal.c index a58b768..7678317 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -725,6 +725,18 @@ doRemoteOpen (virConnectPtr conn, cmd_argv[j++] = strdup ("-e"); cmd_argv[j++] = strdup ("none"); } +#ifdef USE_SOCAT + cmd_argv[j++] = strdup ("socat"); + cmd_argv[j++] = strdup ("-"); + + char *socat_addr = 0; + if ((asprintf (&socat_addr, "GOPEN:%s", + sockname ? sockname : LIBVIRTD_PRIV_UNIX_SOCKET)) < 0) { + error (conn, VIR_ERR_SYSTEM_ERROR, strerror (ENOMEM)); + goto failed; + } + cmd_argv[j++] = socat_addr; +#else cmd_argv[j++] = strdup (priv->hostname); cmd_argv[j++] = strdup (netcat ? netcat : "nc"); cmd_argv[j++] = strdup ("-U"); @@ -732,6 +744,7 @@ doRemoteOpen (virConnectPtr conn, (flags & VIR_CONNECT_RO ? LIBVIRTD_PRIV_UNIX_SOCKET_RO : LIBVIRTD_PRIV_UNIX_SOCKET)); +#endif cmd_argv[j++] = 0; assert (j == nr_args); for (j = 0; j < (nr_args-1); j++) -- 1.6.2

1 1

[libvirt] PATCH: Add name uniqueness checking to LXC driver
by Daniel P. Berrange 05 Aug '09

05 Aug '09

The LXC driver define/create methods didn't yet have name uniqueness checking enabled Daniel commit 4b23a44f34392b5c6d1c5aa483cbe81b010e47c4 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Fri Jul 31 15:25:03 2009 +0100 Add uniqness checking for LXC define/create methods * src/lxc_driver.c: Check for name & UUID uniqueness when defining or creating domains diff --git a/src/lxc_driver.c b/src/lxc_driver.c index d62c2d7..a9c4f79 100644 --- a/src/lxc_driver.c +++ b/src/lxc_driver.c @@ -311,6 +311,35 @@ static virDomainPtr lxcDomainDefine(virConnectPtr conn, const char *xml) VIR_DOMAIN_XML_INACTIVE))) goto cleanup; + /* See if a VM with matching UUID already exists */ + vm = virDomainFindByUUID(&driver->domains, def->uuid); + if (vm) { + /* UUID matches, but if names don't match, refuse it */ + if (STRNEQ(vm->def->name, def->name)) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + lxcError(conn, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + vm->def->name, uuidstr); + goto cleanup; + } + + /* UUID & name match */ + virDomainObjUnlock(vm); + newVM = 0; + } else { + /* UUID does not match, but if a name matches, refuse it */ + vm = virDomainFindByName(&driver->domains, def->name); + if (vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + lxcError(conn, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + def->name, uuidstr); + goto cleanup; + } + } + if ((def->nets != NULL) && !(driver->have_netns)) { lxcError(conn, NULL, VIR_ERR_NO_SUPPORT, "%s", _("System lacks NETNS support")); @@ -1082,6 +1111,39 @@ lxcDomainCreateAndStart(virConnectPtr conn, VIR_DOMAIN_XML_INACTIVE))) goto cleanup; + /* See if a VM with matching UUID already exists */ + vm = virDomainFindByUUID(&driver->domains, def->uuid); + if (vm) { + /* UUID matches, but if names don't match, refuse it */ + if (STRNEQ(vm->def->name, def->name)) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + lxcError(conn, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + vm->def->name, uuidstr); + goto cleanup; + } + + /* UUID & name match, but if VM is already active, refuse it */ + if (virDomainIsActive(vm)) { + lxcError(conn, NULL, VIR_ERR_OPERATION_FAILED, + _("domain is already active as '%s'"), vm->def->name); + goto cleanup; + } + virDomainObjUnlock(vm); + } else { + /* UUID does not match, but if a name matches, refuse it */ + vm = virDomainFindByName(&driver->domains, def->name); + if (vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(vm->def->uuid, uuidstr); + lxcError(conn, NULL, VIR_ERR_OPERATION_FAILED, + _("domain '%s' is already defined with uuid %s"), + def->name, uuidstr); + goto cleanup; + } + } + if ((def->nets != NULL) && !(driver->have_netns)) { lxcError(conn, NULL, VIR_ERR_NO_SUPPORT, "%s", _("System lacks NETNS support")); -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] PATCH: Fix cleanup of transient VMs
by Daniel P. Berrange 05 Aug '09

05 Aug '09

If a transient VM quit unexpectedly it would never be cleaned up, resulting in a guest that's impossible to remove Daniel commit 7781032c3d870f5c9dacfc02baecc151689d9c57 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Fri Jul 31 14:38:46 2009 +0100 Fix removal of transient VMs when LXC aborts * src/lxc_driver.c: Remove transient VM after monitor triggered shutdown diff --git a/src/lxc_driver.c b/src/lxc_driver.c index f37fc5d..d62c2d7 100644 --- a/src/lxc_driver.c +++ b/src/lxc_driver.c @@ -774,6 +774,10 @@ static void lxcMonitorEvent(int watch, VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN); } + if (!vm->persistent) { + virDomainRemoveInactive(&driver->domains, vm); + vm = NULL; + } cleanup: if (vm) -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] PATCH: Fix startup of LXC vms without cgroups
by Daniel P. Berrange 05 Aug '09

05 Aug '09

If cgroups was not mounted at all, LXC would fail to start any VM, since we missed an error code check Daniel commit 8713c7e8111e73879f8380b920995ff3d1f3f9e9 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Fri Jul 31 14:37:25 2009 +0100 Don't try to activate cgroups if not present for LXC * src/lxc_controller.c: Don't throw error in LXC startup if the cgroups driver mount isn't available. Improve error logging for resource setup diff --git a/src/lxc_controller.c b/src/lxc_controller.c index 9ad48a7..8d11238 100644 --- a/src/lxc_controller.c +++ b/src/lxc_controller.c @@ -84,25 +84,38 @@ static int lxcSetContainerResources(virDomainDefPtr def) rc = virCgroupForDriver("lxc", &driver, 1, 0); if (rc != 0) { - lxcError(NULL, NULL, VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to get cgroup for driver")); + /* Skip all if no driver cgroup is configured */ + if (rc == -ENXIO || rc == -ENOENT) + return 0; + + virReportSystemError(NULL, -rc, "%s", + _("Unable to get cgroup for driver")); return rc; } rc = virCgroupForDomain(driver, def->name, &cgroup, 1); if (rc != 0) { - lxcError(NULL, NULL, VIR_ERR_INTERNAL_ERROR, - _("Unable to create cgroup for domain %s"), def->name); + virReportSystemError(NULL, -rc, + _("Unable to create cgroup for domain %s"), + def->name); goto cleanup; } rc = virCgroupSetMemory(cgroup, def->maxmem); - if (rc != 0) - goto out; + if (rc != 0) { + virReportSystemError(NULL, -rc, + _("Unable to set memory limit for domain %s"), + def->name); + goto cleanup; + } rc = virCgroupDenyAllDevices(cgroup); - if (rc != 0) - goto out; + if (rc != 0) { + virReportSystemError(NULL, -rc, + _("Unable to deny devices for domain %s"), + def->name); + goto cleanup; + } for (i = 0; devices[i].type != 0; i++) { struct cgroup_device_policy *dev = &devices[i]; @@ -110,19 +123,27 @@ static int lxcSetContainerResources(virDomainDefPtr def) dev->type, dev->major, dev->minor); - if (rc != 0) - goto out; + if (rc != 0) { + virReportSystemError(NULL, -rc, + _("Unable to allow device %c:%d:%d for domain %s"), + dev->type, dev->major, dev->minor, def->name); + goto cleanup; + } } rc = virCgroupAllowDeviceMajor(cgroup, 'c', LXC_DEV_MAJ_PTY); - if (rc != 0) - goto out; + if (rc != 0) { + virReportSystemError(NULL, -rc, + _("Unable to allow PYT devices for domain %s"), + def->name); + goto cleanup; + } rc = virCgroupAddTask(cgroup, getpid()); -out: if (rc != 0) { - virReportSystemError(NULL, -rc, "%s", - _("Failed to set lxc resources")); + virReportSystemError(NULL, -rc, + _("Unable to add task %d to cgroup for domain %s"), + getpid(), def->name); } cleanup: -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH] Refresh /etc/xen if inotify wasn't initialized
by Cole Robinson 05 Aug '09

05 Aug '09

If libvirt was built against inotify, but an API user isn't using domain events (virsh, virt-manager), the xen xm driver doesn't poll /etc/xen for new config files. This means that domains created or deleted on other libvirt connections aren't reflected in the original connection (but they will show up for all newly opened connections). This causes newly created VMs to disappear from virt-manager < 0.8.0 once they are shutdown, since VMs were installed on a separate connection. The attached patch refreshes /etc/xen in all cases, unless inotify was successfully initialized (user is using domain events). Thanks, Cole

3 3

[libvirt] [PATCH] Allow libvirtd to RPC to external libvirtd.
by Chris Lalancette 05 Aug '09

05 Aug '09

Allow the daemon itself to make RPCs to an external libvirtd, but only if the URI is fully specified. While this isn't used at the moment, it will be for the tunnelled migration support in the future. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/remote_internal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index ad0cbf0..ff4fb6c 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -997,7 +997,7 @@ remoteOpen (virConnectPtr conn, int ret, rflags = 0; const char *autostart = getenv("LIBVIRT_AUTOSTART"); - if (inside_daemon) + if (inside_daemon && (!conn->uri || (conn->uri && !conn->uri->server))) return VIR_DRV_OPEN_DECLINED; if (!(priv = remoteAllocPrivateData(conn))) -- 1.6.0.6

3 3

[libvirt] [PATCH] rng comment fixes
by Aron Griffis 05 Aug '09

05 Aug '09

--- docs/schemas/capability.rng | 3 +-- docs/schemas/nodedev.rng | 4 ---- docs/schemas/storagepool.rng | 3 +-- docs/schemas/storagevol.rng | 3 +-- 4 files changed, 3 insertions(+), 10 deletions(-) diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng index 775bbdb..1e3c5f3 100644 --- a/docs/schemas/capability.rng +++ b/docs/schemas/capability.rng @@ -1,7 +1,6 @@ - + <grammar xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> -  <start> <ref name='capabilities'/> </start> diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng index 78bd6a8..7060274 100644 --- a/docs/schemas/nodedev.rng +++ b/docs/schemas/nodedev.rng @@ -1,14 +1,10 @@  <grammar xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> -  <start> <ref name='device'/> </start> -  <define name='device'> <element name="device">  + <grammar xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> -  <start> <ref name='pool'/> </start> diff --git a/docs/schemas/storagevol.rng b/docs/schemas/storagevol.rng index 7dc7876..5b0b038 100644 --- a/docs/schemas/storagevol.rng +++ b/docs/schemas/storagevol.rng @@ -1,7 +1,6 @@ - + <grammar xmlns="http://relaxng.org/ns/structure/1.0" datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"> -  <start> <ref name='vol'/> </start>

2 1

[libvirt] openvzGetType() leaks memory
by Matthias Bolte 05 Aug '09

05 Aug '09

All other drivers return a static string from their getType() function (conforming with the API documentation), but the OpenVZ driver does strdup() a string, generating a leak: static const char *openvzGetType(virConnectPtr conn ATTRIBUTE_UNUSED) { return strdup("OpenVZ"); } Matthias

2 1

[libvirt] [PATCH] Don't clobber ID when redefining dom in xm driver
by Cole Robinson 05 Aug '09

05 Aug '09

If redefining a domain in the xen xm driver, we unconditionally set the domain ID to -1. This can make a running domain appear inactive, and really confuse things. Just drop the offending code, since virGetDomain already sets the ID to -1 if required. Fix pointed out by Dan Berrange, more info can be found at https://bugzilla.redhat.com/show_bug.cgi?id=508278 Thanks, Cole

3 2

[libvirt] [PATCH] Fix latent buffer overflow in qemudOpenMonitorUnix.
by Chris Lalancette 05 Aug '09

05 Aug '09

Fix a possible latent bug in qemudOpenMonitorUnix(). If the pathname to the monitor is very long (i.e. >= UNIX_MAX_PATH), then strncpy will *not* place a final \0 on the string (see "man strncpy"). NULL terminate the buffer to ensure we don't run off the end. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/qemu_driver.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 9fcc07a..4f173b7 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -910,6 +910,7 @@ qemudOpenMonitorUnix(virConnectPtr conn, memset(&addr, 0, sizeof(addr)); addr.sun_family = AF_UNIX; strncpy(addr.sun_path, monitor, sizeof(addr.sun_path)); + NUL_TERMINATE(addr.sun_path); do { ret = connect(monfd, (struct sockaddr *) &addr, sizeof(addr)); -- 1.6.0.6

4 5

[libvirt] [PATCH] Remove a stray semicolon in qemudDomainMigratePrepare2.
by Chris Lalancette 05 Aug '09

05 Aug '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/qemu_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 83cbcf3..5f4b28b 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -6274,7 +6274,7 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn, char migrateFrom [64]; const char *p; virDomainEventPtr event = NULL; - int ret = -1;; + int ret = -1; int internalret; *uri_out = NULL; -- 1.6.0.6

3 3

[libvirt] [PATCH] Workaround for broken GCC in Debian Etch
by Maximilian Wilhelm 05 Aug '09

05 Aug '09

Hi again! I missed one patch for working around a GCC bug in Debian Etch regarding limit definitions. Sorry for the unstripped git-format-patch outputs, I just realised this after pressing send :( (This seems to be not my day :)) Ciao Max -- Gib Dein Bestes. Dann übertriff Dich selbst!

3 4

[libvirt] [PATCH] Add some automatic dependency checks for configure to enable/disable {ESX, UML, LXC, Xen-Inotify}
by Maximilian Wilhelm 05 Aug '09

05 Aug '09

Hi! While building libVirt on an older Debian Etch machine, I stumbled across some automatic enabled drivers which stopped configure and make very badly due to missing header files, old libraries and stuff. So I decided to improve the automagic tests so others won't face the same problem again :) Find four patches attached. Ciao Max -- Fortschritt bedeutet, einen Schritt so zu machen, daß man den nächsten auch noch machen kann.

3 2

Re: [libvirt] VMware support and Server 2.0.1
by Matthias Bolte 05 Aug '09

05 Aug '09

2009/7/30 Timo Makinen <tmakinen(a)ee.oulu.fi>: > On Thu, Jul 30, 2009 at 03:22:59AM +0200, Matthias Bolte wrote: >> 2009/7/29 Timo Makinen <tmakinen(a)ee.oulu.fi>: >> > On Wed, Jul 29, 2009 at 06:12:59PM +0200, Matthias Bolte wrote: >> >> 2009/7/27 Timo Makinen <tmakinen(a)ee.oulu.fi>: >> >> Could you do some basic testing beside listing and dumpxml, as I have >> >> currently no VMware GSX installation at hand? Just test if the >> >> following commands work as expected in virsh: >> >> >> >> - start >> >> - shutdown >> >> - reboot >> >> - suspend >> >> - resume >> >> - nodeinfo >> >> - dominfo >> >> >> >> Regards, >> >> Matthias >> > >> > All these worked out of the box. >> >> Nice! >> >> Could you test the attached patch? It adds handling for the port in >> the URI, extends the version checking for GSX 2.0 and fixes the bug in >> VMX parsing. >> >> Matthias > > Works like a charm now. :) > > - Timo > Fine! The attached second GSX patch adds a gsx:// scheme to the ESX driver, so you can connect to a GSX host using virsh -c gsx://host and the driver will select the port automatically dependent on the scheme and transport. Here gsx scheme and default transport https result in port 8333. Matthias

3 2

[libvirt] [PATCH] spelling fix
by Aron Griffis 04 Aug '09

04 Aug '09

--- src/qemu_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index 4fe4e39..6b0b404 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -1970,7 +1970,7 @@ int qemudBuildCommandLine(virConnectPtr conn, if (def->nvideos) { if (def->nvideos > 1) { qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, - "%s", _("only one video card is currentely supported")); + "%s", _("only one video card is currently supported")); goto error; }

1 0

[libvirt] PATCH: Fix escaping for 8-bit high characters
by Daniel P. Berrange 04 Aug '09

04 Aug '09

The virBufferEscapeString method has a broken test *cur > 0x20 which causes all 8-bit high characters to be lost as 'cur' is a signed char. This obviously dooms anyone using UTF-8 characters outside the boring old ASCII-7 range, like this guy https://bugzilla.redhat.com/show_bug.cgi?id=479517 Daniel diff --git a/src/buf.c b/src/buf.c index 259175d..c802aa2 100644 --- a/src/buf.c +++ b/src/buf.c @@ -304,7 +304,7 @@ virBufferEscapeString(const virBufferPtr buf, const char *format, const char *st *out++ = 'o'; *out++ = 's'; *out++ = ';'; - } else if ((*cur >= 0x20) || (*cur == '\n') || (*cur == '\t') || + } else if (((unsigned char)*cur >= 0x20) || (*cur == '\n') || (*cur == '\t') || (*cur == '\r')) { /* * default case, just copy ! -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH] Remove ATTRIBUTE_UNUSED from flags to qemudDomainMigratePerform.
by Chris Lalancette 02 Aug '09

02 Aug '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/qemu_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index eadb53f..9fcc07a 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -6424,7 +6424,7 @@ qemudDomainMigratePerform (virDomainPtr dom, const char *cookie ATTRIBUTE_UNUSED, int cookielen ATTRIBUTE_UNUSED, const char *uri, - unsigned long flags ATTRIBUTE_UNUSED, + unsigned long flags, const char *dname ATTRIBUTE_UNUSED, unsigned long resource) { -- 1.6.0.6

2 2

[libvirt] [PATCH] Add a comment about setting errors after qemudStartVMDaemon().
by Chris Lalancette 02 Aug '09

02 Aug '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/qemu_driver.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index fcfbfbc..eadb53f 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -6390,6 +6390,9 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn, */ snprintf (migrateFrom, sizeof (migrateFrom), "tcp:0.0.0.0:%d", this_port); if (qemudStartVMDaemon (dconn, driver, vm, migrateFrom, -1) < 0) { + /* Note that we don't set an error here because qemudStartVMDaemon + * should have already done that. + */ if (!vm->persistent) { virDomainRemoveInactive(&driver->domains, vm); vm = NULL; -- 1.6.0.6

2 2

[libvirt] [PATCH] Fix an erroneous debug error to KVM; it should read QEMU/KVM.
by Chris Lalancette 02 Aug '09

02 Aug '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/qemu_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 5f4b28b..fcfbfbc 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -6321,7 +6321,7 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn, */ if (!STRPREFIX (uri_in, "tcp:")) { qemudReportError (dconn, NULL, NULL, VIR_ERR_INVALID_ARG, - "%s", _("only tcp URIs are supported for KVM migrations")); + "%s", _("only tcp URIs are supported for KVM/QEMU migrations")); goto cleanup; } -- 1.6.0.6

2 2

[libvirt] [PATCH] Convert a few stray users of free() in libvirt.c to VIR_FREE().
by Chris Lalancette 02 Aug '09

02 Aug '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/libvirt.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 167359f..9fd864d 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3020,7 +3020,7 @@ virDomainMigrate (virDomainPtr domain, ret = dconn->driver->domainMigratePrepare2 (dconn, &cookie, &cookielen, uri, &uri_out, flags, dname, bandwidth, dom_xml); - free (dom_xml); + VIR_FREE (dom_xml); if (ret == -1) goto done; if (uri == NULL && uri_out == NULL) { virLibConnError (conn, VIR_ERR_INTERNAL_ERROR, @@ -3062,8 +3062,8 @@ virDomainMigrate (virDomainPtr domain, } done: - free (uri_out); - free (cookie); + VIR_FREE (uri_out); + VIR_FREE (cookie); return ddomain; error: -- 1.6.0.6

2 2

[libvirt] [PATCH] Use virGetHostname instead of gethostname.
by Chris Lalancette 02 Aug '09

02 Aug '09

Fix up qemudDomainMigratePrepare2 to use virGetHostname instead of gethostname. Besides the fact that virGetHostname is far more clever, there was a latent bug in the handling that could cause a buffer overflow on a very long hostname. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/qemu_driver.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index cee2164..83cbcf3 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -6270,11 +6270,12 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn, virDomainDefPtr def = NULL; virDomainObjPtr vm = NULL; int this_port; - char hostname [HOST_NAME_MAX+1]; + char *hostname; char migrateFrom [64]; const char *p; virDomainEventPtr event = NULL; int ret = -1;; + int internalret; *uri_out = NULL; @@ -6300,14 +6301,16 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn, if (port == QEMUD_MIGRATION_NUM_PORTS) port = 0; /* Get hostname */ - if (gethostname (hostname, HOST_NAME_MAX+1) == -1) { + if ((hostname = virGetHostname()) == NULL) { virReportSystemError (dconn, errno, "%s", _("failed to determine host name")); goto cleanup; } /* Caller frees */ - if (virAsprintf(uri_out, "tcp:%s:%d", hostname, this_port) < 0) { + internalret = virAsprintf(uri_out, "tcp:%s:%d", hostname, this_port); + VIR_FREE(hostname); + if (internalret < 0) { virReportOOMError (dconn); goto cleanup; } -- 1.6.0.6

2 2

[libvirt] [PATCH] Fix up a minor indentation issue with virDomainMigratePrepare.
by Chris Lalancette 02 Aug '09

02 Aug '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/libvirt.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 7ecf1ec..167359f 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3078,13 +3078,13 @@ error: */ int virDomainMigratePrepare (virConnectPtr dconn, - char **cookie, - int *cookielen, - const char *uri_in, - char **uri_out, - unsigned long flags, - const char *dname, - unsigned long bandwidth) + char **cookie, + int *cookielen, + const char *uri_in, + char **uri_out, + unsigned long flags, + const char *dname, + unsigned long bandwidth) { VIR_DEBUG("dconn=%p, cookie=%p, cookielen=%p, uri_in=%s, uri_out=%p, " "flags=%lu, dname=%s, bandwidth=%lu", dconn, cookie, cookielen, -- 1.6.0.6

2 2

[libvirt] [PATCH] Fix virCapabilitiesDefaultGuestMachine documentation.
by Chris Lalancette 02 Aug '09

02 Aug '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/capabilities.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/capabilities.c b/src/capabilities.c index d186961..c6766b6 100644 --- a/src/capabilities.c +++ b/src/capabilities.c @@ -567,7 +567,7 @@ virCapabilitiesDefaultGuestMachine(virCapsPtr caps, } /** - * virCapabilitiesDefaultGuestMachine: + * virCapabilitiesDefaultGuestEmulator: * @caps: capabilities to query * @ostype: OS type to search for ('xen', 'hvm') * @arch: architecture to search for -- 1.6.0.6

2 2

[libvirt] [PATCH] Fix up a silly typo in apibuild.py.
by Chris Lalancette 02 Aug '09

02 Aug '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- docs/apibuild.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index 6fec049..84bc1ac 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -39,7 +39,7 @@ ignored_functions = { "virDomainMigratePrepare": "private function for migration", "virDomainMigratePrepare2": "private function for migration", "virDrvSupportsFeature": "private function for remote access", - "DllMain": "specific function fo Win32", + "DllMain": "specific function for Win32", } def escape(raw): -- 1.6.0.6

2 2

[libvirt] PATCH: Fix crash attempting to shutdown inactive QEMU vm
by Daniel P. Berrange 31 Jul '09

31 Jul '09

If the virDomainShutdown() op was run on an active QEMu vm, it would crash, since the def->monitor_chr was NULL. Daniel commit 49ec121fd806aaa07bbcba9668a8f9dd43dda9c4 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Fri Jul 31 15:50:46 2009 +0100 Fix crash when attempting to shutdown inactive QEMU vm * src/qemu_driver.c: Add check that QEMU is active before attemting to shutdown. Fix error code for check in destroy method diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 26897d3..cebbafb 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2940,6 +2940,12 @@ static int qemudDomainShutdown(virDomainPtr dom) { goto cleanup; } + if (!virDomainIsActive(vm)) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto cleanup; + } + if (qemudMonitorCommand(vm, "system_powerdown", &info) < 0) { qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, "%s", _("shutdown operation failed")); @@ -2971,7 +2977,7 @@ static int qemudDomainDestroy(virDomainPtr dom) { goto cleanup; } if (!virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + qemudReportError(dom->conn, dom, NULL, VIR_ERR_OPERATION_INVALID, "%s", _("domain is not running")); goto cleanup; } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH] Split virDomainMigrate into functions.
by Chris Lalancette 31 Jul '09

31 Jul '09

Re-factor virDomainMigrate to split out the version 1 and version 2 protocols into their own functions. In reality, the two versions share very little in common, so forcing them together in the same function was just confusing. This will also make adding tunnelled migration easier. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/libvirt.c | 258 ++++++++++++++++++++++++++++++++++----------------------- 1 files changed, 155 insertions(+), 103 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 9fd864d..dede2b9 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -2874,6 +2874,146 @@ error: } +static virDomainPtr +migrate_version_1 (virDomainPtr domain, + virConnectPtr dconn, + unsigned long flags, + const char *dname, + const char *uri, + unsigned long bandwidth) +{ + virDomainPtr ddomain = NULL; + char *uri_out = NULL; + char *cookie = NULL; + int cookielen = 0; + + /* Prepare the migration. + * + * The destination host may return a cookie, or leave cookie as + * NULL. + * + * The destination host MUST set uri_out if uri_in is NULL. + * + * If uri_in is non-NULL, then the destination host may modify + * the URI by setting uri_out. If it does not wish to modify + * the URI, it should leave uri_out as NULL. + */ + if (dconn->driver->domainMigratePrepare + (dconn, &cookie, &cookielen, uri, &uri_out, flags, dname, + bandwidth) == -1) + goto done; + + if (uri == NULL && uri_out == NULL) { + virLibConnError (domain->conn, VIR_ERR_INTERNAL_ERROR, + _("domainMigratePrepare did not set uri")); + goto done; + } + if (uri_out) + uri = uri_out; /* Did domainMigratePrepare change URI? */ + assert (uri != NULL); + + /* Perform the migration. The driver isn't supposed to return + * until the migration is complete. + */ + if (domain->conn->driver->domainMigratePerform + (domain, cookie, cookielen, uri, flags, dname, bandwidth) == -1) + goto done; + + /* Get the destination domain and return it or error. + * 'domain' no longer actually exists at this point + * (or so we hope), but we still use the object in memory + * in order to get the name. + */ + dname = dname ? dname : domain->name; + if (dconn->driver->domainMigrateFinish) + ddomain = dconn->driver->domainMigrateFinish + (dconn, dname, cookie, cookielen, uri, flags); + else + ddomain = virDomainLookupByName (dconn, dname); + + done: + VIR_FREE (uri_out); + VIR_FREE (cookie); + return ddomain; +} + +static virDomainPtr +migrate_version_2 (virDomainPtr domain, + virConnectPtr dconn, + unsigned long flags, + const char *dname, + const char *uri, + unsigned long bandwidth) +{ + virDomainPtr ddomain = NULL; + char *uri_out = NULL; + char *cookie = NULL; + char *dom_xml = NULL; + int cookielen = 0, ret; + + /* Prepare the migration. + * + * The destination host may return a cookie, or leave cookie as + * NULL. + * + * The destination host MUST set uri_out if uri_in is NULL. + * + * If uri_in is non-NULL, then the destination host may modify + * the URI by setting uri_out. If it does not wish to modify + * the URI, it should leave uri_out as NULL. + */ + + /* In version 2 of the protocol, the prepare step is slightly + * different. We fetch the domain XML of the source domain + * and pass it to Prepare2. + */ + if (!domain->conn->driver->domainDumpXML) { + virLibConnError (domain->conn, VIR_ERR_INTERNAL_ERROR, __FUNCTION__); + return NULL; + } + dom_xml = domain->conn->driver->domainDumpXML (domain, + VIR_DOMAIN_XML_SECURE); + if (!dom_xml) + return NULL; + + ret = dconn->driver->domainMigratePrepare2 + (dconn, &cookie, &cookielen, uri, &uri_out, flags, dname, + bandwidth, dom_xml); + VIR_FREE (dom_xml); + if (ret == -1) + goto done; + + if (uri == NULL && uri_out == NULL) { + virLibConnError (domain->conn, VIR_ERR_INTERNAL_ERROR, + _("domainMigratePrepare2 did not set uri")); + goto done; + } + if (uri_out) + uri = uri_out; /* Did domainMigratePrepare2 change URI? */ + assert (uri != NULL); + + /* Perform the migration. The driver isn't supposed to return + * until the migration is complete. + */ + ret = domain->conn->driver->domainMigratePerform + (domain, cookie, cookielen, uri, flags, dname, bandwidth); + if (ret == -1) + goto done; + + /* In version 2 of the migration protocol, we pass the + * status code from the sender to the destination host, + * so it can do any cleanup if the migration failed. + */ + dname = dname ? dname : domain->name; + ddomain = dconn->driver->domainMigrateFinish2 + (dconn, dname, cookie, cookielen, uri, flags, ret); + + done: + VIR_FREE (uri_out); + VIR_FREE (cookie); + return ddomain; +} + /** * virDomainMigrate: * @domain: a domain object @@ -2930,140 +3070,52 @@ virDomainMigrate (virDomainPtr domain, const char *uri, unsigned long bandwidth) { - virConnectPtr conn; virDomainPtr ddomain = NULL; - char *uri_out = NULL; - char *cookie = NULL; - char *dom_xml = NULL; - int cookielen = 0, ret, version = 0; DEBUG("domain=%p, dconn=%p, flags=%lu, dname=%s, uri=%s, bandwidth=%lu", domain, dconn, flags, NULLSTR(dname), NULLSTR(uri), bandwidth); virResetLastError(); + /* First checkout the source */ if (!VIR_IS_CONNECTED_DOMAIN (domain)) { virLibDomainError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__); return NULL; } - conn = domain->conn; /* Source connection. */ - if (!VIR_IS_CONNECT (dconn)) { - virLibConnError (conn, VIR_ERR_INVALID_CONN, __FUNCTION__); + if (domain->conn->flags & VIR_CONNECT_RO) { + virLibDomainError(domain, VIR_ERR_OPERATION_DENIED, __FUNCTION__); goto error; } - if (domain->conn->flags & VIR_CONNECT_RO) { - virLibDomainError(domain, VIR_ERR_OPERATION_DENIED, __FUNCTION__); + /* Now checkout the destination */ + if (!VIR_IS_CONNECT (dconn)) { + virLibConnError (domain->conn, VIR_ERR_INVALID_CONN, __FUNCTION__); goto error; } if (dconn->flags & VIR_CONNECT_RO) { - /* NB, delibrately report error against source object, not dest here */ - virLibDomainError(domain, VIR_ERR_OPERATION_DENIED, __FUNCTION__); + /* NB, deliberately report error against source object, not dest */ + virLibDomainError (domain, VIR_ERR_OPERATION_DENIED, __FUNCTION__); goto error; } /* Check that migration is supported by both drivers. */ - if (VIR_DRV_SUPPORTS_FEATURE (conn->driver, conn, + if (VIR_DRV_SUPPORTS_FEATURE (domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_V1) && VIR_DRV_SUPPORTS_FEATURE (dconn->driver, dconn, VIR_DRV_FEATURE_MIGRATION_V1)) - version = 1; - else if (VIR_DRV_SUPPORTS_FEATURE (conn->driver, conn, + ddomain = migrate_version_1 (domain, dconn, flags, dname, uri, bandwidth); + else if (VIR_DRV_SUPPORTS_FEATURE (domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_V2) && VIR_DRV_SUPPORTS_FEATURE (dconn->driver, dconn, VIR_DRV_FEATURE_MIGRATION_V2)) - version = 2; + ddomain = migrate_version_2 (domain, dconn, flags, dname, uri, bandwidth); else { - virLibConnError (conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); + virLibConnError (domain->conn, VIR_ERR_NO_SUPPORT, __FUNCTION__); goto error; } - /* Prepare the migration. - * - * The destination host may return a cookie, or leave cookie as - * NULL. - * - * The destination host MUST set uri_out if uri_in is NULL. - * - * If uri_in is non-NULL, then the destination host may modify - * the URI by setting uri_out. If it does not wish to modify - * the URI, it should leave uri_out as NULL. - */ - if (version == 1) { - ret = dconn->driver->domainMigratePrepare - (dconn, &cookie, &cookielen, uri, &uri_out, flags, dname, - bandwidth); - if (ret == -1) goto done; - if (uri == NULL && uri_out == NULL) { - virLibConnError (conn, VIR_ERR_INTERNAL_ERROR, - _("domainMigratePrepare did not set uri")); - goto done; - } - if (uri_out) uri = uri_out; /* Did domainMigratePrepare change URI? */ - - assert (uri != NULL); - } - else /* if (version == 2) */ { - /* In version 2 of the protocol, the prepare step is slightly - * different. We fetch the domain XML of the source domain - * and pass it to Prepare2. - */ - if (!conn->driver->domainDumpXML) { - virLibConnError (conn, VIR_ERR_INTERNAL_ERROR, __FUNCTION__); - goto error; - } - dom_xml = conn->driver->domainDumpXML (domain, - VIR_DOMAIN_XML_SECURE); - - if (!dom_xml) - goto error; + if (ddomain == NULL) + goto error; - ret = dconn->driver->domainMigratePrepare2 - (dconn, &cookie, &cookielen, uri, &uri_out, flags, dname, - bandwidth, dom_xml); - VIR_FREE (dom_xml); - if (ret == -1) goto done; - if (uri == NULL && uri_out == NULL) { - virLibConnError (conn, VIR_ERR_INTERNAL_ERROR, - _("domainMigratePrepare2 did not set uri")); - goto done; - } - if (uri_out) uri = uri_out; /* Did domainMigratePrepare2 change URI? */ - - assert (uri != NULL); - } - - /* Perform the migration. The driver isn't supposed to return - * until the migration is complete. - */ - ret = conn->driver->domainMigratePerform - (domain, cookie, cookielen, uri, flags, dname, bandwidth); - - if (version == 1) { - if (ret == -1) goto done; - /* Get the destination domain and return it or error. - * 'domain' no longer actually exists at this point - * (or so we hope), but we still use the object in memory - * in order to get the name. - */ - dname = dname ? dname : domain->name; - if (dconn->driver->domainMigrateFinish) - ddomain = dconn->driver->domainMigrateFinish - (dconn, dname, cookie, cookielen, uri, flags); - else - ddomain = virDomainLookupByName (dconn, dname); - } else /* if (version == 2) */ { - /* In version 2 of the migration protocol, we pass the - * status code from the sender to the destination host, - * so it can do any cleanup if the migration failed. - */ - dname = dname ? dname : domain->name; - ddomain = dconn->driver->domainMigrateFinish2 - (dconn, dname, cookie, cookielen, uri, flags, ret); - } - - done: - VIR_FREE (uri_out); - VIR_FREE (cookie); return ddomain; error: -- 1.6.0.6

2 2

[libvirt] [PATCH] Fix PCIe FLR detection
by Mark McLoughlin 31 Jul '09

31 Jul '09

PCIe DevCap register is actually 32 bits, not 16 bits. Since FLR is bit 28, we clearly are failing to detect FLR support. Known to fix device reset with some SR-IOV devices. * src/pci.c: fix pciDetectFunctionLevelReset() --- src/pci.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pci.c b/src/pci.c index 4030a14..2dc2e1c 100644 --- a/src/pci.c +++ b/src/pci.c @@ -321,7 +321,7 @@ pciFindCapabilityOffset(pciDevice *dev, unsigned capability) static unsigned pciDetectFunctionLevelReset(pciDevice *dev) { - uint16_t caps; + uint32_t caps; uint8_t pos; /* The PCIe Function Level Reset capability allows @@ -331,7 +331,7 @@ pciDetectFunctionLevelReset(pciDevice *dev) * on SR-IOV NICs at the moment. */ if (dev->pcie_cap_pos) { - caps = pciRead16(dev, dev->pcie_cap_pos + PCI_EXP_DEVCAP); + caps = pciRead32(dev, dev->pcie_cap_pos + PCI_EXP_DEVCAP); if (caps & PCI_EXP_DEVCAP_FLR) { VIR_DEBUG("%s %s: detected PCIe FLR capability", dev->id, dev->name); return 1; -- 1.6.2.5

2 1

[libvirt] PATCH: Re-enable ESX driver on Mingw32
by Daniel P. Berrange 31 Jul '09

31 Jul '09

After finding an RPM of mingw32-curl for Fedora 11, I was able to successfully build the ESX driver on Ming32 with only a couple of tweaks. Daniel commit 8b135962ef026ef3ef1b5c5163b1213eeba9ec36 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Thu Jul 30 16:40:29 2009 +0100 Enable ESX driver build on Mingw32 * autobuild.sh, mingw32-libvirt.spec.in: Enable esx on mingw32 * src/esx/esx_driver.c: Define AI_ADDRCONFIG if not set * src/esx/esx_util.c, src/esx/esx_vi_types.c: Always use %lld & friends, since gnulib guarentees we have these and not the target's own variants diff --git a/autobuild.sh b/autobuild.sh index 239372c..d3934ea 100755 --- a/autobuild.sh +++ b/autobuild.sh @@ -78,7 +78,6 @@ if [ -x /usr/bin/i686-pc-mingw32-gcc ]; then --without-openvz \ --without-one \ --without-phyp \ - --without-esx \ --without-netcf \ --without-libvirtd diff --git a/mingw32-libvirt.spec.in b/mingw32-libvirt.spec.in index 8fd08a6..40a8124 100644 --- a/mingw32-libvirt.spec.in +++ b/mingw32-libvirt.spec.in @@ -54,7 +54,6 @@ MinGW Windows libvirt virtualization library. --without-openvz \ --without-one \ --without-phyp \ - --without-esx \ --without-netcf \ --without-libvirtd make diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index e3d60a5..08d82f9 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -1769,7 +1769,7 @@ esxDomainGetInfo(virDomainPtr domain, virDomainInfoPtr info) for (value = perfMetricIntSeries->value; value != NULL; value = value->_next) { - VIR_DEBUG("value %"PRIi64, value->value); + VIR_DEBUG("value %lld", (long long int)value->value); } } } @@ -2399,8 +2399,8 @@ esxDomainGetSchedulerParameters(virDomainPtr domain, default: ESX_ERROR(domain->conn, VIR_ERR_INTERNAL_ERROR, - "Shares level has unknown value %"PRIi32, - sharesInfo->level); + "Shares level has unknown value %d", + (int)sharesInfo->level); goto failure; } diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c index 5c87ea3..a113fde 100644 --- a/src/esx/esx_util.c +++ b/src/esx/esx_util.c @@ -41,6 +41,10 @@ virReportErrorHelper (conn, VIR_FROM_ESX, code, __FILE__, __FUNCTION__, \ __LINE__, fmt) +/* AI_ADDRCONFIG is missing on some systems. */ +#ifndef AI_ADDRCONFIG +# define AI_ADDRCONFIG 0 +#endif char * @@ -435,12 +439,12 @@ esxUtil_GetConfigLong(virConnectPtr conn, virConfPtr conf, const char *name, int esxUtil_GetConfigBoolean(virConnectPtr conn, virConfPtr conf, - const char *name, int *boolean, int default_, + const char *name, int *boolval, int default_, int optional) { virConfValuePtr value; - *boolean = default_; + *boolval = default_; value = virConfGetValue(conf, name); if (value == NULL) { @@ -465,9 +469,9 @@ esxUtil_GetConfigBoolean(virConnectPtr conn, virConfPtr conf, } if (STRCASEEQ(value->str, "true")) { - *boolean = 1; + *boolval = 1; } else if (STRCASEEQ(value->str, "false")) { - *boolean = 0; + *boolval = 0; } else { ESX_ERROR(conn, VIR_ERR_INTERNAL_ERROR, "Config entry '%s' must represent a boolean value " diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 684b8c7..ab17460 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -962,7 +962,7 @@ esxVI_Int_DeepCopy(virConnectPtr conn, esxVI_Int **dest, esxVI_Int *src) /* esxVI_Int_Serialize */ ESX_VI__TEMPLATE__SERIALIZE_EXTRA(Int, "xsd:int", { - virBufferVSprintf(output, "%"PRIi32, item->value); + virBufferVSprintf(output, "%d", (int)item->value); }); /* esxVI_Int_SerializeList */ @@ -992,7 +992,7 @@ ESX_VI__TEMPLATE__LIST__APPEND(Long); /* esxVI_Long_Serialize */ ESX_VI__TEMPLATE__SERIALIZE_EXTRA(Long, "xsd:long", { - virBufferVSprintf(output, "%"PRIi64, item->value); + virBufferVSprintf(output, "%lld", (long long int)item->value); }); /* esxVI_Long_SerializeList */ -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] PATCH: Fix permissions problem starting QEMU
by Daniel P. Berrange 31 Jul '09

31 Jul '09

There is a minor bug when running QEMU non-root, and having capng enabled. libvirt is unable to write the PID file in /var/run/libvirt/qemu, since its now owned by 'qemu', but libvirtd has dropped all capabilties at this point. The fix is to delay dropping capabilities until after the PID file has been created. We should also be sure to kill the child if writing the PID file fails Daniel commit ce246587178bc6539a3ea6181cdf06ea45878fd3 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Thu Jul 30 14:58:16 2009 +0100 Fix problem writing QEMU pidfile * src/util.c: Don't drop capabilities until after the PID file has been written. Kill off child if writing the PID file fails * src/qemu_driver.c: Remove bogus trailing '/' in state dir diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 9fb8506..26897d3 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -468,7 +468,7 @@ qemudStartup(int privileged) { goto out_of_memory; if (virAsprintf(&qemu_driver->stateDir, - "%s/run/libvirt/qemu/", LOCAL_STATE_DIR) == -1) + "%s/run/libvirt/qemu", LOCAL_STATE_DIR) == -1) goto out_of_memory; } else { uid_t uid = geteuid(); diff --git a/src/util.c b/src/util.c index ee64b28..39aae24 100644 --- a/src/util.c +++ b/src/util.c @@ -513,12 +513,6 @@ __virExec(virConnectPtr conn, if ((hook)(data) != 0) _exit(1); - /* The hook above may need todo something privileged, so - * we delay clearing capabilities until now */ - if ((flags & VIR_EXEC_CLEAR_CAPS) && - virClearCapabilities() < 0) - _exit(1); - /* Daemonize as late as possible, so the parent process can detect * the above errors with wait* */ if (flags & VIR_EXEC_DAEMON) { @@ -543,6 +537,9 @@ __virExec(virConnectPtr conn, if (pid > 0) { if (pidfile && virFileWritePidPath(pidfile,pid)) { + kill(pid, SIGTERM); + usleep(500*1000); + kill(pid, SIGTERM); virReportSystemError(conn, errno, "%s", _("could not write pidfile")); _exit(1); @@ -551,6 +548,12 @@ __virExec(virConnectPtr conn, } } + /* The steps above may need todo something privileged, so + * we delay clearing capabilities until the last minute */ + if ((flags & VIR_EXEC_CLEAR_CAPS) && + virClearCapabilities() < 0) + _exit(1); + if (envp) execve(argv[0], (char **) argv, (char**)envp); else -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 4

[libvirt] PATCH: Disable IPv6 on virtual network bridges
by Daniel P. Berrange 30 Jul '09

30 Jul '09

This is to address: https://bugzilla.redhat.com/show_bug.cgi?id=501934 which allows the guest to DOS the host IPv6 connectivity Daniel commit 763cf06ff76b4ded03a9b577cd8c541729190edc Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Thu Jul 30 16:34:56 2009 +0100 Disable IPv6 on virtual networks If the bridge device is configured to have IPv6 address and accept router advertisments, then a malicious guest can send out bogus advertisments and hijack/DOS host IPv6 connectivity * src/network_driver.c: Set accept_ra=0, disable_ipv6=1, autoconf=0 for IPv6 sysctl on virual network bridge devices diff --git a/src/network_driver.c b/src/network_driver.c index 1683631..eaea454 100644 --- a/src/network_driver.c +++ b/src/network_driver.c @@ -788,6 +788,55 @@ networkEnableIpForwarding(void) return virFileWriteStr("/proc/sys/net/ipv4/ip_forward", "1\n"); } +#define SYSCTL_PATH "/proc/sys" + +static int networkDisableIPV6(virConnectPtr conn, + virNetworkObjPtr network) +{ + char *field = NULL; + int ret = -1; + + if (virAsprintf(&field, SYSCTL_PATH "/net/ipv6/conf/%s/disable_ipv6", network->def->bridge) < 0) { + virReportOOMError(conn); + goto cleanup; + } + + if (virFileWriteStr(field, "1") < 0) { + virReportSystemError(conn, errno, + _("cannot enable %s"), field); + goto cleanup; + } + VIR_FREE(field); + + if (virAsprintf(&field, SYSCTL_PATH "/net/ipv6/conf/%s/accept_ra", network->def->bridge) < 0) { + virReportOOMError(conn); + goto cleanup; + } + + if (virFileWriteStr(field, "0") < 0) { + virReportSystemError(conn, errno, + _("cannot disable %s"), field); + goto cleanup; + } + VIR_FREE(field); + + if (virAsprintf(&field, SYSCTL_PATH "/net/ipv6/conf/%s/autoconf", network->def->bridge) < 0) { + virReportOOMError(conn); + goto cleanup; + } + + if (virFileWriteStr(field, "1") < 0) { + virReportSystemError(conn, errno, + _("cannot enable %s"), field); + goto cleanup; + } + + ret = 0; +cleanup: + VIR_FREE(field); + return ret; +} + static int networkStartNetworkDaemon(virConnectPtr conn, struct network_driver *driver, virNetworkObjPtr network) { @@ -806,6 +855,9 @@ static int networkStartNetworkDaemon(virConnectPtr conn, return -1; } + if (networkDisableIPV6(conn, network) < 0) + goto err_delbr; + if (brSetForwardDelay(driver->brctl, network->def->bridge, network->def->delay) < 0) goto err_delbr; -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 4

[libvirt] [PATCH] BZ481602: Attempted to reproduce the bug led to issues around type mapping. They are resolved, and the code from the bug runs aginst hte test driver. Once published I will have the submitter reproduce it.
by Bryan Kearney 30 Jul '09

30 Jul '09

--- src/main/java/org/libvirt/Domain.java | 4 +--- src/main/java/org/libvirt/SchedLongParameter.java | 2 +- src/main/java/org/libvirt/SchedParameter.java | 2 ++ src/main/java/org/libvirt/SchedUintParameter.java | 2 +- src/main/java/org/libvirt/jna/Libvirt.java | 2 +- src/test/java/test.java | 8 ++++++++ 6 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/libvirt/Domain.java b/src/main/java/org/libvirt/Domain.java index a9a6b25..a7b49ee 100644 --- a/src/main/java/org/libvirt/Domain.java +++ b/src/main/java/org/libvirt/Domain.java @@ -607,13 +607,11 @@ public class Domain { * @throws LibvirtException */ public void setSchedulerParameters(SchedParameter[] params) throws LibvirtException { - IntByReference nParams = new IntByReference(); - nParams.setValue(params.length); virSchedParameter[] input = new virSchedParameter[params.length]; for (int x = 0; x < params.length; x++) { input[x] = SchedParameter.toNative(params[x]); } - libvirt.virDomainSetSchedulerParameters(VDP, input, nParams); + libvirt.virDomainSetSchedulerParameters(VDP, input, params.length); processError(); } diff --git a/src/main/java/org/libvirt/SchedLongParameter.java b/src/main/java/org/libvirt/SchedLongParameter.java index 50628b0..7999777 100644 --- a/src/main/java/org/libvirt/SchedLongParameter.java +++ b/src/main/java/org/libvirt/SchedLongParameter.java @@ -21,7 +21,7 @@ public final class SchedLongParameter extends SchedParameter { } public int getType() { - return 2; + return 3; } public String getTypeAsString() { diff --git a/src/main/java/org/libvirt/SchedParameter.java b/src/main/java/org/libvirt/SchedParameter.java index 92b3547..370b0da 100644 --- a/src/main/java/org/libvirt/SchedParameter.java +++ b/src/main/java/org/libvirt/SchedParameter.java @@ -4,6 +4,7 @@ import java.util.Arrays; import org.libvirt.jna.Libvirt; import org.libvirt.jna.virSchedParameter; +import org.libvirt.jna.virSchedParameterValue; import com.sun.jna.Native; @@ -43,6 +44,7 @@ public abstract class SchedParameter { public static virSchedParameter toNative(SchedParameter param) { virSchedParameter returnValue = new virSchedParameter(); + returnValue.value = new virSchedParameterValue() ; returnValue.field = Arrays.copyOf(param.field.getBytes(), Libvirt.VIR_DOMAIN_SCHED_FIELD_LENGTH); returnValue.type = param.getType(); switch (param.getType()) { diff --git a/src/main/java/org/libvirt/SchedUintParameter.java b/src/main/java/org/libvirt/SchedUintParameter.java index 1b96758..9305579 100644 --- a/src/main/java/org/libvirt/SchedUintParameter.java +++ b/src/main/java/org/libvirt/SchedUintParameter.java @@ -22,7 +22,7 @@ public final class SchedUintParameter extends SchedParameter { } public int getType() { - return 3; + return 2; } public String getTypeAsString() { diff --git a/src/main/java/org/libvirt/jna/Libvirt.java b/src/main/java/org/libvirt/jna/Libvirt.java index 62f7ba3..0b30656 100644 --- a/src/main/java/org/libvirt/jna/Libvirt.java +++ b/src/main/java/org/libvirt/jna/Libvirt.java @@ -107,7 +107,7 @@ public interface Libvirt extends Library { public int virDomainSetAutostart(DomainPointer virDomainPtr, int autoStart); public int virDomainSetMaxMemory(DomainPointer virDomainPtr, NativeLong maxMemory); public int virDomainSetMemory(DomainPointer virDomainPtr, NativeLong maxMemory); - public int virDomainSetSchedulerParameters(DomainPointer virDomainPtr, virSchedParameter[] params, IntByReference nparams); + public int virDomainSetSchedulerParameters(DomainPointer virDomainPtr, virSchedParameter[] params, int nparams); public int virDomainSetVcpus(DomainPointer virDomainPtr, int nvcpus); public int virDomainShutdown(DomainPointer virDomainPtr); public int virDomainSuspend(DomainPointer virDomainPtr); diff --git a/src/test/java/test.java b/src/test/java/test.java index 9427cc5..be12d5e 100644 --- a/src/test/java/test.java +++ b/src/test/java/test.java @@ -245,6 +245,14 @@ public class test { for(SchedParameter c: testDomain.getSchedulerParameters()){ System.out.println(c.getTypeAsString() +":"+ c.field +":"+ c.getValueAsString()); } + + // test setting a scheduled parameter + SchedUintParameter[] pars = new SchedUintParameter[1]; + pars[0] = new SchedUintParameter(); + pars[0].field = "weight"; + pars[0].value = 100; + testDomain.setSchedulerParameters(pars); + System.out.println("virDomainGetUUID:" + testDomain.getUUID()); for(int c: testDomain.getUUID()) System.out.print(String.format("%02x", c)); -- 1.6.0.6

1 0

[libvirt] Pre-0.7.0 release for testing
by Daniel Veillard 30 Jul '09

30 Jul '09

Considering the large amount of new code and features expected for 0.7.0 at the end of the week, I made a pre-release at ftp://libvirt.org/libvirt/libvirt-0.7.0-0.1.gitf055724.tar.gz if people have time to test and report, that would be great ! I expect to make the actual release this thursday, unless there is too many issues in which case I would postpone to beginning of next week (or whenever main problems get fixed...) thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 4

[libvirt] Fix -Werror build error regarding to '#ifdef IFF_VNET_HDR'
by Maximilian Wilhelm 30 Jul '09

30 Jul '09

Hi! Our build bot found a build error when building libVirt with -Werror introduced in b4f62abbf1191c8fbab3306b4bf2f2567e18067f kvm/virtio: Set IFF_VNET_HDR when setting up tap fds The attached patch kind of fixes the build error but I'm not sure, if this is the final solution for this problem, though... Ciao Max -- The real problem with C++ for kernel modules is: the language just sucks. -- Linus Torvalds

2 3

[libvirt] [PATCH] Drop the leading lib from libvirt. Based on testing by thomas@scripty.at this is a better way to load the libarary
by Bryan Kearney 30 Jul '09

30 Jul '09

--- src/main/java/org/libvirt/jna/Libvirt.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/main/java/org/libvirt/jna/Libvirt.java b/src/main/java/org/libvirt/jna/Libvirt.java index 33914ac..62f7ba3 100644 --- a/src/main/java/org/libvirt/jna/Libvirt.java +++ b/src/main/java/org/libvirt/jna/Libvirt.java @@ -20,7 +20,7 @@ public interface Libvirt extends Library { public int authCallback(virConnectCredential cred, int ncred, Pointer cbdata); } - Libvirt INSTANCE = (Libvirt) Native.loadLibrary("libvirt", Libvirt.class); + Libvirt INSTANCE = (Libvirt) Native.loadLibrary("virt", Libvirt.class); // Constants we need public static int VIR_UUID_BUFLEN = 16; -- 1.6.0.6

3 2

[libvirt] RFC: libvirt java bindings based on JNA
by Bryan Kearney 30 Jul '09

30 Jul '09

I would like to get some comments on an initial cut of the java bindings on top of JNA[1]. They are not 100% complete (see below), but they are good enough to be criticized. In addition, if there are features additions to the API which people are interested in, I would appreciate the feedback on that. JNA is a java implementation of the Foreign Function Interface [2]. The main benefit is that it removes the need for all the nasty C glue code. What replaces it is pure java mapping files. If you look in the org.libvirt.jna package in the code, you will see that the 2928 lines of jni code have been replaced by 427 lines of java code. To be fair, some of the business logic from the C code is now in the org.libvirt package... but you get the point. The original java API has remained the same. The open issues with the code are: 1) Authorization callback has not been tested. 2) GetUUID is not returning the correct int array. 3) Find by UUID is not working These all are mapping issues to be worked out. The rest of the code should be working, but I would appreciate it being exercised. The main drawback to this approach is that it requires the use of java 1.6. I looked on EPEL, F10, and F11.. and java 1.6 and the JNA jar file are available so I did not believe this was an issue. I will send a patch stream to the list, but you can also get the code via an SRPM [3] or via github [4]. -- bk [1] https://jna.dev.java.net/ [2] http://en.wikipedia.org/wiki/Foreign_function_interface [3] http://bkearney.fedorapeople.org/libvirt-java-0.3.0pre-1.fc10.src.rpm [4] http://github.com/bkearney/libvirt-java/tree/jna

3 11

[libvirt] PATCH: Always start dnsmasq to provide DNS
by Daniel P. Berrange 30 Jul '09

30 Jul '09

Currently we only start dnsmasq if DHCP ranges are configured. https://bugzilla.redhat.com/show_bug.cgi?id=508965 points out that this prevents use of DNS in guests using static IP config. Thus this patch makes us always start dnsmasq, regardless of DHCP config if we have an IP addr configured. There is no need for the --no-dhcp-interface= that BZ mentions, since that's just to allow you to restrict which interfaces dnsmasq does DHCP on - we've already restricted it to just out interface, and leaving out the DHCP ranges disables its DHCP server for every interface Regards, Daniel commit deb71927a3551b3a1554351ef098644aec978a09 Author: Daniel P. Berrange <berrange(a)redhat.com> Date: Thu Jul 30 14:52:31 2009 +0100 Allow dnsmasq to provide DNS without DHCP * src/network_driver.c: Always start dnsmasq to allow it to provide DNS, even if no DHCP ranges are enabled diff --git a/src/network_driver.c b/src/network_driver.c index 9621782..1683631 100644 --- a/src/network_driver.c +++ b/src/network_driver.c @@ -136,8 +136,9 @@ networkFindActiveConfigs(struct network_driver *driver) { brHasBridge(driver->brctl, obj->def->bridge) == 0) { obj->active = 1; - /* Finally try and read dnsmasq pid if any DHCP ranges are set */ - if (obj->def->nranges && + /* Finally try and read dnsmasq pid if any */ + if ((obj->def->ipAddress || + obj->def->nranges) && virFileReadPid(NETWORK_PID_DIR, obj->def->name, &obj->dnsmasqPid) == 0) { @@ -844,7 +845,8 @@ static int networkStartNetworkDaemon(virConnectPtr conn, goto err_delbr2; } - if (network->def->nranges && + if ((network->def->ipAddress || + network->def->nranges) && dhcpStartDhcpDaemon(conn, network) < 0) goto err_delbr2; -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH] Remove MAX_TAP_ID, take 3
by Aron Griffis 30 Jul '09

30 Jul '09

This is a resend of take 2 to fix formatting problems in the patch. No other changes. As far as I can tell, there's no reason to format the device string in brAddTap(). Delegate the job to TUNSETIFF, thereby removing the loop and the MAX_TAP_ID artificial limit. This patch allows me to get 421 guests running before hitting other limits. Signed-off-by: Aron Griffis <aron.griffis(a)hp.com> diff --git a/src/bridge.c b/src/bridge.c index 0509afd..ec37192 100644 --- a/src/bridge.c +++ b/src/bridge.c @@ -49,8 +49,6 @@ #include "util.h" #include "logging.h" -#define MAX_TAP_ID 256 - #define JIFFIES_TO_MS(j) (((j)*1000)/HZ) #define MS_TO_JIFFIES(ms) (((ms)*HZ)/1000) @@ -466,76 +464,52 @@ brAddTap(brControl *ctl, int vnet_hdr, int *tapfd) { - int id, subst, fd; + int fd, len; + struct ifreq ifr = {0}; if (!ctl || !ctl->fd || !bridge || !ifname) return EINVAL; - subst = id = 0; - - if (strstr(*ifname, "%d")) - subst = 1; - if ((fd = open("/dev/net/tun", O_RDWR)) < 0) return errno; - if (vnet_hdr) - vnet_hdr = brProbeVnetHdr(fd); + ifr.ifr_flags = IFF_TAP|IFF_NO_PI; - do { - struct ifreq try; - int len; +#ifdef IFF_VNET_HDR + if (vnet_hdr && brProbeVnetHdr(fd)) + ifr.ifr_flags |= IFF_VNET_HDR; +#endif - memset(&try, 0, sizeof(struct ifreq)); + strncpy(ifr.ifr_name, *ifname, IFNAMSIZ-1); - try.ifr_flags = IFF_TAP|IFF_NO_PI; + if (ioctl(fd, TUNSETIFF, &ifr) < 0) + goto error; -#ifdef IFF_VNET_HDR - if (vnet_hdr) - try.ifr_flags |= IFF_VNET_HDR; -#endif + len = strlen(ifr.ifr_name); + if (len >= BR_IFNAME_MAXLEN - 1) { + errno = EINVAL; + goto error; + } - if (subst) { - len = snprintf(try.ifr_name, BR_IFNAME_MAXLEN, *ifname, id); - if (len >= BR_IFNAME_MAXLEN) { - errno = EADDRINUSE; - goto error; - } - } else { - len = strlen(*ifname); - if (len >= BR_IFNAME_MAXLEN - 1) { - errno = EINVAL; - goto error; - } - - strncpy(try.ifr_name, *ifname, len); - try.ifr_name[len] = '\0'; - } - - if (ioctl(fd, TUNSETIFF, &try) == 0) { - /* We need to set the interface MTU before adding it - * to the bridge, because the bridge will have its - * MTU adjusted automatically when we add the new interface. - */ - if ((errno = brSetInterfaceMtu(ctl, bridge, try.ifr_name))) - goto error; - if ((errno = brAddInterface(ctl, bridge, try.ifr_name))) - goto error; - if ((errno = brSetInterfaceUp(ctl, try.ifr_name, 1))) - goto error; - if (!tapfd && - (errno = ioctl(fd, TUNSETPERSIST, 1))) - goto error; - VIR_FREE(*ifname); - if (!(*ifname = strdup(try.ifr_name))) - goto error; - if (tapfd) - *tapfd = fd; - return 0; - } - - id++; - } while (subst && id <= MAX_TAP_ID); + /* We need to set the interface MTU before adding it + * to the bridge, because the bridge will have its + * MTU adjusted automatically when we add the new interface. + */ + if ((errno = brSetInterfaceMtu(ctl, bridge, ifr.ifr_name))) + goto error; + if ((errno = brAddInterface(ctl, bridge, ifr.ifr_name))) + goto error; + if ((errno = brSetInterfaceUp(ctl, ifr.ifr_name, 1))) + goto error; + if (!tapfd && + (errno = ioctl(fd, TUNSETPERSIST, 1))) + goto error; + VIR_FREE(*ifname); + if (!(*ifname = strdup(ifr.ifr_name))) + goto error; + if (tapfd) + *tapfd = fd; + return 0; error: close(fd);

4 9

[libvirt] VM creation failed : Permission denied : bind(unix:/var/run/libvirt/qemu//VM.monitor)
by Pierre-Gilles Mialon 30 Jul '09

30 Jul '09

I use Ovirt under Fedora 11 with the latest developpement package and the VM creation failed with : bind(unix:/var/run/libvirt/qemu//VM-4.monitor): Permission denied See the logs : On the Ovirt Node ==> /var/log/messages <== Jul 29 20:43:37 node62 kernel: device vnet0 entered promiscuous mode Jul 29 20:43:37 node62 kernel: breth0: port 2(vnet0) entering learning state Jul 29 20:43:37 node62 libvirtd: 20:43:37.873: info : qemudDispatchSignalEvent:370 : Received unexpected signal 17 Jul 29 20:43:37 node62 libvirtd: 20:43:37.877: info : qemudDispatchSignalEvent:370 : Received unexpected signal 17 Jul 29 20:43:37 node62 kernel: breth0: port 2(vnet0) entering disabled state Jul 29 20:43:37 node62 kernel: device vnet0 left promiscuous mode Jul 29 20:43:37 node62 kernel: breth0: port 2(vnet0) entering disabled state Jul 29 20:43:37 node62 libvirtd: 20:43:37.977: error : qemudReadLogOutput:816 : internal error Process exited while reading console log output Jul 29 20:43:37 node62 libvirtd: 20:43:37.977: error : qemudWaitForMonitor:1103 : internal error unable to start guest: bind(unix:/var/run/libvirt/qemu//VM-4.monitor): Permission denied#012qemu: could not open monitor device 'unix:/var/run/libvirt/qemu//VM-4.monitor,server,nowait'#012 Jul 29 20:43:38 node62 libvirtd: 20:43:38.073: error : qemudDomainLookupByUUID:2644 : Domain not found: no domain with matching uuid '492f836f-5123-e185-39c2-09c5dd43a7f6' Jul 29 20:43:38 node62 libvirt-qpid: Error: virDomainLookupByUUIDString Subsystem qemu: Domain not found: no domain with matching uuid '492f836f-5123- e185-39c2-09c5dd43a7f6' in NodeWrap.cpp:syncDomains:241 code: 42 ==> /var/log/libvirt/qemu/VM-4.log <== LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin HOME=/root USER=root LOGNAME=root /usr/bin/qemu-kvm -S -M pc -m 256 -smp 1 -name VM-4 -uuid 492f836f-5123- e185-39c2-09c5dd43a7f6 -monitor unix:/var/run/libvirt/qemu//VM-4.monitor,server,nowait -boot n -net nic,macaddr=00:16:3e:10:de:fe,vlan=0,name=nic.0 -net tap,fd=18,vlan=0,name=tap.0 -serial pty -parallel none -usb -vnc 0.0.0.0:0 - vga cirrus bind(unix:/var/run/libvirt/qemu//VM-4.monitor): Permission denied qemu: could not open monitor device 'unix:/var/run/libvirt/qemu//VM-4.monitor,server,nowait' ==> # rpm -qa | grep libvirt <== libvirt-0.7.0-0.2.gitf055724.fc11.x86_64 libvirt-python-0.7.0-0.2.gitf055724.fc11.x86_64 libvirt-client-0.7.0-0.2.gitf055724.fc11.x86_64 libvirt-qpid-0.2.17-0.fc11.x86_64 Regards -- Pierre-Gilles Mialon Linagora :: http://www.linagora.com Responsable hébergement :: Head of Hosting services pmialon(a)linagora.com :: +33.1 58 18 65 46

5 11

[libvirt] VMware ESX: Scheduler documentation and cleanup
by Matthias Bolte 30 Jul '09

30 Jul '09

Add some documentation about the CPU scheduler parameters and remove some old, unnecessary compensation code, since virsh uses the proposed parameter types now. Documentation in HTML form will be added soon. Matthias

2 1